For the PHY enable/disable signalling to propagate
between Dispaly and PHY, DDI clocks need to be running when
enabling the PHY.
Signed-off-by: Vandita Kulkarni
---
drivers/gpu/drm/i915/display/icl_dsi.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/
MIPI DSI transcoder cannot be in video mode to support any of the
display C states.
Signed-off-by: Vandita Kulkarni
---
drivers/gpu/drm/i915/display/intel_display_power.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display_power.c
b/d
Update ADL_P device info to support DSI0, DSI1
Signed-off-by: Vandita Kulkarni
---
drivers/gpu/drm/i915/i915_pci.c | 31 ---
1 file changed, 28 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_pci.c b/drivers/gpu/drm/i915/i915_pci.c
index 169837de
Fixes: f87c46c43175 ("drm/i915/dsi/xelpd: Add WA to program LP to HS wakeup
guardband")
Signed-off-by: Vandita Kulkarni
---
drivers/gpu/drm/i915/display/icl_dsi.c | 2 +-
drivers/gpu/drm/i915/i915_reg.h| 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/dr
Vandita Kulkarni (4):
drm/i915/dsi/xelpd: Fix the bit mask for wakeup GB
drm/i915/dsi/xelpd: Add DSI transcoder support
drm/i915/dsi/xelpd: Disable DC states in Video mode
drm/i915/dsi: Ungate clock before enabling the phy
drivers/gpu/drm/i915/display/icl_dsi.c| 10 +++---
.../drm
== Series Details ==
Series: drm/i915/selftests: Wait request to finish
URL : https://patchwork.freedesktop.org/series/95926/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10750 -> Patchwork_21363
Summary
---
**FAILU
== Series Details ==
Series: drm/i915/selftests: Wait request to finish
URL : https://patchwork.freedesktop.org/series/95926/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
cc4b6b8dafe9 drm/i915/selftests: Wait request to finish
-:23: CHECK:SPACING: spaces preferred around that
Caller of function igt_gpu_fill_dw assumes when this function
returns, the gpu command to fill dword is already finished.
Caller usually checks the GPU filling result immediately, see
the usage in function __igt_write_huge. If there is no wait,
when function igt_gpu_fill_dw returns, the GPU command
== Series Details ==
Series: finish/rebase fbdev pin refactor.
URL : https://patchwork.freedesktop.org/series/95925/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10750_full -> Patchwork_21362_full
Summary
---
**FAIL
== Series Details ==
Series: series starting with [1/2] drm/i915: Declare .(de)gamma_lut_tests for
icl+ (rev2)
URL : https://patchwork.freedesktop.org/series/95841/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10750_full -> Patchwork_21361_full
==
On Fri, Oct 15, 2021 at 5:17 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> Let's add lpt_pch_disable() as the counterpart to
> lpt_pch_enable().
>
> Note that unlike the ilk+ code the fdi_link_train()
> and fdi_disable() calls are still left directly in
> intel_crt.c. If we wanted to move t
On Fri, Oct 15, 2021 at 5:17 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> Reanme intel_ddi_fdi_post_disable() to hsw_fdi_disable() and
> relocate it next to all the other code dealing with FDI_RX.
> intel_ddi.c has now been cleansed of FDI_RX.
>
> In order to avoid exposing intel_disable_d
On Fri, Oct 15, 2021 at 5:17 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> Hoover the remaining open coded PCH modeset sequence bits
> out from ilk_crtc_disable(). Somewhat annoyingly the
> enable vs. disable is a bit asymmetric so we need two
> functions for the disable case.
>
> Cc: Dave
On Fri, Oct 15, 2021 at 5:17 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> Move the lpt_get_iclkip() call from hsw_crt_get_config()
> since that's where we have the lpt_program_iclkip() call
> as well.
>
> Tehcnically this isn't perhaps quite right since iCLKIP
> is providing the CRT dotclo
== Series Details ==
Series: finish/rebase fbdev pin refactor.
URL : https://patchwork.freedesktop.org/series/95925/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10750 -> Patchwork_21362
Summary
---
**SUCCESS**
N
On Fri, Oct 15, 2021 at 5:16 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> Pull the ilk+ PCH state readout into its own function and relocate
> to the appropriate file.
>
> The clock readout parts are perhaps a bit iffy since we depend
> on the gmch DPLL readout code. But we can think about
On Fri, Oct 15, 2021 at 5:16 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> Nuke the hsw_get_ddi_port_state() eyesore by putting the
> readout code into intel_pch_display.c, and calling it directly
> from hsw_crt_get_config().
>
> Cc: Dave Airlie
> Cc: Jani Nikula
> Signed-off-by: Ville Sy
== Series Details ==
Series: finish/rebase fbdev pin refactor.
URL : https://patchwork.freedesktop.org/series/95925/
State : warning
== Summary ==
$ dim sparse --fast origin/drm-tip
Sparse version: v0.6.2
Fast mode used, each commit won't be checked separately.
-
+drivers/gpu/drm/i915/display/
== Series Details ==
Series: finish/rebase fbdev pin refactor.
URL : https://patchwork.freedesktop.org/series/95925/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f1c4731db194 drm/i915/display: refactor fbdev pin/unpin out into functions.
-:38: WARNING:BRACES: braces {} are not
On Fri, Oct 15, 2021 at 5:16 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> Use the clean "atomic_state+crtc" approach of passing
> arguments to the top level PCH modeset code.
>
> And while at it we can also just pass the whole crtc to
> ilk_disable_pch_transcoder().
Some minor whitespace:
On Fri, Oct 15, 2021 at 5:16 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> Move the PCH refclk stuff (including all the LPT/WPT
> iCLKIP/CLKOUT_DP things) to its own file.
>
> We also suck in the mPHY programming from intel_fdi.c
> since we're the only caller.
The title of the patch has a
On Fri, Oct 15, 2021 at 5:16 PM Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> Start moving the code for PCH modeset sequence/etc. to
> its own file.
>
> Still not sure about the file name though...
Name is good enough for now, there aren't a lot of great names, no
point getting stuck on it.
On Thu, 14 Oct 2021 at 19:09, Ville Syrjala
wrote:
>
> From: Ville Syrjälä
>
> Fix a pile of regression on older machines which just oops the driver
> on load.
>
For all 4:
Reviewed-by: Dave Airlie
though it would be nice if the clflushes has more justifications on
initial patch submission/re
From: Dave Airlie
The uses_fence isn't used.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/display/intel_fb_pin.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_fb_pin.c
b/drivers/gpu/drm/i915/display/intel_fb_pin.c
index 0beb0aa
From: Dave Airlie
These aren't used since refactoring.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/display/intel_display.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/intel_display.c
b/drivers/gpu/drm/i915/display/intel_display.c
index ff598b6cd9
From: Dave Airlie
This moves the fbdev pin code over and moves the internal
interfaces to static.
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/display/intel_fb_pin.c | 37 +++--
drivers/gpu/drm/i915/display/intel_fb_pin.h | 15 -
drivers/gpu/drm/i915/display/inte
Jani had some extra review for the refactor patch. Address that.
Dave.
From: Dave Airlie
This just cleans up the calls a bit.
v2: fix unpin in vaddr fail path (Jani)
Signed-off-by: Dave Airlie
---
drivers/gpu/drm/i915/display/intel_fbdev.c | 67 +-
1 file changed, 41 insertions(+), 26 deletions(-)
diff --git a/drivers/gpu/drm/i915/display/int
== Series Details ==
Series: series starting with [1/2] drm/i915: Declare .(de)gamma_lut_tests for
icl+ (rev2)
URL : https://patchwork.freedesktop.org/series/95841/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10750 -> Patchwork_21361
Hi Sujaritha,
[...]
> > +void intel_gt_sysfs_unregister(struct intel_gt *gt)
> > +{
> > +}
>
> Is there a reason for this function to not be populated ?
yes, there is, indeed, something missing here. There has been a
fix bout this floating around from Chris about sysfs_gt kobjects.
I will chec
On Wed, Oct 13, 2021 at 08:36:01PM +0200, Nirmoy Das wrote:
> Debugfs APIs returns encoded error on failure so use
> debugfs_lookup() instead of checking for NULL.
The commit message no longer matches up with the patch itself
(debugfs_lookup() isn't called).
My suggestion would be something like:
== Series Details ==
Series: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi (rev3)
URL : https://patchwork.freedesktop.org/series/95880/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_10744_full -> Patchwork_21360_full
==
== Series Details ==
Series: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi (rev3)
URL : https://patchwork.freedesktop.org/series/95880/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_10744 -> Patchwork_21360
== Series Details ==
Series: replace drm_detect_hdmi_monitor() with drm_display_info.is_hdmi (rev3)
URL : https://patchwork.freedesktop.org/series/95880/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
bcbb68918d43 gpu/drm: make drm_add_edid_modes() consistent when updating
conn
Thank you, we will handle that.
Please mind our weekend.
Thanks
Tomas
> -Original Message-
> From: Pavel Machek
> Sent: Sunday, October 17, 2021 10:24
> To: kernel list ; Lubart, Vitaly
> ; Winkler, Tomas ;
> Ceraolo Spurio, Daniele ;
> jani.nik...@linux.intel.com; joonas.lahti...@linu
Hi!
Extended Cc list. Should I attempt to prepare a patch?
Best regards,
Pavel
On Thu 2021-10-14 12:53:34, Pavel Machek wrote:
>
> CONFIG_INTEL_MEI_PXP:
>
> MEI Support for PXP Services on Intel platforms.
>
> Enables the ME FW services
36 matches
Mail list logo
