[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/uapi: Add comment clarifying purpose of I915_TILING_* values

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915/uapi: Add comment clarifying purpose of I915_TILING_* values URL : https://patchwork.freedesktop.org/series/95743/ State : success == Summary == CI Bug Log - changes from CI_DRM_10727_full -> Patchwork_21321_full ===

Re: [Intel-gfx] [PATCH 07/11] drm/i915/xehp: Determine which tile raised an interrupt

2021-10-12 Thread Andi Shyti
Hi Matt and Paulo, > The first step of interrupt handling is to read a tile0 register that > tells us in which tile the interrupt happened; we can then we read the ... we can then read the... Andi

Re: [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation

2021-10-12 Thread Matt Roper
On Tue, Oct 12, 2021 at 06:00:46PM -0700, José Roberto de Souza wrote: > This memory frequency calculated is only used to check if it is zero, > what is not useful as it will never actually be zero. > > Also the calculation is wrong, we should be checking other bit to > select the appropriate freq

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats

2021-10-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats URL : https://patchwork.freedesktop.org/series/95750/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10728 -> Patchwork_21325 ===

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats

2021-10-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats URL : https://patchwork.freedesktop.org/series/95750/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked se

Re: [Intel-gfx] [PATCH 20/26] drm/i915/guc: Implement no mid batch preemption for multi-lrc

2021-10-12 Thread Matthew Brost
On Mon, Oct 11, 2021 at 04:32:03PM -0700, John Harrison wrote: > On 10/4/2021 15:06, Matthew Brost wrote: > > For some users of multi-lrc, e.g. split frame, it isn't safe to preempt > > mid BB. To safely enable preemption at the BB boundary, a handshake > > between to parent and child is needed. Th

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats

2021-10-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/pmu: Add a name to the execlists stats URL : https://patchwork.freedesktop.org/series/95750/ State : warning == Summary == $ dim checkpatch origin/drm-tip d9aca49cd0a6 drm/i915/pmu: Add a name to the execlists stats 1fa082d603c9

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove memory frequency calculation (rev2)

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Remove memory frequency calculation (rev2) URL : https://patchwork.freedesktop.org/series/95748/ State : success == Summary == CI Bug Log - changes from CI_DRM_10728 -> Patchwork_21324 Summary ---

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove memory frequency calculation (rev2)

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Remove memory frequency calculation (rev2) URL : https://patchwork.freedesktop.org/series/95748/ State : warning == Summary == $ dim checkpatch origin/drm-tip e86da89208d6 drm/i915: Remove memory frequency calculation -:23: WARNING:UNKNOWN_COMMIT_ID: Unkn

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove memory frequency calculation

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Remove memory frequency calculation URL : https://patchwork.freedesktop.org/series/95748/ State : success == Summary == CI Bug Log - changes from CI_DRM_10728 -> Patchwork_21323 Summary --- **SU

[Intel-gfx] [PATCH 2/2] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

2021-10-12 Thread Umesh Nerlige Ramappa
With GuC handling scheduling, i915 is not aware of the time that a context is scheduled in and out of the engine. Since i915 pmu relies on this info to provide engine busyness to the user, GuC shares this info with i915 for all engines using shared memory. For each engine, this info contains: - to

[Intel-gfx] [PATCH 1/2] drm/i915/pmu: Add a name to the execlists stats

2021-10-12 Thread Umesh Nerlige Ramappa
In preparation for GuC pmu stats, add a name to the execlists stats structure so that it can be differentiated from the GuC stats. Signed-off-by: Umesh Nerlige Ramappa --- drivers/gpu/drm/i915/gt/intel_engine_cs.c| 14 +++--- drivers/gpu/drm/i915/gt/intel_engine_stats.h | 33 +++-- d

Re: [Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation

2021-10-12 Thread Souza, Jose
On Tue, 2021-10-12 at 18:00 -0700, José Roberto de Souza wrote: > This memory frequency calculated is only used to check if it is zero, > what is not useful as it will never actually be zero. > > Also the calculation is wrong, we should be checking other bit to > select the appropriate frequency m

[Intel-gfx] [PATCH v2] drm/i915: Remove memory frequency calculation

2021-10-12 Thread José Roberto de Souza
This memory frequency calculated is only used to check if it is zero, what is not useful as it will never actually be zero. Also the calculation is wrong, we should be checking other bit to select the appropriate frequency multiplier while this code is stuck with a fixed multiplier. So here dropp

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove memory frequency calculation

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Remove memory frequency calculation URL : https://patchwork.freedesktop.org/series/95748/ State : warning == Summary == $ dim checkpatch origin/drm-tip 2fbf85e7741f drm/i915: Remove memory frequency calculation -:19: WARNING:UNKNOWN_COMMIT_ID: Unknown com

Re: [Intel-gfx] [PATCH] drm/i915: Remove memory frequency calculation

2021-10-12 Thread Matt Roper
On Tue, Oct 12, 2021 at 05:24:55PM -0700, José Roberto de Souza wrote: > This memory frequency calculated is only used to check if it is zero, > what is not useful as it will never actually be zero. > > Also the calculation is wrong, we should be checking other bit to > select the appropriate freq

Re: [Intel-gfx] [PATCH 21/26] drm/i915: Multi-BB execbuf

2021-10-12 Thread Matthew Brost
On Tue, Oct 12, 2021 at 02:22:41PM -0700, John Harrison wrote: > On 10/4/2021 15:06, Matthew Brost wrote: > > Allow multiple batch buffers to be submitted in a single execbuf IOCTL > > after a context has been configured with the 'set_parallel' extension. > > The number batches is implicit based on

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: move remaining debugfs interfaces into gt (rev12)

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev12) URL : https://patchwork.freedesktop.org/series/75333/ State : success == Summary == CI Bug Log - changes from CI_DRM_10728 -> Patchwork_21322 Summar

Re: [Intel-gfx] [PATCH 23/26] drm/i915: Make request conflict tracking understand parallel submits

2021-10-12 Thread Matthew Brost
On Tue, Oct 12, 2021 at 03:08:05PM -0700, John Harrison wrote: > On 10/4/2021 15:06, Matthew Brost wrote: > > If an object in the excl or shared slot is a composite fence from a > > parallel submit and the current request in the conflict tracking is from > > the same parallel context there is no ne

Re: [Intel-gfx] [PATCH 22/26] drm/i915/guc: Handle errors in multi-lrc requests

2021-10-12 Thread Matthew Brost
On Tue, Oct 12, 2021 at 02:56:36PM -0700, John Harrison wrote: > On 10/4/2021 15:06, Matthew Brost wrote: > > If an error occurs in the front end when multi-lrc requests are getting > > generated we need to skip these in the backend but we still need to > > emit the breadcrumbs seqno. An issues ari

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Parallel submission aka multi-bb execbuf (rev4)

2021-10-12 Thread Matthew Brost
On Tue, Oct 12, 2021 at 03:15:00PM -0700, John Harrison wrote: > On 10/4/2021 15:21, Patchwork wrote: > > == Series Details == > > > > Series: Parallel submission aka multi-bb execbuf (rev4) > > URL : https://patchwork.freedesktop.org/series/92789/ > > State : warning > > > > == Summary == > >

[Intel-gfx] [PATCH] drm/i915: Remove memory frequency calculation

2021-10-12 Thread José Roberto de Souza
This memory frequency calculated is only used to check if it is zero, what is not useful as it will never actually be zero. Also the calculation is wrong, we should be checking other bit to select the appropriate frequency multiplier while this code is stuck with a fixed multiplier. So here dropp

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for Parallel submission aka multi-bb execbuf (rev4)

2021-10-12 Thread Matthew Brost
On Tue, Oct 12, 2021 at 03:15:37PM -0700, John Harrison wrote: > On 10/4/2021 15:26, Patchwork wrote: > > == Series Details == > > > > Series: Parallel submission aka multi-bb execbuf (rev4) > > URL : https://patchwork.freedesktop.org/series/92789/ > > State : warning > > > > == Summary == > >

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/uapi: Add comment clarifying purpose of I915_TILING_* values

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915/uapi: Add comment clarifying purpose of I915_TILING_* values URL : https://patchwork.freedesktop.org/series/95743/ State : success == Summary == CI Bug Log - changes from CI_DRM_10727 -> Patchwork_21321

Re: [Intel-gfx] ✗ Fi.CI.DOCS: warning for Parallel submission aka multi-bb execbuf (rev4)

2021-10-12 Thread John Harrison
On 10/4/2021 15:26, Patchwork wrote: == Series Details == Series: Parallel submission aka multi-bb execbuf (rev4) URL : https://patchwork.freedesktop.org/series/92789/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/gt/uc/intel_guc.h:166: war

Re: [Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Parallel submission aka multi-bb execbuf (rev4)

2021-10-12 Thread John Harrison
On 10/4/2021 15:21, Patchwork wrote: == Series Details == Series: Parallel submission aka multi-bb execbuf (rev4) URL : https://patchwork.freedesktop.org/series/92789/ State : warning == Summary == $ dim checkpatch origin/drm-tip e2a47a99bf9d drm/i915/guc: Move GuC guc_id allocation under su

[Intel-gfx] [PATCH] drm/i915/uapi: Add comment clarifying purpose of I915_TILING_* values

2021-10-12 Thread Matt Roper
The I915_TILING_* values in our uapi header are intended solely for use with the old get_tiling/set_tiling ioctls that operate on hardware de-tiling fences; all other uapi communication about tiling types is done via framebuffer modifiers rather than with these old values. On newer Intel platforms

Re: [Intel-gfx] [PATCH 23/26] drm/i915: Make request conflict tracking understand parallel submits

2021-10-12 Thread John Harrison
On 10/4/2021 15:06, Matthew Brost wrote: If an object in the excl or shared slot is a composite fence from a parallel submit and the current request in the conflict tracking is from the same parallel context there is no need to enforce ordering as the ordering already implicit. Make the request c

Re: [Intel-gfx] [PATCH 22/26] drm/i915/guc: Handle errors in multi-lrc requests

2021-10-12 Thread John Harrison
On 10/4/2021 15:06, Matthew Brost wrote: If an error occurs in the front end when multi-lrc requests are getting generated we need to skip these in the backend but we still need to emit the breadcrumbs seqno. An issues arises because with multi-lrc breadcrumbs there is a handshake between the par

[Intel-gfx] [RFC PATCH] lib/stackdepot: stack_depot_init_mutex can be static

2021-10-12 Thread kernel test robot
lib/stackdepot.c:150:1: warning: symbol 'stack_depot_init_mutex' was not declared. Should it be static? Reported-by: kernel test robot Signed-off-by: kernel test robot --- stackdepot.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/lib/stackdepot.c b/lib/stackdepot.c in

Re: [Intel-gfx] [PATCH v2] lib/stackdepot: allow optional init and stack_table allocation by kvmalloc()

2021-10-12 Thread kernel test robot
Hi Vlastimil, I love your patch! Perhaps something to improve: [auto build test WARNING on drm-intel/for-linux-next] [also build test WARNING on linux/master linus/master v5.15-rc5] [cannot apply to hnaz-mm/master next-20211012] [If your patch is applied to the wrong git tree, kindly drop us a

Re: [Intel-gfx] [PATCH] drm/i915: Stop using I915_TILING_* in client blit selftest

2021-10-12 Thread Matt Roper
On Fri, Oct 08, 2021 at 12:49:57PM +0300, Ville Syrjälä wrote: > On Thu, Sep 30, 2021 at 05:58:16PM -0700, Matt Roper wrote: > > The I915_TILING_* definitions in the uapi header are intended solely for > > tiling modes that are visible to the old de-tiling fence ioctls. Since > > modern hardware d

Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix read of memory frequency

2021-10-12 Thread Matt Roper
On Tue, Oct 12, 2021 at 02:23:27PM -0700, Souza, Jose wrote: > On Tue, 2021-10-12 at 14:20 -0700, Matt Roper wrote: > > On Fri, Oct 08, 2021 at 01:58:55PM -0700, José Roberto de Souza wrote: > > > All display 9 and display 10 platforms has only 4 bits for the memory > > > frequency but display 11 p

Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix read of memory frequency

2021-10-12 Thread Souza, Jose
On Tue, 2021-10-12 at 14:20 -0700, Matt Roper wrote: > On Fri, Oct 08, 2021 at 01:58:55PM -0700, José Roberto de Souza wrote: > > All display 9 and display 10 platforms has only 4 bits for the memory > > frequency but display 11 platforms it changes to 8 bits. > > > > Display 9 platforms has anoth

Re: [Intel-gfx] [PATCH 21/26] drm/i915: Multi-BB execbuf

2021-10-12 Thread John Harrison
On 10/4/2021 15:06, Matthew Brost wrote: Allow multiple batch buffers to be submitted in a single execbuf IOCTL after a context has been configured with the 'set_parallel' extension. The number batches is implicit based on the contexts configuration. This is implemented with a series of loops. F

Re: [Intel-gfx] [PATCH] drm/i915/icl: Fix read of memory frequency

2021-10-12 Thread Matt Roper
On Fri, Oct 08, 2021 at 01:58:55PM -0700, José Roberto de Souza wrote: > All display 9 and display 10 platforms has only 4 bits for the memory > frequency but display 11 platforms it changes to 8 bits. > > Display 9 platforms has another register in bits 7:4 that prevents us > to have a single mas

Re: [Intel-gfx] [RFC v2 03/22] drm: Add Plane Degamma Mode property

2021-10-12 Thread Shankar, Uma
> -Original Message- > From: Pekka Paalanen > Sent: Tuesday, October 12, 2021 5:20 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > harry.wentl...@amd.com; ville.syrj...@linux.intel.com; brian.star...@arm.com; > sebast...@sebastianwick.net

Re: [Intel-gfx] [RFC v2 00/22] Add Support for Plane Color Lut and CSC features

2021-10-12 Thread Shankar, Uma
> -Original Message- > From: Pekka Paalanen > Sent: Tuesday, October 12, 2021 5:25 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > harry.wentl...@amd.com; ville.syrj...@linux.intel.com; brian.star...@arm.com; > sebast...@sebastianwick.net

Re: [Intel-gfx] [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline

2021-10-12 Thread Shankar, Uma
> -Original Message- > From: Pekka Paalanen > Sent: Tuesday, October 12, 2021 4:01 PM > To: Shankar, Uma > Cc: intel-gfx@lists.freedesktop.org; dri-de...@lists.freedesktop.org; > harry.wentl...@amd.com; ville.syrj...@linux.intel.com; > brian.star...@arm.com; sebast...@sebastianwick.ne

Re: [Intel-gfx] [PATCH v3 4/5] drm/dp, drm/i915: Add support for VESA backlights using PWM for brightness control

2021-10-12 Thread Doug Anderson
Hi, On Tue, Oct 5, 2021 at 7:41 PM Lyude Paul wrote: > > @@ -1859,8 +1859,7 @@ drm_dp_sink_can_do_video_without_timing_msa(const u8 > dpcd[DP_RECEIVER_CAP_SIZE]) > static inline bool > drm_edp_backlight_supported(const u8 edp_dpcd[EDP_DISPLAY_CTL_CAP_SIZE]) > { > - return (edp_dpcd[1] &

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/2] drm/dp: add helpers to read link training delays

2021-10-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp: add helpers to read link training delays URL : https://patchwork.freedesktop.org/series/95731/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10723_full -> Patchwork_21320_full

Re: [Intel-gfx] [PATCH 4/5] drm/armada: check dri/crtc root before debugfs init

2021-10-12 Thread kernel test robot
Hi Nirmoy, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on tegra/for-next drm-tip/drm-tip linus/master v5.15-rc5 next-20211012] [If your patch is applied to the wrong git tree, kindly drop us a note. And when

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Fix dereference of pointer backup before it is null checked

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Fix dereference of pointer backup before it is null checked URL : https://patchwork.freedesktop.org/series/95723/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10723_full -> Patchwork_21319_full ===

Re: [Intel-gfx] [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline

2021-10-12 Thread Shankar, Uma
> -Original Message- > From: Pekka Paalanen > Sent: Tuesday, October 12, 2021 5:30 PM > To: Simon Ser > Cc: Shankar, Uma ; intel-gfx@lists.freedesktop.org; > dri- > de...@lists.freedesktop.org; harry.wentl...@amd.com; > ville.syrj...@linux.intel.com; brian.star...@arm.com; > sebast...

Re: [Intel-gfx] [PATCH 24/26] drm/i915: Update I915_GEM_BUSY IOCTL to understand composite fences

2021-10-12 Thread Matthew Brost
On Tue, Oct 12, 2021 at 08:53:25AM +0100, Tvrtko Ursulin wrote: > > On 04/10/2021 23:06, Matthew Brost wrote: > > Parallel submission create composite fences (dma_fence_array) for excl / > > shared slots in objects. The I915_GEM_BUSY IOCTL checks these slots to > > determine the busyness of the ob

[Intel-gfx] [PATCH 02/26] drm/i915/guc: Take GT PM ref when deregistering context

2021-10-12 Thread Matthew Brost
Taking a PM reference to prevent intel_gt_wait_for_idle from short circuiting while a deregister context H2G is in flight. To do this must issue the deregister H2G from a worker as context can be destroyed from an atomic context and taking GT PM ref blows up. Previously we took a runtime PM from th

[Intel-gfx] ✓ Fi.CI.IGT: success for lib/stackdepot: allow optional init and stack_table allocation by kvmalloc() (rev2)

2021-10-12 Thread Patchwork
== Series Details == Series: lib/stackdepot: allow optional init and stack_table allocation by kvmalloc() (rev2) URL : https://patchwork.freedesktop.org/series/95549/ State : success == Summary == CI Bug Log - changes from CI_DRM_10723_full -> Patchwork_21318_full

Re: [Intel-gfx] [PATCH 6/8] drm/i915/display: refactor fbdev pin/unpin out into functions.

2021-10-12 Thread Jani Nikula
On Tue, 12 Oct 2021, Dave Airlie wrote: > From: Dave Airlie > > This just cleans up the calls a bit. I get an uneasy feeling about the changes in the error paths here. The happy day scenario looks fine. > > Signed-off-by: Dave Airlie > --- > drivers/gpu/drm/i915/display/intel_fbdev.c | 64 +++

Re: [Intel-gfx] [PATCH 1/4] drm/i915/huc: Use i915_probe_error to report early CTB failures

2021-10-12 Thread Michal Wajdeczko
On 12.10.2021 18:16, Jani Nikula wrote: > On Mon, 11 Oct 2021, Matthew Brost wrote: >> On Mon, Oct 11, 2021 at 08:51:03PM +0530, Thanneeru Srinivasulu wrote: >>> Replace DRM_ERROR with CT_PROBE_ERROR to report early CTB failures. >>> >>> Signed-off-by: Thanneeru Srinivasulu >> >> Reviewed-by:

Re: [Intel-gfx] [PATCH 1/4] drm/i915/huc: Use i915_probe_error to report early CTB failures

2021-10-12 Thread Jani Nikula
On Tue, 12 Oct 2021, Jani Nikula wrote: > On Mon, 11 Oct 2021, Matthew Brost wrote: >> On Mon, Oct 11, 2021 at 08:51:03PM +0530, Thanneeru Srinivasulu wrote: >>> Replace DRM_ERROR with CT_PROBE_ERROR to report early CTB failures. >>> >>> Signed-off-by: Thanneeru Srinivasulu >> >> Reviewed-by: M

Re: [Intel-gfx] [PATCH 1/4] drm/i915/huc: Use i915_probe_error to report early CTB failures

2021-10-12 Thread Jani Nikula
On Mon, 11 Oct 2021, Matthew Brost wrote: > On Mon, Oct 11, 2021 at 08:51:03PM +0530, Thanneeru Srinivasulu wrote: >> Replace DRM_ERROR with CT_PROBE_ERROR to report early CTB failures. >> >> Signed-off-by: Thanneeru Srinivasulu > > Reviewed-by: Matthew Brost > >> --- >> drivers/gpu/drm/i915/g

Re: [Intel-gfx] [PATCH v2] lib/stackdepot: allow optional init and stack_table allocation by kvmalloc()

2021-10-12 Thread Marco Elver
On Tue, 12 Oct 2021 at 11:06, Vlastimil Babka wrote: > Currently, enabling CONFIG_STACKDEPOT means its stack_table will be allocated > from memblock, even if stack depot ends up not actually used. The default size > of stack_table is 4MB on 32-bit, 8MB on 64-bit. > > This is fine for use-cases suc

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/dp: add helpers to read link training delays

2021-10-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp: add helpers to read link training delays URL : https://patchwork.freedesktop.org/series/95731/ State : success == Summary == CI Bug Log - changes from CI_DRM_10723 -> Patchwork_21320 ==

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/dp: add helpers to read link training delays

2021-10-12 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp: add helpers to read link training delays URL : https://patchwork.freedesktop.org/series/95731/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked s

Re: [Intel-gfx] [PATCH 4/4] drm/i915/guc: Inject probe errors for CT send

2021-10-12 Thread Michal Wajdeczko
On 11.10.2021 20:00, Matthew Brost wrote: > On Mon, Oct 11, 2021 at 08:51:06PM +0530, Thanneeru Srinivasulu wrote: >> Inject probe errors -ENXIO, -EBUSY for CT send. >> >> Signed-off-by: Thanneeru Srinivasulu >> --- >> drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c | 8 >> 1 file changed,

Re: [Intel-gfx] [PATCH][next] drm/i915: Fix dereference of pointer backup before it is null checked

2021-10-12 Thread Dan Carpenter
On Tue, Oct 12, 2021 at 04:47:24PM +0200, Thomas Hellström wrote: > Hi, > > On 10/12/21 15:25, Colin King wrote: > > From: Colin Ian King > > > > The assignment of pointer backup_bo dereferences pointer backup before > > backup is null checked, this could lead to a null pointer dereference > > i

Re: [Intel-gfx] [PATCH][next] drm/i915: Fix dereference of pointer backup before it is null checked

2021-10-12 Thread Thomas Hellström
Hi, On 10/12/21 15:25, Colin King wrote: From: Colin Ian King The assignment of pointer backup_bo dereferences pointer backup before backup is null checked, this could lead to a null pointer dereference issue. Fix this by only assigning backup_bo after backup has been null checked. Addresses-

[Intel-gfx] [PATCH 2/2] drm/i915/dp: use new link training delay helpers

2021-10-12 Thread Jani Nikula
Use the new link training delay helpers, fixing the delays for 128b/132b. For existing 8b/10b functionality, this will cause additional 1-byte DPCD reads for LTTPR delays instead of using the cached values. It's just too complicated to combine generic helpers with local caching in a sensible way.

[Intel-gfx] [PATCH 1/2] drm/dp: add helpers to read link training delays

2021-10-12 Thread Jani Nikula
The link training delays are different and/or available in different DPCD offsets depending on: - Clock recovery vs. channel equalization - DPRX vs. LTTPR - 128b/132b vs. 8b/10b - DPCD 1.4+ vs. earlier Add helpers to get the correct delays in us, reading DPCD if necessary. This is more straightfo

Re: [Intel-gfx] [PATCH 2/5] drm/i915: check dri root before debugfs init

2021-10-12 Thread Das, Nirmoy
Hi Zhi, Please discard this patch,  review https://patchwork.freedesktop.org/patch/458554/?series=95690&rev=1 instead. minor->debugfs_root wont be NULl as we save debugfs_create_dir()'s return value in that. Regards, Nirmoy On 10/12/2021 11:59 AM, Wang, Zhi A wrote: On 10/8/21 9:17 AM, Ni

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Fix dereference of pointer backup before it is null checked

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Fix dereference of pointer backup before it is null checked URL : https://patchwork.freedesktop.org/series/95723/ State : success == Summary == CI Bug Log - changes from CI_DRM_10723 -> Patchwork_21319

[Intel-gfx] [PATCH][next] drm/i915: Fix dereference of pointer backup before it is null checked

2021-10-12 Thread Colin King
From: Colin Ian King The assignment of pointer backup_bo dereferences pointer backup before backup is null checked, this could lead to a null pointer dereference issue. Fix this by only assigning backup_bo after backup has been null checked. Addresses-Coverity: ("Dereference before null check")

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/dg2: Tile 4 plane format support

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Tile 4 plane format support URL : https://patchwork.freedesktop.org/series/95715/ State : success == Summary == CI Bug Log - changes from CI_DRM_10721_full -> Patchwork_21317_full Summary ---

Re: [Intel-gfx] [PATCH 4/4] vgaswitcheroo: do not check for NULL debugfs dentry

2021-10-12 Thread Das, Nirmoy
On 10/12/2021 8:48 AM, Lukas Wunner wrote: On Mon, Oct 11, 2021 at 10:24:29PM +0200, Lukas Wunner wrote: On Mon, Oct 11, 2021 at 09:06:07PM +0200, Nirmoy Das wrote: Debugfs APIs returns encoded error on failure so use debugfs_lookup() instead of checking for NULL. [...] --- a/drivers/gpu/vg

Re: [Intel-gfx] [PATCH 2/4] drm/ttm: do not set NULL to debugfs dentry

2021-10-12 Thread Das, Nirmoy
On 10/12/2021 9:09 AM, Christian König wrote: Am 11.10.21 um 21:06 schrieb Nirmoy Das: For debugfs directory, it is recommended to save the result and pass over to next debugfs API for creating debugfs files/directories. Error conditions are handled by debugfs APIs. CC: Christian Koenig CC:

[Intel-gfx] ✓ Fi.CI.BAT: success for lib/stackdepot: allow optional init and stack_table allocation by kvmalloc() (rev2)

2021-10-12 Thread Patchwork
== Series Details == Series: lib/stackdepot: allow optional init and stack_table allocation by kvmalloc() (rev2) URL : https://patchwork.freedesktop.org/series/95549/ State : success == Summary == CI Bug Log - changes from CI_DRM_10723 -> Patchwork_21318 ==

Re: [Intel-gfx] [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline

2021-10-12 Thread Pekka Paalanen
On Tue, 12 Oct 2021 10:35:37 + Simon Ser wrote: > On Tuesday, October 12th, 2021 at 12:30, Pekka Paalanen > wrote: > > > is there a practise of landing proposal documents in the kernel? How > > does that work, will a kernel tree carry the patch files? > > Or should this document be worded

Re: [Intel-gfx] [RFC v2 00/22] Add Support for Plane Color Lut and CSC features

2021-10-12 Thread Pekka Paalanen
On Tue, 7 Sep 2021 03:08:42 +0530 Uma Shankar wrote: > This is how a typical display color hardware pipeline looks like: > +---+ > |RAM| > | +--++-++-+ | > | | FB 1 || FB 2

Re: [Intel-gfx] [RFC v2 03/22] drm: Add Plane Degamma Mode property

2021-10-12 Thread Pekka Paalanen
On Tue, 7 Sep 2021 03:08:45 +0530 Uma Shankar wrote: > Add Plane Degamma Mode as an enum property. Create a helper > function for all plane color management features. > > This is an enum property with values as blob_id's and exposes > the various gamma modes supported and the lut ranges. Gettin

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for lib/stackdepot: allow optional init and stack_table allocation by kvmalloc() (rev2)

2021-10-12 Thread Patchwork
== Series Details == Series: lib/stackdepot: allow optional init and stack_table allocation by kvmalloc() (rev2) URL : https://patchwork.freedesktop.org/series/95549/ State : warning == Summary == $ dim checkpatch origin/drm-tip 205d6c25088d lib/stackdepot: allow optional init and stack_table

Re: [Intel-gfx] linux-next: build failure after merge of the drm-misc tree

2021-10-12 Thread Karol Herbst
uhh, that's on me. I will send out a patch today. I just noticed that the config file I used for testing had WERROR disabled. On Tue, Oct 12, 2021 at 4:18 AM Stephen Rothwell wrote: > > Hi all, > > After merging the drm-misc tree, today's linux-next build (x86_64 > allmodconfig) failed like this:

Re: [Intel-gfx] [PATCH 2/4] drm/ttm: do not set NULL to debugfs dentry

2021-10-12 Thread Christian König
Am 11.10.21 um 21:06 schrieb Nirmoy Das: For debugfs directory, it is recommended to save the result and pass over to next debugfs API for creating debugfs files/directories. Error conditions are handled by debugfs APIs. CC: Christian Koenig CC: Huang Rui CC: David Airlie CC: Daniel Vetter

Re: [Intel-gfx] [PATCH 5/8] drm/i915/display: move pin/unpin fb/plane code to a new file.

2021-10-12 Thread Jani Nikula
On Tue, 12 Oct 2021, Dave Airlie wrote: > From: Dave Airlie > > This just moves this code out of the i915_display.c into a new > standalone file. > > Signed-off-by: Dave Airlie Thanks for the patches, pushed up to and including this one, it's all pure code movement AFAICS. The next one needs sl

Re: [Intel-gfx] [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline

2021-10-12 Thread Simon Ser
On Tuesday, October 12th, 2021 at 12:30, Pekka Paalanen wrote: > is there a practise of landing proposal documents in the kernel? How > does that work, will a kernel tree carry the patch files? > Or should this document be worded like documentation for an accepted > feature, and then the patches

Re: [Intel-gfx] [RFC v2 01/22] drm: RFC for Plane Color Hardware Pipeline

2021-10-12 Thread Pekka Paalanen
On Tue, 7 Sep 2021 03:08:43 +0530 Uma Shankar wrote: > This is a RFC proposal for plane color hardware blocks. > It exposes the property interface to userspace and calls > out the details or interfaces created and the intended > purpose. > > Credits: Ville Syrjälä > Signed-off-by: Uma Shankar

Re: [Intel-gfx] [PATCH] drm/i915/gvt: clean up kernel-doc in gtt.c

2021-10-12 Thread Wang, Zhi A
On 10/3/21 5:23 AM, Randy Dunlap wrote: > Fix kernel-doc warnings in gtt.c: > > gtt.c:1152: warning: This comment starts with '/**', but isn't a kernel-doc > comment. Refer Documentation/doc-guide/kernel-doc.rst > * Check if can do 2M page > gtt.c:1152: warning: missing initial short descriptio

[Intel-gfx] ✓ Fi.CI.IGT: success for Fixup header includes (rev4)

2021-10-12 Thread Patchwork
== Series Details == Series: Fixup header includes (rev4) URL : https://patchwork.freedesktop.org/series/95587/ State : success == Summary == CI Bug Log - changes from CI_DRM_10720_full -> Patchwork_21316_full Summary --- **SUCCESS**

Re: [Intel-gfx] [PATCH 2/5] drm/i915: check dri root before debugfs init

2021-10-12 Thread Wang, Zhi A
On 10/8/21 9:17 AM, Nirmoy Das wrote: > Return early if dri minor root dentry is NULL. > > CC: Zhenyu Wang > CC: Zhi Wang > CC: Jani Nikula > CC: Joonas Lahtinen > CC: Rodrigo Vivi > CC: David Airlie > CC: Daniel Vetter > Signed-off-by: Nirmoy Das > --- > drivers/gpu/drm/i915/gvt/debugfs

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/dg2: Tile 4 plane format support

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Tile 4 plane format support URL : https://patchwork.freedesktop.org/series/95715/ State : success == Summary == CI Bug Log - changes from CI_DRM_10721 -> Patchwork_21317 Summary --- **SUCCES

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: abstract intel_dp_lane_max_vswing_reached()

2021-10-12 Thread Jani Nikula
On Mon, 11 Oct 2021, Jani Nikula wrote: > Add per-lane abstraction for max vswing reached to make follow-up > cleaner, as this one reverses the conditions. > > v2: both conditions need to be true, reverse (Ville) > > Cc: Ville Syrjälä > Signed-off-by: Jani Nikula Pushed both with Ville's IRC r-

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: Tile 4 plane format support

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915/dg2: Tile 4 plane format support URL : https://patchwork.freedesktop.org/series/95715/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9f8c203ad95f drm/i915/dg2: Tile 4 plane format support -:194: WARNING:LINE_CONTINUATIONS: Avoid unnecessary

[Intel-gfx] [PATCH v2] lib/stackdepot: allow optional init and stack_table allocation by kvmalloc()

2021-10-12 Thread Vlastimil Babka
Currently, enabling CONFIG_STACKDEPOT means its stack_table will be allocated from memblock, even if stack depot ends up not actually used. The default size of stack_table is 4MB on 32-bit, 8MB on 64-bit. This is fine for use-cases such as KASAN which is also a config option and has overhead on it

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Update memory bandwidth formulae (rev6)

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915: Update memory bandwidth formulae (rev6) URL : https://patchwork.freedesktop.org/series/95138/ State : success == Summary == CI Bug Log - changes from CI_DRM_10720_full -> Patchwork_21315_full Summary -

Re: [Intel-gfx] [PATCH] lib/stackdepot: allow optional init and stack_table allocation by kvmalloc()

2021-10-12 Thread Vlastimil Babka
On 10/11/21 19:08, Marco Elver wrote: > On Mon, 11 Oct 2021 at 19:02, Vlastimil Babka wrote: > [...] >> > On the other hand, the lazy initialization mode you're introducing >> > requires an explicit stack_depot_init() call somewhere and isn't as >> > straightforward as before. >> > >> > Not sure w

[Intel-gfx] [PATCH] drm/i915/dg2: Tile 4 plane format support

2021-10-12 Thread Stanislav Lisovskiy
TileF(Tile4 in bspec) format is 4K tile organized into 64B subtiles with same basic shape as for legacy TileY which will be supported by Display13. v2: - Fixed wrong case condition(Jani Nikula) - Increased I915_FORMAT_MOD_F_TILED up to 12(Imre Deak) v3: - s/I915_TILING_F/TILING_4/g - s/I9

Re: [Intel-gfx] [PATCH 2/2] drm/i915/pmu: Connect engine busyness stats from GuC to pmu

2021-10-12 Thread Tvrtko Ursulin
On 11/10/2021 21:08, Umesh Nerlige Ramappa wrote: On Mon, Oct 11, 2021 at 12:41:19PM +0100, Tvrtko Ursulin wrote: On 07/10/2021 23:55, Umesh Nerlige Ramappa wrote: With GuC handling scheduling, i915 is not aware of the time that a context is scheduled in and out of the engine. Since i915 pmu

Re: [Intel-gfx] [PATCH 24/26] drm/i915: Update I915_GEM_BUSY IOCTL to understand composite fences

2021-10-12 Thread Tvrtko Ursulin
On 04/10/2021 23:06, Matthew Brost wrote: Parallel submission create composite fences (dma_fence_array) for excl / shared slots in objects. The I915_GEM_BUSY IOCTL checks these slots to determine the busyness of the object. Prior to patch it only check if the fence in the slot was a i915_reques

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: refactor plane config + pin out (rev2)

2021-10-12 Thread Patchwork
== Series Details == Series: drm/i915/display: refactor plane config + pin out (rev2) URL : https://patchwork.freedesktop.org/series/95541/ State : success == Summary == CI Bug Log - changes from CI_DRM_10720_full -> Patchwork_21314_full Su

Re: [Intel-gfx] [PATCH] drm/i915: replacing drm_modeset_lock_all for DRM_MODESET_LOCK_ALL_*

2021-10-12 Thread Jani Nikula
On Sun, 10 Oct 2021, Maíra Canal wrote: > As requested in GPU Driver Developers Guide TODO list, replaces all > drm_lock boilerplates for DRM_MODESET_LOCK_ALL_* helpers. Please see [1]. Also, all i915 patches must be Cc'd to intel-gfx mailing list. Please see MAINTAINERS file. BR, Jani. [1]

[Intel-gfx] ✓ Fi.CI.BAT: success for Fixup header includes (rev4)

2021-10-12 Thread Patchwork
== Series Details == Series: Fixup header includes (rev4) URL : https://patchwork.freedesktop.org/series/95587/ State : success == Summary == CI Bug Log - changes from CI_DRM_10720 -> Patchwork_21316 Summary --- **SUCCESS** No reg