[Intel-gfx] [PATCH v2 07/17] drm/shmobile: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/shmobile/shmob_drm_drv.c | 6 -- 1 file changed, 4 insertions(

[Intel-gfx] [PATCH v2 06/17] drm/tegra: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul Reported-by: kernel test robot --- drivers/gpu/drm/tegra/dsi.c | 6 -- drivers/

[Intel-gfx] [PATCH v2 00/17] drm: cleanup: Use DRM_MODESET_LOCK_ALL_* helpers where possible

Hi all, One of the things in the DRM TODO list ("Documentation/gpu/todo.rst") was to "use DRM_MODESET_LOCAL_ALL_* helpers instead of boilerplate". That's what this patch series is about. You will find two types of changes here: - Replacing "drm_modeset_lock_all_ctx()" (and surrounding boilerpl

[Intel-gfx] [PATCH v2 13/17] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN() part 2

As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() While the previous commit was a simple "search and replace", this time I had to do a bit of refactoring as only one call to DRM_MODESET_LOCK_A

[Intel-gfx] [PATCH v2 04/17] drm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/drm_client_modeset.c | 5 +++-- drivers/gpu/drm/drm_crtc_helper.c

[Intel-gfx] [PATCH v2 12/17] drm/i915: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/i915/display/intel_audio.c| 16 --- drivers/gpu/drm/i915/display/intel_display.c

[Intel-gfx] [PATCH v2 15/17] drm/amd: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/amd/amdgpu/amdgpu_display.c | 21 +--- .../gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c

[Intel-gfx] [PATCH v2 16/17] drm: cleanup: remove drm_modeset_(un)lock_all()

Functions drm_modeset_lock_all() and drm_modeset_unlock_all() are no longer used anywhere and can be removed. Signed-off-by: Fernando Ramos --- drivers/gpu/drm/drm_modeset_lock.c | 94 +- include/drm/drm_modeset_lock.h | 2 - 2 files changed, 3 insertions(+), 93

[Intel-gfx] [PATCH v2 08/17] drm/radeon: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/radeon/radeon_device.c | 21 +++-- drivers/gpu/drm/radeon/radeon_dp_mst.c

[Intel-gfx] [PATCH v2 09/17] drm/omapdrm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/omapdrm/omap_fb.c | 9 ++--- 1 file changed, 6 insertions(+),

[Intel-gfx] [PATCH v2 11/17] drm/msm: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/msm/disp/dpu1/dpu_crtc.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-)

[Intel-gfx] [PATCH v2 01/17] drm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace the boilerplate code surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/drm_client_modeset.c | 9 +++-- 1 file changed, 3 insertions(+),

[Intel-gfx] [PATCH v2 14/17] drm/gma500: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos --- drivers/gpu/drm/gma500/psb_device.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions

[Intel-gfx] [PATCH v2 02/17] drm/i915: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace the boilerplate code surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/i915/display/intel_display.c | 18 +--

[Intel-gfx] [PATCH v2 05/17] drm/vmwgfx: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/vmwgfx/vmwgfx_ioctl.c | 11 +++ drivers/gpu/drm/vmwgfx/vmw

[Intel-gfx] [PATCH v2 03/17] drm/msm: cleanup: drm_modeset_lock_all_ctx() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace the boilerplate code surrounding drm_modeset_lock_all_ctx() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul Reported-by: kernel test robot --- drivers/gpu/drm/msm/disp/msm_

[Intel-gfx] [PATCH v2 17/17] doc: drm: remove TODO entry regarding DRM_MODSET_LOCK_ALL cleanup

The previous commits do exactly what this entry in the TODO file asks for, thus we can remove it now as it is no longer applicable. Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- Documentation/gpu/todo.rst| 17 - Documentation/locking/ww-mutex-design.rs

[Intel-gfx] [PATCH v2 10/17] drm/nouveau: cleanup: drm_modeset_lock_all() --> DRM_MODESET_LOCK_ALL_BEGIN()

As requested in Documentation/gpu/todo.rst, replace driver calls to drm_modeset_lock_all() with DRM_MODESET_LOCK_ALL_BEGIN() and DRM_MODESET_LOCK_ALL_END() Signed-off-by: Fernando Ramos Reviewed-by: Sean Paul --- drivers/gpu/drm/nouveau/dispnv50/disp.c | 15 ++- 1 file changed, 10 i

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Reject bogus modes with fixed mode panels

== Series Details == Series: drm/i915: Reject bogus modes with fixed mode panels URL : https://patchwork.freedesktop.org/series/95003/ State : success == Summary == CI Bug Log - changes from CI_DRM_10633_full -> Patchwork_21149_full Summary

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/7] drm/i915/display: Wait PSR2 get out of deep sleep to update pipe

== Series Details == Series: series starting with [1/7] drm/i915/display: Wait PSR2 get out of deep sleep to update pipe URL : https://patchwork.freedesktop.org/series/95002/ State : success == Summary == CI Bug Log - changes from CI_DRM_10632_full -> Patchwork_21148_full

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/bdb: Fix version check (rev2)

== Series Details == Series: drm/i915/bdb: Fix version check (rev2) URL : https://patchwork.freedesktop.org/series/94871/ State : success == Summary == CI Bug Log - changes from CI_DRM_10632_full -> Patchwork_21147_full Summary --- *

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Introduce Intel PXP (rev12)

== Series Details == Series: drm/i915: Introduce Intel PXP (rev12) URL : https://patchwork.freedesktop.org/series/90503/ State : failure == Summary == Applying: drm/i915/pxp: Define PXP component interface Applying: mei: pxp: export pavp client to me client bus Applying: drm/i915/pxp: define P

Re: [Intel-gfx] [PATCH 04/13] drm/i915/tc: Check for DP-alt, legacy sinks before taking PHY ownership

On Tue, 2021-09-21 at 03:23 +0300, Imre Deak wrote: > On ADL-P the PHY ready/complete flag is always set even in TBT-alt mode. > To avoid taking the PHY ownership and the following spurious "PHY sudden > disconnect" messages on this platform when connecting the PHY in TBT > mode, check if there is

Re: [Intel-gfx] [PATCH 03/13] drm/i915/tc: Remove waiting for PHY complete during releasing ownership

On Tue, 2021-09-21 at 03:23 +0300, Imre Deak wrote: > Waiting for the PHY complete flag to clear when releasing the PHY > ownership was add in > > commit ddec362724f9 ("drm/i915: Wait for TypeC PHY complete flag to clear in > safe mode") > > This isn't required by the spec, the vague idea was to

Re: [Intel-gfx] [PATCH v12 04/17] drm/i915/pxp: allocate a vcs context for pxp usage

On 9/23/2021 12:35 AM, Alan Previn wrote: From: Daniele Ceraolo Spurio The context is required to send the session termination commands to the VCS, which will be implemented in a follow-up patch. We can also use the presence of the context as a check of pxp initialization completion. v2: us

Re: [Intel-gfx] [PATCH 02/13] drm/i915/adlp/tc: Fix PHY connected check for Thunderbolt mode

On Tue, 2021-09-21 at 03:23 +0300, Imre Deak wrote: > On ADL-P the PHY ready (aka status complete on other platforms) flag is > always set, besides when a DP-alt, legacy sink is connected also when a > TBT sink is connected or nothing is connected. So assume the PHY to be > connected when both the

Re: [Intel-gfx] [PATCH 01/13] drm/i915/tc: Fix TypeC port init/resume time sanitization

On Tue, 2021-09-21 at 03:23 +0300, Imre Deak wrote: > Atm during driver loading and system resume TypeC ports are accessed > before their HW/SW state is synced. Move the TypeC port sanitization to > the encoder's sync_state hook to fix this. > > Fixes: f9e76a6e68d3 ("drm/i915: Add an encoder hook

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Reject bogus modes with fixed mode panels

== Series Details == Series: drm/i915: Reject bogus modes with fixed mode panels URL : https://patchwork.freedesktop.org/series/95003/ State : success == Summary == CI Bug Log - changes from CI_DRM_10633 -> Patchwork_21149 Summary ---

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/7] drm/i915/display: Wait PSR2 get out of deep sleep to update pipe

== Series Details == Series: series starting with [1/7] drm/i915/display: Wait PSR2 get out of deep sleep to update pipe URL : https://patchwork.freedesktop.org/series/95002/ State : success == Summary == CI Bug Log - changes from CI_DRM_10632 -> Patchwork_21148 ==

[Intel-gfx] ✗ Fi.CI.DOCS: warning for series starting with [1/7] drm/i915/display: Wait PSR2 get out of deep sleep to update pipe

== Series Details == Series: series starting with [1/7] drm/i915/display: Wait PSR2 get out of deep sleep to update pipe URL : https://patchwork.freedesktop.org/series/95002/ State : warning == Summary == $ make htmldocs 2>&1 > /dev/null | grep i915 ./drivers/gpu/drm/i915/display/intel_drrs.c

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/bdb: Fix version check (rev2)

== Series Details == Series: drm/i915/bdb: Fix version check (rev2) URL : https://patchwork.freedesktop.org/series/94871/ State : success == Summary == CI Bug Log - changes from CI_DRM_10632 -> Patchwork_21147 Summary --- **SUCCESS**

[Intel-gfx] [PATCH 5/6] drm/i915: Reject user modes that don't match fixed mode's refresh rate

From: Ville Syrjälä When using a panel with a fixed mode we don't change the refresh rate of the display. Reject any user requested mode which doesn't match that fixed refresh rate. Unfortunately when Xorg sees the scaling_mode property on the connecor it likes to automagically cook up modes who

[Intel-gfx] [PATCH 6/6] drm/i915: Drop pointless fixed_mode checks from dsi code

From: Ville Syrjälä We don't support dsi displays without a fixed mode, so drop all the pointless checks. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dsi.c | 15 - drivers/gpu/drm/i915/display/vlv_dsi.c | 41 ++-- 2 files changed, 23 insert

[Intel-gfx] [PATCH 4/6] drm/i915: Introduce intel_panel_compute_config()

From: Ville Syrjälä Let's introduce a compute_config() helper for fixed mode panels. For now all it does is the fixed_mode->adjusted_mode copy. Note that with sDVO we have to ask the external encoder chip to spit out our actual display timings for us, so we won't use intel_panel_compute_config()

[Intel-gfx] [PATCH 3/6] drm/i915: Reject modes that don't match fixed_mode vrefresh

From: Ville Syrjälä When using a fixed mode we won't change the refresh rate ever. So filter out all modes that don't match the fixed_mode's refresh rate. I'm going to declare the "rounded to nearest Hz refresh rates must match" approach good enough for now. Note that we could start supporting

[Intel-gfx] [PATCH 2/6] drm/i915: Use intel_panel_mode_valid() for DSI/LVDS/DVO

From: Ville Syrjälä All fixed mode panels should behave the same way when it comes to mode filtering. Reuse the intel_panel_mode_valid() for all of them. This changes the behaviour to match what we do for eDP, ie. reject anything that doesn't exactly match the fixed mode dimensions. Users can st

[Intel-gfx] [PATCH 1/6] drm/i915: Extract intel_panel_mode_valid()

From: Ville Syrjälä Extract intel_panel_mode_valid() from the eDP code to a generic helper. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c| 8 +++- drivers/gpu/drm/i915/display/intel_panel.c | 18 ++ drivers/gpu/drm/i915/display/intel_panel.h

[Intel-gfx] [PATCH 0/6] drm/i915: Reject bogus modes with fixed mode panels

From: Ville Syrjälä Let's start to reject user modes whose refresh rate is nowhere near the actual fixed mode refresh rate we're going to use. ATM we're just flat out lying to the user. We'll also pimp the connector's mode list validation a bit. Ville Syrjälä (6): drm/i915: Extract intel_pan

[Intel-gfx] ✗ Fi.CI.BUILD: failure for i915/display: split and constify vtable (rev8)

== Series Details == Series: i915/display: split and constify vtable (rev8) URL : https://patchwork.freedesktop.org/series/94459/ State : failure == Summary == Applying: drm/i915/uncore: split the fw get function into separate vfunc Applying: drm/i915/pm: drop get_fifo_size vfunc. Applying: dr

[Intel-gfx] [PATCH 7/7] drm/i915/display: Enable PSR2 selective fetch by default

With all the past fixes now this feature is functional and can be enabled by default in desktop enviroments that uses compositor. Cc: Gwan-gyeong Mun Cc: Ville Syrjälä Signed-off-by: José Roberto de Souza --- drivers/gpu/drm/i915/i915_params.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion

[Intel-gfx] [PATCH 5/7] drm/i915/display/psr: Do full fetch when handling biplanar formats

From: Gwan-gyeong Mun We are still missing the PSR2 selective fetch handling of biplanar formats but until proper handle is added we can workaround it by doing full frames fetch when state has biplanar formats. Signed-off-by: Gwan-gyeong Mun --- drivers/gpu/drm/i915/display/intel_psr.c | 4 +++

[Intel-gfx] [PATCH 3/7] drm/i915/display: Add new fb_op_origin type and use it to optimize power savings

intel_prepare_plane_fb() was calling i915_gem_object_flush_frontbuffer() with the generic ORIGIN_DIRTYFB, what was causing PSR, FBC and DRRS to do their frontbuffer rendering in a framebuffer that will be flipped. Not handling this call as frontbuffer rendering allow us to save more power with all

[Intel-gfx] [PATCH 1/7] drm/i915/display: Wait PSR2 get out of deep sleep to update pipe

Alderlake-P was getting 'max time under evasion' messages when PSR2 was enabled, this is due PIPE_SCANLINE/PIPEDSL returning 0 over a period of time longer than VBLANK_EVASION_TIME_US. For PSR1 we had the same issue so intel_psr_wait_for_idle() was implemented to wait for PSR1 to get into idle sta

[Intel-gfx] [PATCH 4/7] drm/i915/display/psr: Handle plane restrictions at every page flip

PSR2 selective is not supported over rotated and scaled planes. We had the rotation check in intel_psr2_sel_fetch_config_valid() but that code path is only execute when a modeset is needed and change those plane parameters do not require a modeset. Also need to check those restricions in the secon

[Intel-gfx] [PATCH 6/7] drm/i915/display/adlp: Allow PSR2 to be enabled

With all the recent fixes PSR2 is properly working in Alderlake-P but due to some issues that don't have software workarounds it will not be supported in display steppings older than B0. Even with this patch PSR2 will no be enabled by default in ADL-P, it still requires enable_psr2_sel_fetch to be

[Intel-gfx] [PATCH 2/7] drm/i915/display: Handle frontbuffer rendering when PSR2 selective fetch is enabled

CURSURFLIVE writes has no affect when PSR2 selective fetch is enabled, the right thing to do here would be calculate the damaged area and program PSR2 selective fetch registers properly during vblank but we can't do that due to performance reasons. So for now we can workaround and offer proper ren

Re: [Intel-gfx] [PATCH 06/14] drm/i915: Split g4x_compute_pipe_wm() into two

On Fri, May 14, 2021 at 03:57:43PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Split g4x_compute_pipe_wm() into two halves. The first half computes > the new raw watermarks, and the second half munges those up into real > watermarks for the particular pipe. > > We can reuse the second

[Intel-gfx] [PATCH v2] drm/i915/bdb: Fix version check

With patch "drm/i915/vbt: Fix backlight parsing for VBT 234+" the size of bdb_lfp_backlight_data structure has been increased, causing if-statement in the parse_lfp_backlight function that comapres this structure size to the one retrieved from BDB, always to fail for older revisions. This patch cal

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Wait PSR2 get out of deep sleep to update pipe

On Thu, 2021-09-23 at 16:27 +0300, Gwan-gyeong Mun wrote: > > On 9/17/21 11:52 PM, José Roberto de Souza wrote: > > Alderlake-P was getting 'max time under evasion' messages when PSR2 > > was enabled, this is due PIPE_SCANLINE/PIPEDSL returning 0 over a > > period of time longer than VBLANK_EVASIO

Re: [Intel-gfx] i915 Updates - ADLP DMC v2.12

On Mon, Sep 20, 2021 at 5:57 PM Srivatsa, Anusha wrote: > > Hi josh, Ben, Kyle > > Kindly add the below i915 changes to linux-firmware: > > linux-firmware: add frimware for mediatek bluetooth chip (MT7922) (2021-09-13 > 11:35:49 -0400) > > > > are available in the Git repository at: > > > > git

Re: [Intel-gfx] [PATCH] drm/i915: Tile F plane format support

On Thu, Sep 23, 2021 at 06:49:59PM +0300, Ville Syrjälä wrote: > On Thu, Sep 23, 2021 at 11:48:58AM +0300, Stanislav Lisovskiy wrote: > > TileF(Tile4 in bspec) format is 4K tile organized into > > 64B subtiles with same basic shape as for legacy TileY > > which will be supported by Display13. > >

[Intel-gfx] [patch 00/11] hrtimers: Cleanup hrtimer_forward() [ab]use

A recent syzbot report unearthed abuse of hrtimer_forward() which can cause runaway timers hogging the CPU in timer expiry context by rearming the timer in the past over and over. This happens when the caller uses timer->expiry for the 'now' argument of hrtimer_forward(). That works as long as the

[Intel-gfx] [patch 07/11] drm/i915/pmu: Use hrtimer_forward_now()

hrtimer_forward() is about to be removed from the public interfaces. Replace it with hrtimer_forward_now() which provides the same functionality. Signed-off-by: Thomas Gleixner Cc: David Airlie Cc: intel-gfx@lists.freedesktop.org Cc: Joonas Lahtinen Cc: Jani Nikula Cc: dri-de...@lists.freedesk

Re: [Intel-gfx] [PATCH 1/2] Enable buddy memory manager support

[AMD Public Use] Hi Alex, I will fix the name and send a document in my next version. Thanks, Arun -Original Message- From: Alex Deucher Sent: Tuesday, September 21, 2021 12:54 AM To: Paneer Selvam, Arunpravin Cc: Maling list - DRI developers ; Intel Graphics Development ; amd-gfx lis

Re: [Intel-gfx] [PATCH 1/2] Enable buddy memory manager support

[AMD Public Use] Hi Christian, > And where is the patch to switch i915 and remove the Intel copy of this? Creating a patch for the switch. > In general I think that every public function here needs a kerneldoc > description what it is all about. Making a kernel doc description for each public f

Re: [Intel-gfx] [PATCH 2/2] Add drm buddy manager support to amdgpu driver

[AMD Public Use] Hi Christian, Thanks for the review, I will the send the next version fixing all issues. Regards, Arun -Original Message- From: Christian König Sent: Wednesday, September 22, 2021 12:18 PM To: Paneer Selvam, Arunpravin ; Koenig, Christian ; dri-de...@lists.freedesktop.

Re: [Intel-gfx] [PATCH 05/14] drm/i915: Fix HPLL watermark readout for g4x

On Thu, Sep 23, 2021 at 04:24:21PM +0300, Lisovskiy, Stanislav wrote: > On Wed, Sep 22, 2021 at 05:05:12PM +0300, Ville Syrjälä wrote: > > On Fri, Sep 17, 2021 at 06:34:22PM +0300, Lisovskiy, Stanislav wrote: > > > On Fri, May 14, 2021 at 03:57:42PM +0300, Ville Syrjala wrote: > > > > From: Ville S

Re: [Intel-gfx] [PATCH] drm/i915: Tile F plane format support

On Thu, Sep 23, 2021 at 11:48:58AM +0300, Stanislav Lisovskiy wrote: > TileF(Tile4 in bspec) format is 4K tile organized into > 64B subtiles with same basic shape as for legacy TileY > which will be supported by Display13. Why we still haven't done the F->tile64 rename? This is the last chance to

Re: [Intel-gfx] [PATCH v6 3/9] drm/i915/gt: Increase suspend timeout

On 9/23/21 4:33 PM, Tvrtko Ursulin wrote: On 23/09/2021 14:19, Thomas Hellström wrote: On 9/23/21 2:59 PM, Tvrtko Ursulin wrote: On 23/09/2021 12:47, Thomas Hellström wrote: Hi, Tvrtko, On 9/23/21 12:13 PM, Tvrtko Ursulin wrote: On 22/09/2021 07:25, Thomas Hellström wrote: With GuC su

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Tile F plane format support (rev2)

== Series Details == Series: drm/i915: Tile F plane format support (rev2) URL : https://patchwork.freedesktop.org/series/94983/ State : success == Summary == CI Bug Log - changes from CI_DRM_10630_full -> Patchwork_21145_full Summary --

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/adlp: Add support for remapping CCS FBs (rev3)

On Tue, Sep 07, 2021 at 05:25:30AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/adlp: Add support for remapping CCS FBs (rev3) > URL : https://patchwork.freedesktop.org/series/94108/ > State : failure Patches 1-5 pushed to drm-intel-next, thanks for the review. The failu

Re: [Intel-gfx] [PATCH] drm/i915/guc, docs: Fix pdfdocs build error by removing nested grid

On Mon, 20 Sep 2021, Akira Yokosawa wrote: > Nested grids in grid-table cells are not specified as proper ReST > constructs. > Commit 572f2a5cd974 ("drm/i915/guc: Update firmware to v62.0.0") > added a couple of kerneldoc tables of the form: > > +---+---+-

Re: [Intel-gfx] [PATCH v6 3/9] drm/i915/gt: Increase suspend timeout

On 23/09/2021 14:19, Thomas Hellström wrote: On 9/23/21 2:59 PM, Tvrtko Ursulin wrote: On 23/09/2021 12:47, Thomas Hellström wrote: Hi, Tvrtko, On 9/23/21 12:13 PM, Tvrtko Ursulin wrote: On 22/09/2021 07:25, Thomas Hellström wrote: With GuC submission on DG1, the execution of the reques

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/uncore: fwtable read handlers are now used on all forcewake platforms

On Thu, Sep 23, 2021 at 03:44:00AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/uncore: fwtable read handlers are now used on all forcewake > platforms > URL : https://patchwork.freedesktop.org/series/94975/ > State : success > > == Summary == > > CI Bug Log - changes f

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Tile F plane format support (rev2)

== Series Details == Series: drm/i915: Tile F plane format support (rev2) URL : https://patchwork.freedesktop.org/series/94983/ State : success == Summary == CI Bug Log - changes from CI_DRM_10630 -> Patchwork_21145 Summary --- **SUC

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Flush buffer pools on driver remove

On Thu, Sep 23, 2021 at 03:07:06PM +0200, Janusz Krzysztofik wrote: > Hi Matt, > > Thanks for review. > > On czwartek, 23 września 2021 00:24:29 CEST Matt Roper wrote: > > On Fri, Sep 03, 2021 at 04:23:20PM +0200, Janusz Krzysztofik wrote: > > > In preparation for clean driver release, attempts t

Re: [Intel-gfx] [PATCH 2/3] drm/i915/display: Wait PSR2 get out of deep sleep to update pipe

On 9/17/21 11:52 PM, José Roberto de Souza wrote: Alderlake-P was getting 'max time under evasion' messages when PSR2 was enabled, this is due PIPE_SCANLINE/PIPEDSL returning 0 over a period of time longer than VBLANK_EVASION_TIME_US. For PSR1 we had the same issue so intel_psr_wait_for_idle(

Re: [Intel-gfx] [PATCH 05/14] drm/i915: Fix HPLL watermark readout for g4x

On Wed, Sep 22, 2021 at 05:05:12PM +0300, Ville Syrjälä wrote: > On Fri, Sep 17, 2021 at 06:34:22PM +0300, Lisovskiy, Stanislav wrote: > > On Fri, May 14, 2021 at 03:57:42PM +0300, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > If HPLL watermarks are already enabled, let's not mark th

Re: [Intel-gfx] [PATCH v6 3/9] drm/i915/gt: Increase suspend timeout

On 9/23/21 2:59 PM, Tvrtko Ursulin wrote: On 23/09/2021 12:47, Thomas Hellström wrote: Hi, Tvrtko, On 9/23/21 12:13 PM, Tvrtko Ursulin wrote: On 22/09/2021 07:25, Thomas Hellström wrote: With GuC submission on DG1, the execution of the requests times out for the gem_exec_suspend igt test

[Intel-gfx] [PATCH] drm/i915: Tile F plane format support

TileF(Tile4 in bspec) format is 4K tile organized into 64B subtiles with same basic shape as for legacy TileY which will be supported by Display13. v2: - Fixed wrong case condition(Jani Nikula) - Increased I915_FORMAT_MOD_F_TILED up to 12(Imre Deak) Cc: Imre Deak Cc: Matt Roper Cc: Maarten

Re: [Intel-gfx] [PATCH RESEND] drm/i915: Flush buffer pools on driver remove

Hi Matt, Thanks for review. On czwartek, 23 września 2021 00:24:29 CEST Matt Roper wrote: > On Fri, Sep 03, 2021 at 04:23:20PM +0200, Janusz Krzysztofik wrote: > > In preparation for clean driver release, attempts to drain work queues > > and release freed objects are taken at driver remove time.

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/25] dma-buf: add dma_resv_for_each_fence_unlocked v5

== Series Details == Series: series starting with [01/25] dma-buf: add dma_resv_for_each_fence_unlocked v5 URL : https://patchwork.freedesktop.org/series/94992/ State : failure == Summary == CI Bug Log - changes from CI_DRM_10630 -> Patchwork_21144

Re: [Intel-gfx] [PATCH v6 3/9] drm/i915/gt: Increase suspend timeout

On 23/09/2021 12:47, Thomas Hellström wrote: Hi, Tvrtko, On 9/23/21 12:13 PM, Tvrtko Ursulin wrote: On 22/09/2021 07:25, Thomas Hellström wrote: With GuC submission on DG1, the execution of the requests times out for the gem_exec_suspend igt test case after executing around 800-900 of 1000

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/25] dma-buf: add dma_resv_for_each_fence_unlocked v5

== Series Details == Series: series starting with [01/25] dma-buf: add dma_resv_for_each_fence_unlocked v5 URL : https://patchwork.freedesktop.org/series/94992/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/25] dma-buf: add dma_resv_for_each_fence_unlocked v5

== Series Details == Series: series starting with [01/25] dma-buf: add dma_resv_for_each_fence_unlocked v5 URL : https://patchwork.freedesktop.org/series/94992/ State : warning == Summary == $ dim checkpatch origin/drm-tip 56de5e82f37e dma-buf: add dma_resv_for_each_fence_unlocked v5 -:23: WA

[Intel-gfx] [PATCH 21/25] drm: use new iterator in drm_gem_plane_helper_prepare_fb

Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem_atomic_helper.c | 13 +++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/drm_gem_atomic_helper.c b/driv

[Intel-gfx] [PATCH 15/25] drm/i915: use the new iterator in i915_sw_fence_await_reservation v3

Simplifying the code a bit. v2: use dma_resv_for_each_fence instead, according to Tvrtko the lock is held here anyway. v3: back to using dma_resv_for_each_fence_unlocked. Signed-off-by: Christian König --- drivers/gpu/drm/i915/i915_sw_fence.c | 53 ++-- 1 file change

[Intel-gfx] [PATCH 19/25] drm/i915: use new cursor in intel_prepare_plane_fb

Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/display/intel_display.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c index 134a6acbd8fb..

[Intel-gfx] [PATCH 11/25] drm/msm: use new iterator in msm_gem_describe

Simplifying the code a bit. Also drop the RCU read side lock since the object is locked anyway. Untested since I can't get the driver to compile on !ARM. Signed-off-by: Christian König --- drivers/gpu/drm/msm/msm_gem.c | 19 +-- 1 file changed, 5 insertions(+), 14 deletions(-)

[Intel-gfx] [PATCH 12/25] drm/radeon: use new iterator in radeon_sync_resv

Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/radeon/radeon_sync.c | 22 +++--- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/gpu/drm/radeon/radeon_sync.c b/drivers/gpu/drm/radeon/radeon_sync.c index 9257b60144c4..b991ba1

[Intel-gfx] [PATCH 08/25] drm/amdgpu: use the new iterator in amdgpu_sync_resv

Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c | 44 1 file changed, 14 insertions(+), 30 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_sync.c index 862eb3

[Intel-gfx] [PATCH 20/25] drm: use new iterator in drm_gem_fence_array_add_implicit v3

Simplifying the code a bit. v2: add missing rcu_read_lock()/unlock() v3: switch to locked version Signed-off-by: Christian König --- drivers/gpu/drm/drm_gem.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/drm_gem.c b/drivers/gpu/

[Intel-gfx] [PATCH 25/25] drm/etnaviv: replace dma_resv_get_excl_unlocked

We certainly hold the reservation lock here, no need for the RCU dance. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c b/drivers/gpu/drm/etnaviv/etna

[Intel-gfx] [PATCH 07/25] drm/ttm: use the new iterator in ttm_bo_flush_all_fences

This is probably a fix since we didn't even grabed a reference to the fences. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/ttm/ttm_bo.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_bo.c b/drivers/g

[Intel-gfx] [PATCH 24/25] drm/etnaviv: use new iterator in etnaviv_gem_describe

Instead of hand rolling the logic. Signed-off-by: Christian König --- drivers/gpu/drm/etnaviv/etnaviv_gem.c | 31 ++- 1 file changed, 11 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/etnaviv/etnaviv_gem.c b/drivers/gpu/drm/etnaviv/etnaviv_gem.c index 8f1b5

Re: [Intel-gfx] [PATCH 13/26] drm/i915: use the new iterator in i915_gem_busy_ioctl

Am 22.09.21 um 12:21 schrieb Tvrtko Ursulin: On 22/09/2021 10:10, Christian König wrote: This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König ---   drivers/gpu/drm/i915/gem/i915_gem_busy.c | 35 ++--  

[Intel-gfx] [PATCH 09/25] drm/amdgpu: use new iterator in amdgpu_ttm_bo_eviction_valuable

Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c | 14 -- 1 file changed, 4 insertions(+), 10 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_ttm.c index 1129e17e9f09..4511cd

[Intel-gfx] [PATCH 22/25] drm/nouveau: use the new iterator in nouveau_fence_sync

Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/nouveau_fence.c | 48 +++-- 1 file changed, 12 insertions(+), 36 deletions(-) diff --git a/drivers/gpu/drm/nouveau/nouveau_fence.c b/drivers/gpu/drm/nouveau/nouveau_fence.c index 05d0b3eb

[Intel-gfx] [PATCH 04/25] dma-buf: use new iterator in dma_resv_get_fences v3

This makes the function much simpler since the complex retry logic is now handled elsewhere. v2: use sizeof(void*) instead v3: fix rebase bug Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 108 - 1 file changed, 35

[Intel-gfx] [PATCH 03/25] dma-buf: use new iterator in dma_resv_copy_fences

This makes the function much simpler since the complex retry logic is now handled else where. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 84 +++--- 1 file changed, 32 insertions(+), 52 deletions(-) diff --git a/dri

[Intel-gfx] [PATCH 23/25] drm/nouveau: use the new interator in nv50_wndw_prepare_fb

Makes the handling a bit more complex, but avoids the use of dma_resv_get_excl_unlocked(). Signed-off-by: Christian König --- drivers/gpu/drm/nouveau/dispnv50/wndw.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/nouveau/dispnv50/wndw.c b/drivers/g

[Intel-gfx] [PATCH 06/25] dma-buf: use new iterator in dma_resv_test_signaled

This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 57 +- 1 file changed, 7 insertions(+), 50 deletions(-) diff --git a/drive

[Intel-gfx] [PATCH 10/25] drm/amdgpu: use new iterator in amdgpu_vm_prt_fini

No need to actually allocate an array of fences here. Signed-off-by: Christian König --- drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c | 26 +- 1 file changed, 5 insertions(+), 21 deletions(-) diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c b/drivers/gpu/drm/amd/amdgpu/amd

[Intel-gfx] [PATCH 16/25] drm/i915: use the new iterator in i915_request_await_object v2

Simplifying the code a bit. v2: add missing rcu_read_lock()/rcu_read_unlock() v3: use dma_resv_for_each_fence instead Signed-off-by: Christian König Reviewed-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_request.c | 34 + 1 file changed, 5 insertions(+), 29 delet

[Intel-gfx] [PATCH 17/25] drm/i915: use new iterator in i915_gem_object_wait_reservation

Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 51 +--- 1 file changed, 9 insertions(+), 42 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index f909aaa

[Intel-gfx] [PATCH 13/25] drm/scheduler: use new iterator in drm_sched_job_add_implicit_dependencies v2

Simplifying the code a bit. v2: use dma_resv_for_each_fence Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/gpu/drm/scheduler/sched_main.c | 26 ++ 1 file changed, 6 insertions(+), 20 deletions(-) diff --git a/drivers/gpu/drm/scheduler/sched_main.

[Intel-gfx] [PATCH 01/25] dma-buf: add dma_resv_for_each_fence_unlocked v5

Abstract the complexity of iterating over all the fences in a dma_resv object. The new loop handles the whole RCU and retry dance and returns only fences where we can be sure we grabbed the right one. v2: fix accessing the shared fences while they might be freed, improve kerneldoc, rename _cu

[Intel-gfx] [PATCH 18/25] drm/i915: use new iterator in i915_gem_object_wait_priority

Simplifying the code a bit. Signed-off-by: Christian König --- drivers/gpu/drm/i915/gem/i915_gem_wait.c | 31 +--- 1 file changed, 6 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/gem/i915_gem_wait.c b/drivers/gpu/drm/i915/gem/i915_gem_wait.c index a13193d

Re: [Intel-gfx] [PATCH 01/26] dma-buf: add dma_resv_for_each_fence_unlocked v4

Am 22.09.21 um 16:36 schrieb Tvrtko Ursulin: + +/** + * dma_resv_iter_first_unlocked - first fence in an unlocked dma_resv obj. + * @cursor: the cursor with the current position + * + * Returns the first fence from an unlocked dma_resv obj. + */ +struct dma_fence *dma_resv_iter_first_unlocked(s

[Intel-gfx] [PATCH 05/25] dma-buf: use new iterator in dma_resv_wait_timeout

This makes the function much simpler since the complex retry logic is now handled elsewhere. Signed-off-by: Christian König Reviewed-by: Daniel Vetter --- drivers/dma-buf/dma-resv.c | 69 +- 1 file changed, 8 insertions(+), 61 deletions(-) diff --git a/drive

  1   2   >