Re: [Intel-gfx] [PATCH v4 06/16] drm/i915/hdcp: HDCP stream encryption support

2020-11-05 Thread Ramalingam C
On 2020-11-06 at 10:52:03 +0530, Anshuman Gupta wrote: > On 2020-11-05 at 21:04:03 +0530, Ramalingam C wrote: > > On 2020-10-27 at 22:11:58 +0530, Anshuman Gupta wrote: > > > Both HDCP_{1.x,2.x} requires to select/deselect Multistream HDCP bit > > > in TRANS_DDI_FUNC_CTL in order to enable/disable

Re: [Intel-gfx] [PATCH v4 08/16] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-11-05 Thread Ramalingam C
On 2020-11-06 at 10:20:35 +0530, Anshuman Gupta wrote: > On 2020-11-05 at 22:09:12 +0530, Ramalingam C wrote: > > On 2020-10-27 at 22:12:00 +0530, Anshuman Gupta wrote: > > > Pass dig_port as an argument to intel_hdcp_init() > > > and intel_hdcp2_init(). > > > This will be required for HDCP 2.2 str

Re: [Intel-gfx] [PATCH v4 07/16] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-05 Thread Anshuman Gupta
On 2020-11-05 at 21:11:52 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:11:59 +0530, Anshuman Gupta wrote: > > Enable HDCP 1.4 over DP MST for Gen12. > > This also enable the stream encryption support for > > older generations, which was missing earlier. > It will be nice to have them in separat

Re: [Intel-gfx] [PATCH v4 12/16] drm/i915/hdcp: MST streams support in hdcp port_data

2020-11-05 Thread Anshuman Gupta
On 2020-11-05 at 22:04:15 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:12:04 +0530, Anshuman Gupta wrote: > > Add support for multiple mst stream in hdcp port data > > which will be used by RepeaterAuthStreamManage msg and > > HDCP 2.2 security f/w for m' validation. > > > > v2: > > Init the h

Re: [Intel-gfx] [PATCH] drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms

2020-11-05 Thread Jani Nikula
On Thu, 05 Nov 2020, Lucas De Marchi wrote: > On Thu, Nov 05, 2020 at 10:47:15AM +0530, Anshuman Gupta wrote: >>On 2020-11-03 at 17:06:42 -0500, Rodrigo Vivi wrote: >>> On Fri, Oct 30, 2020 at 11:46:58AM +0530, Anshuman Gupta wrote: >>> > From: Bob Paauwe >>> > >>> > The WA specifies that we need

Re: [Intel-gfx] [PATCH v4 06/16] drm/i915/hdcp: HDCP stream encryption support

2020-11-05 Thread Anshuman Gupta
On 2020-11-05 at 21:04:03 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:11:58 +0530, Anshuman Gupta wrote: > > Both HDCP_{1.x,2.x} requires to select/deselect Multistream HDCP bit > > in TRANS_DDI_FUNC_CTL in order to enable/disable stream HDCP > > encryption over DP MST Transport Link. > > > >

Re: [Intel-gfx] [PATCH v4 13/16] drm/i915/hdcp: Pass connector to check_2_2_link

2020-11-05 Thread Anshuman Gupta
On 2020-11-05 at 22:15:37 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:12:05 +0530, Anshuman Gupta wrote: > > This requires for HDCP 2.2 MST check link. > > > > Cc: Ramalingam C > > Reviewed-by: Uma Shankar > > Signed-off-by: Anshuman Gupta > > --- > > drivers/gpu/drm/i915/display/intel_di

[Intel-gfx] ✗ Fi.CI.BAT: failure for Big Joiner End End enabling with 8K@30, 60

2020-11-05 Thread Patchwork
== Series Details == Series: Big Joiner End End enabling with 8K@30, 60 URL : https://patchwork.freedesktop.org/series/83556/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9276 -> Patchwork_18865 Summary --- **FAILUR

Re: [Intel-gfx] [PATCH v4 08/16] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-11-05 Thread Anshuman Gupta
On 2020-11-05 at 22:09:12 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:12:00 +0530, Anshuman Gupta wrote: > > Pass dig_port as an argument to intel_hdcp_init() > > and intel_hdcp2_init(). > > This will be required for HDCP 2.2 stream encryption. > > > > Cc: Ramalingam C > > Reviewed-by: Uma S

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Big Joiner End End enabling with 8K@30, 60

2020-11-05 Thread Patchwork
== Series Details == Series: Big Joiner End End enabling with 8K@30, 60 URL : https://patchwork.freedesktop.org/series/83556/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit won't be checked separately. - +drivers/gpu/drm/i915

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Big Joiner End End enabling with 8K@30, 60

2020-11-05 Thread Patchwork
== Series Details == Series: Big Joiner End End enabling with 8K@30, 60 URL : https://patchwork.freedesktop.org/series/83556/ State : warning == Summary == $ dim checkpatch origin/drm-tip c255c8a307f4 drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes 3140cb9ed5f5 drm/i91

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Correctly set SFC capability for video engines

2020-11-05 Thread Patchwork
== Series Details == Series: drm/i915: Correctly set SFC capability for video engines URL : https://patchwork.freedesktop.org/series/83551/ State : success == Summary == CI Bug Log - changes from CI_DRM_9274_full -> Patchwork_18864_full Sum

[Intel-gfx] [PATCH v15 09/14] drm/i915/dp: Modify VDSC helpers to configure DSC for Bigjoiner slave

2020-11-05 Thread Manasi Navare
Make vdsc work when no output is enabled. The big joiner needs VDSC on the slave, so enable it and set the appropriate bits. So remove encoder usage from dsc functions. Signed-off-by: Manasi Navare --- drivers/gpu/drm/i915/display/icl_dsi.c | 2 +- drivers/gpu/drm/i915/display/intel_ddi.

[Intel-gfx] [PATCH v15 00/14] Big Joiner End End enabling with 8K@30, 60

2020-11-05 Thread Manasi Navare
Maarten Lankhorst (6): drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3. drm/i915: Try to make bigjoiner work in atomic check drm/i915: Link planes in a bigjoiner configuration, v3. drm/i915: Add bigjoi

[Intel-gfx] [PATCH v15 06/14] drm/i915/dp: Add from_crtc_state to copy color blobs

2020-11-05 Thread Manasi Navare
No functional changes here, just adds a from_crtc_state as a prep for bigjoiner v2: * More prep with intel_atomic_state (Ville) Cc: Ville Syrjälä Signed-off-by: Manasi Navare Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic.c | 9 + drivers/gpu/drm/i915/displa

[Intel-gfx] [PATCH v15 07/14] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3.

2020-11-05 Thread Manasi Navare
From: Maarten Lankhorst Small changes to intel_dp_mode_valid(), allow listing modes that can only be supported in the bigjoiner configuration, which is not supported yet. v13: * Allow bigjoiner if hdisplay >5120 v12: * slice_count logic simplify (Ville) * Fix unnecessary changes in downstream_mo

[Intel-gfx] [PATCH v15 04/14] drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split

2020-11-05 Thread Manasi Navare
From: Maarten Lankhorst With bigjoiner, there will be 2 pipes driving 2 halves of 1 transcoder, because of this, we need a pipe_mode for various calculations, including for example watermarks, plane clipping, etc. v10: * remove redundant pipe_mode assignment (Ville) v9: * pipe_mode in state dump

[Intel-gfx] [PATCH v15 05/14] drm/i915: Pass intel_atomic_state instead of drm_atomic_state

2020-11-05 Thread Manasi Navare
No functional changes, to align with previous cleanups pass intel_atomic_state instead of drm_atomic_state. Also pass this intel_atomic_state with crtc_state to some of the atomic_check functions. v2: * Squash some changes from next patch (Ville) Signed-off-by: Manasi Navare Reviewed-by: Ville S

[Intel-gfx] [PATCH v15 10/14] drm/i915/dp: Master/Slave enable/disable sequence for bigjoiner

2020-11-05 Thread Manasi Navare
Enabling is done in a special sequence and so should plane updates be. Ideally the end user never notices the second pipe is used. This way ideally everything will be tear free, and updates are really atomic as userspace expects it. This uses generic modeset_enables() calls like trans port sync b

[Intel-gfx] [PATCH v15 08/14] drm/i915: Try to make bigjoiner work in atomic check

2020-11-05 Thread Manasi Navare
From: Maarten Lankhorst When the clock is higher than the dotclock, try with 2 pipes enabled. If we can enable 2, then we will go into big joiner mode, and steal the adjacent crtc. This only links the crtc's in software, no hardware or plane programming is done yet. Blobs are also copied fr

[Intel-gfx] [PATCH v15 13/14] drm/i915: Add bigjoiner aware plane clipping checks

2020-11-05 Thread Manasi Navare
From: Maarten Lankhorst We need to look at hw.fb for the framebuffer, and add the translation for the slave_plane_state. With these changes we set the correct rectangle on the bigjoiner slave, and don't set incorrect src/dst/visibility on the slave plane. v2: * Manual rebase (Manasi) v3: * hw.r

[Intel-gfx] [PATCH v15 11/14] drm/i915: HW state readout for Bigjoiner case

2020-11-05 Thread Manasi Navare
Skip iterating over bigjoiner slaves, only the master has the state we care about. Add the width of the bigjoiner slave to the reconstructed fb. Hide the bigjoiner slave to userspace, and double the mode on bigjoiner master. And last, disable bigjoiner slave from primary if reconstruction fails.

[Intel-gfx] [PATCH v15 03/14] drm/i915/dp: Add a wrapper function around get_pipe_config

2020-11-05 Thread Manasi Navare
Create a new function intel_crtc_get_pipe_config() that calls platform specific hooks for get_pipe_config() No functional change here. Suggested-by: Ville Syrjälä Signed-off-by: Manasi Navare Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 14 +++--- 1 fil

[Intel-gfx] [PATCH v15 01/14] drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes

2020-11-05 Thread Manasi Navare
No functional changes. This patch just moves some mode checks around to prepare for adding bigjoiner related mode validation Cc: Ville Syrjälä Signed-off-by: Manasi Navare Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 12 ++-- 1 file changed, 6 insertions(+),

[Intel-gfx] [PATCH v15 02/14] drm/i915: Move encoder->get_config to a new function

2020-11-05 Thread Manasi Navare
No functional changes, create a separate intel_encoder_get_config() function that calls encoder->get_config hook. This is needed so that later we can add beigjoienr related readout here. Signed-off-by: Manasi Navare Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 1

[Intel-gfx] [PATCH v15 14/14] drm/i915: Add debugfs dumping for bigjoiner, v3.

2020-11-05 Thread Manasi Navare
From: Maarten Lankhorst Dump debugfs and planar links as well, this will make it easier to debug when things go wrong. v4: * Rebase Changes since v1: - Report planar slaves as such, now that we have the plane_state switch. Changes since v2: - Rebase on top of the new plane format dumping Signed

[Intel-gfx] [PATCH v15 12/14] drm/i915: Link planes in a bigjoiner configuration, v3.

2020-11-05 Thread Manasi Navare
From: Maarten Lankhorst Make sure that when a plane is set in a bigjoiner mode, we will add their counterpart to the atomic state as well. This will allow us to make sure all state is available when planes are checked. Because of the funny interactions with bigjoiner and planar YUV formats, w

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Correctly set SFC capability for video engines

2020-11-05 Thread Patchwork
== Series Details == Series: drm/i915: Correctly set SFC capability for video engines URL : https://patchwork.freedesktop.org/series/83551/ State : success == Summary == CI Bug Log - changes from CI_DRM_9274 -> Patchwork_18864 Summary -

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/gem: Drop free_work for GEM contexts (rev2)

2020-11-05 Thread Patchwork
== Series Details == Series: drm/i915/gem: Drop free_work for GEM contexts (rev2) URL : https://patchwork.freedesktop.org/series/83537/ State : success == Summary == CI Bug Log - changes from CI_DRM_9273_full -> Patchwork_18862_full Summary

[Intel-gfx] [PATCH] drm/i915: Correctly set SFC capability for video engines

2020-11-05 Thread Daniele Ceraolo Spurio
From: Venkata Sandeep Dhanalakota SFC capability of video engines is not set correctly because i915 is testing for incorrect bits. Fixes: c5d3e39caa45 ("drm/i915: Engine discovery query") Cc: Matt Roper Cc: Tvrtko Ursulin Signed-off-by: Venkata Sandeep Dhanalakota Signed-off-by: Daniele Cerao

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for Final prep series for bigjoiner

2020-11-05 Thread Navare, Manasi
Hi, Here the failures are happening in: i915_gem_object_create_stolen_for_preallocated causing the BAT failure. Thsi is unrelated to the changes in this patch. Manasi On Thu, Nov 05, 2020 at 11:43:41PM +, Patchwork wrote: > == Series Details == > > Series: Final prep series for bigjoiner >

[Intel-gfx] ✗ Fi.CI.BAT: failure for Final prep series for bigjoiner

2020-11-05 Thread Patchwork
== Series Details == Series: Final prep series for bigjoiner URL : https://patchwork.freedesktop.org/series/83547/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9274 -> Patchwork_18863 Summary --- **FAILURE** Seri

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Final prep series for bigjoiner

2020-11-05 Thread Patchwork
== Series Details == Series: Final prep series for bigjoiner URL : https://patchwork.freedesktop.org/series/83547/ State : warning == Summary == $ dim checkpatch origin/drm-tip a1e5aa27e03c drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes 5c583972c6ab drm/i915: Move enc

Re: [Intel-gfx] [PATCH] drm/i915: Tweaked Wa_14010685332 for PCHs used on gen11 platforms

2020-11-05 Thread Lucas De Marchi
On Thu, Nov 05, 2020 at 10:47:15AM +0530, Anshuman Gupta wrote: On 2020-11-03 at 17:06:42 -0500, Rodrigo Vivi wrote: On Fri, Oct 30, 2020 at 11:46:58AM +0530, Anshuman Gupta wrote: > From: Bob Paauwe > > The WA specifies that we need to toggle a SDE chicken bit on and then > off as the final st

[Intel-gfx] [PATCH v7 3/7] drm/i915/dp: Add a wrapper function around get_pipe_config

2020-11-05 Thread Manasi Navare
Create a new function intel_crtc_get_pipe_config() that calls platform specific hooks for get_pipe_config() No functional change here. Suggested-by: Ville Syrjälä Signed-off-by: Manasi Navare Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 14 +++--- 1 fil

[Intel-gfx] [PATCH v7 0/7] Final prep series for bigjoiner

2020-11-05 Thread Manasi Navare
Addressed all review comments in this, sending this to get final CI results Maarten Lankhorst (2): drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3. Manasi Navare (5): drm/i915/dp: Some reshuffling in mode_v

[Intel-gfx] [PATCH v7 6/7] drm/i915/dp: Add from_crtc_state to copy color blobs

2020-11-05 Thread Manasi Navare
No functional changes here, just adds a from_crtc_state as a prep for bigjoiner v2: * More prep with intel_atomic_state (Ville) Cc: Ville Syrjälä Signed-off-by: Manasi Navare Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_atomic.c | 9 + drivers/gpu/drm/i915/displa

[Intel-gfx] [PATCH v7 7/7] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3.

2020-11-05 Thread Manasi Navare
From: Maarten Lankhorst Small changes to intel_dp_mode_valid(), allow listing modes that can only be supported in the bigjoiner configuration, which is not supported yet. v13: * Allow bigjoiner if hdisplay >5120 v12: * slice_count logic simplify (Ville) * Fix unnecessary changes in downstream_mo

[Intel-gfx] [PATCH v7 1/7] drm/i915/dp: Some reshuffling in mode_valid as prep for bigjoiner modes

2020-11-05 Thread Manasi Navare
No functional changes. This patch just moves some mode checks around to prepare for adding bigjoiner related mode validation Cc: Ville Syrjälä Signed-off-by: Manasi Navare Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_dp.c | 12 ++-- 1 file changed, 6 insertions(+),

[Intel-gfx] [PATCH v7 2/7] drm/i915: Move encoder->get_config to a new function

2020-11-05 Thread Manasi Navare
No functional changes, create a separate intel_encoder_get_config() function that calls encoder->get_config hook. This is needed so that later we can add beigjoienr related readout here. Signed-off-by: Manasi Navare Reviewed-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 1

[Intel-gfx] [PATCH v7 5/7] drm/i915: Pass intel_atomic_state instead of drm_atomic_state

2020-11-05 Thread Manasi Navare
No functional changes, to align with previous cleanups pass intel_atomic_state instead of drm_atomic_state. Also pass this intel_atomic_state with crtc_state to some of the atomic_check functions. v2: * Squash some changes from next patch (Ville) Signed-off-by: Manasi Navare Reviewed-by: Ville S

[Intel-gfx] [PATCH v7 4/7] drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split

2020-11-05 Thread Manasi Navare
From: Maarten Lankhorst With bigjoiner, there will be 2 pipes driving 2 halves of 1 transcoder, because of this, we need a pipe_mode for various calculations, including for example watermarks, plane clipping, etc. v10: * remove redundant pipe_mode assignment (Ville) v9: * pipe_mode in state dump

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/2] drm/i915/gem: Allow backends to override pread implementation

2020-11-05 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gem: Allow backends to override pread implementation URL : https://patchwork.freedesktop.org/series/83541/ State : success == Summary == CI Bug Log - changes from CI_DRM_9271_full -> Patchwork_18861_full =

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gem: Drop free_work for GEM contexts (rev2)

2020-11-05 Thread Patchwork
== Series Details == Series: drm/i915/gem: Drop free_work for GEM contexts (rev2) URL : https://patchwork.freedesktop.org/series/83537/ State : success == Summary == CI Bug Log - changes from CI_DRM_9273 -> Patchwork_18862 Summary ---

Re: [Intel-gfx] [PATCH v6 3/6] drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split

2020-11-05 Thread Navare, Manasi
On Thu, Nov 05, 2020 at 06:15:11PM +0200, Ville Syrjälä wrote: > On Thu, Nov 05, 2020 at 08:03:01AM -0800, Navare, Manasi wrote: > > On Thu, Nov 05, 2020 at 05:13:04PM +0200, Ville Syrjälä wrote: > > > On Mon, Nov 02, 2020 at 03:04:00PM -0800, Manasi Navare wrote: > > > > From: Maarten Lankhorst >

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [RFC,1/2] drm/i915: Improve record of hung engines in error state (rev2)

2020-11-05 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915: Improve record of hung engines in error state (rev2) URL : https://patchwork.freedesktop.org/series/83497/ State : success == Summary == CI Bug Log - changes from CI_DRM_9269_full -> Patchwork_18859_full ===

[Intel-gfx] [PATCH v2] drm/i915/gem: Drop free_work for GEM contexts

2020-11-05 Thread Chris Wilson
The free_list and worker was introduced in commit 5f09a9c8ab6b ("drm/i915: Allow contexts to be unreferenced locklessly"), but subsequently made redundant by the removal of the last sleeping lock in commit 2935ed5339c4 ("drm/i915: Remove logical HW ID"). As we can now free the GEM context immediate

[Intel-gfx] [PATCH i-g-t] i915/gem_pread, gem_pwrite: Exercise exhaustion

2020-11-05 Thread Chris Wilson
Use userfault to arbitrarily delay the completion of copy_from_user() in order to trap many, many threads inside the core of gem_pread/gem_pwrite. This allows us to exhaust the preferred paths and potentially trip over unexpected fallback paths. Suggested-by: Matthew Auld Signed-off-by: Chris Wil

Re: [Intel-gfx] [CI 2/2] drm/i915/gem: Pull phys pread/pwrite implementations to the backend

2020-11-05 Thread Chris Wilson
Quoting Chris Wilson (2020-11-05 15:49:34) > Move the specialised interactions with the physical GEM object from the > pread/pwrite ioctl handler into the phys backend. > Fixes: c6790dc22312 ("drm/i915: Wean off drm_pci_alloc/drm_pci_free") Testcase: igt/gem_pwrite/exhaustion > Signed-off-by: Chr

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display/tgl: Disable FBC with PSR2

2020-11-05 Thread Shankar, Uma
> -Original Message- > From: Souza, Jose > Sent: Thursday, November 5, 2020 11:09 PM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/display/tgl: Disable FBC with > PSR2 > > On Thu, 2020-11-05 at 21:57 +0530, Shankar, Uma wrote: > >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/2] drm/i915/gem: Allow backends to override pread implementation

2020-11-05 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gem: Allow backends to override pread implementation URL : https://patchwork.freedesktop.org/series/83541/ State : success == Summary == CI Bug Log - changes from CI_DRM_9271 -> Patchwork_18861 ===

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display/tgl: Disable FBC with PSR2

2020-11-05 Thread Souza, Jose
On Thu, 2020-11-05 at 21:57 +0530, Shankar, Uma wrote: > > > -Original Message- > > From: Souza, Jose > > Sent: Thursday, November 5, 2020 9:38 PM > > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/display/tgl: Disable FBC with > > PS

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [CI,1/2] drm/i915/gem: Allow backends to override pread implementation

2020-11-05 Thread Patchwork
== Series Details == Series: series starting with [CI,1/2] drm/i915/gem: Allow backends to override pread implementation URL : https://patchwork.freedesktop.org/series/83541/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit wo

[Intel-gfx] [PULL] drm-intel-fixes

2020-11-05 Thread Rodrigo Vivi
Hi Dave and Daniel, This includes gvt-fixes that had come last week, now with clean tags for dim. Also, 306bb61d6bb3 ("drm/i915/gt: Expose more parameters for emitting writes into the ring") is only a dependency of its following patch. In summary: drm-intel-fixes-2020-11-05: - GVT fixes includ

Re: [Intel-gfx] [PATCH v4 14/16] drm/i915/hdcp: Add HDCP 2.2 stream register

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:12:06 +0530, Anshuman Gupta wrote: > Add HDCP 2.2 DP MST HDCP2_STREAM_STATUS > and HDCP2_AUTH_STREAM register in i915_reg header. Reviewed-by: Ramalingam C > > Cc: Ramalingam C > Reviewed-by: Uma Shankar > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/i915_re

Re: [Intel-gfx] [PATCH v4 13/16] drm/i915/hdcp: Pass connector to check_2_2_link

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:12:05 +0530, Anshuman Gupta wrote: > This requires for HDCP 2.2 MST check link. > > Cc: Ramalingam C > Reviewed-by: Uma Shankar > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i915/display/intel_display_types.h | 3 ++- > drivers/gpu/drm/i915/display/intel_dp_hdcp.c

Re: [Intel-gfx] [PATCH v4 08/16] drm/i915/hdcp: Pass dig_port to intel_hdcp_init

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:12:00 +0530, Anshuman Gupta wrote: > Pass dig_port as an argument to intel_hdcp_init() > and intel_hdcp2_init(). > This will be required for HDCP 2.2 stream encryption. > > Cc: Ramalingam C > Reviewed-by: Uma Shankar > Signed-off-by: Anshuman Gupta > --- > drivers/gpu/drm/i

Re: [Intel-gfx] [PATCH v4 12/16] drm/i915/hdcp: MST streams support in hdcp port_data

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:12:04 +0530, Anshuman Gupta wrote: > Add support for multiple mst stream in hdcp port data > which will be used by RepeaterAuthStreamManage msg and > HDCP 2.2 security f/w for m' validation. > > v2: > Init the hdcp port data k for HDMI/DP SST strem. > > v3: > Cosmetic changes.

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ehl: Implement W/A 22010492432 (rev3)

2020-11-05 Thread Souza, Jose
On Wed, 2020-11-04 at 08:43 +, Patchwork wrote: Patch Details Series: drm/i915/ehl: Implement W/A 22010492432 (rev3) URL:https://patchwork.freedesktop.org/series/83135/ State: failure Details: https://intel-gfx-ci.01.org/tree/drm-tip/Patchwork_18848/index.html CI Bug Log - changes

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display/tgl: Disable FBC with PSR2

2020-11-05 Thread Shankar, Uma
> -Original Message- > From: Souza, Jose > Sent: Thursday, November 5, 2020 9:38 PM > To: Shankar, Uma ; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 1/2] drm/i915/display/tgl: Disable FBC with > PSR2 > > On Thu, 2020-11-05 at 01:26 +0530, Uma Shankar wrote: > > Th

Re: [Intel-gfx] [PATCH v6 6/6] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3.

2020-11-05 Thread Ville Syrjälä
On Tue, Nov 03, 2020 at 08:00:40AM -0800, Manasi Navare wrote: > From: Maarten Lankhorst > > Small changes to intel_dp_mode_valid(), allow listing modes that > can only be supported in the bigjoiner configuration, which is > not supported yet. > > v13: > * Allow bigjoiner if hdisplay >5120 > v12

Re: [Intel-gfx] [PATCH 02/22] drm/i915/gem: Pull phys pread/pwrite implementations to the backend

2020-11-05 Thread Chris Wilson
Quoting Matthew Auld (2020-11-05 16:02:38) > On Thu, 5 Nov 2020 at 15:45, Chris Wilson wrote: > > > > Quoting Matthew Auld (2020-11-05 15:40:20) > > > On Thu, 5 Nov 2020 at 15:39, Matthew Auld > > > wrote: > > > > > > > > On Thu, 5 Nov 2020 at 10:11, Chris Wilson > > > > wrote: > > > > > > > >

Re: [Intel-gfx] [PATCH v5 5/6] drm/i915/dp: Prep for bigjoiner atomic check

2020-11-05 Thread Ville Syrjälä
On Thu, Nov 05, 2020 at 08:09:38AM -0800, Navare, Manasi wrote: > On Thu, Nov 05, 2020 at 05:23:33PM +0200, Ville Syrjälä wrote: > > On Thu, Nov 05, 2020 at 05:21:31PM +0200, Ville Syrjälä wrote: > > > On Mon, Nov 02, 2020 at 01:19:05PM -0800, Manasi Navare wrote: > > > > No functional changes here

Re: [Intel-gfx] [PATCH v6 3/6] drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split

2020-11-05 Thread Ville Syrjälä
On Thu, Nov 05, 2020 at 08:03:01AM -0800, Navare, Manasi wrote: > On Thu, Nov 05, 2020 at 05:13:04PM +0200, Ville Syrjälä wrote: > > On Mon, Nov 02, 2020 at 03:04:00PM -0800, Manasi Navare wrote: > > > From: Maarten Lankhorst > > > > > > With bigjoiner, there will be 2 pipes driving 2 halves of 1

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Drop free_work for GEM contexts

2020-11-05 Thread Patchwork
== Series Details == Series: drm/i915/gem: Drop free_work for GEM contexts URL : https://patchwork.freedesktop.org/series/83537/ State : failure == Summary == CI Bug Log - changes from CI_DRM_9269 -> Patchwork_18860 Summary --- **FAI

Re: [Intel-gfx] [PATCH v6 6/6] drm/i915/dp: Allow big joiner modes in intel_dp_mode_valid(), v3.

2020-11-05 Thread Navare, Manasi
@Ville, any feedback on this patch here? Or should this be usptreamed as part of the core series since this actually allows the 8K modes Manasi On Tue, Nov 03, 2020 at 08:00:40AM -0800, Manasi Navare wrote: > From: Maarten Lankhorst > > Small changes to intel_dp_mode_valid(), allow listing mod

Re: [Intel-gfx] [PATCH v4 11/16] drm/hdcp: Max MST content streams

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:12:03 +0530, Anshuman Gupta wrote: > Let's define Maximum MST content streams up to four > generically which can be supported by modern display > controllers. > > Cc: Sean Paul > Cc: Ramalingam C > Acked-by: Maarten Lankhorst > Reviewed-by: Uma Shankar > Signed-off-by: Ansh

Re: [Intel-gfx] [PATCH v5 5/6] drm/i915/dp: Prep for bigjoiner atomic check

2020-11-05 Thread Navare, Manasi
On Thu, Nov 05, 2020 at 05:23:33PM +0200, Ville Syrjälä wrote: > On Thu, Nov 05, 2020 at 05:21:31PM +0200, Ville Syrjälä wrote: > > On Mon, Nov 02, 2020 at 01:19:05PM -0800, Manasi Navare wrote: > > > No functional changes here. Just pass intel_atomic_state > > > along with crtc_state to certain at

Re: [Intel-gfx] [PATCH 1/2] drm/i915/display/tgl: Disable FBC with PSR2

2020-11-05 Thread Souza, Jose
On Thu, 2020-11-05 at 01:26 +0530, Uma Shankar wrote: > There are some corner cases wrt underrun when we enable > FBC with PSR2 on TGL. Recommendation from hardware is to > keep this combination disabled. Do you have any references to this? HSD? BSpec? > > Signed-off-by: Uma Shankar > --- >  dr

Re: [Intel-gfx] [PATCH v4 10/16] misc/mei/hdcp: Fix AUTH_STREAM_REQ cmd buffer len

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:12:02 +0530, Anshuman Gupta wrote: > Fix the size of WIRED_REPEATER_AUTH_STREAM_REQ cmd buffer size. > It is based upon the actual number of MST streams and size > of wired_cmd_repeater_auth_stream_req_in. > Excluding the size of hdcp_cmd_header. > > v2: > hdcp_cmd_header size

Re: [Intel-gfx] [PATCH 02/22] drm/i915/gem: Pull phys pread/pwrite implementations to the backend

2020-11-05 Thread Matthew Auld
On Thu, 5 Nov 2020 at 15:45, Chris Wilson wrote: > > Quoting Matthew Auld (2020-11-05 15:40:20) > > On Thu, 5 Nov 2020 at 15:39, Matthew Auld > > wrote: > > > > > > On Thu, 5 Nov 2020 at 10:11, Chris Wilson > > > wrote: > > > > > > > > More the specialised interation with the physical GEM objec

Re: [Intel-gfx] [PATCH v6 3/6] drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split

2020-11-05 Thread Navare, Manasi
On Thu, Nov 05, 2020 at 05:13:04PM +0200, Ville Syrjälä wrote: > On Mon, Nov 02, 2020 at 03:04:00PM -0800, Manasi Navare wrote: > > From: Maarten Lankhorst > > > > With bigjoiner, there will be 2 pipes driving 2 halves of 1 transcoder, > > because of this, we need a pipe_mode for various calculat

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [RFC,1/2] drm/i915: Improve record of hung engines in error state (rev2)

2020-11-05 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915: Improve record of hung engines in error state (rev2) URL : https://patchwork.freedesktop.org/series/83497/ State : success == Summary == CI Bug Log - changes from CI_DRM_9269 -> Patchwork_18859 =

[Intel-gfx] [CI 2/2] drm/i915/gem: Pull phys pread/pwrite implementations to the backend

2020-11-05 Thread Chris Wilson
Move the specialised interactions with the physical GEM object from the pread/pwrite ioctl handler into the phys backend. Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/gem/i915_gem_phys.c | 55 drivers/gpu/drm/i915/i915_gem.c |

[Intel-gfx] [CI 1/2] drm/i915/gem: Allow backends to override pread implementation

2020-11-05 Thread Chris Wilson
From: Matthew Auld As there are more and more complicated interactions between the different backing stores and userspace, push the control into the backends rather than accumulate them all inside the ioctl handlers. Signed-off-by: Matthew Auld Reviewed-by: Chris Wilson Signed-off-by: Chris Wi

Re: [Intel-gfx] [PATCH 02/22] drm/i915/gem: Pull phys pread/pwrite implementations to the backend

2020-11-05 Thread Chris Wilson
Quoting Matthew Auld (2020-11-05 15:40:20) > On Thu, 5 Nov 2020 at 15:39, Matthew Auld > wrote: > > > > On Thu, 5 Nov 2020 at 10:11, Chris Wilson wrote: > > > > > > More the specialised interation with the physical GEM object from the > > > > Move interaction > > > > > p

Re: [Intel-gfx] [PATCH v4 07/16] drm/i915/hdcp: Enable Gen12 HDCP 1.4 DP MST support

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:11:59 +0530, Anshuman Gupta wrote: > Enable HDCP 1.4 over DP MST for Gen12. > This also enable the stream encryption support for > older generations, which was missing earlier. It will be nice to have them in separate patches. -Ram > > v2: > - Added debug print for stream encr

Re: [Intel-gfx] [PATCH 02/22] drm/i915/gem: Pull phys pread/pwrite implementations to the backend

2020-11-05 Thread Matthew Auld
On Thu, 5 Nov 2020 at 15:39, Matthew Auld wrote: > > On Thu, 5 Nov 2020 at 10:11, Chris Wilson wrote: > > > > More the specialised interation with the physical GEM object from the > > Move interaction > > > pread/pwrite ioctl handler into the phys backend. > > > > Signed

Re: [Intel-gfx] [PATCH 02/22] drm/i915/gem: Pull phys pread/pwrite implementations to the backend

2020-11-05 Thread Matthew Auld
On Thu, 5 Nov 2020 at 10:11, Chris Wilson wrote: > > More the specialised interation with the physical GEM object from the Move interaction > pread/pwrite ioctl handler into the phys backend. > > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld __

Re: [Intel-gfx] [PATCH v4 06/16] drm/i915/hdcp: HDCP stream encryption support

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:11:58 +0530, Anshuman Gupta wrote: > Both HDCP_{1.x,2.x} requires to select/deselect Multistream HDCP bit > in TRANS_DDI_FUNC_CTL in order to enable/disable stream HDCP > encryption over DP MST Transport Link. > > HDCP 1.4 stream encryption requires to validate the stream encry

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [RFC,1/2] drm/i915: Improve record of hung engines in error state (rev2)

2020-11-05 Thread Patchwork
== Series Details == Series: series starting with [RFC,1/2] drm/i915: Improve record of hung engines in error state (rev2) URL : https://patchwork.freedesktop.org/series/83497/ State : warning == Summary == $ dim sparse --fast origin/drm-tip Sparse version: v0.6.2 Fast mode used, each commit

Re: [Intel-gfx] [PATCH v5 5/6] drm/i915/dp: Prep for bigjoiner atomic check

2020-11-05 Thread Ville Syrjälä
On Thu, Nov 05, 2020 at 05:21:31PM +0200, Ville Syrjälä wrote: > On Mon, Nov 02, 2020 at 01:19:05PM -0800, Manasi Navare wrote: > > No functional changes here. Just pass intel_atomic_state > > along with crtc_state to certain atomic_check functions. > > This will lay the foundation for adding bigjo

Re: [Intel-gfx] [PATCH v5 5/6] drm/i915/dp: Prep for bigjoiner atomic check

2020-11-05 Thread Ville Syrjälä
On Mon, Nov 02, 2020 at 01:19:05PM -0800, Manasi Navare wrote: > No functional changes here. Just pass intel_atomic_state > along with crtc_state to certain atomic_check functions. > This will lay the foundation for adding bigjoiner master/slave > states in atomic check. > > v2: > * More prep with

Re: [Intel-gfx] [PATCH v5 2/6] drm/i915: Move encoder->get_config to a new function

2020-11-05 Thread Ville Syrjälä
On Mon, Nov 02, 2020 at 01:19:02PM -0800, Manasi Navare wrote: > No functional changes, create a separate intel_encoder_get_config() > function that calls encoder->get_config hook. > This is needed so that later we can add beigjoienr related > readout here. > > Signed-off-by: Manasi Navare Revie

Re: [Intel-gfx] [PATCH v5 4/6] drm/i915: Pass intel_atomic_state instead of drm_atomic_state

2020-11-05 Thread Ville Syrjälä
On Mon, Nov 02, 2020 at 01:19:04PM -0800, Manasi Navare wrote: > No functional changes, to align with previous cleanups pass > intel_atomic_state instead of drm_atomic_state. > Also pass this intel_atomic_state with crtc_state to > some of the atomic_check functions. > > Signed-off-by: Manasi Nava

Re: [Intel-gfx] [PATCH v6 3/6] drm/i915: Add hw.pipe_mode to allow bigjoiner pipe/transcoder split

2020-11-05 Thread Ville Syrjälä
On Mon, Nov 02, 2020 at 03:04:00PM -0800, Manasi Navare wrote: > From: Maarten Lankhorst > > With bigjoiner, there will be 2 pipes driving 2 halves of 1 transcoder, > because of this, we need a pipe_mode for various calculations, including > for example watermarks, plane clipping, etc. > > v9: >

[Intel-gfx] [PATCH] drm/i915/gem: Drop free_work for GEM contexts

2020-11-05 Thread Chris Wilson
The free_list and worker was introduced in commit 5f09a9c8ab6b ("drm/i915: Allow contexts to be unreferenced locklessly"), but subsequently made redundant by the removal of the last sleeping lock in commit 2935ed5339c4 ("drm/i915: Remove logical HW ID"). As we can now free the GEM context immediate

Re: [Intel-gfx] [PATCH V3] drm/i915/ehl: Implement W/A 22010492432

2020-11-05 Thread Imre Deak
On Wed, Nov 04, 2020 at 10:36:55AM +0530, Tejas Upadhyay wrote: > As per W/A implemented for TGL to program half of the nominal > DCO divider fraction value which is also applicable on EHL. > > Changes since V2: > - Apply stepping B0 till FOREVER > - B0 - revid update as per Bspec 2915

Re: [Intel-gfx] [PATCH v4 05/16] drm/i915/hdcp: Move HDCP enc status timeout to header

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:11:57 +0530, Anshuman Gupta wrote: > DP MST stream encryption status requires time of a link frame > in order to change its status, but as there were some HDCP > encryption timeout observed earlier, it is safer to use > ENCRYPT_STATUS_CHANGE_TIMEOUT_MS timeout for stream status

Re: [Intel-gfx] [PATCH v4 04/16] drm/i915/hdcp: DP MST transcoder for link and stream

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:11:56 +0530, Anshuman Gupta wrote: > Gen12 has H/W delta with respect to HDCP{1.x,2.x} display engine > instances lies in Transcoder instead of DDI as in Gen11. > > This requires hdcp driver to use mst_master_transcoder for link > authentication and stream transcoder for stream

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/display: Use initial_fastset_check() to compute and apply the initial PSR state

2020-11-05 Thread Souza, Jose
On Tue, 2020-11-03 at 07:07 +, Patchwork wrote: > Patch Details > Series: drm/i915/display: Use initial_fastset_check() to compute and apply > the initial PSR state URL: > https://patchwork.freedesktop.org/series/83375/ State: success Details: > https://intel-gfx-ci.01.org/tree/drm-tip/Patchw

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/22] drm/i915/gem: Allow backends to override pread implementation

2020-11-05 Thread Patchwork
== Series Details == Series: series starting with [01/22] drm/i915/gem: Allow backends to override pread implementation URL : https://patchwork.freedesktop.org/series/83531/ State : success == Summary == CI Bug Log - changes from CI_DRM_9268 -> Patchwork_18858

Re: [Intel-gfx] [PATCH v4 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-11-05 Thread Ramalingam C
On 2020-11-05 at 18:51:57 +0530, Ramalingam C wrote: > On 2020-11-05 at 18:48:02 +0530, Ramalingam C wrote: > > On 2020-10-27 at 22:11:53 +0530, Anshuman Gupta wrote: > > > When crtc state need_modeset is true it is not necessary > > > it is going to be a real modeset, it can turns to be a > > > fa

Re: [Intel-gfx] [PATCH v4 02/16] drm/i915/hdcp: Get conn while content_type changed

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:11:54 +0530, Anshuman Gupta wrote: > Get DRM connector reference count while scheduling a prop work > to avoid any possible destroy of DRM connector when it is in > DRM_CONNECTOR_REGISTERED state. > > Fixes: a6597faa2d59 ("drm/i915: Protect workers against disappearing > conne

Re: [Intel-gfx] [PATCH v4 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-11-05 Thread Ramalingam C
On 2020-11-05 at 18:48:02 +0530, Ramalingam C wrote: > On 2020-10-27 at 22:11:53 +0530, Anshuman Gupta wrote: > > When crtc state need_modeset is true it is not necessary > > it is going to be a real modeset, it can turns to be a > > fastset instead of modeset. > > This turns content protection pro

Re: [Intel-gfx] [PATCH v4 01/16] drm/i915/hdcp: Update CP property in update_pipe

2020-11-05 Thread Ramalingam C
On 2020-10-27 at 22:11:53 +0530, Anshuman Gupta wrote: > When crtc state need_modeset is true it is not necessary > it is going to be a real modeset, it can turns to be a > fastset instead of modeset. > This turns content protection property to be DESIRED and hdcp > update_pipe left with property t

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/22] drm/i915/gem: Allow backends to override pread implementation

2020-11-05 Thread Patchwork
== Series Details == Series: series starting with [01/22] drm/i915/gem: Allow backends to override pread implementation URL : https://patchwork.freedesktop.org/series/83531/ State : warning == Summary == $ dim checkpatch origin/drm-tip 6fbdba27ca31 drm/i915/gem: Allow backends to override pre

Re: [Intel-gfx] [RFC v2 2/2] drm/i915: Use ABI engine class in error state ecode

2020-11-05 Thread Chris Wilson
Quoting Tvrtko Ursulin (2020-11-05 11:38:42) > From: Tvrtko Ursulin > > Instead of printing out the internal engine mask, which can change between > kernel versions making it difficult to map to actual engines, present a > bitmask of hanging engines ABI classes. For example: > > [drm] GPU HANG

[Intel-gfx] [RFC v2 2/2] drm/i915: Use ABI engine class in error state ecode

2020-11-05 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Instead of printing out the internal engine mask, which can change between kernel versions making it difficult to map to actual engines, present a bitmask of hanging engines ABI classes. For example: [drm] GPU HANG: ecode 9:8:24dd, in gem_exec_schedu [1334] Engine ABI

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Introduce skl_ddb_entry_for_slices()

2020-11-05 Thread Lisovskiy, Stanislav
On Tue, Oct 27, 2020 at 10:39:51PM +0200, Ville Syrjala wrote: > From: Ville Syrjälä > > Generalize icl_get_first_dbuf_slice_offset() into something that > just gives us the start+end of the dbuf chunk covered by the > specified slices as a standard ddb entry. Initial idea was to use > it during

  1   2   >