Hi Christophe,
Thank you for the patch! Yet something to improve:
[auto build test ERROR on linus/master]
[also build test ERROR on next-20200403]
[cannot apply to powerpc/next drm-intel/for-linux-next tip/x86/core v5.6]
[if your patch is applied to the wrong git tree, please drop us a note to
== Series Details ==
Series: SAGV support for Gen12+ (rev13)
URL : https://patchwork.freedesktop.org/series/75129/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8247_full -> Patchwork_17204_full
Summary
---
**SUCCESS
Hello,
On Thu, Apr 2, 2020 at 5:47 PM Alexey Budankov
wrote:
>
>
> Extend error messages to mention CAP_PERFMON capability as an option
> to substitute CAP_SYS_ADMIN capability for secure system performance
> monitoring and observability operations. Make perf_event_paranoid_check()
> and __cmd_ft
== Series Details ==
Series: drm/i915: Revoke mmap before fence
URL : https://patchwork.freedesktop.org/series/75470/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8247_full -> Patchwork_17202_full
Summary
---
**FAIL
Hi Ville
Thanks for the patch.
Our understanding of private_flags was that we can use it within our
drivers to handle vendor specific features.
Hence we do have several features in our downstream drivers as well as
some planned work based on this.
This was the only method to pass around and
== Series Details ==
Series: devm_drm_dev_alloc, no more drmm_add_final_kfree (rev3)
URL : https://patchwork.freedesktop.org/series/75463/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8252 -> Patchwork_17210
Summary
--
== Series Details ==
Series: devm_drm_dev_alloc, no more drmm_add_final_kfree (rev3)
URL : https://patchwork.freedesktop.org/series/75463/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
e72346e75771 drivers/base: Always release devres on device_del
-:78: WARNING:NO_AUTHOR_SIGN_O
== Series Details ==
Series: drm/dp_mst: Remove drm_dp_mst_has_audio()
URL : https://patchwork.freedesktop.org/series/75488/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8252 -> Patchwork_17209
Summary
---
**SUCCESS
The big change is device_add so that device_del can auto-cleanup
devres resources. This allows us to use devm_drm_dev_alloc, which
removes the last user of drm_dev_init.
v2: Rebased
Signed-off-by: Daniel Vetter
---
.../gpu/drm/i915/selftests/mock_gem_device.c | 33 +--
1 file c
Just some prep work before we rework the lifetime handling, which
requires replacing all the drm_dev_put in selftests by something else.
v2: Don't go with a static inline, upsets the header tests and
separation.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/gem/selftests/huge_pages.c
== Series Details ==
Series: drm: Put drm_display_mode on diet (rev2)
URL : https://patchwork.freedesktop.org/series/73674/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8252 -> Patchwork_17208
Summary
---
**FAILURE*
Drive-by fix I noticed the other day - drm_dp_mst_has_audio() only ever
made sense back when we still had to validate ports before accessing
them in order to (attempt to) avoid NULL dereferences. Since we have
proper reference counting that guarantees we always can safely access
the MST port, there
== Series Details ==
Series: drm: Put drm_display_mode on diet (rev2)
URL : https://patchwork.freedesktop.org/series/73674/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
fa630bba9e2b drm: Nuke mode->hsync
bb6f7d766981 drm/i915: Introduce some local intel_dp variables
325b0ad221
Quoting Lyude Paul (2020-04-03 22:25:43)
> Hey - almost forgot to reply to this, I actually probably won't be able to
> test this properly for a while since my razer laptop is actually stuck in the
> office I work at, and I legally can't get to it with COVID-19 shelter-in-
> place. Sorry about that
Hey - almost forgot to reply to this, I actually probably won't be able to
test this properly for a while since my razer laptop is actually stuck in the
office I work at, and I legally can't get to it with COVID-19 shelter-in-
place. Sorry about that!
On Sun, 2020-03-22 at 15:40 +, Chris Wilso
== Series Details ==
Series: drm/i915/gt: Free request pool from virtual engines
URL : https://patchwork.freedesktop.org/series/75483/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8251 -> Patchwork_17207
Summary
---
Hi Ville,
Thank you for the patch.
On Fri, Apr 03, 2020 at 11:39:54PM +0300, Ville Syrjala wrote:
> From: Ville Syrjälä
>
> Get rid of mode->vrefresh and just calculate it on demand. Saves
> a bit of space and avoids the cached value getting out of sync
> with reality.
>
> Mostly done with coc
On Fri, Apr 03, 2020 at 11:01:10AM -0700, Linus Torvalds wrote:
> On Fri, Apr 3, 2020 at 12:21 AM Christophe Leroy
> wrote:
> >
> > Now we have user_read_access_begin() and user_write_access_begin()
> > in addition to user_access_begin().
>
> I realize Al asked for this, but I don't think it real
== Series Details ==
Series: drm/i915/selftests: Wait until we start timeslicing after a submit
URL : https://patchwork.freedesktop.org/series/75479/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8251 -> Patchwork_17206
Sum
From: Ville Syrjälä
In order to shrink drm_display_mode below the magic two cacheline
mark in 64bit we need to shrink it by another 8 bytes. The easiest
thing to eliminate is the 'export_head' list head which is only
used during the getconnector ioctl to temporarly track which modes
on the connec
From: Ville Syrjälä
The last two uses of mode->private_flags (in i915 and gma500)
are now gone. So let's remove mode->private_flags entirely.
CC: Sam Ravnborg
Cc: Daniel Vetter
Cc: Emil Velikov
Signed-off-by: Ville Syrjälä
---
include/drm/drm_modes.h | 10 --
1 file changed, 10 dele
From: Ville Syrjälä
There's no reason for I915_MODE_FLAG_INHERITED to exist as a flag
anymore. Just make it a boolean.
CC: Sam Ravnborg
Cc: Daniel Vetter
Cc: Emil Velikov
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/display/intel_atomic.c | 2 +-
drivers/gpu/drm/i915/display
From: Ville Syrjälä
gma500 needs 4 bits (to store a pixel multiplier) in the
mode->private_flags, i915 currently has three bits defined.
No one else uses this. Reduce the size to u8.
Reviewed-by: Emil Velikov
Signed-off-by: Ville Syrjälä
---
include/drm/drm_modes.h | 2 +-
1 file changed, 1 i
From: Ville Syrjälä
gma500 only uses mode->private_flags to convey the sdvo pixel
multiplier from the encoder .mode_fixup() hook to the encoder
.mode_set() hook. Those always seems get called as a pair so
let's just stuff the pixel multiplier into the encoder itself
as there are no state objects
From: Ville Syrjälä
Store the timings (apart from the clock) as u16. The uapi mode
struct already uses u16 for everything so using something bigger
internally doesn't really help us.
Reviewed-by: Emil Velikov
Reviewed-by: Daniel Vetter
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_mod
From: Ville Syrjälä
The mode flags are direclty exposed in the uapi as u32. Use the
same size type to store them internally.
Reviewed-by: Emil Velikov
Signed-off-by: Ville Syrjälä
---
include/drm/drm_modes.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_m
From: Ville Syrjälä
Replace the use of mode->private_flags with a truly private bitmaks
in our own crtc state. We also need a copy in the crtc itself so the
vblank code can get at it. We already have scanline_offset in there
for a similar reason, as well as the vblank->hwmode which is assigned
vi
From: Ville Syrjälä
The drrs code dereferences mode->vrefresh via some really long chain
of structures/pointers. Couldn't get coccinelle to see through all
that so let's add some local variables to help it.
Reviewed-by: Emil Velikov
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/i915/displa
From: Ville Syrjälä
Remove the pointless whole-function indentation. Also don't
need to worry about negative values anymore since we switched
everything to u16.
Reviewed-by: Emil Velikov
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/drm_modes.c | 26 --
1 file chang
From: Ville Syrjälä
Reorganize drm_display_mode to eliminate all the holes.
We'll put all the actual timings to the start of the
struct and all the extra junk to the end.
Gets the size down to 136 bytes on 64bit and 120 bytes on
32bit. With a bit more work we should be able to get this
below the
From: Ville Syrjälä
We only have 7 bits defined for mode->type. Shrink the storage to u8.
Reviewed-by: Emil Velikov
Reviewed-by: Daniel Vetter
Signed-off-by: Ville Syrjälä
---
include/drm/drm_modes.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/drm/drm_modes.h
From: Ville Syrjälä
The driver never sets mode->private_flags so copying
it back and forth is entirely pointless. Stop doing it.
Also drop private_flags from the tracepoint.
Cc: Rob Clark
Cc: Sean Paul
Cc: linux-arm-...@vger.kernel.org
Cc: freedr...@lists.freedesktop.org
Reviewed-by: Emil Vel
From: Ville Syrjälä
Instead of supporting ~2000km wide displayes let's limit ourselves
to ~65m. That seems plenty big enough to me.
Even with EDID_QUIRK_DETAILED_IN_CM EDIDs seem to be limited to
10*0xfff which fits into the 16 bits.
Reviewed-by: Emil Velikov
Signed-off-by: Ville Syrjälä
---
From: Ville Syrjälä
htotal*vtotal*vrefresh ~= clock. So just say "clock" when we mean it.
Cc: Linus Walleij
Cc: Sam Ravnborg
Signed-off-by: Ville Syrjälä
---
drivers/gpu/drm/mcde/mcde_dsi.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/mcde/mcde_dsi.c
From: Ville Syrjälä
Let's just calculate the hsync rate on demand. No point in wasting
space storing it and risking the cached value getting out of sync
with reality.
v2: Move drm_mode_hsync() next to its only users
Drop the TODO
Reviewed-by: Emil Velikov #v1
Signed-off-by: Ville Syrjälä
From: Ville Syrjälä
Refreshed version of the mode diet.
New unseen stuff at the end:
- Nuke private_flags entirely
- Replace export_head with a bool to shrink the struct
below the magic two cachelines
I kept the intermediate "shrink private_flags to u8" step
because I didn't want to redo the
>-Original Message-
>From: Chris Wilson
>Sent: Friday, April 3, 2020 4:34 PM
>To: Ruhl, Michael J ; intel-
>g...@lists.freedesktop.org
>Subject: Re: [Intel-gfx] [PATCH] drm/i915/selftests: Wait until we start
>timeslicing after a submit
>
>Quoting Ruhl, Michael J (2020-04-03 21:31:42)
>> >
Quoting Ruhl, Michael J (2020-04-03 21:31:42)
> >-Original Message-
> >From: Intel-gfx On Behalf Of Chris
> >Wilson
> >Sent: Friday, April 3, 2020 3:02 PM
> >To: intel-gfx@lists.freedesktop.org
> >Cc: Chris Wilson
> >Subject: [Intel-gfx] [PATCH] drm/i915/selftests: Wait until we start
>
While extremely unlikely to be populated, we could capture a request on
the virtual engine which we should free along with the virtual engine.
Fixes: 43acd6516ca9 ("drm/i915: Keep a per-engine request pool")
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/gt/intel_engine.h| 2 ++
drive
>-Original Message-
>From: Intel-gfx On Behalf Of Chris
>Wilson
>Sent: Friday, April 3, 2020 3:02 PM
>To: intel-gfx@lists.freedesktop.org
>Cc: Chris Wilson
>Subject: [Intel-gfx] [PATCH] drm/i915/selftests: Wait until we start
>timeslicing
>after a submit
>
>If we submit, we do not start
== Series Details ==
Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev4)
URL : https://patchwork.freedesktop.org/series/75333/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8251 -> Patchwork_17205
Summary
== Series Details ==
Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev4)
URL : https://patchwork.freedesktop.org/series/75333/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
88806913668d drm/i915/gt: move remaining debugfs interfaces into gt
-:119: WARNING:FILE
If we submit, we do not start timeslicnig until we process the CS event
that marks the start of the context running on HW. So in the selftest,
be sure to wait until we have processed the pending events before
asserting that timeslicing has begun.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i
From: Andi Shyti
The following interfaces:
i915_wedged
i915_forcewake_user
i915_gem_interrupt
i915_rcs_topology
i915_sseu_status
are dependent on gt values. Put them inside gt/ and drop the
"i915_" prefix name. This would be the new structure:
gt
|
+-- forcewake_user
|
+--
== Series Details ==
Series: drm/i915: Check current i915_vma.pin_count status first on unbind (rev6)
URL : https://patchwork.freedesktop.org/series/72529/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8244_full -> Patchwork_17199_full
=
On Fri, 3 Apr 2020 at 14:24, Chris Wilson wrote:
>
> We are dramatically underestimating the overhead for an active object
> and its inodes.
>
> Signed-off-by: Chris Wilson
Acked-by: Matthew Auld
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.o
On Fri, Apr 3, 2020 at 12:21 AM Christophe Leroy
wrote:
>
> Now we have user_read_access_begin() and user_write_access_begin()
> in addition to user_access_begin().
I realize Al asked for this, but I don't think it really adds anything
to the series.
The "full" makes the names longer, but not re
Quoting Dixit, Ashutosh (2020-04-03 18:45:09)
> On Fri, 03 Apr 2020 09:17:14 -0700, Chris Wilson wrote:
> >
> > Quoting Ashutosh Dixit (2020-04-03 02:01:20)
> > > It is wrong to block the user thread in the next poll when OA data is
> > > already available which could not fit in the user buffer pro
On 4/3/20 8:58 AM, Daniel Vetter wrote:
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: David Lechner
---
Acked-by: David Lechner
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.
+Dave and Daniel,
On Fri, Apr 03, 2020 at 11:05:07AM +0800, Zhenyu Wang wrote:
> On 2020.03.31 09:26:44 -0700, Rodrigo Vivi wrote:
> > On Tue, Mar 31, 2020 at 03:00:25PM +0800, Zhenyu Wang wrote:
> > >
> > > Hi,
> > >
> > > Here's more queued gvt fixes for 5.7. Please see details below.
> > >
On Fri, 03 Apr 2020 09:17:14 -0700, Chris Wilson wrote:
>
> Quoting Ashutosh Dixit (2020-04-03 02:01:20)
> > It is wrong to block the user thread in the next poll when OA data is
> > already available which could not fit in the user buffer provided in
> > the previous read. In several cases the exa
On Fri, Apr 3, 2020 at 6:59 AM Daniel Vetter wrote:
>
> Upcasting using a container_of macro is more typesafe, faster and
> easier for the compiler to optimize.
>
> Signed-off-by: Daniel Vetter
> Cc: Dave Airlie
> Cc: Gerd Hoffmann
> Cc: Daniel Vetter
> Cc: "Noralf Trønnes"
> Cc: Sam Ravnborg
On Fri, Apr 3, 2020 at 6:58 AM Daniel Vetter wrote:
>
> And switch the helper over to container_of, which is a bunch faster
> than chasing a pointer. Plus allows gcc to see through this maze.
>
> Signed-off-by: Daniel Vetter
Acked-by: Eric Anholt
___
On Fri, Apr 3, 2020 at 6:59 AM Daniel Vetter wrote:
>
> Already using devm_drm_dev_init, so very simple replacment.
>
> Signed-off-by: Daniel Vetter
Acked-by: Eric Anholt
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedes
On Fri, Apr 3, 2020 at 6:58 AM Daniel Vetter wrote:
>
> Also allows us to simplify the unroll code since the drm_dev_put
> disappears.
>
> Signed-off-by: Daniel Vetter
Acked-by: Eric Anholt
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
ht
On Fri, Apr 3, 2020 at 6:58 AM Daniel Vetter wrote:
>
> We already have it in v3d_dev->drm.dev with zero additional pointer
> chasing. Personally I don't like duplicated pointers like this
> because:
> - reviewers need to check whether the pointer is for the same or
> different objects if there'
On Fri, Apr 3, 2020 at 6:58 AM Daniel Vetter wrote:
>
> We already have it in v3d_dev->drm.dev with zero additional pointer
> chasing. Personally I don't like duplicated pointers like this
> because:
> - reviewers need to check whether the pointer is for the same or
> different objects if there's
On 4/3/20 8:58 AM, Daniel Vetter wrote:
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: David Lechner
---
Acked-by: David Lechner
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.
== Series Details ==
Series: SAGV support for Gen12+ (rev13)
URL : https://patchwork.freedesktop.org/series/75129/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8247 -> Patchwork_17204
Summary
---
**SUCCESS**
No r
On Fri, 3 Apr 2020 at 17:10, Chris Wilson wrote:
>
> Make sure we revoke the user's mmaps of this vma to force them to take a
> pagefault *before* we remove the associated aperture detiling register.
>
> Fixes: 0d86ee35097a ("drm/i915/gt: Make fence revocation unequivocal")
> Signed-off-by: Chris
On 4/3/20 8:58 AM, Daniel Vetter wrote:
Already using devm_drm_dev_init, so very simple replacment.
Aside: There was an oddity in the old code, we allocated priv but in
the error path we've freed priv->dbidev ...
Signed-off-by: Daniel Vetter
Cc: David Lechner
---
Acked-by: David Lechner
__
On Fri, Apr 03, 2020 at 12:32:20AM +, Souza, Jose wrote:
> On Fri, 2020-03-13 at 18:48 +0200, Ville Syrjala wrote:
> > From: Ville Syrjälä
> >
> > Don't assume there is just one port sync slave. We might have
> > several.
> >
> > Signed-off-by: Ville Syrjälä
> > ---
> > drivers/gpu/drm/i91
On 4/3/20 8:58 AM, Daniel Vetter wrote:
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: "Noralf Trønnes"
Cc: Sam Ravnborg
Cc: Daniel Vetter
Cc: Eric Anholt
Cc: David Lechner
---
Acked-by: David Lechner
_
== Series Details ==
Series: series starting with [01/10] drm/i915/selftests: Add request throughput
measurement to perf
URL : https://patchwork.freedesktop.org/series/75452/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8243_full -> Patchwork_17197_full
=
== Series Details ==
Series: series starting with [01/23] perf/core: Only copy-to-user after
completely unlocking all locks, v2.
URL : https://patchwork.freedesktop.org/series/75423/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8238_full -> Patchwork_17184_full
=
== Series Details ==
Series: SAGV support for Gen12+ (rev13)
URL : https://patchwork.freedesktop.org/series/75129/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f121c205f975 drm/i915: Start passing latency as parameter
2cb942fadfcf drm/i915: Eliminate magic numbers "0" and "1"
== Series Details ==
Series: i915 lpsp support for lpsp igt (rev6)
URL : https://patchwork.freedesktop.org/series/74648/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8228_full -> Patchwork_17155_full
Summary
---
**W
== Series Details ==
Series: drm/i915: Revoke mmap before fence
URL : https://patchwork.freedesktop.org/series/75470/
State : success
== Summary ==
CI Bug Log - changes from CI_DRM_8247 -> Patchwork_17202
Summary
---
**SUCCESS**
N
== Series Details ==
Series: series starting with [v2,1/5] uaccess: Add user_read_access_begin/end
and user_write_access_begin/end
URL : https://patchwork.freedesktop.org/series/75471/
State : failure
== Summary ==
Applying: uaccess: Add user_read_access_begin/end and
user_write_access_begin
== Series Details ==
Series: drm/i915: Avoid setting timer->expires to 0
URL : https://patchwork.freedesktop.org/series/75447/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8243_full -> Patchwork_17195_full
Summary
---
According to BSpec 53998, we should try to
restrict qgv points, which can't provide
enough bandwidth for desired display configuration.
Currently we are just comparing against all of
those and take minimum(worst case).
v2: Fixed wrong PCode reply mask, removed hardcoded
values.
v3: Forbid si
== Series Details ==
Series: SAGV support for Gen12+ (rev10)
URL : https://patchwork.freedesktop.org/series/75129/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8243_full -> Patchwork_17194_full
Summary
---
**FAILURE
== Series Details ==
Series: SAGV support for Gen12+ (rev12)
URL : https://patchwork.freedesktop.org/series/75129/
State : failure
== Summary ==
Applying: drm/i915: Start passing latency as parameter
Applying: drm/i915: Eliminate magic numbers "0" and "1" from color plane
Applying: drm/i915: I
Add support for selective read or write user access with
user_read_access_begin/end and user_write_access_begin/end.
Signed-off-by: Christophe Leroy
Reviewed-by: Kees Cook
---
v2: no change
---
arch/powerpc/include/asm/book3s/32/kup.h | 4 ++--
arch/powerpc/include/asm/kup.h | 14 +++
When i915_gem_execbuffer2_ioctl() is using user_access_begin(),
that's only to perform unsafe_put_user() so use
user_write_access_begin() in order to only open write access.
Signed-off-by: Christophe Leroy
Reviewed-by: Kees Cook
---
v2: Rebased (one part of the patch flies away)
---
drivers/gpu
Some architectures like powerpc64 have the capability to separate
read access and write access protection.
For get_user() and copy_from_user(), powerpc64 only open read access.
For put_user() and copy_to_user(), powerpc64 only open write access.
But when using unsafe_get_user() or unsafe_put_user()
When opening user access to only perform reads, only open read access.
When opening user access to only perform writes, only open write
access.
Signed-off-by: Christophe Leroy
Reviewed-by: Kees Cook
---
v2: Fixed a mismatched use of _read_ and _write_ in compat_get_bitmap()
and compat_put_bitmap
Now we have user_read_access_begin() and user_write_access_begin()
in addition to user_access_begin().
Make it explicit that user_access_begin() provides both read and
write by renaming it user_full_access_begin(). And the same for
user_access_end() which becomes user_full_access_end().
Done with
Quoting Ashutosh Dixit (2020-04-03 02:01:20)
> It is wrong to block the user thread in the next poll when OA data is
> already available which could not fit in the user buffer provided in
> the previous read. In several cases the exact user buffer size is not
> known. Blocking user space in poll ca
== Series Details ==
Series: drm/i915/perf: Do not clear pollin for small user read buffers (rev7)
URL : https://patchwork.freedesktop.org/series/75085/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8242_full -> Patchwork_17191_full
Make sure we revoke the user's mmaps of this vma to force them to take a
pagefault *before* we remove the associated aperture detiling register.
Fixes: 0d86ee35097a ("drm/i915/gt: Make fence revocation unequivocal")
Signed-off-by: Chris Wilson
Cc: Matthew Auld
---
drivers/gpu/drm/i915/i915_vma.
Let's refactor the whole SAGV logic, moving
the main calculations from intel_can_enable_sagv
to intel_compute_sagv_mask, which also handles
this in a unified way calling gen specific
functions to evaluate if SAGV is allowed for
each crtc. If crtc sagv mask have been changed
we serialize access and
According to many computer science sources - magic values
in code _are_ _bad_. For many reasons: the reason is that "0"
or "1" or whatever magic values confuses and doesn't give any
info why this parameter is this value and what it's meaning
is.
I renamed "0" to COLOR_PLANE_Y and "1" to COLOR_PLANE
On Fri, Apr 3, 2020 at 5:15 PM Daniel Vetter wrote:
>
> On Fri, Apr 3, 2020 at 5:06 PM Greg Kroah-Hartman
> wrote:
> >
> > On Fri, Apr 03, 2020 at 04:47:04PM +0200, Daniel Vetter wrote:
> > > On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman
> > > wrote:
> > > >
> > > > On Fri, Apr 03, 2020 at 0
On 03/04/2020 08:36, Chris Wilson wrote:
We use timer->expires == 0 to detect if a timer had been cancelled, but
it's a valid expiration we could set. Just skip using 0 and set the
expiry for the next jiffie.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_utils.c | 2 +-
1 file
On Fri, Apr 3, 2020 at 5:06 PM Greg Kroah-Hartman
wrote:
>
> On Fri, Apr 03, 2020 at 04:47:04PM +0200, Daniel Vetter wrote:
> > On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman
> > wrote:
> > >
> > > On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote:
> > > > In drm we've added nice d
On Fri, Apr 03, 2020 at 04:47:04PM +0200, Daniel Vetter wrote:
> On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman
> wrote:
> >
> > On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote:
> > > In drm we've added nice drm_device (the main gpu driver thing, which
> > > also represents the us
On Fri, Apr 03, 2020 at 04:51:33PM +0200, Daniel Vetter wrote:
> On Fri, Apr 3, 2020 at 4:47 PM Daniel Vetter wrote:
> >
> > On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman
> > wrote:
> > >
> > > On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote:
> > > > In drm we've added nice drm_
On Fri, Apr 3, 2020 at 4:47 PM Daniel Vetter wrote:
>
> On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman
> wrote:
> >
> > On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote:
> > > In drm we've added nice drm_device (the main gpu driver thing, which
> > > also represents the userspace
On Fri, Apr 3, 2020 at 4:17 PM Greg Kroah-Hartman
wrote:
>
> On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote:
> > In drm we've added nice drm_device (the main gpu driver thing, which
> > also represents the userspace interfaces and has everything else
> > dangling off it) init functi
== Series Details ==
Series: drm/i915: Keep a per-engine request pools (rev2)
URL : https://patchwork.freedesktop.org/series/75427/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8238_full -> Patchwork_17189_full
Summary
---
On Fri, Apr 03, 2020 at 03:57:45PM +0200, Daniel Vetter wrote:
> In drm we've added nice drm_device (the main gpu driver thing, which
> also represents the userspace interfaces and has everything else
> dangling off it) init functions using devres, devm_drm_dev_init and
> soon devm_drm_dev_alloc (t
== Series Details ==
Series: devm_drm_dev_alloc, no more drmm_add_final_kfree
URL : https://patchwork.freedesktop.org/series/75463/
State : failure
== Summary ==
CALLscripts/checksyscalls.sh
CALLscripts/atomic/check-atomics.sh
DESCEND objtool
CHK include/generated/compile.h
On 2020-03-01 6:46 a.m., Marek Olšák wrote:
> For Mesa, we could run CI only when Marge pushes, so that it's a strictly
> pre-merge CI.
Thanks for the suggestion! I implemented something like this for Mesa:
https://gitlab.freedesktop.org/mesa/mesa/-/merge_requests/4432
--
Earthling Michel Dänz
== Series Details ==
Series: drm/i915/gt: move remaining debugfs interfaces into gt (rev3)
URL : https://patchwork.freedesktop.org/series/75333/
State : failure
== Summary ==
CI Bug Log - changes from CI_DRM_8238_full -> Patchwork_17188_full
Quoting Janusz Krzysztofik (2020-04-03 14:58:47)
> On Thu, 2020-04-02 at 19:40 +0100, Chris Wilson wrote:
> > Add a tiny per-engine request mempool so that we should always have a
> > request available for powermanagement allocations from tricky
> > contexts. This reserve is expected to be only use
Luckily we're already well set up in the main driver, with
drm_dev_put() being the last thing in both the unload error case and
the pci remove function.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/i915_drv.c | 17 -
drivers/gpu/drm/i915/i915_pci.c | 2 --
2 files chang
The big change is device_add so that device_del can auto-cleanup
devres resources. This allows us to use devm_drm_dev_alloc, which
removes the last user of drm_dev_init.
Signed-off-by: Daniel Vetter
---
.../gpu/drm/i915/selftests/mock_gem_device.c | 31 +--
.../gpu/drm/i915/self
Already using devm_drm_dev_init, so very simple replacment.
Signed-off-by: Daniel Vetter
Cc: Dave Airlie
Cc: Gerd Hoffmann
Cc: Daniel Vetter
Cc: Sam Ravnborg
Cc: "Noralf Trønnes"
Cc: Rob Herring
Cc: Thomas Zimmermann
Cc: virtualizat...@lists.linux-foundation.org
Cc: Emil Velikov
---
driv
Komeda uses the component framework, which does open/close a new
devres group around all the bind callbacks. Which means we can use
devm_ functions for managing the drm_device cleanup, with leaking
stuff in case of deferred probes or other reasons to unbind
components, or the component_master.
Als
1 - 100 of 187 matches
Mail list logo
