[Intel-gfx] [CI] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-12-03 Thread Chris Wilson
From: Abdiel Janulgue This is really just an alias of mmap_gtt. The 'mmap offset' nomenclature comes from the value returned by this ioctl which is the offset into the device fd which userpace uses with mmap(2). mmap_gtt was our initial mmap_offset implementation, this extends our CPU mmap suppo

Re: [Intel-gfx] [PATCH v3 01/13] drm/i915/bios: pass devdata to parse_ddi_port

2019-12-03 Thread Kulkarni, Vandita
> -Original Message- > From: Jani Nikula > Sent: Tuesday, November 26, 2019 7:13 PM > To: intel-gfx@lists.freedesktop.org > Cc: Nikula, Jani ; Kulkarni, Vandita > ; Ville Syrjälä > Subject: [PATCH v3 01/13] drm/i915/bios: pass devdata to parse_ddi_port > > Allow accessing the parent stru

Re: [Intel-gfx] [PATCH CI] drm/i915/display/tgl: Do not program clockgating

2019-12-03 Thread Jani Nikula
On Tue, 03 Dec 2019, "Souza, Jose" wrote: > On Tue, 2019-12-03 at 10:20 +0200, Jani Nikula wrote: >> On Mon, 02 Dec 2019, José Roberto de Souza >> wrote: >> > Talked with HW team and this is a left over, driver should not >> > program clockgating, dekel firmware will be reponsible for any >> > cl

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: s/HAS_128_BYTE_Y_TILING/!HAS_512_BYTE_Y_TILING/

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915: s/HAS_128_BYTE_Y_TILING/!HAS_512_BYTE_Y_TILING/ URL : https://patchwork.freedesktop.org/series/70396/ State : success == Summary == CI Bug Log - changes from CI_DRM_7475_full -> Patchwork_15567_full Su

Re: [Intel-gfx] [PATCH v3 04/12] video: fbdev: uvesafb: modify the static fb_ops directly

2019-12-03 Thread Jani Nikula
On Tue, 03 Dec 2019, Daniel Vetter wrote: > On Tue, Dec 03, 2019 at 06:38:46PM +0200, Jani Nikula wrote: >> Avoid modifying the fb_ops via info->fbops to let us make the pointer >> const in the future. >> >> Cc: linux-fb...@vger.kernel.org >> Signed-off-by: Jani Nikula >> --- >> drivers/video/f

[Intel-gfx] ✗ Fi.CI.IGT: failure for video, drm, etc: constify fbops in struct fb_info (rev2)

2019-12-03 Thread Patchwork
== Series Details == Series: video, drm, etc: constify fbops in struct fb_info (rev2) URL : https://patchwork.freedesktop.org/series/70198/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7475_full -> Patchwork_15565_full Sum

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev5)

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev5) URL : https://patchwork.freedesktop.org/series/70164/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7474_full -> Patchwork_15563_full Summary

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/perf: drop pointless static qualifier in i915_perf_add_config_ioctl()

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915/perf: drop pointless static qualifier in i915_perf_add_config_ioctl() URL : https://patchwork.freedesktop.org/series/70405/ State : success == Summary == CI Bug Log - changes from CI_DRM_7479 -> Patchwork_15574

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4,1/2] drm/i915/display/icl+: Do not program clockgating

2019-12-03 Thread Patchwork
== Series Details == Series: series starting with [v4,1/2] drm/i915/display/icl+: Do not program clockgating URL : https://patchwork.freedesktop.org/series/70404/ State : success == Summary == CI Bug Log - changes from CI_DRM_7479 -> Patchwork_15573 ===

Re: [Intel-gfx] [PATCH v3 5/5] drm/i915/vbt: Parse power conservation features block

2019-12-03 Thread Souza, Jose
On Thu, 2019-11-28 at 16:29 +0200, Jani Nikula wrote: > On Wed, 27 Nov 2019, José Roberto de Souza > wrote: > > From VBT 228+ this is block that PSR and other power saving > > features configuration should be read from. > > > > v3: > > Using DRRS from this new block > > > > Cc: Matt Roper > > C

[Intel-gfx] [PATCH -next] drm/i915/perf: drop pointless static qualifier in i915_perf_add_config_ioctl()

2019-12-03 Thread Mao Wenan
There is no need to have the 'T *v' variable static since new value always be assigned before use it. Reported-by: Hulk Robot Signed-off-by: Mao Wenan --- drivers/gpu/drm/i915/i915_perf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/driv

[Intel-gfx] [PATCH v4 2/2] drm/i915/display: Fix warning about MST and DDI restrictions

2019-12-03 Thread José Roberto de Souza
Capturing the restrictions of the BSpec pages bellow: SKL and CNL do not support MST in DDI E, DDI E only support 2 lanes and it is mostly used to support a 4 lanes eDP panel together with DDI A. ICL's DDI E support MST just like other ports but DDI A is still eDP and MIPI only. TGL supports MST i

[Intel-gfx] [PATCH v4 1/2] drm/i915/display/icl+: Do not program clockgating

2019-12-03 Thread José Roberto de Souza
Talked with HW team and this is a left over, driver should not program clockgating, mg or dekel firmware is reponsible for any clockgating programing. Also removing the register and bits definition related to clockgating. v2: Added WARN_ON v3: Only calling icl_phy_set_clock_gating() on intel_ddi

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: eDP DPCD aux backlight fixes (rev2)

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915: eDP DPCD aux backlight fixes (rev2) URL : https://patchwork.freedesktop.org/series/69914/ State : success == Summary == CI Bug Log - changes from CI_DRM_7479 -> Patchwork_15572 Summary --- **SUC

Re: [Intel-gfx] [PATCH 01/11] drm/i915: Fix sha_text population code

2019-12-03 Thread Sasha Levin
Hi, [This is an automated email] This commit has been processed because it contains a "Fixes:" tag, fixing commit: ee5e5e7a5e0f ("drm/i915: Add HDCP framework + base implementation"). The bot has tested the following trees: v5.4.1, v5.3.14, v4.19.87. v5.4.1: Build OK! v5.3.14: Build OK! v4.19.

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/display/tgl: Do not program clockgating (rev3)

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915/display/tgl: Do not program clockgating (rev3) URL : https://patchwork.freedesktop.org/series/70076/ State : success == Summary == CI Bug Log - changes from CI_DRM_7478 -> Patchwork_15571 Summary --

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Set the PD again for Haswell (rev5)

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915/gt: Set the PD again for Haswell (rev5) URL : https://patchwork.freedesktop.org/series/70321/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7478 -> Patchwork_15570 Summary --- **

Re: [Intel-gfx] [PATCH 6/7] drm/i915/display/tgl: Fix the order of the step to turn transcoder clock off

2019-12-03 Thread Souza, Jose
On Thu, 2019-11-28 at 20:40 +0200, Ville Syrjälä wrote: > On Fri, Nov 22, 2019 at 04:54:58PM -0800, José Roberto de Souza > wrote: > > For TGL the step to turn off the transcoder clock was moved to > > after > > the complete shutdown of DDI. Only the MST slave transcoders should > > disable the clo

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Set the PD again for Haswell (rev5)

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915/gt: Set the PD again for Haswell (rev5) URL : https://patchwork.freedesktop.org/series/70321/ State : warning == Summary == $ dim checkpatch origin/drm-tip fe6aa6fc3a2d drm/i915/gt: Set the PD again for Haswell -:22: WARNING:COMMIT_LOG_LONG_LINE: Possible

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add new EHL/JSL PCI ids

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915: Add new EHL/JSL PCI ids URL : https://patchwork.freedesktop.org/series/70399/ State : success == Summary == CI Bug Log - changes from CI_DRM_7478 -> Patchwork_15569 Summary --- **SUCCESS** No

[Intel-gfx] [PATCH v2] drm/i915: Assume 100% brightness when not in DPCD control mode

2019-12-03 Thread Lyude Paul
Currently we always determine the initial panel brightness level by simply reading the value from DP_EDP_BACKLIGHT_BRIGHTNESS_MSB/LSB. This seems wrong though, because if the panel is not currently in DPCD control mode there's not really any reason why there would be any brightness value programmed

Re: [Intel-gfx] [PATCH] Revert "drm/i915: use a separate context for gpu relocs"

2019-12-03 Thread Daniele Ceraolo Spurio
On 11/29/19 4:48 AM, Chris Wilson wrote: Since commit c45e788d95b4 ("drm/i915/tgl: Suspend pre-parser across GTT invalidations"), we now disable the advanced preparser on Tigerlake for the invalidation phase at the start of the batch, we no longer need to emit the GPU relocations from a second

Re: [Intel-gfx] [PATCH 3/7] drm/i915/tgl: Select master trasconder for MST stream

2019-12-03 Thread Souza, Jose
On Tue, 2019-12-03 at 14:47 +0200, Ville Syrjälä wrote: > On Mon, Dec 02, 2019 at 10:03:38PM +, Souza, Jose wrote: > > On Thu, 2019-11-28 at 14:06 +0200, Ville Syrjälä wrote: > > > On Thu, Nov 28, 2019 at 01:14:37AM +, Souza, Jose wrote: > > > > On Wed, 2019-11-27 at 21:59 +0200, Ville Syrj

Re: [Intel-gfx] [PATCH v3] drm/i915/display/tgl: Do not program clockgating

2019-12-03 Thread Souza, Jose
On Tue, 2019-12-03 at 13:55 -0800, Matt Roper wrote: > On Tue, Dec 03, 2019 at 01:29:02PM -0800, José Roberto de Souza > wrote: > > Talked with HW team and this is a left over, driver should not > > program clockgating, dekel firmware will be reponsible for any > > clockgating programing. > > > >

Re: [Intel-gfx] [PATCH CI 1/3] drm/i915/display: Check the old state to find port sync slave

2019-12-03 Thread Manasi Navare
On Mon, Dec 02, 2019 at 02:25:11PM -0800, José Roberto de Souza wrote: > If the CRTC is going from enabled to disabled and it is a port sync > slave, it needs to check to the old state to be disabled before the > port sync master. Yes this makes sense, thank you for the fix Reviewed-by: Manasi na

Re: [Intel-gfx] [PATCH] drm/i915: Add new EHL/JSL PCI ids

2019-12-03 Thread Matt Roper
On Tue, Dec 03, 2019 at 01:24:10PM -0800, Matt Roper wrote: > On Tue, Dec 03, 2019 at 01:13:08PM -0800, José Roberto de Souza wrote: > > Adding the recently added EHL/JSL PCI ids. > > > > BSpec: 29153 > > Cc: James Ausmus > > Cc: Matt Roper > > Signed-off-by: José Roberto de Souza > > --- > >

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: Define each HBR link rate

2019-12-03 Thread Manasi Navare
On Tue, Dec 03, 2019 at 03:11:54PM +0200, Ville Syrjälä wrote: > On Tue, Dec 03, 2019 at 11:08:52AM +0200, Jani Nikula wrote: > > On Mon, 02 Dec 2019, José Roberto de Souza wrote: > > > This is better than keep those values in the code that you always > > > need to check the DP spec to know what l

[Intel-gfx] ✓ Fi.CI.BAT: success for Clear Color Support for TGL Render Decompression (rev12)

2019-12-03 Thread Patchwork
== Series Details == Series: Clear Color Support for TGL Render Decompression (rev12) URL : https://patchwork.freedesktop.org/series/66814/ State : success == Summary == CI Bug Log - changes from CI_DRM_7477 -> Patchwork_15568 Summary -

Re: [Intel-gfx] [PATCH v3] drm/i915/display/tgl: Do not program clockgating

2019-12-03 Thread Matt Roper
On Tue, Dec 03, 2019 at 01:29:02PM -0800, José Roberto de Souza wrote: > Talked with HW team and this is a left over, driver should not > program clockgating, dekel firmware will be reponsible for any > clockgating programing. > > v2: > Added WARN_ON > > v3: > Only calling icl_phy_set_clock_gatin

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: Define each HBR link rate

2019-12-03 Thread Souza, Jose
On Tue, 2019-12-03 at 15:11 +0200, Ville Syrjälä wrote: > On Tue, Dec 03, 2019 at 11:08:52AM +0200, Jani Nikula wrote: > > On Mon, 02 Dec 2019, José Roberto de Souza > > wrote: > > > This is better than keep those values in the code that you always > > > need to check the DP spec to know what leve

Re: [Intel-gfx] [PATCH 4/7] drm/i915: Clean up intel_{pre, post}_plane_update()

2019-12-03 Thread Souza, Jose
On Thu, 2019-11-28 at 14:02 +0200, Ville Syrjälä wrote: > On Wed, Nov 27, 2019 at 11:25:07PM +, Souza, Jose wrote: > > On Wed, 2019-11-27 at 21:05 +0200, Ville Syrjala wrote: > > > From: Ville Syrjälä > > > > > > Change the calling convention to just pass the state+crtc and > > > switch to in

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Clear Color Support for TGL Render Decompression (rev12)

2019-12-03 Thread Patchwork
== Series Details == Series: Clear Color Support for TGL Render Decompression (rev12) URL : https://patchwork.freedesktop.org/series/66814/ State : warning == Summary == $ dim checkpatch origin/drm-tip eef8e7c65d3d drm/framebuffer: Format modifier for Intel Gen-12 render compression 3d307d5a0

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gt: Track the context validity explicitly

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915/gt: Track the context validity explicitly URL : https://patchwork.freedesktop.org/series/70356/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7470_full -> Patchwork_15559_full Summary -

[Intel-gfx] [PATCH v3] drm/i915/display/tgl: Do not program clockgating

2019-12-03 Thread José Roberto de Souza
Talked with HW team and this is a left over, driver should not program clockgating, dekel firmware will be reponsible for any clockgating programing. v2: Added WARN_ON v3: Only calling icl_phy_set_clock_gating() on intel_ddi_pre_enable_hdmi for GEN11 BSpec issue: 20885 BSpec: 49292 Cc: Lucas De

Re: [Intel-gfx] [PATCH] drm/i915: Add new EHL/JSL PCI ids

2019-12-03 Thread Matt Roper
On Tue, Dec 03, 2019 at 01:13:08PM -0800, José Roberto de Souza wrote: > Adding the recently added EHL/JSL PCI ids. > > BSpec: 29153 > Cc: James Ausmus > Cc: Matt Roper > Signed-off-by: José Roberto de Souza > --- > include/drm/i915_pciids.h | 7 +-- > 1 file changed, 5 insertions(+), 2 de

[Intel-gfx] [CI] drm/i915/gt: Set the PD again for Haswell

2019-12-03 Thread Chris Wilson
And Haswell still occasionally forgets it is meant to be using a new page directory, so repeat ourselves a little louder. <7> [509.919864] heartbeat rcs0 heartbeat {prio:-2147483645} not ticking <7> [509.919895] heartbeat Awake? 8 <7> [509.919903] heartbeat Barriers?: no <7> [509.919912]

[Intel-gfx] [PATCH] drm/i915: Add new EHL/JSL PCI ids

2019-12-03 Thread José Roberto de Souza
Adding the recently added EHL/JSL PCI ids. BSpec: 29153 Cc: James Ausmus Cc: Matt Roper Signed-off-by: José Roberto de Souza --- include/drm/i915_pciids.h | 7 +-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/include/drm/i915_pciids.h b/include/drm/i915_pciids.h index b1f6

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: s/HAS_128_BYTE_Y_TILING/!HAS_512_BYTE_Y_TILING/

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915: s/HAS_128_BYTE_Y_TILING/!HAS_512_BYTE_Y_TILING/ URL : https://patchwork.freedesktop.org/series/70396/ State : success == Summary == CI Bug Log - changes from CI_DRM_7475 -> Patchwork_15567 Summary

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915/display: Check the old state to find port sync slave (rev2)

2019-12-03 Thread Souza, Jose
On Tue, 2019-12-03 at 08:24 +, Patchwork wrote: > == Series Details == > > Series: series starting with [CI,1/3] drm/i915/display: Check the old > state to find port sync slave (rev2) > URL : https://patchwork.freedesktop.org/series/70320/ > State : success > > == Summary == > > CI Bug Log

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gem: Take runtime-pm wakeref prior to unbinding

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915/gem: Take runtime-pm wakeref prior to unbinding URL : https://patchwork.freedesktop.org/series/70344/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7470_full -> Patchwork_15553_full Sum

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: s/HAS_128_BYTE_Y_TILING/!HAS_512_BYTE_Y_TILING/

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915: s/HAS_128_BYTE_Y_TILING/!HAS_512_BYTE_Y_TILING/ URL : https://patchwork.freedesktop.org/series/70396/ State : warning == Summary == $ dim checkpatch origin/drm-tip 65fc147366ce drm/i915: s/HAS_128_BYTE_Y_TILING/!HAS_512_BYTE_Y_TILING/ -:69: CHECK:MACRO_AR

[Intel-gfx] ✓ Fi.CI.BAT: success for video, drm, etc: constify fbops in struct fb_info (rev2)

2019-12-03 Thread Patchwork
== Series Details == Series: video, drm, etc: constify fbops in struct fb_info (rev2) URL : https://patchwork.freedesktop.org/series/70198/ State : success == Summary == CI Bug Log - changes from CI_DRM_7475 -> Patchwork_15565 Summary -

[Intel-gfx] ✗ Fi.CI.BUILD: failure for drm/i915: Add support for HDCP 1.4 over MST connectors

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915: Add support for HDCP 1.4 over MST connectors URL : https://patchwork.freedesktop.org/series/70393/ State : failure == Summary == Applying: drm/i915: Fix sha_text population code Applying: drm/i915: Intercept Aksv writes in the aux hooks Applying: drm/i915

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for video, drm, etc: constify fbops in struct fb_info (rev2)

2019-12-03 Thread Patchwork
== Series Details == Series: video, drm, etc: constify fbops in struct fb_info (rev2) URL : https://patchwork.freedesktop.org/series/70198/ State : warning == Summary == $ dim checkpatch origin/drm-tip 5109f996a5c8 video: fbdev: atyfb: modify the static fb_ops directly -:21: CHECK:AVOID_EXTERN

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gem: Avoid parking the vma as we unbind

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915/gem: Avoid parking the vma as we unbind URL : https://patchwork.freedesktop.org/series/70382/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7474 -> Patchwork_15564 Summary --- **

Re: [Intel-gfx] [RFC 06/13] drm/i915/svm: Page table mirroring support

2019-12-03 Thread Niranjan Vishwanathapura
On Tue, Nov 26, 2019 at 06:32:52PM +, Jason Gunthorpe wrote: On Mon, Nov 25, 2019 at 11:33:27AM -0500, Jerome Glisse wrote: On Fri, Nov 22, 2019 at 11:33:12PM +, Jason Gunthorpe wrote: > On Fri, Nov 22, 2019 at 12:57:27PM -0800, Niranjana Vishwanathapura wrote: [...] > > +static int >

Re: [Intel-gfx] [RFC 06/13] drm/i915/svm: Page table mirroring support

2019-12-03 Thread Niranjan Vishwanathapura
On Tue, Nov 26, 2019 at 06:45:14PM +, Jason Gunthorpe wrote: On Mon, Nov 25, 2019 at 08:32:58AM -0800, Niranjan Vishwanathapura wrote: > And putting the cpu PFN of a ZONE_DEVICE device page into > sg_dma_address still looks very wrong to me The below call in patch 7 does convert any cpu PFN

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/irq: Refactor gen11 display interrupt handling (rev2)

2019-12-03 Thread Matt Roper
On Tue, Dec 03, 2019 at 06:40:37AM +, Patchwork wrote: > == Series Details == > > Series: drm/i915/irq: Refactor gen11 display interrupt handling (rev2) > URL : https://patchwork.freedesktop.org/series/70303/ > State : failure > > == Summary == > > CI Bug Log - changes from CI_DRM_7467_ful

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev5)

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev5) URL : https://patchwork.freedesktop.org/series/70164/ State : success == Summary == CI Bug Log - changes from CI_DRM_7474 -> Patchwork_15563 Summary ---

Re: [Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [CI,1/5] drm/i915/psr: Add bits per pixel limitation

2019-12-03 Thread Souza, Jose
On Tue, 2019-12-03 at 11:47 +0200, Jani Nikula wrote: > On Mon, 02 Dec 2019, "Souza, Jose" wrote: > > On Fri, 2019-11-29 at 08:22 +, Patchwork wrote: > > > == Series Details == > > > > > > Series: series starting with [CI,1/5] drm/i915/psr: Add bits per > > > pixel limitation > > > URL : ht

Re: [Intel-gfx] [PATCH] drm/i915: Remove tautological compare in eb_relocate_vma

2019-12-03 Thread Nick Desaulniers
On Tue, Dec 3, 2019 at 5:42 AM Chris Wilson wrote: > > Quoting Nick Desaulniers (2019-12-02 19:18:20) > > On Sat, Nov 23, 2019 at 12:05 PM Chris Wilson > > wrote: > > > > > > Quoting Nathan Chancellor (2019-11-23 19:53:22) > > > > -Wtautological-compare was recently added to -Wall in LLVM, which

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev5)

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET (rev5) URL : https://patchwork.freedesktop.org/series/70164/ State : warning == Summary == $ dim checkpatch origin/drm-tip 787a6c4246fc drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET -:459: WARNING:UNNECESSARY_ELSE: else i

Re: [Intel-gfx] [PATCH CI] drm/i915/display/tgl: Do not program clockgating

2019-12-03 Thread Souza, Jose
On Tue, 2019-12-03 at 10:20 +0200, Jani Nikula wrote: > On Mon, 02 Dec 2019, José Roberto de Souza > wrote: > > Talked with HW team and this is a left over, driver should not > > program clockgating, dekel firmware will be reponsible for any > > clockgating programing. > > > > v2: > > Added WARN_

[Intel-gfx] [PATCH] drm/i915: s/HAS_128_BYTE_Y_TILING/!HAS_512_BYTE_Y_TILING/

2019-12-03 Thread Ville Syrjala
From: Ville Syrjälä 512B Y tiling is the special case so perhaps makes sense to flip the flag around and adjust the code accordingly. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/display/intel_display.c | 6 +++--- drivers/gpu/drm/i915/gem/i915_gem_tiling.c | 2 +- drive

[Intel-gfx] [PATCH 06/11] drm/i915: Factor out hdcp->value assignments

2019-12-03 Thread Sean Paul
From: Sean Paul This is a bit of housecleaning for a future patch. Instead of sprinkling hdcp->value assignments and prop_work scheduling everywhere, introduce a function to do it for us. Signed-off-by: Sean Paul --- drivers/gpu/drm/i915/display/intel_hdcp.c | 67 --- 1 fil

[Intel-gfx] [PATCH 11/11] drm/i915: Add HDCP 1.4 support for MST connectors

2019-12-03 Thread Sean Paul
From: Sean Paul Now that all the groundwork has been laid, we can turn on HDCP 1.4 over MST. Everything except for toggling the HDCP signalling and HDCP 2.2 support is the same as the DP case, so we'll re-use those callbacks Signed-off-by: Sean Paul --- drivers/gpu/drm/i915/display/intel_dp_ms

[Intel-gfx] [PATCH 10/11] drm/i915: Expose HDCP shim functions from dp for use by dp_mst

2019-12-03 Thread Sean Paul
From: Sean Paul These functions are all the same for dp and dp_mst, so expose them for use by the dp_mst hdcp implementation. Signed-off-by: Sean Paul --- .../drm/i915/display/intel_display_types.h| 22 +++ drivers/gpu/drm/i915/display/intel_dp.c | 14 ++-- 2

[Intel-gfx] [PATCH 09/11] drm/i915: Use ddi_update_pipe in intel_dp_mst

2019-12-03 Thread Sean Paul
From: Sean Paul In order to act upon content_protection property changes, we'll need to implement the .update_pipe() hook. We can re-use intel_ddi_update_pipe for this Signed-off-by: Sean Paul --- drivers/gpu/drm/i915/display/intel_ddi.c| 9 + drivers/gpu/drm/i915/display/intel_dp.

[Intel-gfx] [PATCH 08/11] drm/i915: Support DP MST in enc_to_dig_port() function

2019-12-03 Thread Sean Paul
From: Sean Paul Although DP_MST fake encoders are not subclassed from digital ports, they are associated with them. Support these encoders. Signed-off-by: Sean Paul --- .../drm/i915/display/intel_display_types.h| 19 +-- 1 file changed, 13 insertions(+), 6 deletions(-) dif

[Intel-gfx] [PATCH 03/11] drm/i915: Disable HDCP signalling on transcoder disable

2019-12-03 Thread Sean Paul
From: Sean Paul Currently we rely on intel_hdcp_disable() to disable HDCP signalling in the DDI Function Control register. This patch adds a safety net by also clearing the bit when we disable the transcoder. Once we have HDCP over MST and disappearing connectors, we want to make sure that the s

[Intel-gfx] [PATCH 01/11] drm/i915: Fix sha_text population code

2019-12-03 Thread Sean Paul
From: Sean Paul This patch fixes a few bugs: 1- We weren't taking into account sha_leftovers when adding multiple ksvs to sha_text. As such, we were or'ing the end of ksv[j - 1] with the beginning of ksv[j] 2- In the sha_leftovers == 2 and sha_leftovers == 3 case, bstatus was being pla

[Intel-gfx] [PATCH 07/11] drm/i915: Don't fully disable HDCP on a port if multiple pipes are using it

2019-12-03 Thread Sean Paul
From: Sean Paul This patch is required for HDCP over MST. If a port is being used for multiple HDCP streams, we don't want to fully disable HDCP on a port if one of them is disabled. Instead, we just disable the HDCP signalling on that particular pipe and exit early. The last pipe to disable HDCP

[Intel-gfx] [PATCH 04/11] drm/i915: Don't WARN on HDCP toggle if get_hw_state returns false

2019-12-03 Thread Sean Paul
From: Sean Paul Now that we can rely on transcoder disable to toggle signalling off, it's less of a catastrophe if get_hw_state() returns false. Once we enable MST, this will be a valid exit path and we want to make sure we're not spamming the logs needlessly. Signed-off-by: Sean Paul --- dri

[Intel-gfx] [PATCH 00/11] drm/i915: Add support for HDCP 1.4 over MST connectors

2019-12-03 Thread Sean Paul
From: Sean Paul Hey all, As the subject says, this set adds support for HDCP 1.4 over MST. Most of the set is plumbing and refactor to allow the MST support to slot in organically. I stubbed out HDCP 2.2 support since I don't have a means of testing it. If no one picks up the slack, I can come b

[Intel-gfx] [PATCH 05/11] drm/i915: Change toggle_signalling() argument to connector

2019-12-03 Thread Sean Paul
From: Sean Paul HDCP over MST requires us to toggle ddi signalling. Since we'll want to toggle signalling on the pipe associated with the fake encoder as opposed to the digital port's base, we need to get it from connector. This patch converts all existing callers and implementations to use conn

[Intel-gfx] [PATCH 02/11] drm/i915: Intercept Aksv writes in the aux hooks

2019-12-03 Thread Sean Paul
From: Sean Paul Instead of hand rolling the transfer ourselves in the hdcp hook, inspect aux messages and add the aksv flag in the aux transfer hook. IIRC, this was the original implementation and folks wanted this hack to be isolated to the hdcp code, which makes sense. However in testing an L

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gt: Set the PD again for Haswell (rev4)

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915/gt: Set the PD again for Haswell (rev4) URL : https://patchwork.freedesktop.org/series/70321/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7471 -> Patchwork_15562 Summary --- **

Re: [Intel-gfx] [PATCH v3 07/12] video: fbdev: intelfb: use const pointer for fb_ops

2019-12-03 Thread Daniel Vetter
On Tue, Dec 03, 2019 at 06:38:49PM +0200, Jani Nikula wrote: > Use const for fb_ops to let us make the fbops struct const in the > future. > > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/video/fbdev/intelfb/intelfb.h | 2 +- > 1 file changed, 1 insertion(+), 1 de

Re: [Intel-gfx] [PATCH v3 04/12] video: fbdev: uvesafb: modify the static fb_ops directly

2019-12-03 Thread Daniel Vetter
On Tue, Dec 03, 2019 at 06:38:46PM +0200, Jani Nikula wrote: > Avoid modifying the fb_ops via info->fbops to let us make the pointer > const in the future. > > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/video/fbdev/uvesafb.c | 4 ++-- > 1 file changed, 2 inserti

Re: [Intel-gfx] [PATCH v3 03/12] video: fbdev: nvidia: modify the static fb_ops directly

2019-12-03 Thread Daniel Vetter
On Tue, Dec 03, 2019 at 06:38:45PM +0200, Jani Nikula wrote: > Avoid modifying the fb_ops via info->fbops to let us make the pointer > const in the future. > > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/video/fbdev/nvidia/nvidia.c | 20 +++- > 1

Re: [Intel-gfx] [PATCH v3 02/12] video: fbdev: mb862xx: modify the static fb_ops directly

2019-12-03 Thread Daniel Vetter
On Tue, Dec 03, 2019 at 06:38:44PM +0200, Jani Nikula wrote: > Avoid modifying the fb_ops via info->fbops to let us make the pointer > const in the future. Drop the unnecessary EXPORT_SYMBOL() while at it. > > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/video/fbd

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gt: Set the PD again for Haswell (rev4)

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915/gt: Set the PD again for Haswell (rev4) URL : https://patchwork.freedesktop.org/series/70321/ State : warning == Summary == $ dim checkpatch origin/drm-tip 16a289e5501c drm/i915/gt: Set the PD again for Haswell -:22: WARNING:COMMIT_LOG_LONG_LINE: Possible

Re: [Intel-gfx] [PATCH v3 01/12] video: fbdev: atyfb: modify the static fb_ops directly

2019-12-03 Thread Daniel Vetter
On Tue, Dec 03, 2019 at 06:38:43PM +0200, Jani Nikula wrote: > Avoid modifying the fb_ops via info->fbops to let us make the pointer > const in the future. > > Cc: linux-fb...@vger.kernel.org > Signed-off-by: Jani Nikula > --- > drivers/video/fbdev/aty/atyfb.h | 2 +- > drivers/video/fbd

Re: [Intel-gfx] [PATCH 0/4] consistently use dma_resv locking wrappers

2019-12-03 Thread Daniel Vetter
On Mon, Nov 25, 2019 at 10:43:52AM +0100, Daniel Vetter wrote: > Hi all, > > This is prep work for some dma_resv series I'm tinkering with, but I > figured good to split this out since good idea to land this no matter what > exactly I'll end up creating in dma_resv. With these everything in > driv

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915/execlists: Add a couple more validity checks to assert_pending()

2019-12-03 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/execlists: Add a couple more validity checks to assert_pending() URL : https://patchwork.freedesktop.org/series/70375/ State : failure == Summary == CI Bug Log - changes from CI_DRM_7471 -> Patchwork_15561 ==

Re: [Intel-gfx] [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info

2019-12-03 Thread Jani Nikula
On Tue, 03 Dec 2019, Jani Nikula wrote: > This is v3 of https://patchwork.freedesktop.org/series/70198/. > > 0day reported some build failures, and I needed to add patches 1-5 and 7 Should be, patches 1-4 and 7. > to address them. Patch 8 was amended accordingly (dropped some consts), > but the

[Intel-gfx] [PATCH v3 10/12] media: constify fb ops across all drivers

2019-12-03 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. Remove the redundant fbops assignments while at it. v2: - actually add const in vivid - fix typo (Christophe de Dinechin) Cc: Hans Verkuil Cc: Andy Walls Cc: linux-me...@vger.kernel.org Cc: ivtv-de

[Intel-gfx] [PATCH v3 12/12] auxdisplay: constify fb ops

2019-12-03 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. Cc: Miguel Ojeda Sandonis Cc: Robin van der Gracht Reviewed-by: Daniel Vetter Reviewed-by: Miguel Ojeda Acked-by: Robin van der Gracht Signed-off-by: Jani Nikula --- drivers/auxdisplay/cfag12864

[Intel-gfx] [PATCH v3 06/12] drm: constify fb ops across all drivers

2019-12-03 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. Cc: dri-de...@lists.freedesktop.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- drivers/gpu/drm/amd/amdgpu/amdgpu_fb.c| 2 +- drivers/gpu/drm/armada/armada_fbdev.c

[Intel-gfx] [PATCH v3 11/12] samples: vfio-mdev: constify fb ops

2019-12-03 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. v2: fix typo (Christophe de Dinechin) Cc: Kirti Wankhede Cc: k...@vger.kernel.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- samples/vfio-mdev/mdpy-fb.c | 2 +- 1 file changed, 1 in

[Intel-gfx] [PATCH v3 08/12] video: constify fb ops across all drivers

2019-12-03 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. This does not cover all drivers; some actually modify the fbops struct, for example to adjust for different configurations, and others do more involved things that I'd rather not touch in practically o

[Intel-gfx] [PATCH v3 09/12] HID: picoLCD: constify fb ops

2019-12-03 Thread Jani Nikula
Now that the fbops member of struct fb_info is const, we can start making the ops const as well. v2: fix typo (Christophe de Dinechin) Cc: Bruno Prémont Cc: linux-in...@vger.kernel.org Reviewed-by: Daniel Vetter Acked-by: Bruno Prémont Signed-off-by: Jani Nikula --- drivers/hid/hid-picolcd_f

[Intel-gfx] [PATCH v3 07/12] video: fbdev: intelfb: use const pointer for fb_ops

2019-12-03 Thread Jani Nikula
Use const for fb_ops to let us make the fbops struct const in the future. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/intelfb/intelfb.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/video/fbdev/intelfb/intelfb.h b/drivers/vide

[Intel-gfx] [PATCH v3 03/12] video: fbdev: nvidia: modify the static fb_ops directly

2019-12-03 Thread Jani Nikula
Avoid modifying the fb_ops via info->fbops to let us make the pointer const in the future. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/nvidia/nvidia.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) diff --git a/drivers/video/fb

[Intel-gfx] [PATCH v3 02/12] video: fbdev: mb862xx: modify the static fb_ops directly

2019-12-03 Thread Jani Nikula
Avoid modifying the fb_ops via info->fbops to let us make the pointer const in the future. Drop the unnecessary EXPORT_SYMBOL() while at it. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/mb862xx/mb862xxfb.h | 2 +- drivers/video/fbdev/mb862xx/mb862xxfb

[Intel-gfx] [PATCH v3 00/12] video, drm, etc: constify fbops in struct fb_info

2019-12-03 Thread Jani Nikula
This is v3 of https://patchwork.freedesktop.org/series/70198/. 0day reported some build failures, and I needed to add patches 1-5 and 7 to address them. Patch 8 was amended accordingly (dropped some consts), but the other patches remain the same from v2, except the ones I merged already. BR, Jani

[Intel-gfx] [PATCH v3 05/12] video: fbdev: make fbops member of struct fb_info a const pointer

2019-12-03 Thread Jani Nikula
Now that we no longer modify the fbops, or hold non-const pointers to it, we can make it const. After this, we can start making the fbops const all over the place. Cc: linux-fb...@vger.kernel.org Reviewed-by: Daniel Vetter Signed-off-by: Jani Nikula --- include/linux/fb.h | 2 +- 1 file changed

[Intel-gfx] [PATCH v3 01/12] video: fbdev: atyfb: modify the static fb_ops directly

2019-12-03 Thread Jani Nikula
Avoid modifying the fb_ops via info->fbops to let us make the pointer const in the future. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/aty/atyfb.h | 2 +- drivers/video/fbdev/aty/atyfb_base.c| 6 +++--- drivers/video/fbdev/aty/mach64_cursor.c |

[Intel-gfx] [PATCH v3 04/12] video: fbdev: uvesafb: modify the static fb_ops directly

2019-12-03 Thread Jani Nikula
Avoid modifying the fb_ops via info->fbops to let us make the pointer const in the future. Cc: linux-fb...@vger.kernel.org Signed-off-by: Jani Nikula --- drivers/video/fbdev/uvesafb.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/video/fbdev/uvesafb.c b/drivers/

Re: [Intel-gfx] [PATCH 2/2] drm/i915/dp/tgl+: Update combo phy vswing tables

2019-12-03 Thread Matt Roper
On Mon, Dec 02, 2019 at 06:31:10PM -0800, José Roberto de Souza wrote: > TGL has now a table for RBR and HBR and another table for HBR2 over > combo phys. The HBR2 one has some small changes comparing to the ICL > one, so adding two new tables and adding a function to return TGL > combo phy tables.

Re: [Intel-gfx] [PATCH 1/2] drm/i915/dp: Define each HBR link rate

2019-12-03 Thread Matt Roper
On Mon, Dec 02, 2019 at 06:31:09PM -0800, José Roberto de Souza wrote: > This is better than keep those values in the code that you always > need to check the DP spec to know what level of HBR it is. > > Signed-off-by: José Roberto de Souza I think there are a bunch of other places where we coul

[Intel-gfx] ✗ Fi.CI.BUILD: failure for Refactor Gen11+ SAGV support (rev12)

2019-12-03 Thread Patchwork
== Series Details == Series: Refactor Gen11+ SAGV support (rev12) URL : https://patchwork.freedesktop.org/series/68028/ State : failure == Summary == Applying: drm/i915: Refactor intel_can_enable_sagv Using index info to reconstruct a base tree... M drivers/gpu/drm/i915/display/intel_dis

[Intel-gfx] [CI] drm/i915/gem: Avoid parking the vma as we unbind

2019-12-03 Thread Chris Wilson
In order to avoid keeping a reference on the i915_vma (which is long overdue!) we have to coordinate all the possible lifetimes and only use the vma while we know it is alive. In this episode, we are reminded that while idle, the closed vma are destroyed. So if the GT idles while we are working wit

Re: [Intel-gfx] [PATCH 2/2] drm/i915/execlists: Skip nested spinlock for validating pending

2019-12-03 Thread Chris Wilson
Quoting Chris Wilson (2019-12-03 15:26:31) > Only along the submission path can we guarantee that the locked request > is indeed from a foreign engine, and so the nesting of engine/rq is > permissible. On the submission tasklet (process_csb()), we may find > ourselves competing with the normal nest

Re: [Intel-gfx] [PATCH 2/2] drm/i915/execlists: Skip nested spinlock for validating pending

2019-12-03 Thread Chris Wilson
Quoting Tvrtko Ursulin (2019-12-03 15:38:20) > > On 03/12/2019 11:53, Chris Wilson wrote: > > Only along the submission path can we guarantee that the locked request > > is indeed from a foreign engine, and so the nesting of engine/rq is > > permissible. On the submission tasklet (process_csb()),

Re: [Intel-gfx] [PATCH 1/2] drm/i915/execlists: Add a couple more validity checks to assert_pending()

2019-12-03 Thread Chris Wilson
Quoting Chris Wilson (2019-12-03 15:26:30) > Check the pending request submission is valid: that it at least has a > reference for the submission and that the request is on the active list. > > Signed-off-by: Chris Wilson Reviewed-by: Tvrtko Ursulin -Chris ___

Re: [Intel-gfx] [PATCH 2/2] drm/i915/execlists: Skip nested spinlock for validating pending

2019-12-03 Thread Tvrtko Ursulin
On 03/12/2019 11:53, Chris Wilson wrote: Only along the submission path can we guarantee that the locked request is indeed from a foreign engine, and so the nesting of engine/rq is permissible. On the submission tasklet (process_csb()), we may find ourselves competing with the normal nesting of

Re: [Intel-gfx] [PATCH 2/2] drm/i915/execlists: Skip nested spinlock for validating pending

2019-12-03 Thread Chris Wilson
Quoting Chris Wilson (2019-12-03 15:26:31) > Only along the submission path can we guarantee that the locked request > is indeed from a foreign engine, and so the nesting of engine/rq is > permissible. On the submission tasklet (process_csb()), we may find > ourselves competing with the normal nest

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gt: Track the context validity explicitly

2019-12-03 Thread Patchwork
== Series Details == Series: drm/i915/gt: Track the context validity explicitly URL : https://patchwork.freedesktop.org/series/70356/ State : success == Summary == CI Bug Log - changes from CI_DRM_7470 -> Patchwork_15559 Summary ---

[Intel-gfx] [CI] drm/i915: Introduce DRM_I915_GEM_MMAP_OFFSET

2019-12-03 Thread Chris Wilson
From: Abdiel Janulgue This is really just an alias of mmap_gtt. The 'mmap offset' nomenclature comes from the value returned by this ioctl which is the offset into the device fd which userpace uses with mmap(2). mmap_gtt was our initial mmap_offset implementation, this extends our CPU mmap suppo

  1   2   >