Re: [Intel-gfx] [PATCH v7 10/11] drm/hdcp: update content protection property with uevent

2019-07-04 Thread Ramalingam C
On 2019-07-04 at 14:14:19 +0300, Pekka Paalanen wrote: > On Tue, 7 May 2019 21:57:44 +0530 > Ramalingam C wrote: > > > drm function is defined and exported to update a connector's > > content protection property state and to generate a uevent along > > with it. > > > > Need ACK for the uevent f

[Intel-gfx] ✓ Fi.CI.IGT: success for EHL port programming (rev6)

2019-07-04 Thread Patchwork
== Series Details == Series: EHL port programming (rev6) URL : https://patchwork.freedesktop.org/series/62492/ State : success == Summary == CI Bug Log - changes from CI_DRM_6406_full -> Patchwork_13522_full Summary --- **SUCCESS**

[Intel-gfx] ✗ Fi.CI.BAT: failure for + diff-sucks.patch added to -mm tree

2019-07-04 Thread Patchwork
== Series Details == Series: + diff-sucks.patch added to -mm tree URL : https://patchwork.freedesktop.org/series/63251/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6422 -> Patchwork_13539 Summary --- **FAILURE**

Re: [Intel-gfx] mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

2019-07-04 Thread Andrew Morton
On Thu, 04 Jul 2019 22:22:41 -0700 Joe Perches wrote: > > So when comparing a zero-length file with a non-existent file, diff > > produces no output. > > Why use the -N option ? > > $ diff --help > [...] > -N, --new-file treat absent files as empty > > otherwise > > $ cd $(

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for + diff-sucks.patch added to -mm tree

2019-07-04 Thread Patchwork
== Series Details == Series: + diff-sucks.patch added to -mm tree URL : https://patchwork.freedesktop.org/series/63251/ State : warning == Summary == $ dim checkpatch origin/drm-tip cdf723d72139 + diff-sucks.patch added to -mm tree -:22: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit

Re: [Intel-gfx] mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

2019-07-04 Thread Joe Perches
On Thu, 2019-07-04 at 22:09 -0700, Andrew Morton wrote: > diff(1) doesn't seem to know how to handle a zero-length file. > > y:/home/akpm> mkdir foo > y:/home/akpm> cd foo > y:/home/akpm/foo> touch x > y:/home/akpm/foo> diff -uN x y > y:/home/akpm/foo> date > x > y:/home/akpm/foo> diff -uN x y > -

[Intel-gfx] ✗ Fi.CI.BAT: failure for mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

2019-07-04 Thread Patchwork
== Series Details == Series: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/) URL : https://patchwork.freedesktop.org/series/63249/ State : failure == Summary == Applying: mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/) error: sha1 information is lacking or useless (y). error: could not b

Re: [Intel-gfx] mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

2019-07-04 Thread Andrew Morton
On Fri, 5 Jul 2019 13:14:35 +1000 Stephen Rothwell wrote: > > I checked next-20190704 tag. > > > > I see the empty file > > drivers/gpu/drm/i915/oa/Makefile > > > > Did someone delete it? > > Commit > > 5ed7a0cf3394 ("drm/i915: Move

[Intel-gfx] + diff-sucks.patch added to -mm tree

2019-07-04 Thread akpm
The patch titled Subject: diff sucks has been added to the -mm tree. Its filename is diff-sucks.patch This patch should soon appear at http://ozlabs.org/~akpm/mmots/broken-out/diff-sucks.patch and later at http://ozlabs.org/~akpm/mmotm/broken-out/diff-sucks.patch Before you ju

[Intel-gfx] ✓ Fi.CI.IGT: success for Modular FIA

2019-07-04 Thread Patchwork
== Series Details == Series: Modular FIA URL : https://patchwork.freedesktop.org/series/63175/ State : success == Summary == CI Bug Log - changes from CI_DRM_6405_full -> Patchwork_13521_full Summary --- **SUCCESS** No regressions

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915: make new intel_tc.c use uncore accessors

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: make new intel_tc.c use uncore accessors URL : https://patchwork.freedesktop.org/series/63174/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6405_full -> Patchwork_13519_full ===

Re: [Intel-gfx] mmotm 2019-07-04-15-01 uploaded (gpu/drm/i915/oa/)

2019-07-04 Thread Stephen Rothwell
vers/gpu/drm/i915/oa] Error 2 > > ../scripts/Makefile.build:498: recipe for target 'drivers/gpu/drm/i915' > > failed > > > > I checked next-20190704 tag. > > I see the empty file > drivers/gpu/drm/i915/oa/Makefile > > Did someone delete i

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/ehl: Add support for DPLL4 (v10)

2019-07-04 Thread Patchwork
== Series Details == Series: drm/i915/ehl: Add support for DPLL4 (v10) URL : https://patchwork.freedesktop.org/series/63171/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6405_full -> Patchwork_13517_full Summary ---

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Random plane stuff

2019-07-04 Thread Patchwork
== Series Details == Series: drm/i915: Random plane stuff URL : https://patchwork.freedesktop.org/series/63165/ State : success == Summary == CI Bug Log - changes from CI_DRM_6405_full -> Patchwork_13515_full Summary --- **SUCCESS**

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v2] drm/i915/gem: Defer obj->base.resv fini until RCU callback (rev2)

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [v2] drm/i915/gem: Defer obj->base.resv fini until RCU callback (rev2) URL : https://patchwork.freedesktop.org/series/63160/ State : success == Summary == CI Bug Log - changes from CI_DRM_6405_full -> Patchwork_13514_full =

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [1/4] drm/i915: Check caller held wakerefs in assert_forcewakes_active

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [1/4] drm/i915: Check caller held wakerefs in assert_forcewakes_active URL : https://patchwork.freedesktop.org/series/63151/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6404_full -> Patchwork_13512_full =

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/3] drm/i915/overlay: Stash the kernel context on initialisation (rev2)

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/overlay: Stash the kernel context on initialisation (rev2) URL : https://patchwork.freedesktop.org/series/63240/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6418 -> Patchwork_13537

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/hangcheck: Look at instdone for all engines (rev2)

2019-07-04 Thread Patchwork
== Series Details == Series: drm/i915/hangcheck: Look at instdone for all engines (rev2) URL : https://patchwork.freedesktop.org/series/61843/ State : success == Summary == CI Bug Log - changes from CI_DRM_6404_full -> Patchwork_13511_full

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Show instdone for each engine in debugfs

2019-07-04 Thread Matthew Auld
On Thu, 4 Jul 2019 at 21:05, Chris Wilson wrote: > > Although polling each engine quickly is preferable as it should give us > a sample of each engine at roughly the same time, keep it simple and > just sample the engine as print out the debug state. as we > > Signed-off-by: Chris Wilson Review

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] i915/gem_create: Show number of pages cleared

2019-07-04 Thread Matthew Auld
On Tue, 2 Jul 2019 at 19:58, Chris Wilson wrote: > > Just a little bit of feedback at the end of an otherwise quiet 20s. > > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org https://lists.

[Intel-gfx] [PATCH v2] drm/i915/selftests: Be engine agnostic

2019-07-04 Thread Chris Wilson
When using MI operations, we do not care which engine we use, so use them all where possible, and where inconvenient double check we have the engine we selected at random. v2: Drop the local copy of engine->sseu to avoid an unchecked deref Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld -

Re: [Intel-gfx] [PATCH 1/3] drm/i915/overlay: Stash the kernel context on initialisation

2019-07-04 Thread Matthew Auld
On Thu, 4 Jul 2019 at 21:05, Chris Wilson wrote: > > Simplify runtime request creation by storing the context we need to use > during initialisation. This allows us to remove one more hardcoded > engine lookup. > > Signed-off-by: Chris Wilson Reviewed-by: Matthew Auld ___

Re: [Intel-gfx] [PATCH 2/3] drm/i915/selftests: Be engine agnostic

2019-07-04 Thread Matthew Auld
On Thu, 4 Jul 2019 at 21:05, Chris Wilson wrote: > > When using MI operations, we do not care which engine we use, so use > them all where possible, and where inconvenient double check we have the > engine we selected at random. > > Signed-off-by: Chris Wilson > > diff --git a/drivers/gpu/drm/

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/gtt: Mark the freed page table entries with scratch

2019-07-04 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Mark the freed page table entries with scratch URL : https://patchwork.freedesktop.org/series/63241/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6418 -> Patchwork_13536 Summary -

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Show support for accurate sw PMU busyness tracking

2019-07-04 Thread Patchwork
== Series Details == Series: drm/i915: Show support for accurate sw PMU busyness tracking URL : https://patchwork.freedesktop.org/series/63144/ State : success == Summary == CI Bug Log - changes from CI_DRM_6404_full -> Patchwork_13510_full

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Drain the freedlists between exec passes

2019-07-04 Thread Matthew Auld
On Thu, 4 Jul 2019 at 17:53, Chris Wilson wrote: > > During the context execution tests, we issue a lot of work and discard a > lot of objects without releasing the lock and allowing the background > reaper to free those objects. Insert a small break between each pass to > flush the worker. > > Si

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Mark the freed page table entries with scratch

2019-07-04 Thread Matthew Auld
On Thu, 4 Jul 2019 at 21:17, Chris Wilson wrote: > > On unwinding the allocation error path and having freed the page table > entry, it is imperative that we mark it as scratch. > > <4> [416.075569] general protection fault: [#1] PREEMPT SMP PTI > <4> [416.075801] CPU: 0 PID: 2385 Comm: kwork

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/gtt: Mark the freed page table entries with scratch

2019-07-04 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Mark the freed page table entries with scratch URL : https://patchwork.freedesktop.org/series/63241/ State : warning == Summary == $ dim checkpatch origin/drm-tip 9ce6db8f4b00 drm/i915/gtt: Mark the freed page table entries with scratch -:10: WARNING:

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/overlay: Stash the kernel context on initialisation

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/overlay: Stash the kernel context on initialisation URL : https://patchwork.freedesktop.org/series/63240/ State : success == Summary == CI Bug Log - changes from CI_DRM_6418 -> Patchwork_13535 ===

[Intel-gfx] [PATCH] drm/i915/gtt: Mark the freed page table entries with scratch

2019-07-04 Thread Chris Wilson
On unwinding the allocation error path and having freed the page table entry, it is imperative that we mark it as scratch. <4> [416.075569] general protection fault: [#1] PREEMPT SMP PTI <4> [416.075801] CPU: 0 PID: 2385 Comm: kworker/u2:11 Tainted: G U 5.2.0-rc7-CI-Patchwork_

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Order assert forcewake test

2019-07-04 Thread Patchwork
== Series Details == Series: drm/i915: Order assert forcewake test URL : https://patchwork.freedesktop.org/series/63238/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6418 -> Patchwork_13534 Summary --- **FAILURE**

[Intel-gfx] [PATCH 3/3] drm/i915: Show instdone for each engine in debugfs

2019-07-04 Thread Chris Wilson
Although polling each engine quickly is preferable as it should give us a sample of each engine at roughly the same time, keep it simple and just sample the engine as print out the debug state. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 33 -

[Intel-gfx] [PATCH 2/3] drm/i915/selftests: Be engine agnostic

2019-07-04 Thread Chris Wilson
When using MI operations, we do not care which engine we use, so use them all where possible, and where inconvenient double check we have the engine we selected at random. Signed-off-by: Chris Wilson --- .../gpu/drm/i915/gem/selftests/huge_pages.c | 42 +++ .../i915/gem/selftes

[Intel-gfx] [PATCH 1/3] drm/i915/overlay: Stash the kernel context on initialisation

2019-07-04 Thread Chris Wilson
Simplify runtime request creation by storing the context we need to use during initialisation. This allows us to remove one more hardcoded engine lookup. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/display/intel_overlay.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-)

[Intel-gfx] [PATCH] drm/i915: Order assert forcewake test

2019-07-04 Thread Chris Wilson
Read the current value before computing the expected to ensure that if the timer does complete early (against our will), it should not cause a false positive. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/intel_uncore.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --gi

Re: [Intel-gfx] [PATCH 2/4] drm/i915: fix include order in intel_tc.*

2019-07-04 Thread Imre Deak
On Thu, Jul 04, 2019 at 07:56:09PM +0200, Michal Wajdeczko wrote: > On Thu, 04 Jul 2019 19:43:12 +0200, Imre Deak wrote: > > > On Thu, Jul 04, 2019 at 07:21:38PM +0200, Michal Wajdeczko wrote: > > > On Thu, 04 Jul 2019 02:06:47 +0200, Lucas De Marchi > > > wrote: > > > > > > > Make intel_tc.h t

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Dump w/a lists on all engines (rev2)

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Dump w/a lists on all engines (rev2) URL : https://patchwork.freedesktop.org/series/63140/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6417 -> Patchwork_13533 =

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Drain the freedlists between exec passes

2019-07-04 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Drain the freedlists between exec passes URL : https://patchwork.freedesktop.org/series/63233/ State : success == Summary == CI Bug Log - changes from CI_DRM_6417 -> Patchwork_13532 Summary -

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Dump w/a lists on all engines (rev2)

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Dump w/a lists on all engines (rev2) URL : https://patchwork.freedesktop.org/series/63140/ State : warning == Summary == $ dim checkpatch origin/drm-tip ed6225abf6d0 drm/i915: Dump w/a lists on all engines -:48: WARNING:PREFER_

Re: [Intel-gfx] [PATCH v7 10/11] drm/hdcp: update content protection property with uevent

2019-07-04 Thread Ramalingam C
On 2019-07-04 at 14:14:19 +0300, Pekka Paalanen wrote: > On Tue, 7 May 2019 21:57:44 +0530 > Ramalingam C wrote: > > > drm function is defined and exported to update a connector's > > content protection property state and to generate a uevent along > > with it. > > > > Need ACK for the uevent f

Re: [Intel-gfx] [PATCH 2/4] drm/i915: fix include order in intel_tc.*

2019-07-04 Thread Michal Wajdeczko
On Thu, 04 Jul 2019 19:43:12 +0200, Imre Deak wrote: On Thu, Jul 04, 2019 at 07:21:38PM +0200, Michal Wajdeczko wrote: On Thu, 04 Jul 2019 02:06:47 +0200, Lucas De Marchi wrote: > Make intel_tc.h the first include so we guarantee it's self-contained. > Sort the rest. Same principle applies f

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/3] drm/i915/gtt: pde entry encoding is identical

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gtt: pde entry encoding is identical URL : https://patchwork.freedesktop.org/series/63229/ State : success == Summary == CI Bug Log - changes from CI_DRM_6417 -> Patchwork_13531 ===

Re: [Intel-gfx] [PATCH 2/4] drm/i915: fix include order in intel_tc.*

2019-07-04 Thread Imre Deak
On Thu, Jul 04, 2019 at 07:21:38PM +0200, Michal Wajdeczko wrote: > On Thu, 04 Jul 2019 02:06:47 +0200, Lucas De Marchi > wrote: > > > Make intel_tc.h the first include so we guarantee it's self-contained. > > Sort the rest. Same principle applies for includes in the header. > > > > Signed-off-b

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-07-04 Thread Ramalingam C
On 2019-07-04 at 14:12:27 +0300, Pekka Paalanen wrote: > On Tue, 7 May 2019 21:57:43 +0530 > Ramalingam C wrote: > > > DRM API for generating uevent for a status changes of connector's > > property. > > > > This uevent will have following details related to the status change: > > > > HOTPLUG

Re: [Intel-gfx] [PATCH v7 07/11] drm: Add Content protection type property

2019-07-04 Thread Ramalingam C
On 2019-07-04 at 14:11:59 +0300, Pekka Paalanen wrote: > On Tue, 7 May 2019 21:57:41 +0530 > Ramalingam C wrote: > > > This patch adds a DRM ENUM property to the selected connectors. > > This property is used for mentioning the protected content's type > > from userspace to kernel HDCP authentic

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/3] drm/i915/gtt: pde entry encoding is identical

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gtt: pde entry encoding is identical URL : https://patchwork.freedesktop.org/series/63229/ State : warning == Summary == $ dim sparse origin/drm-tip Sparse version: v0.5.2 Commit: drm/i915/gtt: pde entry encoding is identical -O:

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/3] drm/i915/gtt: pde entry encoding is identical

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915/gtt: pde entry encoding is identical URL : https://patchwork.freedesktop.org/series/63229/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3d60e2b75e24 drm/i915/gtt: pde entry encoding is identical -:58: CHECK:MACRO

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915/gtt: Defer the free for alloc error paths

2019-07-04 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Defer the free for alloc error paths URL : https://patchwork.freedesktop.org/series/63127/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6404_full -> Patchwork_13508_full Summary -

Re: [Intel-gfx] [PATCH 2/4] drm/i915: fix include order in intel_tc.*

2019-07-04 Thread Michal Wajdeczko
On Thu, 04 Jul 2019 02:06:47 +0200, Lucas De Marchi wrote: Make intel_tc.h the first include so we guarantee it's self-contained. Sort the rest. Same principle applies for includes in the header. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/display/intel_tc.c | 5 +++-- drivers/

[Intel-gfx] [PATCH] drm/i915/selftests: Drain the freedlists between exec passes

2019-07-04 Thread Chris Wilson
During the context execution tests, we issue a lot of work and discard a lot of objects without releasing the lock and allowing the background reaper to free those objects. Insert a small break between each pass to flush the worker. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/gem/selfte

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Check caller held wakerefs in assert_forcewakes_active

2019-07-04 Thread Patchwork
== Series Details == Series: drm/i915: Check caller held wakerefs in assert_forcewakes_active URL : https://patchwork.freedesktop.org/series/63125/ State : success == Summary == CI Bug Log - changes from CI_DRM_6404_full -> Patchwork_13507_full =

[Intel-gfx] [PATCH i-g-t 1/3] uapi/i915: Sync to bf73fc0fa9cf

2019-07-04 Thread Chris Wilson
Pull in i915_drm.h up to commit bf73fc0fa9cf ("drm/i915: Show support for accurate sw PMU busyness tracking") for the new cap bits. Signed-off-by: Chris Wilson --- include/drm-uapi/i915_drm.h | 1 + 1 file changed, 1 insertion(+) diff --git a/include/drm-uapi/i915_drm.h b/include/drm-uapi/i915_

[Intel-gfx] [PATCH i-g-t 2/3] lib/i915: Report I915_SCHEDULER_CAP_ENGINE_BUSY_STATS

2019-07-04 Thread Chris Wilson
Hook the new capability bit alongside the existing scheduler reporting. Signed-off-by: Chris Wilson --- lib/i915/gem_scheduler.c | 15 +++ lib/i915/gem_scheduler.h | 1 + 2 files changed, 16 insertions(+) diff --git a/lib/i915/gem_scheduler.c b/lib/i915/gem_scheduler.c index 1ea910

[Intel-gfx] [PATCH i-g-t 3/3] perf_pmu: Refine requirement testing for engine-busy-stats

2019-07-04 Thread Chris Wilson
Now that we report whether the accurate per-engine utilisation statistics are available (albeit via the scheduler caps) put it to to use to selectively enable the high accuracy tests where we expect it to work. Signed-off-by: Chris Wilson Cc: Tvrtko Ursulin --- tests/perf_pmu.c | 4 ++-- 1 file

Re: [Intel-gfx] [PATCH v4 4/5] drm/i915: Transition port type checks to phy checks

2019-07-04 Thread kbuild test robot
Hi Matt, Thank you for the patch! Yet something to improve: [auto build test ERROR on drm-intel/for-linux-next] [also build test ERROR on next-20190704] [cannot apply to v5.2-rc7] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gtt: pde entry encoding is identical

2019-07-04 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-07-04 16:44:05) >> +#define set_pd_entry(pd, pde, to) ({ \ >> + __write_pd_entry((pd), (pde), px_base(to), gen8_pde_encode); \ >> + atomic_inc(&(pd)->used); \ > > inc befo

Re: [Intel-gfx] [PATCH 2/2] drm/i915/guc: Turn on GuC/HuC auto mode

2019-07-04 Thread Chris Wilson
Quoting Michal Wajdeczko (2019-07-03 14:02:51) > On Wed, 03 Jul 2019 13:40:06 +0200, Chris Wilson > wrote: > > > Quoting Michal Wajdeczko (2019-07-03 12:36:40) > >> GuC firmware is now mature, so let it run by default. > >> Note that today GuC is only used for HuC authentication. > > > > https:

Re: [Intel-gfx] [PATCH v4 1/5] drm/i915/gen11: Start distinguishing 'phy' from 'port'

2019-07-04 Thread Lucas De Marchi
On Thu, Jul 04, 2019 at 06:09:04PM +0300, Ville Syrjälä wrote: On Thu, Jul 04, 2019 at 07:54:26AM -0700, Lucas De Marchi wrote: On Thu, Jul 04, 2019 at 12:18:11PM +0300, Ville Syrjälä wrote: >On Wed, Jul 03, 2019 at 04:37:32PM -0700, Matt Roper wrote: >> Our past DDI-based Intel platforms have h

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gtt: pde entry encoding is identical

2019-07-04 Thread Chris Wilson
Quoting Mika Kuoppala (2019-07-04 16:44:05) > +#define set_pd_entry(pd, pde, to) ({ \ > + __write_pd_entry((pd), (pde), px_base(to), gen8_pde_encode); \ > + atomic_inc(&(pd)->used); \ inc before write so that you have a nic

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915/guc: Upgrade to GuC 33.0.0

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/guc: Upgrade to GuC 33.0.0 URL : https://patchwork.freedesktop.org/series/63123/ State : success == Summary == CI Bug Log - changes from CI_DRM_6404_full -> Patchwork_13506_full ===

[Intel-gfx] [PATCH 1/3] drm/i915/gtt: pde entry encoding is identical

2019-07-04 Thread Mika Kuoppala
For all page directory entries, the pde encoding is identical. Don't compilicate call sites with different versions of doing the same thing. We check the existence of physical page before writing the entry into it. This further generalizes the pd so that manipulation in callsites will be identical,

[Intel-gfx] [PATCH 3/3] drm/i915/gtt: Setup phys pages for 3lvl pdps

2019-07-04 Thread Mika Kuoppala
If we setup backing phys page for 3lvl pdps, even they are not used, we lose 5 pages per ppgtt. Trading this memory on bsw, we gain more common code paths for all gen8+ directory manipulation. And those paths are now void of checks for page directory type, making the hot paths faster. v2: don't s

[Intel-gfx] [PATCH 2/3] drm/i915/gtt: Tear down setup and cleanup macros for page dma

2019-07-04 Thread Mika Kuoppala
We don't use common codepaths to setup and cleanup page directories vs page tables. So their setup and cleanup macros are of no use. Signed-off-by: Mika Kuoppala Reviewed-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_gtt.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-)

Re: [Intel-gfx] [PATCH v4 1/5] drm/i915/gen11: Start distinguishing 'phy' from 'port'

2019-07-04 Thread Ville Syrjälä
On Thu, Jul 04, 2019 at 07:54:26AM -0700, Lucas De Marchi wrote: > On Thu, Jul 04, 2019 at 12:18:11PM +0300, Ville Syrjälä wrote: > >On Wed, Jul 03, 2019 at 04:37:32PM -0700, Matt Roper wrote: > >> Our past DDI-based Intel platforms have had a fixed DDI<->PHY mapping. > >> Because of this, both the

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [CI,1/3] drm/i915: Rework some interrupt handling functions to take intel_gt

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Rework some interrupt handling functions to take intel_gt URL : https://patchwork.freedesktop.org/series/63225/ State : success == Summary == CI Bug Log - changes from CI_DRM_6413 -> Patchwork_13530 =

Re: [Intel-gfx] [PATCH v4 1/5] drm/i915/gen11: Start distinguishing 'phy' from 'port'

2019-07-04 Thread Lucas De Marchi
On Thu, Jul 04, 2019 at 12:18:11PM +0300, Ville Syrjälä wrote: On Wed, Jul 03, 2019 at 04:37:32PM -0700, Matt Roper wrote: Our past DDI-based Intel platforms have had a fixed DDI<->PHY mapping. Because of this, both the bspec documentation and our i915 code has used the term "port" when talking

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Flush the workqueue before draining

2019-07-04 Thread Patchwork
== Series Details == Series: drm/i915: Flush the workqueue before draining URL : https://patchwork.freedesktop.org/series/63117/ State : failure == Summary == CI Bug Log - changes from CI_DRM_6404_full -> Patchwork_13505_full Summary --

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [CI,1/3] drm/i915: Rework some interrupt handling functions to take intel_gt

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Rework some interrupt handling functions to take intel_gt URL : https://patchwork.freedesktop.org/series/63225/ State : warning == Summary == $ dim checkpatch origin/drm-tip 570169d12f55 drm/i915: Rework some interrupt handl

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Defer obj->base.resv fini until RCU callback

2019-07-04 Thread Chris Wilson
Quoting Mika Kuoppala (2019-07-04 15:18:40) > Chris Wilson writes: > > > Quoting Mika Kuoppala (2019-07-04 14:53:09) > >> Chris Wilson writes: > >> > +static void shmem_release(struct drm_i915_gem_object *obj) > >> > +{ > >> > + fput(obj->base.filp); > >> > >> We lose the check for filp exi

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Defer obj->base.resv fini until RCU callback

2019-07-04 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-07-04 14:53:09) >> Chris Wilson writes: >> >> > Since reservation_object_fini() does an immediate free, rather than >> > kfree_rcu as normal, we have to delay the release until after the RCU >> > grace period has elapsed (i.e. from the rcu clea

Re: [Intel-gfx] [PATCH 3/4] drm/i915: move intel_ddi_set_fia_lane_count to intel_tc.c

2019-07-04 Thread Imre Deak
On Wed, Jul 03, 2019 at 05:06:48PM -0700, Lucas De Marchi wrote: > PORT_TX_DFLEXDPMLE1 is a FIA register so move it to intel_tc.c where we > access other FIA registers. In Tiger Lake we have multiple/modular FIAs > so it makes sense to start moving all access to their registers to a > common place.

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Defer obj->base.resv fini until RCU callback

2019-07-04 Thread Chris Wilson
Quoting Mika Kuoppala (2019-07-04 14:53:09) > Chris Wilson writes: > > > Since reservation_object_fini() does an immediate free, rather than > > kfree_rcu as normal, we have to delay the release until after the RCU > > grace period has elapsed (i.e. from the rcu cleanup callback) so that we > > c

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for Extend BT2020 support in iCSC and fixes (rev5)

2019-07-04 Thread Shankar, Uma
>-Original Message- >From: Patchwork [mailto:patchw...@emeril.freedesktop.org] >Sent: Wednesday, July 3, 2019 12:31 AM >To: Shankar, Uma >Cc: intel-gfx@lists.freedesktop.org >Subject: ✓ Fi.CI.IGT: success for Extend BT2020 support in iCSC and fixes >(rev5) > >== Series Details == > >Ser

Re: [Intel-gfx] [PATCH 2/4] drm/i915: fix include order in intel_tc.*

2019-07-04 Thread Imre Deak
On Wed, Jul 03, 2019 at 05:06:47PM -0700, Lucas De Marchi wrote: > Make intel_tc.h the first include so we guarantee it's self-contained. > Sort the rest. Same principle applies for includes in the header. > > Signed-off-by: Lucas De Marchi > --- > drivers/gpu/drm/i915/display/intel_tc.c | 5 +++

Re: [Intel-gfx] [PATCH 1/3] drm/i915/gem: Defer obj->base.resv fini until RCU callback

2019-07-04 Thread Mika Kuoppala
Chris Wilson writes: > Since reservation_object_fini() does an immediate free, rather than > kfree_rcu as normal, we have to delay the release until after the RCU > grace period has elapsed (i.e. from the rcu cleanup callback) so that we > can rely on the RCU protected access to the fences while

Re: [Intel-gfx] [PATCH 1/4] drm/i915: make new intel_tc.c use uncore accessors

2019-07-04 Thread Imre Deak
On Wed, Jul 03, 2019 at 04:59:57PM -0700, Lucas De Marchi wrote: > Let's make the just created intel_tc.c already follow the trend of using > i915 instead of dev_priv and calling the intel_uncore_*() functions. > > Signed-off-by: Lucas De Marchi Reviewed-by: Imre Deak > --- > drivers/gpu/drm/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/gtt: Handle double alloc failures

2019-07-04 Thread Patchwork
== Series Details == Series: drm/i915/gtt: Handle double alloc failures URL : https://patchwork.freedesktop.org/series/63223/ State : success == Summary == CI Bug Log - changes from CI_DRM_6410 -> Patchwork_13529 Summary --- **SUCCES

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Flush the workqueue before draining

2019-07-04 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-07-04 11:22:17) >> Chris Wilson writes: >> >> > Trying to drain a workqueue while we may still be adding to it from >> > background tasks is, according to kernel/workqueue.c, verboten. So, add >> > a flush_workqueue() at the start of our cleanu

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Handle double alloc failures

2019-07-04 Thread Chris Wilson
Quoting Matthew Auld (2019-07-04 13:27:07) > On Thu, 4 Jul 2019 at 11:43, Chris Wilson wrote: > > > > Matthew pointed out that we could face a double failure with concurrent > > allocations/frees, and so the assumption that the local var alloc was > > NULL was fraught with danger. Rather than comp

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Handle double alloc failures

2019-07-04 Thread Matthew Auld
On Thu, 4 Jul 2019 at 11:43, Chris Wilson wrote: > > Matthew pointed out that we could face a double failure with concurrent > allocations/frees, and so the assumption that the local var alloc was > NULL was fraught with danger. Rather than complicate the error paths too > much to add a second loc

[Intel-gfx] [CI 2/3] drm/i915: Remove some legacy mmio accessors from interrupt handling

2019-07-04 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Mostly in gen11 interrupt handling and a couple neighbouring functions which were easy since uncore local was already available. Signed-off-by: Paulo Zanoni Co-developed-by: Paulo Zanoni Signed-off-by: Tvrtko Ursulin Cc: Daniele Ceraolo Spurio Reviewed-by: Chris Wilson

[Intel-gfx] [CI 1/3] drm/i915: Rework some interrupt handling functions to take intel_gt

2019-07-04 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Some interrupt handling functions already have gt in their names suggesting them as obvious candidates to make them take struct intel_gt instead of i915. Signed-off-by: Paulo Zanoni Co-developed-by: Paulo Zanoni Signed-off-by: Tvrtko Ursulin Cc: Daniele Ceraolo Spurio Re

[Intel-gfx] [CI 3/3] drm/i915: Move dev_priv->pm_i{m, e}r into intel_gt

2019-07-04 Thread Tvrtko Ursulin
From: Tvrtko Ursulin PM interrupts belong to the GT so move the variables to be inside struct intel_gt. Signed-off-by: Paulo Zanoni Co-developed-by: Paulo Zanoni Signed-off-by: Tvrtko Ursulin Cc: Daniele Ceraolo Spurio Reviewed-by: Chris Wilson Acked-by: Daniele Ceraolo Spurio --- drivers

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v4] drm/i915: Check caller held wakerefs in assert_forcewakes_active (rev4)

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [v4] drm/i915: Check caller held wakerefs in assert_forcewakes_active (rev4) URL : https://patchwork.freedesktop.org/series/63151/ State : success == Summary == CI Bug Log - changes from CI_DRM_6410 -> Patchwork_13528 =

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915: Rework some interrupt handling functions to take intel_gt

2019-07-04 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Rework some interrupt handling functions to take intel_gt URL : https://patchwork.freedesktop.org/series/63116/ State : success == Summary == CI Bug Log - changes from CI_DRM_6404_full -> Patchwork_13504_full ===

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/hdcp: debugs logs for sink related failures

2019-07-04 Thread Patchwork
== Series Details == Series: drm/i915/hdcp: debugs logs for sink related failures URL : https://patchwork.freedesktop.org/series/63217/ State : success == Summary == CI Bug Log - changes from CI_DRM_6410 -> Patchwork_13527 Summary ---

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gtt: Defer the free for alloc error paths

2019-07-04 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2019-07-04 11:58:38) >> Chris Wilson writes: >> >> > Quoting Matthew Auld (2019-07-04 11:28:18) >> >> On 03/07/2019 18:19, Chris Wilson wrote: >> >> > If we hit an error while allocating the page tables, we have to unwind >> >> > the incomplete upda

Re: [Intel-gfx] [PATCH v7 10/11] drm/hdcp: update content protection property with uevent

2019-07-04 Thread Pekka Paalanen
On Tue, 7 May 2019 21:57:44 +0530 Ramalingam C wrote: > drm function is defined and exported to update a connector's > content protection property state and to generate a uevent along > with it. > > Need ACK for the uevent from userspace consumer. > > v2: > Update only when state is differen

Re: [Intel-gfx] [PATCH v7 09/11] drm: uevent for connector status change

2019-07-04 Thread Pekka Paalanen
On Tue, 7 May 2019 21:57:43 +0530 Ramalingam C wrote: > DRM API for generating uevent for a status changes of connector's > property. > > This uevent will have following details related to the status change: > > HOTPLUG=1, CONNECTOR= and PROPERTY= > > Need ACK from this uevent from userspac

Re: [Intel-gfx] [PATCH v7 07/11] drm: Add Content protection type property

2019-07-04 Thread Pekka Paalanen
On Tue, 7 May 2019 21:57:41 +0530 Ramalingam C wrote: > This patch adds a DRM ENUM property to the selected connectors. > This property is used for mentioning the protected content's type > from userspace to kernel HDCP authentication. > > Type of the stream is decided by the protected content

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gtt: Defer the free for alloc error paths

2019-07-04 Thread Chris Wilson
Quoting Mika Kuoppala (2019-07-04 11:58:38) > Chris Wilson writes: > > > Quoting Matthew Auld (2019-07-04 11:28:18) > >> On 03/07/2019 18:19, Chris Wilson wrote: > >> > If we hit an error while allocating the page tables, we have to unwind > >> > the incomplete updates, and wish to free the unuse

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gtt: Defer the free for alloc error paths

2019-07-04 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Matthew Auld (2019-07-04 11:28:18) >> On 03/07/2019 18:19, Chris Wilson wrote: >> > If we hit an error while allocating the page tables, we have to unwind >> > the incomplete updates, and wish to free the unused pd. However, we are >> > not allowed to be hoding the

Re: [Intel-gfx] [PATCH] drm: allow render capable master with DRM_AUTH ioctls

2019-07-04 Thread Michel Dänzer
On 2019-07-03 7:10 p.m., Emil Velikov wrote: > From: Emil Velikov > > There are cases (in mesa and applications) where one would open the > primary node without properly authenticating the client. > > Sometimes we don't check if the authentication succeeds, but there's > also cases we simply for

Re: [Intel-gfx] [PATCH v7 04/11] drm: revocation check at drm subsystem

2019-07-04 Thread Pekka Paalanen
On Tue, 7 May 2019 21:57:38 +0530 Ramalingam C wrote: > On every hdcp revocation check request SRM is read from fw file > /lib/firmware/display_hdcp_srm.bin > > SRM table is parsed and stored at drm_hdcp.c, with functions exported > for the services for revocation check from drivers (which > im

[Intel-gfx] [PATCH] drm/i915/gtt: Handle double alloc failures

2019-07-04 Thread Chris Wilson
Matthew pointed out that we could face a double failure with concurrent allocations/frees, and so the assumption that the local var alloc was NULL was fraught with danger. Rather than complicate the error paths too much to add a second local for a second free, just do the second free earlier on the

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gtt: Defer the free for alloc error paths

2019-07-04 Thread Chris Wilson
Quoting Matthew Auld (2019-07-04 11:28:18) > On 03/07/2019 18:19, Chris Wilson wrote: > > If we hit an error while allocating the page tables, we have to unwind > > the incomplete updates, and wish to free the unused pd. However, we are > > not allowed to be hoding the spinlock at that point, and s

Re: [Intel-gfx] [PATCH] drm/i915: Move the renderstate setup under gt/

2019-07-04 Thread Mika Kuoppala
Chris Wilson writes: > The render state is used to initialise the default RCS context, and only > used during early setup from within the gt code. As such, it makes a > good candidate for placing within gt/, even if it is not yet entirely > clean of our GEM heritage. > > Signed-off-by: Chris Wils

Re: [Intel-gfx] [PATCH 2/3] drm/i915/gtt: Defer the free for alloc error paths

2019-07-04 Thread Matthew Auld
On 03/07/2019 18:19, Chris Wilson wrote: If we hit an error while allocating the page tables, we have to unwind the incomplete updates, and wish to free the unused pd. However, we are not allowed to be hoding the spinlock at that point, and so must use the holding later free to defer it until

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Flush the workqueue before draining

2019-07-04 Thread Chris Wilson
Quoting Mika Kuoppala (2019-07-04 11:22:17) > Chris Wilson writes: > > > Trying to drain a workqueue while we may still be adding to it from > > background tasks is, according to kernel/workqueue.c, verboten. So, add > > a flush_workqueue() at the start of our cleanup procedure. > > I don't get

Re: [Intel-gfx] [PATCH 3/3] drm/i915: Flush the workqueue before draining

2019-07-04 Thread Mika Kuoppala
Chris Wilson writes: > Trying to drain a workqueue while we may still be adding to it from > background tasks is, according to kernel/workqueue.c, verboten. So, add > a flush_workqueue() at the start of our cleanup procedure. I don't get it. drain_workqueue does it's own flushing. -Mika > > Sig

  1   2   >