Re: [Intel-gfx] [PATCH v5 4/8] drm/cma-helper: Use the generic fbdev emulation

2018-08-20 Thread John Stultz
On Tue, Jul 3, 2018 at 9:03 AM, Noralf Trønnes wrote: > This switches the CMA helper drivers that use its fbdev emulation over > to the generic fbdev emulation. It's the first phase of using generic > fbdev. A later phase will use DRM client callbacks for the > lastclose/hotplug/remove callbacks.

[Intel-gfx] ✓ Fi.CI.BAT: success for Improve crc-core driver interface (rev13)

2018-08-20 Thread Patchwork
== Series Details == Series: Improve crc-core driver interface (rev13) URL : https://patchwork.freedesktop.org/series/45246/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4692 -> Patchwork_9982 = == Summary - SUCCESS == No regressions found. External URL: https://pat

[Intel-gfx] ✓ Fi.CI.IGT: success for Improve crc-core driver interface (rev13)

2018-08-20 Thread Patchwork
== Series Details == Series: Improve crc-core driver interface (rev13) URL : https://patchwork.freedesktop.org/series/45246/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4692_full -> Patchwork_9980_full = == Summary - SUCCESS == No regressions found. == Known issue

[Intel-gfx] ✗ Fi.CI.BAT: failure for Improve crc-core driver interface (rev13)

2018-08-20 Thread Patchwork
== Series Details == Series: Improve crc-core driver interface (rev13) URL : https://patchwork.freedesktop.org/series/45246/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4692 -> Patchwork_9981 = == Summary - FAILURE == Serious unknown changes coming with Patchwork_9981

[Intel-gfx] ✓ Fi.CI.BAT: success for Improve crc-core driver interface (rev13)

2018-08-20 Thread Patchwork
== Series Details == Series: Improve crc-core driver interface (rev13) URL : https://patchwork.freedesktop.org/series/45246/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4692 -> Patchwork_9980 = == Summary - SUCCESS == No regressions found. External URL: https://pat

[Intel-gfx] [PATCH V3 1/3] drm/vkms/crc: Implement verify_crc_source callback

2018-08-20 Thread Mahesh Kumar
This patch implements "verify_crc_source" callback function for Virtual KMS drm driver. Changes Since V1: - update values_cnt in verify_crc_source Changes Since V2: - don't return early from set_crc_source to keep behavior same (Haneen) Cc: Haneen Mohammed Signed-off-by: Mahesh Kumar --- drive

Re: [Intel-gfx] [PATCH V2 1/3] drm/vkms/crc: Implement verify_crc_source callback

2018-08-20 Thread Kumar, Mahesh
Hi Haneen, On 8/21/2018 4:09 AM, Haneen Mohammed wrote: On Tue, Aug 14, 2018 at 08:31:03AM +0530, Mahesh Kumar wrote: This patch implements "verify_crc_source" callback function for Virtual KMS drm driver. Changes Since V1: - update values_cnt in verify_crc_source Cc: Haneen Mohammed Signed

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/psr: Add PSR mode/revision to debugfs (rev3)

2018-08-20 Thread Patchwork
== Series Details == Series: drm/i915/psr: Add PSR mode/revision to debugfs (rev3) URL : https://patchwork.freedesktop.org/series/47902/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4691_full -> Patchwork_9979_full = == Summary - WARNING == Minor unknown changes coming

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/5] drm/i915: kill intel_display_power_well_is_enabled()

2018-08-20 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: kill intel_display_power_well_is_enabled() URL : https://patchwork.freedesktop.org/series/48466/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4691_full -> Patchwork_9978_full = == Summary - SUCCESS == No

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Remove wait_for_idle() for PSR2

2018-08-20 Thread Rodrigo Vivi
On Wed, Aug 15, 2018 at 06:35:15PM -0700, Dhinakaran Pandiyan wrote: > On Mon, 2018-08-13 at 18:10 +, Pandiyan, Dhinakaran wrote: > > On Mon, 2018-08-13 at 09:57 -0700, Rodrigo Vivi wrote: > > > On Thu, Aug 09, 2018 at 05:41:35PM -0700, Dhinakaran Pandiyan > > > wrote: > > > > CI runs show PSR2

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Add PSR mode/revision to debugfs (rev3)

2018-08-20 Thread Patchwork
== Series Details == Series: drm/i915/psr: Add PSR mode/revision to debugfs (rev3) URL : https://patchwork.freedesktop.org/series/47902/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4691 -> Patchwork_9979 = == Summary - SUCCESS == No regressions found. External URL:

Re: [Intel-gfx] [PATCH] drm/i915: Show debugfs dpcd read failure directly

2018-08-20 Thread Rodrigo Vivi
On Mon, Aug 20, 2018 at 12:10:08PM -0700, Pandiyan, Dhinakaran wrote: > > > On Mon, 2018-08-20 at 10:15 +0300, Jani Nikula wrote: > > On Fri, 20 Jul 2018, Rodrigo Vivi wrote: > > > Instead of using a backchannel if some dpcd read failed we > > > can show that directly on debugfs output. > > > >

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/5] drm/i915: kill intel_display_power_well_is_enabled()

2018-08-20 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: kill intel_display_power_well_is_enabled() URL : https://patchwork.freedesktop.org/series/48466/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4691 -> Patchwork_9978 = == Summary - SUCCESS == No regressio

[Intel-gfx] [PATCH i-g-t] Skip VBlank tests in modules without VBlank

2018-08-20 Thread Rodrigo Siqueira
The kms_flip test does not support drivers without VBlank which exclude some virtual drivers. This patch adds a function that checks if a module has a VBlank or not; if a module has VBlank than kms_flip will execute all the VBlank tests, otherwise, VBlank tests will be skipped. Signed-off-by: Rodr

[Intel-gfx] [PATCH v3] drm/i915/psr: Add PSR mode/revision to debugfs

2018-08-20 Thread Azhar Shaikh
Log the PSR mode/revision (PSR1 or PSR2) in the debugfs file i915_edp_psr_status. Signed-off-by: Azhar Shaikh --- Changes in v3: - rebased Changes in v2: - Fix checkpatch warning. - Add Reviewed-by: from v1 drivers/gpu/drm/i915/i915_debugfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deleti

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/5] drm/i915: kill intel_display_power_well_is_enabled()

2018-08-20 Thread Patchwork
== Series Details == Series: series starting with [1/5] drm/i915: kill intel_display_power_well_is_enabled() URL : https://patchwork.freedesktop.org/series/48466/ State : warning == Summary == $ dim checkpatch origin/drm-tip 20b826691fa5 drm/i915: kill intel_display_power_well_is_enabled() c7

[Intel-gfx] [PATCH 4/5] drm/i915: move lookup_power_well() up

2018-08-20 Thread Paulo Zanoni
There's no need for that forward declaration. Cc: Imre Deak Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_runtime_pm.c | 46 +++-- 1 file changed, 21 insertions(+), 25 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_runtime_pm.c b/drivers/gpu/drm/

[Intel-gfx] [PATCH 5/5] drm/i915: use the SW-based pw->hw_enabled check instead of reading registers

2018-08-20 Thread Paulo Zanoni
I can't find a reason why we would want to call is_enabled(), which does a register read, instead of just relying on our tracking with hw_enabled. Let's try to trust our hardware sync. Cc: Imre Deak Requested-by: José Roberto de Souza Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH 2/5] drm/i915: WARN() if we can't lookup_power_well()

2018-08-20 Thread Paulo Zanoni
None of the current lookup_power_well() callers are actually checking for NULL return values, they all just use the pointer right away. The first idea was to replace these theoretical segfaults with a BUG() since this would at least make our code a little more explicit to the reader. It was sugges

[Intel-gfx] [PATCH 3/5] drm/i915: use for_each_power_well in lookup_power_well()

2018-08-20 Thread Paulo Zanoni
Use the nice helper function to make the implementation simpler. v2: Rebase. Cc: Imre Deak Reviewed-by: José Roberto de Souza (v1) Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_runtime_pm.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/drivers/gp

[Intel-gfx] [PATCH 1/5] drm/i915: kill intel_display_power_well_is_enabled()

2018-08-20 Thread Paulo Zanoni
Use the same coding pattern as we use in the other functions of the same file: just call lookup_power_well() directly in the only caller. Cc: Imre Deak Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/intel_runtime_pm.c | 20 +++- 1 file changed, 3 insertions(+), 17 deletion

Re: [Intel-gfx] [PATCH 2/2] drm/i915/psr: Mask PSR irq bits when re-enabling interrupts.

2018-08-20 Thread Dhinakaran Pandiyan
On Wed, 2018-08-15 at 18:05 -0700, Dhinakaran Pandiyan wrote: > gen8_de_irq_postinstall() wasn't masking the IRQ bit before passing > the > debug flag to psr_irq_control(). This check was missed when new debug > bits > were defined in 'commit c44301fce614 ("drm/i915: Allow control of > PSR at >

Re: [Intel-gfx] [PATCHv3] lib/ratelimit: Lockless ratelimiting

2018-08-20 Thread Dmitry Safonov
Hi Petr, thanks for review, On Wed, 2018-08-15 at 17:10 +0200, Petr Mladek wrote: > On Tue 2018-07-03 23:56:28, Dmitry Safonov wrote: > > Currently ratelimit_state is protected with spin_lock. If the .lock > > is > > taken at the moment of ___ratelimit() call, the message is > > suppressed to > >

Re: [Intel-gfx] [PATCH 1/4] drm/i915: kill intel_display_power_well_is_enabled()

2018-08-20 Thread Paulo Zanoni
Em Sex, 2018-08-17 às 16:41 -0700, Paulo Zanoni escreveu: > Em Qua, 2018-08-15 às 23:27 +0300, Imre Deak escreveu: > > On Wed, Aug 08, 2018 at 03:16:11PM -0700, Paulo Zanoni wrote: > > > Use the same coding pattern as we use in the other functions of > > > the > > > same file: just call lookup_powe

Re: [Intel-gfx] [PATCH 1/5] drm/dp/fec: DRM helper for Forward Error Correction

2018-08-20 Thread Manasi Navare
Hi Jani, Thanks for your feedback. Please see my comments below: On Fri, Aug 17, 2018 at 12:51:03PM +0300, Jani Nikula wrote: > On Tue, 07 Aug 2018, Anusha Srivatsa wrote: > > From: "Srivatsa, Anusha" > > > > DP 1.4 has Forward Error Correction Support(FEC). > > Add helper function to check if

Re: [Intel-gfx] [PATCH] drm/i915: Show debugfs dpcd read failure directly

2018-08-20 Thread Pandiyan, Dhinakaran
On Mon, 2018-08-20 at 10:15 +0300, Jani Nikula wrote: > On Fri, 20 Jul 2018, Rodrigo Vivi wrote: > > Instead of using a backchannel if some dpcd read failed we > > can show that directly on debugfs output. > > > > We are not returning an error because we might still want > > to know if sub-sequ

Re: [Intel-gfx] [PATCH] drm/i915/audio: Hook up component bindings even if displays are disabled

2018-08-20 Thread Chris Wilson
Quoting Imre Deak (2018-08-20 14:23:13) > On Fri, Aug 17, 2018 at 11:02:41AM +0100, Chris Wilson wrote: > > If the display has been disabled by modparam, we still want to connect > > together the HW bits and bobs with the associated drivers so that we can > > continue to manage their runtime power

Re: [Intel-gfx] [PATCH v2 i-g-t 0/2] Fix some GCC warnings

2018-08-20 Thread Rodrigo Siqueira
Hi, I would like to know if there is any improvement that I can do for this patchset. Thanks On 07/29, Rodrigo Siqueira wrote: > During the compilation, some GCC (8.1) warnings are shown. This patchset > address some of the warnings problems. > > Changes since v2: > - Reduce the total amount o

Re: [Intel-gfx] [PATCH i-g-t 0/2] Add support to force specific module load

2018-08-20 Thread Rodrigo Siqueira
Hi, I would like to know if there is any improvement that I can do for this patchset. Thanks On 07/07, Rodrigo Siqueira wrote: > This patchset adds support for forcing a specific module to be loaded > via command line. This feature can bring benefits for developers that > need to create a new mo

Re: [Intel-gfx] [PATCH] drm/i915/audio: Hook up component bindings even if displays are disabled

2018-08-20 Thread Imre Deak
On Fri, Aug 17, 2018 at 11:02:41AM +0100, Chris Wilson wrote: > If the display has been disabled by modparam, we still want to connect > together the HW bits and bobs with the associated drivers so that we can > continue to manage their runtime power gating. > > Fixes: 108109444ff6 ("drm/i915: Che

Re: [Intel-gfx] [PATCH v2] drm/i915: Increase LSPCON timeout

2018-08-20 Thread Jani Nikula
On Mon, 20 Aug 2018, "Sharma, Shashank" wrote: > On 8/18/2018 1:37 AM, Fredrik Schön wrote: > >> 100 ms is not enough time for the LSPCON adapter on Intel NUC devices to >> settle. This causes dropped display modes at boot or screen reconfiguration. >> Empirical testing can reproduce the error up

Re: [Intel-gfx] [PATCH v2] drm/i915: Increase LSPCON timeout

2018-08-20 Thread Sharma, Shashank
On 8/18/2018 1:37 AM, Fredrik Schön wrote: 100 ms is not enough time for the LSPCON adapter on Intel NUC devices to settle. This causes dropped display modes at boot or screen reconfiguration. Empirical testing can reproduce the error up to a timeout of 190 ms. Basic boot and stress testing at 2

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Verify power domains after enabling them (rev3)

2018-08-20 Thread Imre Deak
On Fri, Aug 17, 2018 at 03:24:40PM +, Patchwork wrote: > == Series Details == > > Series: drm/i915: Verify power domains after enabling them (rev3) > URL : https://patchwork.freedesktop.org/series/48394/ > State : success Pushed to -dinq with i915_welcome_messages() updated, thanks for the

Re: [Intel-gfx] [PATCH] drm/i915: Show debugfs dpcd read failure directly

2018-08-20 Thread Jani Nikula
On Fri, 20 Jul 2018, Rodrigo Vivi wrote: > Instead of using a backchannel if some dpcd read failed we > can show that directly on debugfs output. > > We are not returning an error because we might still want > to know if sub-sequent reads works, but we shouldn't > need to check 2 places to see why

Re: [Intel-gfx] [PATCH] drm/i915/dp: Link train Fallback on eDP only if fallback link BW can fit panel's native mode

2018-08-20 Thread Wilson
I believe this is the patch discussed here: https://bugs.freedesktop.org/show_bug.cgi?id=105338 In which case Tested-By: Alexander Wilson On 8/17/18 4:36 PM, Manasi Navare wrote: > Thanks Lyude. > > So based on the imitial comments from Jani N, the recommendation was to > disconnect > down