[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Filter out both physical address swizzles

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Filter out both physical address swizzles URL : https://patchwork.freedesktop.org/series/46214/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4456_full -> Patchwork_9597_full = == Summary - WARNING == Minor unknown changes

Re: [Intel-gfx] [PATCH v4] drm/i915/gvt: declare gvt as i915's soft dependency

2018-07-09 Thread Zhenyu Wang
On 2018.07.09 18:24:10 +0800, intel-gvt-dev-boun...@lists.freedesktop.org wrote: > From: Hang Yuan > > This helps initramfs builder and other tools to know the full dependencies > of i915 and have gvt module loaded with i915. > > v2: add condition and change to pre-dependency (Chris) > v3: move

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with kernel.h: Add for_each_if() (rev3)

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with kernel.h: Add for_each_if() (rev3) URL : https://patchwork.freedesktop.org/series/46158/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4455_full -> Patchwork_9596_full = == Summary - WARNING == Minor unknown changes comin

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: remove confusing GPIO vs PCH_GPIO URL : https://patchwork.freedesktop.org/series/46200/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4455_full -> Patchwork_9595_full = == Summary - WARNING == Minor unknow

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev4)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev4) URL : https://patchwork.freedesktop.org/series/46104/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4458 -> Patchwork_9600 = == Summary - SUCCESS == No regressions f

[Intel-gfx] [PATCH v4] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Tarun Vyas
In commit "drm/i915: Wait for PSR exit before checking for vblank evasion", the idea was to limit the PSR IDLE checks when PSR is actually supported. While CAN_PSR does do that check, it doesn't applies on a per-crtc basis. crtc_state->has_psr is a more granular check that only applies to pipe(s) t

[Intel-gfx] ✓ Fi.CI.BAT: success for Kill resource streamer

2018-07-09 Thread Patchwork
== Series Details == Series: Kill resource streamer URL : https://patchwork.freedesktop.org/series/46224/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4458 -> Patchwork_9599 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedesktop.

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for Kill resource streamer

2018-07-09 Thread Patchwork
== Series Details == Series: Kill resource streamer URL : https://patchwork.freedesktop.org/series/46224/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/icl: move has_resource_streamer to GEN11_FEATURES Okay! Commit: drm/i915: kill resource streamer -drivers/gpu/dr

[Intel-gfx] [PATCH 0/2] Kill resource streamer

2018-07-09 Thread Lucas De Marchi
First patch is makes sense for ICL since it doesn't have resource streamer. It has been a feature that was never properly tested/used so also kill it on second patch - this is a tentative/rfc: see commit message. Lucas De Marchi (2): drm/i915/icl: move has_resource_streamer to GEN11_FEATURES d

[Intel-gfx] [PATCH 2/2] drm/i915: kill resource streamer

2018-07-09 Thread Lucas De Marchi
After disabling resource streamer on ICL (due to it actually not existing there), I got feedback that there have been some experimental patches for mesa to use it, but nothing ever landed nor shipped. This is a tentative to remove it from kernel keeping the uapi defines around for compatibility. W

[Intel-gfx] [PATCH 1/2] drm/i915/icl: move has_resource_streamer to GEN11_FEATURES

2018-07-09 Thread Lucas De Marchi
Resource streamer has been removed on GEN11 so move it to the FEATURES macro. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/i915_gem_execbuffer.c | 2 +- drivers/gpu/drm/i915/i915_pci.c| 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 2/2] drm/i915: use the ICL stolen memory

2018-07-09 Thread Paulo Zanoni
Em Sex, 2018-07-06 às 19:09 -0700, Lucas De Marchi escreveu: > On Fri, May 4, 2018 at 1:33 PM Paulo Zanoni > wrote: > > > > Now that our stolen memory is already reserved by the x86 subsystem > > (since commit "x86/gpu: reserve ICL's graphics stolen memory"), > > make > > use of it. > > > > Cc:

Re: [Intel-gfx] [PATCH] kernel.h: Add for_each_if()

2018-07-09 Thread Andrew Morton
On Mon, 9 Jul 2018 18:25:09 +0200 Daniel Vetter wrote: > To avoid compilers complainig about ambigious else blocks when putting > an if condition into a for_each macro one needs to invert the > condition and add a dummy else. We have a nice little convenience > macro for that in drm headers, let

Re: [Intel-gfx] [PATCH v3] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Dhinakaran Pandiyan
On Mon, 2018-07-09 at 14:28 -0700, Tarun Vyas wrote: > In commit "drm/i915: Wait for PSR exit before checking for vblank > evasion", the idea was to limit the PSR IDLE checks when PSR is > actually supported. While CAN_PSR does do that check, it doesn't > applies on a per-crtc basis. crtc_state->ha

Re: [Intel-gfx] [PATCH 10/12] pci: use for_each_if

2018-07-09 Thread Bjorn Helgaas
On Mon, Jul 09, 2018 at 10:36:48AM +0200, Daniel Vetter wrote: > Avoids the inverted condition compared to the open-coded version. > > Signed-off-by: Daniel Vetter > Cc: Bjorn Helgaas > Cc: linux-...@vger.kernel.org Acked-by: Bjorn Helgaas I assume you'll merge this with the rest of the serie

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev3)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev3) URL : https://patchwork.freedesktop.org/series/46104/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4456 -> Patchwork_9598 = == Summary - SUCCESS == No regressions f

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev3)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update (rev3) URL : https://patchwork.freedesktop.org/series/46104/ State : warning == Summary == $ dim checkpatch origin/drm-tip fc0aabf8423b drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pi

Re: [Intel-gfx] [PATCH] cpufreq: use for_each_if

2018-07-09 Thread Rafael J. Wysocki
On Mon, Jul 9, 2018 at 6:11 PM, Daniel Vetter wrote: > Avoids the inverted condition compared to the open coded version. > > Signed-off-by: Daniel Vetter > Cc: "Rafael J. Wysocki" > Cc: Viresh Kumar > Cc: linux...@vger.kernel.org > Cc: Eric Engestrom > -- > v2: Fix the logic fumble in the 2nd

[Intel-gfx] [PATCH v3] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Tarun Vyas
In commit "drm/i915: Wait for PSR exit before checking for vblank evasion", the idea was to limit the PSR IDLE checks when PSR is actually supported. While CAN_PSR does do that check, it doesn't applies on a per-crtc basis. crtc_state->has_psr is a more granular check that only applies to pipe(s) t

Re: [Intel-gfx] [PATCH 5/8] drm/i915: s/int i/enum hpd_pin pin/

2018-07-09 Thread Rodrigo Vivi
On Thu, Jul 05, 2018 at 07:43:54PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Use the enum hpd_pin type when talking about HPD pins, and rename the > variable from a very nondescript 'i' to 'pin', a name we already > use in other parts of the code. > > Signed-off-by: Ville Syrjälä R

Re: [Intel-gfx] [PATCH 4/8] drm/i915: Nuke dev_priv->irq_port[]

2018-07-09 Thread Rodrigo Vivi
On Thu, Jul 05, 2018 at 07:43:53PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > Instead of looping over ports and hpd_pins, let's loop over > the encoders when doing hotplug processing. And instead of > depending on dev_priv->irq_port[] to tell us whether the > encoder has the ->hpd_puls

Re: [Intel-gfx] [PATCH] drm/i915: Remove function details from device error messages

2018-07-09 Thread Rodrigo Vivi
On Mon, Jul 09, 2018 at 09:14:05PM +0100, Chris Wilson wrote: > Quoting Rodrigo Vivi (2018-07-09 18:51:02) > > On Mon, Jul 09, 2018 at 02:48:58PM +0100, Chris Wilson wrote: > > > Error messages are intended to be addressed to the user; be clear, > > > succinct, instructive and unambiguous. Adding t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Filter out both physical address swizzles

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Filter out both physical address swizzles URL : https://patchwork.freedesktop.org/series/46214/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4456 -> Patchwork_9597 = == Summary - SUCCESS == No regressions found. Extern

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove function details from device error messages

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Remove function details from device error messages URL : https://patchwork.freedesktop.org/series/46187/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4454_full -> Patchwork_9594_full = == Summary - FAILURE == Serious unknown change

Re: [Intel-gfx] [PATCH v5 20/40] drm/i915: Check HDCP 1.4 and 2.2 link on CP_IRQ

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:10:09PM +0530, Ramalingam C wrote: > On DP HDCP1.4 and 2.2, when CP_IRQ is received, start the link > integrity check for the HDCP version that is enabled. > > v2: > Rebased. Function name is changed. > v3: > No Changes. > v4: > No Changes. > v5: > No Changes. >

Re: [Intel-gfx] [PATCH v5 19/40] drm/i915: hdcp_check_link only on CP_IRQ

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:10:08PM +0530, Ramalingam C wrote: > HDCP check link is invoked only on CP_IRQ detection, instead of all > short pulses. > > v3: > No Changes. > v4: > Added sean in cc and collected the reviewed-by received. > v5: > No Change. > > Signed-off-by: Ramalingam C Rev

Re: [Intel-gfx] [PATCH v5 13/40] drm/i915: Implement HDCP2.2 Enable and Disable

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:10:02PM +0530, Ramalingam C wrote: > Implements a sequence of enabling and disabling the HDCP2.2 > (auth and encryption). This is really hard to review, since all I see are stubs. I'd much rather have each patch do something useful, instead of just call stubs. That said,

Re: [Intel-gfx] [PATCH v5 12/40] drm/i915: Enable HDCP1.4 incase of HDCP2.2 failure

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:10:01PM +0530, Ramalingam C wrote: > When HDCP2.2 enabling fails and HDCP1.4 is supported, HDCP1.4 is > enabled. > Just squash this into patch 11, no need for a separate patch. > v2: > Rebased. > v3: > No Changes. > v4: > Reviewed-by is collected. > v5: > No Ch

Re: [Intel-gfx] [PATCH v5 11/40] drm/i915: Enable superior HDCP ver that is capable

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:10:00PM +0530, Ramalingam C wrote: > Considering that HDCP2.2 is more secure than HDCP1.4, When a setup > supports HDCP2.2 and HDCP1.4, HDCP2.2 will be enabled. > > v2: > Included few optimization suggestions [Chris Wilson] > Commit message is updated as per the reba

Re: [Intel-gfx] [PATCH v5 10/40] drm/i915: Pullout the bksv read and validation

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:59PM +0530, Ramalingam C wrote: > For reusability purpose, this patch implements the hdcp1.4 bksv's > read and validation as a functions. > > For detecting the HDMI panel's HDCP capability this fucntions will be > used. > > v2: > Rebased. > v3: > No Changes. > v4

Re: [Intel-gfx] [PATCH v5 09/40] drm/i915: Schedule hdcp_check_link in _intel_hdcp_enable

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:58PM +0530, Ramalingam C wrote: > As a preparation for making the intel_hdcp_enable as common function > for both HDCP1.4 and HDCP2.2, HDCP1.4 check_link scheduling is moved > into _intel_hdcp_enable() function. > > v3: > No Changes. > v4: > Style fix. > v5: > N

Re: [Intel-gfx] [PATCH v5 07/40] drm/i915: Define Intel HDCP2.2 registers

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:56PM +0530, Ramalingam C wrote: > Intel HDCP2.2 registers are defined with addr offsets and bit details. > > v2: > Replaced the arith calc with _PICK [Sean Paul] > v3: > No changes. > v4: > %s/HDCP2_CTR_DDI/HDCP2_CTL_DDI [Uma] > v5: > Added parentheses for the

Re: [Intel-gfx] [PATCH v5 06/40] drm/i915: Define HDCP2.2 related variables

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:55PM +0530, Ramalingam C wrote: > For upcoming implementation of HDCP2.2 in I915, important variable > required for HDCP2.2 are defined. Please just introduce them when you use them. I can't provide useful review on this patch unless I can see how the variables are us

Re: [Intel-gfx] [PATCH v5 05/40] drm/i915: wrapping all hdcp var into intel_hdcp

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:54PM +0530, Ramalingam C wrote: > Considering significant number of HDCP specific variables, it will > be clean to have separate struct for HDCP. > > New structure called intel_hdcp is added within intel_connector. > > v2: > struct hdcp statically allocated. [Sean

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Tarun Vyas
On Mon, Jul 09, 2018 at 01:31:52PM -0700, Dhinakaran Pandiyan wrote: > On Mon, 2018-07-09 at 12:52 -0700, Tarun Vyas wrote: > > On Mon, Jul 09, 2018 at 11:58:52AM -0700, Dhinakaran Pandiyan wrote: > > > > > > On Mon, 2018-07-09 at 11:16 -0700, Tarun Vyas wrote: > > > > > > > > On Mon, Jul 09, 201

Re: [Intel-gfx] [PATCH v5 02/40] drm: HDMI and DP specific HDCP2.2 defines

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:51PM +0530, Ramalingam C wrote: > This patch adds HDCP register definitions for HDMI and DP HDCP > adaptations. > > HDMI specific HDCP2.2 register definitions are added into drm_hdcp.h, > where as HDCP2.2 register offsets in DPCD offsets are defined at > drm_dp_helper

Re: [Intel-gfx] [PATCH v5 01/40] drm: hdcp2.2 authentication msg definitions

2018-07-09 Thread Sean Paul
On Wed, Jun 27, 2018 at 02:09:50PM +0530, Ramalingam C wrote: > This patch defines the hdcp2.2 protocol messages for authentication. > > v2: > bit_fields are removed. Instead bitmasking used. [Tomas and Jani] > prefix HDCP_2_2_ is added to the macros. [Tomas] > v3: > No Changes. > v4: > St

Re: [Intel-gfx] [PATCH] drm/i915: Remove function details from device error messages

2018-07-09 Thread Chris Wilson
Quoting Rodrigo Vivi (2018-07-09 18:51:02) > On Mon, Jul 09, 2018 at 02:48:58PM +0100, Chris Wilson wrote: > > Error messages are intended to be addressed to the user; be clear, > > succinct, instructive and unambiguous. Adding the function name to > > that message does not add any information the

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Dhinakaran Pandiyan
On Mon, 2018-07-09 at 12:52 -0700, Tarun Vyas wrote: > On Mon, Jul 09, 2018 at 11:58:52AM -0700, Dhinakaran Pandiyan wrote: > > > > On Mon, 2018-07-09 at 11:16 -0700, Tarun Vyas wrote: > > > > > > On Mon, Jul 09, 2018 at 11:30:00AM -0700, Dhinakaran Pandiyan > > > wrote: > > > > > > > > > > > >

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Add Exec param to control data port coherency. (rev5)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Add Exec param to control data port coherency. (rev5) URL : https://patchwork.freedesktop.org/series/40181/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4454_full -> Patchwork_9592_full = == Summary - FAILURE == Serious unknown cha

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Tarun Vyas
On Mon, Jul 09, 2018 at 11:58:52AM -0700, Dhinakaran Pandiyan wrote: > On Mon, 2018-07-09 at 11:16 -0700, Tarun Vyas wrote: > > On Mon, Jul 09, 2018 at 11:30:00AM -0700, Dhinakaran Pandiyan wrote: > > > > > > On Sun, 2018-07-08 at 18:46 -0700, Tarun Vyas wrote: > > > > > > > > In commit "drm/i915

[Intel-gfx] [PATCH] drm/i915/selftests: Filter out both physical address swizzles

2018-07-09 Thread Chris Wilson
In our swizzling selftests, we cannot predict the physical address of the target page (at least not simply!) and so skip bit17 swizzles. However, there are two bit17 swizzle modes and we only skipped on, with the second being observed on the lab gdg causing the test to fail, as soon as we hit a pag

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Rodrigo Vivi
On Mon, Jul 09, 2018 at 12:58:28PM -0700, Dhinakaran Pandiyan wrote: > On Mon, 2018-07-09 at 12:24 -0700, Rodrigo Vivi wrote: > > On Mon, Jul 09, 2018 at 11:30:00AM -0700, Dhinakaran Pandiyan wrote: > > > > > > On Sun, 2018-07-08 at 18:46 -0700, Tarun Vyas wrote: > > > > > > > > In commit "drm/i9

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Dhinakaran Pandiyan
On Mon, 2018-07-09 at 12:24 -0700, Rodrigo Vivi wrote: > On Mon, Jul 09, 2018 at 11:30:00AM -0700, Dhinakaran Pandiyan wrote: > > > > On Sun, 2018-07-08 at 18:46 -0700, Tarun Vyas wrote: > > > > > > In commit "drm/i915: Wait for PSR exit before checking for vblank > > > evasion", the idea was to

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Rodrigo Vivi
On Mon, Jul 09, 2018 at 11:30:00AM -0700, Dhinakaran Pandiyan wrote: > On Sun, 2018-07-08 at 18:46 -0700, Tarun Vyas wrote: > > In commit "drm/i915: Wait for PSR exit before checking for vblank > > evasion", the idea was to limit the PSR IDLE checks when PSR is > > actually supported. While CAN_PSR

Re: [Intel-gfx] [PATCH 2/2] drm/i915: use the ICL stolen memory

2018-07-09 Thread Rodrigo Vivi
On Fri, Jul 06, 2018 at 07:09:15PM -0700, Lucas De Marchi wrote: > On Fri, May 4, 2018 at 1:33 PM Paulo Zanoni wrote: > > > > Now that our stolen memory is already reserved by the x86 subsystem > > (since commit "x86/gpu: reserve ICL's graphics stolen memory"), make > > use of it. > > > > Cc: Joon

[Intel-gfx] ✗ Fi.CI.IGT: failure for series starting with [01/11] drm/i915/selftests: Prevent background reaping of active objects

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with [01/11] drm/i915/selftests: Prevent background reaping of active objects URL : https://patchwork.freedesktop.org/series/46176/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4454_full -> Patchwork_9591_full = == Summary - FA

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Dhinakaran Pandiyan
On Mon, 2018-07-09 at 11:16 -0700, Tarun Vyas wrote: > On Mon, Jul 09, 2018 at 11:30:00AM -0700, Dhinakaran Pandiyan wrote: > > > > On Sun, 2018-07-08 at 18:46 -0700, Tarun Vyas wrote: > > > > > > In commit "drm/i915: Wait for PSR exit before checking for vblank > > > evasion", the idea was to li

Re: [Intel-gfx] [PATCH] kernel.h: Add for_each_if()

2018-07-09 Thread Andy Shevchenko
On Mon, 2018-07-09 at 18:25 +0200, Daniel Vetter wrote: > v2: Explain a bit better what this is good for, after the discussion > with Peter Z. Since I have not been Cc'ed to your discussion there is another weirdness which this macro prohibits, i.e. for_each_blah() { } else { ...blahblah... }

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Tarun Vyas
On Mon, Jul 09, 2018 at 11:30:00AM -0700, Dhinakaran Pandiyan wrote: > On Sun, 2018-07-08 at 18:46 -0700, Tarun Vyas wrote: > > In commit "drm/i915: Wait for PSR exit before checking for vblank > > evasion", the idea was to limit the PSR IDLE checks when PSR is > > actually supported. While CAN_PSR

Re: [Intel-gfx] [PATCH 4/4] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk

2018-07-09 Thread Ville Syrjälä
On Sat, Jul 07, 2018 at 08:32:16AM +0200, Hans de Goede wrote: > Hi, > > On 07/06/2018 04:16 PM, Ville Syrjälä wrote: > > On Tue, Jun 19, 2018 at 10:18:27PM +0200, Hans de Goede wrote: > >> On BYT and CHT the GOP sometimes initializes the pclk at a (slightly) > >> different frequency then the pclk

Re: [Intel-gfx] [PATCH v2] drm/i915: Use crtc_state->has_psr instead of CAN_PSR for pipe update

2018-07-09 Thread Dhinakaran Pandiyan
On Sun, 2018-07-08 at 18:46 -0700, Tarun Vyas wrote: > In commit "drm/i915: Wait for PSR exit before checking for vblank > evasion", the idea was to limit the PSR IDLE checks when PSR is > actually supported. While CAN_PSR does do that check, it doesn't > applies on a per-crtc basis. crtc_state->ha

Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-09 Thread Daniel Vetter
On Mon, Jul 9, 2018 at 6:12 PM, Mark Rutland wrote: > On Mon, Jul 09, 2018 at 06:03:42PM +0200, Peter Zijlstra wrote: >> On Mon, Jul 09, 2018 at 05:52:04PM +0200, Daniel Vetter wrote: >> > for_each_something(foo) >> > if (foo->bla) >> > call_bla(foo); >> > else >> >

Re: [Intel-gfx] [PATCH] drm/i915: Remove function details from device error messages

2018-07-09 Thread Rodrigo Vivi
On Mon, Jul 09, 2018 at 02:48:58PM +0100, Chris Wilson wrote: > Error messages are intended to be addressed to the user; be clear, > succinct, instructive and unambiguous. Adding the function name to > that message does not add any information the user requires and in > the process makes the messag

Re: [Intel-gfx] [PATCH 4/4] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk

2018-07-09 Thread Hans de Goede
Hi, On 07/09/2018 07:37 PM, Rodrigo Vivi wrote: On Sat, Jul 07, 2018 at 08:32:16AM +0200, Hans de Goede wrote: Hi, On 07/06/2018 04:16 PM, Ville Syrjälä wrote: On Tue, Jun 19, 2018 at 10:18:27PM +0200, Hans de Goede wrote: On BYT and CHT the GOP sometimes initializes the pclk at a (slightly)

Re: [Intel-gfx] [PATCH 4/4] drm/i915/intel_dsi: Read back pclk set by GOP and use that as pclk

2018-07-09 Thread Rodrigo Vivi
On Sat, Jul 07, 2018 at 08:32:16AM +0200, Hans de Goede wrote: > Hi, > > On 07/06/2018 04:16 PM, Ville Syrjälä wrote: > > On Tue, Jun 19, 2018 at 10:18:27PM +0200, Hans de Goede wrote: > > > On BYT and CHT the GOP sometimes initializes the pclk at a (slightly) > > > different frequency then the pc

Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-09 Thread Mark Rutland
On Mon, Jul 09, 2018 at 06:03:42PM +0200, Peter Zijlstra wrote: > On Mon, Jul 09, 2018 at 05:52:04PM +0200, Daniel Vetter wrote: > > for_each_something(foo) > > if (foo->bla) > > call_bla(foo); > > else > > call_default(foo); > > > > Totally contrived, but this comp

Re: [Intel-gfx] [PATCH 09/12] nubus: use for_each_if

2018-07-09 Thread Finn Thain
On Mon, 9 Jul 2018, Daniel Vetter wrote: > Avoids the inverted check compared to the open-coded version. > > Signed-off-by: Daniel Vetter > Cc: Finn Thain > Cc: linux-m...@lists.linux-m68k.org Acked-by: Finn Thain > --- > include/linux/nubus.h | 2 +- > 1 file changed, 1 insertion(+), 1 del

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with kernel.h: Add for_each_if() (rev3)

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with kernel.h: Add for_each_if() (rev3) URL : https://patchwork.freedesktop.org/series/46158/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4455 -> Patchwork_9596 = == Summary - SUCCESS == No regressions found. External URL

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with kernel.h: Add for_each_if() (rev3)

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with kernel.h: Add for_each_if() (rev3) URL : https://patchwork.freedesktop.org/series/46158/ State : warning == Summary == $ dim checkpatch origin/drm-tip 071bf8d2 kernel.h: Add for_each_if() -:6: WARNING:TYPO_SPELLING: 'ambigious' may be missp

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: remove confusing GPIO vs PCH_GPIO URL : https://patchwork.freedesktop.org/series/46200/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4455 -> Patchwork_9595 = == Summary - SUCCESS == No regressions found.

Re: [Intel-gfx] [PATCH v4] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-07-09 17:28:02) > > On 09/07/2018 14:20, Tomasz Lis wrote: > > +static int i915_gem_context_clear_data_port_coherent(struct > > i915_gem_context *ctx) > > +{ > > + int ret; > > + > > + ret = intel_lr_context_modify_data_port_coherency(ctx, false); > > + if

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [CI,1/3] drm/i915: Provide a timeout to i915_gem_wait_for_idle()

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with [CI,1/3] drm/i915: Provide a timeout to i915_gem_wait_for_idle() URL : https://patchwork.freedesktop.org/series/46175/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4453_full -> Patchwork_9590_full = == Summary - WARNING ==

Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-09 Thread Peter Zijlstra
On Mon, Jul 09, 2018 at 05:52:04PM +0200, Daniel Vetter wrote: > for_each_something(foo) > if (foo->bla) > call_bla(foo); > else > call_default(foo); Note that the kernel coding style 'discourages' this style and would like you to write: for_each_so

Re: [Intel-gfx] [PATCH v4] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-09 Thread Tvrtko Ursulin
On 09/07/2018 14:20, Tomasz Lis wrote: The patch adds a parameter to control the data port coherency functionality on a per-context level. When the IOCTL is called, a command to switch data port coherency state is added to the ordered list. All prior requests are executed on old coherency settin

[Intel-gfx] [PATCH] kernel.h: Add for_each_if()

2018-07-09 Thread Daniel Vetter
To avoid compilers complainig about ambigious else blocks when putting an if condition into a for_each macro one needs to invert the condition and add a dummy else. We have a nice little convenience macro for that in drm headers, let's move it out. Subsequent patches will roll it out to other place

[Intel-gfx] [PATCH 2/2] drm/i915: remove PCH_GMBUS defines

2018-07-09 Thread Lucas De Marchi
Now they are the same as GMBUS*, but without considering the different address bases. In order to use GMBUS* we just need access to dev_priv in a few places so this has been added. Signed-off-by: Lucas De Marchi --- drivers/gpu/drm/i915/gvt/edid.c | 42 + drivers/

[Intel-gfx] [PATCH 1/2] drm/i915: remove confusing GPIO vs PCH_GPIO

2018-07-09 Thread Lucas De Marchi
Instead of defining all registers twice, define just a PCH_GPIO_BASE that has the same address as PCH_GPIO_A and use that to calculate all the others. This also brings VLV and !HAS_GMCH_DISPLAY in line, doing the same thing. This also rewrites the GMBUS[05] registers since they depend on gpio_mmio

[Intel-gfx] [PATCH] cpufreq: use for_each_if

2018-07-09 Thread Daniel Vetter
Avoids the inverted condition compared to the open coded version. Signed-off-by: Daniel Vetter Cc: "Rafael J. Wysocki" Cc: Viresh Kumar Cc: linux...@vger.kernel.org Cc: Eric Engestrom -- v2: Fix the logic fumble in the 2nd hunk, spotted by Eric. --- include/linux/cpufreq.h | 8 ++-- 1 fil

Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-09 Thread Daniel Vetter
On Mon, Jul 9, 2018 at 6:03 PM, Peter Zijlstra wrote: > On Mon, Jul 09, 2018 at 05:52:04PM +0200, Daniel Vetter wrote: >> for_each_something(foo) >> if (foo->bla) >> call_bla(foo); >> else >> call_default(foo); >> >> Totally contrived, but this complains. Li

Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-09 Thread Peter Zijlstra
On Mon, Jul 09, 2018 at 05:52:04PM +0200, Daniel Vetter wrote: > for_each_something(foo) > if (foo->bla) > call_bla(foo); > else > call_default(foo); > > Totally contrived, but this complains. Liberally sprinkling {} also shuts > up the compiler, but it's a

Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-09 Thread Daniel Vetter
On Mon, Jul 09, 2018 at 05:12:58PM +0200, Peter Zijlstra wrote: > On Mon, Jul 09, 2018 at 05:00:07PM +0200, Daniel Vetter wrote: > > On Mon, Jul 9, 2018 at 12:36 PM, Peter Zijlstra > > wrote: > > > On Mon, Jul 09, 2018 at 10:36:49AM +0200, Daniel Vetter wrote: > > > >> #define for_each_node_wit

Re: [Intel-gfx] [RFC COMP I/F] drm/i915: Initialize HDCP2.2 and its MEI interface

2018-07-09 Thread Ramalingam C
On Monday 09 July 2018 08:40 PM, Daniel Vetter wrote: On Mon, Jul 09, 2018 at 07:01:09PM +0530, Ramalingam C wrote: Initialize HDCP2.2 support. This includes the mei interface initialization along with required component registration. v2: mei interface handle is protected with mutex. [Chri

Re: [Intel-gfx] [PATCH v4] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-09 Thread Lis, Tomasz
On 2018-07-09 16:24, Lionel Landwerlin wrote: On 09/07/18 15:03, Lis, Tomasz wrote: On 2018-07-09 15:48, Lionel Landwerlin wrote: On 09/07/18 14:20, Tomasz Lis wrote: The patch adds a parameter to control the data port coherency functionality on a per-context level. When the IOCTL is calle

Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-09 Thread Peter Zijlstra
On Mon, Jul 09, 2018 at 05:00:07PM +0200, Daniel Vetter wrote: > On Mon, Jul 9, 2018 at 12:36 PM, Peter Zijlstra wrote: > > On Mon, Jul 09, 2018 at 10:36:49AM +0200, Daniel Vetter wrote: > >> #define for_each_node_with_cpus(node)\ > >> for_each_online_node(node)

Re: [Intel-gfx] [RFC COMP I/F] drm/i915: Initialize HDCP2.2 and its MEI interface

2018-07-09 Thread Daniel Vetter
On Mon, Jul 09, 2018 at 07:01:09PM +0530, Ramalingam C wrote: > Initialize HDCP2.2 support. This includes the mei interface > initialization along with required component registration. > > v2: > mei interface handle is protected with mutex. [Chris Wilson] > v3: > Notifiers are used for the mei

Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

2018-07-09 Thread Daniel Vetter
On Mon, Jul 9, 2018 at 12:36 PM, Peter Zijlstra wrote: > On Mon, Jul 09, 2018 at 10:36:49AM +0200, Daniel Vetter wrote: >> Avoids complaints from gcc about ambiguous else clauses. > > Is that a new thing? I'm fairly sure I've never seen it do that, > >> Signed-off-by: Daniel Vetter >> Cc: Andrew

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove function details from device error messages

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Remove function details from device error messages URL : https://patchwork.freedesktop.org/series/46187/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4454 -> Patchwork_9594 = == Summary - SUCCESS == No regressions found. Externa

Re: [Intel-gfx] [PATCH 02/11] drm/i915: Only reset hangcheck at the start of an activity cycle

2018-07-09 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2018-07-09 15:13:44) >> Chris Wilson writes: >> >> > Across a reset, the seqno (and thus hangcheck) should restart and the >> > hangcheck naturally progress, for when it does not, we want to declare an >> > emergency. Currently, we only detect if re

Re: [Intel-gfx] [PATCH 02/11] drm/i915: Only reset hangcheck at the start of an activity cycle

2018-07-09 Thread Chris Wilson
Quoting Mika Kuoppala (2018-07-09 15:13:44) > Chris Wilson writes: > > > Across a reset, the seqno (and thus hangcheck) should restart and the > > hangcheck naturally progress, for when it does not, we want to declare an > > emergency. Currently, we only detect if reset and reinit fails, but we >

Re: [Intel-gfx] [PATCH v4] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-09 Thread Lionel Landwerlin
On 09/07/18 15:03, Lis, Tomasz wrote: On 2018-07-09 15:48, Lionel Landwerlin wrote: On 09/07/18 14:20, Tomasz Lis wrote: The patch adds a parameter to control the data port coherency functionality on a per-context level. When the IOCTL is called, a command to switch data port coherency state

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Add Exec param to control data port coherency. (rev5)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Add Exec param to control data port coherency. (rev5) URL : https://patchwork.freedesktop.org/series/40181/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4454 -> Patchwork_9592 = == Summary - SUCCESS == No regressions found. Exte

Re: [Intel-gfx] [PATCH 02/11] drm/i915: Only reset hangcheck at the start of an activity cycle

2018-07-09 Thread Mika Kuoppala
Chris Wilson writes: > Across a reset, the seqno (and thus hangcheck) should restart and the > hangcheck naturally progress, for when it does not, we want to declare an > emergency. Currently, we only detect if reset and reinit fails, but we > do not detect if the call to reinit succeeds but the

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Initialize HDCP2.2 and its MEI interface

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Initialize HDCP2.2 and its MEI interface URL : https://patchwork.freedesktop.org/series/46180/ State : failure == Summary == Applying: drm/i915: Initialize HDCP2.2 and its MEI interface error: sha1 information is lacking or useless (drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH v4] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-09 Thread Lis, Tomasz
On 2018-07-09 15:48, Lionel Landwerlin wrote: On 09/07/18 14:20, Tomasz Lis wrote: The patch adds a parameter to control the data port coherency functionality on a per-context level. When the IOCTL is called, a command to switch data port coherency state is added to the ordered list. All prio

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for drm/i915: Add Exec param to control data port coherency. (rev5)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Add Exec param to control data port coherency. (rev5) URL : https://patchwork.freedesktop.org/series/40181/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Add IOCTL Param to control data port coherency. -drivers/gpu/drm/i915/s

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Add Exec param to control data port coherency. (rev5)

2018-07-09 Thread Patchwork
== Series Details == Series: drm/i915: Add Exec param to control data port coherency. (rev5) URL : https://patchwork.freedesktop.org/series/40181/ State : warning == Summary == $ dim checkpatch origin/drm-tip c705f01c81f1 drm/i915: Add IOCTL Param to control data port coherency. -:15: WARNING:

Re: [Intel-gfx] [PATCH 01/11] drm/i915/selftests: Prevent background reaping of active objects

2018-07-09 Thread Chris Wilson
Quoting Mika Kuoppala (2018-07-09 14:48:31) > Chris Wilson writes: > > > igt_mmap_offset_exhaustion() wants to test what happens when the mmap > > space is filled with zombie objects, objects discarded by userspace but > > still active on the GPU. As they are only protected by the active > > refe

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/3] drm/i915: Provide a timeout to i915_gem_wait_for_idle()

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with [1/3] drm/i915: Provide a timeout to i915_gem_wait_for_idle() URL : https://patchwork.freedesktop.org/series/46170/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4453_full -> Patchwork_9589_full = == Summary - WARNING ==

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [01/11] drm/i915/selftests: Prevent background reaping of active objects

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with [01/11] drm/i915/selftests: Prevent background reaping of active objects URL : https://patchwork.freedesktop.org/series/46176/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4454 -> Patchwork_9591 = == Summary - SUCCESS ==

Re: [Intel-gfx] [PATCH 01/11] drm/i915/selftests: Prevent background reaping of active objects

2018-07-09 Thread Mika Kuoppala
Chris Wilson writes: > igt_mmap_offset_exhaustion() wants to test what happens when the mmap > space is filled with zombie objects, objects discarded by userspace but > still active on the GPU. As they are only protected by the active > reference, we have to be certain that active reference is ke

[Intel-gfx] [PATCH] drm/i915: Remove function details from device error messages

2018-07-09 Thread Chris Wilson
Error messages are intended to be addressed to the user; be clear, succinct, instructive and unambiguous. Adding the function name to that message does not add any information the user requires and in the process makes the message less clear. E.g. [ 245.539711] i915 :00:02.0: [drm:i915_gem_i

Re: [Intel-gfx] [PATCH v4] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-09 Thread Lionel Landwerlin
On 09/07/18 14:20, Tomasz Lis wrote: The patch adds a parameter to control the data port coherency functionality on a per-context level. When the IOCTL is called, a command to switch data port coherency state is added to the ordered list. All prior requests are executed on old coherency settings,

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [01/11] drm/i915/selftests: Prevent background reaping of active objects

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with [01/11] drm/i915/selftests: Prevent background reaping of active objects URL : https://patchwork.freedesktop.org/series/46176/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915/selftests: Prevent background reaping of

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 03/11] trace.pl: Scale timeline for better precision

2018-07-09 Thread Tvrtko Ursulin
On 09/07/2018 14:26, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-07-09 14:19:56) From: Tvrtko Ursulin vis library has a limited precision compared to our trace data which prevents zooming into the timeline and seeing the fine detail. Scale the HTML view by a thousand to work around it.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [01/11] drm/i915/selftests: Prevent background reaping of active objects

2018-07-09 Thread Patchwork
== Series Details == Series: series starting with [01/11] drm/i915/selftests: Prevent background reaping of active objects URL : https://patchwork.freedesktop.org/series/46176/ State : warning == Summary == $ dim checkpatch origin/drm-tip d53e6a02a19e drm/i915/selftests: Prevent background re

[Intel-gfx] [RFC COMP I/F] drm/i915: Initialize HDCP2.2 and its MEI interface

2018-07-09 Thread Ramalingam C
Initialize HDCP2.2 support. This includes the mei interface initialization along with required component registration. v2: mei interface handle is protected with mutex. [Chris Wilson] v3: Notifiers are used for the mei interface state. v4: Poll for mei client device state Error msg for out

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t 03/11] trace.pl: Scale timeline for better precision

2018-07-09 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-07-09 14:19:56) > From: Tvrtko Ursulin > > vis library has a limited precision compared to our trace data which > prevents zooming into the timeline and seeing the fine detail. > > Scale the HTML view by a thousand to work around it. Shouldn't there be some clue in

Re: [Intel-gfx] [igt-dev] [PATCH i-g-t] igt/gem_render_copy: Check for GEM before running

2018-07-09 Thread Chris Wilson
Quoting Ville Syrjälä (2018-07-09 14:19:40) > On Mon, Jul 09, 2018 at 11:28:47AM +0100, Chris Wilson wrote: > > gem_render_copy requires a working GPU so check first. > > > > Signed-off-by: Chris Wilson > > --- > > tests/gem_render_copy.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff -

[Intel-gfx] [PATCH v4] drm/i915: Add IOCTL Param to control data port coherency.

2018-07-09 Thread Tomasz Lis
The patch adds a parameter to control the data port coherency functionality on a per-context level. When the IOCTL is called, a command to switch data port coherency state is added to the ordered list. All prior requests are executed on old coherency settings, and all exec requests after the IOCTL

  1   2   >