Re: [Intel-gfx] [PATCH 11/12] sched: use for_each_if in topology.h

[Peter Zijlstra]

On Mon, Jul 09, 2018 at 05:52:04PM +0200, Daniel Vetter wrote:
> for_each_something(foo)
>       if (foo->bla)
>               call_bla(foo);
>       else
>               call_default(foo);

Note that the kernel coding style 'discourages' this style and would
like you to write:

        for_each_something(foo) {
                if (foo->bla)
                        call_bla(foo);
                else
                        call_default(foo);
        }

Which avoids the entire problem. See CodingStyle-3:

  Also, use braces when a loop contains more than a single simple statement:

  .. code-block:: c

          while (condition) {
                  if (test)
                          do_something();
          }
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx