[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/dp: Add DP_DPCD_REV_XX to drm_dp_helper

2018-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp: Add DP_DPCD_REV_XX to drm_dp_helper URL : https://patchwork.freedesktop.org/series/42710/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4149_full -> Patchwork_8912_full = == Summary - WARNING == Minor unknow

Re: [Intel-gfx] [PATCH] drm/i915/psr: vbt change for psr

2018-05-04 Thread Puthikorn Voravootivat
FYI, Here is the the BDB version of the chip that need this change in Google Pixelbook. localhost ~ # uname -p Intel(R) Core(TM) i5-7Y57 CPU @ 1.20GHz localhost ~ # dmesg | grep VBT.signature [0.298850] VBT signature "$VBT SKYLAKE", BDB version 211 localhost ~ # uname -p Intel(R) Cor

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/dp: Add DP_DPCD_REV_XX to drm_dp_helper

2018-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp: Add DP_DPCD_REV_XX to drm_dp_helper URL : https://patchwork.freedesktop.org/series/42710/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4149 -> Patchwork_8912 = == Summary - SUCCESS == No regressions found.

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/dp: Add DP_DPCD_REV_XX to drm_dp_helper

2018-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/dp: Add DP_DPCD_REV_XX to drm_dp_helper URL : https://patchwork.freedesktop.org/series/42710/ State : warning == Summary == $ dim checkpatch origin/drm-tip 57a92512db6b drm/dp: Add DP_DPCD_REV_XX to drm_dp_helper 94f073af5236 drm/dp:

Re: [Intel-gfx] [PATCH 4/5] drm/i915/icl/huc: Correctly authenticate the HuC for Icelake

2018-05-04 Thread John Spotswood
On Wed, 2018-05-02 at 12:03 -0700, Oscar Mateo wrote: > The register to check for correct HuC authentication by the GuC > has changed in Icelake. Look into the right register & bit. > > v2: rebased. > v3: rebased. > v4: Fix I915_PARAM_HUC_STATUS as well (Tony) > v5: Fix duplicate Cc > > BSpec: 19

[Intel-gfx] [PATCH 2/2] drm/dp: Correctly mask DP_TRAINING_AUX_RD_INTERVAL values for DP 1.4

2018-05-04 Thread matthew . s . atwood
From: Matt Atwood DP_TRAINING_AUX_RD_INTERVAL with DP 1.3 spec changed bit scheeme from 8 bits to 7 in DPCD 0x000e. The 8th bit is used to identify extended receiver capabilities. For panels that use this new feature wait interval would be increased by 512 ms, when spec is max 16 ms. This behavio

[Intel-gfx] [PATCH 1/2] drm/dp: Add DP_DPCD_REV_XX to drm_dp_helper

2018-05-04 Thread matthew . s . atwood
From: Matt Atwood As more differentation occurs between DP spec. Its useful to have these as macros in a drm_dp_helper. v2: DPCD_REV_XX to DP_DPCD_REV_XX Signed-off-by: Matt Atwood --- include/drm/drm_dp_helper.h | 5 + 1 file changed, 5 insertions(+) diff --git a/include/drm/drm_dp_help

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Skip the execlists tests on !execlists machines

2018-05-04 Thread Chris Wilson
Quoting Chris Wilson (2018-05-04 17:33:57) > Quoting Tvrtko Ursulin (2018-05-04 17:25:27) > > > > On 04/05/2018 13:42, Chris Wilson wrote: > > > Ignore the tests looking at the innards of execlists and its submission > > > tasklets on machines that don't support execlists! > > > > > > Signed-off-

[Intel-gfx] [PATCH 1/2] x86/gpu: reserve ICL's graphics stolen memory

2018-05-04 Thread Paulo Zanoni
ICL changes the registers and addresses to 64 bits. I also briefly looked at implementing an u64 version of the PCI config read functions, but I concluded this wouldn't be trivial, so it's not worth doing it for a single user that can't have any racing problems while reading the register in two se

[Intel-gfx] [PATCH 2/2] drm/i915: use the ICL stolen memory

2018-05-04 Thread Paulo Zanoni
Now that our stolen memory is already reserved by the x86 subsystem (since commit "x86/gpu: reserve ICL's graphics stolen memory"), make use of it. Cc: Joonas Lahtinen Cc: Daniele Ceraolo Spurio Cc: x...@kernel.org Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_gem_stolen.c | 38 +++

Re: [Intel-gfx] [PATCH v13 08/10] drm: Expose modes with aspect ratio, only if requested

2018-05-04 Thread Ville Syrjälä
On Thu, May 03, 2018 at 08:26:26AM +0200, Daniel Vetter wrote: > On Wed, May 02, 2018 at 12:20:20PM +0530, Nautiyal, Ankit K wrote: > > From: Ankit Nautiyal > > > > We parse the EDID and add all the modes in the connector's modelist. > > This adds CEA modes with aspect ratio information too, rega

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Eliminate the unused dev_priv->vbt.lvds_vbt

2018-05-04 Thread Rodrigo Vivi
On Fri, May 04, 2018 at 05:13:49PM +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > dev_priv->vbt.lvds_vbt is set but never actually used. Kill it. > > Signed-off-by: Ville Syrjälä Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_drv.h | 1 - > drivers/gpu/drm/i915/intel_b

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: configure the transcoder clocks before touching pipeconf on HSW+ (rev2)

2018-05-04 Thread Paulo Zanoni
Em Qua, 2018-05-02 às 22:23 +, Patchwork escreveu: > == Series Details == > > Series: drm/i915: configure the transcoder clocks before touching > pipeconf on HSW+ (rev2) > URL : https://patchwork.freedesktop.org/series/42436/ > State : failure > > == Summary == > > = CI Bug Log - changes f

Re: [Intel-gfx] [PATCH v2] drm/i915: Fix drm:intel_enable_lvds ERROR message in kernel log

2018-05-04 Thread Ville Syrjälä
On Fri, Apr 20, 2018 at 01:36:40PM +0300, Jani Nikula wrote: > On Thu, 19 Apr 2018, Ville Syrjala wrote: > > From: Florent Flament > > > > Fix `[drm:intel_enable_lvds] *ERROR* timed out waiting for panel to > > power on` in kernel log at boot time. > > > > Toshiba Satellite Z930 laptops needs bet

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Skip the execlists tests on !execlists machines

2018-05-04 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-04 17:25:27) > > On 04/05/2018 13:42, Chris Wilson wrote: > > Ignore the tests looking at the innards of execlists and its submission > > tasklets on machines that don't support execlists! > > > > Signed-off-by: Chris Wilson > > --- > > drivers/gpu/drm/i915/self

Re: [Intel-gfx] [PATCH 01/22] drm/i915/icl: Introduce initial Icelake Workarounds

2018-05-04 Thread Tvrtko Ursulin
On 02/05/2018 21:34, Oscar Mateo wrote: Inherit workarounds from previous platforms that are still valid for Icelake. v2: GEN7_ROW_CHICKEN2 is masked v3: - Since it has been fixed already in upstream, removed the TODO comment about WA_SET_BIT for WaInPlaceDecompressionHang. - Squashe

Re: [Intel-gfx] [PATCH] drm/i915/selftests: Skip the execlists tests on !execlists machines

2018-05-04 Thread Tvrtko Ursulin
On 04/05/2018 13:42, Chris Wilson wrote: Ignore the tests looking at the innards of execlists and its submission tasklets on machines that don't support execlists! Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_lrc.c | 4 1 file changed, 4 insertions(+) diff --gi

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Expose RPCS (SSEU) configuration to userspace

2018-05-04 Thread Lionel Landwerlin
On 03/05/18 18:18, Tvrtko Ursulin wrote:   +int intel_lr_context_set_sseu(struct i915_gem_context *ctx, +  struct intel_engine_cs *engine, +  struct i915_gem_context_sseu *sseu) +{ +    struct drm_i915_private *dev_priv = ctx->i915; +    struct intel_context *ce; +

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present

2018-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present URL : https://patchwork.freedesktop.org/series/42690/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4146_full -> Patchwork_8910_ful

[Intel-gfx] ✓ Fi.CI.IGT: success for dma-fence cleanup v2 (rev6)

2018-05-04 Thread Patchwork
== Series Details == Series: dma-fence cleanup v2 (rev6) URL : https://patchwork.freedesktop.org/series/42640/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4146_full -> Patchwork_8909_full = == Summary - WARNING == Minor unknown changes coming with Patchwork_8909_full n

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/dp: silence a static checker warning (rev2)

2018-05-04 Thread Patchwork
== Series Details == Series: drm/i915/dp: silence a static checker warning (rev2) URL : https://patchwork.freedesktop.org/series/42630/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4146 -> Patchwork_8911 = == Summary - FAILURE == Serious unknown changes coming with Patc

[Intel-gfx] [PATCH] drm/i915/dp: Silence static checkers for n_entries

2018-05-04 Thread Chris Wilson
Smatch warns that n_entries isn't always set, so copy'n'paste the common response used in the other setup paths to silence gcc. The advantage of fixing it in situ (rather than use a zero initialiser) is that the analysers are quite capable of then spotting the absence. Reported-by: Dan Carpenter

Re: [Intel-gfx] [PATCH] drm/i915/dp: silence a static checker warning

2018-05-04 Thread Chris Wilson
Quoting Rodrigo Vivi (2018-05-03 17:40:00) > On Thu, May 03, 2018 at 01:53:22PM +0300, Dan Carpenter wrote: > > Smatch warns that "n_entries" isn't always set. It would trigger a > > some WARN_ON()s on that path so presumably it can't happen but it's > > simple enough to initialize it to zero just

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: Skip the execlists tests on !execlists machines

2018-05-04 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Skip the execlists tests on !execlists machines URL : https://patchwork.freedesktop.org/series/42683/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4146_full -> Patchwork_8907_full = == Summary - WARNING == Minor unknown c

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present

2018-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present URL : https://patchwork.freedesktop.org/series/42690/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4146 -> Patchwork_8910 = == Su

[Intel-gfx] ✗ Fi.CI.SPARSE: warning for series starting with [1/2] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present

2018-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present URL : https://patchwork.freedesktop.org/series/42690/ State : warning == Summary == $ dim sparse origin/drm-tip Commit: drm/i915: Consult VBT "LVDS co

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [1/2] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present

2018-05-04 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present URL : https://patchwork.freedesktop.org/series/42690/ State : warning == Summary == $ dim checkpatch origin/drm-tip 55f6fb40253e drm/i915: Consult VBT

[Intel-gfx] ✓ Fi.CI.BAT: success for dma-fence cleanup v2 (rev6)

2018-05-04 Thread Patchwork
== Series Details == Series: dma-fence cleanup v2 (rev6) URL : https://patchwork.freedesktop.org/series/42640/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4146 -> Patchwork_8909 = == Summary - SUCCESS == No regressions found. External URL: https://patchwork.freedes

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dma-fence cleanup v2 (rev6)

2018-05-04 Thread Patchwork
== Series Details == Series: dma-fence cleanup v2 (rev6) URL : https://patchwork.freedesktop.org/series/42640/ State : warning == Summary == $ dim checkpatch origin/drm-tip 96d5c610719e dma-fence: remove fill_driver_data callback 81dd25d339aa dma-fence: Make ->enable_signaling optional -:65: W

[Intel-gfx] [PATCH 1/2] drm/i915: Consult VBT "LVDS config" bits to determine whether internal LVDS is present

2018-05-04 Thread Ville Syrjala
From: Ville Syrjälä VBT seems to have some bits to tell us whether the internal LVDS port has something hooked up. In theory one might expect the VBT to not have a child device for the LVDS port if there's no panel hooked up, but in practice many VBTs still add the child device. The "LVDS config"

[Intel-gfx] [PATCH 2/2] drm/i915: Eliminate the unused dev_priv->vbt.lvds_vbt

2018-05-04 Thread Ville Syrjala
From: Ville Syrjälä dev_priv->vbt.lvds_vbt is set but never actually used. Kill it. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_drv.h | 1 - drivers/gpu/drm/i915/intel_bios.c | 3 --- 2 files changed, 4 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/d

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Include priority and completed status in request in/out tracepoints

2018-05-04 Thread Patchwork
== Series Details == Series: drm/i915: Include priority and completed status in request in/out tracepoints URL : https://patchwork.freedesktop.org/series/42678/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4146_full -> Patchwork_8906_full = == Summary - WARNING == Mino

[Intel-gfx] [PATCH] drm/i915: Remove unecessary dma_fence_ops

2018-05-04 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. v2: Also remove the relase hook, dma_fence_free is the default. Signed-off-by: Daniel Vetter Cc: Jani Nikula Cc: Joonas Lahtinen Cc: Rodrigo Vivi Cc: Chris Wilson Cc: Tvrtko Ursulin Cc: Colin Ia

[Intel-gfx] [PATCH] dma-fence: Make ->enable_signaling optional

2018-05-04 Thread Daniel Vetter
Many drivers have a trivial implementation for ->enable_signaling. Let's make it optional by assuming that signalling is already available when the callback isn't present. v2: Don't do the trick to set the ENABLE_SIGNAL_BIT unconditionally, it results in an expensive spinlock take for everyone. In

[Intel-gfx] ✗ Fi.CI.BAT: failure for dma-fence cleanup v2 (rev3)

2018-05-04 Thread Patchwork
== Series Details == Series: dma-fence cleanup v2 (rev3) URL : https://patchwork.freedesktop.org/series/42640/ State : failure == Summary == Applying: dma-fence: remove fill_driver_data callback Applying: dma-fence: Make ->enable_signaling optional Applying: dma-fence: Allow wait_any_timeout f

[Intel-gfx] [PATCH] drm/msm: Remove unecessary dma_fence_ops

2018-05-04 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. v2: Also remove the relase hook, dma_fence_free is the default. Signed-off-by: Daniel Vetter Cc: Rob Clark Cc: linux-arm-...@vger.kernel.org Cc: freedr...@lists.freedesktop.org --- drivers/gpu/drm/

[Intel-gfx] [PATCH] drm/vc4: Remove unecessary dma_fence_ops

2018-05-04 Thread Daniel Vetter
dma_fence_default_wait is the default now, same for the trivial enable_signaling implementation. v2: Also remove the relase hook, dma_fence_free is the default. Reviewed-by: Eric Anholt Signed-off-by: Daniel Vetter Cc: Eric Anholt --- drivers/gpu/drm/vc4/vc4_fence.c | 8 1 file chang

[Intel-gfx] [PATCH] dma-fence: Polish kernel-doc for dma-fence.c

2018-05-04 Thread Daniel Vetter
- Intro section that links to how this is exposed to userspace. - Lots more hyperlinks. - Minor clarifications and style polish v2: Add misplaced hunk of kerneldoc from a different patch. Signed-off-by: Daniel Vetter Cc: Sumit Semwal Cc: Gustavo Padovan Cc: linux-me...@vger.kernel.org Cc: lina

Re: [Intel-gfx] [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 03:17:08PM +0200, Christian König wrote: > Am 04.05.2018 um 11:25 schrieb Daniel Vetter: > > On Fri, May 4, 2018 at 11:16 AM, Chris Wilson > > wrote: > > > Quoting Daniel Vetter (2018-05-04 09:57:59) > > > > On Fri, May 04, 2018 at 09:31:33AM +0100, Chris Wilson wrote: > >

Re: [Intel-gfx] [PATCH 07/22] drm/i915/icl: WaCL2SFHalfMaxAlloc

2018-05-04 Thread Mika Kuoppala
Oscar Mateo writes: > This workarounds an issue with insufficient storage for the > CL2 and SF units. > > v2: Renamed to Wa_1405766107 > v3: Wrapped the commit message > v4: Rebased on top of the WA refactoring > v5: Added References (Mika) > > References: HSDES#1405766107 > Cc: Mika Kuoppala >

Re: [Intel-gfx] [PATCH 06/22] drm/i915/icl: WaDisableCleanEvicts

2018-05-04 Thread Mika Kuoppala
Oscar Mateo writes: > Avoids an undefined LLC behavior. > > BSpec: 9613 > > v2: Renamed to Wa_1405733216 > v3: Spaces around '<<' and fix surrounding code > v4: Rebased on top of the WA refactoring > v5: Added References (Mika) > > References: HSDES#1405733216 > Cc: Mika Kuoppala > Signed-off-by

Re: [Intel-gfx] [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Christian König
Am 04.05.2018 um 11:25 schrieb Daniel Vetter: On Fri, May 4, 2018 at 11:16 AM, Chris Wilson wrote: Quoting Daniel Vetter (2018-05-04 09:57:59) On Fri, May 04, 2018 at 09:31:33AM +0100, Chris Wilson wrote: Quoting Daniel Vetter (2018-05-04 09:23:01) On Fri, May 04, 2018 at 10:17:22AM +0200, D

Re: [Intel-gfx] [PATCH v5 0/6] Enable NV12 support

2018-05-04 Thread Maarten Lankhorst
Op 03-05-18 om 10:58 schreef Srinivas, Vidya: > >> -Original Message- >> From: Srinivas, Vidya >> Sent: Wednesday, May 2, 2018 3:47 PM >> To: Maarten Lankhorst ; Kristian >> Høgsberg >> Cc: intel-gfx@lists.freedesktop.org >> Subject: RE: [Intel-gfx] [PATCH v5 0/6] Enable NV12 support >> >>

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/selftests: Skip the execlists tests on !execlists machines

2018-05-04 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Skip the execlists tests on !execlists machines URL : https://patchwork.freedesktop.org/series/42683/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4146 -> Patchwork_8907 = == Summary - WARNING == Minor unknown changes com

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Include priority and completed status in request in/out tracepoints

2018-05-04 Thread Patchwork
== Series Details == Series: drm/i915: Include priority and completed status in request in/out tracepoints URL : https://patchwork.freedesktop.org/series/42678/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4146 -> Patchwork_8906 = == Summary - SUCCESS == No regressions

Re: [Intel-gfx] [PATCH v5 6/6] drm/i915: Add skl_check_nv12_surface for NV12

2018-05-04 Thread Maarten Lankhorst
Op 19-04-18 om 12:22 schreef Vidya Srinivas: > From: Maarten Lankhorst > > We skip src trunction/adjustments for > NV12 case and handle the sizes directly. > Without this, pipe fifo underruns are seen on APL/KBL. > > v2: For NV12, making the src coordinates multiplier of 4 > > v3: Moving all the s

[Intel-gfx] [PATCH] drm/i915/selftests: Skip the execlists tests on !execlists machines

2018-05-04 Thread Chris Wilson
Ignore the tests looking at the innards of execlists and its submission tasklets on machines that don't support execlists! Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/selftests/intel_lrc.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/selftests/intel_lrc.c

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Include priority and completed status in request in/out tracepoints

2018-05-04 Thread Patchwork
== Series Details == Series: drm/i915: Include priority and completed status in request in/out tracepoints URL : https://patchwork.freedesktop.org/series/42678/ State : warning == Summary == $ dim checkpatch origin/drm-tip 0e6962a6d576 drm/i915: Include priority and completed status in reques

[Intel-gfx] [PATCH rdma-next 01/21] drm/i915: Move u64-to-ptr helpers to general header

2018-05-04 Thread Leon Romanovsky
From: Leon Romanovsky The macro u64_to_ptr() and function ptr_to_u64() are useful enough to be part of general header, so move them there and allow RDMA subsystem reuse them. Signed-off-by: Leon Romanovsky --- drivers/gpu/drm/i915/i915_utils.h | 12 ++-- include/linux/kernel.h

Re: [Intel-gfx] [PATCH] drm/i915: Remove assertion of active_rings must be non-empty if active_requests

2018-05-04 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-04 11:37:25) > > On 04/05/2018 11:11, Chris Wilson wrote: > > "An outstanding request must still be on an active ring somewhere" is > > only true if we haven't just been interrupted by the shrinker in the > > middle of allocating the request itself. (At the start of

Re: [Intel-gfx] [PATCH] drm/i915: Include priority and completed status in request in/out tracepoints

2018-05-04 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-04 12:56:43) > From: Tvrtko Ursulin > > It is useful to see the priority as requests are coming in and completed > status as requests are coming out of the GPU. > > To achieve this in a more readable way we need to abandon the common > request_hw tracepoint class.

[Intel-gfx] [PATCH] drm/i915: Include priority and completed status in request in/out tracepoints

2018-05-04 Thread Tvrtko Ursulin
From: Tvrtko Ursulin It is useful to see the priority as requests are coming in and completed status as requests are coming out of the GPU. To achieve this in a more readable way we need to abandon the common request_hw tracepoint class. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH 5/5] drm/selftests: Add drm helper selftest

2018-05-04 Thread Maarten Lankhorst
Op 03-05-18 om 15:36 schreef Ville Syrjälä: > On Thu, May 03, 2018 at 01:22:17PM +0200, Maarten Lankhorst wrote: >> Signed-off-by: Maarten Lankhorst >> --- >> drivers/gpu/drm/Kconfig | 1 + >> drivers/gpu/drm/selftests/Makefile| 2 +- >> .../gpu/drm/selftests

[Intel-gfx] ✗ Fi.CI.IGT: failure for drm/i915: Remove assertion of active_rings must be non-empty if active_requests

2018-05-04 Thread Patchwork
== Series Details == Series: drm/i915: Remove assertion of active_rings must be non-empty if active_requests URL : https://patchwork.freedesktop.org/series/42674/ State : failure == Summary == = CI Bug Log - changes from CI_DRM_4143_full -> Patchwork_8905_full = == Summary - FAILURE == Se

Re: [Intel-gfx] [PATCH 05/22] drm/i915/icl: WaModifyGamTlbPartitioning

2018-05-04 Thread Mika Kuoppala
Oscar Mateo writes: > Adjust default GAM TLB partitioning for performance reasons. > > v2: Only touch the bits that we really need > v3: Rebased on top of the WA refactoring > v4: > - Added References (Mika) > - Rebased > > References: HSDES#220260670 s/220260670/220160670 > Cc: Mika Kuoppal

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Remove assertion of active_rings must be non-empty if active_requests

2018-05-04 Thread Patchwork
== Series Details == Series: drm/i915: Remove assertion of active_rings must be non-empty if active_requests URL : https://patchwork.freedesktop.org/series/42674/ State : success == Summary == = CI Bug Log - changes from CI_DRM_4143 -> Patchwork_8905 = == Summary - SUCCESS == No regressio

Re: [Intel-gfx] [PATCH] drm/i915: Remove assertion of active_rings must be non-empty if active_requests

2018-05-04 Thread Tvrtko Ursulin
On 04/05/2018 11:11, Chris Wilson wrote: "An outstanding request must still be on an active ring somewhere" is only true if we haven't just been interrupted by the shrinker in the middle of allocating the request itself. (At the start of i915_request_alloc() we pin the context and prepare the GT

Re: [Intel-gfx] [PATCH 09/71] drm/i915: Store a pointer to intel_context in i915_request

2018-05-04 Thread Tvrtko Ursulin
On 03/05/2018 07:36, Chris Wilson wrote: To ease the frequent and ugly pointer dance of &request->gem_context->engine[request->engine->id] during request submission, store that pointer as request->hw_context. One major advantage that we will exploit later is that this decouples the logical conte

Re: [Intel-gfx] [PATCH] drm/i915: Remove assertion of active_rings must be non-empty if active_requests

2018-05-04 Thread Chris Wilson
Quoting Chris Wilson (2018-05-04 11:11:47) > "An outstanding request must still be on an active ring somewhere" is > only true if we haven't just been interrupted by the shrinker in the > middle of allocating the request itself. (At the start of > i915_request_alloc() we pin the context and prepare

Re: [Intel-gfx] [PATCH 04/22] drm/i915/icl: WaL3BankAddressHashing

2018-05-04 Thread Mika Kuoppala
Oscar Mateo writes: > Revert to an L3 non-hash model, for performance reasons. > > v2: > - Place the WA name above the actual change > - Improve the register naming > v3: > - Rebased > - Renamed to Wa_1604223664 > v4: Rebased on top of the WA refactoring > v5: > - Added References (Mika

[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove assertion of active_rings must be non-empty if active_requests

2018-05-04 Thread Patchwork
== Series Details == Series: drm/i915: Remove assertion of active_rings must be non-empty if active_requests URL : https://patchwork.freedesktop.org/series/42674/ State : warning == Summary == $ dim checkpatch origin/drm-tip 3b85f7a21062 drm/i915: Remove assertion of active_rings must be non-

[Intel-gfx] [PATCH] drm/i915: Remove assertion of active_rings must be non-empty if active_requests

2018-05-04 Thread Chris Wilson
"An outstanding request must still be on an active ring somewhere" is only true if we haven't just been interrupted by the shrinker in the middle of allocating the request itself. (At the start of i915_request_alloc() we pin the context and prepare the GT for activity, marking it as active, and the

[Intel-gfx] [PULL] drm-misc-next

2018-05-04 Thread Maarten Lankhorst
drm-misc-next-2018-05-04: drm-misc-next for v4.18: Ignore the dma-fence changes, they have been immediately reverted. :) Core Changes: - Rounding behavior when clipping a visible plane has changed slightly. We now consistently try to round towards the 1.0x scale to prevent running into hw limits.

Re: [Intel-gfx] [PATCH] drm/i915/gtt: Tidy up duplicate branches in gen8_gmch_probe()

2018-05-04 Thread Joonas Lahtinen
Quoting Chris Wilson (2018-05-04 00:29:56) > Following commit f773568b6ff8 ("drm/i915: nuke the duplicated stolen > discovery"), the if-else-chain for determining the GTT size is redundant > with the !chv branches all being the same. > > Reported-by: Ville Syrjälä > References: f773568b6ff8 ("drm

Re: [Intel-gfx] [PATCH 05/71] drm/i915/execlists: Disable submission tasklets when rescheduling

2018-05-04 Thread Chris Wilson
Quoting Tvrtko Ursulin (2018-05-04 10:15:20) > On 03/05/2018 20:50, Chris Wilson wrote: > The second hunk is a bit more difficult. It creates a longer softirq-off > section, which is a slight negative, and I am unsure how much it > actually closes the race with tasklets in practice. So it may be

Re: [Intel-gfx] [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 4, 2018 at 11:16 AM, Chris Wilson wrote: > Quoting Daniel Vetter (2018-05-04 09:57:59) >> On Fri, May 04, 2018 at 09:31:33AM +0100, Chris Wilson wrote: >> > Quoting Daniel Vetter (2018-05-04 09:23:01) >> > > On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote: >> > > > On Fri

Re: [Intel-gfx] [RFC v1] drm/i915: Add Exec param to control data port coherency.

2018-05-04 Thread Joonas Lahtinen
Quoting Lis, Tomasz (2018-03-20 19:23:03) > > > On 2018-03-19 15:26, Chris Wilson wrote: > > Quoting Lis, Tomasz (2018-03-19 14:14:19) > > > On 2018-03-19 13:43, Chris Wilson wrote: > > Quoting Tomasz Lis (2018-03-19 12:37:35) > > The patch adds a para

Re: [Intel-gfx] [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Chris Wilson
Quoting Daniel Vetter (2018-05-04 09:57:59) > On Fri, May 04, 2018 at 09:31:33AM +0100, Chris Wilson wrote: > > Quoting Daniel Vetter (2018-05-04 09:23:01) > > > On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote: > > > > On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote: > >

Re: [Intel-gfx] [PATCH 05/71] drm/i915/execlists: Disable submission tasklets when rescheduling

2018-05-04 Thread Tvrtko Ursulin
On 03/05/2018 20:50, Chris Wilson wrote: Quoting Tvrtko Ursulin (2018-05-03 18:49:27) On 03/05/2018 07:36, Chris Wilson wrote: As we reschedule the requests, we do not want the submission tasklet running until we finish updating the priority chains. (We start rewriting priorities from the old

Re: [Intel-gfx] [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 09:31:33AM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2018-05-04 09:23:01) > > On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote: > > > On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote: > > > > Quoting Daniel Vetter (2018-05-03 15:25:52) > >

Re: [Intel-gfx] [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Chris Wilson
Quoting Daniel Vetter (2018-05-04 09:23:01) > On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote: > > On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote: > > > Quoting Daniel Vetter (2018-05-03 15:25:52) > > > > Almost everyone uses dma_fence_default_wait. > > > > > > > > v2:

Re: [Intel-gfx] [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 10:17:22AM +0200, Daniel Vetter wrote: > On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote: > > Quoting Daniel Vetter (2018-05-03 15:25:52) > > > Almost everyone uses dma_fence_default_wait. > > > > > > v2: Also remove the BUG_ON(!ops->wait) (Chris). > > > > I j

Re: [Intel-gfx] [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Daniel Vetter
On Fri, May 04, 2018 at 09:09:10AM +0100, Chris Wilson wrote: > Quoting Daniel Vetter (2018-05-03 15:25:52) > > Almost everyone uses dma_fence_default_wait. > > > > v2: Also remove the BUG_ON(!ops->wait) (Chris). > > I just don't get the rationale for implicit over explicit. Closer approximation

Re: [Intel-gfx] [PATCH 04/15] dma-fence: Make ->wait callback optional

2018-05-04 Thread Chris Wilson
Quoting Daniel Vetter (2018-05-03 15:25:52) > Almost everyone uses dma_fence_default_wait. > > v2: Also remove the BUG_ON(!ops->wait) (Chris). I just don't get the rationale for implicit over explicit. -Chris ___ Intel-gfx mailing list Intel-gfx@lists.f

Re: [Intel-gfx] [PATCH v1] i915: Convert to use match_string() helper

2018-05-04 Thread Jani Nikula
On Thu, 03 May 2018, Andy Shevchenko wrote: > The new helper returns index of the matching string in an array. > We are going to use it here. > > Signed-off-by: Andy Shevchenko Pushed to drm-intel-next-queued, thanks for the patch. BR, Jani. > --- > drivers/gpu/drm/i915/intel_pipe_crc.c | 22

Re: [Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/selftests: fix spelling mistake: "parmaters" -> "parameters"

2018-05-04 Thread Chris Wilson
Quoting Patchwork (2018-05-03 22:47:39) > == Series Details == > > Series: drm/i915/selftests: fix spelling mistake: "parmaters" -> "parameters" > URL : https://patchwork.freedesktop.org/series/42647/ > State : success > > == Summary == > > = CI Bug Log - changes from CI_DRM_4134_full -> Patch

Re: [Intel-gfx] [PATCH 07/15] drm/etnaviv: Remove unecessary dma_fence_ops

2018-05-04 Thread Christian Gmeiner
Am Do., 3. Mai 2018 um 16:26 Uhr schrieb Daniel Vetter < daniel.vet...@ffwll.ch>: > dma_fence_default_wait is the default now, same for the trivial > enable_signaling implementation. Reviewed-by: Christian Gmeiner > Acked-by: Lucas Stach > Signed-off-by: Daniel Vetter > Cc: Lucas Stach > Cc