Re: [Intel-gfx] [PATCH] drm/i915: Empty the ring before disabling

2017-10-26 Thread Mika Kuoppala
Chris Wilson writes: > An interesting snippet from Sandybridge's prm: > > "Although a Ring Buffer can be enabled in the non-empty state, it must > not be disabled unless it is empty. Attempting to disable a Ring Buffer > in the non-empty state is UNDEFINED." > > Let's avoid the undefined behaviou

Re: [Intel-gfx] [PATCH] drm/i915: Fallback to reserve forcewake if primary ack missing

2017-10-26 Thread Mika Kuoppala
Chris Wilson writes: > Quoting Mika Kuoppala (2017-10-26 15:01:44) >> There is a possibility on gen9 hardware to miss the forcewake ack >> message. The recommended workaround is to use another free >> bit and toggle it until original bit is successfully acknowledged. >> >> The workaround is a bi

Re: [Intel-gfx] [PATCH v2] drm/i915: Cancel the modeset retry work during modeset cleanup

2017-10-26 Thread Maarten Lankhorst
Op 27-10-17 om 00:18 schreef Chris Wilson: > Quoting Manasi Navare (2017-10-26 22:52:00) >> During modeset cleanup on driver unload we may have a pending >> hotplug work. This needs to be canceled early during the teardown >> so that it does not fire after we have freed the connector. >> We do this

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Do not rely on wm preservation for ILK watermarks

2017-10-26 Thread Matt Roper
On Wed, Oct 25, 2017 at 08:03:47AM +0200, Maarten Lankhorst wrote: > Op 25-10-17 om 01:01 schreef Matt Roper: > > On Thu, Oct 19, 2017 at 05:13:40PM +0200, Maarten Lankhorst wrote: > >> The original intent was to preserve watermarks as much as possible > >> in intel_pipe_wm.raw_wm, and put the vali

[Intel-gfx] ✓ Fi.CI.IGT: success for tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled (rev2)

2017-10-26 Thread Patchwork
== Series Details == Series: tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled (rev2) URL : https://patchwork.freedesktop.org/series/32667/ State : success == Summary == Test kms_flip: Subgroup modeset-vs-vblank-race-interruptible: pass -> FAI

[Intel-gfx] ✗ Fi.CI.BAT: warning for series starting with [v2,1/2] drm/i915: Add connector property to limit max bpc

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [v2,1/2] drm/i915: Add connector property to limit max bpc URL : https://patchwork.freedesktop.org/series/32730/ State : warning == Summary == Series 32730v1 series starting with [v2,1/2] drm/i915: Add connector property to limit max bpc http

Re: [Intel-gfx] [PATCH] drm/i915: Improve DP downstream HPD handling

2017-10-26 Thread Pandiyan, Dhinakaran
On Thu, 2017-10-26 at 22:41 +0300, Ville Syrjala wrote: > From: Ville Syrjälä > > DP dongles may signal downstream HPD via short HPD pulses. Setting the > sink to DPMS off apparently kills the downstream HPD (at least on my > DP->VGA dongle), so skip the DPMS off for such dongles when we turn >

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Empty the ring before disabling

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Empty the ring before disabling URL : https://patchwork.freedesktop.org/series/32727/ State : failure == Summary == Series 32727v1 drm/i915: Empty the ring before disabling https://patchwork.freedesktop.org/api/1.0/series/32727/revisions/1/mbox/ Test gem

[Intel-gfx] [PATCH v2 2/2] drm/i915: Allow "max bpc" property to limit pipe_bpp

2017-10-26 Thread Radhakrishna Sripada
From: "Sripada, Radhakrishna" Use the newly added "max bpc" connector property to limit pipe bpp. Cc: Ville Syrjälä Cc: Paulo Zanoni Cc: Manasi Navare Signed-off-by: Radhakrishna Sripada --- drivers/gpu/drm/i915/intel_display.c | 27 +++ 1 file changed, 27 insertions

[Intel-gfx] [PATCH v2 1/2] drm/i915: Add connector property to limit max bpc

2017-10-26 Thread Radhakrishna Sripada
From: "Sripada, Radhakrishna" At times 12bpc HDMI cannot be driven due to faulty cables, dongles level shifters etc. To workaround them we may need to drive the output at a lower bpc. Currently the user space does not have a way to limit the bpc. The default bpc to be programmed is decided by the

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled (rev2)

2017-10-26 Thread Patchwork
== Series Details == Series: tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled (rev2) URL : https://patchwork.freedesktop.org/series/32667/ State : success == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_

Re: [Intel-gfx] [RFC 00/17] Per-context and per-client engine busyness

2017-10-26 Thread Lionel Landwerlin
On 26/10/17 21:11, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-10-26 18:13:13) On 26/10/17 14:05, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-10-26 14:00:28) On 26/10/2017 10:50, Lionel Landwerlin wrote: On 26/10/17 08:34, Tvrtko Ursulin wrote: On 25/10/2017 18:38, Chris Wilson

Re: [Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled

2017-10-26 Thread Pandiyan, Dhinakaran
On Thu, 2017-10-26 at 16:51 -0700, Dhinakaran Pandiyan wrote: > The frontbuffer_tracking PSR tests fail if PSR cannot be activated when > there is sink support. But, there are several other requirements related to > mode timings that have to be satisfied before PSR can be enabled. No reason > to f

[Intel-gfx] [PATCH] drm/i915: Empty the ring before disabling

2017-10-26 Thread Chris Wilson
An interesting snippet from Sandybridge's prm: "Although a Ring Buffer can be enabled in the non-empty state, it must not be disabled unless it is empty. Attempting to disable a Ring Buffer in the non-empty state is UNDEFINED." Let's avoid the undefined behaviour as we disable the rings prior to

[Intel-gfx] [PATCH i-g-t v2] tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled

2017-10-26 Thread Dhinakaran Pandiyan
The frontbuffer_tracking PSR tests fail if PSR cannot be activated when there is sink support. But, there are several other requirements related to mode timings that have to be satisfied before PSR can be enabled. No reason to fail these tests when PSR cannot be enabled. v2: Check for Source_OK in

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Cancel the modeset retry work during modeset cleanup (rev2)

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Cancel the modeset retry work during modeset cleanup (rev2) URL : https://patchwork.freedesktop.org/series/32668/ State : success == Summary == Test kms_cursor_legacy: Subgroup flip-vs-cursor-legacy: pass -> FAIL (shard

[Intel-gfx] [drm-intel:for-linux-next 14/15] cc1: warning: unrecognized command line option '-Wno-implicit-fallthrough'

2017-10-26 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel for-linux-next head: 886c6b8692ba5f71b578097524b3b082e2e02119 commit: 39bf4de89ff7c87a2205e7ec5483e7424b86a1f6 [14/15] drm/i915: Add -Wall -Wextra to our build, set warnings to full config: i386-randconfig-x0-10270203 (attached as .config) compiler

Re: [Intel-gfx] [GIT PULL] gvt fix for 4.14-rc6

2017-10-26 Thread Rodrigo Vivi
On Thu, Oct 26, 2017 at 06:09:51PM +, Zhi Wang wrote: > Hi: > Here are some fixes for 4.14-rc6. Zhenyu's patch fixes the per_ctx_bb > check in GVT-g since the usage of per_ctx_bb in i915 has been changed > recently. Another two patches from Xiong fix the GPU hang of linxu guest > when it's

[Intel-gfx] [PULL] drm-intel-fixes

2017-10-26 Thread Rodrigo Vivi
Hi Dave, Here goes drm-intel-fixes-2017-10-26. It is basically yesterday's one plus GVT fixes I received today morning. One fix for stable: - fix perf enable/disable ioctls for 32bits (Lionel) Plus GVT fixes: - Fix per_ctx_bb check (Zhenyu) - Fix GPU hang of Linux guest (Xion) - Refine MMIO_R

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915/huc: Use helper function while waiting for DMA completion

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915/huc: Use helper function while waiting for DMA completion URL : https://patchwork.freedesktop.org/series/32528/ State : success == Summary == Test kms_flip: Subgroup modeset-vs-vblank-race: dmesg-warn -> PASS (shard-hsw) fdo#1

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Cancel the modeset retry work during modeset cleanup (rev2)

2017-10-26 Thread Manasi Navare
On Thu, Oct 26, 2017 at 11:21:40PM +0100, Chris Wilson wrote: > Quoting Patchwork (2017-10-26 23:18:32) > > == Series Details == > > > > Series: drm/i915: Cancel the modeset retry work during modeset cleanup > > (rev2) > > URL : https://patchwork.freedesktop.org/series/32668/ > > State : succes

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Cancel the modeset retry work during modeset cleanup (rev2)

2017-10-26 Thread Chris Wilson
Quoting Chris Wilson (2017-10-26 23:21:40) > Quoting Patchwork (2017-10-26 23:18:32) > > == Series Details == > > > > Series: drm/i915: Cancel the modeset retry work during modeset cleanup > > (rev2) > > URL : https://patchwork.freedesktop.org/series/32668/ > > State : success > > > > == Summa

Re: [Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Cancel the modeset retry work during modeset cleanup (rev2)

2017-10-26 Thread Chris Wilson
Quoting Patchwork (2017-10-26 23:18:32) > == Series Details == > > Series: drm/i915: Cancel the modeset retry work during modeset cleanup (rev2) > URL : https://patchwork.freedesktop.org/series/32668/ > State : success > > == Summary == > > Series 32668v2 drm/i915: Cancel the modeset retry wor

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Cancel the modeset retry work during modeset cleanup (rev2)

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Cancel the modeset retry work during modeset cleanup (rev2) URL : https://patchwork.freedesktop.org/series/32668/ State : success == Summary == Series 32668v2 drm/i915: Cancel the modeset retry work during modeset cleanup https://patchwork.freedesktop.org

Re: [Intel-gfx] [PATCH v2] drm/i915: Cancel the modeset retry work during modeset cleanup

2017-10-26 Thread Chris Wilson
Quoting Manasi Navare (2017-10-26 22:52:00) > During modeset cleanup on driver unload we may have a pending > hotplug work. This needs to be canceled early during the teardown > so that it does not fire after we have freed the connector. > We do this after drm_kms_helper_poll_fini(dev) since this m

[Intel-gfx] [PATCH v2] drm/i915: Cancel the modeset retry work during modeset cleanup

2017-10-26 Thread Manasi Navare
During modeset cleanup on driver unload we may have a pending hotplug work. This needs to be canceled early during the teardown so that it does not fire after we have freed the connector. We do this after drm_kms_helper_poll_fini(dev) since this might trigger modeset retry work due to link retrain

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Remove i915.enable_execlists module parameter

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Remove i915.enable_execlists module parameter URL : https://patchwork.freedesktop.org/series/32719/ State : failure == Summary == Series 32719 revision 1 was fully merged or fully failed: no git log ___

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/huc: Use helper function while waiting for DMA completion

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915/huc: Use helper function while waiting for DMA completion URL : https://patchwork.freedesktop.org/series/32528/ State : success == Summary == Series 32528v1 drm/i915/huc: Use helper function while waiting for DMA completion https://patchwork.freedesktop.o

Re: [Intel-gfx] [PATCH] drm/i915: Include RING_MODE when dumping the engine state

2017-10-26 Thread Chris Wilson
Quoting Mika Kuoppala (2017-10-26 14:49:43) > Chris Wilson writes: > > > Knowing the RING_MODE flags is useful for checking the state of the > > engine, such as whether the CS is idle after trying to stop the engines > > before reset. > > > > Signed-off-by: Chris Wilson > > Cc: Mika Kuoppala >

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [01/10] drm/i915/guc: Precompute GuC shared data offset

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [01/10] drm/i915/guc: Precompute GuC shared data offset URL : https://patchwork.freedesktop.org/series/31412/ State : failure == Summary == Series 31412 revision 1 was fully merged or fully failed: no git log _

[Intel-gfx] ✗ Fi.CI.BAT: failure for Preemption with GuC, third attempt

2017-10-26 Thread Patchwork
== Series Details == Series: Preemption with GuC, third attempt URL : https://patchwork.freedesktop.org/series/32320/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelease.h CHK includ

[Intel-gfx] [PATCH 1/2] drm/i915: Remove i915.enable_execlists module parameter

2017-10-26 Thread Chris Wilson
Execlists and legacy ringbuffer submission are no longer feature comparable (execlists now offer greater functionality that should overcome their performance hit) and obsoletes the unsafe module parameter, i.e. comparing the two modes of execution is no longer useful, so remove the debug tool. Sig

[Intel-gfx] [PATCH 2/2] drm/i915: Remove obsolete ringbuffer emission for gen8+

2017-10-26 Thread Chris Wilson
submission. We have made a few improvements to lowlevel execlists throughput, and ringbuffer currently panics on boot! (bdw i7-5557u, 20171026): ring execlists exec continuous nops on all rings: n/a1.921us exec sequential nops on each

Re: [Intel-gfx] [PATCH] drm/i915: Add -Wall -Wextra to our build, set warnings to full

2017-10-26 Thread Chris Wilson
Quoting Jani Nikula (2017-10-26 15:36:34) > On Tue, 24 Oct 2017, Chris Wilson wrote: > > Recently W=1 on gcc-7.2 (-Wunused-const-variable) caught a regression > > that had been lurking for 6 months, so lets try enabling the full set of > > warnings for CI builds. This means more patches will be re

Re: [Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/huc: Use helper function while waiting for DMA completion

2017-10-26 Thread Chris Wilson
Quoting Patchwork (2017-10-24 13:27:27) > == Series Details == > > Series: drm/i915/huc: Use helper function while waiting for DMA completion > URL : https://patchwork.freedesktop.org/series/32528/ > State : failure > > == Summary == > > Series 32528v1 drm/i915/huc: Use helper function while w

Re: [Intel-gfx] [PATCH 00/12] Preemption with GuC, fourth try

2017-10-26 Thread Chris Wilson
Quoting Michał Winiarski (2017-10-25 21:00:08) > No major changes from previous iteration. > Dropped the workaround for missing interrupt (which turned out to be > self-inflicted, now properly fixed by Chris), and applied the review comments. And pushed. Thanks everyone for the reviews and suggest

Re: [Intel-gfx] [PATCH v6] drm/i915/guc: Add a second client, to be used for preemption

2017-10-26 Thread Chris Wilson
Quoting Michel Thierry (2017-10-26 19:49:06) > On 26/10/17 07:17, Michał Winiarski wrote: > > @@ -763,14 +770,14 @@ static int guc_init_doorbell_hw(struct intel_guc *guc) > > > > /* Now for every client (and not only execbuf_client) make sure > > their > > * doorbells are known

Re: [Intel-gfx] [PATCH v6] drm/i915/guc: Add a second client, to be used for preemption

2017-10-26 Thread Michel Thierry
On 10/26/2017 1:02 PM, Chris Wilson wrote: Quoting Michel Thierry (2017-10-26 19:49:06) On 26/10/17 07:17, Michał Winiarski wrote: @@ -763,14 +770,14 @@ static int guc_init_doorbell_hw(struct intel_guc *guc) /* Now for every client (and not only execbuf_client) make sure their

Re: [Intel-gfx] [RFC 00/17] Per-context and per-client engine busyness

2017-10-26 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-10-26 18:13:13) > On 26/10/17 14:05, Chris Wilson wrote: > > Quoting Tvrtko Ursulin (2017-10-26 14:00:28) > >> On 26/10/2017 10:50, Lionel Landwerlin wrote: > >>> On 26/10/17 08:34, Tvrtko Ursulin wrote: > On 25/10/2017 18:38, Chris Wilson wrote: > > Quoting

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Improve DP downstream HPD handling

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Improve DP downstream HPD handling URL : https://patchwork.freedesktop.org/series/32714/ State : failure == Summary == Series 32714v1 drm/i915: Improve DP downstream HPD handling https://patchwork.freedesktop.org/api/1.0/series/32714/revisions/1/mbox/ Te

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled

2017-10-26 Thread Pandiyan, Dhinakaran
On Thu, 2017-10-26 at 17:35 -0200, Paulo Zanoni wrote: > Em Qui, 2017-10-26 às 12:32 -0700, Rodrigo Vivi escreveu: > > On Thu, Oct 26, 2017 at 01:29:57PM +, Paulo Zanoni wrote: > > > Em Qua, 2017-10-25 às 17:37 -0700, Dhinakaran Pandiyan escreveu: > > > > The frontbuffer_tracking PSR tests f

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Add a GuC doorbells selftest

2017-10-26 Thread Chris Wilson
Quoting Michel Thierry (2017-10-26 19:54:06) > On 26/10/17 11:51, Michel Thierry wrote: > > Try to create as many clients as it is currently possible (currently > > limited to max number of doorbells) and exercise the doorbell > > alloc/dealloc code. > > > > Since our usage mode require very few c

[Intel-gfx] [PATCH] drm/i915: Improve DP downstream HPD handling

2017-10-26 Thread Ville Syrjala
From: Ville Syrjälä DP dongles may signal downstream HPD via short HPD pulses. Setting the sink to DPMS off apparently kills the downstream HPD (at least on my DP->VGA dongle), so skip the DPMS off for such dongles when we turn off the port. Cc: David Woodhouse Cc: Imre Deak Cc: Pablo Bugzill

Re: [Intel-gfx] [PATCH 1/2] drm/i915/edp: read edp display control registers unconditionally

2017-10-26 Thread Manasi Navare
On Thu, Oct 26, 2017 at 05:29:31PM +0300, Jani Nikula wrote: > Per my reading of the eDP spec, DP_DPCD_DISPLAY_CONTROL_CAPABLE bit in > DP_EDP_CONFIGURATION_CAP should be set if the eDP display control > registers starting at offset DP_EDP_DPCD_REV are "enabled". Currently we > check the bit before

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled

2017-10-26 Thread Paulo Zanoni
Em Qui, 2017-10-26 às 12:32 -0700, Rodrigo Vivi escreveu: > On Thu, Oct 26, 2017 at 01:29:57PM +, Paulo Zanoni wrote: > > Em Qua, 2017-10-25 às 17:37 -0700, Dhinakaran Pandiyan escreveu: > > > The frontbuffer_tracking PSR tests fail if PSR cannot be > > > activated > > > when > > > there is sin

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_frontbuffer_tracking: Skip tests when PSR cannot be enabled

2017-10-26 Thread Rodrigo Vivi
On Thu, Oct 26, 2017 at 01:29:57PM +, Paulo Zanoni wrote: > Em Qua, 2017-10-25 às 17:37 -0700, Dhinakaran Pandiyan escreveu: > > The frontbuffer_tracking PSR tests fail if PSR cannot be activated > > when > > there is sink support. But, there are several other requirements > > related to > > mo

Re: [Intel-gfx] [PATCH 2/2] drm/i915/edp: clean up code and comments around eDP DPCD read

2017-10-26 Thread Manasi Navare
On Thu, Oct 26, 2017 at 05:29:32PM +0300, Jani Nikula wrote: > Some minor drive-by cleanups. > > Signed-off-by: Jani Nikula Reviewed-by: Manasi Navare > --- > drivers/gpu/drm/i915/intel_dp.c | 10 +++--- > 1 file changed, 7 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [v6,1/3] drm/i915: Add Guc/HuC firmware details to error state

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] drm/i915: Add Guc/HuC firmware details to error state URL : https://patchwork.freedesktop.org/series/32710/ State : success == Summary == Test kms_busy: Subgroup extended-modeset-hang-newfb-with-reset-render-B:

Re: [Intel-gfx] [PATCH] drm/i915: set minimum CD clock to twice the BCLK.

2017-10-26 Thread Kumar, Abhay
On 10/26/2017 1:45 AM, Jani Nikula wrote: On Wed, 25 Oct 2017, Dhinakaran Pandiyan wrote: On Wednesday, October 25, 2017 3:02:12 PM PDT abhay.ku...@intel.com wrote: From: Abhay Kumar In glk when device boots with only 1366x768 panel, HDA codec doesn't comeup. This result in no audio foreve

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/selftests: Add a GuC doorbells selftest (rev2)

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915/selftests: Add a GuC doorbells selftest (rev2) URL : https://patchwork.freedesktop.org/series/32655/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generated/utsrelea

Re: [Intel-gfx] [PATCH v2] drm/i915/selftests: Add a GuC doorbells selftest

2017-10-26 Thread Michel Thierry
On 26/10/17 11:51, Michel Thierry wrote: Try to create as many clients as it is currently possible (currently limited to max number of doorbells) and exercise the doorbell alloc/dealloc code. Since our usage mode require very few clients/doorbells, this code has been exercised very lightly and i

[Intel-gfx] [PATCH v2] drm/i915/selftests: Add a GuC doorbells selftest

2017-10-26 Thread Michel Thierry
Try to create as many clients as it is currently possible (currently limited to max number of doorbells) and exercise the doorbell alloc/dealloc code. Since our usage mode require very few clients/doorbells, this code has been exercised very lightly and it's good to have a simple test for it. As

Re: [Intel-gfx] [PATCH v6] drm/i915/guc: Add a second client, to be used for preemption

2017-10-26 Thread Michel Thierry
On 26/10/17 07:17, Michał Winiarski wrote: @@ -763,14 +770,14 @@ static int guc_init_doorbell_hw(struct intel_guc *guc) /* Now for every client (and not only execbuf_client) make sure their * doorbells are known by the GuC */ - //for (client = client_list; client != NULL

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Fix SSEU Device Status.

2017-10-26 Thread Rodrigo Vivi
On Thu, Oct 26, 2017 at 02:31:16PM +, Lionel Landwerlin wrote: > Since I've been looking at EU_DISABLE* in intel_device_info.c, your patch > caught my eye :) > Reading the documentation I couldn't find anything wrong. > > Reviewed-by: Lionel Landwerlin Thanks. Merged to dinq. > > On 26/10/

[Intel-gfx] ✗ Fi.CI.IGT: failure for Lib: Move __gem_context_create to common ioctl wrapper library. (rev3)

2017-10-26 Thread Patchwork
== Series Details == Series: Lib: Move __gem_context_create to common ioctl wrapper library. (rev3) URL : https://patchwork.freedesktop.org/series/31775/ State : failure == Summary == Test kms_busy: Subgroup extended-modeset-hang-newfb-with-reset-render-A: pass ->

[Intel-gfx] [GIT PULL] gvt fix for 4.14-rc6

2017-10-26 Thread Zhi Wang
Hi: Here are some fixes for 4.14-rc6. Zhenyu's patch fixes the per_ctx_bb check in GVT-g since the usage of per_ctx_bb in i915 has been changed recently. Another two patches from Xiong fix the GPU hang of linxu guest when it's running large workload. Thanks, Zhi. The following changes si

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [v6,1/3] drm/i915: Add Guc/HuC firmware details to error state

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [v6,1/3] drm/i915: Add Guc/HuC firmware details to error state URL : https://patchwork.freedesktop.org/series/32710/ State : success == Summary == Series 32710v1 series starting with [v6,1/3] drm/i915: Add Guc/HuC firmware details to error st

Re: [Intel-gfx] [PATCH v8 1/6] drm/i915 : Unifying seq_puts messages for feature support

2017-10-26 Thread Daniele Ceraolo Spurio
On 25/10/17 06:31, Michal Wajdeczko wrote: On Tue, 24 Oct 2017 19:21:20 +0200, Sujaritha Sundaresan wrote: Unifying the various seq_puts messages in debugfs to the simplest one for feature support. v2: Clarifying the commit message (Anusha) v3: Re-factoring code as per review (Michal) v4

Re: [Intel-gfx] [PATCH 1/2] drm/dp: Bit definition for D3 power state that keeps AUX fully powered

2017-10-26 Thread Pandiyan, Dhinakaran
On Thu, 2017-10-26 at 10:59 +0300, Jani Nikula wrote: > On Thu, 10 Aug 2017, Dhinakaran Pandiyan wrote: > > DPCD 600h - SET_POWER & SET_DP_PWR_VOLTAGE defines power state > > > > 101 = Set Main-Link for local Sink device and all downstream Sink > > devices to D3 (power-down mode), keep AUX block

[Intel-gfx] ✗ Fi.CI.BAT: failure for Lib: Move __gem_context_create to common ioctl wrapper library. (rev3)

2017-10-26 Thread Patchwork
== Series Details == Series: Lib: Move __gem_context_create to common ioctl wrapper library. (rev3) URL : https://patchwork.freedesktop.org/series/31775/ State : failure == Summary == IGT patchset tested on top of latest successful build 1fc4de1ca390adec9be8bd7cc0c36cab07465959 igt/gem_exec_la

[Intel-gfx] [PATCH v6 2/3] drm/i915: Make GuC log part of the uC error state

2017-10-26 Thread Michal Wajdeczko
We keep details of GuC and HuC in separate error state struct. Make GuC log part of it to group all related data together. Since we are printing uC details at the end, with this change GuC log will be moved there too. v2: comment on new placement of the log (Chris) Signed-off-by: Michal Wajdeczko

[Intel-gfx] [PATCH v6 3/3] drm/i915: Handle error-state modparams in dedicated functions

2017-10-26 Thread Michal Wajdeczko
Capturing and cleanup and modparams in error state requires some macro tricks. Move that code into separated functions for easier maintenance. Signed-off-by: Michal Wajdeczko Cc: Chris Wilson --- drivers/gpu/drm/i915/i915_gpu_error.c | 26 +- 1 file changed, 17 insertion

[Intel-gfx] [PATCH v6 1/3] drm/i915: Add Guc/HuC firmware details to error state

2017-10-26 Thread Michal Wajdeczko
Include GuC and HuC firmware details in captured error state to provide additional debug information. To reuse existing uc firmware pretty printer, introduce new drm-printer variant that works with our i915_error_state_buf output. Also update uc firmware pretty printer to accept const input. v2: d

Re: [Intel-gfx] [PATCH i-g-t] lib/igt_debugfs: Remove support for legacy CRC api.

2017-10-26 Thread James Ausmus
On Thu, Oct 26, 2017 at 01:38:51PM +0200, Maarten Lankhorst wrote: > In kernel v4.10 the legacy crc api has been replaced by a generic > drm crc API. While at it, fix igt_require_pipe_crc, the file cannot be > opened any more when the crtc is not active after kernel commit 8038e09be5a3 > ("drm/crc:

[Intel-gfx] [PATCH i-g-t v4] lib: Move __gem_context_create to common ioctl wrapper library.

2017-10-26 Thread Antonio Argenziano
This patch adds a context creation ioctl wrapper that returns the error for the caller to consume. Multiple tests that implemented this already, have been changed to use the new library function. v2: - Add gem_require_contexts() to check for contexts support (Chris) v3: - Add gem_

Re: [Intel-gfx] [RFC 00/17] Per-context and per-client engine busyness

2017-10-26 Thread Lionel Landwerlin
On 26/10/17 14:05, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-10-26 14:00:28) On 26/10/2017 10:50, Lionel Landwerlin wrote: On 26/10/17 08:34, Tvrtko Ursulin wrote: On 25/10/2017 18:38, Chris Wilson wrote: Quoting Chris Wilson (2017-10-25 16:47:13) Quoting Tvrtko Ursulin (2017-10-25 16

Re: [Intel-gfx] [PATCH v5 2/2] drm/i915: Make GuC log part of the uC error state

2017-10-26 Thread Michal Wajdeczko
On Wed, 25 Oct 2017 13:11:25 +0200, Chris Wilson wrote: Quoting Michal Wajdeczko (2017-10-25 11:41:12) We keep details of GuC and HuC in separate error state struct. Make GuC log part of it to group all related data together. The only significant change would appear to placement in error-s

[Intel-gfx] ✓ Fi.CI.IGT: success for series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible()

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible() URL : https://patchwork.freedesktop.org/series/32698/ State : success == Summary == Test kms_busy: Subgroup extended-modeset-hang-newfb-with-reset-render-C:

Re: [Intel-gfx] [PATCH] drm/i915: Cancel the modeset retry work during modeset cleanup

2017-10-26 Thread Manasi Navare
On Thu, Oct 26, 2017 at 07:33:44AM +0100, Chris Wilson wrote: > Quoting Manasi Navare (2017-10-26 02:20:04) > > During modeset cleanup on driver unload we may have a pending > > hotplug work. This needs to be cancel early during the teardown > > so that it does not fire after we have freed the conn

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Parse max HDMI TMDS clock from VBT

2017-10-26 Thread Chris Wilson
Quoting Ville Syrjälä (2017-10-26 16:51:23) > On Thu, Oct 26, 2017 at 04:44:39PM +0100, Chris Wilson wrote: > > Quoting Ville Syrjala (2017-10-26 16:14:05) > > > From: Ville Syrjälä > > > > > > Starting from version 204 VBT can specify the max TMDS clock we are > > > allowed to use with HDMI port

[Intel-gfx] ✓ Fi.CI.IGT: success for Preemption with GuC, fourth try (rev6)

2017-10-26 Thread Patchwork
== Series Details == Series: Preemption with GuC, fourth try (rev6) URL : https://patchwork.freedesktop.org/series/32654/ State : success == Summary == Test kms_busy: Subgroup extended-modeset-hang-newfb-with-reset-render-A: pass -> DMESG-WARN (shard-hsw) fdo#1022

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Remove obsolete ringbuffer emission for gen8+

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Remove obsolete ringbuffer emission for gen8+ URL : https://patchwork.freedesktop.org/series/32701/ State : failure == Summary == Series 32701v1 drm/i915: Remove obsolete ringbuffer emission for gen8+ https://patchwork.freedesktop.org/api/1.0/series/32701

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Parse max HDMI TMDS clock from VBT

2017-10-26 Thread Ville Syrjälä
On Thu, Oct 26, 2017 at 04:44:39PM +0100, Chris Wilson wrote: > Quoting Ville Syrjala (2017-10-26 16:14:05) > > From: Ville Syrjälä > > > > Starting from version 204 VBT can specify the max TMDS clock we are > > allowed to use with HDMI ports. Parse that information and take it > > into account w

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible()

2017-10-26 Thread Chris Wilson
Quoting Ville Syrjala (2017-10-26 16:14:04) > From: Ville Syrjälä > > Move the crtc state related 12bpc checks into hdmi_12bpc_possible() > since that one already examines other parts of the crtc state. > > Note that we can drop the !force_dvi check since > crtc_state->has_hdmi_sink already acco

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Parse max HDMI TMDS clock from VBT

2017-10-26 Thread Chris Wilson
Quoting Ville Syrjala (2017-10-26 16:14:05) > From: Ville Syrjälä > > Starting from version 204 VBT can specify the max TMDS clock we are > allowed to use with HDMI ports. Parse that information and take it > into account when filtering modes and computing a crtc state. > > + if (bdb_vers

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible()

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible() URL : https://patchwork.freedesktop.org/series/32698/ State : success == Summary == Series 32698v1 series starting with [1/2] drm/i915: Clean up the mess around hdmi_12bpc_possibl

Re: [Intel-gfx] [PATCH] drm/i915: Remove obsolete ringbuffer emission for gen8+

2017-10-26 Thread Chris Wilson
Quoting Chris Wilson (2017-10-26 16:31:33) > Since removing the module parameter to force selection of ringbuffer > emission for gen8, the code is defunct. Remove it. Ah, there's meant to a patch to remove the modparam first. It's not required to test this patch, just equally pointless to keep i91

[Intel-gfx] [PATCH] drm/i915: Remove obsolete ringbuffer emission for gen8+

2017-10-26 Thread Chris Wilson
submission. We have made a few improvements to lowlevel execlists throughput, and ringbuffer currently panics on boot! (bdw i7-5557u, 20171026): ring execlists exec continuous nops on all rings: n/a1.921us exec sequential nops on each

[Intel-gfx] ✓ Fi.CI.IGT: success for Preemption with GuC, fourth try (rev5)

2017-10-26 Thread Patchwork
== Series Details == Series: Preemption with GuC, fourth try (rev5) URL : https://patchwork.freedesktop.org/series/32654/ State : success == Summary == Test kms_busy: Subgroup extended-modeset-hang-oldfb-with-reset-render-A: pass -> DMESG-WARN (shard-hsw) fdo#1022

[Intel-gfx] [PATCH 1/2] drm/i915: Clean up the mess around hdmi_12bpc_possible()

2017-10-26 Thread Ville Syrjala
From: Ville Syrjälä Move the crtc state related 12bpc checks into hdmi_12bpc_possible() since that one already examines other parts of the crtc state. Note that we can drop the !force_dvi check since crtc_state->has_hdmi_sink already accounts for that. Signed-off-by: Ville Syrjälä --- drivers

[Intel-gfx] [PATCH 2/2] drm/i915: Parse max HDMI TMDS clock from VBT

2017-10-26 Thread Ville Syrjala
From: Ville Syrjälä Starting from version 204 VBT can specify the max TMDS clock we are allowed to use with HDMI ports. Parse that information and take it into account when filtering modes and computing a crtc state. Also take the opportunity to sort the platform check if ladder from new to old.

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/2] drm/i915/edp: read edp display control registers unconditionally

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915/edp: read edp display control registers unconditionally URL : https://patchwork.freedesktop.org/series/32695/ State : success == Summary == Series 32695v1 series starting with [1/2] drm/i915/edp: read edp display control regist

[Intel-gfx] ✗ Fi.CI.IGT: warning for series starting with [1/2] drm/i915: Hold rcu_read_lock when iterating over the radixtree (objects)

2017-10-26 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Hold rcu_read_lock when iterating over the radixtree (objects) URL : https://patchwork.freedesktop.org/series/32693/ State : warning == Summary == Test kms_busy: Subgroup extended-modeset-hang-newfb-with-reset-render-C:

[Intel-gfx] ✓ Fi.CI.IGT: success for lib/igt_debugfs: Remove support for legacy CRC api.

2017-10-26 Thread Patchwork
== Series Details == Series: lib/igt_debugfs: Remove support for legacy CRC api. URL : https://patchwork.freedesktop.org/series/32689/ State : success == Summary == Test kms_busy: Subgroup extended-modeset-hang-oldfb-with-reset-render-B: dmesg-warn -> PASS (shard-

Re: [Intel-gfx] [PATCH 1/2] drm/i915/edp: read edp display control registers unconditionally

2017-10-26 Thread Ville Syrjälä
On Thu, Oct 26, 2017 at 05:29:31PM +0300, Jani Nikula wrote: > Per my reading of the eDP spec, DP_DPCD_DISPLAY_CONTROL_CAPABLE bit in > DP_EDP_CONFIGURATION_CAP should be set if the eDP display control > registers starting at offset DP_EDP_DPCD_REV are "enabled". Currently we > check the bit before

[Intel-gfx] ✓ Fi.CI.IGT: success for drm/i915: Include RING_MODE when dumping the engine state

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Include RING_MODE when dumping the engine state URL : https://patchwork.freedesktop.org/series/32691/ State : success == Summary == Test kms_plane: Subgroup plane-panning-bottom-right-suspend-pipe-A-planes: skip -> PASS

[Intel-gfx] ✗ Fi.CI.BAT: warning for Preemption with GuC, fourth try (rev6)

2017-10-26 Thread Patchwork
== Series Details == Series: Preemption with GuC, fourth try (rev6) URL : https://patchwork.freedesktop.org/series/32654/ State : warning == Summary == Series 32654v6 Preemption with GuC, fourth try https://patchwork.freedesktop.org/api/1.0/series/32654/revisions/6/mbox/ Test kms_pipe_crc_bas

Re: [Intel-gfx] [PATCH] drm/i915: Add -Wall -Wextra to our build, set warnings to full

2017-10-26 Thread Jani Nikula
On Tue, 24 Oct 2017, Chris Wilson wrote: > Recently W=1 on gcc-7.2 (-Wunused-const-variable) caught a regression > that had been lurking for 6 months, so lets try enabling the full set of > warnings for CI builds. This means more patches will be rejected early > that contain trivial and sometimes

Re: [Intel-gfx] [PATCH] drm/i915: Fallback to reserve forcewake if primary ack missing

2017-10-26 Thread Chris Wilson
Quoting Mika Kuoppala (2017-10-26 15:01:44) > There is a possibility on gen9 hardware to miss the forcewake ack > message. The recommended workaround is to use another free > bit and toggle it until original bit is successfully acknowledged. > > The workaround is a bit misleadingly named as WaRsFo

Re: [Intel-gfx] [PATCH v3] drm/i915: Remove unsafe i915.enable_rc6

2017-10-26 Thread Joonas Lahtinen
On Thu, 2017-10-26 at 11:32 +0100, Chris Wilson wrote: > It has been many years since the last confirmed sighting (and fix) of an > RC6 related bug (usually a system hang). Remove the parameter to stop > users from setting dangerous values, as they often set it during triage > and end up disabling

Re: [Intel-gfx] [PATCH] drm/i915/cnl: Fix SSEU Device Status.

2017-10-26 Thread Lionel Landwerlin
Since I've been looking at EU_DISABLE* in intel_device_info.c, your patch caught my eye :) Reading the documentation I couldn't find anything wrong. Reviewed-by: Lionel Landwerlin On 26/10/17 01:15, Rodrigo Vivi wrote: CNL adds an extra register for slice/subslice information. Although no SKU

[Intel-gfx] [PATCH 2/2] drm/i915/edp: clean up code and comments around eDP DPCD read

2017-10-26 Thread Jani Nikula
Some minor drive-by cleanups. Signed-off-by: Jani Nikula --- drivers/gpu/drm/i915/intel_dp.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 158438bb0389..73b1ed8cff6b 100644 --- a/drivers/gpu/

[Intel-gfx] [PATCH 1/2] drm/i915/edp: read edp display control registers unconditionally

2017-10-26 Thread Jani Nikula
Per my reading of the eDP spec, DP_DPCD_DISPLAY_CONTROL_CAPABLE bit in DP_EDP_CONFIGURATION_CAP should be set if the eDP display control registers starting at offset DP_EDP_DPCD_REV are "enabled". Currently we check the bit before reading the registers, and DP_EDP_DPCD_REV is the only way to detect

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915: Fallback to reserve forcewake if primary ack missing

2017-10-26 Thread Patchwork
== Series Details == Series: drm/i915: Fallback to reserve forcewake if primary ack missing URL : https://patchwork.freedesktop.org/series/32694/ State : failure == Summary == Series 32694v1 drm/i915: Fallback to reserve forcewake if primary ack missing https://patchwork.freedesktop.org/api/1.

[Intel-gfx] [PATCH v6] drm/i915/guc: Add a second client, to be used for preemption

2017-10-26 Thread Michał Winiarski
From: Dave Gordon This second client is created with priority KMD_HIGH, and marked as preemptive. This will allow us to request preemption using GuC actions. v2: Extract clients creation into a helper, debugfs fixups. (Michał) Recreate doorbell on init. (Daniele) Move clients into an array. v3:

[Intel-gfx] [PATCH] drm/i915: Fallback to reserve forcewake if primary ack missing

2017-10-26 Thread Mika Kuoppala
There is a possibility on gen9 hardware to miss the forcewake ack message. The recommended workaround is to use another free bit and toggle it until original bit is successfully acknowledged. The workaround is a bit misleadingly named as WaRsForcewakeAddDelayForAck. The reason for naming is most l

[Intel-gfx] ✓ Fi.CI.BAT: success for Preemption with GuC, fourth try (rev5)

2017-10-26 Thread Patchwork
== Series Details == Series: Preemption with GuC, fourth try (rev5) URL : https://patchwork.freedesktop.org/series/32654/ State : success == Summary == Series 32654v5 Preemption with GuC, fourth try https://patchwork.freedesktop.org/api/1.0/series/32654/revisions/5/mbox/ Test kms_cursor_legac

Re: [Intel-gfx] [PATCH] drm/i915: Include RING_MODE when dumping the engine state

2017-10-26 Thread Mika Kuoppala
Chris Wilson writes: > Knowing the RING_MODE flags is useful for checking the state of the > engine, such as whether the CS is idle after trying to stop the engines > before reset. > > Signed-off-by: Chris Wilson > Cc: Mika Kuoppala > --- > drivers/gpu/drm/i915/intel_engine_cs.c | 5 + > 1

Re: [Intel-gfx] [PATCH v5] drm/i915/guc: Add a second client, to be used for preemption

2017-10-26 Thread Michal Wajdeczko
On Thu, 26 Oct 2017 15:32:31 +0200, Michał Winiarski wrote: From: Dave Gordon This second client is created with priority KMD_HIGH, and marked as preemptive. This will allow us to request preemption using GuC actions. v2: Extract clients creation into a helper, debugfs fixups. (Michał)

[Intel-gfx] ✗ Fi.CI.BAT: warning for Preemption with GuC, fourth try (rev3)

2017-10-26 Thread Patchwork
== Series Details == Series: Preemption with GuC, fourth try (rev3) URL : https://patchwork.freedesktop.org/series/32654/ State : warning == Summary == Series 32654v3 Preemption with GuC, fourth try https://patchwork.freedesktop.org/api/1.0/series/32654/revisions/3/mbox/ Test chamelium:

  1   2   >