Re: [Intel-gfx] [maintainer-tools PATCH 4/5] doc: build documentation using Sphinx

2017-08-09 Thread Jani Nikula
On Thu, 10 Aug 2017, Rodrigo Vivi wrote: > On Wed, Aug 9, 2017 at 2:08 PM, Jani Nikula wrote: >> Based on Sphinx-quickstart, with existing and generated Makefiles merged >> together. >> >> This makes the rst2html and Sphinx builds work side by side. Plain >> 'make' continues to use rst2html, and

Re: [Intel-gfx] [PATCH v3 i-g-t] tests/kms: increase max threshold time for edid read

2017-08-09 Thread Lofstedt, Marta
Sorry Clinton I fail the test again on my BDW NUCi5 with this V3. Check: https://bugs.freedesktop.org/show_bug.cgi?id=100047 For details. /Marta > -Original Message- > From: Taylor, Clinton A > Sent: Thursday, August 10, 2017 1:52 AM > To: intel-gfx@lists.freedesktop.org > Cc: Taylor, C

Re: [Intel-gfx] [maintainer-tools PATCH 6/5] doc: load WaveDrom scripts directly from CDN instead of bundling

2017-08-09 Thread Jani Nikula
On Thu, 10 Aug 2017, Rodrigo Vivi wrote: > On Wed, Aug 9, 2017 at 2:33 PM, Jani Nikula wrote: >> Way back when the WaveDrom stuff was added, the scripts could only be >> accessed over http. This caused issues with sites served over https and >> modern browsers rightly complaining about mixed cont

Re: [Intel-gfx] [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

2017-08-09 Thread Navare, Manasi D
We currently assume port A is connected to a DP sink when VBT is absent, instead assume it is connected to an eDP sink, which seems like a more common configuration. Although I don't have data to back this up, it is still just as valid as asumming port A is not eDP. This reverts to the behavior

[Intel-gfx] [PATCH i-g-t 4/4] tests/syncobj: Add some wait and reset tests (v5)

2017-08-09 Thread Jason Ekstrand
This adds both trivial error-checking tests as well as more complex tests which actually test whether or not waits do what they're supposed to do. They only currently work on i915 but it should be simple to hook them up for other drivers by simply implementing the little function pointer hook prov

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Simplify hpd pin to port

2017-08-09 Thread Pandiyan, Dhinakaran
On Wed, 2017-08-02 at 10:20 -0700, Rodrigo Vivi wrote: > We will soon need to make that pin port association per > platform, so let's try to simplify it beforehand. > > Also we are moving the backwards port to pin > here as well so let's use a standardized way. > > One extra possibility here woul

Re: [Intel-gfx] [PATCH i-g-t 8/8] tests/kms_ccs: Test CCS on sprite planes

2017-08-09 Thread Jason Ekstrand
On Tue, Aug 8, 2017 at 9:16 AM, Daniel Stone wrote: > Also try to test CCS on available non-primary planes. However, as there > is not enough bandwidth to scan out both the primary and sprite planes > when using CCS (or even Y-tiled), fall back to linear for the primary > plane when using CCS for

Re: [Intel-gfx] [PATCH i-g-t 6/8] tests/kms_ccs: Test for supported modifier

2017-08-09 Thread Jason Ekstrand
On Tue, Aug 8, 2017 at 9:16 AM, Daniel Stone wrote: > Make sure the CCS modifier is supported on our plane, before we try to > use it on that plane. > > Signed-off-by: Daniel Stone > --- > tests/kms_ccs.c | 117 ++ > +- > 1 file changed, 116 i

Re: [Intel-gfx] [PATCH] drm/i915: Introduce intel_hdp_pin.

2017-08-09 Thread Pandiyan, Dhinakaran
On Wed, 2017-08-02 at 12:26 -0700, Rodrigo Vivi wrote: > The idea is to have an unique place to decide the pin-port > per platform. > > So let's create this function now without any functional > change. This seems to change the behavior when port A is not eDP. > Just adding together code from h

Re: [Intel-gfx] [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

2017-08-09 Thread rodrigo . vivi
> On Aug 9, 2017, at 8:20 PM, Dhinakaran Pandiyan wrote: > > We currently assume port A is connected to a DP sink when VBT is absent, > instead assume it is connected to an eDP sink, which seems like a more > common configuration. Although I don't have data to back this up, > it is still just a

Re: [Intel-gfx] [PATCH] drm/i915: add register macro definition style guide

2017-08-09 Thread Pandiyan, Dhinakaran
On Fri, 2017-08-04 at 13:38 +0300, Jani Nikula wrote: > This is not to try to force a new style; this is my interpretation of > what the most common existing style is. > > With hopes I don't need to answer so many questions about style going > forward. > > Cc: Daniel Vetter > Signed-off-by: Jani

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/vbt: Assume port A is connected to eDP when there's no VBT URL : https://patchwork.freedesktop.org/series/28597/ State : success == Summary == Series 28597v1 drm/i915/vbt: Assume port A is connected to eDP when there's no VBT https://patchwork.freedesktop

[Intel-gfx] [PATCH] drm/i915/vbt: Assume port A is connected to eDP when there's no VBT

2017-08-09 Thread Dhinakaran Pandiyan
We currently assume port A is connected to a DP sink when VBT is absent, instead assume it is connected to an eDP sink, which seems like a more common configuration. Although I don't have data to back this up, it is still just as valid as asumming port A is not eDP. This reverts to the behavior bef

Re: [Intel-gfx] [PATCH v9 0/3] drm/i915/gvt: Enable guest i915 48bit full ppgtt support

2017-08-09 Thread Zhenyu Wang
On 2017.08.10 07:41:35 +0800, Tina Zhang wrote: > This patch set is used to enable guest i915 48bit full ppgtt support. > > Kechen Lu (1): > drm/i915/gvt: Add shadow context descriptor updating > > Tina Zhang (2): > drm/i915: Enable guest i915 full ppgtt functionality > drm/i915/gvt: Fix gu

Re: [Intel-gfx] linux-next: manual merge of the drm-misc tree with Linus' tree

2017-08-09 Thread Stephen Rothwell
Hi Dave, On Wed, 2 Aug 2017 12:23:06 +1000 Stephen Rothwell wrote: > > Today's linux-next merge of the drm-misc tree got a conflict in: > > drivers/gpu/drm/nouveau/nv50_display.c > > between commit: > > 4a5431af19bc ("drm/nouveau/kms/nv50: update vblank state in response to > modeset act

Re: [Intel-gfx] [PATCH] drm/vgem: Couple in drm_syncobj support

2017-08-09 Thread Jason Ekstrand
On Wed, Aug 9, 2017 at 6:23 PM, Chris Wilson wrote: > Quoting Jason Ekstrand (2017-08-10 02:02:43) > > On Wed, Aug 9, 2017 at 12:03 PM, Chris Wilson > wrote: > > > > To further facilitate GEM testing, allow testing of drm_syncobj by > > attaching them to vgem fences. These fences are alr

[Intel-gfx] [PATCH 2/4] tests/syncobj: Convert the basic test over to the helpers

2017-08-09 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- tests/syncobj_basic.c | 77 +-- 1 file changed, 19 insertions(+), 58 deletions(-) diff --git a/tests/syncobj_basic.c b/tests/syncobj_basic.c index a7a6742..b08dd2d 100644 --- a/tests/syncobj_basic.c +++ b/tests/syn

[Intel-gfx] [PATCH 3/4] lib/igt_vgem: Add a syncobj attach helper

2017-08-09 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- lib/igt_vgem.c | 25 - lib/igt_vgem.h | 1 + 2 files changed, 25 insertions(+), 1 deletion(-) diff --git a/lib/igt_vgem.c b/lib/igt_vgem.c index 21cccb3..069c6dd 100644 --- a/lib/igt_vgem.c +++ b/lib/igt_vgem.c @@ -101,8 +101,9 @@ void *

[Intel-gfx] [PATCH 1/4] lib: Add some syncobj helpers

2017-08-09 Thread Jason Ekstrand
Signed-off-by: Jason Ekstrand --- lib/Makefile.sources | 2 + lib/igt_syncobj.c| 176 +++ lib/igt_syncobj.h| 65 +++ 3 files changed, 243 insertions(+) create mode 100644 lib/igt_syncobj.c create mode 100644 lib/igt_sync

[Intel-gfx] [PATCH 4/4] tests/syncobj: Add some wait and reset tests (v4)

2017-08-09 Thread Jason Ekstrand
This adds both trivial error-checking tests as well as more complex tests which actually test whether or not waits do what they're supposed to do. They only currently work on i915 but it should be simple to hook them up for other drivers by simply implementing the little function pointer hook prov

Re: [Intel-gfx] [PATCH] drm/vgem: Couple in drm_syncobj support

2017-08-09 Thread Chris Wilson
Quoting Jason Ekstrand (2017-08-10 02:02:43) > On Wed, Aug 9, 2017 at 12:03 PM, Chris Wilson > wrote: > > To further facilitate GEM testing, allow testing of drm_syncobj by > attaching them to vgem fences. These fences are already employed by igt > for testing inter-driver fence hand

Re: [Intel-gfx] [PATCH] drm/vgem: Couple in drm_syncobj support

2017-08-09 Thread Jason Ekstrand
On Wed, Aug 9, 2017 at 12:03 PM, Chris Wilson wrote: > To further facilitate GEM testing, allow testing of drm_syncobj by > attaching them to vgem fences. These fences are already employed by igt > for testing inter-driver fence handling (across dmabuf and sync_file). > > An igt example use would

Re: [Intel-gfx] [PATCH 0/8] Adding NV12 support for SKL display

2017-08-09 Thread Hwang, Dongseong
I tested it on my Kaby Lake chromebook, and it works perfectly. Best regards, DS On Thu, Aug 3, 2017 at 6:23 PM, Hwang, Dongseong wrote: > Thank you for working on NV12 plane support. ChromeOS eagerly wants this > feature to save power on Youtube. If it's landed soon, I'll really > appreciate it

[Intel-gfx] [PATCH v9 2/3] drm/i915: Enable guest i915 full ppgtt functionality

2017-08-09 Thread Tina Zhang
Enable the guest i915 full ppgtt functionality when host can provide this capability. vgt_caps is introduced to guest i915 driver to get the vgpu capabilities from the device model. VGT_CPAS_FULL_PPGTT is one of the capabilities type to let guest i915 dirver know that the guest i915 full ppgtt is s

Re: [Intel-gfx] [PATCH i-g-t] tests/kms: increase max threshold time for edid read

2017-08-09 Thread Chris Wilson
Quoting Daniel Vetter (2017-08-07 17:20:27) > On Fri, Aug 04, 2017 at 11:23:18AM -0700, clinton.a.tay...@intel.com wrote: > > From: Clint Taylor > > > > Current 50ms max threshold timing for an EDID read is very close to the > > actual time for a 2 block HDMI EDID read of 48ms. Any delay like a c

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/kms: increase max threshold time for edid read (rev3)

2017-08-09 Thread Patchwork
== Series Details == Series: tests/kms: increase max threshold time for edid read (rev3) URL : https://patchwork.freedesktop.org/series/28399/ State : success == Summary == IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic. w

Re: [Intel-gfx] [PATCH 2/2] drm/i915/perf: Drop lockdep assert for i915_oa_init_reg_state()

2017-08-09 Thread Chris Wilson
Quoting Lionel Landwerlin (2017-08-09 23:47:20) > On 09/08/17 16:38, Chris Wilson wrote: > > This is called from execlist context init which we need to be unlocked. > > Commit f89823c21224 ("drm/i915/perf: Implement > > I915_PERF_ADD/REMOVE_CONFIG interface") added a lockdep assert to this > > path

Re: [Intel-gfx] [PATCH libdrm] drm: Remove create_handle() drm_framebuffer "virtual".

2017-08-09 Thread Joe Kniss
On Wed, Aug 9, 2017 at 12:14 PM, Noralf Trønnes wrote: > > Den 09.08.2017 01.42, skrev Joe Kniss: >> >> Because all drivers currently use gem objects for framebuffer planes, >> the virtual create_handle() is not required. This change adds a >> struct drm_gem_object *gems[4] field to drm_framebuff

Re: [Intel-gfx] [maintainer-tools PATCH 5/5] doc: use Sphinx bizstyle builtin html theme

2017-08-09 Thread Rodrigo Vivi
On Wed, Aug 9, 2017 at 2:08 PM, Jani Nikula wrote: > Matter of taste, but looks better than the default alabaster, not sure which one I preferred... alabaster goes better with 01.org... but it indeed is not very good... > and is > less trouble than requiring some external themes (such as the sph

Re: [Intel-gfx] [maintainer-tools PATCH 4/5] doc: build documentation using Sphinx

2017-08-09 Thread Rodrigo Vivi
On Wed, Aug 9, 2017 at 2:08 PM, Jani Nikula wrote: > Based on Sphinx-quickstart, with existing and generated Makefiles merged > together. > > This makes the rst2html and Sphinx builds work side by side. Plain > 'make' continues to use rst2html, and 'make html' and friends use > Sphinx. The intenti

[Intel-gfx] [PATCH v3 i-g-t] tests/kms: increase max threshold time for edid read

2017-08-09 Thread clinton . a . taylor
From: Clint Taylor Current 50ms max threshold timing for an EDID read is very close to the actual time for a 2 block HDMI EDID read. Adjust the timings base on connector type as DP reads are at 1 MBit and HDMI at 100K bit. If an LSPcon is connected to device under test the -l option should be pas

Re: [Intel-gfx] [maintainer-tools PATCH 3/5] doc: use window.onload to call WaveDrom.ProcessAll()

2017-08-09 Thread Rodrigo Vivi
I don't know WaveDrom much... but it works so Acked-by: Rodrigo Vivi On Wed, Aug 9, 2017 at 2:08 PM, Jani Nikula wrote: > Simplify the build by doing the WaveDrom processing from the rst file > (albeit raw html block) instead of post-processing the output html. > > Signed-off-by: Jani Nikula >

Re: [Intel-gfx] [maintainer-tools PATCH 2/5] build: add drm-misc-commit-flow.svg to clean target

2017-08-09 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Wed, Aug 9, 2017 at 2:08 PM, Jani Nikula wrote: > Signed-off-by: Jani Nikula > --- > Makefile | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/Makefile b/Makefile > index 784d986b18cd..8bbabae56741 100644 > --- a/Makefile > +++ b/Makefile >

[Intel-gfx] ✓ Fi.CI.BAT: success for tests/kms: increase max threshold time for edid read (rev2)

2017-08-09 Thread Patchwork
== Series Details == Series: tests/kms: increase max threshold time for edid read (rev2) URL : https://patchwork.freedesktop.org/series/28399/ State : success == Summary == IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic. w

[Intel-gfx] [PATCH v2 i-g-t] tests/kms: increase max threshold time for edid read

2017-08-09 Thread clinton . a . taylor
From: Clint Taylor Current 50ms max threshold timing for an EDID read is very close to the actual time for a 2 block HDMI EDID read. Adjust the timings base on connector type as DP reads are at 1 MBit and HDMI at 100K bit. If an LSPcon is connected to device under test the -l option should be pas

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Rename GuC irq trigger function (rev2)

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/guc: Rename GuC irq trigger function (rev2) URL : https://patchwork.freedesktop.org/series/28570/ State : success == Summary == Series 28570v2 drm/i915/guc: Rename GuC irq trigger function https://patchwork.freedesktop.org/api/1.0/series/28570/revisions/2/

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Be less aggressive about changing link config on eDP

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/edp: Be less aggressive about changing link config on eDP URL : https://patchwork.freedesktop.org/series/28588/ State : success == Summary == Series 28588v1 drm/i915/edp: Be less aggressive about changing link config on eDP https://patchwork.freedesktop.o

[Intel-gfx] [maintainer-tools PATCH 6/5] doc: load WaveDrom scripts directly from CDN instead of bundling

2017-08-09 Thread Jani Nikula
Way back when the WaveDrom stuff was added, the scripts could only be accessed over http. This caused issues with sites served over https and modern browsers rightly complaining about mixed content. This was worked around by downloading the WaveDrom scripts over http at build time, and bundling the

[Intel-gfx] [PATCH v2] drm/i915/guc: Rename GuC irq trigger function

2017-08-09 Thread Michal Wajdeczko
We should emphasize that irq raising function depends on Gen. v2: use yet another better name (Chris) Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen Cc: Chris Wilson --- drivers/gpu/drm/i915/intel_uc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/dr

[Intel-gfx] ✓ Fi.CI.BAT: success for series starting with [1/6] drm/i915/gen10+: use the SKL code for reading WM latencies

2017-08-09 Thread Patchwork
== Series Details == Series: series starting with [1/6] drm/i915/gen10+: use the SKL code for reading WM latencies URL : https://patchwork.freedesktop.org/series/28586/ State : success == Summary == Series 28586v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/28

[Intel-gfx] [PATCH v5] drm/i915/edp: Be less aggressive about changing link config on eDP

2017-08-09 Thread Jim Bride
This set of changes has some history to them. There were several attempts to add what was called "fast link training" to i915, which actually wasn't fast link training as per the DP spec. These changes were: commit 5fa836a9d859 ("drm/i915: DP link training optimization") commit 4e96c97742f4 ("dr

Re: [Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests (v3)

2017-08-09 Thread Chris Wilson
Quoting Jason Ekstrand (2017-08-09 19:49:34) > This adds both trivial error-checking tests as well as more complex > tests which actually test whether or not waits do what they're supposed > to do. They only currently work on i915 but it should be simple to hook > them up for other drivers by simp

Re: [Intel-gfx] [PATCH] drm/i915/guc: Rename GuC irq trigger function

2017-08-09 Thread Michal Wajdeczko
On Wed, Aug 09, 2017 at 09:55:03PM +0100, Chris Wilson wrote: > Quoting Michal Wajdeczko (2017-08-09 18:28:07) > > We should emphasize that irq trigger function depends on Gen. > > > > Signed-off-by: Michal Wajdeczko > > Cc: Joonas Lahtinen > > --- > > drivers/gpu/drm/i915/intel_uc.c | 4 ++-- >

[Intel-gfx] [maintainer-tools PATCH 2/5] build: add drm-misc-commit-flow.svg to clean target

2017-08-09 Thread Jani Nikula
Signed-off-by: Jani Nikula --- Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/Makefile b/Makefile index 784d986b18cd..8bbabae56741 100644 --- a/Makefile +++ b/Makefile @@ -48,6 +48,6 @@ mancheck: check: shellcheck mancheck all clean: - rm -f drm-intel.html

[Intel-gfx] [maintainer-tools PATCH 0/5] add Sphinx doc build to maintainer tools

2017-08-09 Thread Jani Nikula
Make it possible to build the maintainer tools docs using Sphinx. For now, support building using both rst2html and Sphinx. After all consumers and autobuilders of the docs have switched over to Sphinx, we can start improving the documentation to produce a more coherent and unified set of maintaine

[Intel-gfx] [maintainer-tools PATCH 4/5] doc: build documentation using Sphinx

2017-08-09 Thread Jani Nikula
Based on Sphinx-quickstart, with existing and generated Makefiles merged together. This makes the rst2html and Sphinx builds work side by side. Plain 'make' continues to use rst2html, and 'make html' and friends use Sphinx. The intention is to keep both for a transition period so that we can have

[Intel-gfx] [maintainer-tools PATCH 5/5] doc: use Sphinx bizstyle builtin html theme

2017-08-09 Thread Jani Nikula
Matter of taste, but looks better than the default alabaster, and is less trouble than requiring some external themes (such as the sphinx rtd theme used in the kernel). Signed-off-by: Jani Nikula --- conf.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/conf.py b/conf.py in

[Intel-gfx] [maintainer-tools PATCH 3/5] doc: use window.onload to call WaveDrom.ProcessAll()

2017-08-09 Thread Jani Nikula
Simplify the build by doing the WaveDrom processing from the rst file (albeit raw html block) instead of post-processing the output html. Signed-off-by: Jani Nikula --- Makefile | 6 -- drm-intel-timeline.rst | 4 drm-misc-timeline.rst | 4 3 files changed, 8 inserti

[Intel-gfx] [maintainer-tools PATCH 1/5] mancheck: run dim.rst through rst2man

2017-08-09 Thread Jani Nikula
Be strict and also require plain rst with no raw directives. Signed-off-by: Jani Nikula --- Makefile | 1 + dim.rst | 2 ++ 2 files changed, 3 insertions(+) diff --git a/Makefile b/Makefile index 44fcdc90473a..784d986b18cd 100644 --- a/Makefile +++ b/Makefile @@ -43,6 +43,7 @@ mancheck:

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/psr: Account for sink CRC raciness on some panels

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/psr: Account for sink CRC raciness on some panels URL : https://patchwork.freedesktop.org/series/28583/ State : success == Summary == Series 28583v1 drm/i915/psr: Account for sink CRC raciness on some panels https://patchwork.freedesktop.org/api/1.0/series

Re: [Intel-gfx] [PATCH] drm/i915/guc: Rename GuC irq trigger function

2017-08-09 Thread Chris Wilson
Quoting Michal Wajdeczko (2017-08-09 18:28:07) > We should emphasize that irq trigger function depends on Gen. > > Signed-off-by: Michal Wajdeczko > Cc: Joonas Lahtinen > --- > drivers/gpu/drm/i915/intel_uc.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/

[Intel-gfx] [PATCH 4/6] drm/i915/gen10: fix WM latency printing

2017-08-09 Thread Rodrigo Vivi
From: Paulo Zanoni Gen 10 is just like Gen 9, so let's consider that all the future platforms are going to be like gen 9 instead of being like gen8-. Cc: Mahesh Kumar Cc: Maarten Lankhorst Signed-off-by: Paulo Zanoni Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_pm.c | 2 +- 1

[Intel-gfx] [PATCH 1/6] drm/i915/gen10+: use the SKL code for reading WM latencies

2017-08-09 Thread Rodrigo Vivi
From: Paulo Zanoni Gen 10 should use the exact same code as Gen 9, so change the check to take this into consideration, and also assume that future platforms will run this code. Also add a MISSING_CASE(), just in case we do something wrong, instead of silently failing. Cc: Mahesh Kumar Cc: Maa

[Intel-gfx] [PATCH 5/6] drm/i915/gen10: implement gen 10 watermarks calculations

2017-08-09 Thread Rodrigo Vivi
From: Paulo Zanoni They're slightly different than the gen 9 calculations. v2: Remove TODO comment. Code matches recent spec. Cc: Mahesh Kumar Cc: Maarten Lankhorst Signed-off-by: Paulo Zanoni Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_pm.c | 21 +++-- 1 fil

[Intel-gfx] [PATCH 6/6] drm/i915/cnl: Reuse skl_wm_get_hw_state on Cannonlake.

2017-08-09 Thread Rodrigo Vivi
Otherwise it reuses the ilk that has a completely different wm. Cc: Mahesh Kumar Cc: Maarten Lankhorst Cc: Paulo Zanoni Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH 3/6] drm/i915/gen10: fix the gen 10 SAGV block time

2017-08-09 Thread Rodrigo Vivi
From: Paulo Zanoni A previous commit added CNL to intel_has_sagv(), but forgot to adjust the SAGV block time to gen 10 platforms. Cc: Mahesh Kumar Cc: Maarten Lankhorst Signed-off-by: Paulo Zanoni Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_pm.c | 13 ++--- 1 file cha

[Intel-gfx] [PATCH 2/6] drm/i915/cnl: Enable SAGV for Cannonlake.

2017-08-09 Thread Rodrigo Vivi
For now inherit from previous platforms. v2: Rebase on top of CFL. Cc: Mahesh Kumar Cc: Maarten Lankhorst Cc: Paulo Zanoni Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_pm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/d

[Intel-gfx] ✓ Fi.CI.BAT: success for igt: Add vgem_syncobj

2017-08-09 Thread Patchwork
== Series Details == Series: igt: Add vgem_syncobj URL : https://patchwork.freedesktop.org/series/28580/ State : success == Summary == IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic. with latest DRM-Tip kernel build CI_DRM

Re: [Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests (v3)

2017-08-09 Thread Chris Wilson
Quoting Jason Ekstrand (2017-08-09 19:49:34) > This adds both trivial error-checking tests as well as more complex > tests which actually test whether or not waits do what they're supposed > to do. They only currently work on i915 but it should be simple to hook > them up for other drivers by simp

[Intel-gfx] [PATCH v5] drm/i915/psr: Account for sink CRC raciness on some panels

2017-08-09 Thread Jim Bride
According to the eDP spec, when the count field in TEST_SINK_MISC increments then the six bytes of sink CRC information in the DPCD should be valid. Unfortunately, this doesn't seem to be the case on some panels, and as a result we get some incorrect and inconsistent values from the sink CRC DPCD

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/cnl: Add slice and subslice information to debugfs.

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/cnl: Add slice and subslice information to debugfs. URL : https://patchwork.freedesktop.org/series/28579/ State : success == Summary == Series 28579v1 drm/i915/cnl: Add slice and subslice information to debugfs. https://patchwork.freedesktop.org/api/1.0/se

Re: [Intel-gfx] [PATCH i-g-t 1/2] Add support for subtest-specific documentation

2017-08-09 Thread Belgaumkar, Vinay
On 8/9/2017 4:40 AM, Petri Latvala wrote: The current documentation for tests is limited to a single string per test binary. This patch adds support for documenting individual subtests. The syntax for subtest documentation is: igt_document_subtest("Frob knobs to see if one of the "

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/edp: Allow alternate fixed mode for eDP if available.

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/edp: Allow alternate fixed mode for eDP if available. URL : https://patchwork.freedesktop.org/series/28578/ State : success == Summary == Series 28578v1 drm/i915/edp: Allow alternate fixed mode for eDP if available. https://patchwork.freedesktop.org/api/1.

[Intel-gfx] [PATCH igt] igt: Add vgem_syncobj

2017-08-09 Thread Chris Wilson
Exercise the drm_syncobj / vGEM coupling. Signed-off-by: Chris Wilson --- lib/igt_vgem.c | 68 +++- lib/igt_vgem.h | 15 +++- tests/Makefile.sources | 1 + tests/vgem_syncobj.c | 212 + 4 files changed, 276 inserti

[Intel-gfx] [PATCH] drm/i915/cnl: Add slice and subslice information to debugfs.

2017-08-09 Thread Rodrigo Vivi
A missing part to EU slice power gating is the debugfs interface. This patch actually should have been squashed to the initial EU slice power gating one. v2: Initial patch was merged without this part. Fixes: c7ae7e9ab207 ("drm/i915/cnl: Configure EU slice power gating.") Cc: Joonas Lahtinen Sig

Re: [Intel-gfx] [PATCH 1/3] drm/i915/cnl: Add allowed DP rates for Cannonlake.

2017-08-09 Thread Rodrigo Vivi
Clint or Mika, could you please review this patch and next 2 here? I remember Clint telling me at some point that rates had possibly change on spec but I checked here and I still see: "eDP/DP link bit rates: 1.62, 2.16, 2.7, 3.24, 4.32, 5.4, 6.48*, 8.1* GHz" Thanks in advance, Rodrigo. On Thu, J

[Intel-gfx] [PATCH v6] drm/i915/edp: Allow alternate fixed mode for eDP if available.

2017-08-09 Thread Jim Bride
Some fixed resolution panels actually support more than one mode, with the only thing different being the refresh rate. Having this alternate mode available to us is desirable, because it allows us to test PSR on panels whose setup time at the preferred mode is too long. With this patch we allow t

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/vgem: Couple in drm_syncobj support

2017-08-09 Thread Patchwork
== Series Details == Series: drm/vgem: Couple in drm_syncobj support URL : https://patchwork.freedesktop.org/series/28576/ State : success == Summary == Series 28576v1 drm/vgem: Couple in drm_syncobj support https://patchwork.freedesktop.org/api/1.0/series/28576/revisions/1/mbox/ Test gem_exe

Re: [Intel-gfx] [PATCH libdrm] drm: Remove create_handle() drm_framebuffer "virtual".

2017-08-09 Thread Noralf Trønnes
Den 09.08.2017 01.42, skrev Joe Kniss: Because all drivers currently use gem objects for framebuffer planes, the virtual create_handle() is not required. This change adds a struct drm_gem_object *gems[4] field to drm_framebuffer and removes create_handle() function pointer from drm_framebuffer_

[Intel-gfx] ✓ Fi.CI.BAT: success for syncobj: Add some wait and reset tests (rev3)

2017-08-09 Thread Patchwork
== Series Details == Series: syncobj: Add some wait and reset tests (rev3) URL : https://patchwork.freedesktop.org/series/28567/ State : success == Summary == IGT patchset tested on top of latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic. with latest DRM

[Intel-gfx] [PATCH] drm/vgem: Couple in drm_syncobj support

2017-08-09 Thread Chris Wilson
To further facilitate GEM testing, allow testing of drm_syncobj by attaching them to vgem fences. These fences are already employed by igt for testing inter-driver fence handling (across dmabuf and sync_file). An igt example use would be like: int vgem = drm_driver_open(DRIVER_VGEM); uint32

[Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests (v3)

2017-08-09 Thread Jason Ekstrand
This adds both trivial error-checking tests as well as more complex tests which actually test whether or not waits do what they're supposed to do. They only currently work on i915 but it should be simple to hook them up for other drivers by simply implementing the little function pointer hook prov

Re: [Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests

2017-08-09 Thread Chris Wilson
Quoting Jason Ekstrand (2017-08-09 18:46:49) > On Wed, Aug 9, 2017 at 10:28 AM, Chris Wilson > wrote: > > Quoting Jason Ekstrand (2017-08-09 18:04:42) > > This adds both trivial error-checking tests as well as more complex > > tests which actually test whether or not waits do what th

Re: [Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests

2017-08-09 Thread Jason Ekstrand
On Wed, Aug 9, 2017 at 10:28 AM, Chris Wilson wrote: > > [snip] > > Key tests missing here are signal (SIGINT) handling, especially how the > timeout parameters is handled on repeats, see igt_interruptible(), though > you must use igt_ioctl(). I'll see what I can do > Polling multiple handles

[Intel-gfx] ✗ Fi.CI.BAT: failure for syncobj: Add some wait and reset tests (rev2)

2017-08-09 Thread Patchwork
== Series Details == Series: syncobj: Add some wait and reset tests (rev2) URL : https://patchwork.freedesktop.org/series/28567/ State : failure == Summary == IGT patchset build failed on latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic. make all-recurs

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Preserve SRD_CTL bit 29 on PSR init

2017-08-09 Thread Rodrigo Vivi
merged to dinq. Thanks for the patch and reviews On Wed, Aug 9, 2017 at 10:37 AM, Rodrigo Vivi wrote: > Reviewed-by: Rodrigo Vivi > > On Tue, Aug 8, 2017 at 2:51 PM, Jim Bride wrote: >> Bit 29 of SRD_CTL needs to have its value preserved according to the >> B-Spec, so right before we write out

Re: [Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests

2017-08-09 Thread Jason Ekstrand
On Wed, Aug 9, 2017 at 10:28 AM, Chris Wilson wrote: > Quoting Jason Ekstrand (2017-08-09 18:04:42) > > This adds both trivial error-checking tests as well as more complex > > tests which actually test whether or not waits do what they're supposed > > to do. They only currently work on i915 but

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915/guc: Rename GuC irq trigger function

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/guc: Rename GuC irq trigger function URL : https://patchwork.freedesktop.org/series/28570/ State : success == Summary == Series 28570v1 drm/i915/guc: Rename GuC irq trigger function https://patchwork.freedesktop.org/api/1.0/series/28570/revisions/1/mbox/

Re: [Intel-gfx] [PATCH v2] drm/i915/psr: Preserve SRD_CTL bit 29 on PSR init

2017-08-09 Thread Rodrigo Vivi
Reviewed-by: Rodrigo Vivi On Tue, Aug 8, 2017 at 2:51 PM, Jim Bride wrote: > Bit 29 of SRD_CTL needs to have its value preserved according to the > B-Spec, so right before we write out the register we go ahead and read > the register and preserve the value of that bit before we write out > the c

Re: [Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests

2017-08-09 Thread Daniel Stone
Hi Jason, On 9 August 2017 at 18:04, Jason Ekstrand wrote: > +/* One one tenth of a second */ > +#define SHORT_TIME_NSEC 1ull Er, a hundredth? Or only one, one tenth? > +static void > +test_wait_illegal_handle(int fd) > +{ > + struct drm_syncobj_wait wait = { 0 }; > + uint32

[Intel-gfx] [PATCH] drm/i915: Update from drm-next

2017-08-09 Thread Jason Ekstrand
--- include/drm/i915_drm.h | 61 ++ 1 file changed, 52 insertions(+), 9 deletions(-) diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 5ebe046..c26bf7c 100644 --- a/include/drm/i915_drm.h +++ b/include/drm/i915_drm.h @@ -412,6 +412,

[Intel-gfx] [PATCH] drm/i915/guc: Rename GuC irq trigger function

2017-08-09 Thread Michal Wajdeczko
We should emphasize that irq trigger function depends on Gen. Signed-off-by: Michal Wajdeczko Cc: Joonas Lahtinen --- drivers/gpu/drm/i915/intel_uc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_uc.c b/drivers/gpu/drm/i915/intel_uc.c index 2

Re: [Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests

2017-08-09 Thread Chris Wilson
Quoting Jason Ekstrand (2017-08-09 18:04:42) > This adds both trivial error-checking tests as well as more complex > tests which actually test whether or not waits do what they're supposed > to do. They only currently work on i915 but it should be simple to hook > them up for other drivers by simp

[Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests (v2)

2017-08-09 Thread Jason Ekstrand
This adds both trivial error-checking tests as well as more complex tests which actually test whether or not waits do what they're supposed to do. They only currently work on i915 but it should be simple to hook them up for other drivers by simply implementing the little function pointer hook prov

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Introduce intel_ddi_dp_level.

2017-08-09 Thread Vivi, Rodrigo
On Wed, 2017-08-09 at 15:20 +0300, Jani Nikula wrote: > On Tue, 08 Aug 2017, Rodrigo Vivi wrote: > > +static uint32_t intel_ddi_dp_level(struct intel_dp *intel_dp) > > Sorry to pick on specifically this patch when there continue to be > offenders all over the place... don't be sorry. I'm glad t

[Intel-gfx] ✗ Fi.CI.BAT: failure for syncobj: Add some wait and reset tests

2017-08-09 Thread Patchwork
== Series Details == Series: syncobj: Add some wait and reset tests URL : https://patchwork.freedesktop.org/series/28567/ State : failure == Summary == IGT patchset build failed on latest successful build c129026622accef6f54c0cfb0dc55e930cfa60b5 igt: add syncobj_basic. make all-recursive Mak

Re: [Intel-gfx] [PATCH v3 14/16] drm/i915/guc: Enable GuC interrupts when using CT

2017-08-09 Thread Oscar Mateo
On 08/09/2017 09:24 AM, Michal Wajdeczko wrote: We will need them in G2H communication to properly handle responses and requests from the Guc. v2: keep irq enabled while disabling GuC logging (Oscar) Signed-off-by: Michal Wajdeczko Cc: Oscar Mateo Cc: Daniele Ceraolo Spurio Cc: Michel Thie

[Intel-gfx] [PATCH i-g-t] syncobj: Add some wait and reset tests

2017-08-09 Thread Jason Ekstrand
This adds both trivial error-checking tests as well as more complex tests which actually test whether or not waits do what they're supposed to do. They only currently work on i915 but it should be simple to hook them up for other drivers by simply implementing the little function pointer hook prov

Re: [Intel-gfx] [RFC i-g-t] tests/gem_exec_basic: Documentation for subtests

2017-08-09 Thread Belgaumkar, Vinay
On 8/9/2017 7:32 AM, Arkadiusz Hiler wrote: On Tue, Aug 08, 2017 at 03:09:00PM -0700, Vinay Belgaumkar wrote: This is an RFC for adding documentation to IGT subtests. Each subtest can have something similar to a WHAT - explaining what the subtest actually does, and a WHY - which explains a use

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Supply the engine-id for our mock_engine()

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915: Supply the engine-id for our mock_engine() URL : https://patchwork.freedesktop.org/series/28565/ State : success == Summary == Series 28565v1 drm/i915: Supply the engine-id for our mock_engine() https://patchwork.freedesktop.org/api/1.0/series/28565/revis

Re: [Intel-gfx] [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-09 Thread Alex Williamson
On Wed, 9 Aug 2017 08:31:00 + "Zhang, Tina" wrote: > > -Original Message- > > From: intel-gvt-dev [mailto:intel-gvt-dev-boun...@lists.freedesktop.org] On > > Behalf Of Alex Williamson > > Sent: Tuesday, August 8, 2017 1:43 AM > > To: Zhang, Tina > > Cc: Tian, Kevin ; intel-gfx@lists.

[Intel-gfx] [PATCH] drm/i915: Supply the engine-id for our mock_engine()

2017-08-09 Thread Chris Wilson
In the initial selftest, we didn't care what the engine->id was, just that it could uniquely identify it. Later though, we started tracking in the fixed size arrays around the drm_i915_private and so we now require it to be appropriate. This becomes an issue when using the standalone harness of run

[Intel-gfx] [PATCH v3 14/16] drm/i915/guc: Enable GuC interrupts when using CT

2017-08-09 Thread Michal Wajdeczko
We will need them in G2H communication to properly handle responses and requests from the Guc. v2: keep irq enabled while disabling GuC logging (Oscar) Signed-off-by: Michal Wajdeczko Cc: Oscar Mateo Cc: Daniele Ceraolo Spurio Cc: Michel Thierry --- drivers/gpu/drm/i915/i915_guc_submission.c

Re: [Intel-gfx] [PATCH 6/8] dmi: Move memdev_dmi_entry definition to dmi.h (v2)

2017-08-09 Thread Matt Roper
On Mon, Jul 31, 2017 at 10:36:05AM +0200, Jean Delvare wrote: > Hi Matt, Mauro, > > On Thu, 17 Mar 2016 15:18:20 +0100, Jean Delvare wrote: > > On Tue, 8 Mar 2016 10:32:37 -0800, Matt Roper wrote: > > > A couple of the EDAC drivers have a nice memdev_dmi_entry structure for > > > decoding DMI mem

[Intel-gfx] ✗ Fi.CI.BAT: failure for drm/i915/perf: Drop redundant check for perf.initialised on reset

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/perf: Drop redundant check for perf.initialised on reset URL : https://patchwork.freedesktop.org/series/28564/ State : failure == Summary == CHK include/config/kernel.release CHK include/generated/uapi/linux/version.h CHK include/generate

[Intel-gfx] [PATCH] drm/i915/perf: Drop redundant check for perf.initialised on reset

2017-08-09 Thread Chris Wilson
As we cannot have an exclusive stream set if the perf has not been initialized, we only need to check for that exclusive stream. Signed-off-by: Chris Wilson Cc: Lionel Landwerlin Cc: Matthew Auld --- drivers/gpu/drm/i915/i915_perf.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-)

[Intel-gfx] [PATCH 1/2] drm/i915/perf: Initialise dynamic sysfs group before creation

2017-08-09 Thread Chris Wilson
Another case where we need to call sysfs_attr_init() to setup the internal lockdep class prior to use: [9.325229] BUG: key 880168bc7bb0 not in .data! [9.325240] DEBUG_LOCKS_WARN_ON(1) [9.325250] [ cut here ] [9.325280] WARNING: CPU: 1 PID: 275 at kernel/

[Intel-gfx] [PATCH 2/2] drm/i915/perf: Drop lockdep assert for i915_oa_init_reg_state()

2017-08-09 Thread Chris Wilson
This is called from execlist context init which we need to be unlocked. Commit f89823c21224 ("drm/i915/perf: Implement I915_PERF_ADD/REMOVE_CONFIG interface") added a lockdep assert to this path for unclear reasons, remove it again! Fixes: 701f8231a2fe ("drm/i915/perf: prune OA configs") Signed-of

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915/perf: Initialise dynamic sysfs group before creation

2017-08-09 Thread Patchwork
== Series Details == Series: drm/i915/perf: Initialise dynamic sysfs group before creation URL : https://patchwork.freedesktop.org/series/28560/ State : warning == Summary == Series 28560v1 drm/i915/perf: Initialise dynamic sysfs group before creation https://patchwork.freedesktop.org/api/1.0/

Re: [Intel-gfx] [PATCH] drm/i915/perf: Initialise dynamic sysfs group before creation

2017-08-09 Thread Lionel Landwerlin
On 09/08/17 16:14, Lionel Landwerlin wrote: On 09/08/17 16:02, Chris Wilson wrote: Quoting Lionel Landwerlin (2017-08-09 15:57:59) Right, that's exactly what I was asking in our previous exchange. I just follow the traces, and am internally screaming at how much we are stuffing inside drm_i915

  1   2   >