We currently assume port A is connected to a DP sink when VBT is absent, 
instead assume it is connected to an eDP sink, which seems like a more common 
configuration. Although I don't have data to back this up, it is still just as 
valid as asumming port A is not eDP. This reverts to the behavior before 
a98d9c1 ("drm/i915/ddi: Rely on VBT DDI port info for eDP detection") except 
only when there is no VBT. Knowing whether a panel is eDP or not from the panel 
itself would have been nicer, but I cannot find any DPCD registers that provide 
this reliably.

Cc: Jani Nikula <jani.nik...@intel.com>
Cc: Imre Deak <imre.d...@intel.com>
Cc: Rodrigo Vivi <rodrigo.v...@intel.com>
Cc: Clint Taylor <clinton.a.tay...@intel.com>

Signed-off-by: Dhinakaran Pandiyan <dhinakaran.pandi...@intel.com>

Is this patch trying to fix a specific bug? Where do you plan to use 
supports_edp flag? 
I guess I am trying to understand the need for this in the vbt missing defaults 
and what this patch is trying to solve here. 

Manasi


---
 drivers/gpu/drm/i915/intel_bios.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/gpu/drm/i915/intel_bios.c 
b/drivers/gpu/drm/i915/intel_bios.c
index 82b144c..89a405e 100644
--- a/drivers/gpu/drm/i915/intel_bios.c
+++ b/drivers/gpu/drm/i915/intel_bios.c
@@ -1403,6 +1403,7 @@ init_vbt_missing_defaults(struct drm_i915_private 
*dev_priv)
                info->supports_dvi = (port != PORT_A && port != PORT_E);
                info->supports_hdmi = info->supports_dvi;
                info->supports_dp = (port != PORT_E);
+               info->supports_edp = (port == PORT_A);

        }
 }
 
--
2.7.4

_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx

Reply via email to