[Intel-gfx] [PATCH i-g-t v2] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Mika Kahola
kms_plane_multiple wrongly expected that igt lib function would modify the passed igt_crc_t* object. You should use igt_crc_t** instead. This patch fixes this anomaly in the test. While at it, remove unnecesary struct for test data as we only need reference CRC here. The problem was caught by CI

Re: [Intel-gfx] [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-02 Thread Alex Williamson
On Thu, 3 Aug 2017 03:17:09 + "Zhang, Tina" wrote: > > -Original Message- > > From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf > > Of > > Alex Williamson > > Sent: Wednesday, August 2, 2017 5:18 AM > > To: Zhang, Tina > > Cc: Tian, Kevin ; kra...@redhat.com

Re: [Intel-gfx] [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-02 Thread Zhang, Tina
> -Original Message- > From: dri-devel [mailto:dri-devel-boun...@lists.freedesktop.org] On Behalf Of > Alex Williamson > Sent: Wednesday, August 2, 2017 5:18 AM > To: Zhang, Tina > Cc: Tian, Kevin ; kra...@redhat.com; intel- > g...@lists.freedesktop.org; Wang, Zhi A ; > kwankh...@nvidia.

Re: [Intel-gfx] [PATCH 3/4] drm: Only lastclose on unload for legacy drivers

2017-08-02 Thread Daniel Vetter
On Wed, Aug 2, 2017 at 10:50 PM, Alex Deucher wrote: > On Wed, Aug 2, 2017 at 7:56 AM, Daniel Vetter wrote: >> The only thing modern drivers are supposed to do in lastclose is >> restore the fb emulation state. Which is entirely optional, and >> there's really no reason to do that. So restrict it

Re: [Intel-gfx] [PATCH 3/4] lib/scatterlist: Introduce and export __sg_alloc_table_from_pages

2017-08-02 Thread Andrew Morton
On Wed, 2 Aug 2017 14:06:39 +0100 Tvrtko Ursulin wrote: > > Hi Andrew, > > We have a couple of small lib/scatterlist.c tidies here, plus exporting > the new API which allows drivers to control the maximum coalesced entry > as created by __sg_alloc_table_from_pages. > > I am looking for an a

[Intel-gfx] [PATCH] tests/kms_cursor_legacy: use 'enum pipe' type instead of 'int'

2017-08-02 Thread Gustavo Padovan
From: Gustavo Padovan Signed-off-by: Gustavo Padovan --- tests/kms_cursor_legacy.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/tests/kms_cursor_legacy.c b/tests/kms_cursor_legacy.c index 8180b04..15208f8 100644 --- a/tests/kms_cursor_legacy.c +++ b/tests/kms_curs

Re: [Intel-gfx] [PATCH 19/24] drm/i915/scheduler: Support user-defined priorities

2017-08-02 Thread Jason Ekstrand
On Thu, May 18, 2017 at 2:46 AM, Chris Wilson wrote: > Use a priority stored in the context as the initial value when > submitting a request. This allows us to change the default priority on a > per-context basis, allowing different contexts to be favoured with GPU > time at the expense of lower

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Implement .get_format_info() hook for CCS

2017-08-02 Thread Jason Ekstrand
Drp... replied to an old patch. The userspace mesa patches to produce Y_TILED_CCS surfaces have been reviewed for a couple of weeks now. So long as kmscube counts as userspace, I think this should be good to land. Acked-by: Jason Ekstrand On Tue, Aug 1, 2017 at 9:58 AM, Ben Widawsky wrote: >

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Implement .get_format_info() hook for CCS

2017-08-02 Thread Jason Ekstrand
The userspace mesa patches to produce Y_TILED_CCS surfaces have been reviewed for a couple of weeks now. So long as kmscube counts as userspace, I think this should be good to land. Acked-by: Jason Ekstrand On Mon, Jul 31, 2017 at 12:04 AM, Vidya Srinivas wrote: > From: Ville Syrjälä > > SKL

Re: [Intel-gfx] [PATCH 3/4] drm: Only lastclose on unload for legacy drivers

2017-08-02 Thread Alex Deucher
On Wed, Aug 2, 2017 at 7:56 AM, Daniel Vetter wrote: > The only thing modern drivers are supposed to do in lastclose is > restore the fb emulation state. Which is entirely optional, and > there's really no reason to do that. So restrict it to legacy drivers > (where the driver cleanup essentially

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Simplify hpd pin to port (rev2)

2017-08-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Simplify hpd pin to port (rev2) URL : https://patchwork.freedesktop.org/series/28261/ State : failure == Summary == Series 28261v2 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/28261/revisions/2/mb

[Intel-gfx] [PATCH] drm/i915: Introduce intel_hdp_pin.

2017-08-02 Thread Rodrigo Vivi
The idea is to have an unique place to decide the pin-port per platform. So let's create this function now without any functional change. Just adding together code from hdmi and dp together. v2: Add missing pin for port A. Cc: Ville Syrjälä Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: enable WaDisableDopClkGating for gen9

2017-08-02 Thread Rodrigo Vivi
On Wed, Aug 2, 2017 at 10:34 AM, Praveen Paneri wrote: > This WA is required when decoupled frequencies for slice and unslice > are enabled. This disables DOP clock gating for gen9. > > v2: enable the WA for all gen9 platforms (not just for SKL GT4 where > the hang issue is originally reported

[Intel-gfx] ✗ Fi.CI.BAT: warning for drm/i915: enable WaDisableDopClkGating for SKL GT4 (rev2)

2017-08-02 Thread Patchwork
== Series Details == Series: drm/i915: enable WaDisableDopClkGating for SKL GT4 (rev2) URL : https://patchwork.freedesktop.org/series/28068/ State : warning == Summary == Series 28068v2 drm/i915: enable WaDisableDopClkGating for SKL GT4 https://patchwork.freedesktop.org/api/1.0/series/28068/re

[Intel-gfx] ✗ Fi.CI.BAT: failure for series starting with [1/2] drm/i915: Simplify hpd pin to port

2017-08-02 Thread Patchwork
== Series Details == Series: series starting with [1/2] drm/i915: Simplify hpd pin to port URL : https://patchwork.freedesktop.org/series/28261/ State : failure == Summary == Series 28261v1 Series without cover letter https://patchwork.freedesktop.org/api/1.0/series/28261/revisions/1/mbox/ Te

[Intel-gfx] [PATCH] drm/i915: enable WaDisableDopClkGating for gen9

2017-08-02 Thread Praveen Paneri
This WA is required when decoupled frequencies for slice and unslice are enabled. This disables DOP clock gating for gen9. v2: enable the WA for all gen9 platforms (not just for SKL GT4 where the hang issue is originally reported) to avoid rare hangs (David) Cc: David Weinehall Reviewed-by:

[Intel-gfx] [PATCH 1/2] drm/i915: Simplify hpd pin to port

2017-08-02 Thread Rodrigo Vivi
We will soon need to make that pin port association per platform, so let's try to simplify it beforehand. Also we are moving the backwards port to pin here as well so let's use a standardized way. One extra possibility here would be to add a MISSING_CASE along with PORT_NONE, but I don't want to

[Intel-gfx] [PATCH 2/2] drm/i915: Introduce intel_hdp_pin.

2017-08-02 Thread Rodrigo Vivi
The idea is to have an unique place to decide the pin-port per platform. So let's create this function now without any functional change. Just adding together code from hdmi and dp together. Cc: Ville Syrjälä Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/

Re: [Intel-gfx] [PATCH] drm/i915: Fix PCH names for KBP and CNP.

2017-08-02 Thread Srivatsa, Anusha
Reviewed-by: Anusha Srivatsa >-Original Message- >From: Vivi, Rodrigo >Sent: Monday, July 31, 2017 12:10 PM >To: Zanoni, Paulo R >Cc: intel-gfx@lists.freedesktop.org; Srivatsa, Anusha > >Subject: Re: [PATCH] drm/i915: Fix PCH names for KBP and CNP. > >On Mon, 2017-07-31 at 16:05 -0300, P

Re: [Intel-gfx] [PATCH] drm/i915: enable WaDisableDopClkGating for SKL GT4

2017-08-02 Thread David Weinehall
On Sat, Jul 29, 2017 at 10:29:00AM +0530, Praveen Paneri wrote: > This WA is required when decopled frequencies for slice > and unslice are enabled. This disables DOP clock gating > for SKL GT4. > > Cc: David Weinehall > Signed-off-by: Praveen Paneri Tested to fix hangs on GT4; I would suggest

Re: [Intel-gfx] [PATCH v13 5/7] vfio: ABI for mdev display dma-buf operation

2017-08-02 Thread Kirti Wankhede
On 8/2/2017 2:48 AM, Alex Williamson wrote: > On Tue, 25 Jul 2017 17:28:18 +0800 > Tina Zhang wrote: > >> Add VFIO_DEVICE_QUERY_GFX_PLANE ioctl command to let user mode query and >> get the plan and its related information. >> >> The dma-buf's life cycle is handled by user mode and tracked by k

[Intel-gfx] [RFC v4] drm/hdcp: drm enum property for CP State

2017-08-02 Thread Ramalingam C
Default connector property called "Content Protection" is added to represent the content protection state of a connector and to configure the same. Userspace can request for enable or disable of content protection on a connector. Set "DESIRED" for Enable and "UNDESIRED" for disable. Content prote

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers

2017-08-02 Thread Ben Widawsky
On 17-08-02 12:14:15, Daniel Vetter wrote: On Tue, Aug 01, 2017 at 09:14:50AM -0700, Ben Widawsky wrote: On 17-07-31 10:29:55, Daniel Vetter wrote: > On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote: > > On 17-07-29 13:53:10, Daniel Stone wrote: > > > Hi Ben, > > > > > > On 26 July 2

Re: [Intel-gfx] [RFC v3] drm/hdcp: drm enum property for CP State

2017-08-02 Thread Ramalingam C
On Wednesday 26 July 2017 11:24 PM, Sean Paul wrote: On Wed, Jul 26, 2017 at 12:51 PM, C, Ramalingam wrote: -Original Message- From: Sean Paul [mailto:seanp...@chromium.org] Sent: Wednesday, July 26, 2017 8:23 PM To: C, Ramalingam Cc: Sean Paul ; Vetter, Daniel ; Intel Graphics Devel

Re: [Intel-gfx] [PATCH] drm/i915: Use AUX for backlight only if eDP 1.4 or later

2017-08-02 Thread David Weinehall
On 2017-08-02 02:15, Pandiyan, Dhinakaran wrote: On Mon, 2017-07-31 at 15:41 -0700, Puthikorn Voravootivat wrote: But now you're suggesting another arbitrary narrow selection of panels based on limited evidence. I understand your point that the panel I observe is not the representative of the

Re: [Intel-gfx] [PATCH v9 6/6] drm/i915/perf: Implement I915_PERF_ADD/REMOVE_CONFIG interface

2017-08-02 Thread Datczuk, Andrzej
Reviewed-by: Andrzej Datczuk -Original Message- From: Landwerlin, Lionel G Sent: Wednesday, August 2, 2017 12:22 PM To: intel-gfx@lists.freedesktop.org Cc: Landwerlin, Lionel G ; Auld, Matthew ; Datczuk, Andrzej Subject: [PATCH v9 6/6] drm/i915/perf: Implement I915_PERF_ADD/REMOVE_CONF

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Mika Kahola
On Wed, 2017-08-02 at 15:42 +0300, Petri Latvala wrote: > After a bit of digging into this n_words conundrum that I also could > not understand, I found the issue Mika described. > > kms_plane_multiple et al basically do > > igt_crc_t crc; > > > and then they pass &crc to test-internal helper f

Re: [Intel-gfx] [RFC i-g-t 2/2] tools/intel_engine_stats: Just a demo

2017-08-02 Thread Tvrtko Ursulin
On 02/08/2017 14:02, Chris Wilson wrote: Quoting Tvrtko Ursulin (2017-08-02 13:33:12) diff --git a/tools/intel_engine_stats.c b/tools/intel_engine_stats.c new file mode 100644 index ..24dbb1eb6a57 --- /dev/null +++ b/tools/intel_engine_stats.c @@ -0,0 +1,40 @@ +#include +#include

Re: [Intel-gfx] [PATCH 3/4] lib/scatterlist: Introduce and export __sg_alloc_table_from_pages

2017-08-02 Thread Tvrtko Ursulin
Hi Andrew, We have a couple of small lib/scatterlist.c tidies here, plus exporting the new API which allows drivers to control the maximum coalesced entry as created by __sg_alloc_table_from_pages. I am looking for an ack to merge these three patches via the drm-intel tree. Regards, Tvrtko

Re: [Intel-gfx] [RFC i-g-t 2/2] tools/intel_engine_stats: Just a demo

2017-08-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-08-02 13:33:12) > diff --git a/tools/intel_engine_stats.c b/tools/intel_engine_stats.c > new file mode 100644 > index ..24dbb1eb6a57 > --- /dev/null > +++ b/tools/intel_engine_stats.c > @@ -0,0 +1,40 @@ > +#include > +#include > +#include > +#include > +

Re: [Intel-gfx] [RFC i-g-t 2/2] tools/intel_engine_stats: Just a demo

2017-08-02 Thread Petri Latvala
On Wed, Aug 02, 2017 at 01:33:12PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > Signed-off-by: Tvrtko Ursulin > --- > tools/Makefile.sources | 1 + > tools/intel_engine_stats.c | 40 > 2 files changed, 41 insertions(+) > create mode 1006

Re: [Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-02 Thread Tvrtko Ursulin
Hi Peter, We are trying to expose some software PMU events from the i915 driver. Things like GPU engine busyness, power usage and similar. There is quite a bit of opens regarding usage of the perf API and so on. Would you be able to snoop around the below patch and help with answering some

Re: [Intel-gfx] [RFC i-g-t 1/2] intel-gpu-overlay: Use new class/instance based PMU API

2017-08-02 Thread Petri Latvala
Uses new uapi tokens, please add those as LOCAL_* definitions. -- Petri Latvala On Wed, Aug 02, 2017 at 01:33:11PM +0100, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > So it works with the i915 PMU RFC kernel patches. > > Signed-off-by: Tvrtko Ursulin > --- > overlay/gem-interrupts.c |

[Intel-gfx] ✗ Fi.CI.BAT: warning for i915 PMU and engine busy stats (rev2)

2017-08-02 Thread Patchwork
== Series Details == Series: i915 PMU and engine busy stats (rev2) URL : https://patchwork.freedesktop.org/series/27488/ State : warning == Summary == Series 27488v2 i915 PMU and engine busy stats https://patchwork.freedesktop.org/api/1.0/series/27488/revisions/2/mbox/ Test kms_busy:

Re: [Intel-gfx] [RFC i-g-t 1/2] intel-gpu-overlay: Use new class/instance based PMU API

2017-08-02 Thread Chris Wilson
Quoting Tvrtko Ursulin (2017-08-02 13:33:11) > @@ -67,39 +62,53 @@ static int perf_i915_open(int config, int group) > > static int perf_init(struct gpu_top *gt) > { > - const char *names[] = { > - "RCS", > - "BCS", > - "VCS0", > - "V

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Petri Latvala
After a bit of digging into this n_words conundrum that I also could not understand, I found the issue Mika described. kms_plane_multiple et al basically do igt_crc_t crc; and then they pass &crc to test-internal helper functions, which pass the igt_crc_t* pointer to various igt lib functions.

[Intel-gfx] [RFC 10/10] drm/i915: Gate engine stats collection with a static key

2017-08-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin This reduces the cost of the software engine busyness tracking to a single no-op instruction when there are no listeners. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_engine_cs.c | 17 +++ drivers/gpu/drm/i915/intel_ringbuffer.h | 54 ++

[Intel-gfx] [RFC i-g-t 2/2] tools/intel_engine_stats: Just a demo

2017-08-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Signed-off-by: Tvrtko Ursulin --- tools/Makefile.sources | 1 + tools/intel_engine_stats.c | 40 2 files changed, 41 insertions(+) create mode 100644 tools/intel_engine_stats.c diff --git a/tools/Makefile.sources b/tools/Makef

[Intel-gfx] [RFC 08/10] drm/i915: Export engine busy stats in debugfs

2017-08-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Export the stats added in the previous patch in debugfs. Number of active clients reading this data is tracked and the static key is only enabled whilst there are some. Userspace is intended to keep the file descriptor open, seeking to the beginning of the file periodically

[Intel-gfx] [RFC 04/10] drm/i915: Expose a PMU interface for perf queries

2017-08-02 Thread Tvrtko Ursulin
From: Chris Wilson The first goal is to be able to measure GPU (and invidual ring) busyness without having to poll registers from userspace. (Which not only incurs holding the forcewake lock indefinitely, perturbing the system, but also runs the risk of hanging the machine.) As an alternative we

[Intel-gfx] [RFC 07/10] drm/i915: Engine busy time tracking

2017-08-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Track total time requests have been executing on the hardware. We add new kernel API to allow software tracking of time GPU engines are spending executing requests. Both per-engine and global API is added with the latter also being exported for use by external users. v2:

[Intel-gfx] [RFC i-g-t 0/2] IGT PMU support

2017-08-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Two patches which enable intel-gpu-overlay to work with the i915 PMU RFC, plus a simple tool which reads engine busyness from debugfs. Tvrtko Ursulin (2): intel-gpu-overlay: Use new class/instance based PMU API tools/intel_engine_stats: Just a demo overlay/gem-interrup

[Intel-gfx] [RFC i-g-t 1/2] intel-gpu-overlay: Use new class/instance based PMU API

2017-08-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin So it works with the i915 PMU RFC kernel patches. Signed-off-by: Tvrtko Ursulin --- overlay/gem-interrupts.c | 2 +- overlay/gpu-freq.c | 4 +-- overlay/gpu-top.c| 51 +--- overlay/perf.h | 68 ++

[Intel-gfx] [RFC 09/10] drm/i915/pmu: Wire up engine busy stats to PMU

2017-08-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin We can use engine busy stats instead of the MMIO sampling timer for better efficiency. As minimum this saves period * num_engines / sec mmio reads, and in a better case, when only engine busy samplers are active, it enables us to not kick off the sampling timer at all. v2:

[Intel-gfx] [RFC 05/10] drm/i915/pmu: Suspend sampling when GPU is idle

2017-08-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin If only a subset of events is enabled we can afford to suspend the sampling timer when the GPU is idle and so save some cycles and power. v2: Rebase and limit timer even more. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 5 drivers/gpu

[Intel-gfx] [RFC 03/10] drm/i915: Extract intel_get_cagf

2017-08-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Code to be shared between debugfs and the PMU implementation. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c | 8 +--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_pm.c | 14 ++ 3 files changed, 16 inser

[Intel-gfx] [RFC 06/10] drm/i915: Wrap context schedule notification

2017-08-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin No functional change just something which will be handy in the following patch. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_lrc.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_lrc.c b/driv

[Intel-gfx] [RFC 02/10] drm/i915: Add intel_energy_uJ

2017-08-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Extract code from i915_energy_uJ (debugfs) so it can be used by other callers in future patches. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_debugfs.c | 14 +- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/intel_pm.c | 20

[Intel-gfx] [RFC 01/10] drm/i915: Convert intel_rc6_residency_us to ns

2017-08-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Will be used for exposing the PMU counters. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/i915_drv.h | 8 +++- drivers/gpu/drm/i915/intel_pm.c | 23 +-- 2 files changed, 16 insertions(+), 15 deletions(-) diff --git a/drivers/gpu/drm/i915/

[Intel-gfx] [RFC v2 00/10] i915 PMU and engine busy stats

2017-08-02 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Second spin of the i915 PMU series. This version squashes the fixups I was making against Chris' original PMU prototype into patch 4 itself. Main changes in the core patch are: * Convert to class/instance uAPI. * Refactor some code to helpers for clarity. * Skip sampling

[Intel-gfx] ✓ Fi.CI.BAT: success for drm unplugging docs

2017-08-02 Thread Patchwork
== Series Details == Series: drm unplugging docs URL : https://patchwork.freedesktop.org/series/28249/ State : success == Summary == Series 28249v1 drm unplugging docs https://patchwork.freedesktop.org/api/1.0/series/28249/revisions/1/mbox/ Test kms_flip: Subgroup basic-flip-vs-modese

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Mika Kahola
On Wed, 2017-08-02 at 14:16 +0200, Daniel Vetter wrote: > On Wed, Aug 2, 2017 at 2:06 PM, Mika Kahola > wrote: > > > > On Wed, 2017-08-02 at 13:36 +0200, Daniel Vetter wrote: > > > > > > On Mon, Jul 31, 2017 at 09:04:50AM +, Kahola, Mika wrote: > > > > > > > > > > > > > > > > > > > > > >

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Daniel Vetter
On Wed, Aug 2, 2017 at 2:06 PM, Mika Kahola wrote: > On Wed, 2017-08-02 at 13:36 +0200, Daniel Vetter wrote: >> On Mon, Jul 31, 2017 at 09:04:50AM +, Kahola, Mika wrote: >> > >> > > >> > > -Original Message- >> > > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On >> > >

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Mika Kahola
On Wed, 2017-08-02 at 13:36 +0200, Daniel Vetter wrote: > On Mon, Jul 31, 2017 at 09:04:50AM +, Kahola, Mika wrote: > > > > > > > > -Original Message- > > > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On > > > Behalf Of > > > Daniel Vetter > > > Sent: Monday, July 31,

[Intel-gfx] [PATCH 3/4] drm: Only lastclose on unload for legacy drivers

2017-08-02 Thread Daniel Vetter
The only thing modern drivers are supposed to do in lastclose is restore the fb emulation state. Which is entirely optional, and there's really no reason to do that. So restrict it to legacy drivers (where the driver cleanup essentially happens in lastclose). This will also allow us to share the u

[Intel-gfx] [PATCH 4/4] drm: Clean up drm_dev_unplug

2017-08-02 Thread Daniel Vetter
Use drm_dev_unregister to unregister the interfaces, which also allows us to simplify the open_count == 0 case. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_drv.c | 15 +++ 1 file changed, 3 insertions(+), 12 deletions(-) diff --git a/drivers/gpu/drm/drm_drv.c b/drivers/gpu/

[Intel-gfx] [PATCH 2/4] drm: Document device unplug infrastructure

2017-08-02 Thread Daniel Vetter
While at it, also ocd and give them a consistent drm_dev_ prefix, like the other device instance functionality. Plus move the functions into the right places. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/drm_drv.c | 24 +--- drivers/gpu/drm/drm_file.c

[Intel-gfx] [PATCH 0/4] drm unplugging docs

2017-08-02 Thread Daniel Vetter
Hi all, Just a small cleanup plus kerneldoc for the unplug support. There's still the fundamental problem that most likely our lifetime stuff is entirely screwed up for this, at least never export a dma-buf or dma-fence from a driver which can be hot-unplugged. It'd be sweet if we could properly

[Intel-gfx] [PATCH 1/4] drm: Extract drm_device.h

2017-08-02 Thread Daniel Vetter
I need this to untangle an include loop in the next patch. Signed-off-by: Daniel Vetter --- include/drm/drmP.h | 175 +-- include/drm/drm_device.h | 190 +++ 2 files changed, 191 insertions(+), 174 deletion

[Intel-gfx] ✓ Fi.CI.BAT: success for drm/i915: Explain nonlinearity of space-time^W requests

2017-08-02 Thread Patchwork
== Series Details == Series: drm/i915: Explain nonlinearity of space-time^W requests URL : https://patchwork.freedesktop.org/series/28239/ State : success == Summary == Series 28239v1 drm/i915: Explain nonlinearity of space-time^W requests https://patchwork.freedesktop.org/api/1.0/series/28239

[Intel-gfx] ✓ Fi.CI.BAT: success for Add support for loadable OA configs

2017-08-02 Thread Patchwork
== Series Details == Series: Add support for loadable OA configs URL : https://patchwork.freedesktop.org/series/28235/ State : success == Summary == Series 28235v1 Add support for loadable OA configs https://patchwork.freedesktop.org/api/1.0/series/28235/revisions/1/mbox/ fcb630a80579faf6d12

Re: [Intel-gfx] [PATCH] drm/i915: Update the status of connector when receiving MST unplug event

2017-08-02 Thread Daniel Vetter
On Wed, Aug 02, 2017 at 01:49:18AM +, Pandiyan, Dhinakaran wrote: > > On Tue, 2017-08-01 at 16:51 +0800, Ethan Hsieh wrote: > > We do not update the status of connector when receiving MST unplug event. > > Call detect function to get latest status and then update status of > > connector. > >

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Lofstedt, Marta
FYI, bug 101907 > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Daniel Vetter > Sent: Wednesday, August 2, 2017 2:37 PM > To: Kahola, Mika > Cc: intel-gfx > Subject: Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix > refe

Re: [Intel-gfx] [PATCH i-g-t] tests/kms_plane_multiple: Fix reference CRC

2017-08-02 Thread Daniel Vetter
On Mon, Jul 31, 2017 at 09:04:50AM +, Kahola, Mika wrote: > > -Original Message- > > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of > > Daniel Vetter > > Sent: Monday, July 31, 2017 11:13 AM > > To: Kahola, Mika > > Cc: intel-gfx > > Subject: Re: [Intel-gfx]

[Intel-gfx] ✗ Fi.CI.BAT: warning for Add support for loadable OA configs

2017-08-02 Thread Patchwork
== Series Details == Series: Add support for loadable OA configs URL : https://patchwork.freedesktop.org/series/28235/ State : warning == Summary == Series 28235v1 Add support for loadable OA configs https://patchwork.freedesktop.org/api/1.0/series/28235/revisions/1/mbox/ fcb630a80579faf6d12

[Intel-gfx] [PATCH] drm/i915: Explain nonlinearity of space-time^W requests

2017-08-02 Thread Chris Wilson
The flow of requests is a nebulous concept, so explain it in the words of an expert, a Time Lord. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_gem_request.h | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_gem_request.h b/drivers/g

[Intel-gfx] [PATCH i-g-t 1/3] lib/igt_aux: Export statistics of signal helper.

2017-08-02 Thread Maarten Lankhorst
Export 2 functions, igt_signal_helper_get_num and igt_signal_helper_get_hz. This will allow tests to measure how much time in a test was spent in a uninterruptible state, which is useful when testing whether certain ioctl's can be interrupted or not. Signed-off-by: Maarten Lankhorst --- lib/igt

[Intel-gfx] [PATCH i-g-t 3/3] tests: Add kms_atomic_interruptible test.

2017-08-02 Thread Maarten Lankhorst
To make sure that we have test exposure when allowing atomic ioctl's to fail interruptibly, we add a test that will fail to lock the mutexes until the fence is signaled. If the locking is done interruptibly, our signal helper will interrupt often, and with the statistics we can ensure that we rece

[Intel-gfx] [PATCH i-g-t 2/3] lib/igt_kms: Remove vblank wait after plane update.

2017-08-02 Thread Maarten Lankhorst
With the conversion to atomic, this is already handled in the core. Signed-off-by: Maarten Lankhorst --- lib/igt_kms.c | 15 --- lib/igt_kms.h | 1 - 2 files changed, 16 deletions(-) diff --git a/lib/igt_kms.c b/lib/igt_kms.c index 6390229f1546..14e2701c3afd 100644 --- a/lib/igt_km

[Intel-gfx] [PATCH v9 0/6] Add support for loadable OA configs

2017-08-02 Thread Lionel Landwerlin
Hi all, Here is a v9 with a tiny change on the whitelisting (patch 6). Cheers, Lionel Landwerlin (6): drm/i915/perf: fix flex eu registers programming drm/i915/perf: prune OA configs drm/i915/perf: leave GDT_CHICKEN_BITS programming in configs drm/i915/perf: disable NOA logic when not us

[Intel-gfx] [PATCH v9 5/6] drm/i915: reorder NOA register definition to follow addresses

2017-08-02 Thread Lionel Landwerlin
It makes things easier to read when implementing whitelisting in the following patches. Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/i915_reg.h | 212 1 file changed, 106 insertions(+), 106 deletions(-) diff --git

[Intel-gfx] [PATCH v9 3/6] drm/i915/perf: leave GDT_CHICKEN_BITS programming in configs

2017-08-02 Thread Lionel Landwerlin
There will be a need for userspaces configurations to set this register. We can apply the same model inside the kernel for test configs. Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/i915_oa_bdw.c| 2 ++ drivers/gpu/drm/i915/i915_oa_bxt.c| 1 + driv

[Intel-gfx] [PATCH v9 6/6] drm/i915/perf: Implement I915_PERF_ADD/REMOVE_CONFIG interface

2017-08-02 Thread Lionel Landwerlin
The motivation behind this new interface is expose at runtime the creation of new OA configs which can be used as part of the i915 perf open interface. This will enable the kernel to learn new configs which may be experimental, or otherwise not part of the core set currently available through the i

[Intel-gfx] [PATCH v9 4/6] drm/i915/perf: disable NOA logic when not used

2017-08-02 Thread Lionel Landwerlin
We already do it on Haswell and the documentation says it saves power. Signed-off-by: Lionel Landwerlin Reviewed-by: Matthew Auld --- drivers/gpu/drm/i915/i915_perf.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_perf.c b/drivers/gpu/drm/i915/i915_perf.c inde

[Intel-gfx] [PATCH v9 1/6] drm/i915/perf: fix flex eu registers programming

2017-08-02 Thread Lionel Landwerlin
We were reserving fewer dwords in the ring than necessary. Indeed we're always writing all registers once, so discard the actual number of registers given by the user and just program the whitelisted ones once. Fixes: 19f81df2859e ("drm/i915/perf: Add OA unit support for Gen 8+") Reported-by: Matt

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers

2017-08-02 Thread Daniel Vetter
On Tue, Aug 01, 2017 at 09:14:50AM -0700, Ben Widawsky wrote: > On 17-07-31 10:29:55, Daniel Vetter wrote: > > On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote: > > > On 17-07-29 13:53:10, Daniel Stone wrote: > > > > Hi Ben, > > > > > > > > On 26 July 2017 at 19:08, Ben Widawsky wrote:

[Intel-gfx] [intel-gfx][i-g-t] test/pm_rpm fail in wait_for_suspend

2017-08-02 Thread Gu, HailinX
Hi~ all I run the test on a desktop machine with i7-6700. And connecting to a kvm. I have checked the status of runtime PM. It's active when we expect suspend. And it could be success on another machine with i7-4770. Thanks for your help. Log shows below. err: (pm_rpm:5978) CRITICAL: Test ass