Re: [Intel-gfx] Kernel stability on baytrail machines

2016-07-18 Thread Michal Feix
Dne 13.7.2016 v 12:48 Pavel Machek napsal(a) Are there any updates on the status of this issue? The current bugzilla report [1] marks this as a power management issue. However, many reports indicate that it would only freeze when running X, so it's not completely clear if it's related to the gf

Re: [Intel-gfx] [PATCH 00/31] Move LRU page reclaim from zones to nodes v8

2016-07-18 Thread Minchan Kim
On Mon, Jul 04, 2016 at 05:34:05AM +0100, Mel Gorman wrote: > On Mon, Jul 04, 2016 at 10:37:03AM +0900, Minchan Kim wrote: > > > The reason we have zone-based reclaim is that we used to have > > > large highmem zones in common configurations and it was necessary > > > to quickly find ZONE_NORMAL pa

Re: [Intel-gfx] [PATCH 00/31] Move LRU page reclaim from zones to nodes v8

2016-07-18 Thread Minchan Kim
On Mon, Jul 04, 2016 at 10:55:09AM +0100, Mel Gorman wrote: > On Mon, Jul 04, 2016 at 05:04:12PM +0900, Minchan Kim wrote: > > > > How big ratio between highmem:lowmem do you think a problem? > > > > > > > > > > That's a "how long is a piece of string" type question. The ratio does > > > not mat

Re: [Intel-gfx] [PATCH] backlight: Avoid double fbcon backlight handling

2016-07-18 Thread joeyli
On Thu, Jun 30, 2016 at 12:30:56PM +0100, Chris Wilson wrote: > Backlights controlled by i915.ko and only associated with its connectors > and also only associated with the intel_drmfb fbcon, controlled by > i915.ko. In this situation, we already handle adjusting the backlight > when the fbcon is b

[Intel-gfx] [PATCH] i915: fix build error with -Werror

2016-07-18 Thread Jeff Mahoney
This fixes the following build error with -Werror and gcc 6.1: drivers/gpu/drm/i915/i915_debugfs.c:2103:6: error: suggest explicit braces to avoid ambiguous 'else' [-Werror=parentheses] Signed-off-by: Jeff Mahoney --- drivers/gpu/drm/i915/i915_debugfs.c |3 ++- 1 file changed, 2 insertions

Re: [Intel-gfx] [PATCH] i915: fix build error with -Werror

2016-07-18 Thread Jeff Mahoney
On 7/4/16 10:29 AM, Jeff Mahoney wrote: > This fixes the following build error with -Werror and gcc 6.1: > > drivers/gpu/drm/i915/i915_debugfs.c:2103:6: error: suggest explicit braces to > avoid ambiguous 'else' [-Werror=parentheses] Oops. It turns out my build test wasn't using gcc6. This doe

[Intel-gfx] [rfc PATCH] drm/i915: Simplify shrinker_lock

2016-07-18 Thread Davidlohr Bueso
Currently i915_gem_shrinker_lock() suffers from a few issues: (1) In the attempt to avoid recursive locking, the mutex owner is consulted. This is obviously nasty and extends the standard api with artifacts like mutex_is_locked_by() deep in driver code. (2) If the lock is taken by another task, t

Re: [Intel-gfx] Kernel stability on baytrail machines

2016-07-18 Thread Michal Feix
On Tue 2016-07-12 16:41:58, Ezequiel Garcia wrote: Hi Alan, (Adding interested people to this thread) On 09 Apr 08:14 PM, One Thousand Gnomes wrote: I do feel that the importance of the mentioned bug is currently underestimated. Can anyone here give a note, how much current linux kernel is sup

Re: [Intel-gfx] [PATCH 00/31] Move LRU page reclaim from zones to nodes v8

2016-07-18 Thread Mel Gorman
On Mon, Jul 04, 2016 at 05:04:12PM +0900, Minchan Kim wrote: > > > How big ratio between highmem:lowmem do you think a problem? > > > > > > > That's a "how long is a piece of string" type question. The ratio does > > not matter as much as whether the workload is both under memory pressure > > an

[Intel-gfx] [PATCH v2] i915: fix build error with -Werror

2016-07-18 Thread Jeff Mahoney
This fixes the following build error with -Werror and gcc 6.1: drivers/gpu/drm/i915/i915_debugfs.c:2103:6: error: suggest explicit braces to avoid ambiguous 'else' [-Werror=parentheses] Signed-off-by: Jeff Mahoney --- drivers/gpu/drm/i915/i915_debugfs.c |7 --- 1 file changed, 4 insert

Re: [Intel-gfx] [PATCH] drm/i915:gen9: restrict WaC6DisallowByGfxPause

2016-07-18 Thread Kamble, Sagar A
On 7/15/2016 7:19 PM, tim.g...@intel.com wrote: From: Tim Gore WaC6DisallowByGfxPause is currently applied unconditionally but is not required in all revisions. References: HSD#2133391 Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/intel_guc_loader.c | 4 +++- 1 file changed, 3 inserti

Re: [Intel-gfx] [PATCH] drm/i915: Handle ENOSPC after failing to insert a mappable node

2016-07-18 Thread Daniel Vetter
On Sat, Jul 16, 2016 at 06:42:36PM +0100, Chris Wilson wrote: > Even after adding individual page support for GTT mmaping, we can still > fail to find any space within the mappable region, and > drm_mm_insert_node() will then report ENOSPC. We have to then handle > this error by using the shmem acc

Re: [Intel-gfx] [PATCH] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Daniel Vetter
On Mon, Jul 18, 2016 at 11:07:14AM +0100, Chris Wilson wrote: > This patch provides the infrastructure for performing a 16-byte aligned > read from WC memory using non-temporal instructions introduced with sse4.1. > Using movntdqa we can bypass the CPU caches and read directly from memory > and ign

Re: [Intel-gfx] [PATCH i-g-t] tests: make color management tests part of the BAT

2016-07-18 Thread Daniel Vetter
On Fri, Jul 15, 2016 at 03:00:59PM +0100, Lionel Landwerlin wrote: > Signed-off-by: Lionel Landwerlin Do we have the time for those in the BAT budget? -Daniel > --- > tests/Makefile.sources |2 +- > tests/kms_pipe_color.c | 1184 > -- > t

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Wait on external rendering for GEM objects

2016-07-18 Thread Daniel Vetter
On Mon, Jul 18, 2016 at 11:18:27AM +0100, Chris Wilson wrote: > On Fri, Jul 15, 2016 at 11:11:20AM +0100, Chris Wilson wrote: > > @@ -1366,6 +1368,16 @@ i915_gem_object_wait_rendering(struct > > drm_i915_gem_object *obj, > > GEM_BUG_ON(obj->active); > > } > > > > + resv = i915_

Re: [Intel-gfx] [PATCH] drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default"

2016-07-18 Thread Daniel Vetter
On Mon, Jul 18, 2016 at 04:27:57PM -0700, Rodrigo Vivi wrote: > This reverts commit 041824ee25cfc535ba2d9a22c217df735ea2471e. > > We have latency issues that might impact the performance: #96606. > and hangs and loading issues on resume after S4: #96526. > > This is also blocking a platform miles

[Intel-gfx] [PATCH] intel: Export pooled EU and min no. of eus in a pool.

2016-07-18 Thread Yang Rong
Update kernel interface with new I915_GETPARAM ioctl entries for pooled EU and min no. of eus in a pool. Add a wrapping function for each parameter. Userspace drivers need these values when decide the thread count. This kernel enabled pooled eu by default for BXT and for fused down 2x6 parts it is

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default"

2016-07-18 Thread Patchwork
== Series Details == Series: drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default" URL : https://patchwork.freedesktop.org/series/10005/ State : failure == Summary == Series 10005v1 drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default" http

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: set proper N/M in modeset

2016-07-18 Thread Yang, Libin
Hi All, I submitted a patch and it show to fail in CI. Does the message means it is failed because of "ro-bdw-i7-5557U failed to connect after reboot". And how can I get the dmesg? Regards, Libin > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] O

[Intel-gfx] [PATCH] drm/i915/guc: Revert "drm/i915/guc: enable GuC loading & submission by default"

2016-07-18 Thread Rodrigo Vivi
This reverts commit 041824ee25cfc535ba2d9a22c217df735ea2471e. We have latency issues that might impact the performance: #96606. and hangs and loading issues on resume after S4: #96526. This is also blocking a platform milestone so let's disable this for now while we make sure we don't have any mo

[Intel-gfx] [PULL] topic/kbl-4.7-fixes

2016-07-18 Thread Daniel Vetter
Hi Dave, As promised here's the pile of kbl cherry-picks assembled by Mika&Rodrigo. It's a bit much, but all well-contained to kbl code and been tested for a while in drm-intel-next. Still separate in case too much, but in that case I think we'd need to disable kbl by default again (which would be

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Set legacy properties when using legacy gamma set IOCTL. (v2)

2016-07-18 Thread Bob Paauwe
On Mon, 18 Jul 2016 09:14:56 +0200 Maarten Lankhorst wrote: > Hey, > > Op 15-07-16 om 12:51 schreef Lionel Landwerlin: > > From: Bob Paauwe > > > > The i915 driver is now using atomic properties and atomic commit > > to handle the legacy set gamma IOCTL. However, if the driver is > > configured

Re: [Intel-gfx] [PATCH] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Dave Gordon
On 18/07/16 16:06, Tvrtko Ursulin wrote: On 18/07/16 14:46, Tvrtko Ursulin wrote: [snip] This version generates the smallest code: static void __memcpy_ntdqa(struct qw2 *dst, const struct qw2 *src, unsigned long len) { unsigned long l4; kernel_fpu_begin(); l4 = len

Re: [Intel-gfx] [PATCH] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Tvrtko Ursulin
On 18/07/16 14:46, Tvrtko Ursulin wrote: [snip] > This version generates the smallest code: > > static void __memcpy_ntdqa(struct qw2 *dst, const struct qw2 *src, unsigned > long len) > { > unsigned long l4; > > kernel_fpu_begin(); > > l4 = len / 4; > while (l4) { >

[Intel-gfx] [PULL] drm-intel-fixes

2016-07-18 Thread Daniel Vetter
Hi Dave, Two more regression fixes for 4.7. Cheers, Daniel The following changes since commit aeddda06c1a704bb97c8a7bfe7a472120193bd56: drm/i915: Ignore panel type from OpRegion on SKL (2016-07-14 16:08:04 +0200) are available in the git repository at: git://anongit.freedesktop.org/drm-i

Re: [Intel-gfx] [PATCH] drm/i915/skl: Fix redundant cursor update, fix cursor underruns

2016-07-18 Thread Ville Syrjälä
On Fri, Jul 15, 2016 at 06:13:56PM -0400, Lyude wrote: > At long last, the time has finally come for Skylake users to plug their > external displays back in. > > During intel_atomic_commit() on Skylake, we've actually been arming the > registers to update the cursor information twice instead of ju

Re: [Intel-gfx] [PATCH] drm/vgem: Remember to offset relative timeouts to mod_timer() by jiffies

2016-07-18 Thread Daniel Vetter
On Mon, Jul 18, 2016 at 10:31:18AM +0100, Chris Wilson wrote: > mod_timer() takes an absolute jiffie value, not a relative timeout and > quietly fixup the missed ret=0 otherwise gcc just always returns that > the fence timed out. > > Testcase: igt/vgem_basic/fence > Fixes: 407779848445 ("drm/vgem:

Re: [Intel-gfx] [PATCH v3 0/3] drm/i915/bxt: Fix performance due to bogus MOCS entry

2016-07-18 Thread Ville Syrjälä
On Fri, Jul 01, 2016 at 04:40:03PM +0300, Imre Deak wrote: > This is v3 of [1] addressing Ville's and Chris' comments. On Daniel's > request I also discussed about these changes with Rong R Yang from the > Beignet and Yakui Zhao from the Libva team, they are CC'd. > > Rong, Yakui please add your A

Re: [Intel-gfx] [PATCH] drm/i915: Set legacy properties when using legacy gamma set IOCTL. (v2)

2016-07-18 Thread Maarten Lankhorst
Op 15-07-16 om 18:13 schreef Bob Paauwe: > On Fri, 15 Jul 2016 14:59:02 +0100 > Lionel Landwerlin wrote: > >> From: Bob Paauwe >> >> The i915 driver is now using atomic properties and atomic commit >> to handle the legacy set gamma IOCTL. However, if the driver is >> configured without atomic (nu

Re: [Intel-gfx] Kernel stability on baytrail machines

2016-07-18 Thread One Thousand Gnomes
On Tue, 12 Jul 2016 16:41:58 -0300 Ezequiel Garcia wrote: > Hi Alan, > > (Adding interested people to this thread) > > On 09 Apr 08:14 PM, One Thousand Gnomes wrote: > > > > I do feel that the importance of the mentioned bug is currently > > > > underestimated. Can anyone here give a note, how

Re: [Intel-gfx] [PATCH] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Dave Gordon
On 18/07/16 13:56, Tvrtko Ursulin wrote: On 18/07/16 12:57, Dave Gordon wrote: On 18/07/16 12:35, Chris Wilson wrote: On Mon, Jul 18, 2016 at 12:15:32PM +0100, Tvrtko Ursulin wrote: I am not sure about this, but looking at the raid6 for example, it has a lot more annotations in cases like thi

Re: [Intel-gfx] [PATCH] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Tvrtko Ursulin
On 18/07/16 13:56, Tvrtko Ursulin wrote: > > On 18/07/16 12:57, Dave Gordon wrote: >> On 18/07/16 12:35, Chris Wilson wrote: >>> On Mon, Jul 18, 2016 at 12:15:32PM +0100, Tvrtko Ursulin wrote: I am not sure about this, but looking at the raid6 for example, it has a lot more annotations

Re: [Intel-gfx] [PATCH 10/17] drm/i915: New module param to control the size of buffer used for storing GuC firmware logs

2016-07-18 Thread Goel, Akash
On 7/18/2016 6:36 PM, Tvrtko Ursulin wrote: On 18/07/16 13:19, Goel, Akash wrote: On 7/18/2016 3:36 PM, Tvrtko Ursulin wrote: On 15/07/16 16:36, Goel, Akash wrote: On 7/15/2016 4:45 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel On recieving t

Re: [Intel-gfx] [PATCH 15/17] drm/i915: Increase GuC log buffer size to reduce flush interrupts

2016-07-18 Thread Tvrtko Ursulin
On 18/07/16 13:35, Goel, Akash wrote: On 7/18/2016 3:24 PM, Tvrtko Ursulin wrote: On 15/07/16 17:20, Goel, Akash wrote: On 7/15/2016 8:37 PM, Tvrtko Ursulin wrote: On 15/07/16 15:42, Goel, Akash wrote: On 7/15/2016 5:27 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com w

Re: [Intel-gfx] [PATCH 10/17] drm/i915: New module param to control the size of buffer used for storing GuC firmware logs

2016-07-18 Thread Tvrtko Ursulin
On 18/07/16 13:19, Goel, Akash wrote: On 7/18/2016 3:36 PM, Tvrtko Ursulin wrote: On 15/07/16 16:36, Goel, Akash wrote: On 7/15/2016 4:45 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel On recieving the log buffer flush interrupt from GuC firmware

Re: [Intel-gfx] [PATCH] dma-buf: Release module reference on creation failure

2016-07-18 Thread Sumit Semwal
Hi Chris, On 18 July 2016 at 17:40, Daniel Vetter wrote: > On Mon, Jul 18, 2016 at 12:16:22PM +0100, Chris Wilson wrote: >> If we fail to create the anon file, we need to remember to release the >> module reference on the owner. >> Thanks for the patch. >> Signed-off-by: Chris Wilson >> Reviewe

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: Treat eDP as always connected, again

2016-07-18 Thread Dave Gordon
On 18/07/16 13:50, Dave Gordon wrote: On 18/07/16 13:29, Daniel Vetter wrote: On Mon, Jul 18, 2016 at 11:43:08AM -, Patchwork wrote: == Series Details == Series: drm/i915: Treat eDP as always connected, again URL : https://patchwork.freedesktop.org/series/9977/ State : failure == Summar

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: Wait up to 3ms for the pcu to ack the cdclk change request on SKL

2016-07-18 Thread Ville Syrjälä
On Wed, Jul 13, 2016 at 02:07:41PM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Wait up to 3ms for the pcu to ack the cdclk change request > on SKL > URL : https://patchwork.freedesktop.org/series/9815/ > State : failure > > == Summary == > > Series 9815v1 drm/i915: Wa

Re: [Intel-gfx] [PATCH] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Tvrtko Ursulin
On 18/07/16 12:57, Dave Gordon wrote: > On 18/07/16 12:35, Chris Wilson wrote: >> On Mon, Jul 18, 2016 at 12:15:32PM +0100, Tvrtko Ursulin wrote: >>> I am not sure about this, but looking at the raid6 for example, it >>> has a lot more annotations in cases like this. >>> >>> It seems to be telling

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: Treat eDP as always connected, again

2016-07-18 Thread Dave Gordon
On 18/07/16 13:29, Daniel Vetter wrote: On Mon, Jul 18, 2016 at 11:43:08AM -, Patchwork wrote: == Series Details == Series: drm/i915: Treat eDP as always connected, again URL : https://patchwork.freedesktop.org/series/9977/ State : failure == Summary == Series 9977v1 drm/i915: Treat eDP

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: Treat eDP as always connected, again

2016-07-18 Thread Ville Syrjälä
On Mon, Jul 18, 2016 at 02:29:45PM +0200, Daniel Vetter wrote: > On Mon, Jul 18, 2016 at 11:43:08AM -, Patchwork wrote: > > == Series Details == > > > > Series: drm/i915: Treat eDP as always connected, again > > URL : https://patchwork.freedesktop.org/series/9977/ > > State : failure > > >

Re: [Intel-gfx] [PATCH 15/17] drm/i915: Increase GuC log buffer size to reduce flush interrupts

2016-07-18 Thread Goel, Akash
On 7/18/2016 3:24 PM, Tvrtko Ursulin wrote: On 15/07/16 17:20, Goel, Akash wrote: On 7/15/2016 8:37 PM, Tvrtko Ursulin wrote: On 15/07/16 15:42, Goel, Akash wrote: On 7/15/2016 5:27 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel In cases where

Re: [Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: Treat eDP as always connected, again

2016-07-18 Thread Daniel Vetter
On Mon, Jul 18, 2016 at 11:43:08AM -, Patchwork wrote: > == Series Details == > > Series: drm/i915: Treat eDP as always connected, again > URL : https://patchwork.freedesktop.org/series/9977/ > State : failure > > == Summary == > > Series 9977v1 drm/i915: Treat eDP as always connected, aga

Re: [Intel-gfx] [PATCH 10/17] drm/i915: New module param to control the size of buffer used for storing GuC firmware logs

2016-07-18 Thread Goel, Akash
On 7/18/2016 3:36 PM, Tvrtko Ursulin wrote: On 15/07/16 16:36, Goel, Akash wrote: On 7/15/2016 4:45 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel On recieving the log buffer flush interrupt from GuC firmware, Driver stores the snapshot of the l

Re: [Intel-gfx] [PATCH] dma-buf: Release module reference on creation failure

2016-07-18 Thread Daniel Vetter
On Mon, Jul 18, 2016 at 12:16:22PM +0100, Chris Wilson wrote: > If we fail to create the anon file, we need to remember to release the > module reference on the owner. > > Signed-off-by: Chris Wilson > Reviewed-by: Joonas Lahtinen > Cc: Joonas Lahtinen > Cc: Sumit Semwal > Cc: Daniel Vetter >

Re: [Intel-gfx] [PATCH] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Tvrtko Ursulin
On 18/07/16 12:35, Chris Wilson wrote: On Mon, Jul 18, 2016 at 12:15:32PM +0100, Tvrtko Ursulin wrote: I am not sure about this, but looking at the raid6 for example, it has a lot more annotations in cases like this. It seems to be telling the compiler which memory ranges does each instruction

[Intel-gfx] ✓ Ro.CI.BAT: success for dma-buf: Release module reference on creation failure (rev2)

2016-07-18 Thread Patchwork
== Series Details == Series: dma-buf: Release module reference on creation failure (rev2) URL : https://patchwork.freedesktop.org/series/5088/ State : success == Summary == Series 5088v2 dma-buf: Release module reference on creation failure http://patchwork.freedesktop.org/api/1.0/series/5088/

Re: [Intel-gfx] [PATCH] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Dave Gordon
On 18/07/16 12:35, Chris Wilson wrote: On Mon, Jul 18, 2016 at 12:15:32PM +0100, Tvrtko Ursulin wrote: I am not sure about this, but looking at the raid6 for example, it has a lot more annotations in cases like this. It seems to be telling the compiler which memory ranges does each instruction

Re: [Intel-gfx] [PATCH 14/17] drm/i915: Add stats for GuC log buffer flush interrupts

2016-07-18 Thread Goel, Akash
On 7/18/2016 5:03 PM, Tvrtko Ursulin wrote: On 18/07/16 11:59, Goel, Akash wrote: On 7/18/2016 3:46 PM, Tvrtko Ursulin wrote: On 15/07/16 16:58, Goel, Akash wrote: On 7/15/2016 5:21 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel GuC firmware s

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: Treat eDP as always connected, again

2016-07-18 Thread Patchwork
== Series Details == Series: drm/i915: Treat eDP as always connected, again URL : https://patchwork.freedesktop.org/series/9977/ State : failure == Summary == Series 9977v1 drm/i915: Treat eDP as always connected, again http://patchwork.freedesktop.org/api/1.0/series/9977/revisions/1/mbox Tes

Re: [Intel-gfx] [PATCH 13/17] drm/i915: New lock to serialize the Host2GuC actions

2016-07-18 Thread Tvrtko Ursulin
On 18/07/16 12:31, Goel, Akash wrote: On 7/18/2016 4:48 PM, Tvrtko Ursulin wrote: On 18/07/16 11:46, Goel, Akash wrote: On 7/18/2016 3:42 PM, Tvrtko Ursulin wrote: On 15/07/16 16:51, Goel, Akash wrote: On 7/15/2016 5:10 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.co

Re: [Intel-gfx] [PATCH] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Chris Wilson
On Mon, Jul 18, 2016 at 12:15:32PM +0100, Tvrtko Ursulin wrote: > I am not sure about this, but looking at the raid6 for example, it > has a lot more annotations in cases like this. > > It seems to be telling the compiler which memory ranges does each > instruction access, and also uses "asm volat

Re: [Intel-gfx] [PATCH 14/17] drm/i915: Add stats for GuC log buffer flush interrupts

2016-07-18 Thread Tvrtko Ursulin
On 18/07/16 11:59, Goel, Akash wrote: On 7/18/2016 3:46 PM, Tvrtko Ursulin wrote: On 15/07/16 16:58, Goel, Akash wrote: On 7/15/2016 5:21 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel GuC firmware sends an interrupt to flush the log buffer when

Re: [Intel-gfx] [PATCH 13/17] drm/i915: New lock to serialize the Host2GuC actions

2016-07-18 Thread Goel, Akash
On 7/18/2016 4:48 PM, Tvrtko Ursulin wrote: On 18/07/16 11:46, Goel, Akash wrote: On 7/18/2016 3:42 PM, Tvrtko Ursulin wrote: On 15/07/16 16:51, Goel, Akash wrote: On 7/15/2016 5:10 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel With the ad

[Intel-gfx] ✗ Ro.CI.BAT: failure for Add USB typeC based DP support for BXT platform (rev9)

2016-07-18 Thread Patchwork
== Series Details == Series: Add USB typeC based DP support for BXT platform (rev9) URL : https://patchwork.freedesktop.org/series/1731/ State : failure == Summary == Series 1731v9 Add USB typeC based DP support for BXT platform http://patchwork.freedesktop.org/api/1.0/series/1731/revisions/9/

Re: [Intel-gfx] [PATCH 13/17] drm/i915: New lock to serialize the Host2GuC actions

2016-07-18 Thread Tvrtko Ursulin
On 18/07/16 11:46, Goel, Akash wrote: On 7/18/2016 3:42 PM, Tvrtko Ursulin wrote: On 15/07/16 16:51, Goel, Akash wrote: On 7/15/2016 5:10 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel With the addition of new Host2GuC actions related to GuC l

[Intel-gfx] [PATCH] dma-buf: Release module reference on creation failure

2016-07-18 Thread Chris Wilson
If we fail to create the anon file, we need to remember to release the module reference on the owner. Signed-off-by: Chris Wilson Reviewed-by: Joonas Lahtinen Cc: Joonas Lahtinen Cc: Sumit Semwal Cc: Daniel Vetter Cc: linux-me...@vger.kernel.org Cc: dri-de...@lists.freedesktop.org Cc: linaro-

Re: [Intel-gfx] [PATCH] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Tvrtko Ursulin
On 18/07/16 11:07, Chris Wilson wrote: This patch provides the infrastructure for performing a 16-byte aligned read from WC memory using non-temporal instructions introduced with sse4.1. Using movntdqa we can bypass the CPU caches and read directly from memory and ignoring the page attributes se

Re: [Intel-gfx] [PATCH 14/17] drm/i915: Add stats for GuC log buffer flush interrupts

2016-07-18 Thread Goel, Akash
On 7/18/2016 3:46 PM, Tvrtko Ursulin wrote: On 15/07/16 16:58, Goel, Akash wrote: On 7/15/2016 5:21 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel GuC firmware sends an interrupt to flush the log buffer when it becomes half full. GuC firmware als

[Intel-gfx] ✗ Ro.CI.BAT: failure for drm/i915: Use SSE4.1 movntqda to accelerate reads from WC memory (rev5)

2016-07-18 Thread Patchwork
== Series Details == Series: drm/i915: Use SSE4.1 movntqda to accelerate reads from WC memory (rev5) URL : https://patchwork.freedesktop.org/series/9949/ State : failure == Summary == Series 9949v5 drm/i915: Use SSE4.1 movntqda to accelerate reads from WC memory http://patchwork.freedesktop.or

Re: [Intel-gfx] [PATCH 13/17] drm/i915: New lock to serialize the Host2GuC actions

2016-07-18 Thread Goel, Akash
On 7/18/2016 3:42 PM, Tvrtko Ursulin wrote: On 15/07/16 16:51, Goel, Akash wrote: On 7/15/2016 5:10 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel With the addition of new Host2GuC actions related to GuC logging, there is a need of a lock to s

Re: [Intel-gfx] [PATCH] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Chris Wilson
On Mon, Jul 18, 2016 at 11:07:14AM +0100, Chris Wilson wrote: > This patch provides the infrastructure for performing a 16-byte aligned > read from WC memory using non-temporal instructions introduced with sse4.1. > Using movntdqa we can bypass the CPU caches and read directly from memory > and ign

Re: [Intel-gfx] [PATCH 11/17] drm/i915: Support to create write combined type vmaps

2016-07-18 Thread Tvrtko Ursulin
On 15/07/16 17:30, Goel, Akash wrote: On 7/15/2016 5:01 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Chris Wilson vmaps has a provision for controlling the page protection bits, with which we can use to control the mapping type, e.g. WB, WC, UC or even WT. T

Re: [Intel-gfx] [PATCH 8/9] drm/i915: Wait on external rendering for GEM objects

2016-07-18 Thread Chris Wilson
On Fri, Jul 15, 2016 at 11:11:20AM +0100, Chris Wilson wrote: > @@ -1366,6 +1368,16 @@ i915_gem_object_wait_rendering(struct > drm_i915_gem_object *obj, > GEM_BUG_ON(obj->active); > } > > + resv = i915_gem_object_get_dmabuf_resv(obj); > + if (resv) { > + l

Re: [Intel-gfx] [PATCH 14/17] drm/i915: Add stats for GuC log buffer flush interrupts

2016-07-18 Thread Tvrtko Ursulin
On 15/07/16 16:58, Goel, Akash wrote: On 7/15/2016 5:21 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel GuC firmware sends an interrupt to flush the log buffer when it becomes half full. GuC firmware also tracks how many times the buffer overflowed.

[Intel-gfx] [PATCH] drm/i915: Treat eDP as always connected, again

2016-07-18 Thread ville . syrjala
From: Ville Syrjälä eDP should be treated as connected even if doesn't have an EDID. In that case we'll use the timings from the VBT. That used to be the case until commit f21a21983ef1 ("drm/i915: Splitting intel_dp_detect") broke things by considering even eDP disconnected if we fail to get an E

Re: [Intel-gfx] [PATCH 13/17] drm/i915: New lock to serialize the Host2GuC actions

2016-07-18 Thread Tvrtko Ursulin
On 15/07/16 16:51, Goel, Akash wrote: On 7/15/2016 5:10 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel With the addition of new Host2GuC actions related to GuC logging, there is a need of a lock to serialize them, as they can execute concurrently

[Intel-gfx] [PATCH] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Chris Wilson
This patch provides the infrastructure for performing a 16-byte aligned read from WC memory using non-temporal instructions introduced with sse4.1. Using movntdqa we can bypass the CPU caches and read directly from memory and ignoring the page attributes set on the CPU PTE i.e. negating the impact

Re: [Intel-gfx] [PATCH 10/17] drm/i915: New module param to control the size of buffer used for storing GuC firmware logs

2016-07-18 Thread Tvrtko Ursulin
On 15/07/16 16:36, Goel, Akash wrote: On 7/15/2016 4:45 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel On recieving the log buffer flush interrupt from GuC firmware, Driver stores the snapshot of the log buffer in a local buffer, from which Userspa

[Intel-gfx] ✓ Ro.CI.BAT: success for drm/vgem: Remember to offset relative timeouts to mod_timer() by jiffies

2016-07-18 Thread Patchwork
== Series Details == Series: drm/vgem: Remember to offset relative timeouts to mod_timer() by jiffies URL : https://patchwork.freedesktop.org/series/9975/ State : success == Summary == Series 9975v1 drm/vgem: Remember to offset relative timeouts to mod_timer() by jiffies http://patchwork.free

Re: [Intel-gfx] [PATCH v5] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Chris Wilson
On Mon, Jul 18, 2016 at 10:31:05AM +0100, Tvrtko Ursulin wrote: > On 16/07/16 16:44, Chris Wilson wrote: > Is it okay nowadays to just use these registers in the kernel? > > Many years ago when I last looked into this FPU and MMX registers > were discouraged against and needed explicit kernel_gpu_

Re: [Intel-gfx] [PATCH 15/17] drm/i915: Increase GuC log buffer size to reduce flush interrupts

2016-07-18 Thread Tvrtko Ursulin
On 15/07/16 17:20, Goel, Akash wrote: On 7/15/2016 8:37 PM, Tvrtko Ursulin wrote: On 15/07/16 15:42, Goel, Akash wrote: On 7/15/2016 5:27 PM, Tvrtko Ursulin wrote: On 10/07/16 14:41, akash.g...@intel.com wrote: From: Akash Goel In cases where GuC generate logs at a very high rate, corresp

[Intel-gfx] [PATCH] drm/vgem: Remember to offset relative timeouts to mod_timer() by jiffies

2016-07-18 Thread Chris Wilson
mod_timer() takes an absolute jiffie value, not a relative timeout and quietly fixup the missed ret=0 otherwise gcc just always returns that the fence timed out. Testcase: igt/vgem_basic/fence Fixes: 407779848445 ("drm/vgem: Attach sw fences to exported vGEM dma-buf") Signed-off-by: Chris Wilson

Re: [Intel-gfx] [PATCH v5] drm/i915: Use SSE4.1 movntdqa to accelerate reads from WC memory

2016-07-18 Thread Tvrtko Ursulin
On 16/07/16 16:44, Chris Wilson wrote: This patch provides the infrastructure for performing a 16-byte aligned read from WC memory using non-temporal instructions introduced with sse4.1. Using movntdqa we can bypass the CPU caches and read directly from memory and ignoring the page attributes se

Re: [Intel-gfx] [PATCH] drm/i915: Set legacy properties when using legacy gamma set IOCTL. (v2)

2016-07-18 Thread Maarten Lankhorst
Op 15-07-16 om 15:59 schreef Lionel Landwerlin: > From: Bob Paauwe > > The i915 driver is now using atomic properties and atomic commit > to handle the legacy set gamma IOCTL. However, if the driver is > configured without atomic (nuclear_pageflip = false), it won't > update the legacy properties

Re: [Intel-gfx] [PATCH 1/2] drm/i915: add missing condition for committing planes on crtc

2016-07-18 Thread Maarten Lankhorst
Op 15-07-16 om 12:51 schreef Lionel Landwerlin: > The i915 driver checks for color management properties changes as part > of a plane update. Therefore a color management update must imply a > plane update, otherwise we never update the transformation matrixes > and degamma/gamma LUTs. > > v2: add

Re: [Intel-gfx] [PATCH 02/11] drm/doc: Add kerneldoc for @index

2016-07-18 Thread Chris Wilson
On Mon, Jul 18, 2016 at 09:15:35AM +0200, Daniel Vetter wrote: > On Fri, Jul 15, 2016 at 09:06:04PM +0100, Chris Wilson wrote: > > On Fri, Jul 15, 2016 at 09:47:59PM +0200, Daniel Vetter wrote: > > > Was forgotten when adding them all over. 0-day should complain about > > > new missing kernel-doc,

Re: [Intel-gfx] [PATCH 02/11] drm/doc: Add kerneldoc for @index

2016-07-18 Thread Daniel Vetter
On Fri, Jul 15, 2016 at 09:06:04PM +0100, Chris Wilson wrote: > On Fri, Jul 15, 2016 at 09:47:59PM +0200, Daniel Vetter wrote: > > Was forgotten when adding them all over. 0-day should complain about > > new missing kernel-doc, not sure why that wasn't caught/fixed. > > > > Cc: Chris Wilson > > S

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Set legacy properties when using legacy gamma set IOCTL. (v2)

2016-07-18 Thread Maarten Lankhorst
Hey, Op 15-07-16 om 12:51 schreef Lionel Landwerlin: > From: Bob Paauwe > > The i915 driver is now using atomic properties and atomic commit > to handle the legacy set gamma IOCTL. However, if the driver is > configured without atomic (nuclear_pageflip = false), it won't > update the legacy prope