Re: [Intel-gfx] [PATCH i-g-t 2/4] lib: Skip suspend/hibernate tests if the system doesn't support them

2015-10-26 Thread David Weinehall
On Fri, Oct 23, 2015 at 12:39:31PM -0700, Jesse Barnes wrote: > On 10/22/2015 01:35 PM, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Do a dry run with rtcwake first to determine if the system even supports > > the intended suspend state. If not, skip the test. > > > > Fix

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-26 Thread David Weinehall
On Mon, Oct 26, 2015 at 03:59:24PM -0200, Paulo Zanoni wrote: > 2015-10-26 15:30 GMT-02:00 David Weinehall : > > On Mon, Oct 26, 2015 at 02:44:18PM -0200, Paulo Zanoni wrote: > >> 2015-10-26 12:59 GMT-02:00 David Weinehall > >> : > >> > On Fri, Oct 23, 2015 at 11:50:46AM -0200, Paulo Zanoni wrote:

Re: [Intel-gfx] [PATCH] drm/i915/skl: Correct other-pipe watermark update condition check (v2)

2015-10-26 Thread Kumar, Mahesh
Yes, it doesn't solve all warnings. Other than fbdev restore, there is one warning which I faced during DPMS/Hot-plug, which is due to calculation of watermarks twice. Once for first CRTC "Pipe-A" (during which it consider/calculates watermark for other pipe "Pipe-B" as well & stores in structu

Re: [Intel-gfx] [PATCH 2/2] drm/i915: shut up gen8+ SDE irq dmesg noise

2015-10-26 Thread Daniel Vetter
On Fri, Oct 23, 2015 at 8:22 AM, Ville Syrjälä wrote: > The regressing patch change didn't add the message, so there was a clear > change in behaviour, and now it's papered over. It did move around the DRM_ERROR for all the others and also added the SDE one for consistency. At least that's how I

[Intel-gfx] [PATCH] drm/i915: Skip fence installation for objects with rotated views (v2)

2015-10-26 Thread Vivek Kasireddy
While pinning a fb object to the display plane, only install a fence if the object is using a normal view. This corresponds with the behavior found in i915_gem_object_do_pin() where the fencability criteria is determined only for objects with normal views. v2: Look at the object's map_and_fenceabl

Re: [Intel-gfx] [PATCH] drm/i915/skl: Remove duplicated mem calls for PLANE_CURSOR.

2015-10-26 Thread Ville Syrjälä
On Mon, Oct 26, 2015 at 02:41:00PM +0100, Maarten Lankhorst wrote: > These calls are unneeded because the previous memset/memcmp already handles > PLANE_CURSOR too, > so no need to treat it in a special way. > > Signed-off-by: Maarten Lankhorst > --- > diff --git a/drivers/gpu/drm/i915/intel_pm.

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-26 Thread Paulo Zanoni
2015-10-23 12:55 GMT-02:00 Thomas Wood : > On 23 October 2015 at 12:42, David Weinehall > wrote: >> Some tests should not be run by default, due to their slow, >> and sometimes superfluous, nature. >> >> We still want to be able to run these tests though in some cases. >> Until now there's been no

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-26 Thread Paulo Zanoni
2015-10-26 15:30 GMT-02:00 David Weinehall : > On Mon, Oct 26, 2015 at 02:44:18PM -0200, Paulo Zanoni wrote: >> 2015-10-26 12:59 GMT-02:00 David Weinehall : >> > On Fri, Oct 23, 2015 at 11:50:46AM -0200, Paulo Zanoni wrote: >> > >> > [snip] >> > >> >> It's not clear to me, please clarify: now the t

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-26 Thread David Weinehall
On Mon, Oct 26, 2015 at 04:28:15PM +, Thomas Wood wrote: > On 26 October 2015 at 15:28, David Weinehall > wrote: > > On Fri, Oct 23, 2015 at 03:55:23PM +0100, Thomas Wood wrote: > >> On 23 October 2015 at 12:42, David Weinehall > >> wrote: > >> > Some tests should not be run by default, due t

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-26 Thread David Weinehall
On Mon, Oct 26, 2015 at 02:44:18PM -0200, Paulo Zanoni wrote: > 2015-10-26 12:59 GMT-02:00 David Weinehall : > > On Fri, Oct 23, 2015 at 11:50:46AM -0200, Paulo Zanoni wrote: > > > > [snip] > > > >> It's not clear to me, please clarify: now the tests that were > >> previously completely hidden will

Re: [Intel-gfx] [PATCH] drm/915: Pad GTT views of exec objects up to user specified size

2015-10-26 Thread Chris Wilson
On Mon, Oct 26, 2015 at 04:00:20PM +, Tvrtko Ursulin wrote: > > Hi, > > On 23/10/15 10:50, Tvrtko Ursulin wrote: > >On 22/10/15 17:07, Chris Wilson wrote: > >>On Thu, Oct 22, 2015 at 03:15:55PM +0100, Tvrtko Ursulin wrote: > >>> > >>>Hi, > >>> > >>>On 21/10/15 16:24, Chris Wilson wrote: > >>>

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-26 Thread Paulo Zanoni
2015-10-26 12:59 GMT-02:00 David Weinehall : > On Fri, Oct 23, 2015 at 11:50:46AM -0200, Paulo Zanoni wrote: > > [snip] > >> It's not clear to me, please clarify: now the tests that were >> previously completely hidden will be listed in --list-subtests and >> will be shown as skipped during normal

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-26 Thread Thomas Wood
On 26 October 2015 at 15:28, David Weinehall wrote: > On Fri, Oct 23, 2015 at 03:55:23PM +0100, Thomas Wood wrote: >> On 23 October 2015 at 12:42, David Weinehall >> wrote: >> > Some tests should not be run by default, due to their slow, >> > and sometimes superfluous, nature. >> > >> > We still

Re: [Intel-gfx] [PATCH] drm/915: Pad GTT views of exec objects up to user specified size

2015-10-26 Thread Tvrtko Ursulin
Hi, On 23/10/15 10:50, Tvrtko Ursulin wrote: On 22/10/15 17:07, Chris Wilson wrote: On Thu, Oct 22, 2015 at 03:15:55PM +0100, Tvrtko Ursulin wrote: Hi, On 21/10/15 16:24, Chris Wilson wrote: Our GPUs impose certain requirements upon buffers that depend upon how exactly they are used. Typic

Re: [Intel-gfx] [PATCH] drm/i915: Add extra plane information in debugfs.

2015-10-26 Thread Ville Syrjälä
On Mon, Oct 26, 2015 at 03:56:33PM +0100, Robert Fekete wrote: > Hi, thanks for reviewing Maarten. > See comments inline... > > On mån, 2015-10-26 at 09:23 +0100, Maarten Lankhorst wrote: > > Op 23-10-15 om 16:24 schreef Robert Fekete: > > > Extends i915_display_info so that for each active crtc a

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-26 Thread David Weinehall
On Fri, Oct 23, 2015 at 03:55:23PM +0100, Thomas Wood wrote: > On 23 October 2015 at 12:42, David Weinehall > wrote: > > Some tests should not be run by default, due to their slow, > > and sometimes superfluous, nature. > > > > We still want to be able to run these tests though in some cases. > >

Re: [Intel-gfx] [PATCH i-g-t 1/3] Rename gem_concurren_all over gem_concurrent_blit

2015-10-26 Thread David Weinehall
On Fri, Oct 23, 2015 at 03:32:08PM +0100, Thomas Wood wrote: > gem_concurrent_all is misspelled in the subject. > > On 23 October 2015 at 12:42, David Weinehall > wrote: > > We'll both rename gem_concurrent_all over gem_concurrent_blit > > and change gem_concurrent_blit in this changeset. To make

Re: [Intel-gfx] [PATCH i-g-t 2/3] Unify handling of slow/combinatorial tests

2015-10-26 Thread David Weinehall
On Fri, Oct 23, 2015 at 11:50:46AM -0200, Paulo Zanoni wrote: [snip] > It's not clear to me, please clarify: now the tests that were > previously completely hidden will be listed in --list-subtests and > will be shown as skipped during normal runs? Yes. Daniel and I discussed this and he though

Re: [Intel-gfx] [PATCH] drm/i915: Add extra plane information in debugfs.

2015-10-26 Thread Robert Fekete
Hi, thanks for reviewing Maarten. See comments inline... On mån, 2015-10-26 at 09:23 +0100, Maarten Lankhorst wrote: > Op 23-10-15 om 16:24 schreef Robert Fekete: > > Extends i915_display_info so that for each active crtc also print > > all planes associated with the pipe. This patch shows informa

Re: [Intel-gfx] [PATCH 20/43] drm/i915: Use paramtrized WRPLL_CTL()

2015-10-26 Thread Ville Syrjälä
On Wed, Sep 30, 2015 at 04:58:34PM +0300, Jani Nikula wrote: > On Fri, 18 Sep 2015, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Signed-off-by: Ville Syrjälä > > --- > > drivers/gpu/drm/i915/i915_reg.h | 2 +- > > drivers/gpu/drm/i915/intel_ddi.c | 8 > >

Re: [Intel-gfx] [PATCH 0/5] drm/i915: Expose __raw_i915_read() & co. to the outside, and a few forcewake things

2015-10-26 Thread Ville Syrjälä
On Thu, Oct 22, 2015 at 02:41:29PM +0100, Chris Wilson wrote: > On Thu, Oct 22, 2015 at 03:34:55PM +0300, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > These patches fell off from my type safe register access series. I > > figured I'd post them separately since they're a fa

Re: [Intel-gfx] [PATCH i-g-t 0/3] Unify slow/combinatorial test handling

2015-10-26 Thread David Weinehall
On Fri, Oct 23, 2015 at 02:47:57PM +0200, Daniel Vetter wrote: > On Fri, Oct 23, 2015 at 12:58:45PM +0100, Chris Wilson wrote: > > On Fri, Oct 23, 2015 at 02:42:33PM +0300, David Weinehall wrote: > > > Until now we've had no unified way to handle slow/combinatorial tests. > > > Most of the time we

[Intel-gfx] [PATCH] drm/i915/skl: Remove duplicated mem calls for PLANE_CURSOR.

2015-10-26 Thread Maarten Lankhorst
These calls are unneeded because the previous memset/memcmp already handles PLANE_CURSOR too, so no need to treat it in a special way. Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c index 0fb0459cf093..efa2b15e8b88 100644 --- a

Re: [Intel-gfx] [PATCH] drm/i915: Ensure associated VMAs are inactive when contexts are destroyed

2015-10-26 Thread Tvrtko Ursulin
On 26/10/15 12:10, Chris Wilson wrote: > On Mon, Oct 26, 2015 at 12:00:06PM +, Tvrtko Ursulin wrote: >> >> On 26/10/15 11:23, Chris Wilson wrote: >>> On Mon, Oct 26, 2015 at 11:05:03AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In the following commit: com

Re: [Intel-gfx] [PATCH] drm/i915: Ensure associated VMAs are inactive when contexts are destroyed

2015-10-26 Thread Chris Wilson
On Mon, Oct 26, 2015 at 12:00:06PM +, Tvrtko Ursulin wrote: > > On 26/10/15 11:23, Chris Wilson wrote: > >On Mon, Oct 26, 2015 at 11:05:03AM +, Tvrtko Ursulin wrote: > >>From: Tvrtko Ursulin > >> > >>In the following commit: > >> > >> commit e9f24d5fb7cf3628b195b18ff3ac4e37937ceeae >

Re: [Intel-gfx] [PATCH] drm/i915: Ensure associated VMAs are inactive when contexts are destroyed

2015-10-26 Thread Tvrtko Ursulin
On 26/10/15 11:23, Chris Wilson wrote: On Mon, Oct 26, 2015 at 11:05:03AM +, Tvrtko Ursulin wrote: From: Tvrtko Ursulin In the following commit: commit e9f24d5fb7cf3628b195b18ff3ac4e37937ceeae Author: Tvrtko Ursulin Date: Mon Oct 5 13:26:36 2015 +0100 drm/i915

Re: [Intel-gfx] [PATCH] drm/i915: Ensure associated VMAs are inactive when contexts are destroyed

2015-10-26 Thread Chris Wilson
On Mon, Oct 26, 2015 at 11:05:03AM +, Tvrtko Ursulin wrote: > From: Tvrtko Ursulin > > In the following commit: > > commit e9f24d5fb7cf3628b195b18ff3ac4e37937ceeae > Author: Tvrtko Ursulin > Date: Mon Oct 5 13:26:36 2015 +0100 > > drm/i915: Clean up associated VMAs on

[Intel-gfx] [PATCH] drm/i915: Ensure associated VMAs are inactive when contexts are destroyed

2015-10-26 Thread Tvrtko Ursulin
From: Tvrtko Ursulin In the following commit: commit e9f24d5fb7cf3628b195b18ff3ac4e37937ceeae Author: Tvrtko Ursulin Date: Mon Oct 5 13:26:36 2015 +0100 drm/i915: Clean up associated VMAs on context destruction I added a WARN_ON assertion that VM's active list must be em

[Intel-gfx] [PATCH] drm/i915: make A0 wa's applied to A1

2015-10-26 Thread tim . gore
From: Tim Gore Since A1 chips use the same GPU as A0, they need all the same wa's in the i915 driver. Update some conditionals to do this. Signed-off-by: Tim Gore --- drivers/gpu/drm/i915/intel_guc_loader.c | 2 +- drivers/gpu/drm/i915/intel_lrc.c| 8 drivers/gpu/drm/i915/inte

Re: [Intel-gfx] [PATCH] drm/i915: Skip fence installation for objects with rotated views (v2)

2015-10-26 Thread Tvrtko Ursulin
Hi, On 19/09/15 02:57, Vivek Kasireddy wrote: v2: Look at the object's map_and_fenceable flag to determine whether to install a fence or not (Chris). v1: While pinning a fb object to the display plane, only install a fence if the object is using a normal view. This corresponds with the behavio

Re: [Intel-gfx] [PATCH v2] drm/i915: Always program CSR if CSR is uninitialized

2015-10-26 Thread Patrik Jakobsson
On Sat, Oct 24, 2015 at 11:03:05AM +0530, Animesh Manna wrote: > > > On 10/23/2015 3:11 PM, Patrik Jakobsson wrote: > >The current CSR loading code depends on the CSR program memory to be > >cleared after boot. This is unfortunately not true on all hardware. > >Instead make use of the FW_UNINITIA

[Intel-gfx] [PATCH v2 01/11] drm/i915: Use passed plane state for sprite planes, v2.

2015-10-26 Thread Maarten Lankhorst
Op 22-10-15 om 14:58 schreef Daniel Vetter: > On Thu, Oct 22, 2015 at 01:56:26PM +0200, Maarten Lankhorst wrote: >> Don't use plane->state directly, use the pointer from commit_plane. >> >> Signed-off-by: Maarten Lankhorst >> --- >> drivers/gpu/drm/i915/intel_drv.h| 8 ++--- >> drivers/gpu/d

Re: [Intel-gfx] [PATCH i-g-t 1/2] igt_kms: Set atomic capability bit

2015-10-26 Thread Daniel Stone
Hi, On 23 October 2015 at 09:05, Daniel Vetter wrote: > On Thu, Oct 22, 2015 at 05:27:00PM -0700, Matt Roper wrote: >> diff --git a/lib/igt_kms.c b/lib/igt_kms.c >> index 51d735d..53bfc20 100644 >> --- a/lib/igt_kms.c >> +++ b/lib/igt_kms.c >> @@ -984,6 +984,9 @@ void igt_display_init(igt_display

Re: [Intel-gfx] [PATCH 03/11] drm/i915: Kill off intel_crtc->atomic.wait_vblank.

2015-10-26 Thread Maarten Lankhorst
Op 22-10-15 om 17:15 schreef Ville Syrjälä: > On Thu, Oct 22, 2015 at 04:50:05PM +0200, Maarten Lankhorst wrote: >> Op 22-10-15 om 15:30 schreef Ville Syrjälä: >>> On Thu, Oct 22, 2015 at 01:56:28PM +0200, Maarten Lankhorst wrote: By handling this after the atomic helper waits for vblanks ther

Re: [Intel-gfx] [PATCH] drm/i915: Add extra plane information in debugfs.

2015-10-26 Thread Maarten Lankhorst
Op 23-10-15 om 16:24 schreef Robert Fekete: > Extends i915_display_info so that for each active crtc also print > all planes associated with the pipe. This patch shows information > about each plane wrt format, size, position, rotation, and scaling. > This is very useful when debugging user space c

Re: [Intel-gfx] [PATCH 16/22] drm/i915: Introduce struct intel_dp_signal_levels

2015-10-26 Thread Ander Conselvan De Oliveira
On Sun, 2015-10-25 at 10:54 +0530, Thulasimani, Sivakumar wrote: > This is a good simplification but for a wrong implementation :). we know > that our current > implementation is wrong and needs to be done the opposite way to make > our code compliant with spec. i assume that it will then be a qu

Re: [Intel-gfx] [RFCv2 DP-typeC 5/6] drm/i915/dp: Enable Upfront link training for typeC DP support on BXT

2015-10-26 Thread Ander Conselvan De Oliveira
On Mon, 2015-10-26 at 08:27 +0530, Thulasimani, Sivakumar wrote: > > On 10/23/2015 5:37 PM, R, Durgadoss wrote: > > > -Original Message- > > > From: Ander Conselvan De Oliveira [mailto:conselv...@gmail.com] > > > Sent: Wednesday, October 21, 2015 9:08 PM > > > To: R, Durgadoss; intel-gfx@l