Re: [Intel-gfx] [PATCH i-g-t v2 1/2] lib/igt_fb : Add more overlay plane support for bxt

2015-07-21 Thread Gharpure, Mayuresh S
Hi Nabendu, PFA. I came across this patch from Damien Lespiau which prevents the topmost plane from being exposed to user space. Once this patch is merged, the following correction in i-g-t won't be required as it takes care of exposing only four planes when drmModeGetPlaneResources is called.

Re: [Intel-gfx] [PATCH 11/16] drm/i915: Add pipe level Gamma correction for CHV/BSW

2015-07-21 Thread Matt Roper
On Tue, Jul 21, 2015 at 04:40:08PM +0530, Malladi, Kausal wrote: > On Tuesday 21 July 2015 05:33 AM, Matt Roper wrote: > >On Wed, Jul 15, 2015 at 06:39:35PM +0530, Kausal Malladi wrote: ... > >>diff --git a/drivers/gpu/drm/i915/intel_display.c > >>b/drivers/gpu/drm/i915/intel_display.c > >>index 1

[Intel-gfx] [PATCH v2 2/3] drm/i915: don't use HPD_PORT_A as an alias for HPD_NONE

2015-07-21 Thread Imre Deak
Currently HPD_PORT_A is used as an alias for HPD_NONE to mean that the given port doesn't support long/short HPD pulse detection. SDVO and CRT ports are like this and for these ports we only want to know whether an hot plug event was detected on the corresponding pin. Since at least on BXT we need

[Intel-gfx] [PATCH v2 1/3] drm/i915: combine i9xx_get_hpd_pins and pch_get_hpd_pins

2015-07-21 Thread Imre Deak
These functions are quite similar, so combine them with the use of a new argument for a function that detects long pulses. This will be also needed by an upcoming patch adding support for BXT long pulse detection. No functional change. v2: - rebase on top -nightly (Daniel) Signed-off-by: Imre De

Re: [Intel-gfx] interference on display, Intel 945GM, 32bit system, kernel next

2015-07-21 Thread Krzysztof Kolasa
On 21.07.2015 16:03, Daniel Vetter wrote: > On Tue, Jul 21, 2015 at 02:48:21PM +0200, Krzysztof Kolasa wrote: >> On 21.07.2015 11:43, Chris Wilson wrote: >>> On Tue, Jul 21, 2015 at 11:07:20AM +0200, Daniel Vetter wrote: On Tue, Jul 21, 2015 at 10:58:50AM +0200, Krzysztof Kolasa wrote: > O

Re: [Intel-gfx] [drm-intel:topic/crc-pmic 2/7] intel_soc_pmic_core.c:undefined reference to `gpiod_remove_lookup_table'

2015-07-21 Thread Kumar, Shobhit
On Tuesday 21 July 2015 11:10 PM, Daniel Vetter wrote: On Tue, Jul 21, 2015 at 09:17:21PM +0530, Kumar, Shobhit wrote: On Tuesday 21 July 2015 07:35 PM, Daniel Vetter wrote: On Tue, Jul 21, 2015 at 07:22:37PM +0800, kbuild test robot wrote: tree: git://anongit.freedesktop.org/drm-intel topic

Re: [Intel-gfx] [PATCH 2/3] drm/i915: don't use HPD_PORT_A as an alias for HPD_NONE

2015-07-21 Thread Imre Deak
On Tue, 2015-07-21 at 13:51 +0530, Sivakumar Thulasimani wrote: > > > On 7/21/2015 3:13 AM, Imre Deak wrote: > > > Currently HPD_PORT_A is used as an alias for HPD_NONE to mean that the > > given port doesn't support long/short HPD pulse detection. SDVO and CRT > > ports are like this and for th

Re: [Intel-gfx] [PATCH igt] lib: add igt_debugfs_read()

2015-07-21 Thread Paulo Zanoni
2015-07-21 14:43 GMT-03:00 Daniel Vetter : > On Tue, Jul 21, 2015 at 02:08:23PM -0300, Paulo Zanoni wrote: >> From: Paulo Zanoni >> >> A helpful function for when you want to read a whole debugfs file to a >> string and don't want to worry about opening and closing file >> descriptors and assertin

Re: [Intel-gfx] [PATCH 1/3] drm/i915: combine i9xx_get_hpd_pins and pch_get_hpd_pins

2015-07-21 Thread Imre Deak
On Tue, 2015-07-21 at 13:50 +0530, Sivakumar Thulasimani wrote: > > On 7/21/2015 3:13 AM, Imre Deak wrote: > > These functions are quite similar, so combine them with the use of a new > > argument for a function that detects long pulses. This will be also > > needed by an upcoming patch adding sup

[Intel-gfx] 8086:1616 [Lenovo ThinkPad T450s] External monitor is disabled after resume

2015-07-21 Thread crs
[1.] One line summary of the problem: 8086:1616 [Lenovo ThinkPad T450s] External monitor is disabled after resume [2.] Full description of the problem/report: I have an external screen connected to my machine (T450s, via docking station) and after resuming from suspend, my external monitor is dis

Re: [Intel-gfx] [PATCH 0/3] drm/i915/bxt: HPD long/short pulse detect support on port A

2015-07-21 Thread Imre Deak
On Tue, 2015-07-21 at 11:40 +0530, Jindal, Sonika wrote: > For the patch 3, the commit message can be changed to only "long pulse > detection" instead of "long/short" because you are not adding support > for short pulse detection. Well it is support for differentiating between long and short pul

Re: [Intel-gfx] [PATCH igt] lib: add igt_debugfs_read()

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 02:08:23PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > A helpful function for when you want to read a whole debugfs file to a > string and don't want to worry about opening and closing file > descriptors and asserting buffer sizes. > > We've been using this alread

[Intel-gfx] [PATCH] drm/i915/skl: Don't clear all watermarks when updating. (v2)

2015-07-21 Thread Bob Paauwe
Clearing the watermarks for all pipes/planes when updating the watermarks for a single CRTC change seems like the wrong thing to do here. As is, this code will ony update any pipe/plane watermarks that need updating and leave the remaining set to zero. Later, the watermark checks in check_wm_state

Re: [Intel-gfx] [drm-intel:topic/crc-pmic 2/7] intel_soc_pmic_core.c:undefined reference to `gpiod_remove_lookup_table'

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 09:17:21PM +0530, Kumar, Shobhit wrote: > On Tuesday 21 July 2015 07:35 PM, Daniel Vetter wrote: > >On Tue, Jul 21, 2015 at 07:22:37PM +0800, kbuild test robot wrote: > >>tree: git://anongit.freedesktop.org/drm-intel topic/crc-pmic > >>head: b029e66fa8e39ba10dcc47b114be8

Re: [Intel-gfx] [PATCH 0/4] i915 to call hda driver on HDMI plug/unplug

2015-07-21 Thread R, Durgadoss
Hi David, >-Original Message- >From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf Of >David Henningsson >Sent: Tuesday, July 21, 2015 1:27 PM >To: alsa-de...@alsa-project.org; intel-gfx@lists.freedesktop.org; >ti...@suse.de; Vetter, Daniel; >jani.nik...@linux.inte

[Intel-gfx] [PATCH igt] lib: add igt_debugfs_read()

2015-07-21 Thread Paulo Zanoni
From: Paulo Zanoni A helpful function for when you want to read a whole debugfs file to a string and don't want to worry about opening and closing file descriptors and asserting buffer sizes. We've been using this already for kms_frontbuffer_tracking and kms_fbcon_fbt, so the only test with new

Re: [Intel-gfx] [drm-intel:topic/crc-pmic 2/7] intel_soc_pmic_core.c:undefined reference to `gpiod_remove_lookup_table'

2015-07-21 Thread Kumar, Shobhit
On Tuesday 21 July 2015 07:35 PM, Daniel Vetter wrote: On Tue, Jul 21, 2015 at 07:22:37PM +0800, kbuild test robot wrote: tree: git://anongit.freedesktop.org/drm-intel topic/crc-pmic head: b029e66fa8e39ba10dcc47b114be8da8b082493b commit: 61dd2ca2d44e493b050adbbb75bc50db11c367dd [2/7] mfd: i

[Intel-gfx] [RFCv2 00/12] TDR/watchdog timeout support for gen8 (edit: fixed coverletter)

2015-07-21 Thread Tomas Elf
This patch series introduces the following features: * Feature 1: TDR (Timeout Detection and Recovery) for gen8 execlist mode. TDR is an umbrella term for anything that goes into detecting and recovering from GPU hangs and is a term more widely used outside of the upstream driver. This feature i

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Make updating pipe without modeset atomic.

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 04:32:26PM +0200, Maarten Lankhorst wrote: > Op 21-07-15 om 16:14 schreef Daniel Vetter: > > On Tue, Jul 21, 2015 at 01:29:01PM +0200, Maarten Lankhorst wrote: > >> Instead of doing a hack during primary plane commit the state > >> is updated during atomic evasion. It handle

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Make wait_for_flips interruptible.

2015-07-21 Thread Chris Wilson
On Tue, Jul 21, 2015 at 03:59:25PM +0200, Maarten Lankhorst wrote: > Op 21-07-15 om 15:31 schreef Chris Wilson: > > On Tue, Jul 21, 2015 at 02:33:33PM +0200, Maarten Lankhorst wrote: > +if (plane->type == DRM_PLANE_TYPE_PRIMARY && old_obj) { > >>> Would feel safer is we just asked if t

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Call audio hotplug notify function

2015-07-21 Thread David Henningsson
On 2015-07-21 11:14, Daniel Vetter wrote: On Tue, Jul 21, 2015 at 09:57:25AM +0200, David Henningsson wrote: On HDMI hotplug events, notify the audio driver. This will enable the audio driver to get the information at all times (even when audio is in different powersave states), and also witho

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Make updating pipe without modeset atomic.

2015-07-21 Thread Maarten Lankhorst
Op 21-07-15 om 16:14 schreef Daniel Vetter: > On Tue, Jul 21, 2015 at 01:29:01PM +0200, Maarten Lankhorst wrote: >> Instead of doing a hack during primary plane commit the state >> is updated during atomic evasion. It handles differences in >> pipe size and the panel fitter. >> >> This is continuin

Re: [Intel-gfx] [PATCH] drm/i915: Add an optional selection from i915 of CONFIG_MMU_NOTIFIER

2015-07-21 Thread Chris Wilson
On Tue, Jul 21, 2015 at 04:17:05PM +0200, Daniel Vetter wrote: > On Tue, Jul 21, 2015 at 01:31:47PM +0100, Tvrtko Ursulin wrote: > > > > On 07/21/2015 01:16 PM, Chris Wilson wrote: > > >userptr requires mmu-notifier for full unprivileged support. Most > > >systems have mmu-notifier support already

Re: [Intel-gfx] [PATCH] drm/i915: Add an optional selection from i915 of CONFIG_MMU_NOTIFIER

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 01:31:47PM +0100, Tvrtko Ursulin wrote: > > On 07/21/2015 01:16 PM, Chris Wilson wrote: > >userptr requires mmu-notifier for full unprivileged support. Most > >systems have mmu-notifier support already enabled as a requirement for > >virtualisation support, but we should ma

Re: [Intel-gfx] [PATCH 5/6] drm/i915: Make updating pipe without modeset atomic.

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 01:29:01PM +0200, Maarten Lankhorst wrote: > Instead of doing a hack during primary plane commit the state > is updated during atomic evasion. It handles differences in > pipe size and the panel fitter. > > This is continuing on top of Daniel's work to make faster > modeset

[Intel-gfx] [PATCH v1.1 1/5] drm/i915: Handle return value in intel_pin_and_fence_fb_obj, v2.

2015-07-21 Thread Maarten Lankhorst
-EDEADLK has special meaning in atomic, but get_fence may call i915_find_fence_reg which can return -EDEADLK. This has special meaning in the atomic world, so convert the error to -EBUSY for this case. Changes since v1: - Add comment in the code. Signed-off-by: Maarten Lankhorst --- Like this?

Re: [Intel-gfx] [drm-intel:topic/crc-pmic 2/7] intel_soc_pmic_core.c:undefined reference to `gpiod_remove_lookup_table'

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 07:22:37PM +0800, kbuild test robot wrote: > tree: git://anongit.freedesktop.org/drm-intel topic/crc-pmic > head: b029e66fa8e39ba10dcc47b114be8da8b082493b > commit: 61dd2ca2d44e493b050adbbb75bc50db11c367dd [2/7] mfd: > intel_soc_pmic_core: Add lookup table for Panel Con

[Intel-gfx] [RFCv2 09/12] drm/i915: TDR/watchdog trace points.

2015-07-21 Thread Tomas Elf
Defined trace points and sprinkled the usage of these throughout the TDR/watchdog implementation. The following trace points are supported: 1. trace_i915_tdr_gpu_recovery: Called at the onset of the full GPU reset recovery path. 2. trace_i915_tdr_engine_recovery:

[Intel-gfx] [RFCv2 12/12] drm/i915: Extended error state with TDR count, watchdog count and engine reset count

2015-07-21 Thread Tomas Elf
These new TDR-specific metrics have previously been added to i915_hangcheck_info() in debugfs. During design review Chris Wilson asked for these metrics to be added to the error state as well. Signed-off-by: Tomas Elf Cc: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/i915_drv.h

Re: [Intel-gfx] interference on display, Intel 945GM, 32bit system, kernel next

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 02:48:21PM +0200, Krzysztof Kolasa wrote: > On 21.07.2015 11:43, Chris Wilson wrote: > > On Tue, Jul 21, 2015 at 11:07:20AM +0200, Daniel Vetter wrote: > >> On Tue, Jul 21, 2015 at 10:58:50AM +0200, Krzysztof Kolasa wrote: > >>> On 21.07.2015 10:41, Daniel Vetter wrote: > >>

[Intel-gfx] [RFCv2 08/12] drm/i915: Debugfs interface for per-engine hang recovery.

2015-07-21 Thread Tomas Elf
1. The i915_wedged_set() function allows us to schedule three forms of hang recovery: a) Legacy hang recovery: By passing e.g. -1 we trigger the legacy full GPU reset recovery path. b) Single engine hang recovery: By passing an engine ID in the interval of [0, I91

[Intel-gfx] [RFCv2 11/12] drm/i915: Fix __i915_wait_request() behaviour during hang detection.

2015-07-21 Thread Tomas Elf
Use is_locked parameter in __i915_wait_request() to determine if a thread should be forced to back off and retry or if it can continue sleeping. Don't return -EIO from __i915_wait_request since that is bad for the upper layers, only -EAGAIN to signify reset in progress. Also, use is_locked in trac

[Intel-gfx] [RFCv2 10/12] drm/i915: Port of Added scheduler support to __wait_request() calls

2015-07-21 Thread Tomas Elf
This is a partial port of the following patch from John Harrison's GPU scheduler patch series: (patch sent to Intel-GFX with the subject line "[Intel-gfx] [RFC 19/39] drm/i915: Added scheduler support to __wait_request() calls" on Fri 17 July 2015) Author: John Harrison Date: Th

[Intel-gfx] [RFCv2 07/12] drm/i915: Fake lost context interrupts through forced CSB check.

2015-07-21 Thread Tomas Elf
A recurring issue during long-duration operations testing of concurrent rendering tasks with intermittent hangs is that context completion interrupts following engine resets are sometimes lost. This becomes a real problem since the hardware might have completed a previously hung context following a

[Intel-gfx] [RFCv2 06/12] drm/i915: Watchdog timeout support for gen8.

2015-07-21 Thread Tomas Elf
Watchdog timeout (or "media engine reset" as it is sometimes called, even though the render engine is also supported) is a feature that allows userland applications to enable hang detection on individual batch buffers. The detection mechanism itself is mostly bound to the hardware and the only thin

[Intel-gfx] [RFCv2 05/12] drm/i915: Reinstate hang recovery work queue.

2015-07-21 Thread Tomas Elf
There used to be a work queue separating the error handler from the hang recovery path, which was removed a while back in this commit: commit b8d24a06568368076ebd5a858a011699a97bfa42 Author: Mika Kuoppala Date: Wed Jan 28 17:03:14 2015 +0200 drm/i915: Remove

[Intel-gfx] [RFCv2 04/12] drm/i915: Extending i915_gem_check_wedge to check engine reset in progress

2015-07-21 Thread Tomas Elf
i915_gem_wedge now returns a positive result in three different cases: 1. Legacy: A hang has been detected and full GPU reset has been promoted. 2. Per-engine recovery: a. A single engine reference can be passed to the function, in which case only that engine will be checked. If

[Intel-gfx] [RFCv2 00/12] TDR/watchdog timeout support for gen8

2015-07-21 Thread Tomas Elf
This patch series introduces the following features: * Feature 1: TDR (Timeout Detection and Recovery) for gen8 execlist mode. TDR is an umbrella term for anything that goes into detecting and recovering from GPU hangs and is a term more widely used outside of the upstream driver. This feature i

[Intel-gfx] [RFCv2 03/12] drm/i915: Adding TDR / per-engine reset support for gen8.

2015-07-21 Thread Tomas Elf
This change introduces support for TDR-style per-engine reset as a initial, less intrusive hang recovery option to be attempted before falling back to the legacy full GPU reset recovery mode if necessary. Initially we're only supporting gen8 but adding support for gen7 is straight-forward since we'

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Make wait_for_flips interruptible.

2015-07-21 Thread Maarten Lankhorst
Op 21-07-15 om 15:31 schreef Chris Wilson: > On Tue, Jul 21, 2015 at 02:33:33PM +0200, Maarten Lankhorst wrote: + if (plane->type == DRM_PLANE_TYPE_PRIMARY && old_obj) { >>> Would feel safer is we just asked if the CRTC had pending flips >>> irrespective of old_obj. Do you plan on moving the

[Intel-gfx] [RFCv2 02/12] drm/i915: Make i915_gem_reset_ring_status() public

2015-07-21 Thread Tomas Elf
Makes i915_gem_reset_ring_status() public for use from engine reset path in order to replicate the same behavior as in full GPU reset but for a single engine. Signed-off-by: Tomas Elf Cc: Chris Wilson Cc: Mika Kuoppala --- drivers/gpu/drm/i915/i915_drv.h | 2 ++ drivers/gpu/drm/i915/i915_gem.c

[Intel-gfx] [RFCv2 01/12] drm/i915: Early exit from semaphore_waits_for for execlist mode.

2015-07-21 Thread Tomas Elf
When submitting semaphores in execlist mode the hang checker crashes in this function because it is only runnable in ring submission mode. The reason this is of particular interest to the TDR patch series is because we use semaphores as a mean to induce hangs during testing (which is the recommende

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: remove unnecessary null test

2015-07-21 Thread Sudip Mukherjee
On Tue, Jul 21, 2015 at 03:51:40PM +0200, Daniel Vetter wrote: > On Tue, Jul 21, 2015 at 05:36:45PM +0530, Sudip Mukherjee wrote: > > While creating the debugfs file we are setting the inode->i_private to > > dev. That same dev is passed to these functions as private of struct > > seq_file via sing

Re: [Intel-gfx] [PATCH v3 1/2] drm/i915: remove unnecessary null test

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 05:36:45PM +0530, Sudip Mukherjee wrote: > While creating the debugfs file we are setting the inode->i_private to > dev. That same dev is passed to these functions as private of struct > seq_file via single_open(). Moreover single_open is setting > file->private_data->privat

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Make wait_for_flips interruptible.

2015-07-21 Thread Chris Wilson
On Tue, Jul 21, 2015 at 02:33:33PM +0200, Maarten Lankhorst wrote: > >> + if (plane->type == DRM_PLANE_TYPE_PRIMARY && old_obj) { > > Would feel safer is we just asked if the CRTC had pending flips > > irrespective of old_obj. Do you plan on moving the pending flips from > > CRTC to plane? That wo

Re: [Intel-gfx] [RFC 00/39] GPU scheduler for i915 driver

2015-07-21 Thread Daniel Vetter
On Fri, Jul 17, 2015 at 03:33:09PM +0100, john.c.harri...@intel.com wrote: > From: John Harrison > > Implemented a batch buffer submission scheduler for the i915 DRM driver. > > The general theory of operation is that when batch buffers are submitted to > the > driver, the execbuffer() code ass

Re: [Intel-gfx] [PATCH 3/3] igt/gem_create: Test to validate parameters for GEM_CREATE ioctl

2015-07-21 Thread Ankitprasad Sharma
On Fri, 2015-07-03 at 10:52 +0100, Tvrtko Ursulin wrote: > > On 07/01/2015 10:26 AM, ankitprasad.r.sha...@intel.com wrote: > > From: Ankitprasad Sharma > > > > This test validates the two parameters (size and flags) GEM_CREATE ioctl. > > > > v2: Added IGT_TEST_DESCRIPTION (Thomas Wood) > > > > Si

Re: [Intel-gfx] [PATCH 2/3] igt/gem_pread: Support to verify pread/pwrite for non-shmem backed obj

2015-07-21 Thread Ankitprasad Sharma
On Fri, 2015-07-03 at 10:37 +0100, Tvrtko Ursulin wrote: > > On 07/01/2015 10:26 AM, ankitprasad.r.sha...@intel.com wrote: > > From: Ankitprasad Sharma > > > > This patch adds support to verify pread/pwrite for non-shmem backed > > objects. It also shows the pread/pwrite speed. > > It also tests

Re: [Intel-gfx] interference on display, Intel 945GM, 32bit system, kernel next

2015-07-21 Thread Krzysztof Kolasa
On 21.07.2015 11:43, Chris Wilson wrote: > On Tue, Jul 21, 2015 at 11:07:20AM +0200, Daniel Vetter wrote: >> On Tue, Jul 21, 2015 at 10:58:50AM +0200, Krzysztof Kolasa wrote: >>> On 21.07.2015 10:41, Daniel Vetter wrote: I meant whether you can reset the bad commit and it's immediate parent >>

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Remove wait_for_pending_flips from disable_noatomic.

2015-07-21 Thread Maarten Lankhorst
Op 21-07-15 om 14:40 schreef Chris Wilson: > On Tue, Jul 21, 2015 at 02:38:14PM +0200, Maarten Lankhorst wrote: >> Op 21-07-15 om 13:35 schreef Chris Wilson: >>> On Thu, Jul 16, 2015 at 02:57:50PM +0200, Maarten Lankhorst wrote: Now that intel_display_suspend is atomic it's safe to remove

Re: [Intel-gfx] About the wait_for() macro in intel_drv.h

2015-07-21 Thread Wang, Zhi A
Ping. :) [code] #define _wait_for(COND, MS, W) ({ \ unsigned long timeout__ = jiffies + msecs_to_jiffies(MS) + 1; \ int ret__ = 0; \ while (!(COND)) { \ if (time

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Remove wait_for_pending_flips from disable_noatomic.

2015-07-21 Thread Chris Wilson
On Tue, Jul 21, 2015 at 02:38:14PM +0200, Maarten Lankhorst wrote: > Op 21-07-15 om 13:35 schreef Chris Wilson: > > On Thu, Jul 16, 2015 at 02:57:50PM +0200, Maarten Lankhorst wrote: > >> Now that intel_display_suspend is atomic it's safe to remove > >> wait_for_pending_flips from intel_crtc_disabl

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Remove wait_for_pending_flips from disable_noatomic.

2015-07-21 Thread Maarten Lankhorst
Op 21-07-15 om 13:35 schreef Chris Wilson: > On Thu, Jul 16, 2015 at 02:57:50PM +0200, Maarten Lankhorst wrote: >> Now that intel_display_suspend is atomic it's safe to remove >> wait_for_pending_flips from intel_crtc_disable_noatomic. It >> will only be used during hw load or resume, in which case

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Make wait_for_flips interruptible.

2015-07-21 Thread Maarten Lankhorst
Op 21-07-15 om 13:26 schreef Chris Wilson: > On Thu, Jul 16, 2015 at 02:57:51PM +0200, Maarten Lankhorst wrote: >> Move it from intel_crtc_atomic_commit to prepare_plane_fb. >> Waiting is done before committing, otherwise it's too late >> to undo the changes. >> >> Signed-off-by: Maarten Lankhorst

Re: [Intel-gfx] [PATCH] drm/i915: Add an optional selection from i915 of CONFIG_MMU_NOTIFIER

2015-07-21 Thread Tvrtko Ursulin
On 07/21/2015 01:16 PM, Chris Wilson wrote: userptr requires mmu-notifier for full unprivileged support. Most systems have mmu-notifier support already enabled as a requirement for virtualisation support, but we should make the option for i915 to take advantage of mmu-notifiers explicit (and ena

Re: [Intel-gfx] [PATCH] drm/i915: Send vblank event when requested in atomic commit.

2015-07-21 Thread Maarten Lankhorst
Op 21-07-15 om 14:05 schreef Maarten Lankhorst: > This is probably slightly wrong, but better than not sending events. > > Signed-off-by: Maarten Lankhorst > --- > diff --git a/drivers/gpu/drm/i915/intel_display.c > b/drivers/gpu/drm/i915/intel_display.c > index 82da2c54bd2e..10bb66ec493a 100644

[Intel-gfx] [PATCH] drm/i915: Add an optional selection from i915 of CONFIG_MMU_NOTIFIER

2015-07-21 Thread Chris Wilson
userptr requires mmu-notifier for full unprivileged support. Most systems have mmu-notifier support already enabled as a requirement for virtualisation support, but we should make the option for i915 to take advantage of mmu-notifiers explicit (and enable by default so that regular userspace can ta

[Intel-gfx] [PATCH v3 2/2] drm/i915: remove redundant if check

2015-07-21 Thread Sudip Mukherjee
The extra check for connector_type is not required as we are already checking for connector_type != DRM_MODE_CONNECTOR_DisplayPort. The check was added by commit eb3394faeb97 ("drm/i915: Add debugfs test control files for Displayport compliance testing") Signed-off-by: Sudip Mukherjee --- v3: It

[Intel-gfx] [PATCH v3 1/2] drm/i915: remove unnecessary null test

2015-07-21 Thread Sudip Mukherjee
While creating the debugfs file we are setting the inode->i_private to dev. That same dev is passed to these functions as private of struct seq_file via single_open(). Moreover single_open is setting file->private_data->private to dev. So at this point it can never be NULL. This check was added by

[Intel-gfx] [PATCH] drm/i915: Send vblank event when requested in atomic commit.

2015-07-21 Thread Maarten Lankhorst
This is probably slightly wrong, but better than not sending events. Signed-off-by: Maarten Lankhorst --- diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 82da2c54bd2e..10bb66ec493a 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Remove wait_for_pending_flips from disable_noatomic.

2015-07-21 Thread Chris Wilson
On Thu, Jul 16, 2015 at 02:57:50PM +0200, Maarten Lankhorst wrote: > Now that intel_display_suspend is atomic it's safe to remove > wait_for_pending_flips from intel_crtc_disable_noatomic. It > will only be used during hw load or resume, in which case there > will be no pending flips anyway. A WAR

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Handle return value in intel_pin_and_fence_fb_obj.

2015-07-21 Thread Chris Wilson
On Thu, Jul 16, 2015 at 02:57:47PM +0200, Maarten Lankhorst wrote: > -EDEADLK has special meaning in atomic, but get_fence may call > i915_find_fence_reg which can return -EDEADLK. > > This has special meaning in the atomic world, so convert the error > to -EBUSY for this case. > > Signed-off-by:

[Intel-gfx] [PATCH 0/6] drm/i915: Fastboot for everyone!

2015-07-21 Thread Maarten Lankhorst
This continues the previous work to make fastboot more atomic. Looking at the changes in pipe_config_compare I guess it was broken for everyone, but with some splitting it was easy to revive it and make it less scary. Maarten Lankhorst (6): drm/atomic: add connectors_changed to separate it from

[Intel-gfx] [PATCH 3/6] drm/i915: Set csc coefficients in update_pipe_size.

2015-07-21 Thread Maarten Lankhorst
This might not have been set during boot, and when we preserve the initial mode this can result in a black screen. Cc: Daniel Stone Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display

[Intel-gfx] [PATCH 4/6] drm/i915: Always try to inherit the initial fb.

2015-07-21 Thread Maarten Lankhorst
The initial state is read out correctly and the state is atomic, so it's safe to preserve the fb without any hacks if it's suitable. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_fbdev.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_fbdev.c b

[Intel-gfx] [PATCH 2/6] drm/atomic: pass old crtc state to atomic_begin/flush.

2015-07-21 Thread Maarten Lankhorst
In intel it's useful to keep track of some state changes with old crtc state vs new state, for example to disable initial planes or when a modeset's prevented during fastboot. Cc: dri-de...@lists.freedesktop.org Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/atmel-hlcdc/atmel_hlcdc_crtc.c

[Intel-gfx] [PATCH 6/6] drm/i915: skip modeset if compatible for everyone.

2015-07-21 Thread Maarten Lankhorst
This is done as a separate commit, to make it easier to revert when things break. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_drv.h | 1 - drivers/gpu/drm/i915/i915_params.c | 5 - drivers/gpu/drm/i915/intel_display.c | 3 +-- 3 files changed, 1 insertion(+), 8 dele

[Intel-gfx] [PATCH 5/6] drm/i915: Make updating pipe without modeset atomic.

2015-07-21 Thread Maarten Lankhorst
Instead of doing a hack during primary plane commit the state is updated during atomic evasion. It handles differences in pipe size and the panel fitter. This is continuing on top of Daniel's work to make faster modesets atomic, and not yet enabled by default. Signed-off-by: Maarten Lankhorst --

[Intel-gfx] [PATCH 1/6] drm/atomic: add connectors_changed to separate it from mode_changed, v2

2015-07-21 Thread Maarten Lankhorst
This can be a separate case from mode_changed, when connectors stay the same but only the mode is different. Drivers may choose to implement specific optimizations to prevent a full modeset for this case. Changes since v1: - Update kerneldocs slightly. Cc: dri-de...@lists.freedesktop.org Signed-o

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Make wait_for_flips interruptible.

2015-07-21 Thread Chris Wilson
On Thu, Jul 16, 2015 at 02:57:51PM +0200, Maarten Lankhorst wrote: > Move it from intel_crtc_atomic_commit to prepare_plane_fb. > Waiting is done before committing, otherwise it's too late > to undo the changes. > > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_atomic.c |

[Intel-gfx] [drm-intel:topic/crc-pmic 2/7] intel_soc_pmic_core.c:undefined reference to `gpiod_remove_lookup_table'

2015-07-21 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel topic/crc-pmic head: b029e66fa8e39ba10dcc47b114be8da8b082493b commit: 61dd2ca2d44e493b050adbbb75bc50db11c367dd [2/7] mfd: intel_soc_pmic_core: Add lookup table for Panel Control as GPIO signal config: x86_64-randconfig-i0-201529 (attached as .confi

Re: [Intel-gfx] [PATCH 11/16] drm/i915: Add pipe level Gamma correction for CHV/BSW

2015-07-21 Thread Malladi, Kausal
On Tuesday 21 July 2015 05:33 AM, Matt Roper wrote: On Wed, Jul 15, 2015 at 06:39:35PM +0530, Kausal Malladi wrote: CHV/BSW platform supports various Gamma correction modes, which are: 1. Legacy 8-bit mode 2. 10-bit CGM (Color Gamut Mapping) mode This patch does the following: 1. Adds the core

Re: [Intel-gfx] [PATCH 10/16] drm/i915: Add set_property handler for pipe Gamma correction on CHV/BSW

2015-07-21 Thread Malladi, Kausal
On Tuesday 21 July 2015 05:33 AM, Matt Roper wrote: On Wed, Jul 15, 2015 at 06:39:34PM +0530, Kausal Malladi wrote: This patch adds set_property handler for Gamma color correction and enhancement capability at Pipe level on CHV/BSW platform. The set function just attaches the Gamma blob to CRTC

[Intel-gfx] [drm-intel:topic/drm-misc 18/18] drivers/gpu/drm/i915/intel_crt.c:801:2: warning: initialization from incompatible pointer type

2015-07-21 Thread kbuild test robot
tree: git://anongit.freedesktop.org/drm-intel topic/drm-misc head: 1d7828f8505146eff1af8f2f973310e9df1f3b53 commit: 1d7828f8505146eff1af8f2f973310e9df1f3b53 [18/18] drm: Make the connector dpms callback return a value, v2. config: x86_64-rhel (attached as .config) reproduce: git checkout 1d7

Re: [Intel-gfx] [RFC 27/39] drm/i915: Add sync wait support to scheduler

2015-07-21 Thread Daniel Vetter
On Fri, Jul 17, 2015 at 03:33:36PM +0100, john.c.harri...@intel.com wrote: > From: John Harrison > > There is a sync framework to allow work for multiple independent > systems to be synchronised with each other but without stalling > the CPU whether in the application or the driver. This patch ad

Re: [Intel-gfx] [PATCH v3] drm/i915: Use two 32bit reads for select 64bit REG_READ ioctls

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 10:45:45AM +0100, Chris Wilson wrote: > On Tue, Jul 21, 2015 at 08:49:31AM +0200, Daniel Vetter wrote: > > On Fri, Jul 17, 2015 at 05:10:25PM +0200, Michał Winiarski wrote: > > > On Thu, Jul 16, 2015 at 12:37:56PM +0100, Chris Wilson wrote: > > > > Since the hardware sometim

Re: [Intel-gfx] [PATCH v3] drm/i915: Use two 32bit reads for select 64bit REG_READ ioctls

2015-07-21 Thread Chris Wilson
On Tue, Jul 21, 2015 at 08:49:31AM +0200, Daniel Vetter wrote: > On Fri, Jul 17, 2015 at 05:10:25PM +0200, Michał Winiarski wrote: > > On Thu, Jul 16, 2015 at 12:37:56PM +0100, Chris Wilson wrote: > > > Since the hardware sometimes mysteriously totally flummoxes the 64bit > > > read of a 64bit regi

Re: [Intel-gfx] [PATCH] drm/i915: Update HAS_PSR macro to include all gen>=8 platforms

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 10:31:19AM +0100, Damien Lespiau wrote: > On Tue, Jul 21, 2015 at 02:48:31PM +0530, Sonika Jindal wrote: > > This is to get PSR support for bxt. > > > > Signed-off-by: Sonika Jindal > > Maybe with a drm/i915/bxt prefix: > > Reviewed-by: Damien Lespiau Is this actually

Re: [Intel-gfx] interference on display, Intel 945GM, 32bit system, kernel next

2015-07-21 Thread Chris Wilson
On Tue, Jul 21, 2015 at 11:07:20AM +0200, Daniel Vetter wrote: > On Tue, Jul 21, 2015 at 10:58:50AM +0200, Krzysztof Kolasa wrote: > > On 21.07.2015 10:41, Daniel Vetter wrote: > > > I meant whether you can reset the bad commit and it's immediate parent > > > extensively to make sure the bisect is

Re: [Intel-gfx] [PATCH i-g-t v3] Android.mk: Disable tools that do not build for android

2015-07-21 Thread Gore, Tim
Tim Gore  Intel Corporation (UK) Ltd. - Co. Reg. #1134945 - Pipers Way, Swindon SN3 1RJ > -Original Message- > From: Intel-gfx [mailto:intel-gfx-boun...@lists.freedesktop.org] On Behalf > Of Daniel Vetter > Sent: Tuesday, July 21, 2015 7:54 AM > To: Morton, Derek J > Cc: Intel Graphics

Re: [Intel-gfx] [RFC 07/39] drm/i915: Start of GPU scheduler

2015-07-21 Thread Daniel Vetter
On Fri, Jul 17, 2015 at 03:33:16PM +0100, john.c.harri...@intel.com wrote: > From: John Harrison > > Initial creation of scheduler source files. Note that this patch implements > most > of the scheduler functionality but does not hook it in to the driver yet. It > also leaves the scheduler code

Re: [Intel-gfx] [PATCH i-g-t v3] Android.mk: Disable tools that do not build for android

2015-07-21 Thread Morton, Derek J
> > >-Original Message- >From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter >Sent: Tuesday, July 21, 2015 7:54 AM >To: Morton, Derek J >Cc: Wood, Thomas; Intel Graphics Development >Subject: Re: [Intel-gfx] [PATCH i-g-t v3] Android.mk: Disable tools that do >not

Re: [Intel-gfx] [PATCH] drm/i915: Update HAS_PSR macro to include all gen>=8 platforms

2015-07-21 Thread Damien Lespiau
On Tue, Jul 21, 2015 at 02:48:31PM +0530, Sonika Jindal wrote: > This is to get PSR support for bxt. > > Signed-off-by: Sonika Jindal Maybe with a drm/i915/bxt prefix: Reviewed-by: Damien Lespiau -- Damien > --- > drivers/gpu/drm/i915/i915_drv.h |5 ++--- > 1 file changed, 2 insertions

[Intel-gfx] [PATCH] drm/i915: Update HAS_PSR macro to include all gen>=8 platforms

2015-07-21 Thread Sonika Jindal
This is to get PSR support for bxt. Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/i915_drv.h |5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h index 718170c..54d2729 100644 --- a/drivers/gpu/drm/i

Re: [Intel-gfx] [RFC 19/39] drm/i915: Added scheduler support to __wait_request() calls

2015-07-21 Thread Daniel Vetter
On Fri, Jul 17, 2015 at 03:33:28PM +0100, john.c.harri...@intel.com wrote: > From: John Harrison > > The scheduler can cause batch buffers, and hence requests, to be submitted to > the ring out of order and asynchronously to their submission to the driver. > Thus > at the point of waiting for th

Re: [Intel-gfx] [PATCH] drm/i915: Update atomic state when removing mst connector.

2015-07-21 Thread Maarten Lankhorst
Op 21-07-15 om 11:09 schreef Daniel Vetter: > On Tue, Jul 21, 2015 at 09:56:15AM +0200, Maarten Lankhorst wrote: >> Signed-off-by: Maarten Lankhorst >> --- >> drivers/gpu/drm/i915/intel_dp_mst.c | 44 >> - >> 1 file changed, 43 insertions(+), 1 deletion(-) >>

Re: [Intel-gfx] [PATCH 2/4] drm/i915: Call audio hotplug notify function

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 09:57:25AM +0200, David Henningsson wrote: > On HDMI hotplug events, notify the audio driver. This will enable > the audio driver to get the information at all times (even when > audio is in different powersave states), and also without reading > it from the hardware. > > S

Re: [Intel-gfx] [PATCH] drm/i915: Update atomic state when removing mst connector.

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 09:56:15AM +0200, Maarten Lankhorst wrote: > Signed-off-by: Maarten Lankhorst > --- > drivers/gpu/drm/i915/intel_dp_mst.c | 44 > - > 1 file changed, 43 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_dp_mst.c

Re: [Intel-gfx] interference on display, Intel 945GM, 32bit system, kernel next

2015-07-21 Thread Daniel Vetter
On Tue, Jul 21, 2015 at 10:58:50AM +0200, Krzysztof Kolasa wrote: > On 21.07.2015 10:41, Daniel Vetter wrote: > > I meant whether you can reset the bad commit and it's immediate parent > > extensively to make sure the bisect is really correct. gpu's occasionally > > take a while to hang themselves,

Re: [Intel-gfx] interference on display, Intel 945GM, 32bit system, kernel next

2015-07-21 Thread Krzysztof Kolasa
On 21.07.2015 10:41, Daniel Vetter wrote: > I meant whether you can reset the bad commit and it's immediate parent > extensively to make sure the bisect is really correct. gpu's occasionally > take a while to hang themselves, so could be that the bisect was > mislead somewhere. Again I will bisec

Re: [Intel-gfx] [RFC 24/39] drm/i915: Support for 'unflushed' ring idle

2015-07-21 Thread Daniel Vetter
On Fri, Jul 17, 2015 at 03:33:33PM +0100, john.c.harri...@intel.com wrote: > From: John Harrison > > When the seqno wraps around zero, the entire GPU is forced to be idle > for some reason (possibly only to work around issues with hardware > semaphores but no-one seems too sure!). This causes a p

Re: [Intel-gfx] [PATCH 2/3] drm/i915: don't use HPD_PORT_A as an alias for HPD_NONE

2015-07-21 Thread Sivakumar Thulasimani
On 7/21/2015 3:13 AM, Imre Deak wrote: Currently HPD_PORT_A is used as an alias for HPD_NONE to mean that the given port doesn't support long/short HPD pulse detection. SDVO and CRT ports are like this and for these ports we only want to know whether an hot plug event was detected on the corres

Re: [Intel-gfx] [PATCH 1/3] drm/i915: combine i9xx_get_hpd_pins and pch_get_hpd_pins

2015-07-21 Thread Sivakumar Thulasimani
On 7/21/2015 3:13 AM, Imre Deak wrote: These functions are quite similar, so combine them with the use of a new argument for a function that detects long pulses. This will be also needed by an upcoming patch adding support for BXT long pulse detection. No functional change. Signed-off-by: Imr

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Make wait_for_flips interruptible.

2015-07-21 Thread Maarten Lankhorst
Op 21-07-15 om 08:51 schreef Daniel Vetter: > On Mon, Jul 20, 2015 at 04:52:11PM +0200, Maarten Lankhorst wrote: >> Op 16-07-15 om 14:57 schreef Maarten Lankhorst: >>> Move it from intel_crtc_atomic_commit to prepare_plane_fb. >>> Waiting is done before committing, otherwise it's too late >>> to un

Re: [Intel-gfx] [RFC 04/39] drm/i915: Prelude to splitting i915_gem_do_execbuffer in two

2015-07-21 Thread Daniel Vetter
On Fri, Jul 17, 2015 at 03:33:13PM +0100, john.c.harri...@intel.com wrote: > From: John Harrison > > The scheduler decouples the submission of batch buffers to the driver with > their > submission to the hardware. This basically means splitting the execbuffer() > function in half. This change re

[Intel-gfx] [PATCH 2/4] drm/i915: Call audio hotplug notify function

2015-07-21 Thread David Henningsson
On HDMI hotplug events, notify the audio driver. This will enable the audio driver to get the information at all times (even when audio is in different powersave states), and also without reading it from the hardware. Signed-off-by: David Henningsson --- drivers/gpu/drm/i915/i915_drv.h|1

Re: [Intel-gfx] [RFC 05/39] drm/i915: Split i915_dem_do_execbuffer() in half

2015-07-21 Thread Daniel Vetter
On Fri, Jul 17, 2015 at 03:33:14PM +0100, john.c.harri...@intel.com wrote: > From: John Harrison > > Split the execbuffer() function in half. The first half collects and validates > all the information requried to process the batch buffer. It also does all the > object pinning, relocations, activ

[Intel-gfx] [PATCH 1/4] drm/i915: Add audio hotplug info struct

2015-07-21 Thread David Henningsson
This struct will be used to transfer information from the i915 driver to the hda driver on HDMI hotplug events. Signed-off-by: David Henningsson --- include/drm/i915_component.h | 19 +++ 1 file changed, 19 insertions(+) diff --git a/include/drm/i915_component.h b/include/drm/

[Intel-gfx] [PATCH 3/4] ALSA: hda - Dispatch incoming HDMI hotplug i915 callback

2015-07-21 Thread David Henningsson
This lets interested codec(s) be notified of HDMI hotplug events sent from the i915 driver. Signed-off-by: David Henningsson --- include/sound/hdaudio.h |4 sound/hda/hdac_i915.c | 24 2 files changed, 28 insertions(+) diff --git a/include/sound/hdaudio.h b

[Intel-gfx] [PATCH 0/4] i915 to call hda driver on HDMI plug/unplug

2015-07-21 Thread David Henningsson
This patch set aims to resolve three problems: * The first - and most serious one - is that the audio driver is not woken up properly when in power save modes, especially not when the HDA controller is in D3. By having the i915 driver call directly into the hda driver, the HDA driver is

  1   2   >