Re: [Intel-gfx] [PATCH v2 00/10] Color Manager Implementation

2015-06-04 Thread Jindal, Sonika
HI Kausal, You don't need to send the entire series again . Just send the updated patch --in-reply-to to the last message. Otherwise the thread gets lost. You can send the entire series once the review is complete and you feel that the patches are too nested inside. Please keep sending the patch

Re: [Intel-gfx] [PATCH] drm/i915 : Added Programming of the MOCS

2015-06-04 Thread Matt Turner
On Thu, Jun 4, 2015 at 11:27 AM, Peter Antoine wrote: > This change adds the programming of the MOCS registers to the gen 9+ > platforms. This change set programs the MOCS register values to a set > of values that are defined to be optimal. > > It creates a fixed register set that is programmed ac

Re: [Intel-gfx] [PATCH] drm/i915: Avoid fluctuating to UNKNOWN connector status during forced probes

2015-06-04 Thread Chris Wilson
On Thu, Jun 04, 2015 at 07:28:31PM +0300, Ville Syrjälä wrote: > So besides avoiding the disconnected->unknown transition, the other thing > we now seem to do is set intel_tv->type to -1 when we find that things > are disconnected. However that doesn't seem to be user visible, and I > can't see any

Re: [Intel-gfx] Playing with the xf86-video-intel code

2015-06-04 Thread Chris Wilson
On Sun, May 31, 2015 at 11:50:26AM +0200, Bálint Pámer wrote: >Hello! > >In a nutshell: >I have a problem where my linux box hooked up to my sharp lcd tv can only >output 1080p@30hz OR 1080i@60hz under linux (opensuse 13.2), but CAN >output 1080p@60hz under windows. (meaning in

Re: [Intel-gfx] [RFC PATCH 00/11] drm/i915: Expose OA metrics via perf PMU

2015-06-04 Thread Robert Bragg
On Wed, May 27, 2015 at 4:39 PM, <> wrote: > On Thu, May 21, 2015 at 12:17:48AM +0100, Robert Bragg wrote: >> > >> > So for me the 'natural' way to represent this in perf would be through >> > event groups. Create a perf event for every single event -- yes this is >> > 53 events. >> >> So when I wa

[Intel-gfx] Fwd: [PATCH] drm/i915: Fix IPS related flicker

2015-06-04 Thread Rodrigo Vivi
I just noticed that I had forgotten to reply-all... Jani, would you consider merge this fix with the explanation above related to Ville's question? or do you want/need any action here? Thanks, Rodrigo. -- Forwarded message -- From: Rodrigo Vivi Date: Fri, May 29, 2015 at 9:45

[Intel-gfx] [PATCH] drm/i915 : Added Programming of the MOCS

2015-06-04 Thread Peter Antoine
This change adds the programming of the MOCS registers to the gen 9+ platforms. This change set programs the MOCS register values to a set of values that are defined to be optimal. It creates a fixed register set that is programmed across the different engines so that all engines have the same tab

Re: [Intel-gfx] [PATCH 14/56] drm/i915: Make retire condition check for requests not objects

2015-06-04 Thread John Harrison
Note that this is a new patch to the series. The issue was found when debugging a problem with the conversion to struct fence that is still in progress. Basically, it was possible to get continuous TDR timeouts on the ECS ring because the start of day initialisation request never got retired an

[Intel-gfx] [PATCH 14/56] drm/i915: Make retire condition check for requests not objects

2015-06-04 Thread John . C . Harrison
From: John Harrison A previous patch (read-read optimisation) changed the early exit condition in i915_gem_retire_requests_ring() from checking the request list to checking the active list. This assumes that all requests have objects associated with them which are placed on the active list. The r

[Intel-gfx] [PATCH i-g-t] pm_rpm: Update the debugfs filename

2015-06-04 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- tests/pm_rpm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tests/pm_rpm.c b/tests/pm_rpm.c index a1f4013..2a83a75 100644 --- a/tests/pm_rpm.c +++ b/tests/pm_rpm.c @@ -669,9 +669,9 @@ static void setup_pc8(void) if (!supports_pc

[Intel-gfx] [PATCH 1/2] drm/i915: Make pc8_status report status for all runtime PM platforms

2015-06-04 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index 47636f3..d8bd4e1 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/

[Intel-gfx] [PATCH 2/2] drm/i915: Add runtime PM's usage_count in i915_runtime_pm_status

2015-06-04 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_debugfs.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_debugfs.c b/drivers/gpu/drm/i915/i915_debugfs.c index d8bd4e1..92cf273 100644 --- a/drivers/gpu/drm/i915/i915_debugfs.c +++ b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 5/7] drm/i915/skl: Update the cached CDCLK at the end of set_cdclk()

2015-06-04 Thread Damien Lespiau
Ville's and Mika's cdclk series was in flight at the same time as the SKL S3 patches so we were missing that update. intel_update_max_cdclk() and intel_update_cdclk() had to be moved up a bit to avoid forward declarations. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c |

[Intel-gfx] [PATCH 1/7] drm/i915: Make broxton_set_cdclk() static

2015-06-04 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 2 +- drivers/gpu/drm/i915/intel_drv.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index c38c297..a96f181 100644 --- a

[Intel-gfx] [PATCH 3/7] drm/i915/skl: Don't warn if reading back DPLL0 is disabled

2015-06-04 Thread Damien Lespiau
We can operate with DPLL0 off with CDCLK backed by the 24Mhz reference clock, and that's a supported configuration. Don't warn when notice DPLL0 is off then. We still have a separate warn at boot if cdclk is disabled (because we don't currently try to handle the case (that shouldn't happen on SKL

[Intel-gfx] [PATCH 6/7] drm/i915/bxt: Use intel_update_cdclk() to update dev_priv->cdclk_freq

2015-06-04 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 47c765d..a232dc9 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/dr

[Intel-gfx] [PATCH 7/7] drm/i915/skl: Warn if the cached cdclk freq is not the requested one

2015-06-04 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 4 1 file changed, 4 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index a232dc9..a018465 100644 --- a/drivers/gpu/drm/i915/intel_display.c +++ b/drivers/gpu/dr

[Intel-gfx] [PATCH 2/7] drm/i915/skl: Derive the max CDCLK from DFSM

2015-06-04 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/i915_reg.h | 7 +++ drivers/gpu/drm/i915/intel_display.c | 13 - 2 files changed, 19 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h index 0f72c0e..cfe262c 100

[Intel-gfx] [PATCH 4/7] drm/i915: Don't display the boot CDCLK twice

2015-06-04 Thread Damien Lespiau
intel_update_cdclk() will already display the boot CDCLK for DDI platforms, no need to repeat there. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_ddi.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Add debug messages at the start/end of DMC firmware loading

2015-06-04 Thread Damien Lespiau
On Thu, Jun 04, 2015 at 04:47:00PM +0100, Chris Wilson wrote: > On Thu, Jun 04, 2015 at 04:42:16PM +0100, Damien Lespiau wrote: > > It's handy to have debug message for the "big" events and this one > > qualifies IMHO. Also helpful to see what's happening while we're loading > > the firwmare and ho

Re: [Intel-gfx] [PATCH] drm/i915: Make sure our labels start at column 0

2015-06-04 Thread Ville Syrjälä
On Thu, Jun 04, 2015 at 04:56:18PM +0100, Damien Lespiau wrote: > I noticed one of those and it turned out we have a few lingering around. Yuck. I'd prefer we got the other way. Consider the following diffs for example: diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.

Re: [Intel-gfx] [PATCH] drm/i915: Avoid fluctuating to UNKNOWN connector status during forced probes

2015-06-04 Thread Ville Syrjälä
On Thu, Jun 04, 2015 at 04:26:18PM +0100, Chris Wilson wrote: > For old-school component TV and CRT connectors, we require a heavyweight > load-detection mechanism. This involves setting up a CRTC and sending a > signal to the output, before reading back any response. As that is quite > slow and CP

Re: [Intel-gfx] [PATCH igt 4/4] tests/kms_psr_sink_crc: test even if PSR is disabled by default

2015-06-04 Thread Rodrigo Vivi
Acked-by: Rodrigo Vivi On Thu, Jun 4, 2015 at 7:31 AM, Paulo Zanoni wrote: > From: Paulo Zanoni > > Use the igt_set_module_param_int() call to enable it, then restore the > previous value after we are done testing. > > With this, we can change the psr_enabled() function to psr_possible(): > the

[Intel-gfx] [PATCH] drm/i915: Make sure our labels start at column 0

2015-06-04 Thread Damien Lespiau
I noticed one of those and it turned out we have a few lingering around. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_display.c | 4 ++-- drivers/gpu/drm/i915/intel_sprite.c | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Add debug messages at the start/end of DMC firmware loading

2015-06-04 Thread Chris Wilson
On Thu, Jun 04, 2015 at 04:42:16PM +0100, Damien Lespiau wrote: > It's handy to have debug message for the "big" events and this one > qualifies IMHO. Also helpful to see what's happening while we're loading > the firwmare and how much time it takes. > > Signed-off-by: Damien Lespiau > --- > dri

[Intel-gfx] [PATCH 1/2] drm/i915: Remove unnecessary () used with WARN()

2015-06-04 Thread Damien Lespiau
In Linux, macros are usually well done and protect their arguments properly, even avoiding multiple evaluations of the parameters. Extra () are really not needed. Cc: Suketu Shah Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_csr.c | 3 ++- 1 file changed, 2 insertions(+), 1 delet

[Intel-gfx] [PATCH 2/2] drm/i915/skl: Add debug messages at the start/end of DMC firmware loading

2015-06-04 Thread Damien Lespiau
It's handy to have debug message for the "big" events and this one qualifies IMHO. Also helpful to see what's happening while we're loading the firwmare and how much time it takes. Signed-off-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_csr.c | 3 +++ 1 file changed, 3 insertions(+) diff -

[Intel-gfx] [PATCH] drm/i915: Avoid fluctuating to UNKNOWN connector status during forced probes

2015-06-04 Thread Chris Wilson
For old-school component TV and CRT connectors, we require a heavyweight load-detection mechanism. This involves setting up a CRTC and sending a signal to the output, before reading back any response. As that is quite slow and CPU heavy, the process is only performed when the output detection is fo

Re: [Intel-gfx] [PATCH v6 3/8] drm/i915: Unify ilk and hsw .get_aux_clock_divider

2015-06-04 Thread Ville Syrjälä
On Thu, Jun 04, 2015 at 04:24:43PM +0300, Jani Nikula wrote: > On Wed, 03 Jun 2015, Mika Kahola wrote: > > From: Ville Syrjälä > > > > ilk_get_aux_clock_divider() is now a subset of > > hsw_get_aux_clock_divider() so unify them. > > I do like the clarity of having these two separate, I see no c

[Intel-gfx] [PATCH] drm/i915/bxt: fix DDI PHY vswing scale value setting

2015-06-04 Thread Imre Deak
According to bspec the DDI PHY vswing scale value is "don't care" in case the scale enable bit [27] is clear. But this doesn't seem to be correct. The scale value seems to also matter if the scale mode bit [26] is set. So both bit 26 and 27 depend on the value. Setting the scale value to 0 while ei

Re: [Intel-gfx] [PATCH] drm/i915/skl: replace csr_mutex by completion in csr firmware loading

2015-06-04 Thread Dave Gordon
On 04/06/15 06:59, Sagar Arun Kamble wrote: > > Hi Daniel, > > We already are grabbing RPM reference before start of DMC FW load and > release post load completion. > > DC5/6 can happen without Runtime PM as well. So we need to wait for CSR > FW load for some time once we disable PW2. > > Havin

[Intel-gfx] [PATCH igt 1/4] tests/template: add IGT_TEST_DESCRIPTION

2015-06-04 Thread Paulo Zanoni
From: Paulo Zanoni So people that write tests based on the template don't forget to use the macro. Signed-off-by: Paulo Zanoni --- tests/template.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/template.c b/tests/template.c index 24fd850..4b5794b 100644 --- a/tests/template.c +++

[Intel-gfx] [PATCH igt 3/4] tests/kms_fbc_crc: run even if FBC is disabled by default

2015-06-04 Thread Paulo Zanoni
From: Paulo Zanoni We may not be perfect, but if we don't even test, we will probably only get worse over time. The function called makes sure we restore whatever was the original FBC parameter when we exit the test, so this should not affect the other tests. Signed-off-by: Paulo Zanoni --- t

[Intel-gfx] [PATCH igt 4/4] tests/kms_psr_sink_crc: test even if PSR is disabled by default

2015-06-04 Thread Paulo Zanoni
From: Paulo Zanoni Use the igt_set_module_param_int() call to enable it, then restore the previous value after we are done testing. With this, we can change the psr_enabled() function to psr_possible(): the only requirement should be that we have a PSR capable sink. The test should now be able t

[Intel-gfx] [PATCH igt 2/4] lib/igt_aux: add functions to manipulate i915.ko parameters

2015-06-04 Thread Paulo Zanoni
From: Paulo Zanoni Some i915.ko features have very nice IGT tests, which are never executed because the features are disabled by default. This leads to unnoticed regressions both in the Kernel and in the IGT tests. We have seen this multiple times, for example, on FBC and PSR. We want to be abl

Re: [Intel-gfx] [PATCH v2 1/7] drm/i915/gen8: Add infrastructure to initialize WA batch buffers

2015-06-04 Thread Siluvery, Arun
On 02/06/2015 19:47, Dave Gordon wrote: On 02/06/15 19:36, Siluvery, Arun wrote: On 01/06/2015 11:22, Daniel, Thomas wrote: Indeed, allocating an extra scratch page in the context would simplify vma/mm management. A trick might be to allocate the scratch page at the start, then offset the lrc

Re: [Intel-gfx] [PATCH 03/55] drm/i915: i915_add_request must not fail

2015-06-04 Thread John Harrison
On 02/06/2015 19:16, Tomas Elf wrote: On 29/05/2015 17:43, john.c.harri...@intel.com wrote: From: John Harrison The i915_add_request() function is called to keep track of work that has been written to the ring buffer. It adds epilogue commands to track progress (seqno updates and such), move

Re: [Intel-gfx] [PATCH v6 0/8] All sort of cdclk stuff

2015-06-04 Thread Jani Nikula
On Thu, 04 Jun 2015, Damien Lespiau wrote: > On Wed, Jun 03, 2015 at 03:45:06PM +0300, Mika Kahola wrote: >> This patch series rebases Ville's original cdclk patch series >> excluding the ones that has already been reviewed. >> >> http://lists.freedesktop.org/archives/intel-gfx/2014-November

Re: [Intel-gfx] [PATCH v6 8/8] drm/i915: HSW cdclk support

2015-06-04 Thread Jani Nikula
On Wed, 03 Jun 2015, Mika Kahola wrote: > From: Ville Syrjälä > > Implement support for changing the cdclk frequency during runtime on > HSW. VLV/CHV already have support for this, so we can follow their > example for the most part. Only the actual hardware programming differs, > the rest is pret

Re: [Intel-gfx] [PATCH] perf/x86/intel/pt: Fix lockdep interaction

2015-06-04 Thread Alexander Shishkin
Tvrtko Ursulin writes: > From: Tvrtko Ursulin > > Since this drivers creates attributes on the heap, lockdep > gets upset and disabled itself. > > Fix by setting ignore_lockdep flags for problematic attributes. > > Signed-off-by: Tvrtko Ursulin > Cc: Alexander Shishkin > Cc: Ingo Molnar > Cc:

Re: [Intel-gfx] [PATCH v6 3/8] drm/i915: Unify ilk and hsw .get_aux_clock_divider

2015-06-04 Thread Jani Nikula
On Wed, 03 Jun 2015, Mika Kahola wrote: > From: Ville Syrjälä > > ilk_get_aux_clock_divider() is now a subset of > hsw_get_aux_clock_divider() so unify them. I do like the clarity of having these two separate, especially with the early return in the ilk version and the w/a in the hsw/bdw version

Re: [Intel-gfx] [PATCH 25/55] drm/i915: Update i915_gem_object_sync() to take a request structure

2015-06-04 Thread John Harrison
On 02/06/2015 19:26, Tomas Elf wrote: On 29/05/2015 17:43, john.c.harri...@intel.com wrote: From: John Harrison The plan is to pass requests around as the basic submission tracking structure rather than rings and contexts. This patch updates the i915_gem_object_sync() code path. v2: Much m

[Intel-gfx] [PATCH v2 09/27] drm/i915: Assign a new pll from the crtc check function.

2015-06-04 Thread Maarten Lankhorst
Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 60 1 file changed, 26 insertions(+), 34 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 41e0f50b3eae..5ce78fec2575 100644

[Intel-gfx] [PATCH v2 24/27] drm/i915: Use full atomic modeset.

2015-06-04 Thread Maarten Lankhorst
Huzzah! \o/ Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic.c | 128 drivers/gpu/drm/i915/intel_display.c | 280 ++- drivers/gpu/drm/i915/intel_drv.h | 5 - 3 files changed, 42 insertions(+), 371 deletions(-) diff --

[Intel-gfx] [PATCH v2 23/27] drm/i915: Remove transitional references from intel_plane_atomic_check.

2015-06-04 Thread Maarten Lankhorst
All transitional plane helpers are gone, party! Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic_plane.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_atomic_plane.c b/drivers/gpu/drm/i915/intel_atom

[Intel-gfx] [PATCH v2 10/27] drm/i915: Do not run most checks when there's no modeset.

2015-06-04 Thread Maarten Lankhorst
The only reason to check anything without modeset was for fastboot audio_changed/infoframe_changed changes. Now that's handled during hw readout parameters shouldn't change any more when all things stay identical. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 27 ++

[Intel-gfx] [PATCH v2 11/27] drm/i915: Split skl_update_scaler, v2.

2015-06-04 Thread Maarten Lankhorst
It's easier to read separate functions for crtc and plane scaler state. Changes since v1: - Update documentation. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 200 ++- drivers/gpu/drm/i915/intel_dp.c | 2 +- drivers/gpu/drm/

[Intel-gfx] [PATCH v2 27/27] drm/i915: Only commit planes on crtc's that have changed planes.

2015-06-04 Thread Maarten Lankhorst
No point in applying vblank evasion if there's nothing to evade. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index 728

[Intel-gfx] [PATCH v2 18/27] drm/i915: Handle disabling planes better.

2015-06-04 Thread Maarten Lankhorst
Read out the initial state, and add a quirk to force disable all plane that were initially active. Use this to disable planes during modeset too. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic.c | 7 ++ drivers/gpu/drm/i915/intel_display.c | 139 +++

[Intel-gfx] [PATCH v2 08/27] drm/i915: Move scaler setup to check crtc function, v2.

2015-06-04 Thread Maarten Lankhorst
The scaler setup may add planes, but since they're unchanged we only have to wait for primary flips. Also set planes_changed to indicate at least 1 plane is modified. Changes since v1: - Instead of removing planes, do minimal validation needed. Signed-off-by: Maarten Lankhorst --- drivers/gpu/d

[Intel-gfx] [PATCH v2 13/27] drm/i915: clean up plane commit functions

2015-06-04 Thread Maarten Lankhorst
No point in hiding behind big ifs. This will be true most of the time. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 16 drivers/gpu/drm/i915/intel_sprite.c | 33 ++--- 2 files changed, 22 insertions(+), 27 deletions(-)

[Intel-gfx] [PATCH v2 14/27] drm/i915: clean up atomic plane check functions

2015-06-04 Thread Maarten Lankhorst
By passing crtc_state to the check_plane functions a lot of duplicated code can be removed. And now that the transitional helpers are gone the crtc_state can be reliably obtained. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic_plane.c | 4 ++- drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH v2 16/27] drm/i915: move detaching scalers to begin_crtc_commit, v2.

2015-06-04 Thread Maarten Lankhorst
This is probably intended to be be done during vblank evasion. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic.c | 3 --- drivers/gpu/drm/i915/intel_display.c | 8 drivers/gpu/drm/i915/intel_drv.h | 1 - 3 files changed, 4 insertions(+), 8 deletions(-) diff

[Intel-gfx] [PATCH v2 00/27] Convert to atomic, part 3.

2015-06-04 Thread Maarten Lankhorst
This patch requires the following patch from airlied/drm-next: "[PATCH] drm/atomic: Clear crtc_state->active in drm_atomic_helper_set_config." Now that suspend/restore is atomic it's time to clean up some remaining issues. First I clean up the suspend code some more now that it's atomic. After th

[Intel-gfx] [PATCH v2 01/27] drm/i915: Always reset in intel_crtc_restore_mode

2015-06-04 Thread Maarten Lankhorst
And get rid of things that are no longer true. This function is only used for forcing a modeset when encoder properties are changed. All the existing state is fine in this case, only setting mode_changed will force a full recalculation here, and take all the state needed. Signed-off-by: Maarten L

[Intel-gfx] [PATCH v2 12/27] drm/i915: Split plane updates of crtc->atomic into a helper, v2.

2015-06-04 Thread Maarten Lankhorst
This makes it easier to verify that no changes are done when calling this from crtc instead. Changes since v1: - Make intel_wm_need_update static and always check it. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic_plane.c | 21 +-- drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [PATCH v2 15/27] drm/i915: remove force argument from disable_plane

2015-06-04 Thread Maarten Lankhorst
The idea was good, but planes can have a fb even though they're disabled. This makes the force argument useless and always true, because only the commit function updates state. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 16 +++- drivers/gpu/drm/i915/i

[Intel-gfx] [PATCH v2 03/27] drm/i915: clean up intel_sanitize_crtc, v2

2015-06-04 Thread Maarten Lankhorst
Instead of breaking all connections manually, kill them with atomic modeset, if it happens. Now that the everything's atomic some code becomes obsolete. Forcing a atomic modeset with null mode and all connectors gone updates the state too, in a cleaner way. Because load detection is atomic too th

[Intel-gfx] [PATCH v2 17/27] drm/i915: Move crtc commit updates to separate functions.

2015-06-04 Thread Maarten Lankhorst
To allow them to be used in intel_set_mode. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 127 +++ 1 file changed, 69 insertions(+), 58 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_disp

[Intel-gfx] [PATCH v2 05/27] drm/i915: add fastboot checks for has_audio and has_infoframe

2015-06-04 Thread Maarten Lankhorst
The original commit 206645910b97 "drm/i915: check for audio and infoframe changes across mode sets v2" added checking when has_audio and has_infoframe were changed. It seems the original commit added both checks for the fastboot case. By setting crtc_state->mode_changed the code will disable the c

[Intel-gfx] [PATCH v2 21/27] drm/i915: get rid of intel_plane_restore in intel_crtc_page_flip

2015-06-04 Thread Maarten Lankhorst
Use a full atomic call instead. intel_crtc_page_flip will still have to live until async updates are allowed. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i

[Intel-gfx] [PATCH v2 06/27] drm/i915: Clean up intel_atomic_setup_scalers slightly.

2015-06-04 Thread Maarten Lankhorst
Get rid of a whole lot of ternary operators and assign the index in scaler_id, instead of the id. They're the same thing. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic.c | 21 +++-- drivers/gpu/drm/i915/intel_display.c | 2 -- drivers/gpu/drm/i915/intel

[Intel-gfx] [PATCH v2 25/27] drm/i915: Call plane update functions directly from intel_atomic_commit.

2015-06-04 Thread Maarten Lankhorst
Now that there's only a single path for all atomic updates we can call intel_(pre/post)_plane_update from intel_atomic_commit directly. This makes the intention more clear. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 12 ++-- 1 file changed, 6 insertions(+

[Intel-gfx] [PATCH v2 07/27] drm/i915: Add a simple atomic crtc check function, v2.

2015-06-04 Thread Maarten Lankhorst
Move the check for encoder cloning here. Changes since v1: - Remove was/is crtc_disabled. (mattrope) - Rename function to intel_crtc_atomic_check. (mattrope) Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic.c | 5 +- drivers/gpu/drm/i915/intel_display.c | 126 ++

[Intel-gfx] [PATCH v2 26/27] drm/i915: always disable irqs in intel_pipe_update_start

2015-06-04 Thread Maarten Lankhorst
This can only fail because of a bug in the code. Suggested-by: Daniel Vetter Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 15 +-- drivers/gpu/drm/i915/intel_drv.h | 2 +- drivers/gpu/drm/i915/intel_sprite.c | 17 +++-- 3 files changed

[Intel-gfx] [PATCH v2 19/27] drm/i915: atomic plane updates in a nutshell

2015-06-04 Thread Maarten Lankhorst
Now that all planes are added during a modeset we can use the calculated changes before disabling a plane, and then either commit or force disable a plane before disabling the crtc. The code is shared with atomic_begin/flush, except watermark updating and vblank evasion are not used. Signed-off-b

[Intel-gfx] [PATCH v2 22/27] drm/i915: Make setting color key atomic.

2015-06-04 Thread Maarten Lankhorst
By making color key atomic there are no more transitional helpers. The plane check function will reject the color key when a scaler is active. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_atomic_plane.c | 1 + drivers/gpu/drm/i915/intel_display.c | 5 +- drivers/gpu/drm

[Intel-gfx] [PATCH v2 20/27] drm/i915: Update less state during modeset.

2015-06-04 Thread Maarten Lankhorst
No need to repeatedly call update_watermarks, or update_fbc. Down to a single call to update_watermarks in .crtc_enable Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_display.c | 65 +--- 1 file changed, 15 insertions(+), 50 deletions(-) diff --g

[Intel-gfx] [PATCH v2 02/27] drm/i915: Use crtc state in intel_modeset_pipe_config

2015-06-04 Thread Maarten Lankhorst
Grabbing crtc state from atomic state is a lot more involved, and make sure connectors are added before calling this function. Move check_digital_port_conflicts to intel_modeset_checks, it's only useful to check it on a modeset. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/intel_di

[Intel-gfx] [PATCH v2 04/27] drm/i915: Update power domains only on affected crtc's.

2015-06-04 Thread Maarten Lankhorst
Use for_each_crtc_state to only touch affected crtc's. In order to make sure that the initial power is still set correctly we make sure modeset_update_crtc_power_domains is called during the initial modeset. Signed-off-by: Maarten Lankhorst --- drivers/gpu/drm/i915/i915_drv.c | 3 --- driv

Re: [Intel-gfx] [PATCH v6 0/8] All sort of cdclk stuff

2015-06-04 Thread Damien Lespiau
On Wed, Jun 03, 2015 at 03:45:06PM +0300, Mika Kahola wrote: > This patch series rebases Ville's original cdclk patch series > excluding the ones that has already been reviewed. > > http://lists.freedesktop.org/archives/intel-gfx/2014-November/055633.html > > The patches are rebased to the

[Intel-gfx] [PATCH 02/55] drm/i915: Reserve ring buffer space for i915_add_request() commands

2015-06-04 Thread John . C . Harrison
From: John Harrison It is a bad idea for i915_add_request() to fail. The work will already have been send to the ring and will be processed, but there will not be any tracking or management of that work. The only way the add request call can fail is if it can't write its epilogue commands to the

Re: [Intel-gfx] [PATCH 15/21] drm/i915/gtt: Fill scratch page

2015-06-04 Thread Chris Wilson
On Thu, Jun 04, 2015 at 12:08:17PM +0100, Tomas Elf wrote: > On 01/06/2015 16:53, Chris Wilson wrote: > >On Wed, May 27, 2015 at 07:12:02PM +0100, Tomas Elf wrote: > >>On 22/05/2015 18:05, Mika Kuoppala wrote: > >>>During review of dynamic page tables series, I was able > >>>to hit a lite restore b

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Move WaBarrierPerformanceFixDisable:skl to skl code from chv code

2015-06-04 Thread Jani Nikula
On Wed, 03 Jun 2015, Jani Nikula wrote: > On Tue, 02 Jun 2015, Damien Lespiau wrote: >> On Tue, Jun 02, 2015 at 03:37:35PM +0300, ville.syrj...@linux.intel.com >> wrote: >>> From: Ville Syrjälä >>> >>> commit 65ca7514e21adbee25b8175fc909759c735d00ff >>> Author: Damien Lespiau >>> Date: M

Re: [Intel-gfx] [PATCH] drm/i915: Don't check modeset state in the hw state force restore path

2015-06-04 Thread Jani Nikula
On Tue, 02 Jun 2015, Ander Conselvan De Oliveira wrote: > On Tue, 2015-06-02 at 09:27 +0200, Maarten Lankhorst wrote: >> Op 02-06-15 om 09:12 schreef Jani Nikula: >> > On Mon, 01 Jun 2015, Ander Conselvan de Oliveira >> > wrote: >> >> Since the force restore logic will restore the CRTCs state on

Re: [Intel-gfx] [PATCH 15/21] drm/i915/gtt: Fill scratch page

2015-06-04 Thread Tomas Elf
On 01/06/2015 16:53, Chris Wilson wrote: On Wed, May 27, 2015 at 07:12:02PM +0100, Tomas Elf wrote: On 22/05/2015 18:05, Mika Kuoppala wrote: During review of dynamic page tables series, I was able to hit a lite restore bug with execlists. I assume that due to incorrect pd, the batch run out of

Re: [Intel-gfx] DC6 already programmed to be disabled

2015-06-04 Thread Damien Lespiau
On Thu, Jun 04, 2015 at 01:39:50PM +0530, Sagar Arun Kamble wrote: > The warning faced by Chandra has to corrected. This warning is not > related to firmware load. > > Issue is -> During boot DC5/6 will be already disabled and hence While > enabling PW2 for the first time the check to see if DC5/

Re: [Intel-gfx] [PATCH] drm/i915: Make pinned object handling more specific

2015-06-04 Thread Joonas Lahtinen
On to, 2015-06-04 at 10:01 +0100, Chris Wilson wrote: > On Thu, Jun 04, 2015 at 11:49:06AM +0300, Joonas Lahtinen wrote: > > Get rid of the over-generic i915_gem_obj_is_pinned and replace it > > with i915_gem_obj_ggtt_is_pinned or more specific VMA handling. > > > > Requested-by: Chris Wilson > >

Re: [Intel-gfx] [PATCH] drm/i915: Make pinned object handling more specific

2015-06-04 Thread Chris Wilson
On Thu, Jun 04, 2015 at 11:49:06AM +0300, Joonas Lahtinen wrote: > Get rid of the over-generic i915_gem_obj_is_pinned and replace it > with i915_gem_obj_ggtt_is_pinned or more specific VMA handling. > > Requested-by: Chris Wilson > Signed-off-by: Joonas Lahtinen I take it you didn't read my patc

[Intel-gfx] [PATCH] drm/i915: Make pinned object handling more specific

2015-06-04 Thread Joonas Lahtinen
Get rid of the over-generic i915_gem_obj_is_pinned and replace it with i915_gem_obj_ggtt_is_pinned or more specific VMA handling. Requested-by: Chris Wilson Signed-off-by: Joonas Lahtinen --- drivers/gpu/drm/i915/i915_debugfs.c | 8 +-- drivers/gpu/drm/i915/i915_drv.h | 9 +

Re: [Intel-gfx] [PATCH v4 00/27] drm/i915: Convert to atomic, part 2.

2015-06-04 Thread Jani Nikula
On Mon, 01 Jun 2015, Maarten Lankhorst wrote: > The goal of this patch series is to implement hardware readout using > atomic state, and restore sw state with a single call to intel_set_mode. > > After that's done intel_crtc_control can be safely converted to > atomic modeset, because nothing rel

Re: [Intel-gfx] [PATCH 3/3] drm/i915/skl: Updated the i915_ring_freq_table debugfs function

2015-06-04 Thread Ville Syrjälä
On Thu, Jun 04, 2015 at 01:36:36PM +0530, Akash Goel wrote: > On Wed, 2015-06-03 at 14:27 -0700, Rodrigo Vivi wrote: > > On Tue, May 12, 2015 at 12:49 AM, wrote: > > > From: Akash Goel > > > > > > Updated the i915_ring_freq_table debugfs function to allow read of ring > > > frequency table throu

[Intel-gfx] [PATCH v4.1 01/13] drm/i915: Use global atomic state for staged pll, config, v3.

2015-06-04 Thread Maarten Lankhorst
Now that we can subclass drm_atomic_state we can also use it to keep track of all the pll settings. atomic_state is a better place to hold all shared state than keeping pll->new_config everywhere. Changes since v1: - Assert connection_mutex is held. Changes since v2: - Fix swapped arguments to kza

Re: [Intel-gfx] [PATCH] drm/i915: Include G4X/VLV/CHV in self refresh status

2015-06-04 Thread Jani Nikula
On Tue, 02 Jun 2015, Ville Syrjälä wrote: > On Tue, Jun 02, 2015 at 02:17:47PM +0300, Ander Conselvan de Oliveira wrote: >> Add all missing platforms handled by intel_set_memory_cxsr() to the >> i915_sr_status debugfs entry. >> >> v2: Add G4X too. (Ville) >> Clarify the change also affects CH

Re: [Intel-gfx] [PATCH] drm/i915: Initialize HWS page address after GPU reset

2015-06-04 Thread Jani Nikula
On Wed, 03 Jun 2015, Ville Syrjälä wrote: > On Tue, Jun 02, 2015 at 08:06:59PM +0100, Arun Siluvery wrote: >> After GPU reset, HW is losing the address of HWS page in the register. >> The page itself is valid except that HW is not aware of its location. >> >> [ 64.368623] [drm:gen8_init_common_

Re: [Intel-gfx] DC6 already programmed to be disabled

2015-06-04 Thread Sagar Arun Kamble
The warning faced by Chandra has to corrected. This warning is not related to firmware load. Issue is -> During boot DC5/6 will be already disabled and hence While enabling PW2 for the first time the check to see if DC5/6 is already disabled does not make sense. So condition should be WARN(!(I9

Re: [Intel-gfx] [PATCH 3/3] drm/i915/skl: Updated the i915_ring_freq_table debugfs function

2015-06-04 Thread Akash Goel
On Wed, 2015-06-03 at 14:27 -0700, Rodrigo Vivi wrote: > On Tue, May 12, 2015 at 12:49 AM, wrote: > > From: Akash Goel > > > > Updated the i915_ring_freq_table debugfs function to allow read of ring > > frequency table through Punit interface, for SKL also. > > > > Signed-off-by: Akash Goel > >

Re: [Intel-gfx] [PATCH v4 14/27] drm/i915: Zap call to drm_plane_helper_disable, v2.

2015-06-04 Thread Jani Nikula
On Mon, 01 Jun 2015, Maarten Lankhorst wrote: > The primary plane can still be configured when crtc is off, > furthermore this is also a noop now that affected planes are > added on modesets. > > Changes since v1: > - Move commit so no frontbuffer_bits warnings are generated. > > Signed-off-by: M

Re: [Intel-gfx] [PATCH 2/2] drm/i915/skl: Ring frequency table programming changes

2015-06-04 Thread Akash Goel
On Wed, 2015-06-03 at 14:24 -0700, Rodrigo Vivi wrote: > On Tue, May 5, 2015 at 4:30 AM, wrote: > > From: Akash Goel > > > > Ring frequency table programming changes for SKL. No need for a > > floor on ring frequency, as the issue of performance impact with > > ring running below DDR frequency,

Re: [Intel-gfx] [PATCH v6 8/8] drm/i915: HSW cdclk support

2015-06-04 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6530 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH v4 15/27] drm/i915: Use global atomic state for staged pll config, v2.

2015-06-04 Thread Jani Nikula
On Mon, 01 Jun 2015, Maarten Lankhorst wrote: > From: Ander Conselvan de Oliveira > > Now that we can subclass drm_atomic_state we can also use it to keep > track of all the pll settings. atomic_state is a better place to hold > all shared state than keeping pll->new_config everywhere. > > Chang

Re: [Intel-gfx] [PATCH] drm/i915/skl: Fix DMC API version.

2015-06-04 Thread shuang . he
Tested-By: Intel Graphics QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 6533 -Summary- Platform Delta drm-intel-nightly Series Applied PNV

Re: [Intel-gfx] [PATCH 1/2] drm/i915/skl: Retrieve the Rpe value from Pcode

2015-06-04 Thread Akash Goel
On Wed, 2015-06-03 at 14:19 -0700, Rodrigo Vivi wrote: > On Tue, May 5, 2015 at 4:30 AM, wrote: > > From: Akash Goel > > > > Read the efficient frequency (aka RPe) value through the the mailbox > > command (0x1A) from the pcode, as done on Haswell and Broadwell. > > The turbo minimum frequency s