[Intel-gfx] [PATCH 4/4] drm/i915/skl: Program PLL for edp1.4 intermediate frequencies

2015-02-20 Thread Sonika Jindal
v2: Making the link_clock half in switch inline with the DPLL_CTRL1_* macros (Ville) Signed-off-by: Sonika Jindal --- drivers/gpu/drm/i915/intel_dp.c | 28 ++-- 1 file changed, 22 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/

[Intel-gfx] [PATCH 2/4] drm/i915/skl: Read sink supported rates from edp panel

2015-02-20 Thread Sonika Jindal
v2: Using DP_SUPPORTED_LINK_RATES macro for supported_rates array (Satheesh). v3: Reading dpcd's supported link rates tables based upon edp version in the same patch. v4: Move version check under is_edp (Satheesh) v5: Using le16 for rates, some naming, and removing nested if block (Ville) v6: Corre

[Intel-gfx] [PATCH 3/4] drm/i915/skl: Add support for edp 1.4 intermediate frequencies

2015-02-20 Thread Sonika Jindal
eDp 1.4 supports custom frequencies. Skylake supports following intermediate frequencies : 3.24 GHz, 2.16 GHz and 4.32 GHz along with usual LBR, HBR and HBR2 frequencies. Read sink supported frequencies and get common frequencies from sink and source and use these for link training. v2: Rebased, r

[Intel-gfx] [PATCH 0/4] drm/i915/skl: Support for edp1.4 intermediate frequencies

2015-02-20 Thread Sonika Jindal
This series adds support for edp1.4 intermediate frequencies supported by Skylake This addresses review comments by Ville and some reformatting. Sonika Jindal (4): drm: Adding edp1.4 specific dpcd macros drm/i915/skl: Read sink supported rates from edp panel drm/i915/skl: Add support for ed

[Intel-gfx] [PATCH 1/4] drm: Adding edp1.4 specific dpcd macros

2015-02-20 Thread Sonika Jindal
Adding dpcd macros related to edp1.4 and link rates v2: Added DP_SUPPORTED_LINK_RATES macros Cc: dri-de...@lists.freedesktop.org Signed-off-by: Sonika Jindal Reviewed-by: Todd Previte --- include/drm/drm_dp_helper.h |8 1 file changed, 8 insertions(+) diff --git a/include/drm/drm

[Intel-gfx] [PATCH] drm/i915/skl: Update edp 1.4 DDI translation table

2015-02-20 Thread Sonika Jindal
Updating recommended DDI translation table for edp 1.4 as per bspec update Signed-off-by: Sonika Jindal Reviewed-by: Damien Lespiau --- drivers/gpu/drm/i915/intel_ddi.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/dr

[Intel-gfx] [PATCH] i-g-t: Adding test case to test background color.

2015-02-20 Thread Chandra Konduru
From: chandra konduru Adding i-g-t test case to test display crtc background color. Signed-off-by: chandra konduru --- lib/igt_kms.c | 60 +++ lib/igt_kms.h | 4 + tests/Android.mk | 1 + tests/Makefile.sources|

[Intel-gfx] [PATCH v9] drm/i915/skl: Add support for SKL background color

2015-02-20 Thread Chandra Konduru
This patch adds support for Skylake display pipe background color. v2: - added property documentation to drm DocBook (Daniel Vetter) - moved property to drm_mode_config (Daniel Vetter) - change to set property to NULL once it is freed. (me) - change to make sure gamma/csc settings were retained du

Re: [Intel-gfx] [PATCH] drm/i915: avoid processing spurious/shared interrupts in low-power states

2015-02-20 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5801 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 277/277

Re: [Intel-gfx] [PATCH] drm/i915: Do not invalidate obj->pages under mempressure

2015-02-20 Thread Sean V Kelley
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On 02/11/2015 05:02 AM, Daniel Vetter wrote: > On Wed, Feb 11, 2015 at 1:55 AM, Sean V Kelley > wrote: >> No corruption seen. I will add reloc domains to my growing audit >> list. > > One more for the libva audit list: > > If you do any ioctl dir

Re: [Intel-gfx] [PATCH] drm/i915: avoid processing spurious/shared interrupts in low-power states

2015-02-20 Thread Imre Deak
On Fri, 2015-02-20 at 19:40 +, Chris Wilson wrote: > On Fri, Feb 20, 2015 at 09:09:02PM +0200, Imre Deak wrote: > > +static void intel_irq_set_state(struct drm_i915_private *dev_priv, > > + bool enabled) > > +{ > > + dev_priv->pm.irqs_enabled = enabled; > > + /* >

Re: [Intel-gfx] [PATCH] drm/i915: avoid processing spurious/shared interrupts in low-power states

2015-02-20 Thread Chris Wilson
On Fri, Feb 20, 2015 at 09:09:02PM +0200, Imre Deak wrote: > +static void intel_irq_set_state(struct drm_i915_private *dev_priv, > + bool enabled) > +{ > + dev_priv->pm.irqs_enabled = enabled; > + /* > + * Before we unmask the interrupt or synchronize agains

[Intel-gfx] [PATCH] drm/i915: avoid processing spurious/shared interrupts in low-power states

2015-02-20 Thread Imre Deak
Atm, it's possible that the interrupt handler is called when the device is in D3 or some other low-power state. It can be due to another device that is still in D0 state and shares the interrupt line with i915, or on some platforms there could be spurious interrupts even without sharing the interru

Re: [Intel-gfx] [PATCH 2/6] drm/i915/bdw: Add support for DRRS to switch RR

2015-02-20 Thread Rodrigo Vivi
On Thu, Feb 19, 2015 at 10:15 PM, Ramalingam C wrote: > Hi, > > > On Thursday 19 February 2015 10:55 PM, Rodrigo Vivi wrote: >> >> On Fri, Feb 13, 2015 at 2:03 AM, Ramalingam C >> wrote: >>> >>> From: Vandana Kannan >>> >>> For Broadwell, there is one instance of Transcoder MN values per >>> tra

[Intel-gfx] [PATCH 06/12] drm/i915/bdw: Add 4 level switching infrastructure

2015-02-20 Thread Michel Thierry
From: Ben Widawsky Map is easy, it's the same register as the PDP descriptor 0, but it only has one entry. v2: PML4 update in legacy context switch is left for historic reasons, the preferred mode of operation is with lrc context based submission. Signed-off-by: Ben Widawsky Signed-off-by: Mic

[Intel-gfx] [PATCH 04/12] drm/i915/bdw: Add ppgtt info for dynamic pages

2015-02-20 Thread Michel Thierry
From: Ben Widawsky Note that there is no gen8 ppgtt debug_dump function yet. Signed-off-by: Ben Widawsky Signed-off-by: Michel Thierry --- drivers/gpu/drm/i915/i915_debugfs.c | 19 ++- drivers/gpu/drm/i915/i915_gem_gtt.c | 32 drivers/gpu/drm/i

[Intel-gfx] [PATCH 05/12] drm/i915/bdw: implement alloc/free for 4lvl

2015-02-20 Thread Michel Thierry
From: Ben Widawsky The code for 4lvl works just as one would expect, and nicely it is able to call into the existing 3lvl page table code to handle all of the lower levels. PML4 has no special attributes, and there will always be a PML4. So simply initialize it at creation, and destroy it at the

[Intel-gfx] [PATCH 00/12] PPGTT with 48b addressing

2015-02-20 Thread Michel Thierry
These patches rely on "PPGTT dynamic page allocations", currently under review, to provide GEN8 dynamic page table support with 64b addresses. As the review progresses, these patches may be combined. In order expand the GPU address space, a 4th level translation is added, the Page Map Level 4 (PML

[Intel-gfx] [PATCH 11/12] drm/i915: Expand error state's address width to 64b

2015-02-20 Thread Michel Thierry
From: Ben Widawsky v2: 0 pad the new 8B fields or else intel_error_decode has a hard time. Note, regardless we need an igt update. v3: Make reloc_offset 64b also. Signed-off-by: Ben Widawsky Signed-off-by: Michel Thierry --- drivers/gpu/drm/i915/i915_drv.h | 4 ++-- drivers/gpu/drm/i9

[Intel-gfx] [PATCH 01/12] drm/i915/bdw: Make pdp allocation more dynamic

2015-02-20 Thread Michel Thierry
From: Ben Widawsky This transitional patch doesn't do much for the existing code. However, it should make upcoming patches to use the full 48b address space a bit easier to swallow. The patch also introduces the PML4, ie. the new top level structure of the page tables. v2: Renamed pdp_free to b

[Intel-gfx] [PATCH 09/12] drm/i915: Plumb sg_iter through va allocation ->maps

2015-02-20 Thread Michel Thierry
From: Ben Widawsky As a step towards implementing 4 levels, while not discarding the existing pte map functions, we need to pass the sg_iter through. The current function understands to the page directory granularity. An object's pages may span the page directory, and so using the iter directly a

[Intel-gfx] [PATCH 03/12] drm/i915/bdw: Add dynamic page trace events

2015-02-20 Thread Michel Thierry
From: Ben Widawsky The dynamic page allocation patch series added it for GEN6, this patch adds them for GEN8. v2: Consolidate pagetable/page_directory events v3: Multiple rebases. Signed-off-by: Ben Widawsky Signed-off-by: Michel Thierry (v3) --- drivers/gpu/drm/i915/i915_gem_gtt.c | 23

[Intel-gfx] [PATCH 12/12] drm/i915/bdw: Flip the 48b switch

2015-02-20 Thread Michel Thierry
Use 48b addresses if hw supports it and i915.enable_ppgtt=3. Aliasing PPGTT remains 32b only. Signed-off-by: Michel Thierry --- drivers/gpu/drm/i915/i915_gem_gtt.c | 7 ++- drivers/gpu/drm/i915/i915_params.c | 2 +- 2 files changed, 3 insertions(+), 6 deletions(-) diff --git a/drivers/gpu

[Intel-gfx] [PATCH 10/12] drm/i915/bdw: Add 4 level support in insert_entries and clear_range

2015-02-20 Thread Michel Thierry
When 48b is enabled, gen8_ppgtt_insert_entries needs to read the Page Map Level 4 (PML4), before it selects which Page Directory Pointer (PDP) it will write to. Similarly, gen8_ppgtt_clear_range needs to get the correct PDP/PD range. Also add a scratch page for PML4. This patch was inspired by B

[Intel-gfx] [PATCH 08/12] drm/i915/bdw: Generalize PTE writing for GEN8 PPGTT

2015-02-20 Thread Michel Thierry
From: Ben Widawsky The insert_entries function was the function used to write PTEs. For the PPGTT it was "hardcoded" to only understand two level page tables, which was the case for GEN7. We can reuse this for 4 level page tables, and remove the concept of insert_entries, which was never viable p

[Intel-gfx] [PATCH 02/12] drm/i915/bdw: Abstract PDP usage

2015-02-20 Thread Michel Thierry
From: Ben Widawsky Up until now, ppgtt->pdp has always been the root of our page tables. Legacy 32b addresses acted like it had 1 PDP with 4 PDPEs. In preparation for 4 level page tables, we need to stop use ppgtt->pdp directly unless we know it's what we want. The future structure will use ppgt

[Intel-gfx] [PATCH 07/12] drm/i915/bdw: Support 64 bit PPGTT in lrc mode

2015-02-20 Thread Michel Thierry
In 64b (48bit canonical) PPGTT addressing, the PDP0 register contains the base address to PML4, while the other PDP registers are ignored. Also, the addressing mode must be specified in every context descriptor. Signed-off-by: Michel Thierry --- drivers/gpu/drm/i915/intel_lrc.c | 167 ++

Re: [Intel-gfx] [PATCH] drm: Adding edp1.4 specific dpcd macros

2015-02-20 Thread Todd Previte
On 2/20/2015 1:25 AM, Jani Nikula wrote: On Thu, 19 Feb 2015, Todd Previte wrote: Just some formatting issues that need to be cleaned up. Otherwise the definitions look correct according to the eDP 1.4 spec. Actually the formatting seems to be in line with the rest of that particular file. B

Re: [Intel-gfx] [PATCH 11/17] drm/i915: Update the EDID automated compliance test function

2015-02-20 Thread Daniel Vetter
Readding intel-gfx. On Wed, Feb 18, 2015 at 5:57 PM, Todd Previte wrote: > On 12/17/14 1:20 PM, Daniel Vetter wrote: >> Just something random I've spotted while driving by: drm_get_edid does all >> the checksum stuff for you already (it retries up to 4 times if the >> checkusm is off and also che

Re: [Intel-gfx] [PATCH v4 07/24] drm/i915: Create page table allocators

2015-02-20 Thread Mika Kuoppala
Michel Thierry writes: > From: Ben Widawsky > > As we move toward dynamic page table allocation, it becomes much easier > to manage our data structures if break do things less coarsely by > breaking up all of our actions into individual tasks. This makes the > code easier to write, read, and ve

Re: [Intel-gfx] [PATCH v4 09/24] drm/i915: Track GEN6 page table usage

2015-02-20 Thread Mika Kuoppala
Michel Thierry writes: > From: Ben Widawsky > > Instead of implementing the full tracking + dynamic allocation, this > patch does a bit less than half of the work, by tracking and warning on > unexpected conditions. The tracking itself follows which PTEs within a > page table are currently being

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add debugfs entry for DRRS

2015-02-20 Thread Ramalingam C
Hi, On Friday 20 February 2015 12:15 AM, Rodrigo Vivi wrote: On Fri, Feb 13, 2015 at 2:03 AM, Ramalingam C wrote: From: Vandana Kannan Adding a debugfs entry to determine if DRRS is supported or not V2: [By Ram]: Following details about the active crtc will be filled in seq-file of

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add the last written reg to error state

2015-02-20 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5799 -Summary- Platform Delta drm-intel-nightly Series Applied PNV -2 277/277

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Add the last written reg to error state

2015-02-20 Thread Chris Wilson
At first glance, this is interesting. On reflection I think I still only care about the register values at the time of the error. Otherwise, I would rather have the last few registers written - and only those of the interesting set as defined by the error state - their values and when. We would als

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Track last register written (debug)

2015-02-20 Thread Chris Wilson
On Fri, Feb 20, 2015 at 09:55:09AM -0200, Paulo Zanoni wrote: > 2015-02-20 3:33 GMT-02:00 Ben Widawsky : > > Register writes are supposed to be posted, and therefore "fast." In order > > to try > > to preserve this behavior, the patch uses percpu variables to make the > > overhead > > minimal. Th

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Track last register written (debug)

2015-02-20 Thread Paulo Zanoni
2015-02-20 3:33 GMT-02:00 Ben Widawsky : > Register writes are supposed to be posted, and therefore "fast." In order to > try > to preserve this behavior, the patch uses percpu variables to make the > overhead > minimal. The slow data collection is done at error time, and that only occurs > if >

Re: [Intel-gfx] [PATCH v2] drm/i915: FIFO space query code refactor

2015-02-20 Thread Mika Kuoppala
Dave Gordon writes: > When querying the GTFIFOCTL register to check the FIFO space, the read value > must be masked. The operation is repeated explicitly in several places. This > change refactors the read-and-mask code into a function call. > > v2: rebased on top of Mika's forcewake patch set, s

Re: [Intel-gfx] [PATCH 1/2] drm/i915: Split adding request to smaller functions

2015-02-20 Thread Mika Kuoppala
John Harrison writes: > Please note that a lot of the issues with _i915_add_request are cleaned > up by my patch series to remove the outstanding_lazy_request. The add to > client in some random client context is fixed, the messy execlist vs > legacy ringbuf decisions are removed, the execlist

Re: [Intel-gfx] [PATCH] drm: Adding edp1.4 specific dpcd macros

2015-02-20 Thread Jani Nikula
On Thu, 19 Feb 2015, Todd Previte wrote: > Just some formatting issues that need to be cleaned up. Otherwise the > definitions look correct according to the eDP 1.4 spec. Actually the formatting seems to be in line with the rest of that particular file. BR, Jani. > > -T > > On 2/19/15 12:46 AM