Re: [Intel-gfx] [PATCH 3/3] drm/i915: Do only one posting read on forcewake get sequence

2015-01-30 Thread shuang . he
Tested-By: PRC QA PRTS (Patch Regression Test System Contact: shuang...@intel.com) Task id: 5674 -Summary- Platform Delta drm-intel-nightly Series Applied PNV 353/353

[Intel-gfx] [PATCH 4/4] drm/i915: Use atomic helper for pageflips

2015-01-30 Thread Matt Roper
Now that we have asynchronous nuclear pageflip, we should be able to push our legacy pageflip ioctl through the atomic helper and rip out a bunch of i915-specific pageflip code. This patch is actually pretty conservative; I think there's a lot more flip-related infrastructure that should be ripped

[Intel-gfx] [PATCH 1/4] drm/i915: Keep plane->state updated on pageflip

2015-01-30 Thread Matt Roper
Until all drivers have transitioned to atomic, the framebuffer associated with a plane is tracked in both plane->fb (for legacy) and plane->state->fb (for all the new atomic codeflow). All of our modeset and plane updates use drm_plane->update_plane(), so in theory plane->fb and plane->state->fb s

[Intel-gfx] [PATCH 2/4] drm/i915: Switch planes from transitional helpers to full atomic helpers

2015-01-30 Thread Matt Roper
There are two sets of helper functions provided by the DRM core that can implement the .update_plane() and .disable_plane() hooks in terms of a driver's atomic entrypoints. The transitional helpers (which we have been using so far) create a plane state and then use the plane's atomic entrypoints t

[Intel-gfx] [PATCH 3/4] drm/i915: Enable asynchronous nuclear flips

2015-01-30 Thread Matt Roper
The initial i915 nuclear pageflip support rejected asynchronous updates. Allow all work after we swap in the new state structures to run asynchronously. We also need to start sending completion events to userspace if they were requested. Signed-off-by: Matt Roper --- drivers/gpu/drm/i915/i915_d

[Intel-gfx] [PATCH 0/4] More nuclear pageflip

2015-01-30 Thread Matt Roper
The first two patches here were already posted earlier this week; they allow our legacy plane updates to make use of the main atomic helpers rather than the transitional atomic helpers. This shouldn't have any functional change, but it will cause us to exercise the full atomic pipeline rather than

[Intel-gfx] Updated drm-intel-testing

2015-01-30 Thread Daniel Vetter
Hi all, New -testing cycle with cool stuff: - chv rps improvements from Ville - atomic state handling prep work from Ander - execlist request tracking refactoring from Nick Hoath - forcewake code consolidation from Chris&Mika - fastboot plane config refactoring and skl support from Damien - some m

Re: [Intel-gfx] [PATCH] drm/i915: Fix a use-after-free in intel_execlists_retire_requests

2015-01-30 Thread Daniel Vetter
On Fri, Jan 30, 2015 at 5:45 PM, Nick Hoath wrote: > On 30/01/2015 16:33, Daniel Vetter wrote: >> >> On Fri, Jan 30, 2015 at 11:01:30AM +0200, Mika Kuoppala wrote: >>> >>> Nick Hoath writes: >>> Remove request from list before unreferencing it, in case it's actually the only reference.

[Intel-gfx] [RFC 4/6] drm/i915: Use framebuffer tiling mode for display purposes

2015-01-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To prepare for framebuffer modifiers, move tiling definition from the object into the framebuffer. Move in a way that framebuffer tiling is now used for display while object tiling remains for fencing. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c

[Intel-gfx] [RFC 2/6] drm/i915: Add tiled framebuffer modifiers

2015-01-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin To be used from the new addfb2 extension. Signed-off-by: Tvrtko Ursulin --- include/uapi/drm/i915_drm.h | 13 + 1 file changed, 13 insertions(+) diff --git a/include/uapi/drm/i915_drm.h b/include/uapi/drm/i915_drm.h index 6eed16b..a7327fd 100644 --- a/include/

[Intel-gfx] [RFC 3/6] drm/i915: Set up fb modifier on initial takeover

2015-01-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Initialize the simulated ioctl with the new modifier token so it can be passed on in line with the new API usage. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/

[Intel-gfx] [RFC 1/6] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-01-30 Thread Tvrtko Ursulin
From: Rob Clark In DRM/KMS we are lacking a good way to deal with tiled/compressed formats. Especially in the case of dmabuf/prime buffer sharing, where we cannot always rely on under-the-hood flags passed to driver specific gem-create ioctl to pass around these extra flags. The proposal is to

[Intel-gfx] [RFC 0/6] Use framebuffer modifiers for tiled display

2015-01-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Instead of using driver private set tiling ioctl, use the proposed addfb2 ioctl extension to tell the driver about display buffer special formatting. Lightly tested only with a hacked up igt/testdisplay. Sending out early so people can comment on the overall approach over th

[Intel-gfx] [RFC 5/6] drm/i915: Allow fb modifier to set framebuffer tiling

2015-01-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Use the fb modifier if it was specified over object tiling mode. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 40 +--- 1 file changed, 33 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_disp

[Intel-gfx] [RFC 6/6] drm/i915: Announce support for framebuffer modifiers

2015-01-30 Thread Tvrtko Ursulin
From: Tvrtko Ursulin Let the DRM core know we can handle it. Signed-off-by: Tvrtko Ursulin --- drivers/gpu/drm/i915/intel_display.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/gpu/drm/i915/intel_display.c index ca69da0..1a8d433 100644 -

Re: [Intel-gfx] [PATCH] drm/i915/skl: Enable eDRAM for gen9 as well

2015-01-30 Thread Ville Syrjälä
On Thu, Jan 29, 2015 at 12:42:35PM +, Damien Lespiau wrote: > Suggested-by: Daniel Vetter > Signed-off-by: Damien Lespiau > --- > drivers/gpu/drm/i915/intel_uncore.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915/intel_uncore.c > b/drivers/g

Re: [Intel-gfx] [PATCH] drm/i915: Fix a use-after-free in intel_execlists_retire_requests

2015-01-30 Thread Nick Hoath
On 30/01/2015 16:33, Daniel Vetter wrote: On Fri, Jan 30, 2015 at 11:01:30AM +0200, Mika Kuoppala wrote: Nick Hoath writes: Remove request from list before unreferencing it, in case it's actually the only reference. (Found by Tvrtko Ursulin) Signed-off-by: Nick Hoath Do we have a Bugzilla

Re: [Intel-gfx] [PATCH v2] drm/i915: Use pipe_config's cpu_transcoder for reading encoder hw state

2015-01-30 Thread Daniel Vetter
On Fri, Jan 30, 2015 at 12:17:23PM +0200, Ander Conselvan de Oliveira wrote: > The get_config() functions for ddi and dp_mst, used to read the value > of cpu_transcoder from the crtc->config instead of the state passed as > an argument. On the hardware state readout path, that happens to work > sin

[Intel-gfx] PCH fifo underrun in 3.18

2015-01-30 Thread jon
Just updated my thinkpad (x230, ivy bridge platform) to 3.18 and boot fails with the error 'PCH fifo underrun'. This is under fedora 21 with the fedora kernel version 3.18.3-201 Platform information: [jon@localhost]~% lspci 00:00.0 Host bridge: Intel Corporation 3rd Gen Core processor DRAM C

Re: [Intel-gfx] [PATCH] drm/i915: Fix a use-after-free in intel_execlists_retire_requests

2015-01-30 Thread Daniel Vetter
On Fri, Jan 30, 2015 at 11:01:30AM +0200, Mika Kuoppala wrote: > Nick Hoath writes: > > > Remove request from list before unreferencing it, in case it's actually > > the only reference. (Found by Tvrtko Ursulin) > > > > Signed-off-by: Nick Hoath Do we have a Bugzilla: or similar report? Also wh

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Split shared dpll setup out of __intel_set_mode()

2015-01-30 Thread Daniel Vetter
On Thu, Jan 29, 2015 at 04:55:08PM +0200, Ander Conselvan de Oliveira wrote: > This simplifies __intel_set_mode() a little. > > Signed-off-by: Ander Conselvan de Oliveira > Merged this one here, please sign up Matt or someone else suitable for the in-depth review. -Daniel > --- > drivers/gpu/

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT

2015-01-30 Thread Daniel Vetter
On Thu, Jan 29, 2015 at 02:11:13PM -0600, Jeff McGee wrote: > On Thu, Jan 29, 2015 at 02:13:38PM +, Damien Lespiau wrote: > > We need to have a separate GT3 struct intel_device_info to declare they > > have a second VCS. Let's start by splitting the PCI ids per-GT. > > > Would it be a good ide

Re: [Intel-gfx] [igt PATCH] gen9: fix gem_render_copy 3d state setup

2015-01-30 Thread Daniel Vetter
On Thu, Jan 29, 2015 at 04:15:55PM +0200, Mika Kuoppala wrote: > Damien Lespiau writes: > > > On Thu, Jan 29, 2015 at 11:32:46AM +, Chris Wilson wrote: > >> On Thu, Jan 29, 2015 at 11:17:04AM +, Damien Lespiau wrote: > >> > On Thu, Jan 29, 2015 at 11:12:46AM +, Chris Wilson wrote: > >

Re: [Intel-gfx] [PATCH] drm/i915/skl: Enable eDRAM for gen9 as well

2015-01-30 Thread Daniel Vetter
On Thu, Jan 29, 2015 at 12:42:35PM +, Damien Lespiau wrote: > Suggested-by: Daniel Vetter > Signed-off-by: Damien Lespiau Hm, I've thought the magic bit moved ... or have you found it in configdb again? -Daniel > --- > drivers/gpu/drm/i915/intel_uncore.c | 3 ++- > 1 file changed, 2 insert

[Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-01-30 Thread Daniel Vetter
From: Rob Clark In DRM/KMS we are lacking a good way to deal with tiled/compressed formats. Especially in the case of dmabuf/prime buffer sharing, where we cannot always rely on under-the-hood flags passed to driver specific gem-create ioctl to pass around these extra flags. The proposal is to

Re: [Intel-gfx] [PATCH] drm/i915: Don't do posting reads on getting forcewake

2015-01-30 Thread Daniel Vetter
On Wed, Jan 28, 2015 at 02:04:27PM +, Chris Wilson wrote: > On Wed, Jan 28, 2015 at 03:25:05PM +0200, Mika Kuoppala wrote: > > The checking for ack and also any subsequent mmio access > > will serialize with setting the forcewake bit. Drop the > > posting read as superfluous. > > > > Note that

Re: [Intel-gfx] [PATCH 2/2] drm/i915: Introduce intel_set_rps()

2015-01-30 Thread Daniel Vetter
On Thu, Jan 29, 2015 at 01:57:16PM +0200, Ville Syrjälä wrote: > On Wed, Jan 28, 2015 at 10:29:06AM +, Chris Wilson wrote: > > On Tue, Jan 27, 2015 at 04:36:16PM +0200, ville.syrj...@linux.intel.com > > wrote: > > > From: Ville Syrjälä > > > > > > Replace the valleyview_set_rps() and gen6_se

Re: [Intel-gfx] [PATCH 1/3] drm/i915/skl: Split the SKL PCI ids by GT

2015-01-30 Thread Jeff McGee
On Fri, Jan 30, 2015 at 09:30:07AM +0200, Jani Nikula wrote: > On Thu, 29 Jan 2015, Jeff McGee wrote: > > On Thu, Jan 29, 2015 at 02:13:38PM +, Damien Lespiau wrote: > >> We need to have a separate GT3 struct intel_device_info to declare they > >> have a second VCS. Let's start by splitting th

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-01-30 Thread Daniel Vetter
On Fri, Jan 30, 2015 at 09:51:48AM -0500, Rob Clark wrote: > On Fri, Jan 30, 2015 at 9:35 AM, Tvrtko Ursulin > wrote: > > > > On 01/30/2015 01:43 PM, Rob Clark wrote: > >> > >> On Fri, Jan 30, 2015 at 5:51 AM, Tvrtko Ursulin > >> wrote: > > +/* > + * Format Modifier tokens: >

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-01-30 Thread Tvrtko Ursulin
On 01/29/2015 05:01 PM, Daniel Vetter wrote: +#define fourcc_mod_code(vendor, val) \ + u64)DRM_FORMAT_MOD_VENDOR_## vendor) << 56) | (val & 0x00ffL) Unbalanced parentheses. Finding them as I go along, sorry! :) Regards, Tvrtko ___

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-01-30 Thread Rob Clark
On Fri, Jan 30, 2015 at 9:35 AM, Tvrtko Ursulin wrote: > > On 01/30/2015 01:43 PM, Rob Clark wrote: >> >> On Fri, Jan 30, 2015 at 5:51 AM, Tvrtko Ursulin >> wrote: +/* + * Format Modifier tokens: + * + * When adding a new token please document the layout with a code

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-01-30 Thread Tvrtko Ursulin
On 01/30/2015 01:43 PM, Rob Clark wrote: On Fri, Jan 30, 2015 at 5:51 AM, Tvrtko Ursulin wrote: +/* + * Format Modifier tokens: + * + * When adding a new token please document the layout with a code comment, + * similar to the fourcc codes above. drm_fourcc.h is considered the + * authoritativ

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-01-30 Thread Rob Clark
On Fri, Jan 30, 2015 at 5:51 AM, Tvrtko Ursulin wrote: >> +/* >> + * Format Modifier tokens: >> + * >> + * When adding a new token please document the layout with a code >> comment, >> + * similar to the fourcc codes above. drm_fourcc.h is considered the >> + * authoritative source for all of thes

Re: [Intel-gfx] [PATCH] drm/i915: More DPIO magic for CHV HDMI & DP

2015-01-30 Thread Ville Syrjälä
On Fri, Jan 30, 2015 at 12:01:53AM +0530, Vijay Purushothaman wrote: > This patch implements latest changes in Gain, lock threshold and integer > co-efficient values using sideband r/w. Without these changes there will > be signal integrity issues for both HDMI and DP. > > Change-Id: I7b7151b5ab3a

Re: [Intel-gfx] [PATCH] RFC: drm: add support for tiled/compressed/etc modifier in addfb2

2015-01-30 Thread Tvrtko Ursulin
On 01/29/2015 05:01 PM, Daniel Vetter wrote: [snip] + +/* + * Format Modifiers: + * + * Format modifiers describe, typically, a re-ordering or modification + * of the data in a plane of an FB. This can be used to express tiled/ + * swizzled formats, or compression, or a combination of the two

Re: [Intel-gfx] [PATCH] drm/i915: Use pipe_config's cpu_transcoder for reading dp_mst hw state

2015-01-30 Thread Ander Conselvan De Oliveira
On pe, 2015-01-30 at 12:15 +0200, Jani Nikula wrote: > On Fri, 30 Jan 2015, Ander Conselvan de Oliveira > wrote: > > On the hardware state readout path, using crtc->config happens to work > > since the proper value is written to it before encoder->get_config() is > > called. However, in the check

[Intel-gfx] [PATCH v2] drm/i915: Use pipe_config's cpu_transcoder for reading encoder hw state

2015-01-30 Thread Ander Conselvan de Oliveira
The get_config() functions for ddi and dp_mst, used to read the value of cpu_transcoder from the crtc->config instead of the state passed as an argument. On the hardware state readout path, that happens to work since the proper value is written to it before encoder->get_config() is called. However,

Re: [Intel-gfx] [PATCH] drm/i915: Use pipe_config's cpu_transcoder for reading dp_mst hw state

2015-01-30 Thread Jani Nikula
On Fri, 30 Jan 2015, Ander Conselvan de Oliveira wrote: > On the hardware state readout path, using crtc->config happens to work > since the proper value is written to it before encoder->get_config() is > called. However, in the check_crtc() path, the state will be read from > the cpu_transcoder

[Intel-gfx] [PATCH] drm/i915: Use pipe_config's cpu_transcoder for reading dp_mst hw state

2015-01-30 Thread Ander Conselvan de Oliveira
On the hardware state readout path, using crtc->config happens to work since the proper value is written to it before encoder->get_config() is called. However, in the check_crtc() path, the state will be read from the cpu_transcoder in the software tracking, instead of the one just read out from hw

Re: [Intel-gfx] [PATCH] drm/i915: Fix a use-after-free in intel_execlists_retire_requests

2015-01-30 Thread Mika Kuoppala
Nick Hoath writes: > Remove request from list before unreferencing it, in case it's actually > the only reference. (Found by Tvrtko Ursulin) > > Signed-off-by: Nick Hoath Reviewed-by: Mika Kuoppala > --- > drivers/gpu/drm/i915/intel_lrc.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(