[Intel-gfx] [I-G-T][PATCH] Add panning test for primary plane.

2014-05-15 Thread Yi Sun
Get CRCs of a full red and a full blue surface as reference. Create a big framebuffer that is twice width and twice height as the current display mode. Fill the top left quarter with red, bottom right quarter with blue Check the scanned out image with the CRTC at position (0, 0) of the framebuffe

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915: Fix gen2 and hsw+ scanline counter

2014-05-15 Thread sourab gupta
On Fri, May 16, 2014 at 11:03 AM, akash goel wrote: > > Sorry not aware of this specific difference in the starting value of > scanline counter for HSW+ (& gen 2), but implementation wise, patch looks > fine. > > Reviewed-by: "Akash Goel " > > Don't have enough info about the initial scanline cou

Re: [Intel-gfx] [PATCH v2 9/9] drm/i915: Fix gen2 and hsw+ scanline counter

2014-05-15 Thread akash goel
Sorry not aware of this specific difference in the starting value of scanline counter for HSW+ (& gen 2), but implementation wise, patch looks fine. Reviewed-by: "Akash Goel " On Thu, May 15, 2014 at 10:53 PM, wrote: > From: Ville Syrjälä > > On gen2 the scanline counter behaves a bit differe

Re: [Intel-gfx] [PATCH 2/4] drm/plane-helper: Add drm_primary_helper_check_update() (v2)

2014-05-15 Thread Lee, Chon Ming
> -Original Message- > From: Rob Clark [mailto:robdcl...@gmail.com] > Sent: Friday, May 16, 2014 11:05 AM > To: Lee, Chon Ming > Cc: Roper, Matthew D; Intel Graphics Development; dri- > de...@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 2/4] drm/plane-helper: Add > drm_primary_

Re: [Intel-gfx] [PATCH] i915: Add module option to support VGA arbiter on HD devices

2014-05-15 Thread Alex Williamson
On Fri, 2014-05-16 at 00:50 +0200, Daniel Vetter wrote: > On Thu, May 15, 2014 at 11:43 PM, Alex Williamson > wrote: > > I don't know what to do with this. It seems like a lot of wishful > > thinking that in the best case would drag on for years. Even if we get > > VGA arbitration out of Xorg, t

Re: [Intel-gfx] [PATCH 2/4] drm/plane-helper: Add drm_primary_helper_check_update() (v2)

2014-05-15 Thread Rob Clark
On Thu, May 15, 2014 at 10:51 PM, Lee, Chon Ming wrote: > On 04/30 10:07, Matt Roper wrote: >> Pull the parameter checking from drm_primary_helper_update() out into >> its own function; drivers that provide their own setplane() >> implementations rather than using the helper may still want to shar

Re: [Intel-gfx] [PATCH v3 8/9] drm/i915: Draw a picture about video timings

2014-05-15 Thread sourab gupta
On Thu, May 15, 2014 at 10:50 PM, wrote: > From: Ville Syrjälä > > The docs are a bit lacking when it comes to describing when certain > timing related events occur in the hardware. Draw a picture which > tries to capture the most important ones. > > v2: Clarify a few details (Imre) > v3: Add HS

Re: [Intel-gfx] [PATCH 2/4] drm/plane-helper: Add drm_primary_helper_check_update() (v2)

2014-05-15 Thread Lee, Chon Ming
On 04/30 10:07, Matt Roper wrote: > Pull the parameter checking from drm_primary_helper_update() out into > its own function; drivers that provide their own setplane() > implementations rather than using the helper may still want to share > this parameter checking logic. > > A few of the checks he

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Add a small adjustment to the pixel counter on interlaced modes

2014-05-15 Thread sourab gupta
On Thu, May 15, 2014 at 8:23 PM, akash goel wrote: > Reviewed the patch & it looks good. > Just to confirm, this patch tries to address the case of a tiny window of > transition, i.e. from the 1st field (last half line) to 2nd field (first > half line). > > Reviewed-by: "Akash Goel " > > > Review

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Improve gen3/4 frame counter

2014-05-15 Thread sourab gupta
Reviewed the patch. Looks good. Reviewed-by: "Sourab Gupta " On Thu, May 15, 2014 at 8:16 PM, akash goel wrote: > > > Reviewed the patch & it looks fine. > > Reviewed-by: "Akash Goel " > On Tue, Apr 29, 2014 at 4:05 PM, wrote: > >> From: Ville Syrjälä >> >> Currently the logic to fix up the

Re: [Intel-gfx] [PATCH 2/5] drm/i915/bdw: Implement a basic PM interrupt handler

2014-05-15 Thread O'Rourke, Tom
>+static void gen8_disable_rps_interrupts(struct drm_device *dev) { >+ struct drm_i915_private *dev_priv = dev->dev_private; >+ >+ I915_WRITE(GEN6_PMINTRMSK, 0x); [TOR:] Please note that for Broadwell, bit 31 in GEN6_PMINTRMSK is not an interrupt disable bit. In "drm/i915: Enabl

[Intel-gfx] [RFC 2/4] drm: Allow drivers to register cursor planes with crtc

2014-05-15 Thread Matt Roper
Universal plane support had placeholders for cursor planes, but didn't actually do anything with them. Save the cursor plane reference inside the crtc and update the cursor plane parameter from void* to drm_plane. Signed-off-by: Matt Roper --- drivers/gpu/drm/drm_crtc.c | 5 - include/drm/d

[Intel-gfx] [RFC 3/4] drm/i915: Add intel_crtc_cursor_set_obj() to set cursor buffer

2014-05-15 Thread Matt Roper
Refactor cursor buffer setting such that the code to actually update the cursor lives in a new function, intel_crtc_cursor_set_obj(), and takes a GEM object as a parameter. The existing legacy cursor ioctl handler, intel_crtc_cursor_set() will now perform the userspace handle lookup and then call

[Intel-gfx] [RFC 4/4] drm/i915: Switch to unified plane cursor handling

2014-05-15 Thread Matt Roper
The DRM core will translate calls to legacy cursor ioctls into universal cursor calls automatically, so there's no need to maintain the legacy cursor support. This greatly simplifies the transition since we don't have to handle reference counting differently depending on which cursor interface was

[Intel-gfx] [RFC 1/4] drm: Support legacy cursor ioctls via universal planes when possible

2014-05-15 Thread Matt Roper
If drivers support universal planes and have registered a cursor plane with the DRM core, we should use that universal plane support when handling legacy cursor ioctls. Drivers that transition to universal planes won't have to maintain separate legacy ioctl handling; drivers that don't transition

[Intel-gfx] [RFC 0/4] Cursor support with universal planes

2014-05-15 Thread Matt Roper
Cursor planes are a bit trickier to support via the universal plane interface than primary planes were. Legacy cursor ioctls take handles to driver buffers directly whereas the universal plane API takes drm_framebuffer's that represent a buffer; due to this mismatch it isn't possible to implement

[Intel-gfx] [PATCH 2/2] tests/kms_psr_sink_crc: Create test to test PSR by checking panel CRC.

2014-05-15 Thread Rodrigo Vivi
v2: Wait psr enable with timeout and more subtest added. v3: Add wait for v_blank leeting test more reliable and preparing to add Baytrail per-pipe tests. v4: Call busy_ioctl on mmap_gtt to match the real usage and remove the need of inactivate on set_domain, what was semantically wrong. v5

[Intel-gfx] [PATCH 1/2] tests/kms_sink_crc_basic: Basic test to verify Sink CRC debugfs.

2014-05-15 Thread Rodrigo Vivi
v2: rebase after a long time. Signed-off-by: Rodrigo Vivi --- tests/Android.mk | 1 + tests/Makefile.sources | 1 + tests/kms_sink_crc_basic.c | 201 + 3 files changed, 203 insertions(+) create mode 100644 tests/kms_sink_crc_basic.c

[Intel-gfx] [PATCH 01/11] drm/i915: move psr_setup_done to psr struct

2014-05-15 Thread Rodrigo Vivi
v2: Avoid more than one setup. Removing initialization and trusting allocation. (By Paulo Zanoni). v3: rebase. Cc: Paulo Zanoni Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/intel_dp.c | 6 ++ drivers/gpu/drm/i915/intel_drv.h | 1 - 3 file

[Intel-gfx] [PATCH 06/11] drm/i915: Force PSR exit by inactivating it.

2014-05-15 Thread Rodrigo Vivi
The perfect solution for psr_exit is the hardware tracking the changes and doing the psr exit by itself. This scenario works for HSW and BDW with some environments like Gnome and Wayland. However there are many other scenarios that this isn't true. Mainly one right now is KDE users on HSW and BDW

[Intel-gfx] [PATCH 00/11] HSW/BDW PSR.

2014-05-15 Thread Rodrigo Vivi
MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Hi All, This series introduces fixes for PSR on HSW and on BDW and "new features" for PSR on BDW. The biggest thing on this serie is the introduction of the psr_exit infrastructure that was actually created

[Intel-gfx] [PATCH 07/11] drm/i915: BDW PSR: Add single frame update support.

2014-05-15 Thread Rodrigo Vivi
When link is in stand by and PSR exit is triggered by a primary or sprite plane flip this mode allows only one single updated frame to be send to display than get back to PSR immediately. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_reg.h | 1 + drivers/gpu/drm/i915/intel_dp.c | 1 +

[Intel-gfx] [PATCH 09/11] drm/i915: BDW PSR: Remove DDIA limitation for Broadwell.

2014-05-15 Thread Rodrigo Vivi
Broadwell has a PSR per transcoder, where DDIA supports link disable and link standby modes while other transcoders only support link standby. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 27 +-- 1 file changed, 21 insertions(+), 6 deletions(-) diff

[Intel-gfx] [PATCH 05/11] drm/i915: Do not try to enable PSR when Panel doesn't suport it.

2014-05-15 Thread Rodrigo Vivi
Also do not cache aux info. That info could be related to another panel. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index fe28

[Intel-gfx] [PATCH 08/11] drm/i915: BDW PSR: Remove limitations that aren't valid for BDW.

2014-05-15 Thread Rodrigo Vivi
Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 5 + 1 file changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 28144d3..9421b0b 100644 --- a/drivers/gpu/drm/i915/intel_dp.c +++ b/drivers/gpu/drm/i915/intel_dp.c @@ -

[Intel-gfx] [PATCH 10/11] drm/i915: Improve PSR debugfs status.

2014-05-15 Thread Rodrigo Vivi
Now we have the active/inactive state for exit and this actually changes the HW enable bit the status was a bit confusing for users. So let's provide more info. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_debugfs.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --gi

[Intel-gfx] [PATCH 04/11] drm/i915: Don't let update_psr function actually enable PSR.

2014-05-15 Thread Rodrigo Vivi
Being more conservative by enabling PSR only on psr_enable function. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index 58537b7..fe2

[Intel-gfx] [PATCH 11/11] drm/i915: PSR HSW: update after enabling sprite.

2014-05-15 Thread Rodrigo Vivi
On the current structure HSW doesn't support PSR with sprites enabled but sprites can be enabled after PSR was enabled what would cause user to miss screen updates. v2: move it to update_plane. Cc: Ville Syrjälä Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_sprite.c | 2 ++ 1 file

[Intel-gfx] [PATCH 03/11] drm/i915: Use HAS_PSR to avoid unecessary interactions.

2014-05-15 Thread Rodrigo Vivi
Let's be more conservative and protect platforms that don't support PSR from unecessary interactions. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/dr

[Intel-gfx] [PATCH 02/11] drm/i915: Update PSR on resume.

2014-05-15 Thread Rodrigo Vivi
Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_suspend.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_suspend.c b/drivers/gpu/drm/i915/i915_suspend.c index 56785e8..a38dee3 100644 --- a/drivers/gpu/drm/i915/i915_suspend.c +++ b/drivers/gpu/drm/i915/

Re: [Intel-gfx] [PATCH] i915: Add module option to support VGA arbiter on HD devices

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 11:43 PM, Alex Williamson wrote: > I don't know what to do with this. It seems like a lot of wishful > thinking that in the best case would drag on for years. Even if we get > VGA arbitration out of Xorg, the bit about making the userspace VGA > arbiter interface lie depe

Re: [Intel-gfx] [PATCH] i915: Add module option to support VGA arbiter on HD devices

2014-05-15 Thread Alex Williamson
On Mon, 2014-05-12 at 21:38 +0200, Daniel Vetter wrote: > On Mon, May 12, 2014 at 01:30:39PM -0600, Alex Williamson wrote: > > On Mon, 2014-05-12 at 21:08 +0200, Daniel Vetter wrote: > > > On Fri, May 09, 2014 at 02:20:41PM -0600, Alex Williamson wrote: > > > > Commit 81b5c7bc found that the curren

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Intel-specific primary plane handling (v6)

2014-05-15 Thread Matt Roper
On Thu, May 15, 2014 at 11:20:39PM +0200, Daniel Vetter wrote: > > > > Ah, you're right. I was conflating explicit disables (fb=0) with > > > > implicit disables (clipped to invisible). I think the v7 I just sent > > > > should handle this properly...for the implicit disable case we leave the > >

Re: [Intel-gfx] [PATCH 00/10] Enable RC6/Turbo on CHV

2014-05-15 Thread Daniel Vetter
On Mon, May 05, 2014 at 06:17:29PM +0530, deepa...@linux.intel.com wrote: > From: Deepak S > > Squashed some of the patches and created a new patch series. Addressed review > comments on most of the patches. > > Ben Widawsky (1): > drm/i915/bdw: Implement a basic PM interrupt handler > > Dee

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Intel-specific primary plane handling (v6)

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 01:59:39PM -0700, Matt Roper wrote: > On Thu, May 15, 2014 at 10:49:52PM +0200, Daniel Vetter wrote: > > On Thu, May 15, 2014 at 12:35:17PM -0700, Matt Roper wrote: > > > On Thu, May 15, 2014 at 08:00:48PM +0300, Ville Syrjälä wrote: > > > > On Thu, May 15, 2014 at 09:37:55A

Re: [Intel-gfx] [PATCH 5/5] drm/i915: Enable rc6 with bdw

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 08:58:11PM +0300, Mika Kuoppala wrote: > Everything should be in place so enable rc6/rps for bdw. > > Reviewed-by: Ville Syrjälä > Signed-off-by: Mika Kuoppala Merged all 5 patches, thanks. Now that we have the prerequisites it's time to give runtime pm on bdw another sh

Re: [Intel-gfx] [PATCH 1/3] drm/i915: Fix obj->map_and_fenceable for ppgtt

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 04:55:25PM +0100, Chris Wilson wrote: > With ppgtt, it is no longer correct to mark an object as > map_and_fenceable if we simply unbind it from the global gtt. This has > consequences during execbuffer where we simply use > obj->map_and_fenceable in use_cpu_reloc() to decid

Re: [Intel-gfx] [PATCH 00/50] Execlists v2

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 02:15:44PM +, Mateo Lozano, Oscar wrote: > > I've done a very cursory read of this, and my original comment from my > > original high-level review on the internal list still stands: I'm freaked > > out by how > > invasive this is into the existing ring code. All the cha

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Intel-specific primary plane handling (v6)

2014-05-15 Thread Matt Roper
On Thu, May 15, 2014 at 10:49:52PM +0200, Daniel Vetter wrote: > On Thu, May 15, 2014 at 12:35:17PM -0700, Matt Roper wrote: > > On Thu, May 15, 2014 at 08:00:48PM +0300, Ville Syrjälä wrote: > > > On Thu, May 15, 2014 at 09:37:55AM -0700, Matt Roper wrote: > > > > On Thu, May 15, 2014 at 06:52:28P

Re: [Intel-gfx] [PATCH 06/50] drm/i915: s/intel_ring_buffer/intel_engine

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 02:17:23PM +, Mateo Lozano, Oscar wrote: > > -Original Message- > > From: Lespiau, Damien > > Sent: Wednesday, May 14, 2014 2:26 PM > > To: Daniel Vetter > > Cc: Mateo Lozano, Oscar; intel-gfx@lists.freedesktop.org > > Subject: Re: [Intel-gfx] [PATCH 06/50] drm/i

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Intel-specific primary plane handling (v6)

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 12:35:17PM -0700, Matt Roper wrote: > On Thu, May 15, 2014 at 08:00:48PM +0300, Ville Syrjälä wrote: > > On Thu, May 15, 2014 at 09:37:55AM -0700, Matt Roper wrote: > > > On Thu, May 15, 2014 at 06:52:28PM +0300, Ville Syrjälä wrote: > > > ... > > > > > > > > > + }; > >

Re: [Intel-gfx] [PATCH 3/4] drm/i915: MIPI PPS delays added

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 04:06:56PM +0100, Damien Lespiau wrote: > On Mon, Apr 14, 2014 at 11:18:26AM +0530, Shobhit Kumar wrote: > > Added as generic parameters which will be initialized in the panel > > driver and are specific to panels. > > > > Backlight delays have also kept as placeholders and

Re: [Intel-gfx] [PATCH] drm/doc: Discourage usage of MODESET_CTL ioctl

2014-05-15 Thread Laurent Pinchart
Hi Daniel, Thank you for the patch. On Thursday 15 May 2014 15:00:08 Daniel Vetter wrote: > Leftover from the old days of ums and should be used any longer. Since > > commit 29935554b384b1b3a7377d6f0b03b21d18a61683 > Author: Laurent Pinchart > Date: Wed May 30 00:58:09 2012 +0200 > > drm

Re: [Intel-gfx] [PATCH] drm/i915: honour forced connector modes

2014-05-15 Thread Chris Wilson
On Thu, May 15, 2014 at 12:38:01PM -0700, Jesse Barnes wrote: > On Thu, 15 May 2014 10:55:41 +0100 > Chris Wilson wrote: > > > In the move over to use BIOS connector configs, we lost the ability to > > force a specific set of connectors on or off. Try to remedy that by > > dropping back to the o

Re: [Intel-gfx] [PATCH] drm/i915: honour forced connector modes

2014-05-15 Thread Jesse Barnes
On Thu, 15 May 2014 10:55:41 +0100 Chris Wilson wrote: > In the move over to use BIOS connector configs, we lost the ability to > force a specific set of connectors on or off. Try to remedy that by > dropping back to the old behavior if we detect a hard coded connector > config that tries to ena

[Intel-gfx] [PATCH 4/4] kms_universal_plane: Universal plane testing (v3)

2014-05-15 Thread Matt Roper
Add a simple test to exercise universal plane support. v3: - For testing while crtc is off, switch between several different primary plane fb's before reenabling the crtc. This will help catch pin/unpin mistakes. v2: - Test that pageflips error out gracefully when the primary plane is

Re: [Intel-gfx] [PATCH] drm: Perform cmdline mode parsing during connector initialisation

2014-05-15 Thread Jesse Barnes
On Thu, 15 May 2014 10:54:36 +0100 Chris Wilson wrote: > i915.ko has a custom fbdev initialisation routine that aims to preserve > the current mode set by the BIOS, unless overruled by the user. The > user's wishes are determined by what, if any, mode is specified on the > command line (via the v

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Intel-specific primary plane handling (v6)

2014-05-15 Thread Matt Roper
On Thu, May 15, 2014 at 08:00:48PM +0300, Ville Syrjälä wrote: > On Thu, May 15, 2014 at 09:37:55AM -0700, Matt Roper wrote: > > On Thu, May 15, 2014 at 06:52:28PM +0300, Ville Syrjälä wrote: > > ... > > > > > > > + }; > > > > + bool visible; > > > > + int ret; > > > > + > > > >

[Intel-gfx] [PATCH 4/4] drm/i915: Intel-specific primary plane handling (v7)

2014-05-15 Thread Matt Roper
Intel hardware allows the primary plane to be disabled independently of the CRTC. Provide custom primary plane handling to allow this. v7: - Clip primary plane to invisible when crtc is disabled since intel_crtc->config.pipe_src_{w,h} may be garbage otherwise. - Unpin old fb before pinning n

Re: [Intel-gfx] AAEON Asus Company Bay Trail Linux Issue LVDS

2014-05-15 Thread Mark Lee
-BEGIN PGP SIGNED MESSAGE- Hash: SHA256 To Domonik, Your dmesg log confirms that you have a KMS issue (you booted this with KMS right)? I've extracted the important parts (stack traces) below. I'll be looking into the issue, I am also cc'ing this to the Intel mailing list. From, Mark [

Re: [Intel-gfx] [PATCH 1/5] drm/i915: Bail out early on gen6_signal if no semaphores

2014-05-15 Thread Ville Syrjälä
On Thu, May 15, 2014 at 08:58:07PM +0300, Mika Kuoppala wrote: > If we dont have semaphores enabled, we allocate 4 > dwords for signalling. But end up emitting more regardless. > > Fix this by bailing out early if semaphores are not enabled. > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi

[Intel-gfx] [PATCH 5/5] drm/i915: Enable rc6 with bdw

2014-05-15 Thread Mika Kuoppala
Everything should be in place so enable rc6/rps for bdw. Reviewed-by: Ville Syrjälä Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/intel_pm.c |8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_pm.c i

[Intel-gfx] [PATCH 1/5] drm/i915: Bail out early on gen6_signal if no semaphores

2014-05-15 Thread Mika Kuoppala
If we dont have semaphores enabled, we allocate 4 dwords for signalling. But end up emitting more regardless. Fix this by bailing out early if semaphores are not enabled. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78274 Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=78283 Sign

[Intel-gfx] [PATCH 2/5] drm/i915/bdw: Implement a basic PM interrupt handler

2014-05-15 Thread Mika Kuoppala
From: Ben Widawsky Almost all of it is reusable from the existing code. The primary difference is we need to do even less in the interrupt handler, since interrupts are not shared in the same way. The patch is mostly a copy-paste of the existing snb+ code, with updates to the relevant parts requ

[Intel-gfx] [PATCH 3/5] drm/i915: Enable PM Interrupts target via Display Interface.

2014-05-15 Thread Mika Kuoppala
From: Deepak S In BDW, Apart from unmasking up/down threshold interrupts. we need to umask bit 32 of PM_INTRMASK to route interrupts to target via Display Interface. v2: Add (1<<31) mask (Ville) v3: Add Gen check for the mask (ville) Reviewed-by: Ville Syrjälä Signed-off-by: Deepak S --- dr

[Intel-gfx] [PATCH 4/5] drm/i915: Fix rc6 options debug info

2014-05-15 Thread Mika Kuoppala
by correctly displaying result and requested. Suggested-by: Imre Deak Reviewed-by: Ville Syrjälä Signed-off-by: Mika Kuoppala --- drivers/gpu/drm/i915/intel_pm.c |2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/intel_

[Intel-gfx] [PATCH v2 9/9] drm/i915: Fix gen2 and hsw+ scanline counter

2014-05-15 Thread ville . syrjala
From: Ville Syrjälä On gen2 the scanline counter behaves a bit differently from the later generations. Instead of adding one to the raw scanline counter value, we must subtract one. On HSW/BDW the scanline counter requires a +2 adjustment on HDMI outputs. DP outputs on the on the other require t

[Intel-gfx] [PATCH v3 8/9] drm/i915: Draw a picture about video timings

2014-05-15 Thread ville . syrjala
From: Ville Syrjälä The docs are a bit lacking when it comes to describing when certain timing related events occur in the hardware. Draw a picture which tries to capture the most important ones. v2: Clarify a few details (Imre) v3: Add HSW+ HDMI scanline counter numbers Acked-by: Imre Deak Re

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Intel-specific primary plane handling (v6)

2014-05-15 Thread Ville Syrjälä
On Thu, May 15, 2014 at 09:37:55AM -0700, Matt Roper wrote: > On Thu, May 15, 2014 at 06:52:28PM +0300, Ville Syrjälä wrote: > ... > > > > > + }; > > > + bool visible; > > > + int ret; > > > + > > > + ret = drm_primary_helper_check_update(plane, crtc, fb, > > > +

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Add support for Generic MIPI panel driver

2014-05-15 Thread Damien Lespiau
On Mon, Apr 14, 2014 at 11:18:27AM +0530, Shobhit Kumar wrote: > This driver makes use of the generic panel information from the VBT. > Panel information is classified into two - panel configuration and panel > power sequence which is unique to each panel. The generic driver uses the > panel config

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Intel-specific primary plane handling (v6)

2014-05-15 Thread Matt Roper
On Thu, May 15, 2014 at 06:52:28PM +0300, Ville Syrjälä wrote: ... > > > + }; > > + bool visible; > > + int ret; > > + > > + ret = drm_primary_helper_check_update(plane, crtc, fb, > > + &src, &dest, &clip, > > +

[Intel-gfx] [PATCH 3/4] drm/i915: don't force full modeset if primary plane is disabled (v2)

2014-05-15 Thread Matt Roper
In a future patch, we'll allow the primary plane to be disabled by userspace via the universal plane API. If a modeset is requested while the primary plane is disabled, crtc->primary->fb will be NULL which generally triggers a full modeset (except in fastboot situations). If we detect that the cr

[Intel-gfx] [PATCH] tests/kms_render: don't loop through modes

2014-05-15 Thread Daniel Vetter
We kinda have testdisplay for this ... and doing this tends to take forever. Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=77709 Signed-off-by: Daniel Vetter --- tests/kms_render.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/tests/kms_render.c b/test

[Intel-gfx] [PATCH 3/3] drm/i915: Add soft-pinning API for execbuffer

2014-05-15 Thread Chris Wilson
Userspace can pass in an offset that it presumes the object is located at. The kernel will then do its utmost to fit the object into that location. The assumption is that userspace is handling its own object locations (for example along with full-ppgtt) and that the kernel will rarely have to make

[Intel-gfx] [PATCH 1/3] drm/i915: Fix obj->map_and_fenceable for ppgtt

2014-05-15 Thread Chris Wilson
With ppgtt, it is no longer correct to mark an object as map_and_fenceable if we simply unbind it from the global gtt. This has consequences during execbuffer where we simply use obj->map_and_fenceable in use_cpu_reloc() to decide which access method to use for writing into the object. Now for a pp

[Intel-gfx] [PATCH 2/3] drm/i915: Prevent negative relocation deltas from wrapping

2014-05-15 Thread Chris Wilson
This is pure evil. Userspace, I'm looking at you SNA, repacks batch buffers on the fly after generation as they are being passed to the kernel for execution. These batches also contain self-referenced relocations as a single buffer encompasses the state commands, kernels, vertices and sampler. Duri

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Intel-specific primary plane handling (v6)

2014-05-15 Thread Ville Syrjälä
On Wed, Apr 30, 2014 at 10:07:03AM -0700, Matt Roper wrote: > Intel hardware allows the primary plane to be disabled independently of > the CRTC. Provide custom primary plane handling to allow this. > > v6: > - Pass rectangles to primary helper check function and get plane >visibility back.

[Intel-gfx] AAEON Asus Company Bay Trail Linux Issue LVDS

2014-05-15 Thread Dominik Rozek
Hi Team: I work for AAEON an Asus company who makes embedded, long life, motherboards. I am running into a situation with a large customer of mine that wants to use a 15.6" LCD Panel, https://dl.dropboxusercontent.com/u/52392/TFT-LCD%2BPreliminary%2BSpecification%2BG156BGE-L01%2Bver%2B1.0.pdf

Re: [Intel-gfx] 3.15-rc: regression in suspend

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 5:29 PM, Jiri Kosina wrote: >> > Note that X do work somehow after resume (I can't switch virtual >> > desktops and dialog is stuck on screen, but it is not complete >> > failure). I can do ctrl-alt-f1 and get to useful prompt. >> >> Oops. You were right. It seems it is dup

Re: [Intel-gfx] [PATCH v2 8/9] drm/i915: Draw a picture about video timings

2014-05-15 Thread akash goel
Nice illustration of the various events in a Video signal. Reviewed-by: "Akash Goel " On Tue, Apr 29, 2014 at 4:05 PM, wrote: > From: Ville Syrjälä > > The docs are a bit lacking when it comes to describing when certain > timing related events occur in the hardware. Draw a picture which > tri

Re: [Intel-gfx] [PATCH 3/4] drm/i915: MIPI PPS delays added

2014-05-15 Thread Damien Lespiau
On Mon, Apr 14, 2014 at 11:18:26AM +0530, Shobhit Kumar wrote: > Added as generic parameters which will be initialized in the panel > driver and are specific to panels. > > Backlight delays have also kept as placeholders and will be used used > once we have MIPI backlight enabling support > > Sig

Re: [Intel-gfx] [PATCH 2/4] drm/i915: MIPI init count programming as generic parameter

2014-05-15 Thread Damien Lespiau
On Mon, Apr 14, 2014 at 11:18:25AM +0530, Shobhit Kumar wrote: > Signed-off-by: Shobhit Kumar Reviewed-by: Damien Lespiau -- Damien ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] [PATCH 1/4] drm/i915: Correct MIPI operation mode as per expected values from VBT

2014-05-15 Thread Damien Lespiau
On Mon, Apr 14, 2014 at 11:18:24AM +0530, Shobhit Kumar wrote: > In VBT fields operation mode is 0 for Video mode and 1 for command mode. > This field will be directly used as is in generic panel driver. So > adjust accordingly. > > Signed-off-by: Shobhit Kumar Reviewed-by: Damien Lespiau --

[Intel-gfx] [PATCH] tests/pm_pc8: Use igt_assert_cmpint

2014-05-15 Thread Daniel Vetter
More pretty! Signed-off-by: Daniel Vetter --- tests/pm_pc8.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/tests/pm_pc8.c b/tests/pm_pc8.c index d36350370ba2..323e0729b9e6 100644 --- a/tests/pm_pc8.c +++ b/tests/pm_pc8.c @@ -605,8 +605,7 @@ static void test_i2c(struct mod

Re: [Intel-gfx] [PATCH 3/4] drm/i915: don't force full modeset if primary plane is disabled

2014-05-15 Thread Ville Syrjälä
On Wed, Apr 30, 2014 at 10:07:02AM -0700, Matt Roper wrote: > In a future patch, we'll allow the primary plane to be disabled by > userspace via the universal plane API. If a modeset is requested while > the primary plane is disabled, crtc->primary->fb will be NULL which > generally triggers a ful

Re: [Intel-gfx] [PATCH 6/9] drm/i915: Add a small adjustment to the pixel counter on interlaced modes

2014-05-15 Thread akash goel
Reviewed the patch & it looks good. Just to confirm, this patch tries to address the case of a tiny window of transition, i.e. from the 1st field (last half line) to 2nd field (first half line). Reviewed-by: "Akash Goel " On Tue, Apr 29, 2014 at 4:05 PM, wrote: > From: Ville Syrjälä > > In in

Re: [Intel-gfx] [PATCH 7/9] drm/i915: Improve gen3/4 frame counter

2014-05-15 Thread akash goel
Reviewed the patch & it looks fine. Reviewed-by: "Akash Goel " On Tue, Apr 29, 2014 at 4:05 PM, wrote: > From: Ville Syrjälä > > Currently the logic to fix up the frame counter on gen3/4 assumes that > start of vblank occurs at vblank_start*htotal pixels, when in fact > it occurs htotal-hsync_s

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Don't allow the FBC base to be 0

2014-05-15 Thread Damien Lespiau
On Thu, May 15, 2014 at 05:05:05PM +0300, Ville Syrjälä wrote: > > I must be missing something important. The FBC buffer is the only one > > requiring a non-zero offset from the base of stolen memory. > > Nothing important can be placed there since the CS apparently writes > there without anyone e

Re: [Intel-gfx] [PATCH v2] drm/i915: Increase WM memory latency values?on SNB

2014-05-15 Thread Robert Navarro
Robert Navarro gmail.com> writes: > > Finally got around to compiling this for my system, there were a few issues > with the build scripts on the latest Ubuntu. > > Currently running 3.15.0-rc3-custom-drm-intel-nightly-bug70254+ with no > issues thus far. > > I'll give a few more days just to

Re: [Intel-gfx] [PATCH 06/50] drm/i915: s/intel_ring_buffer/intel_engine

2014-05-15 Thread Mateo Lozano, Oscar
> -Original Message- > From: Lespiau, Damien > Sent: Wednesday, May 14, 2014 2:26 PM > To: Daniel Vetter > Cc: Mateo Lozano, Oscar; intel-gfx@lists.freedesktop.org > Subject: Re: [Intel-gfx] [PATCH 06/50] drm/i915: > s/intel_ring_buffer/intel_engine > > On Tue, May 13, 2014 at 03:28:27PM +

Re: [Intel-gfx] [PATCH 00/50] Execlists v2

2014-05-15 Thread Mateo Lozano, Oscar
> I've done a very cursory read of this, and my original comment from my > original high-level review on the internal list still stands: I'm freaked out > by how > invasive this is into the existing ring code. All the changes in i915_dma.c > look > very suspicious, since that code is for the lega

Re: [Intel-gfx] [PATCH] drm/i915/bdw: Don't allow the FBC base to be 0

2014-05-15 Thread Ville Syrjälä
On Fri, May 02, 2014 at 06:48:52PM -0700, Ben Widawsky wrote: > On Fri, May 02, 2014 at 09:35:20PM +0100, Chris Wilson wrote: > > On Fri, May 02, 2014 at 10:00:01AM -0700, Ben Widawsky wrote: > > > On Fri, May 02, 2014 at 04:00:25PM +0300, Ville Syrjälä wrote: > > > > On Fri, May 02, 2014 at 09:38:

Re: [Intel-gfx] [PATCH] drm/i915: Gracefully handle obj not bound to GGTT in is_pin_display

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 01:14:54PM +, Mateo Lozano, Oscar wrote: > > > But looking at the code a better way should be: > > > 1. Create new bo, wrap it in a kms fb. > > > 2. Slap busy load onto that bo, e.g. reapeatedly fill it with the blitter. > > > 3. Enable evil interruptor (igt_fork_signal_

[Intel-gfx] [PATCH 1/2] drm/irq: Add kms-native crtc interface functions

2014-05-15 Thread Daniel Vetter
We need to start somewhere ... With this the only places left in i915 where we use pipe integers is in the interrupt handling code. And there it actually makes some amount of sense. v2: - Polish kerneldoc a bit (Thierry). - Drop "dev" parameter since it's unecessary. - Split out i915 changes (Thie

[Intel-gfx] [PATCH 2/2] drm/i915: Use new kms-native vblank functions

2014-05-15 Thread Daniel Vetter
Only the low-level irq handling functions still use integer crtc indices with this. But fixing that will require a lot more sugery and some good ideas for backwards compat with old ums userspace. Both in drivers and in the drm core. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_dis

Re: [Intel-gfx] [PATCH] drm/i915: Gracefully handle obj not bound to GGTT in is_pin_display

2014-05-15 Thread Ville Syrjälä
On Thu, May 15, 2014 at 01:14:54PM +, Mateo Lozano, Oscar wrote: > > > But looking at the code a better way should be: > > > 1. Create new bo, wrap it in a kms fb. > > > 2. Slap busy load onto that bo, e.g. reapeatedly fill it with the blitter. > > > 3. Enable evil interruptor (igt_fork_signal_

Re: [Intel-gfx] [PATCH] drm/i915: Gracefully handle obj not bound to GGTT in is_pin_display

2014-05-15 Thread Mateo Lozano, Oscar
> > But looking at the code a better way should be: > > 1. Create new bo, wrap it in a kms fb. > > 2. Slap busy load onto that bo, e.g. reapeatedly fill it with the blitter. > > 3. Enable evil interruptor (igt_fork_signal_helper). > > 4. Submit pageflip > > > > -> Boom since the set_cache_level wil

[Intel-gfx] [PATCH] drm/irq: kerneldoc polish

2014-05-15 Thread Daniel Vetter
- Integrate into the drm DocBook - Disable kerneldoc for functions not exported to drivers. - Properly document the new drm_vblank_on|off and add cautious comments explaining when drm_vblank_pre|post_modesets shouldn't be used. - General polish and OCD. v2: Polish as suggested by Thierry. Cc:

[Intel-gfx] [PATCH] drm/doc: Discourage usage of MODESET_CTL ioctl

2014-05-15 Thread Daniel Vetter
Leftover from the old days of ums and should be used any longer. Since commit 29935554b384b1b3a7377d6f0b03b21d18a61683 Author: Laurent Pinchart Date: Wed May 30 00:58:09 2012 +0200 drm: Disallow DRM_IOCTL_MODESET_CTL for KMS drivers it is a complete no-Op for kms drivers. v2: Fix up mang

Re: [Intel-gfx] [PATCH] drm/i915: Prevent negative relocation deltas from wrapping

2014-05-15 Thread Chris Wilson
On Thu, May 15, 2014 at 02:46:32PM +0200, Daniel Vetter wrote: > On Thu, May 15, 2014 at 01:17:12PM +0100, Chris Wilson wrote: > > This is pure evil. Userspace, I'm looking at you SNA, repacks batch > > buffers on the fly after generation as they are being passed to the > > kernel for execution. Th

Re: [Intel-gfx] [PATCH] intel-gpu-tools: Skip kms_fence_pin_leak if no cairo

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 10:25:48AM +0100, tim.g...@intel.com wrote: > From: Tim Gore > > The kms_fence_pin_leak test uses igt_kms.c which in turn > uses cairo. So in Android.mk add this test to the skip list > if we dont have cairo > > Issue: VIZ-3894 > Signed-off-by: Tim Gore Merged, thanks f

Re: [Intel-gfx] [PATCH] drm/i915: Prevent negative relocation deltas from wrapping

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 01:17:12PM +0100, Chris Wilson wrote: > This is pure evil. Userspace, I'm looking at you SNA, repacks batch > buffers on the fly after generation as they are being passed to the > kernel for execution. These batches also contain self-referenced > relocations as a single buff

[Intel-gfx] [PATCH v5 1/8] drm/i915/chv: Enable Render Standby (RC6) for Cherryview

2014-05-15 Thread deepak . s
From: Deepak S v2: Configure PCBR if BIOS fails allocate pcbr (deepak) v3: Fix PCBR condition check during CHV RC6 Enable flag set v4: Fixup PCBR comment msg. (Chris) Rebase against latest code (Deak) Fixup Spurious hunk (Ben) v5: Fix PCBR and commentis msg (mika) Signed-off-by: Deepa

Re: [Intel-gfx] [PATCH v4] drm/i915: Replaced Blitter ring based flips with MMIO flips for VLV

2014-05-15 Thread Ville Syrjälä
On Thu, May 15, 2014 at 11:47:37AM +0530, sourab.gu...@intel.com wrote: > From: Sourab Gupta > > Using MMIO based flips on Gen5+ for Media power well residency optimization. > The blitter ring is currently being used just for command streamer based > flip calls. For pure 3D workloads, with MMIO f

[Intel-gfx] [PATCH] drm/i915: Prevent negative relocation deltas from wrapping

2014-05-15 Thread Chris Wilson
This is pure evil. Userspace, I'm looking at you SNA, repacks batch buffers on the fly after generation as they are being passed to the kernel for execution. These batches also contain self-referenced relocations as a single buffer encompasses the state commands, kernels, vertices and sampler. Duri

Re: [Intel-gfx] [PATCH 08/12] drm/irq: Add kms-native crtc interface functions

2014-05-15 Thread Daniel Vetter
On Thu, May 15, 2014 at 12:42 PM, Thierry Reding wrote: > On Thu, May 15, 2014 at 12:10:16PM +0200, Daniel Vetter wrote: >> On Thu, May 15, 2014 at 9:34 AM, Thierry Reding >> wrote: >> > This seems slightly backwards. Since drm_vblank_get() is what's being >> > deprecated here, wouldn't it make m

Re: [Intel-gfx] [PATCH v2] drm/i915: Increase WM memory latency values on SNB

2014-05-15 Thread Jani Nikula
On Thu, 15 May 2014, Ville Syrjälä wrote: > On Thu, May 15, 2014 at 01:34:44PM +0300, Jani Nikula wrote: >> On Thu, 15 May 2014, Chris Wilson wrote: >> > On Thu, May 15, 2014 at 01:13:21PM +0300, Jani Nikula wrote: >> >> On Thu, 08 May 2014, ville.syrj...@linux.intel.com wrote: >> >> > From: Vill

Re: [Intel-gfx] [PATCH v2] drm/i915: Increase WM memory latency values on SNB

2014-05-15 Thread Ville Syrjälä
On Thu, May 15, 2014 at 01:34:44PM +0300, Jani Nikula wrote: > On Thu, 15 May 2014, Chris Wilson wrote: > > On Thu, May 15, 2014 at 01:13:21PM +0300, Jani Nikula wrote: > >> On Thu, 08 May 2014, ville.syrj...@linux.intel.com wrote: > >> > From: Ville Syrjälä > >> > +static void snb_wm_latency_qui

Re: [Intel-gfx] [PATCH 08/12] drm/irq: Add kms-native crtc interface functions

2014-05-15 Thread Thierry Reding
On Thu, May 15, 2014 at 12:10:16PM +0200, Daniel Vetter wrote: > On Thu, May 15, 2014 at 9:34 AM, Thierry Reding > wrote: > > This seems slightly backwards. Since drm_vblank_get() is what's being > > deprecated here, wouldn't it make more sense to write > > drm_crtc_vblank_get() in terms of struct

Re: [Intel-gfx] [PATCH] drm/i915: Fix dynamic allocation of physical handles

2014-05-15 Thread Ville Syrjälä
On Wed, May 14, 2014 at 01:53:17PM +0100, Chris Wilson wrote: > A single object may be referenced by multiple registers fundamentally > breaking the static allotment of ids in the current design. When the > object is used the second time, the physical address of the first > assignment is relinquish

  1   2   >