Re: [Intel-gfx] [PATCH] drm/i915/opregion: work around buggy firmware that provides 8+ output devices

2014-02-18 Thread Matthew Garrett
On Wed, Feb 19, 2014 at 03:31:29PM +0800, Aaron Lu wrote: > DID2 is in system memory region and has some assigned value like 0x400 > when we read it. For this case it is easy since there is only one output > device that is of type LVDS so we can match it to connector of type eDP > or LVDS, suppose

Re: [Intel-gfx] [PATCH] drm/i915/opregion: work around buggy firmware that provides 8+ output devices

2014-02-18 Thread Aaron Lu
On 02/13/2014 08:03 PM, Daniel Vetter wrote: > On Thu, Feb 13, 2014 at 11:08 AM, Chris Wilson > wrote: >> On Thu, Feb 13, 2014 at 05:10:25PM +0800, Aaron Lu wrote: >>> On 02/12/2014 06:31 PM, Chris Wilson wrote: On Wed, Feb 12, 2014 at 11:05:40AM +0800, Aaron Lu wrote: > The ACPI table o

[Intel-gfx] Request for feedback : New Panel-fitter property for connectors

2014-02-18 Thread Goel, Akash
Hello, We are planning to expose a new panel fitter property for the connectors. We have some use cases like a full screen video playback, where we can flip the frame buffer of any size irrespective of the pipe timings and enable the panel fitter to do scaling instead of using the GPU. Other

Re: [Intel-gfx] [PATCH v4] ACPI / video: Add systems that should favour native backlight interface

2014-02-18 Thread Aaron Lu
On 02/18/2014 11:46 PM, Mika Westerberg wrote: > On Tue, Feb 18, 2014 at 04:22:27PM +0100, Rafael J. Wysocki wrote: >> On Tuesday, February 18, 2014 02:31:46 PM Takashi Iwai wrote: >>> At Tue, 18 Feb 2014 12:34:42 +0200, >>> Mika Westerberg wrote: On Tue, Feb 18, 2014 at 01:54:20PM +0800,

Re: [Intel-gfx] [PATCH] drm/i915: Accurately track when we mark the hardware as idle/busy

2014-02-18 Thread Paulo Zanoni
2014-02-18 18:34 GMT-03:00 Paulo Zanoni : > 2014-02-18 16:25 GMT-03:00 Mika Kuoppala : >> Chris Wilson writes: >> >>> We currently call intel_mark_idle() too often, as we do so as a >>> side-effect of processing the request queue. However, we the calls to >>> intel_mark_idle() are expected to be p

Re: [Intel-gfx] [PATCH v4] ACPI / video: Add systems that should favour native backlight interface

2014-02-18 Thread Rafael J. Wysocki
On Tuesday, February 18, 2014 11:28:29 PM Igor Gnatenko wrote: > On Tue, 2014-02-18 at 16:22 +0100, Rafael J. Wysocki wrote: > > On Tuesday, February 18, 2014 02:31:46 PM Takashi Iwai wrote: > > > At Tue, 18 Feb 2014 12:34:42 +0200, > > > Mika Westerberg wrote: > > > > > > > > On Tue, Feb 18, 201

Re: [Intel-gfx] [PATCH] drm/i915: Accurately track when we mark the hardware as idle/busy

2014-02-18 Thread Paulo Zanoni
2014-02-18 16:25 GMT-03:00 Mika Kuoppala : > Chris Wilson writes: > >> We currently call intel_mark_idle() too often, as we do so as a >> side-effect of processing the request queue. However, we the calls to >> intel_mark_idle() are expected to be paired with a call to >> intel_mark_busy() (or els

[Intel-gfx] [PATCH] drm/i915: honor forced connector modes

2014-02-18 Thread Jesse Barnes
In the move over to use BIOS connector configs, we lost the ability to force a specific set of connectors on or off. Try to remedy that by dropping back to the old behavior if we detect a hard coded connector config. Reported-by: Ville Syrjälä Signed-off-by: Jesse Barnes --- drivers/gpu/drm/i9

Re: [Intel-gfx] [PATCH 2/7] drm/i915: Resolving the memory region conflict for Stolen area

2014-02-18 Thread Jesse Barnes
On Tue, 28 Jan 2014 10:14:03 +0100 Daniel Vetter wrote: > On Tue, Jan 28, 2014 at 10:10 AM, Goel, Akash wrote: > > Hi Daniel, > > > > Please let us know about this patch, will this be up-streamed. > > 1. I've just sent out the merge confirmation mail minutes ago. > 2. Please _never_ drop mailin

Re: [Intel-gfx] [PATCH v4] ACPI / video: Add systems that should favour native backlight interface

2014-02-18 Thread Igor Gnatenko
On Tue, 2014-02-18 at 16:22 +0100, Rafael J. Wysocki wrote: > On Tuesday, February 18, 2014 02:31:46 PM Takashi Iwai wrote: > > At Tue, 18 Feb 2014 12:34:42 +0200, > > Mika Westerberg wrote: > > > > > > On Tue, Feb 18, 2014 at 01:54:20PM +0800, Aaron Lu wrote: > > > > + { > > > > + .c

Re: [Intel-gfx] [PATCH] drm/i915: Accurately track when we mark the hardware as idle/busy

2014-02-18 Thread Mika Kuoppala
Chris Wilson writes: > We currently call intel_mark_idle() too often, as we do so as a > side-effect of processing the request queue. However, we the calls to > intel_mark_idle() are expected to be paired with a call to > intel_mark_busy() (or else we try to idle the hardware by accessing > regis

Re: [Intel-gfx] [PATCH] drm/i915: Do not access stolen memory directly by the CPU, even for error capture

2014-02-18 Thread Ben Widawsky
On Wed, Feb 12, 2014 at 07:18:40PM +, Chris Wilson wrote: > For stolen pages, since it is verboten to access them directly on many > architectures, we have to read them through the GTT aperture. If they > are not accessible through the aperture, then we have to abort. > > This was complicated

Re: [Intel-gfx] [PATCH] drm/i915: Fix forcewake counts for gen8

2014-02-18 Thread Mika Kuoppala
Ben Widawsky writes: > On Tue, Feb 18, 2014 at 07:10:24PM +0200, Mika Kuoppala wrote: >> Sometimes generic driver code gets forcewake explicitly by >> gen6_gt_force_wake_get(), which check forcewake_count before accessing >> hardware. However the register access with gen8_write function access >>

Re: [Intel-gfx] [PATCH] xf86-video-intel: Unbreak build on OpenBSD

2014-02-18 Thread Chris Wilson
On Tue, Feb 18, 2014 at 07:55:46PM +0100, Mark Kettenis wrote: > > Date: Tue, 18 Feb 2014 08:06:36 + > > From: Chris Wilson > > > > On Sat, Feb 15, 2014 at 09:29:42PM +0100, Mark Kettenis wrote: > > > Fallout from the backlight helper changes. > > > > Apologies for missing this earlier. I ha

[Intel-gfx] [PATCH 03/11] [v2] drm/i915: Rename and comment all the RPS *stuff*

2014-02-18 Thread Ben Widawsky
The names of the struct members for RPS are stupid. Every time I need to do anything in this code I have to spend a significant amount of time to remember what it all means. By renaming the variables (and adding the comments) I hope to clear up the situation. Indeed doing this make some upcoming pa

Re: [Intel-gfx] [PATCH] xf86-video-intel: Unbreak build on OpenBSD

2014-02-18 Thread Mark Kettenis
> Date: Tue, 18 Feb 2014 08:06:36 + > From: Chris Wilson > > On Sat, Feb 15, 2014 at 09:29:42PM +0100, Mark Kettenis wrote: > > Fallout from the backlight helper changes. > > Apologies for missing this earlier. I have rearranged the code once > again to try to push the OpenBSD specifics down

[Intel-gfx] [PATCH] drm/i915: Accurately track when we mark the hardware as idle/busy

2014-02-18 Thread Chris Wilson
We currently call intel_mark_idle() too often, as we do so as a side-effect of processing the request queue. However, we the calls to intel_mark_idle() are expected to be paired with a call to intel_mark_busy() (or else we try to idle the hardware by accessing registers that are already disabled).

Re: [Intel-gfx] [PATCH] drm/i915: Fix forcewake counts for gen8

2014-02-18 Thread Ben Widawsky
On Tue, Feb 18, 2014 at 07:10:24PM +0200, Mika Kuoppala wrote: > Sometimes generic driver code gets forcewake explicitly by > gen6_gt_force_wake_get(), which check forcewake_count before accessing > hardware. However the register access with gen8_write function access > low level hw accessors direc

[Intel-gfx] [PATCH 5/6] tests/gem_exec_parse: Test for batches w/o MI_BATCH_BUFFER_END

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin Signed-off-by: Brad Volkin --- tests/gem_exec_parse.c | 9 + 1 file changed, 9 insertions(+) diff --git a/tests/gem_exec_parse.c b/tests/gem_exec_parse.c index 9e90408..004c3bf 100644 --- a/tests/gem_exec_parse.c +++ b/tests/gem_exec_parse.c @@ -257,6 +257,15 @@ igt_m

[Intel-gfx] [PATCH 04/13] drm/i915: Reject privileged commands

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin The spec defines most of these commands as privileged. A few others, like the semaphore mbox command and some display commands, are also reserved for the driver's use. Subsequent patches relax some of these restrictions. v2: Rebased Signed-off-by: Brad Volkin --- drivers/gpu

[Intel-gfx] [PATCH 11/13] drm/i915: Reject commands that would store to global HWS page

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin PIPE_CONTROL and MI_FLUSH_DW have bits that would write to the hardware status page. The driver stores request tracking info there, so don't let userspace overwrite it. v2: trailing comma fix, rebased Signed-off-by: Brad Volkin --- drivers/gpu/drm/i915/i915_cmd_parser.c | 24

[Intel-gfx] [PATCH 12/13] drm/i915: Add a CMD_PARSER_VERSION getparam

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin So userspace can query the kernel for command parser support. v2: Add i915_cmd_parser_get_version(), history log, and kerneldoc OTC-Tracker: AXIA-4631 Change-Id: I58af650db9f6753c2dcac9c54ab432fd31db302f Signed-off-by: Brad Volkin --- drivers/gpu/drm/i915/i915_cmd_parser.c |

[Intel-gfx] [PATCH 08/13] drm/i915: Enable register whitelist checks

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin MI_STORE_REGISTER_MEM, MI_LOAD_REGISTER_MEM, and MI_LOAD_REGISTER_IMM commands allow userspace access to registers. Only certain registers should be allowed for such access, so enable checking for those commands. Each ring gets its own register whitelist. MI_LOAD_REGISTER_REG o

[Intel-gfx] [PATCH 01/13] drm/i915: Refactor shmem pread setup

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin The command parser is going to need the same synchronization and setup logic, so factor it out for reuse. v2: Add a check that the object is backed by shmem Signed-off-by: Brad Volkin --- drivers/gpu/drm/i915/i915_drv.h | 3 +++ drivers/gpu/drm/i915/i915_gem.c | 51

[Intel-gfx] [PATCH] intel: Merge i915_drm.h with cmd parser define

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin Signed-off-by: Brad Volkin --- include/drm/i915_drm.h | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/include/drm/i915_drm.h b/include/drm/i915_drm.h index 2f4eb8c..ba863c4 100644 --- a/include/drm/i915_drm.h +++ b/include/drm/i915_drm.h @@ -27,7 +27,7

[Intel-gfx] [PATCH 10/13] drm/i915: Enable PPGTT command parser checks

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin Various commands that access memory have a bit to determine whether the graphics address specified in the command should use the GGTT or PPGTT for translation. These checks ensure that the bit indicates PPGTT translation. Most of these checks use the existing bit-checking infra

[Intel-gfx] [PATCH 6/6] tests/gem_exec_parse: Test a command crossing a page boundary

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin This is a speculative test in that it's not particularly relevant today, but is important if we switch the parser implementation to use kmap_atomic instead of vmap. Signed-off-by: Brad Volkin --- tests/gem_exec_parse.c | 68 ++

[Intel-gfx] [PATCH 2/6] tests/gem_exec_parse: Add tests for rejected commands

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin Signed-off-by: Brad Volkin --- tests/gem_exec_parse.c | 81 ++ 1 file changed, 81 insertions(+) diff --git a/tests/gem_exec_parse.c b/tests/gem_exec_parse.c index c71e478..ebf7116 100644 --- a/tests/gem_exec_parse.c +++ b/tests/

[Intel-gfx] [PATCH 02/13] drm/i915: Implement command buffer parsing logic

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin The command parser scans batch buffers submitted via execbuffer ioctls before the driver submits them to hardware. At a high level, it looks for several things: 1) Commands which are explicitly defined as privileged or which should only be used by the kernel driver. The pars

[Intel-gfx] [PATCH 1/6] tests: Add a test for the command parser

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin Start with a simple testcase that should pass. v2: Switch to I915_PARAM_CMD_PARSER_VERSION Signed-off-by: Brad Volkin --- tests/.gitignore | 1 + tests/Makefile.sources | 1 + tests/gem_exec_parse.c | 140 + 3 files c

[Intel-gfx] [PATCH 4/6] tests/gem_exec_parse: Add tests for bitmask checks

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin Signed-off-by: Brad Volkin --- tests/gem_exec_parse.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/tests/gem_exec_parse.c b/tests/gem_exec_parse.c index 48fde25..9e90408 100644 --- a/tests/gem_exec_parse.c +++ b/tests/gem_exec_parse.c @@ -145,6 +145,

[Intel-gfx] [PATCH 03/13] drm/i915: Initial command parser table definitions

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin Add command tables defining irregular length commands for each ring. This requires a few new command opcode definitions. v2: Whitespace adjustment in command definitions, sparse fix for !F OTC-Tracker: AXIA-4631 Change-Id: I064bceb457e15f46928058352afe76d918c58ef5 Signed-off-b

[Intel-gfx] [PATCH 3/6] tests/gem_exec_parse: Add tests for register whitelist

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin Signed-off-by: Brad Volkin --- tests/gem_exec_parse.c | 26 ++ 1 file changed, 26 insertions(+) diff --git a/tests/gem_exec_parse.c b/tests/gem_exec_parse.c index ebf7116..48fde25 100644 --- a/tests/gem_exec_parse.c +++ b/tests/gem_exec_parse.c @@ -141

[Intel-gfx] [PATCH 05/13] drm/i915: Allow some privileged commands from master

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin The Intel DDX uses these to implement scanline waits in the X server. Signed-off-by: Brad Volkin --- drivers/gpu/drm/i915/i915_cmd_parser.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_cmd_parser.c b/drivers/gpu/drm/i915

[Intel-gfx] [PATCH 00/13] Gen7 batch buffer command parser

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin Certain OpenGL features (e.g. transform feedback, performance monitoring) require userspace code to submit batches containing commands such as MI_LOAD_REGISTER_IMM to access various registers. Unfortunately, some generations of the hardware will noop these commands in "unsecure"

[Intel-gfx] [PATCH 13/13] drm/i915: Enable command parsing by default

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin v2: rebased OTC-Tracker: AXIA-4631 Change-Id: I6747457e1fe7494bd42787af51198fcba398ad78 Signed-off-by: Brad Volkin --- drivers/gpu/drm/i915/i915_params.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/i915_params.c b/drivers/gpu/

[Intel-gfx] [PATCH 09/13] drm/i915: Reject commands that explicitly generate interrupts

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin The driver leaves most interrupts masked during normal operation, so there would have to be additional work to enable userspace to safely request/receive an interrupt. v2: trailing commas, rebased Signed-off-by: Brad Volkin --- drivers/gpu/drm/i915/i915_cmd_parser.c | 22 +++

[Intel-gfx] [PATCH 06/13] drm/i915: Add register whitelists for mesa

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin These registers are currently used by mesa for blitting, transform feedback extensions, and performance monitoring extensions. v2: REG64 macro Signed-off-by: Brad Volkin --- drivers/gpu/drm/i915/i915_cmd_parser.c | 45 ++ drivers/gpu/drm/i915/

[Intel-gfx] [PATCH 07/13] drm/i915: Add register whitelist for DRM master

2014-02-18 Thread bradley . d . volkin
From: Brad Volkin These are used to implement scanline waits in the X server. v2: Use #defines instead of magic numbers Signed-off-by: Brad Volkin --- drivers/gpu/drm/i915/i915_cmd_parser.c | 29 + drivers/gpu/drm/i915/i915_reg.h| 6 ++ 2 files changed

Re: [Intel-gfx] [PATCH 16/19] drm/i915: sanity check power well sw state against hw state

2014-02-18 Thread Ville Syrjälä
On Tue, Feb 18, 2014 at 07:37:01PM +0200, Imre Deak wrote: > On Tue, 2014-02-18 at 18:55 +0200, Ville Syrjälä wrote: > > On Tue, Feb 18, 2014 at 12:02:17AM +0200, Imre Deak wrote: > > > Suggested by Daniel. > > > > > > Signed-off-by: Imre Deak > > > --- > > > drivers/gpu/drm/i915/intel_pm.c | 33

Re: [Intel-gfx] [PATCH 16/19] drm/i915: sanity check power well sw state against hw state

2014-02-18 Thread Imre Deak
On Tue, 2014-02-18 at 18:55 +0200, Ville Syrjälä wrote: > On Tue, Feb 18, 2014 at 12:02:17AM +0200, Imre Deak wrote: > > Suggested by Daniel. > > > > Signed-off-by: Imre Deak > > --- > > drivers/gpu/drm/i915/intel_pm.c | 33 ++--- > > 1 file changed, 30 insertions(+),

[Intel-gfx] [PATCH] drm/i915: Fix forcewake counts for gen8

2014-02-18 Thread Mika Kuoppala
Sometimes generic driver code gets forcewake explicitly by gen6_gt_force_wake_get(), which check forcewake_count before accessing hardware. However the register access with gen8_write function access low level hw accessors directly, ignoring the forcewake_count. This leads to nested forcewake get f

Re: [Intel-gfx] [PATCH] Update intel_chipset macros

2014-02-18 Thread Santos, Joao
The idea behind this patch was indeed to standardize both libdrm's and igt's intel_chipset.h. That's sounds like a (!very) sane idea to me. I really don't mind taking that on later but right now I need to get a patch tested out of the door. Joao. -Original Message- From: Lespiau, Damie

Re: [Intel-gfx] [PATCH] build: Skip kms_plane and kms_sysfs_edid_timing on Android

2014-02-18 Thread Damien Lespiau
On Tue, Feb 18, 2014 at 04:58:58PM +, Santos, Joao wrote: > Someone asked me to put the kms_sysfs_edid_timing for the same reason, > I honestly didn't check it myself. I think we should still add > kms_plane to the skip_list because otherwise it blocks anyone who > tries to build igt tests. Y

Re: [Intel-gfx] [PATCH] build: Skip kms_plane and kms_sysfs_edid_timing on Android

2014-02-18 Thread Santos, Joao
Someone asked me to put the kms_sysfs_edid_timing for the same reason, I honestly didn't check it myself. I think we should still add kms_plane to the skip_list because otherwise it blocks anyone who tries to build igt tests. I'll send another patch if that's alright (?). Joao. -Original

Re: [Intel-gfx] [PATCH 16/19] drm/i915: sanity check power well sw state against hw state

2014-02-18 Thread Ville Syrjälä
On Tue, Feb 18, 2014 at 12:02:17AM +0200, Imre Deak wrote: > Suggested by Daniel. > > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/intel_pm.c | 33 ++--- > 1 file changed, 30 insertions(+), 3 deletions(-) > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/dr

Re: [Intel-gfx] [PATCH 13/19] drm/i915: factor out reset_vblank_counter

2014-02-18 Thread Ville Syrjälä
On Tue, Feb 18, 2014 at 12:02:14AM +0200, Imre Deak wrote: > We need to do the same for other platforms in upcoming patches. > > Signed-off-by: Imre Deak > --- > drivers/gpu/drm/i915/intel_pm.c | 14 ++ > 1 file changed, 10 insertions(+), 4 deletions(-) > > diff --git a/drivers/gpu/

Re: [Intel-gfx] [PATCH 11/19] drm/i915: vlv: keep first level vblank IRQs masked

2014-02-18 Thread Ville Syrjälä
On Tue, Feb 18, 2014 at 12:02:12AM +0200, Imre Deak wrote: > This is a left-over from > > commit b7e634cc8dcd320123199a18bae0937b40dc28b8 > Author: Imre Deak > Date: Tue Feb 4 21:35:45 2014 +0200 > > drm/i915: vlv: don't unmask IIR[DISPLAY_PIPE_A/B_VBLANK] interrupt > > where we stopped unmas

Re: [Intel-gfx] [PATCH] drm/i915: fix forcewake counts for gen8

2014-02-18 Thread Ville Syrjälä
On Tue, Feb 18, 2014 at 05:48:54PM +0200, Mika Kuoppala wrote: > Generic driver code gets forcewake explicitly by gen6_gt_force_wake_get(), > which keeps force wake counts before accessing low level fw get. > However the underlying gen8 register write function access low level > accessors directly.

[Intel-gfx] [PATCH] drm/i915: fix forcewake counts for gen8

2014-02-18 Thread Mika Kuoppala
Generic driver code gets forcewake explicitly by gen6_gt_force_wake_get(), which keeps force wake counts before accessing low level fw get. However the underlying gen8 register write function access low level accessors directly. This leads to nested fw get from hardware, causing forcewake ack clear

Re: [Intel-gfx] [PATCH v4] ACPI / video: Add systems that should favour native backlight interface

2014-02-18 Thread Mika Westerberg
On Tue, Feb 18, 2014 at 04:22:27PM +0100, Rafael J. Wysocki wrote: > On Tuesday, February 18, 2014 02:31:46 PM Takashi Iwai wrote: > > At Tue, 18 Feb 2014 12:34:42 +0200, > > Mika Westerberg wrote: > > > > > > On Tue, Feb 18, 2014 at 01:54:20PM +0800, Aaron Lu wrote: > > > > + { > > > > +

Re: [Intel-gfx] [PATCH 7/5] drm/i915: Improve gen3/4 frame counter

2014-02-18 Thread Imre Deak
On Tue, 2014-02-18 at 16:41 +0200, Ville Syrjälä wrote: > On Tue, Feb 18, 2014 at 04:16:00PM +0200, Imre Deak wrote: > > On Tue, 2014-02-18 at 14:04 +0200, ville.syrj...@linux.intel.com wrote: > > > From: Ville Syrjälä > > > > > > Currently the logic to fix up the frame counter on gen3/4 assumes

Re: [Intel-gfx] [PATCH v4] ACPI / video: Add systems that should favour native backlight interface

2014-02-18 Thread Rafael J. Wysocki
On Tuesday, February 18, 2014 02:31:46 PM Takashi Iwai wrote: > At Tue, 18 Feb 2014 12:34:42 +0200, > Mika Westerberg wrote: > > > > On Tue, Feb 18, 2014 at 01:54:20PM +0800, Aaron Lu wrote: > > > + { > > > + .callback = video_set_use_native_backlight, > > > + .ident = "HP EliteBook 2013 models",

Re: [Intel-gfx] [PATCH 7/5] drm/i915: Improve gen3/4 frame counter

2014-02-18 Thread Ville Syrjälä
On Tue, Feb 18, 2014 at 04:16:00PM +0200, Imre Deak wrote: > On Tue, 2014-02-18 at 14:04 +0200, ville.syrj...@linux.intel.com wrote: > > From: Ville Syrjälä > > > > Currently the logic to fix up the frame counter on gen3/4 assumes that > > start of vblank occurs at vblank_start*htotal pixels, whe

Re: [Intel-gfx] [PATCH] Update intel_chipset macros

2014-02-18 Thread Damien Lespiau
On Tue, Feb 18, 2014 at 01:15:12PM +, joao.san...@intel.com wrote: > From: Joao Santos > > Added in new macros to support new platforms. What's the real purpose of this patch? you're adding a bunch of defines here without any user. I'd argue that we really want to move away from those define

Re: [Intel-gfx] Need your advice: Add a new communication inteface between HD-Audio and Gfx drivers for hotplug notification/ELD update

2014-02-18 Thread Ville Syrjälä
On Tue, Feb 18, 2014 at 01:58:22PM +, Lin, Mengdong wrote: > Sorry to pick up this thread after a long time. > > > -Original Message- > > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of > > Daniel Vetter > > Sent: Thursday, January 23, 2014 4:27 PM > > To: Tak

Re: [Intel-gfx] [PATCH] build: Skip kms_plane and kms_sysfs_edid_timing on Android

2014-02-18 Thread Damien Lespiau
On Tue, Feb 18, 2014 at 01:28:54PM +, joao.san...@intel.com wrote: > From: Joao Santos > > We do not have GLib there so it does not build. > > > Signed-off-by: Joao Santos > --- > tests/Android.mk |2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/tests/Android.mk b/tests/Andro

Re: [Intel-gfx] [PATCH 7/5] drm/i915: Improve gen3/4 frame counter

2014-02-18 Thread Imre Deak
On Tue, 2014-02-18 at 14:04 +0200, ville.syrj...@linux.intel.com wrote: > From: Ville Syrjälä > > Currently the logic to fix up the frame counter on gen3/4 assumes that > start of vblank occurs at vblank_start*htotal pixels, when in fact > it occurs htotal-hsync_start pixels earlier. Apply the ap

Re: [Intel-gfx] Need your advice: Add a new communication inteface between HD-Audio and Gfx drivers for hotplug notification/ELD update

2014-02-18 Thread Lin, Mengdong
Sorry to pick up this thread after a long time. > -Original Message- > From: daniel.vet...@ffwll.ch [mailto:daniel.vet...@ffwll.ch] On Behalf Of > Daniel Vetter > Sent: Thursday, January 23, 2014 4:27 PM > To: Takashi Iwai > On Thu, Jan 23, 2014 at 8:57 AM, Takashi Iwai wrote: > >> Than

Re: [Intel-gfx] [PATCH v4] ACPI / video: Add systems that should favour native backlight interface

2014-02-18 Thread Takashi Iwai
At Tue, 18 Feb 2014 12:34:42 +0200, Mika Westerberg wrote: > > On Tue, Feb 18, 2014 at 01:54:20PM +0800, Aaron Lu wrote: > > + { > > + .callback = video_set_use_native_backlight, > > + .ident = "HP EliteBook 2013 models", > > + .matches = { > > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlet

[Intel-gfx] [PATCH] build: Skip kms_plane and kms_sysfs_edid_timing on Android

2014-02-18 Thread joao . santos
From: Joao Santos We do not have GLib there so it does not build. Signed-off-by: Joao Santos --- tests/Android.mk |2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/Android.mk b/tests/Android.mk index 30be4a6..fa01721 100644 --- a/tests/Android.mk +++ b/tests/Android.mk @@ -32,6 +3

[Intel-gfx] [PATCH] Update intel_chipset macros

2014-02-18 Thread joao . santos
From: Joao Santos Added in new macros to support new platforms. Signed-off-by: Joao Santos --- intel/intel_chipset.h | 49 +++-- 1 file changed, 43 insertions(+), 6 deletions(-) diff --git a/intel/intel_chipset.h b/intel/intel_chipset.h index e558

Re: [Intel-gfx] [PATCH 1/1] drm/i915: Enabling 128x128 and 256x256 ARGB Cursor Support

2014-02-18 Thread Ville Syrjälä
On Tue, Feb 18, 2014 at 03:39:46PM +0530, sagar.a.kam...@intel.com wrote: > From: Sagar Kamble > > With this patch we allow larger cursor planes of sizes 128x128 > and 256x256. Planning to extend kms_cursor_crc test for verifying > these larger planes. > > Cc: Daniel Vetter > Cc: Jani Nikula >

[Intel-gfx] [PATCH 7/5] drm/i915: Improve gen3/4 frame counter

2014-02-18 Thread ville . syrjala
From: Ville Syrjälä Currently the logic to fix up the frame counter on gen3/4 assumes that start of vblank occurs at vblank_start*htotal pixels, when in fact it occurs htotal-hsync_start pixels earlier. Apply the appropriate adjustment to make the frame counter more accurate. Also fix the vblank

[Intel-gfx] [PATCH 8/5] drm/i915: Fix gen2 scanline counter

2014-02-18 Thread ville . syrjala
From: Ville Syrjälä On gen2 the scanline counter behaves a bit differently from the later generations. Instead of adding one to the raw scanline counter value, we must subtract one. I've not yet verified which way gen3 works. My suspicion is that it behaves like gen4 since for the most part the

[Intel-gfx] [PATCH 9/5] drm/i915: Draw a picture about video timings

2014-02-18 Thread ville . syrjala
From: Ville Syrjälä The docs are a bit lacking when it comes to describing when certain timing related events occur in the hardware. Draw a picture which tries to capture the most important ones. Signed-off-by: Ville Syrjälä --- drivers/gpu/drm/i915/i915_irq.c | 48

[Intel-gfx] [PATCH] drm/i915: Added a new Panel-fitter property for connectors

2014-02-18 Thread akash . goel
From: Akash Goel Added a Panel-fitter enable/disable property support for the connectors. NOTE: By default, the value for the property will be disabled. Signed-off-by: G Pallavi Signed-off-by: Akash Goel --- drivers/gpu/drm/i915/i915_drv.h| 8 drivers/gpu/drm/i915/intel_drv.h

Re: [Intel-gfx] [PATCH v4] ACPI / video: Add systems that should favour native backlight interface

2014-02-18 Thread Mika Westerberg
On Tue, Feb 18, 2014 at 01:54:20PM +0800, Aaron Lu wrote: > + { > + .callback = video_set_use_native_backlight, > + .ident = "HP EliteBook 2013 models", > + .matches = { > + DMI_MATCH(DMI_SYS_VENDOR, "Hewlett-Packard"), > + DMI_MATCH(DMI_PRODUCT_NAME, "HP Eli

[Intel-gfx] [PATCH 1/1] drm/i915: Enabling 128x128 and 256x256 ARGB Cursor Support

2014-02-18 Thread sagar . a . kamble
From: Sagar Kamble With this patch we allow larger cursor planes of sizes 128x128 and 256x256. Planning to extend kms_cursor_crc test for verifying these larger planes. Cc: Daniel Vetter Cc: Jani Nikula Cc: David Airlie Cc: dri-de...@lists.freedesktop.org Cc: linux-ker...@vger.kernel.org Sign

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Add rotation support for the cursor plane

2014-02-18 Thread Sagar Arun Kamble
On Tue, 2014-02-18 at 11:23 +0200, Ville Syrjälä wrote: > On Tue, Feb 18, 2014 at 01:19:05PM +0530, Sagar Arun Kamble wrote: > > On Mon, 2014-02-17 at 19:51 +0200, Ville Syrjälä wrote: > > > On Mon, Feb 17, 2014 at 10:53:50PM +0530, Sagar Arun Kamble wrote: > > > > On Fri, 2014-02-14 at 13:39 +0200

Re: [Intel-gfx] [PATCH 4/5] drm/i915: Add rotation support for the cursor plane

2014-02-18 Thread Ville Syrjälä
On Tue, Feb 18, 2014 at 01:19:05PM +0530, Sagar Arun Kamble wrote: > On Mon, 2014-02-17 at 19:51 +0200, Ville Syrjälä wrote: > > On Mon, Feb 17, 2014 at 10:53:50PM +0530, Sagar Arun Kamble wrote: > > > On Fri, 2014-02-14 at 13:39 +0200, Ville Syrjälä wrote: > > > > On Fri, Feb 14, 2014 at 04:31:17P

Re: [Intel-gfx] [PATCH] xf86-video-intel: Unbreak build on OpenBSD

2014-02-18 Thread Chris Wilson
On Sat, Feb 15, 2014 at 09:29:42PM +0100, Mark Kettenis wrote: > Fallout from the backlight helper changes. Apologies for missing this earlier. I have rearranged the code once again to try to push the OpenBSD specifics down into src/backlight.c, can you please check what needs to be fixed up now?