Re: [Intel-gfx] [PATCH 15/17] drm/i915/bdw: collect semaphore error state

2013-12-14 Thread Ben Widawsky
On Sat, Dec 14, 2013 at 09:38:57PM +, Chris Wilson wrote: > On Sat, Dec 14, 2013 at 11:47:24AM -0800, Ben Widawsky wrote: > > On Fri, Dec 13, 2013 at 08:16:03PM -0800, Ben Widawsky wrote: > > > Since the semaphore information is in an object, just dump it, and let > > > the user parse it later.

Re: [Intel-gfx] [PATCH 09/17] drm/i915: init ring->id early

2013-12-14 Thread Ben Widawsky
On Sat, Dec 14, 2013 at 09:45:34PM +, Chris Wilson wrote: > On Fri, Dec 13, 2013 at 08:15:57PM -0800, Ben Widawsky wrote: > > Having the ring id all set up will allow us to use some macro shortcuts > > during ringbuffer init. Admittedly it leaves the code a bit confusing, > > having the initial

[Intel-gfx] [PATCH 2/5] drm/i915: parse backlight modulation frequency from the BIOS VBT

2013-12-14 Thread Rodrigo Vivi
From: Jani Nikula We don't actually do anything with the information yet, but parse and log what's in the VBT. Signed-off-by: Jani Nikula Signed-off-by: Rodrigo Vivi Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.h | 5 + drivers/gpu/drm/i915/intel_bios.c | 29 +++

[Intel-gfx] [PATCH 0/5] drm-intel-collector - update

2013-12-14 Thread Rodrigo Vivi
This is another drm-intel-collector updated notice: http://cgit.freedesktop.org/~vivijim/drm-intel/log/?h=drm-intel-collector Here goes the update list in order for better reviewers assignment: Patch drm/i915: Asynchronously perform the set-base for a simple modeset - Reviewed Patch drm

[Intel-gfx] [PATCH 4/5] drm/i915: vlv: W/a for hotplug/manual VGA detection

2013-12-14 Thread Rodrigo Vivi
From: Imre Deak At least on my VLV stepping VGA detection doesn't work in certain cases. One such case is when all pipes are off and VGA is plugged in. Another case reported by Joonas Lahtinen (also on the same stepping) is booting with VGA disconnected where we incorrectly report that VGA is con

[Intel-gfx] [PATCH 3/5] drm/i915: i830M has watermarks like i855

2013-12-14 Thread Rodrigo Vivi
From: Daniel Vetter So shuffle the checks around a bit. Also give all the structs and functions proper prefixes: i830_ for the dual-pipe mobile platforms and i845_ for the two single-pipe desktop platforms. Note that the max fifo value isn't actually correct for the i830M, but since we don't fro

[Intel-gfx] [PATCH 1/5] drm/i915: Asynchronously perform the set-base for a simple modeset

2013-12-14 Thread Rodrigo Vivi
From: Chris Wilson A simple modeset, where we only wish to switch over to a new framebuffer such as the transition from fbcon to X, takes around 30-60ms. This is due to three factors: 1. We need to make sure the fb->obj is in the display domain, which incurs a cache flush to ensure no dirt is le

[Intel-gfx] [PATCH 5/5] drm/i915: Only use read-back pipe config

2013-12-14 Thread Rodrigo Vivi
From: Daniel Vetter This way we'll catch bugs in our code where we depend upon pipe config state not (yet) read out much quicker, through a simple dpms on/off cycle. This will blow up all over the place for now, hence just a quick idea to toss out there. Signed-off-by: Daniel Vetter Signed-off

Re: [Intel-gfx] [PATCH 09/17] drm/i915: init ring->id early

2013-12-14 Thread Chris Wilson
On Fri, Dec 13, 2013 at 08:15:57PM -0800, Ben Widawsky wrote: > Having the ring id all set up will allow us to use some macro shortcuts > during ringbuffer init. Admittedly it leaves the code a bit confusing, > having the initialization of the id member in a separate place - but I > think the savin

Re: [Intel-gfx] [PATCH 15/17] drm/i915/bdw: collect semaphore error state

2013-12-14 Thread Chris Wilson
On Sat, Dec 14, 2013 at 11:47:24AM -0800, Ben Widawsky wrote: > On Fri, Dec 13, 2013 at 08:16:03PM -0800, Ben Widawsky wrote: > > Since the semaphore information is in an object, just dump it, and let > > the user parse it later. > > > > NOTE: The page being used for the semaphores are incoherent

Re: [Intel-gfx] [PATCH 00/17] Broadwell HW semaphores

2013-12-14 Thread Ben Widawsky
On Sat, Dec 14, 2013 at 09:16:51PM +, Chris Wilson wrote: > On Sat, Dec 14, 2013 at 11:39:27AM -0800, Ben Widawsky wrote: > > > > On Sat, Dec 14, 2013 at 09:08:47AM +, Chris Wilson wrote: > > > On Fri, Dec 13, 2013 at 08:15:48PM -0800, Ben Widawsky wrote: > > > > Ben Widawsky (17): > > > >

Re: [Intel-gfx] [PATCH 00/17] Broadwell HW semaphores

2013-12-14 Thread Chris Wilson
On Sat, Dec 14, 2013 at 11:39:27AM -0800, Ben Widawsky wrote: > > On Sat, Dec 14, 2013 at 09:08:47AM +, Chris Wilson wrote: > > On Fri, Dec 13, 2013 at 08:15:48PM -0800, Ben Widawsky wrote: > > > Ben Widawsky (17): > > > drm/i915: Reorder/respace MI instruction definition > > > drm/i915: D

Re: [Intel-gfx] [PATCH 15/17] drm/i915/bdw: collect semaphore error state

2013-12-14 Thread Ben Widawsky
On Fri, Dec 13, 2013 at 08:16:03PM -0800, Ben Widawsky wrote: > Since the semaphore information is in an object, just dump it, and let > the user parse it later. > > NOTE: The page being used for the semaphores are incoherent with the > CPU. No matter what I do, I cannot figure out a way to read a

Re: [Intel-gfx] [PATCH 00/17] Broadwell HW semaphores

2013-12-14 Thread Ben Widawsky
On Sat, Dec 14, 2013 at 09:08:47AM +, Chris Wilson wrote: > On Fri, Dec 13, 2013 at 08:15:48PM -0800, Ben Widawsky wrote: > > Ben Widawsky (17): > > drm/i915: Reorder/respace MI instruction definition > > drm/i915: Don't emit mbox updates without semaphores > > drm/i915: Move semaphore sp

[Intel-gfx] [PATCH 05/17] [v2] drm/i915: Move ring_begin to signal()

2013-12-14 Thread Ben Widawsky
Add_request has always contained both the semaphore mailbox updates as well as the breadcrumb writes. Since the semaphore signal is the one which actually knows about the number of dwords it needs to emit to the ring, we move the ring_begin to that function. This allows us to remove the hideously s

Re: [Intel-gfx] [PATCH 05/17] drm/i915: Move ring_begin to signal()

2013-12-14 Thread Ben Widawsky
On Sat, Dec 14, 2013 at 09:05:03AM +, Chris Wilson wrote: > On Fri, Dec 13, 2013 at 08:15:53PM -0800, Ben Widawsky wrote: > > Add_request has always contained both the semaphore mailbox updates as > > well as the breadcrumb writes. Since the semaphore signal is the one > > which actually knows

Re: [Intel-gfx] [PATCH 2/3] drm/i915: release the GTT mmaps when going into D3

2013-12-14 Thread Daniel Vetter
On Fri, Dec 13, 2013 at 04:22:40PM -0200, Rodrigo Vivi wrote: > When I saw this I was afraid this force could break userspace somehow, > but Paulo explained me the release with pagefault mechanism. Thanks Paulo. > > Reviewed-by: Rodrigo Vivi Merged all three patches with the small changes added

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v7

2013-12-14 Thread Daniel Vetter
On Sat, Dec 14, 2013 at 12:13:45PM +0100, Daniel Vetter wrote: > On Thu, Dec 12, 2013 at 12:41:54PM -0800, Jesse Barnes wrote: > > + ifbdev->helper.funcs->initial_config = intel_fb_initial_config; > > This here is a bit surprising - my model of operation here presumed that > if we correctly assi

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v7

2013-12-14 Thread Daniel Vetter
On Sat, Dec 14, 2013 at 11:44:06AM +0100, Daniel Vetter wrote: > On Fri, Dec 13, 2013 at 04:43:50PM -0800, Jesse Barnes wrote: > > This is just fixing up existing code to use the new field name, so no > > functional change. I see what you mean about splitting out the field > > change, but now that

Re: [Intel-gfx] [PATCH 4/6] drm/i915: don't memset the fb buffer if preallocated

2013-12-14 Thread Daniel Vetter
On Thu, Dec 12, 2013 at 12:41:55PM -0800, Jesse Barnes wrote: > We want to preserve the BIOS/bootloader contents for later. > > Signed-off-by: Jesse Barnes > --- > drivers/gpu/drm/i915/intel_fbdev.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/drivers/gpu/drm/i915

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v7

2013-12-14 Thread Daniel Vetter
On Thu, Dec 12, 2013 at 12:41:54PM -0800, Jesse Barnes wrote: > Retrieve current framebuffer config info from the regs and create an fb > object for the buffer the BIOS or boot loader left us. This should > allow for smooth transitions to userspace apps once we finish the > initial configuration c

Re: [Intel-gfx] [PATCH 2/6] drm/i915: retrieve current fb config into new plane_config structure at init

2013-12-14 Thread Daniel Vetter
On Thu, Dec 12, 2013 at 12:41:53PM -0800, Jesse Barnes wrote: > Read out the current plane configuration at init time into a new > plane_config structure. This allows us to track any existing > framebuffers attached to the plane and potentially re-use them in our > fbdev code for a smooth handoff.

Re: [Intel-gfx] [PATCH 5/6] drm/i915/vlv: move DPIO init earlier v2

2013-12-14 Thread Daniel Vetter
On Thu, Dec 12, 2013 at 12:41:56PM -0800, Jesse Barnes wrote: > It's needed for early mode state readout, which is in turn needed to > inherit the BIOS config. So split out the reset, which we need on > resume too, from the DPIO reg init, and do the latter earlier. > > v2: split reset and reg ini

Re: [Intel-gfx] [PATCH 3/6] drm/i915: Wrap the preallocated BIOS framebuffer and preserve for KMS fbcon v7

2013-12-14 Thread Daniel Vetter
On Fri, Dec 13, 2013 at 04:43:50PM -0800, Jesse Barnes wrote: > On Fri, 13 Dec 2013 21:47:45 +0100 > Daniel Vetter wrote: > > > On Fri, Dec 13, 2013 at 8:09 PM, Jesse Barnes > > wrote: > > > On Thu, 12 Dec 2013 23:54:37 +0100 > > > Daniel Vetter wrote: > > > > > >> > @@ -258,8 +357,102 @@ stat

Re: [Intel-gfx] [PATCH 00/17] Broadwell HW semaphores

2013-12-14 Thread Chris Wilson
On Fri, Dec 13, 2013 at 08:15:48PM -0800, Ben Widawsky wrote: > Ben Widawsky (17): > drm/i915: Reorder/respace MI instruction definition > drm/i915: Don't emit mbox updates without semaphores > drm/i915: Move semaphore specific ring members to struct > drm/i915: Virtualize the ringbuffer si

Re: [Intel-gfx] [PATCH 05/17] drm/i915: Move ring_begin to signal()

2013-12-14 Thread Chris Wilson
On Fri, Dec 13, 2013 at 08:15:53PM -0800, Ben Widawsky wrote: > Add_request has always contained both the semaphore mailbox updates as > well as the breadcrumb writes. Since the semaphore signal is the one > which actually knows about the number of dwords it needs to emit to the > ring, we move the