[Intel-gfx] [PATCH 5/5] tests/gem_disable_prefault: add pread slow path subtest

2013-07-18 Thread Xiong Zhang
First disable prefault, then map src bo to gtt map, so pread from dst bo to src bo, it will run pread_slow path, finally enable prefault Signed-off-by: Xiong Zhang --- tests/gem_disable_prefault.c | 42 ++ 1 file changed, 42 insertions(+) diff --git a/tes

[Intel-gfx] [PATCH 3/5] tests/gem_disable_prefault: add reloc slow path subtest

2013-07-18 Thread Xiong Zhang
first disable prefault, then put relocate bo in gtt space and exec cmd, so it will run relocate_object_slow path, finally enable prefault Signed-off-by: Xiong Zhang --- tests/Makefile.am| 1 + tests/gem_disable_prefault.c | 168 +++ 2 files c

[Intel-gfx] [PATCH 4/5] tests/gem_disable_prefault: add pwrite slow path subtest

2013-07-18 Thread Xiong Zhang
First disable prefault, then map src bo to gtt space, so when write src bo to dst bo, it will run into pwrite_slow path. Finally enable prefault Signed-off-by: Xiong Zhang --- tests/gem_disable_prefault.c | 43 +++ 1 file changed, 43 insertions(+) diff --

[Intel-gfx] [PATCH 2/5] lib/drmtest: move gem_linear_blt() to drm_test.c

2013-07-18 Thread Xiong Zhang
Several test functions will call gem_linear_blt(), so move this function to drm_test.c. Signed-off-by: Xiong Zhang --- lib/drmtest.c | 75 lib/drmtest.h | 5 +++ tests/gem_exec_blt.c| 84 +--

[Intel-gfx] [PATCH 1/5] lib/drmtest: add drmtest_disable/enable_prefault() function

2013-07-18 Thread Xiong Zhang
Signed-off-by: Xiong Zhang --- lib/drmtest.c | 43 +++ lib/drmtest.h | 3 +++ 2 files changed, 46 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index 011d8c1..713c5ff 100644 --- a/lib/drmtest.c +++ b/lib/drmtest.c @@ -1593,3 +1593,46 @@ void km

[Intel-gfx] [PATCH 2/3] drm/i915: add debug info in slow path

2013-07-18 Thread Xiong Zhang
Signed-off-by: Xiong Zhang --- drivers/gpu/drm/i915/i915_gem.c| 4 drivers/gpu/drm/i915/i915_gem_execbuffer.c | 1 + 2 files changed, 5 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index de59154..f194d7e 100644 --- a/drivers/gpu/dr

[Intel-gfx] [PATCH 3/3] drm/i915: run shmem_pread_fast() after page fault

2013-07-18 Thread Xiong Zhang
fault_in_multipages_writeable() will load fault page into physical memory, then pread can run fast path, no need to run slow path Signed-off-by: Xiong Zhang --- drivers/gpu/drm/i915/i915_gem.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/dr

[Intel-gfx] [PATCH 1/3] drm/i915: add prefault_disable module option

2013-07-18 Thread Xiong Zhang
prefault is stll enabled by default which prevent most of pwrite/pread/reloc from running slow path, in order to verify these slow pathes, prefault need to be disabled. Signed-off-by: Xiong Zhang --- drivers/gpu/drm/i915/i915_drv.c| 5 + drivers/gpu/drm/i915/i915_drv.h

[Intel-gfx] [patch 2/2] drm/i915: use after free on error path

2013-07-18 Thread Dan Carpenter
i915_gem_vma_destroy() frees its argument so we have to move the drm_mm_remove_node() call up a few lines. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 9a9a77a..f347ad5 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers

[Intel-gfx] [patch 1/2] drm/i915: checking for NULL instead of IS_ERR()

2013-07-18 Thread Dan Carpenter
i915_gem_vma_create() returns and ERR_PTR() or a valid pointer, it never returns NULL. Signed-off-by: Dan Carpenter diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c index 40c2fc6..9a9a77a 100644 --- a/drivers/gpu/drm/i915/i915_gem.c +++ b/drivers/gpu/drm/i915/i915_g

[Intel-gfx] [PATCH 2/3] drm/i915: Change uevent for reset completion

2013-07-18 Thread Ben Widawsky
Prior to this patch, we used ERROR=0 as a way of signifying the reset was complete. The functionality dates back quite a ways to: commit f316a42cc49eca73b33d85feb6177e32431747ff Author: Ben Gamari Date: Mon Sep 14 17:48:46 2009 -0400 drm/i915: Hookup chip reset in error handler I'm not re

[Intel-gfx] [PATCH 3/3] [v2] drm/i915: Make i915 events part of uapi

2013-07-18 Thread Ben Widawsky
Make the uevent strings part of the user API for people who wish to write their own listeners. v2: Make a space in the string concatenation. (Chad) Use the "UEVENT" suffix intead of "EVENT" (Chad) Make kernel-doc (Daniel) Thanks to Daniel Vetter for a majority of the parity error comments. CC: C

[Intel-gfx] [PATCH 1/3] drm/i915: Move error uevent to detection time

2013-07-18 Thread Ben Widawsky
We've recently deferred error handling with a workqueue for a number of reasons. However, when we're trying to pass the information to userspace, it's likely more interesting to know when the error was detected by the kernel, and not when we eventually get around to handling it in the workqueue. T

Re: [Intel-gfx] [PATCH 6/7] drm/i915: add functions to disable and restore LCPLL

2013-07-18 Thread Ben Widawsky
On Thu, Jul 18, 2013 at 04:26:42PM -0700, Ben Widawsky wrote: > On Fri, Jul 12, 2013 at 02:19:41PM -0300, Paulo Zanoni wrote: > > From: Paulo Zanoni > > > > For now there are no callers, but these functions are going to be > > needed for the code that allows Package C8+. Other future features may

Re: [Intel-gfx] [PATCH 0/7] HSW/LPT clocking code additional sequences

2013-07-18 Thread Ben Widawsky
On Fri, Jul 12, 2013 at 02:19:35PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Hi > > On the code that allows Package C8+ we need to disable/reenable the PCH > reference clocks and also disable/reenable LCPLL. This series implements the > sequences that are going to be needed. I have loc

Re: [Intel-gfx] [PATCH 7/7] drm/i915: add some assertions to hsw_disable_lcpll

2013-07-18 Thread Ben Widawsky
On Fri, Jul 12, 2013 at 02:19:42PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Most of the hardware needs to be disabled before LCPLL is disabled, so > let's add a function to assert some of items listed in the "Display > Sequences for LCPLL disabling" documentation. > > The idea is that

Re: [Intel-gfx] [PATCH 6/7] drm/i915: add functions to disable and restore LCPLL

2013-07-18 Thread Ben Widawsky
On Fri, Jul 12, 2013 at 02:19:41PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > For now there are no callers, but these functions are going to be > needed for the code that allows Package C8+. Other future features may > also require this code. > The thing that's missing from the patches

Re: [Intel-gfx] [PATCH 5/7] drm/i915: disable CLKOUT_DP when it's not needed

2013-07-18 Thread Ben Widawsky
On Fri, Jul 12, 2013 at 02:19:40PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > We currently don't support HDMI clock bending nor use SSC for DP or > HDMI on Haswell, so the only case where we need CLKOUT_DP is for VGA. > > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/intel_

Re: [Intel-gfx] [PATCH 4/7] drm/i915: extend lpt_enable_clkout_dp

2013-07-18 Thread Ben Widawsky
On Fri, Jul 12, 2013 at 02:19:39PM -0300, Paulo Zanoni wrote: > From: Paulo Zanoni > > Now it implements 3 different sequences from BSpec and also has > support for ULT. > > Signed-off-by: Paulo Zanoni > --- > drivers/gpu/drm/i915/i915_reg.h | 2 ++ > drivers/gpu/drm/i915/intel_display.c

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file

2013-07-18 Thread Daniel Vetter
On Thu, Jul 18, 2013 at 7:44 PM, Chris Wilson wrote: > On Thu, Jul 18, 2013 at 05:53:52PM +0200, Daniel Vetter wrote: >> My plan was kinda to apply the first 4 patches to -fixes since they're the >> more correct solution and we're fairly early, and only backport the >> minimal change. But if you t

Re: [Intel-gfx] [PATCH 2/8] lib: Introduce drmtest_skip_on_simulation()

2013-07-18 Thread Daniel Vetter
On Thu, Jul 18, 2013 at 05:55:00PM +0100, Damien Lespiau wrote: > On Thu, Jul 18, 2013 at 09:31:15AM -0700, Ben Widawsky wrote: > > On Thu, Jul 18, 2013 at 09:18:34AM -0700, Jesse Barnes wrote: > > > On Thu, 18 Jul 2013 16:19:07 +0100 > > > Damien Lespiau wrote: > > > > > > > This will allow us t

[Intel-gfx] [PATCH 6/7] drm/i915: add functions to disable and restore LCPLL

2013-07-18 Thread Paulo Zanoni
From: Paulo Zanoni For now there are no callers, but these functions are going to be needed for the code that allows Package C8+. Other future features may also require this code. v2: - Rebase. - Fix D_COMP wait timeout. Signed-off-by: Paulo Zanoni --- drivers/gpu/drm/i915/i915_reg.h

[Intel-gfx] [PATCH 2/7] drm/i915: extract FDI mPHY functions from lpt_init_pch_refclk

2013-07-18 Thread Paulo Zanoni
From: Paulo Zanoni Because lpt_init_pch_refclk implements the "Sequence to enable CLKOUT_DP for FDI usage and configure PCH FDI I/O", which is very similar to "Sequence to enable CLKOUT_DP" and "Sequence to enable CLKOUT_DP without spread". With the extracted functions we can more easily implemen

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file

2013-07-18 Thread Chris Wilson
On Thu, Jul 18, 2013 at 05:53:52PM +0200, Daniel Vetter wrote: > My plan was kinda to apply the first 4 patches to -fixes since they're the > more correct solution and we're fairly early, and only backport the > minimal change. But if you think it's better to put the entire series into > dinq and o

Re: [Intel-gfx] [PATCH 2/8] lib: Introduce drmtest_skip_on_simulation()

2013-07-18 Thread Jesse Barnes
On Thu, 18 Jul 2013 17:55:00 +0100 Damien Lespiau wrote: > On Thu, Jul 18, 2013 at 09:31:15AM -0700, Ben Widawsky wrote: > > On Thu, Jul 18, 2013 at 09:18:34AM -0700, Jesse Barnes wrote: > > > On Thu, 18 Jul 2013 16:19:07 +0100 > > > Damien Lespiau wrote: > > > > > > > This will allow us to exp

Re: [Intel-gfx] [PATCH 2/8] lib: Introduce drmtest_skip_on_simulation()

2013-07-18 Thread Damien Lespiau
On Thu, Jul 18, 2013 at 09:31:15AM -0700, Ben Widawsky wrote: > On Thu, Jul 18, 2013 at 09:18:34AM -0700, Jesse Barnes wrote: > > On Thu, 18 Jul 2013 16:19:07 +0100 > > Damien Lespiau wrote: > > > > > This will allow us to explicitely blacklist tests we don't want to run > > > on simulation. > >

Re: [Intel-gfx] [PATCH 2/8] lib: Introduce drmtest_skip_on_simulation()

2013-07-18 Thread Daniel Vetter
On Thu, Jul 18, 2013 at 09:18:34AM -0700, Jesse Barnes wrote: > On Thu, 18 Jul 2013 16:19:07 +0100 > Damien Lespiau wrote: > > > This will allow us to explicitely blacklist tests we don't want to run > > on simulation. > > So FWIW I'll reiterate that I'd prefer to manage this in either the > Mak

Re: [Intel-gfx] [PATCH] drm/i915: Extend i915_powersave parameter.

2013-07-18 Thread Rodrigo Vivi
On Wed, Jul 17, 2013 at 6:30 PM, Daniel Vetter wrote: > On Wed, Jul 17, 2013 at 11:23 PM, Rodrigo Vivi wrote: My opinion is that we respect the specific module parameters, and if they are left to default values, then apply the global powersave parameter. If that too is default, the

Re: [Intel-gfx] [PATCH 06/11] drm/i915: Match all PSR mode entry conditions before enabling it.

2013-07-18 Thread Daniel Vetter
On Thu, Jul 18, 2013 at 6:36 PM, Rodrigo Vivi wrote: > On Thu, Jul 18, 2013 at 5:02 AM, Daniel Vetter wrote: >> On Mon, Jul 15, 2013 at 03:06:22PM +0100, Chris Wilson wrote: >>> On Thu, Jul 11, 2013 at 06:45:00PM -0300, Rodrigo Vivi wrote: >>> > v2: Prefer seq_puts to seq_printf by Paulo Zanoni.

Re: [Intel-gfx] [PATCH 06/11] drm/i915: Match all PSR mode entry conditions before enabling it.

2013-07-18 Thread Rodrigo Vivi
On Thu, Jul 18, 2013 at 5:02 AM, Daniel Vetter wrote: > On Mon, Jul 15, 2013 at 03:06:22PM +0100, Chris Wilson wrote: >> On Thu, Jul 11, 2013 at 06:45:00PM -0300, Rodrigo Vivi wrote: >> > v2: Prefer seq_puts to seq_printf by Paulo Zanoni. >> > v3: small changes like avoiding calling dp_to_dig_port

Re: [Intel-gfx] [PATCH 2/8] lib: Introduce drmtest_skip_on_simulation()

2013-07-18 Thread Ben Widawsky
On Thu, Jul 18, 2013 at 09:18:34AM -0700, Jesse Barnes wrote: > On Thu, 18 Jul 2013 16:19:07 +0100 > Damien Lespiau wrote: > > > This will allow us to explicitely blacklist tests we don't want to run > > on simulation. I agree with Jesse on this. Mostly what I've wanted is an "opt-in" approach a

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-18 Thread Rodrigo Vivi
On Thu, Jul 18, 2013 at 5:24 AM, Daniel Vetter wrote: > On Wed, Jul 17, 2013 at 10:08:34PM +0100, Chris Wilson wrote: >> On Wed, Jul 17, 2013 at 06:01:03PM -0300, Rodrigo Vivi wrote: >> > On Wed, Jul 17, 2013 at 5:18 PM, Chris Wilson >> > wrote: >> > > On Wed, Jul 17, 2013 at 02:46:52PM -0300, R

Re: [Intel-gfx] [PATCH] drm/i915: Add functions to force psr exit

2013-07-18 Thread Rodrigo Vivi
On Thu, Jul 18, 2013 at 5:33 AM, Daniel Vetter wrote: > On Mon, Jul 15, 2013 at 05:29:15PM -0300, Rodrigo Vivi wrote: >> PSR tracking engine in HSW doesn't detect automagically some directly copy >> area >> operations through scanout so we will have to kick it manually and >> reschedule it to com

Re: [Intel-gfx] [PATCH 2/8] lib: Introduce drmtest_skip_on_simulation()

2013-07-18 Thread Jesse Barnes
On Thu, 18 Jul 2013 16:19:07 +0100 Damien Lespiau wrote: > This will allow us to explicitely blacklist tests we don't want to run > on simulation. So FWIW I'll reiterate that I'd prefer to manage this in either the Makefile target for the tests (e.g. have a single_kernel_sim_tests or somesuch),

Re: [Intel-gfx] [PATCH 11/11] drm/i915: Hook PSR functionality

2013-07-18 Thread Rodrigo Vivi
On Thu, Jul 18, 2013 at 6:54 AM, Daniel Vetter wrote: > On Thu, Jul 11, 2013 at 06:45:05PM -0300, Rodrigo Vivi wrote: >> PSR must be enabled after transcoder and port are running. >> And it is only available for HSW. >> >> v2: move enable/disable to intel_ddi >> v3: The spec suggests PSR should be

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file

2013-07-18 Thread Daniel Vetter
On Thu, Jul 18, 2013 at 01:29:58PM +0100, Chris Wilson wrote: > On Thu, Jul 18, 2013 at 02:15:59PM +0200, Daniel Vetter wrote: > > On Tue, Jul 16, 2013 at 08:02:11PM +0100, Chris Wilson wrote: > > > Currently, the register access code is split between i915_drv.c and > > > intel_pm.c. It only bares

Re: [Intel-gfx] Provide a simulation friendly test environment v4

2013-07-18 Thread Daniel Vetter
On Thu, Jul 18, 2013 at 04:19:05PM +0100, Damien Lespiau wrote: > It was high time to follow up on: > http://lists.freedesktop.org/archives/intel-gfx/2013-April/027361.html > > Changes from v2: > • Take into account Daniel's comments and add the tests he listed > • Actually runs on simulatio

[Intel-gfx] [PATCH 6/8] tests: Instrument gem_lut_handle for simulation

2013-07-18 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- tests/gem_lut_handle.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/gem_lut_handle.c b/tests/gem_lut_handle.c index fdd2ab8..f3e5734 100644 --- a/tests/gem_lut_handle.c +++ b/tests/gem_lut_handle.c @@ -183,8 +183,6 @@ int main(int

[Intel-gfx] [PATCH 3/8] lib: Remove old dead code intel_batchbuffer_emit_mi_flush()

2013-07-18 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- lib/intel_batchbuffer.c | 7 --- lib/intel_batchbuffer.h | 3 --- 2 files changed, 10 deletions(-) diff --git a/lib/intel_batchbuffer.c b/lib/intel_batchbuffer.c index 724e23d..c6c8153 100644 --- a/lib/intel_batchbuffer.c +++ b/lib/intel_batchbuffer.c @@ -23

[Intel-gfx] [PATCH 8/8] tests: Add some tiled tests to the runs on simulation

2013-07-18 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- tests/gem_tiled_pread.c| 2 -- tests/gem_tiled_pread_pwrite.c | 4 +--- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/tests/gem_tiled_pread.c b/tests/gem_tiled_pread.c index 779f66f..189affc 100644 --- a/tests/gem_tiled_pread.c +++ b/tests

[Intel-gfx] [PATCH 7/8] tests: Instrument gem_seqno_wrap to run in simulation

2013-07-18 Thread Damien Lespiau
Signed-off-by: Damien Lespiau --- tests/gem_seqno_wrap.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/tests/gem_seqno_wrap.c b/tests/gem_seqno_wrap.c index f354a52..8d94858 100644 --- a/tests/gem_seqno_wrap.c +++ b/tests/gem_seqno_wrap.c @@ -577,7 +577,7 @@ static void p

[Intel-gfx] [PATCH 5/8] tests: Instrument tests run in simulation to run quickly

2013-07-18 Thread Damien Lespiau
We tweak the tests marked as runnable in simulation to run more quickly, more often then not at the expense of stress testing (which is of an arguable interest for the initial bring up in simulation). Hopefully the values chosen still test something, which is not always straightforward. It does ru

[Intel-gfx] [PATCH 4/8] tests: Black list tests we don't want to run on simulation

2013-07-18 Thread Damien Lespiau
Let's start by a small set of tests, to eventually consider running more. The current list should then be: gem_mmap gem_pread_after_blit gem_ring_sync_loop gem_ctx_basic gem_pipe_control_store_loop gem_storedw_loop_render gem_storedw_loop_blt gem_storedw_loop_bsd gem_render_linear_blits gem_tiled

[Intel-gfx] [PATCH 2/8] lib: Introduce drmtest_skip_on_simulation()

2013-07-18 Thread Damien Lespiau
This will allow us to explicitely blacklist tests we don't want to run on simulation. Signed-off-by: Damien Lespiau --- lib/drmtest.c | 12 lib/drmtest.h | 1 + 2 files changed, 13 insertions(+) diff --git a/lib/drmtest.c b/lib/drmtest.c index 76c84b1..a9a7498 100644 --- a/lib/drm

[Intel-gfx] [PATCH 1/8] lib: Rename IGT_QUICK to INTEL_SIMULATION

2013-07-18 Thread Damien Lespiau
It's more accurate this way as the quick mode is really useful for in the simulation environment. v2: Use the INTEL_ prefix to have a chance to share the same environment variable as piglit OpenGL tests Signed-off-by: Damien Lespiau --- lib/drmtest.c | 10 +- lib/drmtest.h | 4 ++--

[Intel-gfx] Provide a simulation friendly test environment v4

2013-07-18 Thread Damien Lespiau
It was high time to follow up on: http://lists.freedesktop.org/archives/intel-gfx/2013-April/027361.html Changes from v2: • Take into account Daniel's comments and add the tests he listed • Actually runs on simulation now -- Damien ___ Intel-gfx

Re: [Intel-gfx] [drm-intel:drm-intel-fixes 52/52] ERROR: Unrecognized email address: 'stable.]'

2013-07-18 Thread Fengguang Wu
Joe, > (It would have been nice to get the content that failes > instead of having to pull the tree) Good suggestion! I'll attach the git-format-patch result in the checkpatch.pl reports in future. Thanks, Fengguang ___ Intel-gfx mailing list Intel-gf

[Intel-gfx] [PATCH] drm/i915: restore debug message lost in merge resolution

2013-07-18 Thread Imre Deak
Restore debug message lost in merge commit e1b73cba13. Also clarify it that we are only clamping bpp not overwriting it. Signed-off-by: Imre Deak --- drivers/gpu/drm/i915/intel_dp.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/

[Intel-gfx] [PATCH] drm/i915: make i915_get_extra_instdone() static

2013-07-18 Thread Mika Kuoppala
commit 84734a049d0ef2f6f5fb0a1fe060cd51480dd855 Author: Mika Kuoppala Date: Fri Jul 12 16:50:57 2013 +0300 drm/i915: move error state to own compilation unit had to export i915_get_extra_instdone() as it was used also in i915_irq.c. Daniel Vetter noticed that as i915_capture_error_state()

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file

2013-07-18 Thread Chris Wilson
On Thu, Jul 18, 2013 at 02:15:59PM +0200, Daniel Vetter wrote: > On Tue, Jul 16, 2013 at 08:02:11PM +0100, Chris Wilson wrote: > > Currently, the register access code is split between i915_drv.c and > > intel_pm.c. It only bares a superficial resemblance to the reset of the > > powermanagement code

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file

2013-07-18 Thread Chris Wilson
On Thu, Jul 18, 2013 at 02:18:19PM +0200, Daniel Vetter wrote: > On Thu, Jul 18, 2013 at 02:15:59PM +0200, Daniel Vetter wrote: > > On Tue, Jul 16, 2013 at 08:02:11PM +0100, Chris Wilson wrote: > > > Currently, the register access code is split between i915_drv.c and > > > intel_pm.c. It only bares

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file

2013-07-18 Thread Daniel Vetter
On Thu, Jul 18, 2013 at 02:15:59PM +0200, Daniel Vetter wrote: > On Tue, Jul 16, 2013 at 08:02:11PM +0100, Chris Wilson wrote: > > Currently, the register access code is split between i915_drv.c and > > intel_pm.c. It only bares a superficial resemblance to the reset of the > > powermanagement code

Re: [Intel-gfx] [PATCH 1/6] drm/i915: Colocate all GT access routines in the same file

2013-07-18 Thread Daniel Vetter
On Tue, Jul 16, 2013 at 08:02:11PM +0100, Chris Wilson wrote: > Currently, the register access code is split between i915_drv.c and > intel_pm.c. It only bares a superficial resemblance to the reset of the > powermanagement code, so move it all into its own file. This is to ease > further patches t

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Create VMAs

2013-07-18 Thread Imre Deak
On Wed, 2013-07-17 at 12:19 -0700, Ben Widawsky wrote: > Formerly: "drm/i915: Create VMAs (part 1)" > > In a previous patch, the notion of a VM was introduced. A VMA describes > an area of part of the VM address space. A VMA is similar to the concept > in the linux mm. However, instead of represen

[Intel-gfx] [PULL] drm-intel-next for 3.12

2013-07-18 Thread Daniel Vetter
Hi Dave, I know you usually don't open -next this early, but since this here contains a few changes to drm_mm I've figured I should unblock David Herrmann. Highlights: - follow-up refactoring after the shared dpll rework that landed in 3.11 - oddball prep cleanups from Ben for ppgtt - encoder->get

Re: [Intel-gfx] [PATCH] drm/i915: correctly restore fences with objects attached

2013-07-18 Thread Daniel Vetter
On Wed, Jul 17, 2013 at 03:44:16PM +0100, Chris Wilson wrote: > On Wed, Jul 17, 2013 at 02:51:28PM +0200, Daniel Vetter wrote: > > To avoid stalls we delay tiling changes and especially hold of > > committing the new fence state for as long as possible. > > Synchronization points are in the execbuf

Re: [Intel-gfx] [PATCH 11/11] drm/i915: Hook PSR functionality

2013-07-18 Thread Daniel Vetter
On Thu, Jul 11, 2013 at 06:45:05PM -0300, Rodrigo Vivi wrote: > PSR must be enabled after transcoder and port are running. > And it is only available for HSW. > > v2: move enable/disable to intel_ddi > v3: The spec suggests PSR should be disabled even before backlight (by > pzanoni) > v4: also di

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-18 Thread Takashi Iwai
At Thu, 18 Jul 2013 09:23:57 +, Wang, Xingchao wrote: > > > > > -Original Message- > > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel > > Vetter > > Sent: Thursday, July 18, 2013 2:44 PM > > To: Wang, Xingchao > > Cc: Paulo Zanoni; daniel.vet...@ffwll.ch; al

Re: [Intel-gfx] [alsa-devel] [PATCH 0/4 V7] Power-well API implementation for Haswell

2013-07-18 Thread Wang, Xingchao
> -Original Message- > From: Daniel Vetter [mailto:daniel.vet...@ffwll.ch] On Behalf Of Daniel Vetter > Sent: Thursday, July 18, 2013 2:44 PM > To: Wang, Xingchao > Cc: Paulo Zanoni; daniel.vet...@ffwll.ch; alsa-de...@alsa-project.org; Daniel > Vetter; intel-gfx@lists.freedesktop.org; Wan

Re: [Intel-gfx] [PATCH] drm/i915: Add functions to force psr exit

2013-07-18 Thread Daniel Vetter
On Mon, Jul 15, 2013 at 05:29:15PM -0300, Rodrigo Vivi wrote: > PSR tracking engine in HSW doesn't detect automagically some directly copy > area > operations through scanout so we will have to kick it manually and > reschedule it to come back to normal operation as soon as possible. > > v2: Befo

Re: [Intel-gfx] [PATCH 09/11] drm/i915: Adding global I915_PARAM for PSR ENABLED.

2013-07-18 Thread Daniel Vetter
On Wed, Jul 17, 2013 at 10:08:34PM +0100, Chris Wilson wrote: > On Wed, Jul 17, 2013 at 06:01:03PM -0300, Rodrigo Vivi wrote: > > On Wed, Jul 17, 2013 at 5:18 PM, Chris Wilson > > wrote: > > > On Wed, Jul 17, 2013 at 02:46:52PM -0300, Rodrigo Vivi wrote: > > >> Hi Chris, > > >> > > >> could you p

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Create VMAs

2013-07-18 Thread Chris Wilson
On Wed, Jul 17, 2013 at 07:31:37PM -0700, Ben Widawsky wrote: > On Thu, Jul 18, 2013 at 01:12:17AM +0100, Chris Wilson wrote: > > Big-bada-boom; > > Just from looking at the code I think I see a bug. A bug which didn't > exist in the original version of the code, and doesn't exist after the > very

Re: [Intel-gfx] [PATCH 06/11] drm/i915: Match all PSR mode entry conditions before enabling it.

2013-07-18 Thread Daniel Vetter
On Mon, Jul 15, 2013 at 03:06:22PM +0100, Chris Wilson wrote: > On Thu, Jul 11, 2013 at 06:45:00PM -0300, Rodrigo Vivi wrote: > > v2: Prefer seq_puts to seq_printf by Paulo Zanoni. > > v3: small changes like avoiding calling dp_to_dig_port twice as noticed by > > Paulo Zanoni. > > v4: Avoiding

Re: [Intel-gfx] [PATCH 04/11] drm/i915: Enable/Disable PSR

2013-07-18 Thread Daniel Vetter
On Wed, Jul 17, 2013 at 02:02:58PM -0300, Paulo Zanoni wrote: > 2013/7/11 Rodrigo Vivi : > > +static void intel_edp_psr_write_vsc(struct intel_dp *intel_dp, > > + struct edp_vsc_psr *vsc_psr) > > +{ > > + struct intel_digital_port *dig_port = dp_to_dig_port(i

Re: [Intel-gfx] RFC frontbuffer write tracking

2013-07-18 Thread Daniel Vetter
On Thu, Jun 20, 2013 at 06:18:27PM +0100, Chris Wilson wrote: > Having thrown around a few ideas for how to do PSR and FBC write > tracking on the frontbuffer, including the creation of a new SCANOUT > domain, the implementation that I've settled on is to detect writes to > either the GTT domain (h