ks ]
>>>
>>> [ Did not check any relevant MLs ]
>>>
>>> Please, see attached dmesg output.
>>
>> Clock mismatch, one for Jesse to figure out. Note that this patch is
>> for 3.12, I simply haven't yet gotten around to properly split my
>
On Mon, 1 Jul 2013 22:01:04 +0200
Daniel Vetter wrote:
> The usual drm driver has tons of different drm_mm memory managers so
> the drm error message in dmesg is pretty useless. WARN instead so
> that we have the full backtrace.
>
> Signed-off-by: Daniel Vetter
I've written this patch myself
PSR must be enabled after transcoder and port are running.
And it is only available for HSW.
v2: move enable/disable to intel_ddi
v3: The spec suggests PSR should be disabled even before backlight (by pzanoni)
v4: also disabling and enabling whenever panel is disabled/enabled.
v5: make it last pat
v2: Prefer seq_puts to seq_printf by Paulo Zanoni.
v3: small changes like avoiding calling dp_to_dig_port twice as noticed by
Paulo Zanoni.
v4: Avoiding reading non-existent registers - noticed by Paulo
on first psr debugfs patch.
Cc: Paulo Zanoni
Signed-off-by: Rodrigo Vivi
---
drivers
Adding support for PSR Status, PSR entry counter and performance counters.
Heavily based on initial work from Shobhit.
v2: Fix PSR Status Link bits by Paulo Zanoni.
v3: Prefer seq_puts to seq_printf by Paulo Zanoni.
v4: Fix identation by Paulo Zanoni.
v5: Return earlier if it isn't Haswell in orde
Adding Enable and Disable PSR functionalities. This includes setting the
PSR configuration over AUX, sending SDP VSC DIP over the eDP PIPE config,
enabling PSR in the sink via DPCD register and finally enabling PSR on
the host.
This patch is based on initial PSR code by Sateesh Kavuri and Kumar Sh
This should help on HSW, where we don't currently have a get_clock call.
Reported-by: Paulo Zanoni
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c | 24 ++--
1 file changed, 14 insertions(+), 10 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dis
On Mon, Jul 01, 2013 at 09:08:58PM +0200, Daniel Vetter wrote:
> On Mon, Jul 1, 2013 at 8:43 PM, Daniel Vetter wrote:
> >> All of this is addressed in future patches. As we've discussed, I think
> >> I'll have to respin it anyway, so I'll name it as such upfront. To me it
> >> felt a little weird
On Sun, Jun 30, 2013 at 05:38:16PM +0200, Daniel Vetter wrote:
> On Thu, Jun 27, 2013 at 04:30:27PM -0700, Ben Widawsky wrote:
> > for file in `ls drivers/gpu/drm/i915/*.c` ; do sed -i
> > "s/dev_priv->mm.inactive_list/i915_gtt_mm-\>inactive_list/" $file; done
> > for file in `ls drivers/gpu/drm/i
On Mon, Jul 01, 2013 at 11:39:30PM +0200, Daniel Vetter wrote:
> Hi Ben
>
> So first things first: I rather like what the code looks like overall at
> the end. I've done a light read-through (by far not a full review) and
> besides a few bikesheds (all mentioned by mail already) the big thing is
>
Hi Ben
So first things first: I rather like what the code looks like overall at
the end. I've done a light read-through (by far not a full review) and
besides a few bikesheds (all mentioned by mail already) the big thing is
the 1:1 context:ppgtt address space relationship.
We've discussed this at
On Mon, Jul 1, 2013 at 10:46 PM, Ben Widawsky wrote:
>> > drm_mm_remove_node() does unlink the node but not remove it. Btw., I
>> > have these fixes in my series, too. I will push it later and write the
>> > git-link to #dri-devel.
>>
>> We have patches in-flight to convert over to embedded drm_mm
Again, Thank you very much for your comments.
Replying what I did and why I didn't here and patches coming later.
On Fri, Jun 28, 2013 at 5:46 PM, Paulo Zanoni wrote:
> 2013/6/28 Rodrigo Vivi :
>> v2: Prefer seq_puts to seq_printf by Paulo Zanoni.
>>
>> Cc: Paulo Zanoni
>> Signed-off-by: Rodri
On Mon, Jul 01, 2013 at 10:39:03PM +0200, Daniel Vetter wrote:
> On Mon, Jul 01, 2013 at 10:21:57PM +0200, David Herrmann wrote:
> > Hi
> >
> > On Mon, Jul 1, 2013 at 10:05 PM, Daniel Vetter
> > wrote:
> > > When converting to the preallocated drm_mm_node interfaces in
> > >
> > > commit dc9dd7a
On Fri, Jun 28, 2013 at 4:31 PM, Paulo Zanoni wrote:
> Hi
>
> 2013/6/28 Rodrigo Vivi :
>> Adding Enable and Disable PSR functionalities. This includes setting the
>> PSR configuration over AUX, sending SDP VSC DIP over the eDP PIPE config,
>> enabling PSR in the sink via DPCD register and finally
On Mon, Jul 01, 2013 at 10:21:57PM +0200, David Herrmann wrote:
> Hi
>
> On Mon, Jul 1, 2013 at 10:05 PM, Daniel Vetter wrote:
> > When converting to the preallocated drm_mm_node interfaces in
> >
> > commit dc9dd7a20fde95aa81a8307cde79c2dff9f83f3d
> > Author: Chris Wilson
> > Date: Fri Dec 7
Every other place properly checks whether we've managed to set
up the stolen allocator at boot-up properly, with the exception
of the cleanup code. Which results in an ugly
*ERROR* Memory manager not clean. Delaying takedown
at module unload time since the drm_mm isn't initialized at all.
v2: Wh
On Mon, Jul 01, 2013 at 09:16:56PM +0100, Chris Wilson wrote:
> On Mon, Jul 01, 2013 at 10:05:54PM +0200, Daniel Vetter wrote:
> > When converting to the preallocated drm_mm_node interfaces in
> >
> > commit dc9dd7a20fde95aa81a8307cde79c2dff9f83f3d
> > Author: Chris Wilson
> > Date: Fri Dec 7 2
On Mon, Jul 01, 2013 at 10:05:54PM +0200, Daniel Vetter wrote:
> When converting to the preallocated drm_mm_node interfaces in
>
> commit dc9dd7a20fde95aa81a8307cde79c2dff9f83f3d
> Author: Chris Wilson
> Date: Fri Dec 7 20:37:07 2012 +
>
> drm/i915: Preallocate the drm_mm_node prior to
Hi
On Mon, Jul 1, 2013 at 10:05 PM, Daniel Vetter wrote:
> When converting to the preallocated drm_mm_node interfaces in
>
> commit dc9dd7a20fde95aa81a8307cde79c2dff9f83f3d
> Author: Chris Wilson
> Date: Fri Dec 7 20:37:07 2012 +
>
> drm/i915: Preallocate the drm_mm_node prior to manip
On Mon, Jul 01, 2013 at 10:05:53PM +0200, Daniel Vetter wrote:
> drm/i915 is the only user of the color allocation handling and
> switched to insert_node a while ago. So we can ditch this.
>
> Signed-off-by: Daniel Vetter
If you build it, they will come. Lies!
Reviewed-by: Chris Wilson
-Chris
On Mon, Jul 01, 2013 at 10:01:03PM +0200, Daniel Vetter wrote:
> Every other place properly checks whether we've managed to set
> up the stolen allocator at boot-up properly, with the exception
> of the cleanup code. Which results in an ugly
>
> *ERROR* Memory manager not clean. Delaying takedown
When converting to the preallocated drm_mm_node interfaces in
commit dc9dd7a20fde95aa81a8307cde79c2dff9f83f3d
Author: Chris Wilson
Date: Fri Dec 7 20:37:07 2012 +
drm/i915: Preallocate the drm_mm_node prior to manipulating the GTT drm_mm
only the allocation side was converted, but not
drm/i915 is the only user of the color allocation handling and
switched to insert_node a while ago. So we can ditch this.
Signed-off-by: Daniel Vetter
---
include/drm/drm_mm.h | 31 ---
1 file changed, 31 deletions(-)
diff --git a/include/drm/drm_mm.h b/include/drm/d
Every other place properly checks whether we've managed to set
up the stolen allocator at boot-up properly, with the exception
of the cleanup code. Which results in an ugly
*ERROR* Memory manager not clean. Delaying takedown
at module unload time since the drm_mm isn't initialized at all.
v2: Wh
The usual drm driver has tons of different drm_mm memory managers so the drm
error message in dmesg is pretty useless. WARN instead so that we have the full
backtrace.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/drm_mm.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git
In
commit 3a359f0b21ab218c1bf7a6a1b638b6fd143d0b99
Author: Daniel Vetter
Date: Sat Apr 20 12:08:11 2013 +0200
drm/mm: fix dump table BUG
I've failed to fix both instances of the regression introduced in
commit 9e8944ab564f2e3dde90a518cd32048c58918608
Author: Chris Wilson
Date: Thu Nov
On Mon, Jul 1, 2013 at 9:48 PM, Ben Widawsky wrote:
>> Full ppgtt otoh need the address space of course.
>>
>> The above structure layout would allow that. It means that aliasing
>> ppgtt will stick out a bit like a sore thumb but imo that's ok since
>> it really _is_ a bit an odd thing. I've just
On Mon, Jul 01, 2013 at 09:06:20PM +0200, Daniel Vetter wrote:
> On Mon, Jul 1, 2013 at 8:52 PM, Ben Widawsky wrote:
> >> One thing which looks a bit peculiar at the end is that struct
> >> i915_hw_ppgtt is actually used as the real ppgtt object (since it
> >> subclases i915_address space). My ori
On Mon, Jul 1, 2013 at 8:43 PM, Daniel Vetter wrote:
>> All of this is addressed in future patches. As we've discussed, I think
>> I'll have to respin it anyway, so I'll name it as such upfront. To me it
>> felt a little weird to start calling things "ggtt" before I made the
>> separation.
>
> I t
On Mon, Jul 1, 2013 at 8:52 PM, Ben Widawsky wrote:
>> One thing which looks a bit peculiar at the end is that struct
>> i915_hw_ppgtt is actually used as the real ppgtt object (since it
>> subclases i915_address space). My original plan was that we'll add a new
>> struct i915_ppgtt {
>> str
On Sun, Jun 30, 2013 at 05:35:00PM +0200, Daniel Vetter wrote:
> On Thu, Jun 27, 2013 at 04:30:41PM -0700, Ben Widawsky wrote:
> > This allows us to be aware of all the VMAs leftover and teardown, and is
> > useful for debug. I suspect it will prove even more useful later.
> >
> > Signed-off-by: B
On Mon, Jul 1, 2013 at 8:40 PM, Ben Widawsky wrote:
> On Sun, Jun 30, 2013 at 03:12:35PM +0200, Daniel Vetter wrote:
>> On Thu, Jun 27, 2013 at 04:30:22PM -0700, Ben Widawsky wrote:
>> > The GTT and PPGTT can be thought of more generally as GPU address
>> > spaces. Many of their actions (insert en
On Sun, Jun 30, 2013 at 03:27:44PM +0200, Daniel Vetter wrote:
> On Thu, Jun 27, 2013 at 04:30:25PM -0700, Ben Widawsky wrote:
> > for file in `ls drivers/gpu/drm/i915/*.c` ; do
> > sed -i "s/mm.aliasing/gtt.aliasing/" $file;
> > done
>
> Commit message should explain _why_ we do something. Ag
On Mon, Jul 1, 2013 at 8:43 PM, Ben Widawsky wrote:
> On Sun, Jun 30, 2013 at 03:18:46PM +0200, Daniel Vetter wrote:
>> On Thu, Jun 27, 2013 at 04:30:24PM -0700, Ben Widawsky wrote:
>> > It doesn't apply to generic VMA, so it belongs with the gtt.
>> >
>> > for file in `ls drivers/gpu/drm/i915/*.c
On Mon, Jul 1, 2013 at 8:32 PM, Ben Widawsky wrote:
> On Sun, Jun 30, 2013 at 03:00:05PM +0200, Daniel Vetter wrote:
>> On Thu, Jun 27, 2013 at 04:30:31PM -0700, Ben Widawsky wrote:
>> > This will be handy when we add VMs. It's not strictly, necessary, but it
>> > will make the code much cleaner.
On Sun, Jun 30, 2013 at 03:18:46PM +0200, Daniel Vetter wrote:
> On Thu, Jun 27, 2013 at 04:30:24PM -0700, Ben Widawsky wrote:
> > It doesn't apply to generic VMA, so it belongs with the gtt.
> >
> > for file in `ls drivers/gpu/drm/i915/*.c` ; do
> > sed -i "s/mm.stolen_base/gtt.stolen_base/"
On Sun, Jun 30, 2013 at 03:12:35PM +0200, Daniel Vetter wrote:
> On Thu, Jun 27, 2013 at 04:30:22PM -0700, Ben Widawsky wrote:
> > The GTT and PPGTT can be thought of more generally as GPU address
> > spaces. Many of their actions (insert entries), state (LRU lists) and
> > many of their characteri
On Sun, Jun 30, 2013 at 03:00:05PM +0200, Daniel Vetter wrote:
> On Thu, Jun 27, 2013 at 04:30:31PM -0700, Ben Widawsky wrote:
> > This will be handy when we add VMs. It's not strictly, necessary, but it
> > will make the code much cleaner.
> >
> > Signed-off-by: Ben Widawsky
>
> You're going to
On Sun, Jun 30, 2013 at 02:34:43PM +0200, Daniel Vetter wrote:
> On Thu, Jun 27, 2013 at 04:30:30PM -0700, Ben Widawsky wrote:
> > For an upcoming patch where we introduce the i915 VMA, it's ideal to
> > have the drm_mm_node as part of the VMA struct (ie. it's pre-allocated).
> > Part of the conver
On Sun, Jun 30, 2013 at 01:36:39PM +0200, Daniel Vetter wrote:
> On Sun, Jun 30, 2013 at 1:31 PM, Chris Wilson
> wrote:
> > I respectfully disagree. The semantics of the pin ioctl remain useful
> > even with the ggtt/ppgtt split, and I think barring its use forever more
> > is unwise. Not that pi
On Mon, 1 Jul 2013 19:36:32 +0200
Daniel Vetter wrote:
> On Mon, Jul 01, 2013 at 10:19:10AM -0700, Jesse Barnes wrote:
> > We need to get the current hw state so we can compare against the
> > expected state.
> >
> > References: https://bugs.freedesktop.org/show_bug.cgi?id=66444
> >
> > Signed-
On Mon, Jul 01, 2013 at 10:19:10AM -0700, Jesse Barnes wrote:
> We need to get the current hw state so we can compare against the
> expected state.
>
> References: https://bugs.freedesktop.org/show_bug.cgi?id=66444
>
> Signed-off-by: Jesse Barnes
Both patches merged. I'll squash this one here i
Print out the flag that failed and fix up a mismatched paren.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 1dd49e8
We need to get the current hw state so we can compare against the
expected state.
References: https://bugs.freedesktop.org/show_bug.cgi?id=66444
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drive
On Mon, Jul 01, 2013 at 05:19:59PM +0100, Chris Wilson wrote:
> On Thu, Jun 06, 2013 at 05:38:54PM +0300, Mika Kuoppala wrote:
> > As getting error state doesn't anymore require big kmallocs,
> > make error state accessible also from sysfs.
> >
> > v2: - error state clearing (Chris Wilson)
> >
On Fri, Jun 28, 2013 at 02:35:41PM +0300, Mika Kuoppala wrote:
> Test both debugfs and sysfs error_state interfaces.
>
> v2: sysfs error_state not mandatory
>
> Signed-off-by: Mika Kuoppala
Series merged with Chris' s/error_state/error/ bikeshed applied, thanks.
-Daniel
> ---
> tests/ZZ_hangm
On Thu, Jun 06, 2013 at 05:38:54PM +0300, Mika Kuoppala wrote:
> As getting error state doesn't anymore require big kmallocs,
> make error state accessible also from sysfs.
>
> v2: - error state clearing (Chris Wilson)
> - user hint, proper access mode bits and name (Daniel Vetter)
>
> v3: re
On 06/26/2013 04:24 PM, Shuah Khan wrote:
> On 06/26/2013 04:12 PM, Winkler, Tomas wrote:
>>
>>
>> 42f132f mei: me: clear interrupts on the resume path
>> 2753ff5 mei: nfc: fix nfc device freeing
>> 5e85b36 mei: init: Flush scheduled work before resetting the device
>>
>> Are you sure you have the
On Mon, Jul 1, 2013 at 10:52 AM, Daniel Vetter wrote:
> On Mon, Jul 1, 2013 at 10:49 AM, Sedat Dilek wrote:
>> On Mon, Jul 1, 2013 at 9:59 AM, Stephen Rothwell
>> wrote:
>>> Hi all,
>>>
>>> Changes since 20130628:
>>>
>>> The regulator tree gained a build failure so I used the version from
>>>
On Mon, Jul 1, 2013 at 10:49 AM, Sedat Dilek wrote:
> On Mon, Jul 1, 2013 at 9:59 AM, Stephen Rothwell
> wrote:
>> Hi all,
>>
>> Changes since 20130628:
>>
>> The regulator tree gained a build failure so I used the version from
>> next-20130628.
>>
>> The trivial tree gained a conflict against t
On Mon, Jul 01, 2013 at 10:56:06AM +0530, Vijay Purushothaman wrote:
> On 6/28/2013 7:54 PM, Ville Syrjälä wrote:
> > On Fri, Jun 28, 2013 at 07:45:31PM +0530, Vijay Purushothaman wrote:
> >> Since the sprite planes are using synchronized MMIO based flip, no need
> >> to wait for vblank. Removing t
52 matches
Mail list logo
