I've pushed a branch with everything I got from Damien's review so far.
http://cgit.freedesktop.org/~bwidawsk/drm-intel/log/?h=vecs-rebase
Since it appears Damien hasn't finished yet, I won't send the updated
patches in case someone else comes along with more comments on those
patches.
Also, sin
On Tue, May 07, 2013 at 03:49:18PM +0100, Damien Lespiau wrote:
> On Sat, Apr 27, 2013 at 05:59:15PM -0700, Ben Widawsky wrote:
> > Like the other rings, the VECS supports semaphores. The semaphore stuff
> > is a bit wonky so this patch on it's own should be nice for review.
> >
> > This patch sho
On Tue, May 07, 2013 at 04:34:46PM +0100, Damien Lespiau wrote:
> On Sat, Apr 27, 2013 at 05:59:13PM -0700, Ben Widawsky wrote:
> > This replaces the existing MBOX update code with a more generalized
> > calculation for emitting mbox updates. We also create a sentinel for
> > doing the updates so w
I think we could.
Joshua, do u still have access to the CrestViewHills platform with Soo Keong -
I need to make some changes to our GEM and try some new code.
Lets take this offline and try to get a reply back to Jesse later.
...alan
-Original Message-
From: Jesse Barnes [mailto:jbar..
Hi Daniel,
On Tue, 7 May 2013 10:43:17 +0200 Daniel Vetter wrote:
>
> On Tue, May 7, 2013 at 3:27 AM, Stephen Rothwell
> wrote:
> >
> > Daniel, I assume all this stuff being added to the drm-intel tree is
> > going upstream very soon?
>
> Oops, no that is stuff for 3.11. Lazy me hoped I could
On Tue, 7 May 2013 23:14:40 +0100
Chris Wilson wrote:
> On Tue, May 07, 2013 at 03:08:42PM -0700, Jesse Barnes wrote:
> > On Tue, 7 May 2013 22:57:37 +0100
> > Chris Wilson wrote:
> >
> > > On Tue, May 07, 2013 at 02:34:31PM -0700, Jesse Barnes wrote:
> > > > +static void valleyview_setup_pctx(
Alan, is this something your team can test since your BIOS doesn't
allocate the power context?
Thanks,
Jesse
On Tue, 7 May 2013 14:34:31 -0700
Jesse Barnes wrote:
> But we need to get the right stolen base and make pre-allocated objects
> for BIOS stuff so we don't clobber it. If the BIOS has
We can use this for fetching encoder specific pipe_config state, like
mode flags, adjusted clock, etc.
Just used for mode flags atm, so we can check the pipe config state at
mode set time.
v2: get_config when checking hw state too
v3: fix DVO and LVDS mode flags (Ville)
get SDVO DTD for flag
On Tue, 7 May 2013 23:14:40 +0100
Chris Wilson wrote:
> On Tue, May 07, 2013 at 03:08:42PM -0700, Jesse Barnes wrote:
> > On Tue, 7 May 2013 22:57:37 +0100
> > Chris Wilson wrote:
> >
> > > On Tue, May 07, 2013 at 02:34:31PM -0700, Jesse Barnes wrote:
> > > > +static void valleyview_setup_pctx(
On Tue, May 07, 2013 at 03:08:42PM -0700, Jesse Barnes wrote:
> On Tue, 7 May 2013 22:57:37 +0100
> Chris Wilson wrote:
>
> > On Tue, May 07, 2013 at 02:34:31PM -0700, Jesse Barnes wrote:
> > > +static void valleyview_setup_pctx(struct drm_device *dev)
> > > +{
> > > + struct drm_i915_private *de
On Tue, 7 May 2013 22:57:37 +0100
Chris Wilson wrote:
> On Tue, May 07, 2013 at 02:34:31PM -0700, Jesse Barnes wrote:
> > +static void valleyview_setup_pctx(struct drm_device *dev)
> > +{
> > + struct drm_i915_private *dev_priv = dev->dev_private;
> > + struct drm_i915_gem_object *pctx;
> > +
On Tue, May 07, 2013 at 02:34:31PM -0700, Jesse Barnes wrote:
> +static void valleyview_setup_pctx(struct drm_device *dev)
> +{
> + struct drm_i915_private *dev_priv = dev->dev_private;
> + struct drm_i915_gem_object *pctx;
> + unsigned long pctx_paddr;
> + u32 pcbr;
> + int pct
On Tue, May 07, 2013 at 11:00:03AM -0700, Jesse Barnes wrote:
> Works pretty well actually.
>
> Signed-off-by: Jesse Barnes
With v6 of the stolen patch merged:
Acked-by: Ben Widawsky
> ---
> drivers/gpu/drm/i915/i915_drv.c |6 --
> 1 file changed, 6 deletions(-)
>
> diff --git a/driv
But we need to get the right stolen base and make pre-allocated objects
for BIOS stuff so we don't clobber it. If the BIOS hasn't allocated a
power context, we allocate one here too, from stolen space as required
by the docs.
v2: fix stolen to phys if ladder (Ben)
keep BIOS reserved space out
Pfit state readout is a bit ugly on gen2/3 due to the intermingling
with the lvds state, but alas.
Also note that since state is always cleared to zero we can
unconditonally compare all the state and completely neglect the actual
platform we're running on.
v2: Properly check for the pfit power do
But we need to get the right stolen base and make pre-allocated objects
for BIOS stuff so we don't clobber it. If the BIOS hasn't allocated a
power context, we allocate one here too, from stolen space as required
by the docs.
v2: fix stolen to phys if ladder (Ben)
keep BIOS reserved space out
On Tue, May 07, 2013 at 08:59:12PM +0100, Chris Wilson wrote:
> On Tue, May 07, 2013 at 06:54:05PM +0300, Jani Nikula wrote:
> > Similar to
> > commit 88afe715dd5469bc24ca7a19ac62dd3c241cab48
> > Author: Chris Wilson
> > Date: Sun Dec 16 12:15:41 2012 +
> >
> > drm/i915: Clear the stole
On Tue, May 07, 2013 at 06:54:05PM +0300, Jani Nikula wrote:
> Similar to
> commit 88afe715dd5469bc24ca7a19ac62dd3c241cab48
> Author: Chris Wilson
> Date: Sun Dec 16 12:15:41 2012 +
>
> drm/i915: Clear the stolen fb before enabling
>
> but on the resume path.
>
> Bugzilla: https://bug
2013/5/6 :
> From: Ville Syrjälä
>
> Rewrite the ILK+ watermark code to allow:
> - updating the watermarks safely (to avoid underruns)
> - pre-computing watermarks (will help with atomic modest and pageflip)
> - enabling LP1+ watermarks for HSW multi-pipe scenarios
>
> The watermark registers are
On Tue, May 07, 2013 at 12:34:00PM -0700, Jesse Barnes wrote:
> But we need to get the right stolen base and make pre-allocated objects
> for BIOS stuff so we don't clobber it. If the BIOS hasn't allocated a
> power context, we allocate one here too, from stolen space as required
> by the docs.
>
On Tue, May 07, 2013 at 11:50:47AM -0700, Jesse Barnes wrote:
> @@ -62,7 +62,10 @@ static unsigned long i915_stolen_to_physical(struct
> drm_device *dev)
>* its value of TOLUD.
>*/
> base = 0;
> - if (INTEL_INFO(dev)->gen >= 6) {
> + if (IS_VALLEYVIEW(dev)) {
> +
But we need to get the right stolen base and make pre-allocated objects
for BIOS stuff so we don't clobber it. If the BIOS hasn't allocated a
power context, we allocate one here too, from stolen space as required
by the docs.
v2: fix stolen to phys if ladder (Ben)
keep BIOS reserved space out
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/intel_display.c | 12 +++-
drivers/gpu/drm/i915/intel_dp.c |4
2 files changed, 7 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index bcadc19..9472e
On ILK-IVB the CPU side eDP is always on port-A.
Also reduce somewhat the debug verbosity.
v2:
- reduce debug verbosity
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/intel_display.c | 10 +++---
1 file changed, 3 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_
But we need to get the right stolen base and make pre-allocated objects
for BIOS stuff so we don't clobber it. If the BIOS hasn't allocated a
power context, we allocate one here too, from stolen space as required
by the docs.
v2: fix stolen to phys if ladder (Ben)
keep BIOS reserved space out
On Tue, May 7, 2013 at 7:59 PM, Daniel Vetter wrote:
> On Tue, May 7, 2013 at 7:44 PM, Ville Syrjälä
> wrote:
>>> +static void intel_sdvo_get_config(struct intel_encoder *encoder,
>>> + struct intel_crtc_config *pipe_config)
>>> +{
>>> + struct intel_sdvo *intel_
We can use this for fetching encoder specific pipe_config state, like
mode flags, adjusted clock, etc.
Just used for mode flags atm, so we can check the pipe config state at
mode set time.
v2: get_config when checking hw state too
v3: fix DVO and LVDS mode flags (Ville)
Signed-off-by: Jesse Barn
Hi
I just tested this series on Haswell, on top of dinq + my watermark
patches. I applied these 6 patches + "Revert "drm/i915: Calculate
correct stolen size for GEN7+"".
Without FBC I was getting around 2.5% PC7 residency with 1920x1080.
Now with a full-screen black-background terminal I get 66%
Works pretty well actually.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_drv.c |6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_drv.c
index 624cdfc..e57b127 100644
--- a/drivers/gpu/drm/i915/i915_drv.c
+++ b/driv
On Tue, May 7, 2013 at 7:44 PM, Ville Syrjälä
wrote:
>> +static void intel_sdvo_get_config(struct intel_encoder *encoder,
>> + struct intel_crtc_config *pipe_config)
>> +{
>> + struct intel_sdvo *intel_sdvo = to_intel_sdvo(&encoder->base);
>> + struct drm_i915
But we need to get the right stolen base and make pre-allocated objects
for BIOS stuff so we don't clobber it. If the BIOS hasn't allocated a
power context, we allocate one here too, from stolen space as required
by the docs.
v2: fix stolen to phys if ladder (Ben)
keep BIOS reserved space out
On Mon, May 06, 2013 at 09:56:40AM -0700, Jesse Barnes wrote:
> We can use this for fetching encoder specific pipe_config state, like
> mode flags, adjusted clock, etc.
>
> Just used for mode flags atm, so we can check the pipe config state at
> mode set time.
>
> v2: get_config when checking hw
On Sat, Apr 27, 2013 at 05:59:16PM -0700, Ben Widawsky wrote:
> Historically we considered the render ring to have special flush
> semantics and everything else to fall under a more general umbrella.
> Probably by coincidence more than anything we decided to make the bsd
> ring have the default *ot
On Sat, Apr 27, 2013 at 05:59:18PM -0700, Ben Widawsky wrote:
> v2: Add set_seqno which didn't exist before rebase (Haihao)
>
> Signed-off-by: Ben Widawsky
> Signed-off-by: Xiang, Haihao
Reviewed-by: Damien Lespiau
--
Damien
___
Intel-gfx mailing l
On Wed, May 01, 2013 at 11:03:10AM -0700, Ben Widawsky wrote:
> On Wed, May 01, 2013 at 11:00:34AM -0700, Ben Widawsky wrote:
> > This reverts commit 03752f5b7b77b95d83479885040950fba1250850.
> >
> > This revert requires a bit of explanation on how I understand things
> > work. Internally the arch
On Tue, May 07, 2013 at 09:51:16AM -0700, Ben Widawsky wrote:
> On Tue, May 07, 2013 at 02:54:06PM +0100, Damien Lespiau wrote:
> > On Sat, Apr 27, 2013 at 05:59:12PM -0700, Ben Widawsky wrote:
> > > Semaphores are tied very closely to the rings in the GPU. Trivial patch
> > > adds comments to the
On Tue, May 07, 2013 at 02:54:06PM +0100, Damien Lespiau wrote:
> On Sat, Apr 27, 2013 at 05:59:12PM -0700, Ben Widawsky wrote:
> > Semaphores are tied very closely to the rings in the GPU. Trivial patch
> > adds comments to the existing code so that when we add new rings we can
> > include comment
Similar to
commit 88afe715dd5469bc24ca7a19ac62dd3c241cab48
Author: Chris Wilson
Date: Sun Dec 16 12:15:41 2012 +
drm/i915: Clear the stolen fb before enabling
but on the resume path.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=57191
Reported-and-tested-by: Nikolay Amiantov
On Sat, Apr 27, 2013 at 05:59:14PM -0700, Ben Widawsky wrote:
> The video enhancement command streamer is a new ring on HSW which does
> what it sounds like it does. This patch provides the most minimal
> inception of the ring.
>
> In order to support a new ring, we need to bump the number. The pa
On Tue, May 7, 2013 at 5:24 PM, Imre Deak wrote:
> On ILK-IVB the PCH side eDP is always on port-D.
>
> Signed-off-by: Imre Deak
> ---
> drivers/gpu/drm/i915/intel_display.c |2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_display.c
> b/driv
On Sat, Apr 27, 2013 at 05:59:13PM -0700, Ben Widawsky wrote:
> This replaces the existing MBOX update code with a more generalized
> calculation for emitting mbox updates. We also create a sentinel for
> doing the updates so we can more abstractly deal with the rings.
>
> When doing MBOX updates
On HSW the CPU side eDP is always on port-A, the PCH side eDP is always
on port-D.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/intel_display.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
There are no more users for these, so remove them.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/intel_dp.c | 36
drivers/gpu/drm/i915/intel_drv.h |2 --
2 files changed, 38 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/d
is_pch_edp() will be removed by the next patch, so replace it by a check
for the port and device type.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/intel_dp.c | 17 +++--
1 file changed, 11 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/g
is_pch_edp() will be removed in a follow-up patch, so replace it
with a check for the port and VBT info (for port-D eDP).
Also make things a bit clearer by using a switch on the ports.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/intel_dp.c | 32 +---
1 file c
On ILK-IVB the PCH side eDP is always on port-D.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/intel_display.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 5b689b2..bdf07b7 100644
---
Signed-off-by: Imre Deak
---
drivers/gpu/drm/i915/intel_drv.h | 12 +---
1 file changed, 5 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_drv.h b/drivers/gpu/drm/i915/intel_drv.h
index 6e01393..c24ee02 100644
--- a/drivers/gpu/drm/i915/intel_drv.h
+++ b/drivers/g
Since whether a specific eDP port is on CPU or on PCH is fixed and
depends only on which digital port it is, we don't really need state
tracking for it. So remove it and instead check for the port and if
needed the machine type (for ValleyView).
The assumption in the code before and after the chan
This is one reason for some of the sporadic kms_flip failures.
One such is https://bugs.freedesktop.org/show_bug.cgi?id=59834.
v2:
- use unsigned long for KDSETMODE/KDGETMODE
- fix passing the parameter to KDGETMODE as it should be by value
- actually testing that it works..
v3:
- don't do an exp
On Sat, Apr 27, 2013 at 05:59:17PM -0700, Ben Widawsky wrote:
> From: "Xiang, Haihao"
>
> The flag will be useful to help share code between IVB, and HSW as the
> programming is similar in many places with this as one of the major
> differences.
>
> v2 (Ben): used the new dev info macros
>
> Si
On Sat, Apr 27, 2013 at 05:59:15PM -0700, Ben Widawsky wrote:
> Like the other rings, the VECS supports semaphores. The semaphore stuff
> is a bit wonky so this patch on it's own should be nice for review.
>
> This patch should have no functional impact.
>
> Signed-off-by: Ben Widawsky
> ---
>
On Tue, May 07, 2013 at 10:46:01AM -0300, Paulo Zanoni wrote:
> 2013/5/7 Damien Lespiau :
> > On Tue, May 07, 2013 at 02:10:05PM +0100, Damien Lespiau wrote:
> >> On Wed, Apr 17, 2013 at 06:15:49PM -0300, Paulo Zanoni wrote:
> >> > From: Paulo Zanoni
> >> >
> >> > This should prevent mode set fail
On Tue, May 7, 2013 at 4:18 PM, Paulo Zanoni wrote:
> 2013/5/7 Daniel Vetter :
>> On Fri, May 03, 2013 at 12:15:39PM -0300, Paulo Zanoni wrote:
>>> From: Paulo Zanoni
>>>
>>> This fixes "unclaimed register" messages when the power well is
>>> disabled and there's a GPU hang.
>>
>> How does this b
2013/5/7 Daniel Vetter :
> On Fri, May 03, 2013 at 12:15:39PM -0300, Paulo Zanoni wrote:
>> From: Paulo Zanoni
>>
>> This fixes "unclaimed register" messages when the power well is
>> disabled and there's a GPU hang.
>
> How does this blow up in a gpu hang? Afaics pipe_enabled is mostly called
> i
On Sat, Apr 27, 2013 at 05:59:12PM -0700, Ben Widawsky wrote:
> Semaphores are tied very closely to the rings in the GPU. Trivial patch
> adds comments to the existing code so that when we add new rings we can
> include comments there as well. It also helps distinguish the ring to
> semaphore mailb
2013/5/7 Damien Lespiau :
> On Tue, May 07, 2013 at 02:10:05PM +0100, Damien Lespiau wrote:
>> On Wed, Apr 17, 2013 at 06:15:49PM -0300, Paulo Zanoni wrote:
>> > From: Paulo Zanoni
>> >
>> > This should prevent mode set failures on LPT.
>> >
>> > Signed-off-by: Paulo Zanoni
>> > ---
>> > drivers
On Tue, May 07, 2013 at 02:10:05PM +0100, Damien Lespiau wrote:
> On Wed, Apr 17, 2013 at 06:15:49PM -0300, Paulo Zanoni wrote:
> > From: Paulo Zanoni
> >
> > This should prevent mode set failures on LPT.
> >
> > Signed-off-by: Paulo Zanoni
> > ---
> > drivers/gpu/drm/i915/intel_pm.c |5 ++
On Wed, Apr 17, 2013 at 06:15:49PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> This should prevent mode set failures on LPT.
>
> Signed-off-by: Paulo Zanoni
> ---
> drivers/gpu/drm/i915/intel_pm.c |5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/gpu/drm/i915/in
Should prove helpful in debugging some DP branch devices.
Signed-off-by: Jani Nikula
---
drivers/gpu/drm/i915/intel_dp.c |5 +
1 file changed, 5 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c
index a293523..af16d5b 100644
--- a/drivers/gpu/d
commit 142e239849c800f9dc23f828762873073f612d3f
Author: Egbert Eich
Date: Thu Apr 11 15:57:57 2013 +0200
drm/i915: Add bit field to record which pins have received HPD events (v3)
added a bit field for hotplug event tracking. There ended up being three
different v3 of the patch: [1], [2],
On Fri, May 03, 2013 at 12:15:40PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> We already have the same check on intel_enable_ddi. This patch
> prevents "unclaimed register" messages when the power well is
> disabled.
>
> V2: Reset intel_crtc->eld_vld to false after the mode_set function
On Fri, May 03, 2013 at 12:15:39PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> This fixes "unclaimed register" messages when the power well is
> disabled and there's a GPU hang.
How does this blow up in a gpu hang? Afaics pipe_enabled is mostly called
in the vblank code, so this should b
On Fri, May 03, 2013 at 12:15:36PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> This should replace intel_using_power_well. The idea is that we're
> adding the requested power domain as an argument, so this might enable
> the code to look less platform-specific and also allows us to easily
On Fri, May 03, 2013 at 12:15:39PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> This fixes "unclaimed register" messages when the power well is
> disabled and there's a GPU hang.
>
> v2: Use the new intel_display_power_enabled().
> v3: Use the new domains for intel_display_power_enabled()
On Tue, May 7, 2013 at 3:27 AM, Stephen Rothwell wrote:
> Hi all,
>
> Today's linux-next merge of the drm-intel tree got a conflict in
> drivers/gpu/drm/i915/i915_reg.h between commit a65851af5938 ("drm/i915:
> Make data/link N value power of two") from Linus' tree and commit
> e3b95f1eb5b9 ("drm/
65 matches
Mail list logo
