On Tue, 19 Feb 2013 15:53:56 -0800
Stéphane Marchesin wrote:
> On Tue, Jan 29, 2013 at 7:41 PM, Stéphane Marchesin
> wrote:
>
> > This increases GEN6_RC6p_THRESHOLD from 10 to 15. For some
> > reason this avoids the gen6_gt_check_fifodbg.isra warnings and
> > associated GPU lockups, whi
On Wed, Feb 20, 2013 at 12:28:00AM +0100, Daniel Vetter wrote:
> Hm, sloppy me didn't send out the "patch merged" spam. Anyway:
>
> stolen + phys_object = kaboom
Nice reminder that the phys objects need to be upgraded to stolen.
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
__
On Thu, Feb 14, 2013 at 02:46:44PM -0800, Ben Widawsky wrote:
> On Thu, Feb 14, 2013 at 09:53:51PM +0200, ville.syrj...@linux.intel.com wrote:
> > From: Ville Syrjälä
> >
> > The bit controlling whether PIPE_CONTROL DW/QW write targets
> > the global GTT or PPGTT moved moved from DW 2 bit 2 to
>
On Tue, Jan 29, 2013 at 7:41 PM, Stéphane Marchesin wrote:
> This increases GEN6_RC6p_THRESHOLD from 10 to 15. For some
> reason this avoids the gen6_gt_check_fifodbg.isra warnings and
> associated GPU lockups, which makes my ivy bridge machine stable.
>
>
Ping?
> Signed-off-by: Stéphane
Hi Dave,
So here's my promised pile of fixes for 3.9. I've dropped the core prep
patches for vt-switchless suspend/resume as discussed on irc. Highlights:
- Fix dmar on g4x. Not really gfx related, but I'm fed up with getting
blamed for dmar crapouts.
- Disable wc ptes updates on ilk when dmar i
On Sun, Feb 10, 2013 at 01:37:52PM -0800, Ben Widawsky wrote:
> On Sun, Feb 10, 2013 at 07:38:13PM +, Chris Wilson wrote:
> > Reading the cspec pays dividends once again, as I found the 'Base of
> > Stolen Memory' config register so that we can skip the fragile
> > computation from Top of Usabl
Turns out it's easy to get the clock, though it may correspond to a
potential pfit mode. In that case, we may still be able to flip if
we can get the native mode params somehow.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c | 26 +++---
1 file change
We may need to disable the panel when flipping to a new buffer, so check
the state here and zero it out if needed, otherwise leave it alone.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c | 19 +++
1 file changed, 19 insertions(+)
diff --git a/drivers/gpu
If the mode is non-native using the panel fitter, don't try to re-use
the fb the BIOS allocated for it.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_fb.c | 12
1 file changed, 12 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel
In case we don't get an fb from the BIOS, we may still be able to re-use
existing state and flip a new buffer.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c |4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/dr
On Tue, Feb 19, 2013 at 05:39:49PM -0300, Paulo Zanoni wrote:
> Hi
>
> 2013/2/19 Jesse Barnes :
> > We still rely on a few LVDS bits, but restoring the enable bit can cause
> > trouble at this point, so don't.
> >
> > v2: use the right mask to prevent restore (Daniel)
> > conditionalize on KMS
From: Chris Wilson
Signed-off-by: Chris Wilson
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_dma.c |8 +-
drivers/gpu/drm/i915/i915_drv.h |2 +-
drivers/gpu/drm/i915/intel_display.c | 14 +-
drivers/gpu/drm/i915/intel_drv.h |4 +
drivers/gpu/drm/i915/int
From: Chris Wilson
Read the current hardware state to retrieve the active mode and populate
our CRTC config if that mode matches our presumptions.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h |2 +
drivers/gpu/drm/i915/intel_crt.c | 27 +++-
drivers/gpu/dr
From: Chris Wilson
Modifying the clock sources (via the DREF control on the PCH) is a slow
multi-stage process as we need to let the clocks stabilise between each
stage. If we are not actually changing the clock sources, then we can
return early.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm
From: Chris Wilson
This will be shared with wrapping the BIOS framebuffer into the fbdev
later. In the meantime, we can tidy the code slightly and improve the
error path handling.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_display.c |7 --
drivers/gpu/drm/i915/intel_drv.h
Missing a curly brace.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 0a2279e..595590c 100644
--- a/drivers/gpu/drm/i915
From: Chris Wilson
As we retrieve the mode from the BIOS it may be constructed using
different assumptions for its configuration, such as utilizing the panel
fitter in a conflicting manner. As such the associated framebuffer may be
insufficient for our setup, and so we need to reject the current
From: Chris Wilson
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_display.c |9 +
drivers/gpu/drm/i915/intel_dp.c |1 +
drivers/gpu/drm/i915/intel_drv.h |8
drivers/gpu/drm/i915/intel_fb.c |9 +
drivers/gpu/drm/i915/intel_lvds.c
This one adds some extra checks on top of Chris's last set:
- check for panel fit modes when inheriting from the BIOS
- update pfit state at pipe_set_base time
It also changes the mode set vs flip checking to include the non-fb case
(e.g. if the BIOS fb was too small for the native mode), sinc
Rather than building a config which may or may not work, let the driver
build an initial fb config. This allows the driver to use the BIOS boot
configuration for example, displaying kernel messages and the initial fb
console on the same outputs the BIOS lit up at boot time. If that
fails, the dri
From: Chris Wilson
Wrap a preallocated region of stolen memory within an ordinary GEM
object, for example the BIOS framebuffer.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h|5 +++
drivers/gpu/drm/i915/i915_gem_stolen.c | 65
2 f
2013/2/19 Jesse Barnes :
> Updated with the fix from Ville.
Very briefly tested on SNB (LVDS) and HSW (eDP + DP). Suspend-to-ram +
resume still work.
>
> ___
> Intel-gfx mailing list
> Intel-gfx@lists.freedesktop.org
> http://lists.freedesktop.org/mailm
Hi
2013/2/19 Jesse Barnes :
> Commented out and unneeded.
Oh, "DRM: i915: add mode setting support" added it, already commented.
>
> Signed-off-by: Jesse Barnes
Reviewed-by: Paulo Zanoni
> ---
> drivers/gpu/drm/i915/intel_fb.c |2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/dri
From: Ville Syrjälä
The indentation is getting way too deep. Pull the vblank interupt
handling out to separate functions.
v2: Keep flip_mask handling in the main irq handler and
flatten {i8xx,i915}_handle_vblank() even further.
Signed-off-by: Ville Syrjälä
---
v1 here http://paste.debian.n
Hi
2013/2/19 Jesse Barnes :
> We still rely on a few LVDS bits, but restoring the enable bit can cause
> trouble at this point, so don't.
>
> v2: use the right mask to prevent restore (Daniel)
> conditionalize on KMS support (Denial)
>
> Signed-off-by: Jesse Barnes
Reviewed-by: Paulo Zanoni
Updated with the fix from Ville.
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailman/listinfo/intel-gfx
Commented out and unneeded.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_fb.c |2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c
index 987bc33..f4e0b88 100644
--- a/drivers/gpu/drm/i915/intel_fb.c
+++ b/drivers/
With the other bits in place, we can do this safely.
v2: disable backlight on suspend to prevent premature enablement on resume
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_drv.c | 12 +---
drivers/gpu/drm/i915/intel_fb.c |3 +++
2 files changed, 12 insertions(+), 3 d
Needed for VT switchless resume.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_display.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 3e6dadf..2bf076e 100644
-
This will poke userspace into probing for configuration changes that may
have occurred across suspend/resume.
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_drv.c | 20
1 file changed, 20 insertions(+)
diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/
We still rely on a few LVDS bits, but restoring the enable bit can cause
trouble at this point, so don't.
v2: use the right mask to prevent restore (Daniel)
conditionalize on KMS support (Denial)
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_suspend.c |8 ++--
1 file cha
To be used to restore sprite state on resume.
v2: move sprite tracking bits up so we don't track modified sprite state
v3: use src_x/y in sprite suspend/resume code (Ville)
Signed-off-by: Jesse Barnes
---
drivers/gpu/drm/i915/intel_drv.h|5 +
drivers/gpu/drm/i915/intel_sprite.c |
On Tue, Feb 19, 2013 at 04:13:35PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> Otherwise, if the BIOS did anything wrong, our first I915_{WRITE,READ}
> will give us "unclaimed register" messages.
>
> V2: Even earlier.
> V3: Move it to intel_early_sanitize_regs.
>
> Bugzilla: http://bug
From: Paulo Zanoni
Bits used only on HDMI mode now have HDMI_ prefix instead of SDVO_.
The COLOR_FORMAT bits now have prefixes (and the 12bpc bit is for HDMI
only).
Notice that this patch uncovers a bug on the SDVO code: the
COLOR_RANGE_16_235 bit can only be used if the port is in TMDS mode,
no
From: Paulo Zanoni
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i915_reg.h | 17 ++---
drivers/gpu/drm/i915/intel_display.c | 18 +-
drivers/gpu/drm/i915/intel_hdmi.c| 23 +--
drivers/gpu/drm/i915/intel_sdvo.c| 16
From: Paulo Zanoni
Since they're all the same register, leave all the #defines at the
same place, organized by Gen and also specify which bits are used by
only a specific port or encoding.
Also remove a few unused duplicates and adjust indentation.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/
Hi
2013/2/19 Daniel Vetter :
> On Mon, Feb 18, 2013 at 07:00:27PM -0300, Paulo Zanoni wrote:
>> From: Paulo Zanoni
>>
>> Some HDMI registers can be used for SDVO, so saying "HDMIB" should be
>> the same as saying "SDVOB" for a given HW generation. This was not
>> true and led to confusions and ev
On Tue, Feb 19, 2013 at 03:16:38PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> If the interrupt handler were to process a previous vblank interrupt and
> the following flip pending interrupt at the same time, the page flip
> would be completed too soon.
>
> To eliminate
From: Paulo Zanoni
Otherwise, if the BIOS did anything wrong, our first I915_{WRITE,READ}
will give us "unclaimed register" messages.
V2: Even earlier.
V3: Move it to intel_early_sanitize_regs.
Bugzilla: http://bugs.freedesktop.org/show_bug.cgi?id=58897
Signed-off-by: Paulo Zanoni
---
driver
On Mon, 18 Feb 2013 19:19:55 +0200
Ville Syrjälä wrote:
> On Fri, Feb 15, 2013 at 01:23:10PM -0800, Jesse Barnes wrote:
> > To be used to restore sprite state on resume.
> >
> > v2: move sprite tracking bits up so we don't track modified sprite state
> >
> > Signed-off-by: Jesse Barnes
> > ---
On Mon, 18 Feb 2013 19:58:26 -0500
Kristian Høgsberg wrote:
> On Mon, Feb 18, 2013 at 10:03 AM, Daniel Vetter wrote:
> > On Fri, Feb 15, 2013 at 01:23:08PM -0800, Jesse Barnes wrote:
> >> A few more fixes from Daniel.
> >
> > So one thing that crossed my mind which we should at least quickly
> >
On Mon, 18 Feb 2013 16:03:20 +0100
Daniel Vetter wrote:
> On Fri, Feb 15, 2013 at 01:23:08PM -0800, Jesse Barnes wrote:
> > A few more fixes from Daniel.
>
> So one thing that crossed my mind which we should at least quickly
> discuss: How is userspace supposed to notice the resume? On a lot of
On Tue, 2013-02-19 at 11:35 +0100, Daniel Vetter wrote:
> On Tue, Feb 19, 2013 at 7:29 AM, William Brown
> wrote:
> > I recently read your blog article at :
> > http://blog.ffwll.ch/2013/02/neat-drmi915-stuff-for-39.html
> >
> > If you don't mind I have two questions regarding these changes.
> >
On Fri, Feb 15, 2013 at 09:21:37PM +0100, Daniel Vetter wrote:
> We need to clear the local variable to get the refcounting right
> (since the reference drm_mode_setplane holds is transferred to the
> plane->fb pointer). But should be done _after_ we update the pointer.
>
> Breakage introduced in
On Tue, Feb 19, 2013 at 1:49 PM, Chris Wilson wrote:
> On Tue, Feb 19, 2013 at 01:30:40PM +0100, Daniel Vetter wrote:
>> They reliably cause HDMI to not be detected on some systems (like my
>> ivb or the bug reporters gm45). To fix up the very slow unplug issues
>> we might want to fire up a 2nd d
From: Ville Syrjälä
Use the gen3 logic for handling page flip interrupts on gen4.
Unfortuantely this kills the stall_check since that looks like it can
easily trigger too early. With the current logic the stall check would
kick in on the first vblank after the flip has been submitted to the
ring
From: Ville Syrjälä
If the interrupt handler were to process a previous vblank interrupt and
the following flip pending interrupt at the same time, the page flip
would be completed too soon.
To eliminate this race, check the live pending flip status from the ISR
register before finishing the pag
These should hopefully fix up the races in gen2-4 page flip support.
Kudos to Chris for fixing up my mistakes in the gen4 patch, and for
providing a nice comment to explain the logic.
Disclaimer: I don't have hardware to test any of this. Currently it has
only been tested by Chris.
__
On Mon, Feb 18, 2013 at 09:41:10PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Signed-off-by: Ville Syrjälä
Applied the two i-g-t patches.
-Daniel
> ---
> lib/intel_chipset.h | 5 +
> 1 file changed, 5 insertions(+)
>
> diff --git a/lib/intel_chipset.h b/lib/inte
On Tue, Feb 19, 2013 at 01:30:40PM +0100, Daniel Vetter wrote:
> They reliably cause HDMI to not be detected on some systems (like my
> ivb or the bug reporters gm45). To fix up the very slow unplug issues
> we might want to fire up a 2nd detect cycle a few hundred ms after
> each hotplug. But for
This reverts
commit 8ec22b214d76773c9d89f4040505ce10f677ed9a
Author: Chris Wilson
Date: Fri May 11 18:01:34 2012 +0100
drm/i915/hdmi: Query the live connector status bit for G4x
and
commit b0ea7d37a8f63eeec5ae80b4a6403cfba01da02f
Author: Damien Lespiau
Date: Thu Dec 13 16:09:00 2012 +
On Mon, Feb 18, 2013 at 07:00:27PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> Some HDMI registers can be used for SDVO, so saying "HDMIB" should be
> the same as saying "SDVOB" for a given HW generation. This was not
> true and led to confusions and even a regression.
>
> Previously we
On Mon, Feb 18, 2013 at 07:00:26PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> Some (but not all) of the HDMI registers can be used to control sDVO,
> so those registers have two names. IMHO, when we're talking about
> HDMI, we really should call the HDMI control register "hdmi_reg"
> ins
On Tue, Feb 19, 2013 at 12:50:09PM +0200, Mika Kuoppala wrote:
> Signed-off-by: Mika Kuoppala
Queued for -next, thanks for the patch.
-Daniel
--
Daniel Vetter
Software Engineer, Intel Corporation
+41 (0) 79 365 57 48 - http://blog.ffwll.ch
___
Intel-gfx
On Tue, Feb 19, 2013 at 12:33:14PM +0200, Jani Nikula wrote:
> On Thu, 14 Feb 2013, Ben Widawsky wrote:
> > On Thu, Feb 14, 2013 at 10:42:11AM +0200, Jani Nikula wrote:
> >> It is customary to end sysfs attributes with a newline.
> >>
> >
> > As best I can tell, you are correct. Have you tested p
Signed-off-by: Mika Kuoppala
---
drivers/gpu/drm/i915/intel_display.c |3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/i915/intel_display.c
index 6eb3882..2b9ea56 100644
--- a/drivers/gpu/drm/i915/intel_display.c
+++ b/drivers/gpu/dr
Also,
References:
https://bugs.launchpad.net/ubuntu/+source/xserver-xorg-video-intel/+bug/1116587
-Chris
--
Chris Wilson, Intel Open Source Technology Centre
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lists.freedesktop.org/mailm
On Mon, Feb 18, 2013 at 05:16:06PM +0200, ville.syrj...@linux.intel.com wrote:
> From: Ville Syrjälä
>
> Use the gen3 logic for handling page flip interrupts on gen4.
We're just missing the other piece of the puzzle:
=0 cantiga:~/git/linux (master)$ git diff | cat
diff --git a/drivers/gpu/drm/i
On Tue, Feb 19, 2013 at 7:29 AM, William Brown wrote:
> I recently read your blog article at :
> http://blog.ffwll.ch/2013/02/neat-drmi915-stuff-for-39.html
>
> If you don't mind I have two questions regarding these changes.
>
> Do any of these fixes correct the black screen on dual gpu laptops wh
On Thu, 14 Feb 2013, Ben Widawsky wrote:
> On Thu, Feb 14, 2013 at 10:42:11AM +0200, Jani Nikula wrote:
>> It is customary to end sysfs attributes with a newline.
>>
>
> As best I can tell, you are correct. Have you tested powertop with this
> change? If not, can you?
Good point. Tested, and eye
On Tue, Feb 19, 2013 at 09:07:21AM +, Chris Wilson wrote:
> On Mon, Feb 18, 2013 at 07:08:47PM +0200, ville.syrj...@linux.intel.com wrote:
> > Here are the (hopefully) final versions of the page flip vs. GPU reset
> > fixes.
> >
> > They survive the i-g-t kms_flip flip-vs-modeset-vs-hang and
On Tue, Feb 19, 2013 at 3:01 AM, Stephen Rothwell wrote:
> On Fri, 15 Feb 2013 08:16:26 -0800 Jesse Barnes
> wrote:
>>
>> On Fri, 15 Feb 2013 10:30:16 +0100
>> Daniel Vetter wrote:
>>
>> > On Fri, Feb 15, 2013 at 3:37 AM, Stephen Rothwell
>> > wrote:
>> > >
>> > > After merging the drm-intel
On Tue, 19 Feb 2013, Chris Wilson wrote:
> On Tue, Feb 19, 2013 at 09:18:20AM +0200, Jani Nikula wrote:
>> Previously FBC disabling due to per-chip default was logged as being
>> disabled per module parameter. Distinguish between the two.
>>
>> v2: Don't even squawk in the debug log if FBC is exp
On Mon, Feb 18, 2013 at 07:00:22PM -0300, Paulo Zanoni wrote:
> From: Paulo Zanoni
>
> Otherwise, if the BIOS did anything wrong, our first I915_{WRITE,READ}
> will give us "unclaimed register" messages.
>
> V2: Even earlier.
Call it intel_early_sanitize_regs() as it seems like a function that
On Mon, Feb 18, 2013 at 09:18:31PM -0800, Ben Widawsky wrote:
> i915_reg.h is messy enough without the extra stuff.
>
> Signed-off-by: Ben Widawsky
Would be nice if we could just discard the rest. Since we can't (damn
you GEM/DRI1) can we just move them to i915_cmd.h?
I would also keep the BLT
On Tue, Feb 19, 2013 at 09:18:20AM +0200, Jani Nikula wrote:
> Previously FBC disabling due to per-chip default was logged as being
> disabled per module parameter. Distinguish between the two.
>
> v2: Don't even squawk in the debug log if FBC is explicitly disabled (Chris
> Wilson).
I'm still no
On Mon, Feb 18, 2013 at 07:08:47PM +0200, ville.syrj...@linux.intel.com wrote:
> Here are the (hopefully) final versions of the page flip vs. GPU reset fixes.
>
> They survive the i-g-t kms_flip flip-vs-modeset-vs-hang and
> flip-vs-panning-vs-hang tests, as well as stopping the rings while a
> fu
67 matches
Mail list logo
