Re: [Intel-gfx] [PATCH] drm/i915: tune down unknown unclaime write hsw debug message

2013-01-11 Thread Ben Widawsky
On Tue, 8 Jan 2013 11:07:03 +0100 Daniel Vetter wrote: > On Tue, Jan 8, 2013 at 10:32 AM, Chris Wilson > wrote: > > On Tue, 8 Jan 2013 09:33:57 +0100, Daniel Vetter > > wrote: > >> This could very well be caused by dirt left behind by the BIOS, so > >> tune it down to the debug level. > > > >

Re: [Intel-gfx] [PATCH 8/8] drm/i915: Hook PSR functionality

2013-01-11 Thread Daniel Vetter
On Fri, Jan 11, 2013 at 05:57:57PM -0200, Rodrigo Vivi wrote: > PSR must be enabled after transcoder and port are running. > And it is only available for HSW. > > Signed-off-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/intel_display.c | 15 +-- > 1 file changed, 13 insertions(+), 2

Re: [Intel-gfx] [PATCH 5/8] drm/i915: VBT Parsing for the PSR Feature Block for HSW

2013-01-11 Thread Daniel Vetter
On Fri, Jan 11, 2013 at 05:57:54PM -0200, Rodrigo Vivi wrote: > From: Shobhit Kumar > > Parse and store useful information in i915_dev_private > > Signed-off-by: Shobhit Kumar > Reviewed-by: Rodrigo Vivi > --- > drivers/gpu/drm/i915/i915_drv.h | 8 > drivers/gpu/drm/i915/intel_bio

Re: [Intel-gfx] [PATCH 0/8] Detect and deal with Interrupt 'Storms' from noisy Hotplug Lines.

2013-01-11 Thread Daniel Vetter
On Thu, Jan 10, 2013 at 10:02:38AM -0500, Egbert Eich wrote: > Despite the many attempts to fix the issue with noisy hotplug interrupt lines > we are still seeing systems that suffer from this: > Recently we encountered a rather large scale installation of Q35 systems > which was hit by this issue

Re: [Intel-gfx] [PATCH 2/8] drm/i915: Added SDP and VSC structures for handling PSR for eDP

2013-01-11 Thread Daniel Vetter
On Fri, Jan 11, 2013 at 05:57:51PM -0200, Rodrigo Vivi wrote: > From: Shobhit Kumar > > Signed-off-by: Sateesh Kavuri > > v2: Modified and corrected the structures to be more in line for > kernel coding guidelines and rebased the code on Paulo's DP patchset > > Signed-off-by: Shobhit Kumar >

[Intel-gfx] [PATCH 8/8] drm/i915: Hook PSR functionality

2013-01-11 Thread Rodrigo Vivi
PSR must be enabled after transcoder and port are running. And it is only available for HSW. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_display.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/drivers/g

[Intel-gfx] [PATCH 7/8] drm/i915: Added debugfs support for PSR Status

2013-01-11 Thread Rodrigo Vivi
From: Shobhit Kumar Added support for PSR entry counter and performance counters Signed-off-by: Shobhit Kumar v2: Add psr enabled yes/no info Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_debugfs.c | 34 ++ 1 file changed, 34 insertions(+) diff --

[Intel-gfx] [PATCH 6/8] drm/i915: Enable/Disable PSR on HSW

2013-01-11 Thread Rodrigo Vivi
From: Shobhit Kumar Added eDP PSR enable functionality. This includes setting the PSR configuration over AUX, sending SDP VSC DIP over the eDP PIPE config, enabling PSR in the sink via DPCD register and finally enabling PSR on the host. PSR works only in LPSP mode, so put the PIPE_DDI in DDIA alw

[Intel-gfx] [PATCH 5/8] drm/i915: VBT Parsing for the PSR Feature Block for HSW

2013-01-11 Thread Rodrigo Vivi
From: Shobhit Kumar Parse and store useful information in i915_dev_private Signed-off-by: Shobhit Kumar Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/i915_drv.h | 8 drivers/gpu/drm/i915/intel_bios.c | 30 ++ drivers/gpu/drm/i915/intel_bios.h | 20

[Intel-gfx] [PATCH 4/8] drm/i915: Setup EDP PSR AUX Registers

2013-01-11 Thread Rodrigo Vivi
From: Shobhit Kumar Signed-off-by: Shobhit Kumar Reviewed-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 49 + 1 file changed, 49 insertions(+) diff --git a/drivers/gpu/drm/i915/intel_dp.c b/drivers/gpu/drm/i915/intel_dp.c index f0224f8..c35caf1

Re: [Intel-gfx] [PATCH 1/8] drm/i915: Remove pch_rq_mask from struct drm_i915_private.

2013-01-11 Thread Daniel Vetter
On Thu, Jan 10, 2013 at 10:02:39AM -0500, Egbert Eich wrote: > This variable is only used locally in the irq postinstall > functions for ivybridge and ironlake. > > Signed-off-by: Egbert Eich Applied to dinq with a minor conflict resolved, thanks for the patch. -Daniel > --- > drivers/gpu/drm/i

[Intel-gfx] [PATCH 3/8] drm/i915: Read the EDP DPCD and PSR Capability

2013-01-11 Thread Rodrigo Vivi
From: Shobhit Kumar Signed-off-by: Shobhit Kumar v2: reuse of just created is_edp_psr and put it at right place. Signed-off-by: Rodrigo Vivi --- drivers/gpu/drm/i915/intel_dp.c | 12 drivers/gpu/drm/i915/intel_drv.h | 1 + include/drm/drm_dp_helper.h | 1 + 3 files change

[Intel-gfx] [PATCH 2/8] drm/i915: Added SDP and VSC structures for handling PSR for eDP

2013-01-11 Thread Rodrigo Vivi
From: Shobhit Kumar Signed-off-by: Sateesh Kavuri v2: Modified and corrected the structures to be more in line for kernel coding guidelines and rebased the code on Paulo's DP patchset Signed-off-by: Shobhit Kumar v3: removing unecessary identation at DP_RECEIVER_CAP_SIZE Signed-off-by: Rodr

[Intel-gfx] [PATCH 1/8] drm/i915: Added eDP PSR registers

2013-01-11 Thread Rodrigo Vivi
From: Shobhit Kumar v2: Add support for psr perfromance counter register and corrected register names to reflect they are PSR registers. Also added bit definitions for the registers v3: Add missing CDCLK_FREQ register needed for PSR enabling. Signed-off-by: Sateesh Kavuri Signed-off-by: Shobhi

[Intel-gfx] [PATCH 0/8] Enable eDP PSR funcionality at HSW

2013-01-11 Thread Rodrigo Vivi
PSR is an eDP feature that allows power saving even with static image at eDP screen. Shobit Kumar has implemented this patch series some time ago, but had no eDP panel with PSR capability to test them. I could test and verify that this series fully identify PSR capability and enables it at HSW

Re: [Intel-gfx] i915_hangcheck_hung problem with 3.8-rc2+ (Linus's latest tree)

2013-01-11 Thread Daniel Vetter
On Fri, Jan 11, 2013 at 6:26 PM, Nikola Pajkovsky wrote: > bug still kicking even w/ (drm/i915: Revert shrinker changes from "Track > unbound pages") Could be a different bug, can you please attach the error_state somewhere? -Daniel -- Daniel Vetter Software Engineer, Intel Corporation +41 (0) 7

Re: [Intel-gfx] [PATCH] drm/i915: fix FORCEWAKE posting reads

2013-01-11 Thread Ben Widawsky
On Fri, Jan 11, 2013 at 09:53:53AM +0200, Jani Nikula wrote: > We stopped reading FORCEWAKE for posting reads in > > commit 8dee3eea3ccd3b6c00a8d3a08dd715d6adf737dd > Author: Ben Widawsky > Date: Sat Sep 1 22:59:50 2012 -0700 > > drm/i915: Never read FORCEWAKE > > and started using someth

Re: [Intel-gfx] [PATCH gen4asm 1/3] build: Don't use automake's maintainer modey

2013-01-11 Thread Damien Lespiau
On Fri, Jan 11, 2013 at 09:41:05AM +0100, Daniel Vetter wrote: > What about moving gen4asm into a subdir of i-g-t? With git filter-branch > we could even retain the entire history > -Daniel I'm not against doing that, it'll shed more light/review/etc on the assembler (I assume patches would h

Re: [Intel-gfx] [PATCH gen4asm 1/3] build: Don't use automake's maintainer mode

2013-01-11 Thread Daniel Vetter
On Thu, Jan 10, 2013 at 10:23:31PM +, Damien Lespiau wrote: > This is pretty much deprecated and automake includes a better equivalent > when maintainer's mode is not used. > > Signed-off-by: Damien Lespiau What about moving gen4asm into a subdir of i-g-t? With git filter-branch we could eve