Dear Kenneth,
thanks for the patch.
Am Freitag, den 05.10.2012, 17:46 -0700 schrieb Kenneth Graunke:
> Commit bf97b276ca04
Could you please paste the date, author and commit summary of this
commit too? At least I cannot memorize hashes that well and having the
summary pasted would give me enou
On 05.10.12 15:37, intel-gfx-requ...@lists.freedesktop.org wrote:
Today's Topics:
1. [RFC 0/4] drm: add raw monotonic timestamp support (Imre Deak)
2. [RFC 1/4] time: export getnstime_raw_and_real for DRM (Imre Deak)
3. [RFC 2/4] drm: make memset/calloc for _vblank_time more
Subject: Re: [RFC 4/4] drm: add support for raw monotonic vblank
timestamps
Message-ID: <1349446447.17758.73.camel@thor.local>
Content-Type: text/plain; charset="ISO-8859-1"
On Fre, 2012-10-05 at 16:59 +0300, Imre Deak wrote:
On Fri, 2012-10-05 at 15:55 +0200, Michel D?nzer wrote:
On
On Fri, 2012-10-05 at 18:09 -0600, Rob Clark wrote:
> On Fri, Oct 5, 2012 at 5:41 PM, Imre Deak wrote:
> > On Fri, 2012-10-05 at 16:18 -0600, Rob Clark wrote:
> >> On Fri, Oct 5, 2012 at 7:37 AM, Imre Deak wrote:
> >> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> >> > b/drivers/gpu/drm/i
Commit bf97b276ca04 accidentally set bit 5 in 3D_CHICKEN, which has
nothing to do with clipping. This patch changes it to be set in
3D_CHICKEN3, where it belongs.
The game "Dante" demonstrates random clipping issues when guardband
clipping is enabled and bit 5 of 3D_CHICKEN3 isn't set. So the
wo
On Fri, 2012-10-05 at 16:18 -0600, Rob Clark wrote:
> On Fri, Oct 5, 2012 at 7:37 AM, Imre Deak wrote:
> > diff --git a/drivers/gpu/drm/i915/intel_display.c
> > b/drivers/gpu/drm/i915/intel_display.c
> > index ab1ef15..056e810 100644
> > --- a/drivers/gpu/drm/i915/intel_display.c
> > +++ b/driver
Imre Deak writes:
> This is needed to make applications depending on vblank/page flip
> timestamps independent of time ajdustments.
>
> I've tested these with an updated intel-gpu-test/flip_test and will send
> the update for that once there's no objection about this patchset.
>
> The patchset is
On Fri, 05 Oct 2012, Chris Wilson wrote:
> By using round_jiffies() we can align the wakeup of our worker to the
> nearest second in order to batch wakeups and reduce system load, which
> is useful for unimportant coarse tasks like our retire_requests.
Is there a reason not to just use INIT_DELAY
On Fri, Oct 5, 2012 at 9:36 AM, Imre Deak wrote:
> Needed by the upcoming DRM raw monotonic timestamp support.
I just had a quick look at driver/input/evdev.c, since evdev devices
did a similar change recently to allow evdev timestamp from the
monotonic clock. They're using a different time API:
By using round_jiffies() we can align the wakeup of our worker to the
nearest second in order to batch wakeups and reduce system load, which
is useful for unimportant coarse tasks like our retire_requests.
v2: round_jiffies_relative() already returns the relative timeout value,
so no need to incor
round_jiffies() aligns the wakeup time to the nearest second in order to
batch wakeups and reduce system load, which is useful for unimportant
coarse timers like our hangcheck.
v2: round_jiffies_relative() returns the relative jiffie value, whereas
we need the absolute value for the timer.
Sugges
On Fri, 05 Oct 2012 08:18:17 -0700, Arjan van de Ven
wrote:
> On 10/5/2012 6:53 AM, Chris Wilson wrote:
> > By using round_jiffies() we can align the wakeup of our worker to the
> > nearest second in order to batch wakeups and reduce system load, which
> > is useful for unimportant coarse tasks l
On Fri, 05 Oct 2012 18:40:05 +0300, Jani Nikula
wrote:
> On Fri, 05 Oct 2012, Chris Wilson wrote:
> > round_jiffies() aligns the wakeup time to the nearest second in order to
> > batch wakeups and reduce system load, which is useful for unimportant
> > coarse timers like our hangcheck.
> >
> > S
On Fri, 05 Oct 2012, Chris Wilson wrote:
> round_jiffies() aligns the wakeup time to the nearest second in order to
> batch wakeups and reduce system load, which is useful for unimportant
> coarse timers like our hangcheck.
>
> Suggested-by: Arjan van de Ven
> Signed-off-by: Chris Wilson
> Cc: A
From: Paulo Zanoni
So WARN in case they're not. It also does not make any sense to
wait_for_vblank at this point.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_display.c | 7 +--
1 file changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
From: Paulo Zanoni
And also properly wait for its idle bit.
You may notice that DDI_BUF_CTL is enabled in .enable but disabled in
.post_disable instead of .disable. Yes, the mode set sequence is not
exactly symmetrical, but let's assume the spec is correct unless we
can prove it's wrong.
Signed
From: Paulo Zanoni
Just set the only bit we need, everything else is either ignored on
HDMI or should be set to zero.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_ddi.c | 6 +-
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/dri
From: Paulo Zanoni
Problems with the previous code:
- HDMI just uses WRPLL1 for everything, so dual head cases might not
work sometimes.
- At encoder->mode_set we just write the PLL register without doing
any kind of check (e.g., check if the PLL is already being used).
- There is n
From: Paulo Zanoni
It's a copy of ironlake_set_pipeconf with 2 differences:
- There is no BPC field to set.
- The interlaced mask is now 2 bits instead of 3.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/i915_reg.h | 1 +
drivers/gpu/drm/i915/intel_display.c | 27 +
From: Paulo Zanoni
On ironlake_crtc_mode_set, WARN if not using IBX or CPT.
On haswell_crtc_mode_set, only run IBX/CPT code on IBX/CPT. I am still
not sure whether IBX/CPT will be possible with a Haswell CPU, so leave
the code there for now and put a WARN in case we spot it.
Signed-off-by: Paul
From: Paulo Zanoni
It's just a copy of ironlake_crtc_mode_set.
Signed-off-by: Paulo Zanoni
---
drivers/gpu/drm/i915/intel_display.c | 187 ++-
1 file changed, 186 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_display.c
b/drivers/gpu/drm/
From: Paulo Zanoni
Previously we were enabling it at mode_set but never disabling. Let's
follow the mode set sequence.
Signed-off-by: Paulo Zanoni
Reviewed-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_ddi.c | 37
drivers/gpu/drm/i915/intel_display
From: Paulo Zanoni
And the right time is exactly after/before changing PIPE_CONF. See the
documentation about the mode set sequence.
This code is not inside any encoder-specific callback because
DDI_FUNC_CTL is part of the pipe, so it is used by all encoders.
Signed-off-by: Paulo Zanoni
Review
From: Paulo Zanoni
Right now, we're trying to enable LCPLL at every mode set, but we're
never disabling it. Also, we really don't want to be disabling LCPLL
since it requires a very complex disable/enable sequence. This
register should really be set by the BIOS and we shouldn't be touching
it. St
From: Paulo Zanoni
Hi
This is a resend of the first 10 patches of the 47-patch series sent a few days
ago, with comments received on IRC and email applied.
Main changes:
- Patch 1 rewritten. Damien pointed some things and I also had a conversation
with an engineer and concluded that we sh
On Fri, 2012-10-05 at 16:14 +0200, Michel Dänzer wrote:
> On Fre, 2012-10-05 at 16:59 +0300, Imre Deak wrote:
> > On Fri, 2012-10-05 at 15:55 +0200, Michel Dänzer wrote:
> > > On Fre, 2012-10-05 at 16:37 +0300, Imre Deak wrote:
> > > > In practice we never want the timestamps for vblank and page
On Fri, 2012-10-05 at 15:55 +0200, Michel Dänzer wrote:
> On Fre, 2012-10-05 at 16:37 +0300, Imre Deak wrote:
> > In practice we never want the timestamps for vblank and page flip events
> > to be affected by time adjustments, so in addition to the gettimeofday
> > timestamps we used so far add su
round_jiffies() aligns the wakeup time to the nearest second in order to
batch wakeups and reduce system load, which is useful for unimportant
coarse timers like our hangcheck.
Suggested-by: Arjan van de Ven
Signed-off-by: Chris Wilson
Cc: Arjan van de Ven
---
drivers/gpu/drm/i915/i915_drv.h |
By using round_jiffies() we can align the wakeup of our worker to the
nearest second in order to batch wakeups and reduce system load, which
is useful for unimportant coarse tasks like our retire_requests.
Suggested-by: Arjan van de Ven
Signed-off-by: Chris Wilson
Cc: Arjan van de Ven
---
driv
2012/10/5 Damien Lespiau :
> From: Damien Lespiau
>
> There's is another register (a read only, so no harm done) at 0x42020 on
> Haswell GPUs. Let's just remove the write from the copy&paste that
> introduced haswell_init_clock_gating().
>
> A note for the interested reader, it does seem we have a
In practice we never want the timestamps for vblank and page flip events
to be affected by time adjustments, so in addition to the gettimeofday
timestamps we used so far add support for raw monotonic timestamps.
For backward compatibility use flags to select between the old and new
timestamp forma
The timestamp is used here for handling the timeout case, so we don't
want it to be affected by time adjustments.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/drm_irq.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm
Using sizeof(*var) instead of sizeof(var_type) allows changing var_type
w/o breaking callers that depend on the size.
Signed-off-by: Imre Deak
---
drivers/gpu/drm/drm_irq.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/drm_irq.c b/drivers/gpu/drm/drm_
Needed by the upcoming DRM raw monotonic timestamp support.
Signed-off-by: Imre Deak
---
kernel/time/timekeeping.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/time/timekeeping.c b/kernel/time/timekeeping.c
index d3b91e7..073d262 100644
--- a/kernel/time/timekeep
This is needed to make applications depending on vblank/page flip
timestamps independent of time ajdustments.
I've tested these with an updated intel-gpu-test/flip_test and will send
the update for that once there's no objection about this patchset.
The patchset is based on danvet's dinq branch w
On Thu, Oct 4, 2012 at 7:02 PM, Paulo Zanoni wrote:
> It would be nice if we could volunteer someone to check the other
> workarounds on the same function. The registers may exist but the WAs
> may not be needed anymore.
I've done a pass this morning and with the new patch posted list, I
think we
On Fri, Oct 5, 2012 at 1:53 PM, Paulo Zanoni wrote:
> 2012/10/4 Lespiau, Damien :
>> On Tue, Oct 2, 2012 at 9:51 PM, Paulo Zanoni wrote:
>>> @@ -5356,8 +5361,6 @@ static int haswell_crtc_mode_set(struct drm_crtc
>>> *crtc,
>>>
>>> haswell_set_pipeconf(crtc, adjusted_mode, dither);
>>>
>>
2012/10/4 Lespiau, Damien :
> On Tue, Oct 2, 2012 at 9:51 PM, Paulo Zanoni wrote:
>> @@ -5356,8 +5361,6 @@ static int haswell_crtc_mode_set(struct drm_crtc *crtc,
>>
>> haswell_set_pipeconf(crtc, adjusted_mode, dither);
>>
>> - intel_wait_for_vblank(dev, pipe);
>> -
>
> I guess this
From: Damien Lespiau
There's is another register (a read only, so no harm done) at 0x42020 on
Haswell GPUs. Let's just remove the write from the copy&paste that
introduced haswell_init_clock_gating().
A note for the interested reader, it does seem we have a duplication of
the 0x42020 register de
39 matches
Mail list logo
