Using the extracted INSTDONE reading, and our new register definitions,
update our hangcheck and error collection to use it.
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_debugfs.c | 8 ---
drivers/gpu/drm/i915/i915_drv.h | 5 ++--
drivers/gpu/drm/i915/i915_irq.c | 47 +
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_reg.h | 6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
index 948ede9..b290221 100644
--- a/drivers/gpu/drm/i915/i915_reg.h
+++ b/drivers/gpu/drm/i915
INSTDONE is used in many places, and it varies from generation to
generation. This provides a good reason for us to extract the logic to
read the relevant information.
The patch has no functional change. It's prep for some new stuff.
Signed-off-by: Ben Widawsky
---
drivers/gpu/drm/i915/i915_irq
Looking at some IVB error states this was very confusing. Upon looking
at updated docs, it appears we've been doing the wrong thing all along.
They're not terribly well tested yet, but hopefully they're trivial
enough that I didn't mess them up (unlikely!).
Ben Widawsky (3):
drm/i915: Extract r
On Wed, Aug 15, 2012 at 08:05:14PM +0300, Imre Deak wrote:
> On Wed, Aug 15, 2012 at 6:27 AM, Wang, Xingchao
> wrote:
> > Hi Daniel/Imre,
> >
> > This revised version changelog:
> > - add " Wait for 1 vertical blank" after enable audio output port
> > - configure pipe related transcoder instead
On Tue, Aug 14, 2012 at 02:35:14PM -0700, Ben Widawsky wrote:
> After reset we unconditionally reinitialize lists. If the context switch
> hasn't yet completed before the suspend, the default context object will
> end up on lists that are going to go away when we resume.
>
> The patch forces the c
On Wed, Aug 15, 2012 at 06:38:10PM -0400, Chun-Yu Shei wrote:
> Hi,
>
> I recently upgraded to a 27" monitor (2560x1440) from a 23" one
> (1920x1080), and had to switch to Windows because the new monitor is
> unusable in Linux. Today, about a month later, I decided to give
> Linux another try, si
Hi,
I recently upgraded to a 27" monitor (2560x1440) from a 23" one
(1920x1080), and had to switch to Windows because the new monitor is
unusable in Linux. Today, about a month later, I decided to give Linux
another try, since there have been several updates to the Intel graphics
driver sinc
On Mon, Aug 13, 2012 at 09:34:45PM -0700, Keith Packard wrote:
> This is left over from the old PLL sharing code and isn't useful now
> that PLLs are shared when possible.
>
> Signed-off-by: Keith Packard
Queued for -next, thanks for the patch. I'll hold off a bit on the others
until it's a bit c
On Wed, Aug 15, 2012 at 07:42:15PM +0100, Chris Wilson wrote:
> On Wed, 15 Aug 2012 19:23:25 +0100, Damien Lespiau
> wrote:
> > From: Damien Lespiau
> >
> > New-ish devices have 3 pipes, so let's not just hardcode 2 but use the
> > for_each_pipe() macro and make struct intel_display_error_state
On Wed, Aug 15, 2012 at 03:36:34PM +0100, James Bottomley wrote:
> On Wed, 2012-08-15 at 16:05 +0200, Paul Menzel wrote:
> > Am Mittwoch, den 15.08.2012, 10:41 +0200 schrieb Daniel Vetter:
> > > between 3.5 and 3.6 in a merge commit! So rc6 behaviour with the
> > > current setting seems to be h
On Mon, Jul 16, 2012 at 12:50 PM, Daniel Vetter wrote:
> On Wed, Jul 04, 2012 at 09:52:11AM +0200, Daniel Vetter wrote:
> > On Tue, Jul 03, 2012 at 02:16:42PM -0700, Stéphane Marchesin wrote:
> > > The up and down thresholds are very asymetric, so it is possible
> > > to have a case where a spike
On Wed, 15 Aug 2012 08:09:47 -0700, Grant wrote:
> > I'm using a Dell XPS 13 laptop on Gentoo and if I use:
> >
> > Option "AccelMethod" "sna"
> > Option "TearFree" "true"
> >
> > my video tearing problem disappears, but if I close my laptop lid for
> > a few minutes, it comes back up with a black
On Wed, 15 Aug 2012 19:23:25 +0100, Damien Lespiau
wrote:
> From: Damien Lespiau
>
> New-ish devices have 3 pipes, so let's not just hardcode 2 but use the
> for_each_pipe() macro and make struct intel_display_error_state is big
> enough.
>
> V2: Also add the number of pipes emitted (Chris Wil
From: Damien Lespiau
New-ish devices have 3 pipes, so let's not just hardcode 2 but use the
for_each_pipe() macro and make struct intel_display_error_state is big
enough.
V2: Also add the number of pipes emitted (Chris Wilson)
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_displ
On 2012-08-15 02:14, Chris Wilson wrote:
On Tue, 14 Aug 2012 14:35:13 -0700, Ben Widawsky
wrote:
Clear the cached instdone state to match what we expect from
hardware
and prevent us from comparing stale values.
Actually, clearing the state is not the same as setting idle state.
There would be
On Wed, Aug 15, 2012 at 6:27 AM, Wang, Xingchao wrote:
> Hi Daniel/Imre,
>
> This revised version changelog:
> - add " Wait for 1 vertical blank" after enable audio output port
> - configure pipe related transcoder instead of operate all transcoders
> blindly
Thanks for the explanation. I'd ha
On Wed, 15 Aug 2012 17:57:36 +0100, Damien Lespiau
wrote:
> From: Damien Lespiau
>
> New-ish devices have 3 pipes, so let's not just hardcode 2 but use the
> for_each_pipe() macro and make struct intel_display_error_state is big
> enough.
Also add the number of pipes emitted to the error state
From: Damien Lespiau
New-ish devices have 3 pipes, so let's not just hardcode 2 but use the
for_each_pipe() macro and make struct intel_display_error_state is big
enough.
Signed-off-by: Damien Lespiau
---
drivers/gpu/drm/i915/intel_display.c | 11 ++-
1 files changed, 6 insertions(+)
On 2012-08-15 02:18, Chris Wilson wrote:
On Tue, 14 Aug 2012 14:35:15 -0700, Ben Widawsky
wrote:
In order to make the HW state CCID match with what we think it
should
be, we must order a switch to the default context.
The really sad thing here is that the switch can potentially fail,
and
as
> I'm using a Dell XPS 13 laptop on Gentoo and if I use:
>
> Option "AccelMethod" "sna"
> Option "TearFree" "true"
>
> my video tearing problem disappears, but if I close my laptop lid for
> a few minutes, it comes back up with a black screen, although I can
> get my session back if I switch to VT1
On Sun, Aug 12, 2012 at 06:15:48PM +0200, Daniel Vetter wrote:
> Yet again the too close relationship between the fb helper and the
> crtc helper code strikes. This time around the fb helper resets all
> encoder->crtc pointers to NULL before starting to set up it's own
> mode. Which is total bulloc
Am Mittwoch, den 15.08.2012, 10:41 +0200 schrieb Daniel Vetter:
> James Bottomley reported [1] a massive power regression, due to the
> enabling of semaphores by default in 3.5. A workaround for him is to
> again disable semaphores. And indeed, his system has a very hard time
> to entre rc6 with se
I'm using a Dell XPS 13 laptop on Gentoo and if I use:
Option "AccelMethod" "sna"
Option "TearFree" "true"
my video tearing problem disappears, but if I close my laptop lid for
a few minutes, it comes back up with a black screen, although I can
get my session back if I switch to VT1 and then back
On Tue, 14 Aug 2012 14:35:15 -0700, Ben Widawsky wrote:
> In order to make the HW state CCID match with what we think it should
> be, we must order a switch to the default context.
>
> The really sad thing here is that the switch can potentially fail, and
> as such we have to assume contexts no l
On Tue, 14 Aug 2012 14:35:13 -0700, Ben Widawsky wrote:
> Clear the cached instdone state to match what we expect from hardware
> and prevent us from comparing stale values.
>
> Actually, clearing the state is not the same as setting idle state.
> There would be a known state of idle (ie. all uni
On Wed, Aug 15, 2012 at 04:13:36PM +0800, Wang Xingchao wrote:
> This patch enabled intel_audio_dump to support Haswell platform. Haswell has
> some registers differences comprared with previous platforms.
>
> Changes since V1:
> - fix compile warnings
> - remove HBR bits show, it doesnot exist u
James Bottomley reported [1] a massive power regression, due to the
enabling of semaphores by default in 3.5. A workaround for him is to
again disable semaphores. And indeed, his system has a very hard time
to entre rc6 with semaphores enabled.
Ben Widawsky run around with a kill-a-watt a lot and
This patch enabled intel_audio_dump to support Haswell platform. Haswell has
some registers differences comprared with previous platforms.
Changes since V1:
- fix compile warnings
- remove HBR bits show, it doesnot exist under Haswell
Changes since V2:
- fix comments style
This is output of int
there're three Ports B/C/D used for selection by each transcoder A/B/C.
Signed-off-by: Wang Xingchao
---
tools/intel_audio_dump.c |6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/tools/intel_audio_dump.c b/tools/intel_audio_dump.c
index 077e096..8a0f6ee 100644
--- a/t
Add Haswell audio registers definition and dump support.
Signed-off-by: Wang Xingchao
---
tools/intel_audio_dump.c | 584 ++
1 file changed, 584 insertions(+)
diff --git a/tools/intel_audio_dump.c b/tools/intel_audio_dump.c
index 8a0f6ee..8b9da30 100
Hi Fengguang,
> -Original Message-
> From: Wu, Fengguang
> Sent: Wednesday, August 15, 2012 4:01 PM
> To: Wang, Xingchao
> Cc: intel-gfx@lists.freedesktop.org; dan...@ffwll.ch; Fu, Michael;
> zhen...@linux.intel.com
> Subject: Re: [PATCH V2 2/2] intel_audio_dump: add Haswell audio dump
> s
Xingchao,
Have you tested the patch in haswell as well as in older hardwares?
In general it would be better if you have run this tool for some time
on several hardwares -- that's the best way to smooth out possible bugs.
> +/*Haswell registers*/
Please fix the style to (ditto for lots of other c
Thanks for catching this!
Acked-by: Fengguang Wu
On Tue, Aug 07, 2012 at 04:52:49PM +0800, Wang Xingchao wrote:
> There're three Ports B/C/D used for selection by each transcoder A/B/C.
>
> Signed-off-by: Wang Xingchao
> ---
> tools/intel_audio_dump.c |6 +++---
> 1 file changed, 3 insert
Hi all,
Any comments about this version patch series?
I wonder if it's helpful for you...:)
Any suggestions are highly appreciated.
Thanks
--xingchao
> -Original Message-
> From: Wang, Xingchao
> Sent: Tuesday, August 07, 2012 4:53 PM
> To: intel-gfx@lists.freedesktop.org
> Cc: dan...@f
Hi,
Some update related to this warning.
Ironlake_crtc_dpms() will enable/disable crtc which pipe was enabled/disabled
there.
Ironlake_crtc_dpms(DRM_MODE_DPMS_OFF) was called before the warning and crtc
was disabled, that causes intel_wait_for_vblank() timeout and some assertions.
I think it's
36 matches
Mail list logo
