Re: [Intel-gfx] Find bugs in i915 driver

2012-08-12 Thread Xu, Anhua
Sorry, Deniel/Greg, late response for your email because of a busy work last work. I will response to you guys ASAP :), below is the updated patch: >From 33eb95a3a711b2354985361ff208ea150a5ba235 Mon Sep 17 00:00:00 2001 From: Xu Anhua Date: Tue, 31 Jul 2012 17:16:50 +0800 Subject: [PATCH] drm

Re: [Intel-gfx] [PATCH] intel: Use VG_CLEAR on the context destroy ioctl as well.

2012-08-12 Thread Eric Anholt
Kenneth Graunke writes: Reviewed-by: Eric Anholt pgpynlVfLMSOQ.pgp Description: PGP signature ___ Intel-gfx mailing list Intel-gfx@lists.freedesktop.org http://lists.freedesktop.org/mailman/listinfo/intel-gfx

Re: [Intel-gfx] v3.5 Oops in i2c_algo_bit.c:bit_xfer+0x23/0x870: i915 or i2c?

2012-08-12 Thread Ben Widawsky
On 2012-08-08 21:50, George Spelvin wrote: I'm trying to run a v3.5 kernel (plus some -stable patches from Ted Ts'o) on an Ubuntu system. Things are generally working except for the following Oops on each boot, which prevents the graphics system from loading. [ 36.187972] [drm] Initialized

[Intel-gfx] [PATCH] intel: Use VG_CLEAR on the context destroy ioctl as well.

2012-08-12 Thread Kenneth Graunke
Otherwise pad appears uninitialized and valgrind grumbles. Signed-off-by: Kenneth Graunke --- intel/intel_bufmgr_gem.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/intel/intel_bufmgr_gem.c b/intel/intel_bufmgr_gem.c index a170813..795c1a8 100644 --- a/intel/intel_bufmgr_gem.c +++ b/inte

[Intel-gfx] [PATCH] drm/i915: drop intel_encoder argument to load_detect_pipe functions

2012-08-12 Thread Daniel Vetter
Since it's redundant - we can get the attached encoder in the functions themselves. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_crt.c | 6 ++ drivers/gpu/drm/i915/intel_display.c | 16 drivers/gpu/drm/i915/intel_drv.h | 6 ++ drivers/gpu/drm/i91

[Intel-gfx] [PATCH] drm/i915: add missing gen2 pipe A quirk entries

2012-08-12 Thread Daniel Vetter
For some odd reason we've missed i830 and a i855 variant. Also kill the two now redundant i830 entries. v2: Don't add the missing 855 id to the pipe A quirk list, we seem to lack justification for it. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 7 +-- 1 file chan

Re: [Intel-gfx] [PATCH 0/7] modeset rework prep patches

2012-08-12 Thread Daniel Vetter
On Sun, Aug 12, 2012 at 09:12:14PM +0100, Chris Wilson wrote: > On Sun, 12 Aug 2012 22:01:02 +0200, Daniel Vetter wrote: > > On Sun, Aug 12, 2012 at 08:47:56PM +0100, Chris Wilson wrote: > > > > drm/i915: simplify dvo dpms interface > > > > > > This just looks like churn for churn's sake? The c

[Intel-gfx] [PATCH] drm/i915: reorder edp disabling to fix ivb MacBook Air

2012-08-12 Thread Daniel Vetter
eDP is tons of fun. It turns out that at least the new MacBook Air 5,1 model absolutely doesn't like the new force vdd dance we've introduced in commit 6cb49835da0426f69a2931bc2a0a8156344b0e41 Author: Daniel Vetter Date: Sun May 20 17:14:50 2012 +0200 drm/i915: enable vdd when switching of

Re: [Intel-gfx] Macbook Air 2012

2012-08-12 Thread Daniel Wagner
I've pointed you at the wrong bug report unfortunately. This one is the right one: https://bugzilla.kernel.org/show_bug.cgi?id=45671 Please test the "patch v3" on that bug. Applied v3 and I see for a short time kernel messages, then the screen goes black, then I think 2 times the backlight goe

Re: [Intel-gfx] [PATCH 0/7] modeset rework prep patches

2012-08-12 Thread Chris Wilson
On Sun, 12 Aug 2012 22:01:02 +0200, Daniel Vetter wrote: > On Sun, Aug 12, 2012 at 08:47:56PM +0100, Chris Wilson wrote: > > On Sun, 12 Aug 2012 19:27:07 +0200, Daniel Vetter > > wrote: > > > drm/i915: prepare load-detect pipe code for dpms changes > > > > It is not immediately obvious from t

Re: [Intel-gfx] [PATCH 0/7] modeset rework prep patches

2012-08-12 Thread Daniel Vetter
On Sun, Aug 12, 2012 at 08:47:56PM +0100, Chris Wilson wrote: > On Sun, 12 Aug 2012 19:27:07 +0200, Daniel Vetter > wrote: > > Hi all, > > > > I've noticed that a few prep patches of the modeset rework series haven't > > been > > merged nor reviewed yet, so I've split them out in this resend. M

Re: [Intel-gfx] [PATCH 0/7] modeset rework prep patches

2012-08-12 Thread Chris Wilson
On Sun, 12 Aug 2012 19:27:07 +0200, Daniel Vetter wrote: > Hi all, > > I've noticed that a few prep patches of the modeset rework series haven't been > merged nor reviewed yet, so I've split them out in this resend. Mostly concern > really old gen2 stuff (dvo + pipe A quirk), but little patches

Re: [Intel-gfx] [PATCH] agp/intel, drm/i915: Use a write-combining map for updating PTEs

2012-08-12 Thread Chris Wilson
On Sun, 12 Aug 2012 17:01:08 +0100, Chris Wilson wrote: > On Sun, 12 Aug 2012 17:47:46 +0200, Daniel Vetter wrote: > > On Sun, Aug 12, 2012 at 12:04:39PM +0100, Chris Wilson wrote: > > > In order to be able to ioremap_wc the GTT space, we need to remove the > > > conflicting pci_iomap from drm/i

Re: [Intel-gfx] 3.6-rc1 breaks my laptop graphics (intel)

2012-08-12 Thread Daniel Vetter
On Sun, Aug 12, 2012 at 11:48:02AM -0700, Greg KH wrote: > On Sun, Aug 12, 2012 at 11:33:05AM -0700, Greg KH wrote: > > On Sun, Aug 12, 2012 at 08:25:31PM +0200, Daniel Vetter wrote: > > > On Sun, Aug 12, 2012 at 11:21:57AM -0700, Greg KH wrote: > > > > Hi Daniel. > > > > > > > > The 3.6-rc1 kerne

Re: [Intel-gfx] 3.6-rc1 breaks my laptop graphics (intel)

2012-08-12 Thread Greg KH
On Sun, Aug 12, 2012 at 11:33:05AM -0700, Greg KH wrote: > On Sun, Aug 12, 2012 at 08:25:31PM +0200, Daniel Vetter wrote: > > On Sun, Aug 12, 2012 at 11:21:57AM -0700, Greg KH wrote: > > > Hi Daniel. > > > > > > The 3.6-rc1 kernel breaks my laptop, booting to a black screen when the > > > i915 dri

Re: [Intel-gfx] Macbook Air 2012

2012-08-12 Thread Daniel Wagner
On 08/12/2012 08:29 PM, Daniel Vetter wrote: On Sun, Aug 12, 2012 at 07:45:05PM +0200, Daniel Wagner wrote: Hi Daniel, On 08/11/2012 11:14 PM, Daniel Vetter wrote: On Sat, Aug 11, 2012 at 04:48:15PM +0200, Paul Menzel wrote: Am Samstag, den 11.08.2012, 16:05 +0200 schrieb Daniel Wagner: I i

[Intel-gfx] [PATCH 7/7] drm/i915: extract ironlake_fdi_pll_disable

2012-08-12 Thread Daniel Vetter
Simply to make the ilk+ crtc disable path clearer and more symmetric with the enable function. Also switch to intel_crtc for the enable function. Signed-Off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 57 +--- 1 file changed, 33 insertions(+), 24

[Intel-gfx] [PATCH 6/7] drm/i915: kill a few unused things in dev_priv

2012-08-12 Thread Daniel Vetter
... and move a few others only used by i915_dma.c into the dri1 dungeon. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/i915_dma.c | 22 +++--- drivers/gpu/drm/i915/i915_drv.h | 13 ++--- 2 files changed, 17 insertions(+), 18 deletions(-) diff --git a/drivers/gpu/

[Intel-gfx] [PATCH 5/7] drm/i915: simplify dvo dpms interface

2012-08-12 Thread Daniel Vetter
All dvo drivers only support 2 dpms states, and our dvo driver even switches of the dvo port for anything else than DPMS_ON. Hence ditch this complexity and simply use bool enable. While reading through this code I've noticed that the mode_set function of ch7017 is a bit peculiar - it disable the

[Intel-gfx] [PATCH 4/7] drm/i915: prepare load-detect pipe code for dpms changes

2012-08-12 Thread Daniel Vetter
A few things need adjustement: - Change the dpms state by calling the dpms connector function and not some crtc helper internal callbacks. Otherwise this will break once we switch to our own dpms handling. - Instead of tracking and restoring intel_crtc->dpms_mode use the connector's dpms vari

[Intel-gfx] [PATCH 3/7] drm/i915: rip out the overlay pipe A workaround

2012-08-12 Thread Daniel Vetter
Now that all affected i830M systems have the pipe A quirk set, we don't need to do any special dances in the overlay code any longer. And reading through the code I'm rather dubios that it actually does what it claims to do ... As a nice benefit this rips out a users of the crtc helper dpms callba

[Intel-gfx] [PATCH 2/7] drm/i915/ns2501: kill pll A enabling hack

2012-08-12 Thread Daniel Vetter
With the pipe A quirk properly fixed up for i830M, this shouldn't be required any longer. Signed-Off-by: Daniel Vetter --- drivers/gpu/drm/i915/dvo_ns2501.c| 7 --- drivers/gpu/drm/i915/intel_display.c | 2 +- 2 files changed, 1 insertion(+), 8 deletions(-) diff --git a/drivers/gpu/drm/

[Intel-gfx] [PATCH 1/7] drm/i915: add missing gen2 pipe A quirk entries

2012-08-12 Thread Daniel Vetter
For some odd reason we've missed i830 and a i855 variant. Also kill the two now redundant i830 entries. Signed-off-by: Daniel Vetter --- drivers/gpu/drm/i915/intel_display.c | 8 ++-- 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/drivers/gpu/drm/i915/intel_display.c b/driver

[Intel-gfx] [PATCH 0/7] modeset rework prep patches

2012-08-12 Thread Daniel Vetter
Hi all, I've noticed that a few prep patches of the modeset rework series haven't been merged nor reviewed yet, so I've split them out in this resend. Mostly concern really old gen2 stuff (dvo + pipe A quirk), but little patches in other areas. Comments&review highly welcome. Thanks, Daniel Dan

Re: [Intel-gfx] 3.6-rc1 breaks my laptop graphics (intel)

2012-08-12 Thread Greg KH
On Sun, Aug 12, 2012 at 08:25:31PM +0200, Daniel Vetter wrote: > On Sun, Aug 12, 2012 at 11:21:57AM -0700, Greg KH wrote: > > Hi Daniel. > > > > The 3.6-rc1 kernel breaks my laptop, booting to a black screen when the > > i915 driver initializes itself. I bisected this down to commit > > 24ded2044

Re: [Intel-gfx] Macbook Air 2012

2012-08-12 Thread Daniel Vetter
On Sun, Aug 12, 2012 at 07:45:05PM +0200, Daniel Wagner wrote: > Hi Daniel, > > On 08/11/2012 11:14 PM, Daniel Vetter wrote: > >On Sat, Aug 11, 2012 at 04:48:15PM +0200, Paul Menzel wrote: > >>Am Samstag, den 11.08.2012, 16:05 +0200 schrieb Daniel Wagner: > >> > >>>I installed on my shiny new Macb

Re: [Intel-gfx] 3.6-rc1 breaks my laptop graphics (intel)

2012-08-12 Thread Daniel Vetter
On Sun, Aug 12, 2012 at 11:21:57AM -0700, Greg KH wrote: > Hi Daniel. > > The 3.6-rc1 kernel breaks my laptop, booting to a black screen when the > i915 driver initializes itself. I bisected this down to commit > 24ded204429fa0f5501d37c63ee35c555c0b75ee (drm/i915: properly enable the > blc contro

[Intel-gfx] 3.6-rc1 breaks my laptop graphics (intel)

2012-08-12 Thread Greg KH
Hi Daniel. The 3.6-rc1 kernel breaks my laptop, booting to a black screen when the i915 driver initializes itself. I bisected this down to commit 24ded204429fa0f5501d37c63ee35c555c0b75ee (drm/i915: properly enable the blc controller on the right pipe), and when I revert that, and also a4f32fc3a37

Re: [Intel-gfx] Macbook Air 2012

2012-08-12 Thread Daniel Wagner
Hi Daniel, On 08/11/2012 11:14 PM, Daniel Vetter wrote: On Sat, Aug 11, 2012 at 04:48:15PM +0200, Paul Menzel wrote: Am Samstag, den 11.08.2012, 16:05 +0200 schrieb Daniel Wagner: I installed on my shiny new Macbook Air 2012 Fedora 17. After adding intremap=off to the kernel arguments, I wa

[Intel-gfx] [PATCH] drm/fb-helper: don't clobber output routing in setup_crtcs

2012-08-12 Thread Daniel Vetter
Yet again the too close relationship between the fb helper and the crtc helper code strikes. This time around the fb helper resets all encoder->crtc pointers to NULL before starting to set up it's own mode. Which is total bullocks, because this will clobber the existing output routing, which the ne

Re: [Intel-gfx] [PATCH] agp/intel, drm/i915: Use a write-combining map for updating PTEs

2012-08-12 Thread Chris Wilson
On Sun, 12 Aug 2012 17:47:46 +0200, Daniel Vetter wrote: > On Sun, Aug 12, 2012 at 12:04:39PM +0100, Chris Wilson wrote: > > In order to be able to ioremap_wc the GTT space, we need to remove the > > conflicting pci_iomap from drm/i915, so we limit the register map in > > drm/i915 to the suitable

Re: [Intel-gfx] [PATCH] agp/intel, drm/i915: Use a write-combining map for updating PTEs

2012-08-12 Thread Daniel Vetter
On Sun, Aug 12, 2012 at 12:04:39PM +0100, Chris Wilson wrote: > In order to be able to ioremap_wc the GTT space, we need to remove the > conflicting pci_iomap from drm/i915, so we limit the register map in > drm/i915 to the suitable range for each generation. The benefit of doing > this is an order

Re: [Intel-gfx] Updated -testing branch

2012-08-12 Thread Daniel Vetter
On Sun, Aug 12, 2012 at 02:55:25PM +0200, Daniel Vetter wrote: > Hi all, > > Note that the new -next is rebased a bit and not a descendant of the old > -nextso that I could fish out a few fixes for 3.6. > > Highlights of the entire thing: > - hsw hdmi improvements (Paulo) > - ips/rps locking rewo

[Intel-gfx] Updated -testing branch

2012-08-12 Thread Daniel Vetter
Hi all, Note that the new -next is rebased a bit and not a descendant of the old -nextso that I could fish out a few fixes for 3.6. Highlights of the entire thing: - hsw hdmi improvements (Paulo) - ips/rps locking rework and cleanups - rc6 on ilk by default again - hw context&dp&dpff support for

[Intel-gfx] [PATCH] agp/intel, drm/i915: Use a write-combining map for updating PTEs

2012-08-12 Thread Chris Wilson
In order to be able to ioremap_wc the GTT space, we need to remove the conflicting pci_iomap from drm/i915, so we limit the register map in drm/i915 to the suitable range for each generation. The benefit of doing this is an order of magnitude reduction in time spent rewriting the GTT entries when i

Re: [Intel-gfx] Netiquette: No HTML messages please. (was: [ANNOUNCE] glamor 0.5.0)

2012-08-12 Thread Zhigang Gong
On Sat, Aug 11, 2012 at 10:55:08AM +0200, Paul Menzel wrote: > Dear Zhigang, > > > thank you for the announcement message and congratulations on the > release. But please do not send HTML messages to lists [1]! Thanks for pointing this out. Actually, I was not aware of that I sent any non plain-

Re: [Intel-gfx] [ANNOUNCE] glamor 0.5.0

2012-08-12 Thread Zhigang Gong
On Fri, Aug 10, 2012 at 08:58:33AM -0700, Jeremy Huddleston Sequoia wrote: > > On Aug 10, 2012, at 03:37, Zhigang Gong wrote: > > > to try a full functional xserver with glamor, it’s recommended to use the > > following xserver version: > > > > commit a615b90cab7569fae9d123e4da1d3373c871d84b >