Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_irq.c |4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 878f1c3..a4e074e 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i9
Bring the for-each-pipe loops together so that the code is easier on the
eyes.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_irq.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index
A couple of miscellaneous cleanups as well to move per-loop condition
variables within the scope of the loop and the update of the DRI1
breadcrumb to the tail of the function.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_irq.c | 55 +--
1 file c
In preparation for rewriting the gen3 irq handler.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_irq.c | 810 ++-
1 file changed, 536 insertions(+), 274 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
i
And a couple of miscellaneous cleanups to the main body of the IRQ loop;
move per-loop condition variables within the scope of the loop and move
the old DRI1 breadcrumb to the tail of the function and so only execute
it once.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_irq.c | 27
Since there is only one remaining user of I915_INTERRUPT_ENABLE_FIX,
expand it at the callsite. Quoting Jesse Barnes:
"I'd really like to get rid of these defines at the top of i915_irq.c.
Some are unused and the others just make you check for the right bits
everytime your read the code."
Signed-
We appear to allow too many pending pageflips as evidenced by an
apparent pin-leak. So borrow the pageflip completion logic from i8xx for
handling PendingFlip in a robust manner.
v2: Address Jesse's reminders about the nuances of gen3 IRQ handling.
References: https://bugzilla.kernel.org/show_bug
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_irq.c | 11 ---
1 file changed, 11 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index a1150b7..d3500c7 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i915_i
And remove the cargo-culted copy from the valleyview irq handler.
Signed-off-by: Chris Wilson
Reviewed-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_dma.c |4
drivers/gpu/drm/i915/i915_drv.h |2 +-
drivers/gpu/drm/i915/i915_irq.c | 18 +-
3 files changed, 10 inse
The waitqueues are already initialised during ring initialisation so
kill the redundant and duplicated code to do so in each generations IRQ
installer.
Signed-off-by: Chris Wilson
Reviewed-by: Jesse Barnes
---
drivers/gpu/drm/i915/i915_irq.c | 17 -
1 file changed, 17 deletion
Rather than duplicate similar code across the IRQ installers, perform
the initialisation of the workers upfront. This will lead to simpler
teardown and quiescent code as we can assume that the workers have
been initialised.
Signed-off-by: Chris Wilson
Reviewed-by: Jesse Barnes
---
drivers/gpu/d
On later gen3, you are able to select the meaning of the FlipPending
status bit in IIR and change it to FlipDone. This was sometimes done by
the BIOS leading to confusion on just how pageflipping worked on gen3.
Simplify the implementation by using the legacy meaning for all gen3
machines.
Note: t
On Tue, 24 Apr 2012 21:48:47 +0100
Chris Wilson wrote:
> We were attempting to use a per-ring spinlock whilst modifying global
> IRQ flags. A recipe for rare missed interrupts.
>
> Signed-off-by: Chris Wilson
Regardless of whether or not this currently fixes anything, I need this
for an upcomi
We were attempting to use a per-ring spinlock whilst modifying global
IRQ flags. A recipe for rare missed interrupts.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_ringbuffer.c | 41 ++-
drivers/gpu/drm/i915/intel_ringbuffer.h |3 +--
2 files change
On Tue, 24 Apr 2012 12:50:35 -0700, Jesse Barnes
wrote:
> > + /* "flip pending" bit means done if this bit is set */
> > + I915_WRITE(ECOSKPD, _MASKED_BIT_DISABLE(ECO_FLIP_DONE));
> > +
>
> Aha. I hope this works across platforms. I don't even know why this
On Tue, Apr 24, 2012 at 12:50:35PM -0700, Jesse Barnes wrote:
> On Tue, 24 Apr 2012 18:31:30 +0100
> Chris Wilson wrote:
> > - if (dev->primary->master) {
> > - master_priv = dev->primary->master->driver_priv;
> > - if (master_priv->sarea_priv)
> > -
On Tue, 24 Apr 2012 18:31:31 +0100
Chris Wilson wrote:
> ---
> drivers/gpu/drm/i915/i915_irq.c | 27 ++-
> 1 file changed, 10 insertions(+), 17 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index 47a540a..2ff431b 1006
On Tue, 24 Apr 2012 18:31:30 +0100
Chris Wilson wrote:
> diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
> index b378555..47a540a 100644
> --- a/drivers/gpu/drm/i915/i915_irq.c
> +++ b/drivers/gpu/drm/i915/i915_irq.c
> @@ -2307,7 +2307,7 @@ static void i915_irq_prein
On Tue, 24 Apr 2012 18:27:57 +0200, Daniel Vetter
wrote:
> The drm_mode->dtd conversion used the crtc timings, whereas the
> dtd->drm_mod did not set these. Use the standard mode information, not
> the crtc timings, in both cases to make these two functions proper
> inverses of each another.
>
>
On Tue, 24 Apr 2012 18:31:28 +0100
Chris Wilson wrote:
> And remove the cargo-culted copy from the valleyview irq handler.
>
> Signed-off-by: Chris Wilson
> ---
Note that VLV flipping needs other work, but it doesn't have this
misfeature so we can drop it.
Reviewed-by: Jesse Barnes
--
Jess
On Tue, 24 Apr 2012 18:31:27 +0100
Chris Wilson wrote:
> The waitqueues are already initialised during ring initialisation so
> kill the redundant and duplicated code to do so in each generations IRQ
> installer.
>
> Signed-off-by: Chris Wilson
> ---
Yep and that happens before we regsiter the
On Tue, 24 Apr 2012 18:31:26 +0100
Chris Wilson wrote:
> Rather than duplicate similar code across the IRQ installers, perform
> the initialisation of the workers upfront. This will lead to simpler
> teardown and quiescent code as we can assume that the workers have
> been initialised.
>
> Signe
On Tue, 24 Apr 2012 16:36:50 +0100
Chris Wilson wrote:
> Enabling the plane before we have assigned valid address means that it
> will access random PTE (often with conflicting memory types) and cause
> GPU lockups. However, enabling the plane too early appears to workaround
> a number of bugs in
We seem to trigger an occasional error when the GPU tries to dereference
a PTE for an overlay plane prior to us populating the offsets in the
overlay registers. This is despite the Overlay Command being set to off.
Close this window delaying the switch on until after those registers are
initialised
In preparation for rewriting the gen3 irq handler.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_irq.c | 811 ++-
1 file changed, 537 insertions(+), 274 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
i
We appear to allow too many pending pageflips as evidenced by an
apparent pin-leak. So borrow the pageflip completion logic from i8xx for
handling PendingFlip in a robust manner.
References: https://bugzilla.kernel.org/show_bug.cgi?id=41882
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i9
---
drivers/gpu/drm/i915/i915_irq.c | 27 ++-
1 file changed, 10 insertions(+), 17 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 47a540a..2ff431b 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/gpu/drm/i915/i
And remove the cargo-culted copy from the valleyview irq handler.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_dma.c |4
drivers/gpu/drm/i915/i915_drv.h |2 +-
drivers/gpu/drm/i915/i915_irq.c | 18 +-
3 files changed, 10 insertions(+), 14 deletions(-)
The waitqueues are already initialised during ring initialisation so
kill the redundant and duplicated code to do so in each generations IRQ
installer.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_irq.c | 17 -
1 file changed, 17 deletions(-)
diff --git a/drivers/
Rather than duplicate similar code across the IRQ installers, perform
the initialisation of the workers upfront. This will lead to simpler
teardown and quiescent code as we can assume that the workers have
been initialised.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_irq.c | 16 +
This was only used by one external caller who would just be as happy
with evict-everything, so perform the replacement and make the function
private.
In the process we note that unbinding the inactive list should not fail,
and make it a warning instead.
Signed-off-by: Chris Wilson
---
Another ea
Maybe this make someone happy, because I'm pretty sure interlaced on
sdvo won't work without this.
Signed-Off-by: Daniel Vetter
---
drivers/gpu/drm/i915/intel_sdvo.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/drm/i915/intel_sdvo.c
b/drivers/gpu/drm/i915/intel_sdvo.c
The drm_mode->dtd conversion used the crtc timings, whereas the
dtd->drm_mod did not set these. Use the standard mode information, not
the crtc timings, in both cases to make these two functions proper
inverses of each another.
Note that this also kills the risk that we handle interlaced timings
i
On Tue, Apr 24, 2012 at 08:57:42AM -0700, Ben Widawsky wrote:
> On Tue, 24 Apr 2012 16:00:21 +0200
> Daniel Vetter wrote:
>
> > Copy&pasted from the vlv setup code. According to docs, we need that
> > on ivb, too.
> >
> > v2: Use new masked bit handling macros.
> >
> > Cc: Ben Widawsky
> > Sig
On Tue, 24 Apr 2012 14:04:12 +0200
Daniel Vetter wrote:
> ... and put them to so good use.
>
> Note that there's functional change in vlv clock gating code, we now
> no longer spuriously read back the current value of the bit. According
> to Bspec the high bits should always read zeror, so ORing
On Tue, 24 Apr 2012 16:00:21 +0200
Daniel Vetter wrote:
> Copy&pasted from the vlv setup code. According to docs, we need that
> on ivb, too.
>
> v2: Use new masked bit handling macros.
>
> Cc: Ben Widawsky
> Signed-Off-by: Daniel Vetter
Reviewed-by: Ben Widawsky
On Tue, 24 Apr 2012 16:03:24 +0200
Daniel Vetter wrote:
> On Sat, Apr 21, 2012 at 05:57:08PM -0700, Ben Widawsky wrote:
> > Rebased after new intel_pm split. This needs testing from QA to see how
> > it impacts power consumption.
> >
> > Cc: "Zhang, Ouping"
> > Signed-off-by: Ben Widawsky
>
>
Enabling the plane before we have assigned valid address means that it
will access random PTE (often with conflicting memory types) and cause
GPU lockups. However, enabling the plane too early appears to workaround
a number of bugs in our modesetting code.
Cc: Franz Melchior
References: https://b
On Tue, Apr 24, 2012 at 04:11:43PM +0100, Chris Wilson wrote:
> On Tue, 24 Apr 2012 15:41:37 +0200, Daniel Vetter
> wrote:
> > the only places we actually need the crtc timings is in the mode_set
> > function.
> >
> > So we can now safely rip out all the remaining calls to set_crtcinfo
> > left
On Tue, 24 Apr 2012 15:41:37 +0200, Daniel Vetter
wrote:
> the only places we actually need the crtc timings is in the mode_set
> function.
>
> So we can now safely rip out all the remaining calls to set_crtcinfo
> left in the driver and clean up this confusion.
I have a little flicker of doubt
Currently, we only bump the LRU of an object when we bind into the GTT
for a page-fault. As the object may be used many times before its
mapping is zapped, we do not mark it as active as frequently as we
should. Userspace should be calling set-to-GTT-domain before each
pointer deference (for synchr
Simplify object tracking by removing the inactive but pinned list. The
only place where this was used is for counting the available memory,
which is just as easy performed by checking all objects on the rare
occasions it is required (application startup). For ease of debugging,
we keep the reportin
The use of the mm_list by deferred-free breaks the following patches to
extend the range of objects tracked. We can simplify things if we just
make the unbind during free uninterrible.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_debugfs.c | 11 ---
drivers/gpu/drm/i915/i915_d
Avoid stalling and waiting for the GPU by checking to see if there is
sufficient inactive space in the aperture for us to bind the buffer
prior to writing through the GTT. If there is inadequate space we will
have to stall waiting for the GPU, and incur overheads moving objects
about. Instead, only
Given the persistence of an offset for the lifetime of an object, itis
easy to contemplate how the mmap space becomes badly fragmented to the
point that further allocations fail with ENOSPC. Our only recourse at
this point is to try to purge the objects to release some space and
reattempt the alloc
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 38 +++---
1 file changed, 15 insertions(+), 23 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index c81962b..e7aa44b 100644
--- a/drivers/gpu/drm/i915
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_dma.c | 66 +--
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gpu/drm/i915/i915_gem.c | 64 +
3 files changed, 66 insertions(+), 65 deletions(-)
diff --git a/
We slightly modify the initialisation sequence to move the
initialisation of the memory managers earlier and in particular before
probing outputs and detecting any existing output configuration. This is
essential if we wish to track preallocated objects and preserve them
whilst initialising GEM.
S
Check to see if we've reached the end before dereferencing to get the
next scatterlist. This helps when creating scatterlists by hand.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem_gtt.c |8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/dr
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h |2 ++
drivers/gpu/drm/i915/i915_gem_gtt.c | 32 +---
2 files changed, 31 insertions(+), 3 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_drv.h b/drivers/gpu/drm/i915/i915_drv.h
index 32e6c
As we may wish to wrap regions preallocated by the BIOS, we need to do
that before carving out contiguous chunks of stolen space for FBC.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h|1 +
drivers/gpu/drm/i915/i915_gem_stolen.c | 68 +--
In order to accommodate objects that are not backed by struct pages, but
instead point into a contiguous region of stolen space, we need to make
various changes to avoid dereferencing obj->pages or obj->base.filp.
First introduce a marker for the stolen object, that specifies its
offset into the s
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_irq.c | 13 -
1 file changed, 12 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/i915_irq.c b/drivers/gpu/drm/i915/i915_irq.c
index 24e1dd2..033f9be 100644
--- a/drivers/gpu/drm/i915/i915_irq.c
+++ b/drivers/g
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_dma.c |4 ++
drivers/gpu/drm/i915/intel_display.c |3 -
drivers/gpu/drm/i915/intel_drv.h |1 +
drivers/gpu/drm/i915/intel_fb.c | 118 --
4 files changed, 119 insertions(+), 7 delet
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 46 ++-
1 file changed, 31 insertions(+), 15 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index a0b6375..45f215f 100644
--- a/drivers/gpu/drm/i91
Allow for the creation of GEM objects backed by stolen memory. As these
are not backed by ordinary pages, we create a fake dma mapping and store
the address in the scatterlist rather than obj->pages.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h|3 +
drivers/gpu/drm
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_fb.c |4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_fb.c b/drivers/gpu/drm/i915/intel_fb.c
index 71ef289..eb65e3c 100644
--- a/drivers/gpu/drm/i915/intel_fb.c
+++ b/drivers/gpu/drm/i91
To be used later by i915 to preallocate exact blocks of space from the
range manager.
Signed-off-by: Chris Wilson
Cc: Dave Airlie
---
drivers/gpu/drm/drm_mm.c | 49 ++
include/drm/drm_mm.h |4
2 files changed, 53 insertions(+)
diff --g
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_overlay.c |6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/gpu/drm/i915/intel_overlay.c
b/drivers/gpu/drm/i915/intel_overlay.c
index 9845cfc..22bb856 100644
--- a/drivers/gpu/drm/i915/intel_overlay.c
+
This will be shared with wrapping the BIOS framebuffer into the fbdev
later. In the meantime, we can tidy the code slightly and improve the
error path handling.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_fb.c | 125 +--
1 file changed, 69 inse
Wrap a preallocated region of stolen memory within an ordinary GEM
object, for example the BIOS framebuffer.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h|5 +++
drivers/gpu/drm/i915/i915_gem_stolen.c | 58
2 files changed, 63 inse
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_ringbuffer.c |6 +-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_ringbuffer.c
b/drivers/gpu/drm/i915/intel_ringbuffer.c
index 2a3fcd6..a8b7605 100644
--- a/drivers/gpu/drm/i915/intel_rin
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 44 ++-
1 file changed, 30 insertions(+), 14 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index 45f215f..e72f661 100644
--- a/drivers/gpu/drm/i91
As we wish to create specialised object constructions in the near
future that share the same basic GEM object struct, export the default
initializer.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_drv.h |1 +
drivers/gpu/drm/i915/i915_gem.c | 32 +++-
If we have created a scatterlist for the physical mapping of the object,
simply use it. This facilitates the later insertion of stolen objects
into the GATT which are not backed by struct page.
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem_gtt.c | 19 ---
1 file
It was not until the G33 refresh, that a PCI config register was
introduced that explicitly said where the stolen memory was. Prior to
865G there was not even a register that said where the end of usable
low memory was and where the stolen memory began (or ended depending
upon chipset). Before then
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_debugfs.c | 19 ++-
1 file changed, 14 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_debugfs.c
b/drivers/gpu/drm/i915/i915_debugfs.c
index de7c65e..1e12c72 100644
--- a/drivers/gpu/drm/i915/i915_d
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/i915_gem.c | 44 ++-
1 file changed, 20 insertions(+), 24 deletions(-)
diff --git a/drivers/gpu/drm/i915/i915_gem.c b/drivers/gpu/drm/i915/i915_gem.c
index af89ba4..c81962b 100644
--- a/drivers/gpu/drm/i91
When dealing with a working set larger than the GATT, or even the
mappable aperture when touching through the GTT, we end up with evicting
objects only to rebind them at a new offset again later. Moving an
object into and out of the GTT requires clflushing the pages, thus
causing a double-clflush p
In comparison to last time, the use of generic objects backed by stolen
memory is fully supported. This has been used to test stolen objects by
allocating the ringbuffer, fbcon and other permanent objects out of
stolen memory and using them in anger.
The first several patches are in preparation fo
Our handling of the crtc timing computation has been nicely
cargo-culted with calls to drm_mode_set_crtcinfo sprinkled all over
the place. But with
commit f9bef081c3c3f77bec54454872e98d3ec635756f
Author: Daniel Vetter
Date: Sun Apr 15 19:53:19 2012 +0200
drm/i915: don't clobber the special
On Sat, Apr 21, 2012 at 05:57:08PM -0700, Ben Widawsky wrote:
> Rebased after new intel_pm split. This needs testing from QA to see how
> it impacts power consumption.
>
> Cc: "Zhang, Ouping"
> Signed-off-by: Ben Widawsky
I've seen the internal power testing results and nothing seems to change.
Copy&pasted from the vlv setup code. According to docs, we need that
on ivb, too.
v2: Use new masked bit handling macros.
Cc: Ben Widawsky
Signed-Off-by: Daniel Vetter
---
drivers/gpu/drm/i915/intel_pm.c |4
1 files changed, 4 insertions(+), 0 deletions(-)
diff --git a/drivers/gpu/dr
The specs recommend that this bit be set on PineView. No reason is
given, but it sounds like a powersaving bit that we should expect the
BIOS to be setting...
v2: Rebase on top of _MASKED_ENABLE_BIT
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_pm.c |3 +++
1 file changed, 3 in
On Tue, Apr 24, 2012 at 10:24, Chris Wilson wrote:
> On Tue, 24 Apr 2012 14:04:12 +0200, Daniel Vetter
> wrote:
> > ... and put them to so good use.
> >
> > Note that there's functional change in vlv clock gating code, we now
> > no longer spuriously read back the current value of the bit. Accord
On Tue, Apr 24, 2012 at 02:24:33PM +0100, Chris Wilson wrote:
> On Tue, 24 Apr 2012 14:04:12 +0200, Daniel Vetter
> wrote:
> > ... and put them to so good use.
> >
> > Note that there's functional change in vlv clock gating code, we now
> > no longer spuriously read back the current value of the
On Tue, 24 Apr 2012 14:04:12 +0200, Daniel Vetter
wrote:
> ... and put them to so good use.
>
> Note that there's functional change in vlv clock gating code, we now
> no longer spuriously read back the current value of the bit. According
> to Bspec the high bits should always read zeror, so ORin
... and put them to so good use.
Note that there's functional change in vlv clock gating code, we now
no longer spuriously read back the current value of the bit. According
to Bspec the high bits should always read zeror, so ORing this in
should have no effect.
Cc: Jesse Barnes
Signed-Off-by: Da
Il 24/04/2012 14.42, Chris Wilson ha scritto:
On Tue, 24 Apr 2012 14:36:50 +0200, Stefano
Fraccaro wrote:
Without nomodeset I'm unable to start the pc: the system hang with a
black screen
And why is that?
-Chris
I don't know... some laptop start with kms enabled, others are unable to
start
On Tue, 24 Apr 2012 14:36:50 +0200, Stefano Fraccaro
wrote:
> Il 24/04/2012 14.08, Chris Wilson ha scritto:
> > Remove nomodeset from your kernel command line, be happy. -Chris
>
> Without nomodeset I'm unable to start the pc: the system hang with a
> black screen
And why is that?
-Chris
--
The specs recommend that this bit be set on PineView. No reason is
given, but it sounds like a powersaving bit that we should expect the
BIOS to be setting...
Signed-off-by: Chris Wilson
---
drivers/gpu/drm/i915/intel_pm.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/gpu/dr
Il 24/04/2012 14.08, Chris Wilson ha scritto:
Remove nomodeset from your kernel command line, be happy. -Chris
Without nomodeset I'm unable to start the pc: the system hang with a
black screen
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.o
On Tue, 24 Apr 2012 14:05:17 +0200, Stefano Fraccaro
wrote:
> I have both 2a42 and 2a43. Strange is strange... with Ubuntu 10.10 32
> bit all works perfectly. I'm trying with an ubuntu 12.04 64 bit (instead
> of Lubuntu). I have attached to this message all the logs that you have
> requested
On Tue, Apr 24, 2012 at 09:28:32AM +, Guo, Chaohong wrote:
> Strange, even in upstream kernel, drm driver supports 2a42 only, but the id
> of his device is 2a43 ?
Hm, in that case we also need the output of lspci -nn
-Daniel
--
Daniel Vetter
Mail: dan...@ffwll.ch
Mobile: +41 (0)79 365 57 4
On Tue, 24 Apr 2012 09:55:08 +0200, Daniel Vetter
wrote:
> Also ditch the cargo-culted dev_priv checks - either we have a
> giant hole in our setup code or this is useless. Plainly bogus
> to check for it in either case.
>
> v2: Chris Wilson noticed that I've missed one bogus dev_priv check.
>
Strange, even in upstream kernel, drm driver supports 2a42 only, but the id
of his device is 2a43 ?
-minskey
-Original Message-
From: intel-gfx-bounces+chaohong.guo=intel@lists.freedesktop.org
[mailto:intel-gfx-bounces+chaohong.guo=intel@lists.freedesktop.org] On
Behalf Of Ch
On Tue, 24 Apr 2012 09:55:08 +0200, Daniel Vetter
wrote:
> Also ditch the cargo-culted dev_priv checks - either we have a
> giant hole in our setup code or this is useless. Plainly bogus
> to check for it in either case.
>
> v2: Chris Wilson noticed that I've missed one bogus dev_priv check.
>
On Tue, 24 Apr 2012 11:06:06 +0200, Stefano Fraccaro
wrote:
> Hi,
> there is a way to make my intel vga work properly? I can't find any
> driver or solution...
> My system is Lubuntu 12.04 x86_64. My intel card is 8086:2a43 rev07.
Since it usually is just a case of installing the OS and pl
On Tue, Apr 24, 2012 at 11:06:06AM +0200, Stefano Fraccaro wrote:
> Hi,
> there is a way to make my intel vga work properly? I can't find
> any driver or solution...
> My system is Lubuntu 12.04 x86_64. My intel card is 8086:2a43 rev07.
It should work. I suggest you ask on ubuntu forums first
Hi,
there is a way to make my intel vga work properly? I can't find any
driver or solution...
My system is Lubuntu 12.04 x86_64. My intel card is 8086:2a43 rev07.
Cheers
Stefano
___
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
http://lis
Also ditch the cargo-culted dev_priv checks - either we have a
giant hole in our setup code or this is useless. Plainly bogus
to check for it in either case.
v2: Chris Wilson noticed that I've missed one bogus dev_priv check.
v3: The check in the overlay code is redundant (Chris)
Signed-off-by:
On Tue, 24 Apr 2012 08:19:31 +0200, Daniel Vetter
wrote:
> diff --git a/drivers/gpu/drm/i915/intel_overlay.c
> b/drivers/gpu/drm/i915/intel_overlay.c
> index 0f0fe31..aa14235 100644
> --- a/drivers/gpu/drm/i915/intel_overlay.c
> +++ b/drivers/gpu/drm/i915/intel_overlay.c
> @@ -1122,10 +1122,8 @@
Let's just get this out of the way.
v2: Rebase against ENODEV changes.
Reviewed-by: Chris Wilson
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/i915_dma.c | 110 +++
drivers/gpu/drm/i915/i915_drv.h |4 --
drivers/gpu/drm/i915/i915_irq.c | 110 --
i915_dma.c contains most of the old dri1 horror-show, so move
the remaining bits there, too. The code has been removed and
the only thing left are some stubs to ensure that userspace
doesn't try to use this stuff. vblank_pipe_set only returns 0
without any side-effects, so we can even stub it out w
Calling these when gem assumes full control of the hw won't end
in anything else than tears. So be a bit more paranoid here.
Just serves as documentation.
v2: Bail out with ENODEV as suggested by Chris Wilson.
Reviewed-by: Chris Wilson
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/i91
This ioctl used in a kms driver is only useful to create massive
havoc.
v2: Bail out with -ENODEV as suggested by Chris Wilson.
Reviewed-by: Chris Wilson
Signed-Off-by: Daniel Vetter
---
drivers/gpu/drm/i915/i915_gem.c |3 +++
1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/
Also ditch the cargo-culted dev_priv checks - either we have a
giant hole in our setup code or this is useless. Plainly bogus
to check for it in either case.
v2: Chris Wilson noticed that I've missed one bogus dev_priv check.
Signed-off-by: Daniel Vetter
---
drivers/gpu/drm/i915/intel_display.c
On Mon, Apr 23, 2012 at 11:23:15PM +0100, Chris Wilson wrote:
> On Mon, 23 Apr 2012 16:50:48 +0200, Daniel Vetter
> wrote:
> > Also ditch the cargo-culted dev_priv checks - either we have a
> > giant hole in our setup code or this is useless. Plainly bogus
> > to check for it in either case.
> >
98 matches
Mail list logo
