[Intel-gfx] [PATCH] drm/i915: Unconditionally initialise the interrupt workers

2012-04-19 Thread Chris Wilson
Rather than duplicate similar code across the IRQ installers, perform the initialisation of the workers upfront. This will lead to simpler teardown and quiescent code as we can assume that the workers have been initialised. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_irq.c | 14 +

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Takashi Iwai
At Thu, 19 Apr 2012 13:55:04 -0400, Adam Jackson wrote: > > On Thu, 2012-04-19 at 18:10 +0200, Takashi Iwai wrote: > > > This patch adds a flag to disable the hotplug during PM operation for > > avoiding such a race. > > > > Cc: > > Signed-off-by: Takashi Iwai > > This seems simpler (untested

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Adam Jackson
On Thu, 2012-04-19 at 18:10 +0200, Takashi Iwai wrote: > This patch adds a flag to disable the hotplug during PM operation for > avoiding such a race. > > Cc: > Signed-off-by: Takashi Iwai This seems simpler (untested): diff --git a/drivers/gpu/drm/i915/i915_drv.c b/drivers/gpu/drm/i915/i915_

[Intel-gfx] [PATCH] drm/i915: Remove i915_gem_ringbuffer_(data|info) from debugfs

2012-04-19 Thread Chris Wilson
This was originally used as an attempt to diagnose GPU hangs, but was never very reliable and superseded by the i915_error_state capture on hangcheck. It now lies languishing unused and unwanted. Signed-off-by: Chris Wilson --- drivers/gpu/drm/i915/i915_debugfs.c | 69 -

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Daniel Vetter
On Thu, Apr 19, 2012 at 06:38:13PM +0200, Takashi Iwai wrote: > At Thu, 19 Apr 2012 18:29:47 +0200, > Daniel Vetter wrote: > > > > On Thu, Apr 19, 2012 at 06:10:18PM +0200, Takashi Iwai wrote: > > > The hotplug work can be still kicked off via irq during PM, and this > > > may conflict with the re

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Takashi Iwai
At Thu, 19 Apr 2012 18:29:47 +0200, Daniel Vetter wrote: > > On Thu, Apr 19, 2012 at 06:10:18PM +0200, Takashi Iwai wrote: > > The hotplug work can be still kicked off via irq during PM, and this > > may conflict with the resume procedure. For example, eDP on SNB > > machine shows WARNING like be

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Takashi Iwai
At Thu, 19 Apr 2012 17:22:47 +0100, Chris Wilson wrote: > > On Thu, 19 Apr 2012 18:10:18 +0200, Takashi Iwai wrote: > > The hotplug work can be still kicked off via irq during PM, and this > > may conflict with the resume procedure. For example, eDP on SNB > > machine shows WARNING like below du

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Daniel Vetter
On Thu, Apr 19, 2012 at 06:10:18PM +0200, Takashi Iwai wrote: > The hotplug work can be still kicked off via irq during PM, and this > may conflict with the resume procedure. For example, eDP on SNB > machine shows WARNING like below during the resume: > > WARNING: at > /usr/src/packages/BUILD

Re: [Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Chris Wilson
On Thu, 19 Apr 2012 18:10:18 +0200, Takashi Iwai wrote: > The hotplug work can be still kicked off via irq during PM, and this > may conflict with the resume procedure. For example, eDP on SNB > machine shows WARNING like below during the resume: Daniel and I were just discussing the number of w

[Intel-gfx] [PATCH] drm/i915: Suppress hotplug work during PM suspend/resume

2012-04-19 Thread Takashi Iwai
The hotplug work can be still kicked off via irq during PM, and this may conflict with the resume procedure. For example, eDP on SNB machine shows WARNING like below during the resume: WARNING: at /usr/src/packages/BUILD/kernel-default-3.0.13/linux-3.0/drivers/gpu/drm/i915/intel_dp.c:332 inte

Re: [Intel-gfx] [PATCH] drm/i915: invalidate render cache on gen2

2012-04-19 Thread Daniel Vetter
On Thu, Apr 19, 2012 at 03:47:44PM +0100, Chris Wilson wrote: > On Thu, 19 Apr 2012 16:45:22 +0200, Daniel Vetter > wrote: > > It looks like we also need to flush the render cache when we just > > invalidate it. This fixes a regression in i-g-t/gem_tiled_blits on my > > i855gm. I guess the render

Re: [Intel-gfx] [PATCH 00/12] Add more DMT and common modes

2012-04-19 Thread Takashi Iwai
At Thu, 19 Apr 2012 14:03:58 +0200, Takashi Iwai wrote: > > At Tue, 17 Apr 2012 17:26:26 +0200, > Takashi Iwai wrote: > > > > At Fri, 13 Apr 2012 16:56:26 -0400, > > Adam Jackson wrote: > > > > > > On 4/13/12 4:33 PM, Adam Jackson wrote: > > > > Incorporates some feedback from Rodrigo and Takash

Re: [Intel-gfx] [PATCH] drm/i915: invalidate render cache on gen2

2012-04-19 Thread Chris Wilson
On Thu, 19 Apr 2012 16:45:22 +0200, Daniel Vetter wrote: > It looks like we also need to flush the render cache when we just > invalidate it. This fixes a regression in i-g-t/gem_tiled_blits on my > i855gm. I guess the render cache there is virtually indexed, so we > need to clean it when changin

[Intel-gfx] [PATCH] drm/i915: invalidate render cache on gen2

2012-04-19 Thread Daniel Vetter
It looks like we also need to flush the render cache when we just invalidate it. This fixes a regression in i-g-t/gem_tiled_blits on my i855gm. I guess the render cache there is virtually indexed, so we need to clean it when changing gtt mappings. This regression has been introduce in commit 46f0

[Intel-gfx] [pull] drm-intel-fixes for 3.4-rc4

2012-04-19 Thread Daniel Vetter
Hi Dave, Just 3 fixes this time around: - Regression fix for upscaled lvds modes on older machines, the clean-up of our crtc timing handling from the interlaced patches screwed things up there. - Locking fix in lastclose, prevents an oops. - Black panel on vt switch due to pageflip when upscal

Re: [Intel-gfx] [PATCH 00/12] Add more DMT and common modes

2012-04-19 Thread Takashi Iwai
At Tue, 17 Apr 2012 17:26:26 +0200, Takashi Iwai wrote: > > At Fri, 13 Apr 2012 16:56:26 -0400, > Adam Jackson wrote: > > > > On 4/13/12 4:33 PM, Adam Jackson wrote: > > > Incorporates some feedback from Rodrigo and Takashi. Major themes of the > > > series: > > > > > > - Fix the DMT list to inc