Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-09 Thread Wu Fengguang
On Thu, Nov 10, 2011 at 03:33:50PM +0800, Wu Fengguang wrote: > Wow I reproduced the bug and got a very interesting dmesg: > > gfx =>[ 4561.287980] [drm:intel_write_eld], ELD on > [CONNECTOR:12:HDMI-A-2], [ENCODER:11:TMDS-11] > gfx =>[ 4561.291730] [drm:ironlake_write_eld], ELD on

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-09 Thread Wu Fengguang
Wow I reproduced the bug and got a very interesting dmesg: gfx =>[ 4561.287980] [drm:intel_write_eld], ELD on [CONNECTOR:12:HDMI-A-2], [ENCODER:11:TMDS-11] gfx =>[ 4561.291730] [drm:ironlake_write_eld], ELD on pipe B gfx =>[ 4561.293804] [drm:ironlake_write_eld], Audio dir

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-09 Thread Wu Fengguang
Christopher, On Thu, Nov 10, 2011 at 12:10:42PM +0800, Christopher White wrote: > On 11/10/11 4:27 AM, Wu Fengguang wrote: > > Christopher, > > > > Did you enabled CONFIG_SND_DEBUG and CONFIG_SND_DEBUG_VERBOSE in > > kconfig? I've been looking for the error messages related to zeroed > > ELD but n

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-09 Thread Wu Fengguang
Christopher, > The dump tool did not work with that environment variable either. > However, it occurred to me that intel_audio_dump may be too outdated in > my distro. It was built on 2010-04-01, v1.0.2+git20100324. If I look at > http://cgit.freedesktop.org/xorg/app/intel-gpu-tools/ I can see tha

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-09 Thread Wu Fengguang
Christopher, Did you enabled CONFIG_SND_DEBUG and CONFIG_SND_DEBUG_VERBOSE in kconfig? I've been looking for the error messages related to zeroed ELD but never managed to find any in your dmesg. Some analyzes of your dmesg: - all drm_edid_to_eld() invocations reads valid EDID data: [2.56000

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-09 Thread Christopher White
Hi Fengguang, I am quoting both your messages below so read until the bottom. I've even found what looks to be the cause. On 11/9/11 2:01 PM, Wu Fengguang wrote: Christopher, On Wed, Nov 09, 2011 at 05:30:18PM +0800, Christopher White wrote: Couldn't resist connecting to my machine over VNC e

Re: [Intel-gfx] [PATCH] drm/i915: Force synchronous TLB invalidations on the BLT ring for SNB+

2011-11-09 Thread Eric Anholt
On Wed, 09 Nov 2011 19:15:06 +, Chris Wilson wrote: > On Wed, 09 Nov 2011 10:57:00 -0800, Eric Anholt wrote: > > On Wed, 9 Nov 2011 17:32:26 +, Chris Wilson > > wrote: > > > We are advised that in order to workaround the TLB invalidation being > > > performed asynchronously with the c

Re: [Intel-gfx] [PATCH] drm/i915: Force synchronous TLB invalidations on the BLT ring for SNB+

2011-11-09 Thread Chris Wilson
On Wed, 09 Nov 2011 10:57:00 -0800, Eric Anholt wrote: > On Wed, 9 Nov 2011 17:32:26 +, Chris Wilson > wrote: > > We are advised that in order to workaround the TLB invalidation being > > performed asynchronously with the command streamer that we need to use > > a post-sync write along with

Re: [Intel-gfx] [PATCH] drm/i915: Force synchronous TLB invalidations on the BLT ring for SNB+

2011-11-09 Thread Eric Anholt
On Wed, 9 Nov 2011 17:32:26 +, Chris Wilson wrote: > We are advised that in order to workaround the TLB invalidation being > performed asynchronously with the command streamer that we need to use > a post-sync write along with the invalidations in the MI_FLUSH_DW so > that all operations are

Re: [Intel-gfx] [PATCH v3] drm/i915: Honor SSC quirk table over the default, unless set by user

2011-11-09 Thread Keith Packard
On Wed, 09 Nov 2011 17:30:29 +0100, Michel Alexandre Salim wrote: > Additional note: while I've not touched the line since it does not > affect me, it seems that i915_panel_use_ssc *cannot* be less than 0 > since that variable is declared as unsigned. Oops. That's the bug here -- we're supposed

Re: [Intel-gfx] [PATCH v2] drm/i915: Prioritize SSC quirk table when determining SSC settings

2011-11-09 Thread Keith Packard
On Wed, 09 Nov 2011 15:29:13 +0100, Michel Alexandre Salim wrote: > the quirk table unreachable if i915_panel_use_ssc is set. This patch > reorders the tests so that the quirk table is checked first, the > i915_panel_use_ssc next and the original per-device setting last. The requirement is that

[Intel-gfx] [PATCH] drm/i915: Force synchronous TLB invalidations on the BLT ring for SNB+

2011-11-09 Thread Chris Wilson
We are advised that in order to workaround the TLB invalidation being performed asynchronously with the command streamer that we need to use a post-sync write along with the invalidations in the MI_FLUSH_DW so that all operations are complete before executing the next command in the ringbuffer. Re

Re: [Intel-gfx] [PATCH v3] drm/i915: Honor SSC quirk table over the default, unless set by user

2011-11-09 Thread Michel Alexandre Salim
Additional note: while I've not touched the line since it does not affect me, it seems that i915_panel_use_ssc *cannot* be less than 0 since that variable is declared as unsigned. So the last line (the value in dev_priv) will never be used to determine whether SSC is used anyway. Keith probably kn

Re: [Intel-gfx] [PATCH] drm/i915: protect force_wake_(get|put) with the gt_lock

2011-11-09 Thread Daniel Vetter
On Wed, Nov 09, 2011 at 05:22:00PM +0100, Nicolas Kalkhof wrote: > Bisecting the kernel proved a little time consuming ;) however with the > very latest linux.git anf xf86-video-intel the cpu load doesn't seem to > go up accodring to top. What I can see is that the SNB draws approx > 10-15 watts mo

Re: [Intel-gfx] [PATCH] drm/i915: protect force_wake_(get|put) with the gt_lock

2011-11-09 Thread Nicolas Kalkhof
Daniel, Bisecting the kernel proved a little time consuming ;) however with the very latest linux.git anf xf86-video-intel the cpu load doesn't seem to go up accodring to top. What I can see is that the SNB draws approx 10-15 watts more when my system is completely idle. My first thought was th

Re: [Intel-gfx] [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC settings

2011-11-09 Thread Michel Alexandre Salim
On Wed, 2011-11-09 at 14:20 +, Chris Wilson wrote: > On Wed, 09 Nov 2011 15:11:40 +0100, Michel Alexandre Salim > wrote: > > From ab11cf4b1b28d0abb1db8bc992d016b257489ab5 Mon Sep 17 00:00:00 2001 > > From: Michel Alexandre Salim > > Date: Wed, 9 Nov 2011 14:18:45 +0100 > > Subject: [PATCH] d

[Intel-gfx] [PATCH v3] drm/i915: Honor SSC quirk table over the default, unless set by user

2011-11-09 Thread Michel Alexandre Salim
>From a90bf9ac2a40869242a79c88958c99dacc3da2a9 Mon Sep 17 00:00:00 2001 From: Michel Alexandre Salim Date: Wed, 9 Nov 2011 14:18:45 +0100 Subject: [PATCH v3] drm/i915: Honor SSC quirk table over the default, unless set by user Commit 72bbe58cd9568c7766cc219a779ea68a02132797 makes the check again

[Intel-gfx] [PATCH v2] drm/i915: Prioritize SSC quirk table when determining SSC settings

2011-11-09 Thread Michel Alexandre Salim
>From ab11cf4b1b28d0abb1db8bc992d016b257489ab5 Mon Sep 17 00:00:00 2001 From: Michel Alexandre Salim Date: Wed, 9 Nov 2011 14:18:45 +0100 Subject: [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC settings Commit 72bbe58cd9568c7766cc219a779ea68a02132797 makes the check against th

Re: [Intel-gfx] [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC settings

2011-11-09 Thread Michel Alexandre Salim
On Wed, 2011-11-09 at 15:11 +0100, Michel Alexandre Salim wrote: > From ab11cf4b1b28d0abb1db8bc992d016b257489ab5 Mon Sep 17 00:00:00 2001 > From: Michel Alexandre Salim > Date: Wed, 9 Nov 2011 14:18:45 +0100 > Subject: [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC > settings >

Re: [Intel-gfx] [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC settings

2011-11-09 Thread Chris Wilson
On Wed, 09 Nov 2011 15:11:40 +0100, Michel Alexandre Salim wrote: > From ab11cf4b1b28d0abb1db8bc992d016b257489ab5 Mon Sep 17 00:00:00 2001 > From: Michel Alexandre Salim > Date: Wed, 9 Nov 2011 14:18:45 +0100 > Subject: [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC > setting

[Intel-gfx] [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC settings

2011-11-09 Thread Michel Alexandre Salim
>From ab11cf4b1b28d0abb1db8bc992d016b257489ab5 Mon Sep 17 00:00:00 2001 From: Michel Alexandre Salim Date: Wed, 9 Nov 2011 14:18:45 +0100 Subject: [PATCH] drm/i915: Prioritize SSC quirk table when determining SSC settings Commit 72bbe58cd9568c7766cc219a779ea68a02132797 makes the check against th

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-09 Thread Wu Fengguang
Hi Christopher, > Now, onto the intel-gpu-tools test. I ran intel_audio_dump as requested > and it only comes back with "Couldn't map MMIO region: No such file or > directory". I spent 10 minutes looking around on Google to no avail. It > seems it tries to mmap() something that doesn't exist.

Re: [Intel-gfx] [PATCH v5] drm/i915: pass ELD to HDMI/DP audio driver

2011-11-09 Thread Christopher White
Good day, Fengguang! Great work! This sounds very promising! I went through the ELD parsing code myself (drm_edid_to_eld), as my programmer mind's curiosity killed me even though I didn't really have time for it, and I could see that it grabs the CEA extension block, grabs the monitor name str