Re: 8027848: The ZoneInfoFile doesn't honor future GMT offset changes

2013-11-06 Thread Xueming Shen
Looks fine. thanks! -Sherman On 11/05/2013 03:21 PM, Aleksej Efimov wrote: Sherman, Thank you for a quick review. I totally agree with you on all items. Actually, I missed fact that the transitions are sorted. And yes - the change can be done on line #431. The new tested fix can be found here

Re: [8]: diff patch for jdk test on a non US platform

2013-11-06 Thread Naoto Sato
Thank you, Francis. I created the following CR for those ResourceBundle test failures: https://bugs.openjdk.java.net/browse/JDK-8027930 Naoto On 11/5/13 10:31 PM, Francis ANDRE wrote: HI To add a little bit more of clarity for the i18n problems in the ResourceBundle tests, joined is an extra

Re: RFR: 8027370: (tz) Support tzdata2013h

2013-11-06 Thread Aleksej Efimov
Hi, We have a fix for JDK-8027848 and it was approved in parallel thread. With '-XX:-UseMathExactIntrinsics' tests run flag and applied fix for JDK-8027848 all tests from the following test sets are passing: test/sun/util/calendar test/java/util/Calendar test/sun/util/resources/TimeZone test/s

Re: 8027848: The ZoneInfoFile doesn't honor future GMT offset changes

2013-11-06 Thread Aleksej Efimov
Sherman, thank you for reviewing it! -Aleksej On 11/06/2013 09:18 PM, Xueming Shen wrote: Looks fine. thanks! -Sherman On 11/05/2013 03:21 PM, Aleksej Efimov wrote: Sherman, Thank you for a quick review. I totally agree with you on all items. Actually, I missed fact that the transitions are

Re: [8]: diff patch for jdk test on a non US platform

2013-11-06 Thread Francis ANDRE
HI To add a little bit more of clarity for the i18n problems in the ResourceBundle tests, joined is an extract from the log of their failures before I fixed them for the non US Locale case. Sorry for not having joined this log before. HTH Francis Le 06/11/2013 00:4

Re: [8]: diff patch for jdk test on a non US platform

2013-11-06 Thread Naoto Sato
And here is the proposed webrev. Please review: http://cr.openjdk.java.net/~naoto/8027930/webrev.00/ Naoto On 11/6/13 9:47 AM, Naoto Sato wrote: Thank you, Francis. I created the following CR for those ResourceBundle test failures: https://bugs.openjdk.java.net/browse/JDK-8027930 Naoto On 1

Re: [8]: diff patch for jdk test on a non US platform

2013-11-06 Thread Stuart Marks
On 11/5/13 10:31 PM, Francis ANDRE wrote: To add a little bit more of clarity for the i18n problems in the ResourceBundle tests, joined is an extract from the log of their failures before I fixed them for the non US Locale case. Sorry for not having joined this log before. By the way, it looks

Re: [8]: diff patch for jdk test on a non US platform

2013-11-06 Thread Stuart Marks
Hi Naoto, The changes look sensible, though I'm not an expert in the ResourceBundle API. I did notice though that in ResourceBundleTest.java there is a static import of java.util.ResourceBundle.Control. Does it need to be a static import? Surprisingly, it seems to compile either way. s'marks

Re: [8]: diff patch for jdk test on a non US platform

2013-11-06 Thread Naoto Sato
Thank you for the review, Stuart. I just wanted to get rid of "Control" in front of "FORMAT_DEFAULT", but silly me, I did not do that! And it does not seem to make much sense using static import just for that purpose. I will remove "static" from the proposed fix. Naoto On 11/6/13 4:11 PM, S

Review Request - 8027695: There should be a space before % sign in Swedish locale

2013-11-06 Thread Yong Huang
Hello, Please review the fix of https://bugs.openjdk.java.net/browse/JDK-8027695 The webrev is http://cr.openjdk.java.net/~yhuang/8027695/webrev.00/ thanks, Yong

Re: [8]: diff patch for jdk test on a non US platform

2013-11-06 Thread Francis ANDRE
Hi Naoto And what will happen to the other non US locale problem? Will they get fix also? Francis Le 06/11/2013 23:36, Naoto Sato a écrit : And here is the proposed webrev. Please review: http://cr.openjdk.java.net/~naoto/8027930/webrev.00/ Naoto On 11/6/13 9:47 AM, Naoto Sato wrote: Than