On 10/07/2012 21:42, Naoto Sato wrote:
Hello,
Please review the JDK8 changes for JEP 127: Improve Locale Data
Packaging and Adopt Unicode CLDR Data
(http://openjdk.java.net/jeps/127). The webrev is located at:
http://cr.openjdk.java.net/~naoto/6336885/webrev.00/
There's a lot here, lots of g
Hi, Naoto.
Wow. Tons of fantastic work!
Looks like many files contain fairly trivial changes related to resources being
moved to another package, but there are many others which require more careful
review.
Scanning the list of files in the webrev, one comment pops to mind. You've
made ch
Hi Iris,
Thank you for your comment. We had a meeting with the build infra team
when Erik was here last week, so they are aware of this change. The
initial review request actually involved 'build-dev' alias besides
'i18n-dev' and 'core-libs-dev'.
Naoto
On 12/07/13 11:32, Iris Clark wrote:
Hi, Naoto.
Fantastic! Sorry I didn’t catch that 'build-dev' was in the set of reviewers.
Thanks for being on top of this.
iris
-Original Message-
From: Naoto Sato
Sent: Friday, July 13, 2012 11:59 AM
To: Iris Clark
Cc: Alan Bateman; Java Core Libs; i18n-dev
Subject: Re: [8] Review re
Something seems strange here:
http://cr.openjdk.java.net/~naoto/6336885/webrev.00/make/java/java/localegen.sh.sdiff.html
It's like someone was avoiding overall quotes, but using them to add spaces
somehow...
I sure would like to get rid of this shell logic, seems like there are lots
repeated
Hi Kelly,
The shell script in question is pretty likely to be removed, or at least
rewritten when we make modifications for Jigsaw packaging of the locale
data. Right now the script creates the pre-baked locale list based on
the existing resource bundle source files in the repository, but that
