Hi, Naoto. Fantastic! Sorry I didn’t catch that 'build-dev' was in the set of reviewers.
Thanks for being on top of this. iris -----Original Message----- From: Naoto Sato Sent: Friday, July 13, 2012 11:59 AM To: Iris Clark Cc: Alan Bateman; Java Core Libs; i18n-dev Subject: Re: <i18n dev> [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data Hi Iris, Thank you for your comment. We had a meeting with the build infra team when Erik was here last week, so they are aware of this change. The initial review request actually involved 'build-dev' alias besides 'i18n-dev' and 'core-libs-dev'. Naoto On 12/07/13 11:32, Iris Clark wrote: > Hi, Naoto. > > Wow. Tons of fantastic work! > > Looks like many files contain fairly trivial changes related to resources > being moved to another package, but there are many others which require more > careful review. > > Scanning the list of files in the webrev, one comment pops to mind. You've > made changes to the current make files and some of the tools used during > make. Does the build-infra team need to make similar/appropriate changes in > the new system? If they haven't already been brought into the loop, you > might want to do so soon. > > Thanks, > iris > > -----Original Message----- > From: Alan Bateman > Sent: Friday, July 13, 2012 8:03 AM > To: Naoto Sato > Cc: Java Core Libs; i18n-dev > Subject: Re: <i18n dev> [8] Review request for JEP 127: Improve Locale > Data Packaging and Adopt Unicode CLDR Data > > On 10/07/2012 21:42, Naoto Sato wrote: >> Hello, >> >> Please review the JDK8 changes for JEP 127: Improve Locale Data >> Packaging and Adopt Unicode CLDR Data >> (http://openjdk.java.net/jeps/127). The webrev is located at: >> >> http://cr.openjdk.java.net/~naoto/6336885/webrev.00/ > There's a lot here, lots of good work but way too much for me to review. > However just one comment to say that the new layout for the resources and > locales will make it a lot easier to modularize so this aspect is very > welcome. > > -Alan. >
