Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-29 Thread Aleksej Efimov
Alan, I want to keep this test until I'll came up with new regression test . And I might will come up with some idea on this test modifications instead of deletion. So thats why I put it to ProblemsList.txt instead of deletion - some sort put it on hold with no impact to JDK 8 release process.

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-29 Thread Alan Bateman
On 24/10/2013 14:32, Aleksej Efimov wrote: Alan, Masayoshi, Michael, If you agree with the proposed changes then we can proceed with closing this bug. Can I ask you to sponsorship this change in such case? The hg patch located here: http://cr.openjdk.java.net/~aefimov/8026772/8026772_jdk8.patc

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-28 Thread Masayoshi Okutsu
Looks good as a temporary solution. Thanks, Masayoshi On 10/24/2013 11:47 PM, Michael Fang wrote: Hi Aleksej, The proposed change is fine for me. thanks, -michael On 13?10?24? 06:32 ??, Aleksej Efimov wrote: Alan, Masayoshi, Michael, If you agree with the proposed changes then we can proc

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Michael Fang
Agreed. It was unnecessary, but it was the practice at that time. thanks, -michael On 13?10?24? 01:55 ??, Masayoshi Okutsu wrote: The test detected the translation changes as regression, but that was unnecessary? I prefer to remove this test rather than changing the data. Thanks, Masayoshi

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Michael Fang
Hi Aleksej, The proposed change is fine for me. thanks, -michael On 13?10?24? 06:32 ??, Aleksej Efimov wrote: Alan, Masayoshi, Michael, If you agree with the proposed changes then we can proceed with closing this bug. Can I ask you to sponsorship this change in such case? The hg patch locat

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Aleksej Efimov
Alan, Masayoshi, Michael, If you agree with the proposed changes then we can proceed with closing this bug. Can I ask you to sponsorship this change in such case? The hg patch located here: http://cr.openjdk.java.net/~aefimov/8026772/8026772_jdk8.patch. Thank you, Aleksej On 10/24/2013 04:27

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Aleksej Efimov
Alan, I have added this test to ProblemList.txt and keep the test update: http://cr.openjdk.java.net/~aefimov/8026772/webrev.01/. I suppose, with such resolution we can safely close this minor bug. And we will decide this test destiny in 8025051. Thanks, Aleksej On 10/24/2013 04:00 PM, Alan B

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Alan Bateman
On 24/10/2013 10:05, Aleksej Efimov wrote: Masayoshi, As Michael said, the time zone names changes is not finalized yet and I'll add new regression test as part of 8025051 and will remove this one. So, I suggest to keep this test and later remove it. I prefer not just remove a workable/questio

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Aleksej Efimov
Masayoshi, As Michael said, the time zone names changes is not finalized yet and I'll add new regression test as part of 8025051 and will remove this one. So, I suggest to keep this test and later remove it. I prefer not just remove a workable/questionable test, but add some replacement for it.

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-24 Thread Masayoshi Okutsu
The test detected the translation changes as regression, but that was unnecessary? I prefer to remove this test rather than changing the data. Thanks, Masayoshi On 10/24/2013 12:12 AM, Michael Fang wrote: Hi Masayoshi, At that time I was asked to have regression test to validate each transla

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-23 Thread Michael Fang
Hi Masayoshi, At that time I was asked to have regression test to validate each translation changes. With our new translation process for TimeZoneNames and new planned regression tests from Aleksej for JDK-8025051 , I believe we can remove t

Re: RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-22 Thread Masayoshi Okutsu
Hi Michael, 27 *@summary Test case for tzdata2005m support for 9 locales What's the purpose of this test? Do we really need to keep this one? Thanks, Masayoshi On 10/22/2013 8:13 PM, Aleksej Efimov wrote: Hi, Can I have a review for 8026772 [1] fix. The webrev link: [2] The timezone test i

RFR: 8026772: test/sun/util/resources/TimeZone/Bug6317929.java failing

2013-10-22 Thread Aleksej Efimov
Hi, Can I have a review for 8026772 [1] fix. The webrev link: [2] The timezone test is failed because of the changed TimeZone names introduced in 8025255 [3]. This timezone names were changed according to updated translation resource files introduced by 8025215 [4]. The fix changes the hard-co