Michael Fang skrev 2012-05-22 21:58:
Thanks Erik.
I have already downloaded the raw message.properties file from the
webrev on 5/16 to proceed with the 7u6 translation.
I performed a diff with current webrev, and it consists of mostly
deleted resources and 1 renamed key CONNECTION_LOST1 =>
Erik,
I approve what you have - please go through and fix the formatting
nits. I inlined my comment below and you can follow up them later if
needed.
On 5/22/2012 12:40 PM, Erik Gahlin wrote:
Thanks for reviewing,
I got a lot of unused import warnings from the IDE when I changed the
Resour
Thanks Erik.
I have already downloaded the raw message.properties file from the
webrev on 5/16 to proceed with the 7u6 translation.
I performed a diff with current webrev, and it consists of mostly
deleted resources and 1 renamed key CONNECTION_LOST1 => CONNECTION_LOST.
I am fine with the ch
Mandy Chung skrev 2012-05-21 23:13:
Erik,
I like your idea of trying to define the string constants
for the keys to benefit from the compiler checking and
catch any issue due to typos at compile time. My review
comments below.
Your webrev includes other cleanup. While it's good to
do the simp
Erik,
I like your idea of trying to define the string constants
for the keys to benefit from the compiler checking and
catch any issue due to typos at compile time. My review
comments below.
Your webrev includes other cleanup. While it's good to
do the simple minor cleanup with this fix, I'd l
Thanks Michael,
When it comes to ALL CAPs or SturdlyCaps, it's okay if those strings are
not translated.
Here is an updated webrev. I removed strings that were no longer in use
and made some changes to the make-files.
http://cr.openjdk.java.net/~egahlin/7017818_4/
/E
Michael Fang skrev 20
