Re: jtreg test failed with Japanese datetime formatting on win32

This issue should have been fixed by bug JDK-8224142[1]. The fix had been integrated into openjdk8u222. Would you provide the OS version and Java version in your test environment? Kinder reminder, before report the issue and paste the log here, you can search the JBS[2] first. [1] https://bug

Re: RFR: 8218781 : Localized names for Japanese Era Reiwa in COMPAT provider

Thank you, pushed. /Leo On 5/19/19 9:55 PM, naoto.s...@oracle.com wrote: Looks good. Naoto On 5/18/19 6:23 AM, li.ji...@oracle.com wrote: Hi Naoto, Please review the updated webrev: http://cr.openjdk.java.net/~ljiang/8218781/webrev.01/ In this update, renamed the data provider names and te

Re: RFR: 8218781 : Localized names for Japanese Era Reiwa in COMPAT provider

Hi Naoto, Please review the updated webrev: http://cr.openjdk.java.net/~ljiang/8218781/webrev.01/ In this update, renamed the data provider names and test case name to improve the readability. Thanks, Leo On 5/18/19 12:39 AM, naoto.s...@oracle.com wrote: Hi Leo, Overall looks good. One com

RFR: 8218781 : Localized names for Japanese Era Reiwa in COMPAT provider

Hi all, Please review the change to update the l10n names for Japanese era Reiwa in JDK COMPAT provider. The l10n names come from the CLDR 35.1, please refer this unicode chart[1] for l10n definitions. Bug: https://bugs.openjdk.java.net/browse/JDK-8218781 Webrev: http://cr.openjdk.java.net/~l

Re: [PATCH] Fix typo in usage for javac

Hi Noriyuki, Very appreciated to report this typo and contribute the patch. This typo issue was introduced by the JDK 12 msg drop 10, and into JDK 13 with the forward port. As we need to fix it on translation memory side first, so we don't fix it on resource files in repo directly. File a bu

Re: UnicodeDecoder U+FFFE handling

Sounds this request is reasonable since Unicode 7: do not consider the U+FFFE in the middle of stream as malformed. FAQ about private use characters and non-characters. [1] http://www.unicode.org/faq/private_use.html Q: Are noncharacters invalid in Unicode strings and UTFs? A: Absolutely not.

RFR: 8210153 : java/text/Format/NumberFormat/CurrencyFormat.java failed

Hi Naoto, Please review the fix to update the currency symbol for VES. Bug: https://bugs.openjdk.java.net/browse/JDK-8210153 Webrev: http://cr.openjdk.java.net/~ljiang/8210153/webrev/ Built and tier1~tier3 tests passed on mach5. Thanks, Leo

RFR: 8208746 8209775 : ISO 4217 Amendment #168 #169 Update

Hi, Please review the changes for ISO 4217 Amendment #168 #169. Bugs: https://bugs.openjdk.java.net/browse/JDK-8208746 168 https://bugs.openjdk.java.net/browse/JDK-8209775 169 Only in amendment #168 has real currency data update for Java, but I also updated the data version to #169 for con

Re: [11] RFR: 8202026 8193552 8204269 : ISO 4217 Amendment #165 # 166 #167 Update

Hi Naoto, I removed the obsoleted currency LTL and LVL from tablea1.txt, added them into otherCodes in ValidateISO4217.java. new webrev as below: http://cr.openjdk.java.net/~ljiang/8202026/webrev.03/ Thanks, Leo On 05/06/2018 2:27 AM, naoto.s...@oracle.com wrote: Hi Leo, Change looks good.

Re: [11] RFR: 8202026 8193552 8204269 : ISO 4217 Amendment #165 # 166 #167 Update

Hi Naoto, Pls review the updated code: http://cr.openjdk.java.net/~ljiang/8202026/webrev.02/ - As suggested, clean up the old transition dates. - Update copyright year. - ISO 4217 Amendment #167 was published today, which discards the #166, so withdraw the change for #166 in webrev.02. Bug f