Thank you, pushed.
/Leo
On 5/19/19 9:55 PM, naoto.s...@oracle.com wrote:
Looks good.
Naoto
On 5/18/19 6:23 AM, li.ji...@oracle.com wrote:
Hi Naoto,
Please review the updated webrev:
http://cr.openjdk.java.net/~ljiang/8218781/webrev.01/
In this update, renamed the data provider names and test case name to
improve the readability.
Thanks,
Leo
On 5/18/19 12:39 AM, naoto.s...@oracle.com wrote:
Hi Leo,
Overall looks good. One comment to the test case is that I would
avoid using the name "JavaTimeSupplementary" or "JTS", as they are
the implementation detail. Actually, a DateTimeFormatException may
not necessarily be caused by a missing JavaTimeSupplementary resource
in the runtime.
Naoto
On 5/16/19 9:04 PM, li.ji...@oracle.com wrote:
Hi all,
Please review the change to update the l10n names for Japanese era
Reiwa in JDK COMPAT provider. The l10n names come from the CLDR
35.1, please refer this unicode chart[1] for l10n definitions.
Bug:
https://bugs.openjdk.java.net/browse/JDK-8218781
Webrev:
http://cr.openjdk.java.net/~ljiang/8218781/webrev.00/
In this change,
- update the l10n names if they are defined in CLDR 35.1.
- update the l10n names to Reiwa, Reiwa, R for FULL, SHORT, NARROW
style respectively.
- In FormatData_th.java, the localized single character was used
for previous eras. But we don't find the corresponding name in CLDR
35.1. Update it to 'R' according to CLDR 35.1.
[1]
https://www.unicode.org/cldr/charts/latest/by_type/date_&_time.japanese.html
Thanks,
Leo
