Re: RFR: 8152926: PropertyResourceBundle constructor don't understand the System.setProperty change

+1 Thanks, -- Yuka On 2016/10/22 9:00, Naoto Sato wrote: Looks good. Naoto On 10/21/16 12:43 AM, Masayoshi Okutsu wrote: Hi, Please review the fix for JDK-8152926. This is a doc fix to clarify initialization of the encoding information with the java.util.PropertyResourceBundle.encoding prop

Re: RFR: 8165804: Revisit the way of loading BreakIterator rules/dictionaries

+1 On 2016/10/21 1:24, Naoto Sato wrote: Looks good to me. Naoto On 10/20/16 1:33 AM, Masayoshi Okutsu wrote: Hi, Please review the changes for JDK-8165804 which is a follow-up of JDK-8076757. Some notes on the changes. - Removed INCLUDES := $(TEXT_PKG_LD) from make/gendata/GendataBreakIter

Re: RFR: JDK-8167992 : Update documentation of java.util.Date class

Looks good to me. Thanks, -- Yuka On 2016/10/17 19:14, Rachna Goel wrote: Hi Masayoshi, Thanks for the review. I have updated href to have double quotes. http://cr.openjdk.java.net/~rgoel/JDK-8167992/webrev.01/ Thanks, Rachna On 10/17/16 3:00 PM, Masayoshi Okutsu wrote: Hi Rachna, Use of

Re: Review Request for JDK-8165466: DecimalFormat percentage format can contain unexpected %

Hi Nisht, The fix looks good to me. Thanks, -- Yuka On 2016/10/03 19:56, Nishit Jain wrote: Hi, Please review the fix for JDK-8165466 Bug: https://bugs.openjdk.java.net/browse/JDK-8165466 Webrev: http://cr.openjdk.java.net/~nishjain/8165466/webrev.04/ Fix: FastPathData was not reinitializ

Re: RFR:JDK-8166993: Typo in java.util.Locale

Hi Rachna, The fix looks good to me. Thanks, -- Yuka On 2016/10/03 16:22, Rachna Goel wrote: Hi, Please review this simple documentation fix for JDK-8166993. Bug : https://bugs.openjdk.java.net/browse/JDK-8166993 webrev :http://cr.openjdk.java.net/~rgoel/JDK-8166993/webrev/ Thanks, Rachna

Re: RFR: 8157792: After Integrating tzdata2016d the test/sun/util/calendar/zi/TestZoneInfo310.java fails for "Asia/Oral" and "Asia/Qyzylorda" Timezones

Hi, The fix looks good to me. Thanks, -- Yuka On 2016/08/30 13:45, Masayoshi Okutsu wrote: Hi, Please review the fix for JDK-8157792. When a zone item wasn't used for any standard-daylight transition, the zone information was discarded. Therefore, its GMT offset change wasn't taken. Issue

Re: RFR: JDK-8150710: java/util/Locale/LocaleProviders.sh fails with RuntimeException: Format failed

Sorry, I used a wrong url... Correct location is http://cr.openjdk.java.net/~peytoia/8150710/webrev.00/ Thanks, -- Yuka On 2016/08/23 16:23, Yuka Kamiya wrote: Hello, http://cr.openjdk.java.net/~peytoia/7068008/webrev.00/ Please review a simple fix for: https://bugs.openjdk.java.net/browse

RFR: JDK-8150710: java/util/Locale/LocaleProviders.sh fails with RuntimeException: Format failed

Hello, http://cr.openjdk.java.net/~peytoia/7068008/webrev.00/ Please review a simple fix for: https://bugs.openjdk.java.net/browse/JDK-8150710 The change is to make a testdata generator use ASCII digits. Thanks, -- Yuka

RFR: JDK-7094818, JDK-8132861 and JDK-8134733

Hello, http://cr.openjdk.java.net/~peytoia/7094818.8132861.8134733/webrev.00/ Please review the fix for the following bugs: https://bugs.openjdk.java.net/browse/JDK-7094818 https://bugs.openjdk.java.net/browse/JDK-8132861 https://bugs.openjdk.java.net/browse/JDK-8134733 Thanks, -- Yuka

Re: Review Request for JDK-8129555: DateFormatSymbols: month-related methods must refer to Calendar constants

+1 On 2016/08/16 14:38, Masayoshi Okutsu wrote: Looks good to me. Masayoshi On 8/16/2016 2:26 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8129555 Bug: https://bugs.openjdk.java.net/browse/JDK-8129555 Webrev: http://cr.openjdk.java.net/~nishjain/8129555/webrev.02/ Fix: Added r

Re: Review Request for JDK-8035133: Locale matching: Weight q=0 isn't handled correctly.

Hi Nishit, The fix looks okay to me. Thanks, -- Yuka On 2016/08/02 14:53, Nishit Jain wrote: Hi, Please review the fix for JDK-8035133 Bug: https://bugs.openjdk.java.net/browse/JDK-8035133 Webrev: http://cr.openjdk.java.net/~nishjain/8035133/webrev.03/ Fix: Changed the filter and lookup me

Re: Review Request for JDK-8055900: j.t.SimpleDateFormat spec needs to be clarified regarding month patterns

Hi, The fix looks okay to me. Thanks, -- Yuka On 2016/07/07 16:17, Nishit Jain wrote: Hi, Please review the fix for JDK-8055900 Bug: https://bugs.openjdk.java.net/browse/JDK-8055900 Webrev: http://cr.openjdk.java.net/~nishjain/8055900/webrev.02/ Fix: A clarification regarding the context s

Re: RFR: 8136356: Add time zone mappings on Windows

Hi, The fix looks good to me. Thanks, -- Yuka On 2016/07/05 12:57, Masayoshi Okutsu wrote: Hi, Please review the fix for JDK-8136356. This fix addresses time zone changes of KB3039024, KB3148851, KB914387, and KB3162835. Issue: https://bugs.openjdk.java.net/browse/JDK-8136356 Webrev: htt

RFR: JDK-7090039: Wrong link in comment of java.text.DateFormatSymbols

Hi, Please review a simple doc fix. https://bugs.openjdk.java.net/browse/JDK-7090039 --- a/src/java.base/share/classes/java/text/DateFormatSymbols.java +++ b/src/java.base/share/classes/java/text/DateFormatSymbols.java @@ -221,7 +221,7 @@ * The zone ID is not localized; it's one of the va

Re: Review Request for JDK-8159420 : The LanguageRange.parse() method is throwing IllegalArgumentException in Turkish Locale

+1 On 2016/06/17 17:40, Masayoshi Okutsu wrote: Looks good. Thanks, Masayoshi On 6/17/2016 5:16 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8159420 Bug: https://bugs.openjdk.java.net/browse/JDK-8159420 Webrev: http://cr.openjdk.java.net/~nishjain/8159420/webrev.04/ Fix: Change

Re: Review Request for JDK-8135061: java.util.Locale#lookup throws java.lang.StringIndexOutOfBoundsException for range having '-' as second character

+1 Thanks, -- Yuka On 2016/06/14 11:27, Masayoshi Okutsu wrote: Looks good to me. Masayoshi On 6/13/2016 6:54 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8135061 Bug: https://bugs.openjdk.java.net/browse/JDK-8135061 Webrev: http://cr.openjdk.java.net/~nishjain/8135061/webrev.0

Re: Review Request for JDK-8040211: Update LSR datafile for BCP 47

+1 On 2016/06/10 17:17, Masayoshi Okutsu wrote: Looks good to me. Masayoshi On 6/10/2016 3:20 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8040211 Bug: https://bugs.openjdk.java.net/browse/JDK-8040211 Webrev: http://cr.openjdk.java.net/~nishjain/8040211/webrev.02/ Fix: Updated

Re: Review Request for JDK-8047780: Locale.LanguageRange() throws an undocumented IAE when range is ill-formed.

+1 On 2016/06/08 12:31, Masayoshi Okutsu wrote: Looks good. Masayoshi On 6/7/2016 2:20 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8047780 Bug: https://bugs.openjdk.java.net/browse/JDK-8047780 Webrev: http://cr.openjdk.java.net/~nishjain/8047780/webrev.01/ Fix: Added in the a

Re: Review Request for JDK-8072099: Format "ha" is unable to parse hours 10-12

Hi, The fix looks good to me. Thanks, -- Yuka On 2016/05/31 15:00, Nishit Jain wrote: Hi, Please review the fix for JDK-8072099. Webrev: http://cr.openjdk.java.net/~nishjain/8072099/webrev.03/ Bug: https://bugs.openjdk.java.net/browse/JDK-8072099 Fix: Changes are made to consider the numb

Re: Review Request for JDK-8145136:Upgrade CLDR locale data

+1 On 2016/05/30 8:15, Masayoshi Okutsu wrote: Other than the copyright year things, all looks good to me. I don't think further review is required for copyright update. Masayoshi On 5/28/2016 3:25 AM, Naoto Sato wrote: Hi Rachna, Here are my comments to the webrev (I am assuming the tool t

Re: Review Request for JDK-8158025: Typo in java.util.Locale

+1 On 2016/05/30 15:04, Masayoshi Okutsu wrote: Looks good to me. Masayoshi On 5/30/2016 3:00 PM, Nishit Jain wrote: Hi, Please review the fix for JDK-8158025. Webrev : http://cr.openjdk.java.net/~nishjain/8158025/webrev.00/ Bug: https://bugs.openjdk.java.net/browse/JDK-8158025 Fix: corre

Re: RFR: 8039565: Remove test exclusion for java/util/ResourceBundle/RestrictedBundleTest.java

Hi, The fix looks good to me. Thanks, -- Yuka On 2016/05/30 14:05, Masayoshi Okutsu wrote: Hi, Please review the fix for JDK-8039565. I don't think it's worth keeping this old test and decided to remove it. Issue: https://bugs.openjdk.java.net/browse/JDK-8039565 Webrev: http://cr.openjdk

Re: RFR: 8031145: Re-examine closed i18n tests to see it they can be moved to the jdk repository.

Hi, The fix looks okay to me. Thanks, -- Yuka On 2016/05/26 18:41, Masayoshi Okutsu wrote: Naoto pointed out that test/java/text/Format/common/*Format.props should have the copyright header. Unfortunately, test/java/text/Format/common/PParser.java, which parses the .props files, doesn't supp

Re: Review Request for JDK-7102969 and JDK-8157138: "currency.properties supercede..." and "Error while fetching currency instance..."

Hi Nishit, The fix looks okay to me. Thanks, -- Yuka On 2016/05/19 16:04, Nishit Jain wrote: Hello All, Please review the updated webrev synced with the latest repository. http://cr.openjdk.java.net/~nishjain/7102969_and_8157138/webrev.08/ Regards, Nishit Jain On 5/18/2016 3:42 PM, Nishit J

Re: CFV: New Internationalization Group Lead: Masayoshi Okutsu

Vote: yes On 2016/04/13 2:02, Naoto Sato wrote: I hereby nominate Masayoshi Okutsu to Internationalization Group Lead [1]. Masayoshi is an active member in the Internationalization group since the inception, and ideal for the role. Votes are due by 10:00am (Pacific Time), April 26, 2016. O

Re: Review Request for JDK-8150324: java/util/Currency/CurrencyTest.java does not restore default TimeZone

Hi Nishit, Can you please replace "jdk/src/share/classes/java/util/CurrencyData.properties" in a comment in the test program with "jdk/make/data/currency/CurrencyData.properties" ? Otherwise, your fix looks good to me. Thanks, -- Yuka On 2016/04/11 19:55, Nishit Jain wrote: Hello All, Ple

RFR: JDK-7129443: (cal) Difference between comment and implementation of DAY_OF_WEEK_IN_MONTH

Hi, I'm sending this RFR in place of Nishit Jain.This is a small doc change. Please review the webrev for the JDK-7129443 Bug: https://bugs.openjdk.java.net/browse/JDK-7129443 Webrev: http://cr.openjdk.java.net/~peytoia/Nishit/7129443/webrev.00/ Thanks, -- Yuka

Re: Review Request for JDK-8031992 : Add Kannada support to the JDK

Hi Nishit, The fix looks good to me. Thanks, -- Yuka On 2016/03/24 14:27, Nishit Jain wrote: Hello All, Please review the following fix in "windows.fontconfig.properties" Bug: https://bugs.openjdk.java.net/browse/JDK-8031992 Webrev: http://cr.openjdk.java.net/~rgoel/Nishit/8031992/webrev.01/

Re: Review Request for JDK-8149735-java/util/Currency/PropertiesTest.sh fails with java.io.FileNotFoundException

Hi Rachna, The fix looks good to me. Thanks, -- Yuka On 2016/04/04 15:33, Rachna Goel wrote: Hello all, Please review fix for JDK-8149735. Please find links to Bug and proposed fix below. https://bugs.openjdk.java.net/browse/JDK-8149735 http://cr.openjdk.java.net/~rgoel/8149735/webrev/

Re: RFR: 8152077: (cal) Calendar.roll does not always roll the hours during daylight savings changes

Hi, The fix looks good to me. Thanks, -- Yuka On 2016/03/29 16:55, Masayoshi Okutsu wrote: Hello, Please review the fix for JDK-8152077. There's a bug in the roll method around the standard/daylight saving time transitions. I've changed the implementation to perform the "roll" operation bas

Re: Review Request for JDK-7015696: The new currency symbols 20B9 (INDIAN RUPEE), 20BA (TURKISH LIRA), 20BD (RUBLE SIGN) not displayed

Hi Nishit, The fix looks good to me. Thanks, -- Yuka On 2016/03/24 14:14, Nishit Jain wrote: Hello All, Please review the following fix in "windows.fontconfig.properties" Bug: https://bugs.openjdk.java.net/browse/JDK-7015696 Webrev: http://cr.openjdk.java.net/~rgoel/Nishit/7015696/webrev.00/

Re: RFR: JDK-8087104: DateFormatSymbols triggers this.clone() in the constructor

Hi Ramanand, Your fix looks good to me. Thanks, -- Yuka On 2016/03/02 14:34, Ramanand Patil wrote: Hi all, May I request one more review for this bug? [Thank you Masayoshi for your review.] Regards, Ramanand. -Original Message- From: Masayoshi Okutsu Sent: Wednesday, February 24,

Re: Review Request for JDK-8074411: Describe "minor unit" and/or "default fraction digits" in Currency class' javadoc clearly

Hi Nishit, Your fix looks good to me. Thanks, -- Yuka On 2016/02/15 21:08, Nishit Jain wrote: Hello All, Please review the following fix in "/Currency.java/". Bug: https://bugs.openjdk.java.net/browse/JDK-8074411 Webrev: http://cr.openjdk.java.net/~rgoel/Nishit/8074411/

RFR: JDK-8026766: Add toString() to j.u.Locale.LanguageRange.

Hi, Please review this simple fix for JDK-8026766: Add toString() to j.u.Locale.LanguageRange. https://bugs.openjdk.java.net/browse/JDK-8026766 http://cr.openjdk.java.net/~peytoia/8026766/webrev.00/ Of course, this is an approved API addition. Thanks, -- Yuka

Re: Review Request: JDK-7047633 remove @ignore 6876961 from test/java/util/ResourceBundle/Test4300693.java

Hi Naveen, Your fix looks good to me. Thanks, -- Yuka On 2015/11/24 22:01, Naveen Kumar wrote: Hi All, Please review the following fix in (jtreg) test for jdk9 Bug: https://bugs.openjdk.java.net/browse/JDK-7047633 webrev: http://cr.openjdk.java.net/~okutsu/naveen/7047633/webrev.00/

Re: Review request :JDK-7011840:TEST_BUG java/util/Locale/LocaleEnhanceTest.java

Hi Rachna, The fix looks good to me. Thanks, -- Yuka On 2015/11/20 19:56, Rachna Goel wrote: Hi all, Please review a simple fix to JDK-7011840. Extra information is outputted to report if Serialized test case data is not found. issue: https://bugs.openjdk.java.net/browse/JDK-7011840

Re: Review Request: JDK-8073211 javadoc of Format parseObject methods should specify NullPointerExceptions

Hi, The fix looks good to me. Thanks, -- Yuka On 2015/11/20 19:20, Naveen Kumar wrote: Hi, Please consider this updated webrev.01 for the review of bug JDK-8073211 Bug:https://bugs.openjdk.java.net/browse/JDK-8073211 webrev: http://cr.openjdk.java.net/~okutsu/naveen/807321

Re: [9] RFR: 8141243: Unexpected timezone returned after parsing a date

Hi, The fix looks good to me. Thanks, -- Yuka On 2015/11/20 17:24, Masayoshi Okutsu wrote: Hello, This is a follow up of the fix for JDK-8141243 done by Ramanand. I've changed resources so that time zone ID "UTC" is picked up by SimpleDateFormat before Antarctica/Troll. issue: https://bug

Re: Review Request:JDK-8061287-Update i18n tests to remove references of jre dir

Hi Rachna, The fix looks good to me. Thanks, -- Yuka On 2015/10/22 3:00, Rachna Goel wrote: Hi all, Please review a small change in PropertiesTest.sh. Please find attached diff generated from "hg diff". Thanks, Rachna

[9] RFR: 8072600: Unicode 8 support

Hello, Please review a small change for 8072600: Unicode 8 support. Mainly date update from Unicode 7. JEP: http://openjdk.java.net/jeps/267 Issue: https://bugs.openjdk.java.net/browse/JDK-8072600 webrev: http://cr.openjdk.java.net/~peytoia/8072600/ Thanks, -- Yuka

Re: RFR: 8138716: (tz) Support tzdata2015g

Hi Aleksej, Looks good to me. Thanks, -- Yuka On 2015/10/03 2:47, Aleksej Efimov wrote: Hi, Please, help to review the latest tzdata integration [1] fix to JDK9: http://cr.openjdk.java.net/~aefimov/tzdata/2015g/9/00/index.html Testing shows no failures in time zones related tests. With Bes

Re: Review Request:JDK-8075315:Change in API doc

Hi Rachna, Looks good to me. (We should solve the mixing of "" and "{@code }" in the future, though) Thanks, -- Yuka On 2015/10/03 2:50, Rachna Goel wrote: Hi All, Please review the following fix in API doc for jdk9. Reference to Bug: https://bugs.openjdk.java.net/browse/JDK-8075315 W

RFR: 8032446: Support Unicode 7.0.0 in JDK 9

Hello, Please review the fix for 8032446 to support Unicode 7 in JDK 9. https://bugs.openjdk.java.net/browse/JDK-8032446 http://cr.openjdk.java.net/~peytoia/8032446/webrev.00/ - Internal review for both open & closed parts has been completed. - Changes in sun.text.* packages are mostly porting f

Re: [9] RFR: 7044727: (tz) TimeZone.getDefault() call returns incorrect value in Windows terminal session

Hi, The fix looks good to me. Thanks, -- Yuka On 2015/04/16 14:37, Masayoshi Okutsu wrote: Hello, Please review the fix for JDK-7044727. This fix supports time zone redirection for Windows terminal sessions. (There are still obsolete code for NT/86. But it's a lot of work to eliminate them

Re: [9] RFR: 8075173: DateFormat in german locale returns wrong value for month march

Hi, The fix looks good to me. Thanks, -- Yuka On 2015/03/24 18:29, Masayoshi Okutsu wrote: Hi, Please review the fix for 8075173. There's an inconsistent month abbreviation between the traditional JDK resources and CLDR-derived ones. We decided to take the CLDR one, Mär. Bug report: http

Re: [9] RFR: 8072602: Unpredictable timezone on Windows when OS's timezone is not found in tzmappings

Hi, The fix looks ok to me. Thanks, -- Yuka On 2015/02/18 17:54, Masayoshi Okutsu wrote: Hi, Could you please review the fix for 8072602? On Windows, the time zone detection code always used "GMT" if the Windows time zone can't be mapped to an Olson time zone ID. This fix is to use a custo

Re: [9] Review request for 8055798: Japanese translation for a warning from javac looks incorrect.

Hi Michael, The fix looks good to me. Thanks, -- Yuka On 2014/11/18 12:31, Michael Fang wrote: Hi, Please help to code review the changes for the following CR for jdk9: 8055798: Japanese translation for a warning from javac looks incorrect. https://bugs.openjdk.java.net/browse/JDK-8055798 T

Re: [7u-dev] Request for approval: 8059206: (tz) Support tzdata2014i

Hi, The fix for 7u looks ok to me. Thanks, -- Yuka On 2014/11/05 5:23, Aleksej Efimov wrote: Hi, Can I ask for the review of this almost-unaltered JDK7 backport? With Best Regards, Aleksej On 03.11.2014 12:14, Seán Coffey wrote: Approved pending a peer review of the JDK7u changes. regards

Re: [9] RFR: 8060006: No Russian time zones mapping for Windows

Hi, The fix looks good to me. Thanks, -- Yuka On 2014/10/10 13:40, Masayoshi Okutsu wrote: Hello, Please review the fix for 8060006, adding new Windows time zone mappings from KB2794119 and KB2998527. Bug: https://bugs.openjdk.java.net/browse/JDK-8060006 Fix: diff --git a/src/java.base/

Re: [9] RFR: 8033627: UTC+02:00 time zones are not detected correctly on Windows

Hi, The fix looks good to me. Thanks, -- Yuka (5/23/14, 17:37), Masayoshi Okutsu wrote: Hello, Could you please review the fix for JDK-8033627? This is lib/tzmappings update due to the Windows KB2794119 update. JBS: https://bugs.openjdk.java.net/browse/JDK-8033627 Webrev: http://cr.openjd

Re: RFR: 8043012: (tz) Support tzdata2014c

Hi, The fix looks good to me. Thanks, -- Yuka (5/15/14, 7:59), Aleksej Efimov wrote: Hello, Can I have a review for the tzdata2014c integration to JDK9. This is a standard release of tzdata (except the hurry with Egypt rules - the main part in this release). The following set of tests was e

Re: [9] RFR: 8041791 : String.toLowerCase regression (JDK-8020037) - violates Unicode

Looks good to me. Thanks, -- Yuka (5/13/14, 2:51), Naoto Sato wrote: Hello, Please review the fix for the following regression: https://bugs.openjdk.java.net/browse/JDK-8041791 The proposed change is located at: http://cr.openjdk.java.net/~naoto/8041791/webrev.00/ Now the new code lowercas

RFR: [9] 8042360: Subtag syntax check is incomplete in Locale.LanguageRange

Hello, Please review a simple fix for JDK 9: Bug description: https://bugs.openjdk.java.net/browse/JDK-8042360 Webrev: http://cr.openjdk.java.net/~peytoia/8042360/webrev.00/ Thanks, -- Yuka

[9] RFR: 8035726: A sentence is truncated in the API doc for j.u.Locale.LanguageRange.parse(String, Map).

Hello, Please review a simple doc fix to add a missing line. http://cr.openjdk.java.net/~peytoia/8035726/webrev.00/ https://bugs.openjdk.java.net/browse/JDK-8035726 Thanks, -- Yuka

Re: Request for a JEP for JDK9 (Unicode support)

reball.net/projects/markdown/syntax -----Original Message- From: Yuka Kamiya Sent: Wednesday, March 26, 2014 12:11 AM To: i18n-dev Subject: Request for a JEP for JDK9 (Unicode support) Hello, This is a JEP to support the latest version of Unicode in JDK 9. I'd appreciate your comments/su

Request for a JEP for JDK9 (Unicode support)

Hello, This is a JEP to support the latest version of Unicode in JDK 9. I'd appreciate your comments/suggestions on: http://cr.openjdk.java.net/~peytoia/JEPs/Unicode.Next.txt https://bugs.openjdk.java.net/browse/JDK-8032446 If I don't receive objections within this month, I'll submit this JEP to

[8] RFR: JDK-8029057 : test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError

Hello, Please review the fix for: https://bugs.openjdk.java.net/browse/JDK-8029057 test/java/text/Bidi/Bug6665028.java can fail with OutOfMemoryError Fix: http://cr.openjdk.java.net/~peytoia/8029057/webrev.00/ The test program was for an old implementation which no longer exists. We decided to r

Re: RFR: 8025703: Update LSR datafile for BCP 47

Hi Masayoshi, Thank you!! -- Yuka (2013/10/17 13:41), Masayoshi Okutsu wrote: > Looks good to me. > > Masayoshi > > On 10/17/2013 10:39 AM, Yuka Kamiya wrote: >> Hi, >> >> Please review this fix for JDK 8. This is to update data for locale matching. >> &g

RFR: 8025703: Update LSR datafile for BCP 47

Hi, Please review this fix for JDK 8. This is to update data for locale matching. http://bugs.sun.com/view_bug.do?bug_id=8025703 http://cr.openjdk.java.net/~peytoia/8025703/webrev.00/ Thanks, -- Yuka

Re: [8]RFR: 8022666: java.util.Calendar.set(int, int, int, int, int, int) documentation typo

Hi, The change looks good to me. Thanks, -- Yuka (2013/10/02 16:50), Masayoshi Okutsu wrote: Hi, Please review the doc fix for the following bug: https://bugs.openjdk.java.net/browse/JDK-8022666 Webev: http://cr.openjdk.java.net/~okutsu/8/8022666/webrev.00/ Thanks, Masayoshi

Re: [8]RFR: 6902861: (cal) GregorianCalendar roll WEEK_OF_YEAR is broken for January 1 2010

Hi, The fix looks ok to me. Thanks, -- Yuka (2013/09/26 18:33), Masayoshi Okutsu wrote: Hi, Please view the fix (workaround) for the following bug. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=6902861 Added a workaround that Calendar.roll tries to stay in the same calendar year even w

Re: [8] RFR: 8024141: Unexpected timezone display name

Hi, The fix looks good to me. Thanks, -- Yuka (2013/09/06 15:05), Masayoshi Okutsu wrote: Hi, Please review the following fix: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8024141 The fix is to cache time zone name arrays in different sizes separately. The cache support and/or time z

Re: RFR JDK-8020054: (tz) Support tzdata2013d

Hi Sherman, The fix looks good to me. Thanks, -- Yuka (2013/08/09 14:54), Xueming Shen wrote: Hi, Please help review the proposed change to update the tz data in JDK8 from 2013c to 2013d. http://cr.openjdk.java.net/~sherman/8020054/webrev http://cr.openjdk.java.net/~sherman/8020054/closed

Re: Request for review - 8021108: Clean up doclint warnings and errors in java.text package

e", which isn't very clear, is > used in the getDateTimeInstance method. So "a date/time formatter" > should be fine (for this doclint cleanup). > > Otherwise, the fixes look good to me. > > Masayoshi > > On 7/25/2013 11:42 PM, Yuka Kamiya wrote: >> H

Request for review - 8021108: Clean up doclint warnings and errors in java.text package

Hello, Please review the fix for 8021108: Clean up doclint warnings and errors in java.text package for JDK 8. http://cr.openjdk.java.net/~peytoia/8021108/webrev.00/ Joe, Because java.text is not listed in TL team's feature area, ( http://openjdk.java.net/groups/core-libs/ ) I don't send this r

Re: Review request - 7064270: java/text/Format/DateFormat/WeekDateTest.java fails on OEL5.6 hi_IN.UTF-8

Hi, The fix looks good to me. Thanks, -- Yuka (2013/06/07 17:24), Masayoshi Okutsu wrote: Hello, This is a review request for the fix of: 7064270: java/text/Format/DateFormat/WeekDateTest.java fails on OEL5.6 hi_IN.UTF-8 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7064270 Webrev: h

Re: Review request - 7177315: SimpleDateFormat parses wrong 2-digit year if input contains spaces

Hi, The fix looks good to me. Thanks, -- Yuka (2013/06/06 11:50), Masayoshi Okutsu wrote: Hello, This is a review request for the fix of 7177315: SimpleDateFormat parses wrong 2-digit year if input contains spaces http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7177315 Webrev: http://c

Re: 8015880: GenerateBreakIteratorData build warning

Hi Alan, Thank you for taking care of this. I investigated how the method had been used. Your fix looks okay. It is not only safe but improves the generator's behavior. I think that we were just lucky that the method had merely wasted CPU and didn't cause a worse problem Thanks, -- Yuka

Review request for 8014469 and 8015570 for 7u40

Masayoshi, Could you please review my fix for the following bugs? http://bugs.sun.com/view_bug.do?bug_id=8014469 8014469 : (tz) Support tzdata2013c http://bugs.sun.com/view_bug.do?bug_id=8015570 (may not be browseable yet) 8015570: Use long comparison in Rule.getRules(). webrev: http://cr.openjd

Re: [8] Request for document changes review

Hi, The fix looks ok to me. Thanks, -- Yuka (2013/05/23 3:45), Naoto Sato wrote: Hello, Please review the changes for the following two simple document fixes: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7056126 http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7083668 The proposed

Re: [threeten-dev] RFR JDK-8013386: (tz) Support tzdata2013c

Hi Sherman, Sorry for my late reply. The fix looks ok to me. But please remember to file an RFE about the hardcoded timezone IDs that Masayoshi mentioned. :-) >> I'm concerned about the 24:00 fix. Is there any way to produce the correct rules without hard coding time zone IDs? > I don't know

Re: [8] Code review request: 8004489 and 8006509

Hi, The fix looks ok to me. Thanks, -- Yuka (13/01/21 14:34), Masayoshi Okutsu wrote: I've updated the webrev to address some feedback. - Added @compile -XDignore.symbol.file to CldrFormatNamesTest.java - Added the Unicode copyright to FormatData_be.java, FormatData_is.java, and FormatData_

Re: [8] Code review request: 4745761: (cal) RFE: Support builder for constructing Calendar

HI, The fix looks ok to me. Thanks, -- Yuka (13/01/16 16:21), Masayoshi Okutsu wrote: Hello. This is a review request for http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=4745761 Webrev: http://cr.openjdk.java.net/~okutsu/8/4745761/webrev.00/ Thanks, Masayoshi

Re: [8] Code review request: 8005561

Hi, It looks good to me. Thanks, -- Yuka (12/12/28 16:30), Masayoshi Okutsu wrote: Hi, This is a code review request for: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005561 (This CR isn't viewable on bugs.sun.com yet.) Webrev: http://cr.openjdk.java.net/~okutsu/8/8005561/webrev.00/

Re: [8] Code review request: 8005471

Hi, It looks ok to me. Thanks, -- Yuka (12/12/28 12:26), Masayoshi Okutsu wrote: Hi, This is a code review request for: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005471 Webrev: http://cr.openjdk.java.net/~okutsu/8/8005471/webrev.00/ Thanks, Masayoshi

Code Review request (8005277)

Hello, This is a review request for: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8005277 http://cr.openjdk.java.net/~peytoia/8005277/webrev.00/ Thanks, -- Yuka

Re: RFR : 8002227 : (tz) Support tzdata2012i

It looks ok to me. Thanks, -- Yuka (12/11/07 8:18), Seán Coffey wrote: Looking to bump up the tzdata version in jdk8 and 7u to tzdata2012i which was released recently. This request is for jdk8. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8002227 webrev : http://cr.openjdk.java.net/~c

Re: RFR : 8002227 : (tz) Support tzdata2012i

Hi Seán, The fix looks good to me. Thanks, -- Yuka (12/11/07 8:18), Seán Coffey wrote: Looking to bump up the tzdata version in jdk8 and 7u to tzdata2012i which was released recently. This request is for jdk8. http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=8002227 webrev : http://cr.op

Review request: 7069824: Support for BCP47 locale matching

Updated based on internal comments. http://cr.openjdk.java.net/~peytoia/7069824/webrev.01/ Thanks, -- Yuka (12/09/28 7:19), Yuka Kamiya wrote: > Hi, > > Please review the change for BCP 47 locale matching. > > http://cr.openjdk.java.net/~peytoia/7069824/webrev.00/ > h

Review request: 7069824: Support for BCP47 locale matching

Hi, Please review the change for BCP 47 locale matching. http://cr.openjdk.java.net/~peytoia/7069824/webrev.00/ http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7069824 Thanks, -- Yuka

Re: [8] Review request for JEP 127: Improve Locale Data Packaging and Adopt Unicode CLDR Data

Hi, It looks good to me. Thanks, -- Yuka (12/08/21 2:14), Naoto Sato wrote: I have updated the changeset by removing the copyright headers from all of the CLDR files, and added a LICENSE file at the top of CLDR source directory (src/share/classes/sun/util/cldr/resources/21_0_1). No other cha

Re: Codereview request for 7033561: Missing Unicode Script aliases

Hi Sherman, The fix looks good to me. Thanks, -- Yuka (11/04/07 5:16), Xueming Shen wrote: It appears the aliases mapping for Character.UnicodeScript is not updated accordingly when we upgraded the Unicode support to 6.0 for JDK7. The difference between the previous version (5.2) and 6.0 of

Re: Bug 100111

se, we really appreciate it if you file a new RFE for this. Thanks, -- Yuka Kamiya