Fwd: RFR: JDK-8220414 :Correct copyright headers in Norm2AllModes.java and Normalizer2.java

Hi, Kindly review fix to JDK-8220414, which updates copyright header. Bug: https://bugs.openjdk.java.net/browse/JDK-8220414 diff -r 645ba889ee5f src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java --- a/src/java.base/share/classes/sun/text/normalizer/Norm2AllModes.java Mon Jan

Re: [13] RFR: 8218948: SimpleDateFormat :: format - Zone Names are not reflected correctly during run time

Hi Naoto, This fix looks good to me. Thanks, Rachna On 3/6/19 4:50 AM, Naoto Sato wrote: Hello, Please review the fix to the following issue: https://bugs.openjdk.java.net/browse/JDK-8218948 The proposed changeset is located at: http://cr.openjdk.java.net/~naoto/8218948/webrev.00/ This

Re: [12] RFR: 8216176: Clarify the singleton description in j.t.c.JapaneseEra class

Looks good to me. On 1/8/19 11:16 PM, Naoto Sato wrote: Hello, Please review the change for the following issue: Issue: https://bugs.openjdk.java.net/browse/JDK-8216176 CSR: https://bugs.openjdk.java.net/browse/JDK-8216177 The proposed changeset is located at: http://cr.openjdk.java.net/~nao

Re: [13] RFR 8215913: [Test_bug]java/util/Locale/LocaleProvidersRun.java failed on de_DE and ja_JP locale.

Looks good to me. Thanks, Rachna On 1/7/19 12:36 PM, Dora Zhou wrote: Hi Rachna, Updated the webrev: http://cr.openjdk.java.net/~dzhou/8215913/webrev.01/ Regards, Dora On 2019/1/4 17:44, Rachna Goel wrote: Hi Dora, Kindly update copyright years in both files and add bug id in

Re: [12] RFR: 8215303: Allowing additional currency code points from later Unicode updates

Hi Naoto, just one nit, copyright year need to be updated in Character.java. Thanks, Rachna On 1/3/19 10:26 PM, Naoto Sato wrote: Hello, Please review the fix to the following issue (and its approved CSR): https://bugs.openjdk.java.net/browse/JDK-8215303 https://bugs.openjdk.java.net/brows

Re: [12] RFR: 8215303: Allowing additional currency code points from later Unicode updates

Hi Naoto, Your fix looks good to me. Thanks, Rachna On 1/3/19 10:26 PM, Naoto Sato wrote: Hello, Please review the fix to the following issue (and its approved CSR): https://bugs.openjdk.java.net/browse/JDK-8215303 https://bugs.openjdk.java.net/browse/JDK-8215305 The proposed changeset is

Re: [13] RFR 8215913: [Test_bug]java/util/Locale/LocaleProvidersRun.java failed on de_DE and ja_JP locale.

Hi Dora, Kindly update copyright years in both files and add bug id in LocaleProvidersRun.java. Other than that, it looks good to me. Thanks, Rachna On 1/4/19 7:58 AM, Dora Zhou wrote: Hello, Please help review the fix for the test bug java/util/Locale/LocaleProvidersRun.java failed on

Re: [12] RFR: 8215194: Initial size of UnicodeBlock map is incorrect

Hi Naoto, Thanks for fixing this. Your fix looks good to me. Thanks, Rachna On 12/11/18 8:21 PM, Naoto Sato wrote: Hi, Please review the fix for the following issue: https://bugs.openjdk.java.net/browse/JDK-8215194 The proposed fix is located at: http://cr.openjdk.java.net/~naoto/821519

RFR: [12] JDK-8209923 : Unicode 11.0.0

Hi, Kindly review this enhancement to support Unicode version in JDK to 11.0.0. Bug: https://bugs.openjdk.java.net/browse/JDK-8209923 patch: http://cr.openjdk.java.net/~rgoel/JDK-8209923/webrev.02/ -- Thanks, Rachna

[12] RFR:8210490:TimeZone.getDisplayName given Locale.US doesn't always honor the Locale

Hi, Kindly review fix to JDK-8210490. Bug: https://bugs.openjdk.java.net/browse/JDK-8210490 Webrev: http://cr.openjdk.java.net/~rgoel/JDK-8210490/webrev.05/ This is a regression caused by JDK-8202537, where for timezones such as Etc/GMT-5, display names got formatted according to default loca

[11] RFR: 8209047:"Illegal pattern character 'B'" IllegalArgumentException with Burmese locales

Hi, Kindly review the fix to JDK-8209047. Bug: https://bugs.openjdk.java.net/browse/JDK-8209047 webrev: http://cr.openjdk.java.net/~rgoel/JDK-8209047/webrev.03/ It is a regression caused by JDK-8202537. Because of the 'B' character introduced in the CLDR time patterns "B HH:mm:ss", "B H:mm" (w

[11]RFR:JDK-8206965: java/util/TimeZone/Bug8149452.java failed on de_DE and ja_JP locale.

Hi, Kindly review fix for JDK-8206965. Bug: https://bugs.openjdk.java.net/browse/JDK-8206965 patch: http://cr.openjdk.java.net/~rgoel/JDK-8206965/webrev.06/ This is a regression caused by JDK-8181157 due to which for some locales, timezone display names were not getting generated. Generating

[11] Review Request: 8204603: Short week days, NaN value and timezone name are inconsistent between CLDR and Java in zh_CN, zh_TW locales.

Hi, Kindly review fix to JDK-8204603. Bug: https://bugs.openjdk.java.net/browse/JDK-8204603 Fix: http://cr.openjdk.java.net/~rgoel/JDK-8204603/webrev.04/ This is a regression caused by JDK-8179071, where locale data is getting incorrectly retrieved (not following languageAliases of CLDR) for

Re: RFR: JDK-8205158: Update the .md files for 3rd party software Unicode 10.0, ICU 60.1, and CLDR v33

wrote: On 6/22/18 6:54 AM, Rachna Goel wrote: Hi, Kindly review fix to update legal files for Unicode, CLDR and ICU. Issue: https://bugs.openjdk.java.net/browse/JDK-8205158 Patch :http://cr.openjdk.java.net/~rgoel/JDK-8205158/webrev.02/ Looks okay. What are the issues that upgrades these

Re: RFR: JDK-8205158: Update the .md files for 3rd party software Unicode 10.0, ICU 60.1, and CLDR v33

Hi, Kindly ignore patch mentioned in previous mail. patch for review is : http://cr.openjdk.java.net/~rgoel/JDK-8205158/webrev.01/ Thanks, Rachna On 6/22/18 7:24 PM, Rachna Goel wrote: Hi, Kindly review fix to update legal files for Unicode, CLDR and ICU. Issue: https

RFR: JDK-8205158: Update the .md files for 3rd party software Unicode 10.0, ICU 60.1, and CLDR v33

Hi, Kindly review fix to update legal files for Unicode, CLDR and ICU. Issue: https://bugs.openjdk.java.net/browse/JDK-8205158 Patch :http://cr.openjdk.java.net/~rgoel/JDK-8205158/webrev.02/ -- Thanks, Rachna

Re: RFR: [11] 8202537: CLDR 33

...@oracle.com wrote: Hi Rachna, A couple of comments: - NumberingSystemsParseHandler.java Since the code substitutes latin digits for supplementary digits, it can skip line 68-79. - A test should be written for the above substitution. Naoto On 6/12/18 10:33 PM, Rachna Goel wrote: Hi, Kindly

RFR: [11] 8202537: CLDR 33

Hi, Kindly review fix for JDK-8202537. Fix is to upgrade Unicode consortium's CLDR data into JDK from current version 29 to 33. For more info : http://cldr.unicode.org/index/downloads/cldr-33 Bug : https://bugs.openjdk.java.net/browse/JDK-8202537 Patch: http://cr.openjdk.java.net/~rgoel/JDK-

[11] RFR JDK-8203474: Update description of "Cyrillic Supplementary" block name in Character.UnicodeBlock class.

Hi, Kindly review this small doc fix to Character.UnicodeBlock class. Bug: https://bugs.openjdk.java.net/browse/JDK-8203474 Patch: --- a/src/java.base/share/classes/java/lang/Character.javaSun May 27 12:00:16 2018 +0530 +++ b/src/java.base/share/classes/java/lang/Character.java Mon May 28

[11] RFR: JDK-8202582 : DateTimeFormatterBuilder.parseOffsetBased unnecessarily calls toString()

Hi, Kindly review this small patch for JDK-8202582. https://bugs.openjdk.java.net/browse/JDK-8202582 http://cr.openjdk.java.net/~rgoel/JDK-8202582/webrev/ Fix is to call text.subSequence() before calling toString() on input string, for more performance. -- Thanks, Rachna

Re: [11] RFR:JDK-8179071:Month value is inconsistent between CLDR and Java in some special locales

One correction: E.g "pa-PK" wil be replaced by "pa-Arab-PK", as former is a deprecated/legacy tag. On 4/27/18 12:05 PM, Rachna Goel wrote: Hi, Kindly review the fix for JDK-8179071. Bug : https://bugs.openjdk.java.net/browse/JDK-8179071 Patch: http://cr.openjdk

[11] RFR:JDK-8179071:Month value is inconsistent between CLDR and Java in some special locales

Hi, Kindly review the fix for JDK-8179071. Bug : https://bugs.openjdk.java.net/browse/JDK-8179071 Patch: http://cr.openjdk.java.net/~rgoel/JDK-8179071/webrev.03/index.html Fix is to parse and store language aliases( Deprecated and Legacy ) from CLDR's SupplemetalMetaData file. At run time, If

[11] RFR: 8191410 : Unicode 10.0.0

Hi, Please review the proposed changes for JDK-819410. Bug : https://bugs.openjdk.java.net/browse/JDK-8191410 proposed changeset is located at : http://cr.openjdk.java.net/~rgoel/JDK-8191410/webrev/ This serves as the implementation for JEP 327. -- Thanks, Rachna

Re: [11] RFR of 8146656: Wrong Months Array for DateFormatSymbols

tag switch is acceptable, but also think providing more text to describe this situation would be helpful to programmers unaware of a 13 month possibility. Cheers, -Joe On 12/19/2017 2:08 AM, Rachna Goel wrote: Hi Joe, Thanks for the comments. I have updated the CSR to have @implSpec in

Re: [10] RFR: 8195478: sun/text/resources/LocaleDataTest.java fails with java.lang.Exception

Hi Hamlin, Just one nit, Please add bug id 8195478 to sun/text/resources/LocaleDataTest.java. Thanks, Rachna On 1/17/2018 1:37 PM, Hamlin Li wrote: Would you please review the following patch? bug: https://bugs.openjdk.java.net/browse/JDK-8195478 webrev as below I have tested it locally

Re: [11] RFR of 8146656: Wrong Months Array for DateFormatSymbols

Rachna, I think the revised version with the @implSpec tag switch is acceptable, but also think providing more text to describe this situation would be helpful to programmers unaware of a 13 month possibility. Cheers, -Joe On 12/19/2017 2:08 AM, Rachna Goel wrote: Hi Joe, Thanks for the

Re: [11] RFR of 8146656: Wrong Months Array for DateFormatSymbols

12/17 2:55 PM, joe darcy wrote: Hi Rachna, On 12/19/2017 1:13 AM, Rachna Goel wrote: Hello Joe, Thanks for the review. Reason I added @implNote is that it's the case for the default implementation. Not added as a part of spec, as some implementation can just return 12 element array f

Re: [11] RFR of 8146656: Wrong Months Array for DateFormatSymbols

Thanks, Rachna On 19/12/17 2:07 PM, joe darcy wrote: Hello Rachna, On 12/18/2017 10:35 PM, Rachna Goel wrote: Hi, Kindly review API Doc fix for java.text.DateFormatSymbols. JBS Issue : https://bugs.openjdk.java.net/browse/JDK-8146656 Webrev: http://cr.openjdk.java.net/~rgoel/8146656/webr

[11] RFR of 8146656: Wrong Months Array for DateFormatSymbols

Hi, Kindly review API Doc fix for java.text.DateFormatSymbols. JBS Issue : https://bugs.openjdk.java.net/browse/JDK-8146656 Webrev: http://cr.openjdk.java.net/~rgoel/8146656/webrev/ CSR: https://bugs.openjdk.java.net/browse/JDK-8191414 -- Thanks, Rachna

JDK10 RFR of JDK-JDK-8168767: java.awt.im.InputContext API doc has a reference to extensions

Hi, Kindly review API Doc fix for java.awt.im.InputContext. JBS Issue : https://bugs.openjdk.java.net/browse/JDK-8168767 Webrev: http://cr.openjdk.java.net/~rgoel/8191123/webrev/ CSR: https://bugs.openjdk.java.net/browse/JDK-8191123 -- Thanks, Rachna

Re: RFR: JDK-8190816 : PropertiesTest.sh fails to make $WRITABLEJDK writable

Hi Martin, I am not a reviewer though, your fix looks good to me. Thanks, Rachna On 07/11/17 9:08 AM, Martin Buchholz wrote: http://cr.openjdk.java.net/~martin/webrevs/openjdk10/Currency-PropertiesTest/ -- T

Re: java 9 AKST timezone parsing

Kindly ignore my mail on subject matter. It was sent by mistake. Thanks, Rachna On 31/10/17 5:26 PM, Rachna Goel wrote: Hi Naoto, I digged into this issue today, and find that those time zone names which getting retrieved from TimeZoneNames_en.java are actually supplemented from COMPAT&#

Re: java 9 AKST timezone parsing

Hi Naoto, I digged into this issue today, and find that those time zone names which getting retrieved from TimeZoneNames_en.java are actually supplemented from COMPAT's TimeZoneNames.java. COMPAT's TimeZoneNames.java has entries like {"SystemV/YST9", AKST}, {"SystemV/

JDK10 RFR of JDK-8185841:Values from getFirstDayOfWeek() are inconsistent with CLDR

Hi, Kindly review the fix to JDK-8185841. Bug : https://bugs.openjdk.java.net/browse/JDK-8185841. patch : http://cr.openjdk.java.net/~rgoel/JDK-8185841/webrev.08/ Fix is to relocate this region dependent data. New Bundle will be generated when Locale id has non empty script and country code a

JDK10 Review Request for JDK-8178872: Decimal form is inconsistent between CLDR and Java in some special locales

Hi, Kindly review fix for JDK-8178872. https://bugs.openjdk.java.net/browse/JDK-8178872 patch : http://cr.openjdk.java.net/~rgoel/JDK-8178872/webrev.06/ fix : Inside CLDRconverter , LDML Parser should check name of container before retrieving decimal separator and grouping separator symbols

RFR: 8167273: Calendar.getDisplayNames inconsistent with DateFormatSymbols

Hi, kindly review fix for JDK-8167273. Bug : https://bugs.openjdk.java.net/browse/JDK-8167273 Patch :http://cr.openjdk.java.net/~rgoel/JDK-8167273/webrev.05/ Fix : Considering GregorianCalendar only, when CLDR is default provider [ no, no-NO, zh-HK ] have Locale providers mismatch problem. F

RFR: JDK-8167143:CLDR timezone parsing does not work for all locales

Hi, Please review fix for JDK-8167143. Bug : https://bugs.openjdk.java.net/browse/JDK-8167143 patch : http://cr.openjdk.java.net/~rgoel/JDK-8167143/webrev.03/index.html Fix : Timezone Parsing failures reasons are different for different locales. a) For Chinese Locales, At run time, as these lo

RFR : JDK-8170840 : java/util/Locale/LocaleTest.java failed

Hi, Kindly review fix for JDK-8170840. Bug :https://bugs.openjdk.java.net/browse/JDK-8170840 Fix : http://cr.openjdk.java.net/~rgoel/JDK-8170840/webrev/ Fix is to correct no of country codes returned in TestGetLangsAndCountries() method. Thanks, Rachna

Re: Request for Review : JDK-8071929 -Locale.getISOCountries() has inconsistent behaviour for "AN", "BU" and "CS" country codes.

ot; inside IsoCountryCode is somewhat strange. How about just "createCountryCodeSet()"? Also, its comment does not describe the method correctly. It does not seem a "mapping function". Naoto On 12/2/16 2:35 AM, Rachna Goel wrote: Hi Stephen, Masayoshi, Thanks for review a

Re: Request for Review : JDK-8071929 -Locale.getISOCountries() has inconsistent behaviour for "AN", "BU" and "CS" country codes.

16 7:33 AM, Rachna Goel wrote: Hi Stephen, Please find my comments inlined. On 30/11/16 5:07 PM, Stephen Colebourne wrote: The ISO-3166-3 code is of a complex form and not widely used as far as I know. As far as I can tell, it is not legal to create a Locale instance using the ISO-3166-3 code as t

Re: Request for Review : JDK-8071929 -Locale.getISOCountries() has inconsistent behaviour for "AN", "BU" and "CS" country codes.

, and what replaced it. I think that again depends on applications requirements. For this new method may need to be added, may be handled under separate JBS entry. Stephen On 30 November 2016 at 09:31, Rachna Goel wrote: Hi Stephen, Thanks a lot for the review. On 30/11/16 3:15 AM, Stephen

Re: Request for Review : JDK-8071929 -Locale.getISOCountries() has inconsistent behaviour for "AN", "BU" and "CS" country codes.

ariables as "iso" as per with JDK naming conventions. But Locale class has methods names with "ISO", So I think I will update all internal method names to have "ISO". Thanks, Rachna Stephen On 29 November 2016 at 09:07, Rachna Goel wrote: Hi, Please review fix f

Request for Review : JDK-8071929 -Locale.getISOCountries() has inconsistent behaviour for "AN", "BU" and "CS" country codes.

Hi, Please review fix for JDK-8071929. Bug : https://bugs.openjdk.java.net/browse/JDK-8071929 patch : http://cr.openjdk.java.net/~rgoel/JDK_8071929/webrev.02/ Fix is to remove obsolete country code "AN" and provide support for retrieving of ISO3166-1 alpha-2, ISO3166-1 alpha-3, ISO3166-3 cou

RFR: JDK-8075577: java.time does not support HOST provider

Hi, Please review fix for JDK-8075577. Bug : https://bugs.openjdk.java.net/browse/JDK-8075577 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8075577/webrev.01/ Fix is to introduce new private spi "sun.text.spi.JavaTimeDateTimePatternProvider.java" to retrieve LocaleProvider specific Date/Ti

RFR: JDK-8071929-Locale.getISOCountries() has inconsistent behaviour for "AN", "BU" and "CS" country codes

Hi, Please review fix for JDK-8071929. Bug : https://bugs.openjdk.java.net/browse/JDK-8071929 patch : http://cr.openjdk.java.net/~rgoel/JDK-8071929/webrev.01/ Fix is to remove obsolete country code "AN" and provide support for retrieving of ISO3166-1 alpha-2, ISO3166-1 alpha-3, ISO3166-3 cou

Re: RFR:JDK-8168906-Tighten permissions granted to the jdk.localedata module

sorry, correction to typo As jdk.localedata module does *not* read any system properties, tightened permissions for same. On 14/11/16 12:42 PM, Rachna Goel wrote: Hi, Kindly review fix for JDK-8168906. https://bugs.openjdk.java.net/browse/JDK-8168906 Patch :http://cr.openjdk.java.net

RFR:JDK-8168906-Tighten permissions granted to the jdk.localedata module

Hi, Kindly review fix for JDK-8168906. https://bugs.openjdk.java.net/browse/JDK-8168906 Patch :http://cr.openjdk.java.net/~rgoel/JDK-8168906/webrev/ fix: As jdk.localedata module does read any system properties, tightened permissions for same. Thanks, Rachna

RFR: JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider on locale de, de_DE, en_US.

Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8146750/webrev.09/ Fix is to retrieve Narrow and Narrow_Standalone Month names and Day names one by one, as they can be duplicate. Thanks, Rachna

Re: RFR: JDK-8167992 : Update documentation of java.util.Date class

;). Otherwise, the fix looks good to me. Thanks, Masayoshi On 10/14/2016 6:46 PM, Rachna Goel wrote: Hi, Please review a simple documentation fix for java.util.Date class. Bug : https://bugs.openjdk.java.net/browse/JDK-8167992 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8167992/webrev/

RFR: JDK-8167992 : Update documentation of java.util.Date class

Hi, Please review a simple documentation fix for java.util.Date class. Bug : https://bugs.openjdk.java.net/browse/JDK-8167992 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8167992/webrev/ Fix : updated links pointing to old websites. Thanks, Rachna

Re: RFR:JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider.

this fix as java.time changes. The test needs to be written for java.time. Thanks, Masayoshi On 9/28/2016 5:13 PM, Rachna Goel wrote: Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8146750/webr

RFR:JDK-8166993: Typo in java.util.Locale

Hi, Please review this simple documentation fix for JDK-8166993. Bug : https://bugs.openjdk.java.net/browse/JDK-8166993 webrev :http://cr.openjdk.java.net/~rgoel/JDK-8166993/webrev/ Thanks, Rachna

RFR:JDK-8146750:java.time.Month.getDisplayName() return incorrect narrow names with JRE provider.

Hi, Please review fix for JDK-8146750. Bug : https://bugs.openjdk.java.net/browse/JDK-8146750 webrev : http://cr.openjdk.java.net/~rgoel/JDK-8146750/webrev.03/ Fix is to retrieve Narrow and Narrow_Standalone Month names as well as Day names one by one, as they can be duplicate. Thanks, Rac

RFR: JDK-8135055.java.util.Date.after(java.sql.Timestamp ) does not return correct results

Hi, Please review fix for JDK-8135055. Bug: https://bugs.openjdk.java.net/browse/JDK-8135055 Webrev: http://cr.openjdk.java.net/~rgoel/JDK-8135055/webrev.02/ Fix is to return getTime() if argument to getMillisOf() is an instance of java.sql.TimeStamp. Thanks, Rachna

RFR: JDK-8163362-Reconsider reflection usage in java.awt.font.JavaAWTFontAccessImpl class

Hi, Please review fix for JDK-8163362. https://bugs.openjdk.java.net/browse/JDK-8163362 Webrev: http://cr.openjdk.java.net/~rgoel/JDK-8163362/webrev.01/ This is a cleanup fix in which Reflection usage in JavaAWTFontAccessImpl class was removed. Thanks, Rachna

Re: Review Request:JDK-8163350-LocaleProviderAdapter Preference list retrieved is wrong, when -Djava.locale.providers=COMPAT

ry to statically import sun.util.locale.provider.LocaleProviderAdapter.Type. - Variable name PreferenceList should be preferenceList. - No need to initialize preferenceList with an ArrayList. Thanks, Masayoshi On 8/10/2016 2:31 AM, Rachna Goel wrote: Hi Naoto, Thanks for the review. Please have a lo

Re: Review Request:JDK-8163350-LocaleProviderAdapter Preference list retrieved is wrong, when -Djava.locale.providers=COMPAT

test case. - I'd prefer a blank line between import statements and the main method. - The argument to main() should be (String[] args) - Indentation is incorrect at line 39 - Needs parens for the if statement at line 41. Naoto On 8/9/16 3:51 AM, Rachna Goel wrote: Hi, Please review f

Review Request:JDK-8163350-LocaleProviderAdapter Preference list retrieved is wrong, when -Djava.locale.providers=COMPAT

Hi, Please review fix for JDK-8163350. Bug: https://bugs.openjdk.java.net/browse/JDK-8163350 Webrev: http://cr.openjdk.java.net/~rgoel/jdk-8163350/webrev.02/ Fix: If user specifies either CLDR or COMPAT via System Property, FALLBACK should not be implicitly included. It is meant to be inclu

Re: Review Request : JDK-8066652 : Default TimeZone is GMT not local if user.timezone is invalid on Mac OS

> Also, please note that I'm no reviewer. > > Best regards, > Christoph > >> -Original Message- >> From: i18n-dev [mailto:i18n-dev-boun...@openjdk.java.net] On Behalf Of >> Rachna Goel >> Sent: Freitag, 29. Juli 2016 08:17 >> To: i18n-dev

Review Request : JDK-8066652 : Default TimeZone is GMT not local if user.timezone is invalid on Mac OS

Hi, Please review the fix for JDK-8066652. Bug : https://bugs.openjdk.java.net/browse/JDK-8066652 Webrev: http://cr.openjdk.java.net/~rgoel/JDK-8066652/webrev.01/ Fix : 1. Used thread safe function localtime_r() to retrieve system timezone. 2. timezone retrieved should be "GMT" if s

Re: Review Request-JDK-8154797:Localization data for "GMT"

Bug8154797.java? You can also use Locale.FRANCE and Locale.UK constants in the test case. Otherwise it looks good. Naoto On 7/13/16 2:01 AM, Rachna Goel wrote: Hi, Please review fix for JDK-8154797. Bug: https://bugs.openjdk.java.net/browse/JDK-8154797 webrev: http://cr.openjdk.java.net/~rgoel

Review Request-JDK-8154797:Localization data for "GMT"

Hi, Please review fix for JDK-8154797. Bug: https://bugs.openjdk.java.net/browse/JDK-8154797 webrev: http://cr.openjdk.java.net/~rgoel/JDK-8154797/webrev.04/ fix summary: Added support for GMT Localization resources (GmtFormat and hourFormat). For more info: http://unicode.org/repos/cldr/tru

Re: Review request : JDK-8158504 - test/sun/util/locale/provider/Bug8038436.java fails

:09 AM, Rachna Goel wrote: Hi, Please review fix for JDK-8158504. Bug : https://bugs.openjdk.java.net/browse/JDK-8158504 Webrev : http://cr.openjdk.java.net/~nishjain/rgoel/8158504/webrev.03/ Fix : Removed java.ext.dirs System property as it is no longer supported in JDK9 and used "-limitmod

Review request : JDK-8158504 - test/sun/util/locale/provider/Bug8038436.java fails

Hi, Please review fix for JDK-8158504. Bug : https://bugs.openjdk.java.net/browse/JDK-8158504 Webrev : http://cr.openjdk.java.net/~nishjain/rgoel/8158504/webrev.03/ Fix : Removed java.ext.dirs System property as it is no longer supported in JDK9 and used "-limitmods java.base" to load only j

Review Request for JDK-8145136:Upgrade CLDR locale data

Hi all, Please review fix for JDK-8145136. Bug: https://bugs.openjdk.java.net/browse/JDK-8145136 webrev: http://cr.openjdk.java.net/~nishjain/rachna/CLDR29/8145136/webrev.00/ Fix: Currently JDK supports CLDR V27 which is upgraded to latest version 29. For more info: http://cldr.unicode.org

Review Request for JDK-8149735-java/util/Currency/PropertiesTest.sh fails with java.io.FileNotFoundException

Hello all, Please review fix for JDK-8149735. Please find links to Bug and proposed fix below. https://bugs.openjdk.java.net/browse/JDK-8149735 http://cr.openjdk.java.net/~rgoel/8149735/webrev/ fix: updated permissions of "WRITABLEJDK

Review Request for JDK-8150432: java/util/Locale/LocaleProviders.sh failed on Win10.

Hi all, Please review a small fix for JDK-8150432. Bug and proposed fix are located at below links respectively. https://bugs.openjdk.java.net/browse/JDK-8150432 http://cr.openjdk.java.net/~rgoel/8150432/webrev/ fix: updated new kernel

Review Request for JDK-8145136 : Upgrade CLDR Locale Data

Hello all, Please review the fix for JDK-8145136. Bug : https://bugs.openjdk.java.net/browse/JDK-8145136 Webrev: http://cr.openjdk.java.net/~rgoel/cldr28/webrev.00/ Fix: Upgraded CLDR data from Version 27 to 28. More information at : http://cldr.unicode.org/ -- Thanks, Rachna

Review Request:JDK-8025547-Locale.toString() documentation error.

Hi all, Kindly review small documentation fix in Locale.toString() method. Bug : https://bugs.openjdk.java.net/browse/JDK-8025547 webrev: http://cr.openjdk.java.net/~rgoel/8025547/webrev.02/ Fix: updated documentation of Locale.tostrin

Review Request: JDK-8130246: PropertiesTest.sh fails..

Hi all, Please review the following fix in PropertiesTest.sh (JTREG test case for Currency). Bug : https://bugs.openjdk.java.net/browse/JDK-8130246 webrev : http://cr.openjdk.java.net/~rgoel/8130246/webrev.01/ Fix : Test case was update

Review request :JDK-7011840:TEST_BUG java/util/Locale/LocaleEnhanceTest.java

Hi all, Please review a simple fix to JDK-7011840. Extra information is outputted to report if Serialized test case data is not found. issue: https://bugs.openjdk.java.net/browse/JDK-7011840 webrev: http://cr.openjdk.java.net/~rgoel/7011840

Review Request:JDK-8061287-Update i18n tests to remove references of jre dir

Hi all, Please review a small change in PropertiesTest.sh. Please find attached diff generated from "hg diff". Thanks, Rachna diff -r b3d0002fde2a test/java/util/Currency/PropertiesTest.sh --- a/test/java/util/Currency/PropertiesTest.sh Thu Oct 08 22:31:42 2015 +0530 +++ b/test/java/util/Curren

Review Request:JDK-8075315:Change in API doc

Hi All, Please review the following fix in API doc for jdk9. Reference to Bug: https://bugs.openjdk.java.net/browse/JDK-8075315 Webrev: http://cr.openjdk.java.net/~naoto/rachna/8075315/webrev.00/ Description: The API doc of Currency.getInstance(Locale) specifies NullPointerException to be t