On Tue, 31 May 2022 17:46:18 GMT, Naoto Sato wrote:
> Refactoring some old code in locale providers. The test case data have also
> been modified due to:
> - There's a bug in `LocaleProviderAdapter.toLocaleArray()` where it did not
> handle the case for `no-NO-NY`.
> - `Locale.toLanguageTag()`
On Wed, 18 May 2022 14:46:42 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> It's the last issue in the series, and it still touches different areas of
> the code.
Marked as reviewed by iris (Reviewer).
--
On Wed, 18 May 2022 13:27:24 GMT, Alexey Ivanov wrote:
> Replaces usages of articles that follow each other in all combinations:
> a/the, an?/an?, the/the…
>
> Also, I fixed a couple of spelling mistakes.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/j
On Thu, 5 May 2022 16:13:59 GMT, Naoto Sato wrote:
> Trivial fix to 3rd party copyright notices.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8558
On Fri, 15 Apr 2022 19:34:33 GMT, Pavel Rappo wrote:
> People rarely include JDK elements with package access in a javadoc run. That
> is why bugs in those elements' doc comments tend to remain unnoticed.
>
> There are many more bugs in the doc comments of the JDK elements with the
> package a
On Thu, 14 Apr 2022 22:27:20 GMT, Naoto Sato wrote:
>> Added the test case, and eliminated the immediate hashmap value, replaced
>> with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last
On Thu, 14 Apr 2022 20:52:44 GMT, Naoto Sato wrote:
> Added the test case, and eliminated the immediate hashmap value, replaced
> with the ordinal number of `Character.UnicodeScript.UNKNOWN`.
Nice catch in the review for 8186958.
-
Marked as reviewed by iris (Reviewer).
PR: https
On Thu, 14 Apr 2022 19:07:09 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `src/java.base` directory, and accepted those
> changes where it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> The majority of fixes are in c
On Fri, 8 Apr 2022 20:17:52 GMT, Naoto Sato wrote:
>> This is to upgrade the CLDR data from version 39 to version 41 which was
>> released yesterday. The vast majority of the changes are basically replacing
>> the CLDR data, along with tools/testcase alignments. Here is the link to
>> CLDR v41
On Thu, 7 Apr 2022 21:20:20 GMT, Naoto Sato wrote:
> This is to upgrade the CLDR data from version 39 to version 41 which was
> released yesterday. The vast majority of the changes are basically replacing
> the CLDR data, along with tools/testcase alignments. Here is the link to CLDR
> v41's r
On Wed, 6 Apr 2022 17:45:13 GMT, Naoto Sato wrote:
> This is a follow-on task after deprecating the Locale constructors
> (https://bugs.openjdk.java.net/browse/JDK-8282819). Most of the changes are
> simple replacements to Locale constructors with `Locale.of()` or Locale
> constants, such as `
On Wed, 30 Mar 2022 16:46:40 GMT, Naoto Sato wrote:
> Fixes test failures caused by depending on the default locale. Specifying
> explicit `Locale.US` will do.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/8045
On Tue, 22 Mar 2022 22:02:22 GMT, Naoto Sato wrote:
>> Fixing the out-of-date number of entries in
>> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
>> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
>> correctly has the `map.size()` value.
>
>
On Tue, 22 Mar 2022 18:44:09 GMT, Naoto Sato wrote:
> Fixing the out-of-date number of entries in
> `Character.UnicodeBlock.NUM_ENTITIES` field. The regression test has been
> renamed and now repurposed just to examine whether the `NUM_ENTITIES`
> correctly has the `map.size()` value.
Marked
On Thu, 17 Mar 2022 18:10:17 GMT, Naoto Sato wrote:
> This is to incorporate the ISO 4217 amendment 171 for Sierra Leonean LEONE
> redenomination (removing 3 zeros). Its effective date is 4/1, but I went
> ahead as JDK19 won't be released by 4/1.
Marked as reviewed by iris (Reviewer).
---
On Fri, 28 Jan 2022 14:39:31 GMT, Matteo Baccan wrote:
> Hi
>
> I have reviewed the code for removing double semicolons at the end of lines
>
> all the best
> matteo
Nice tidy of the code.
Is there anything that can be done to prevent re-introduction of this trivial
problem? Perhaps a new S
On Mon, 21 Feb 2022 12:42:37 GMT, Jaikiran Pai wrote:
> Can I please get a review of this trivial change to the javadoc of
> `DateTimeFormatter.getDecimalStyle()` method which fixes the typo noted in
> https://bugs.openjdk.java.net/browse/JDK-8282190?
Marked as reviewed by iris (Reviewer).
--
On Sat, 22 Jan 2022 21:09:03 GMT, Joe Darcy wrote:
> Use presumed syntax that will be introduced by JDK-8280488.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/7189
On Mon, 17 Jan 2022 21:02:35 GMT, Andrey Turbanov wrote:
> Parameter `ChronoField field` is checked by `if (field instanceof
> ChronoField)`. Such check is confusing, because only one case, when this
> could be `false` is when `field == null`.
> But if condition is not satisfied we will get imm
On Wed, 5 Jan 2022 22:42:38 GMT, Naoto Sato wrote:
> Please review the changes for upgrading the Unicode support in the JDK, from
> version 13 to version 14. Corresponding CSR has also been drafted.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull
On Wed, 10 Nov 2021 19:05:17 GMT, Naoto Sato wrote:
>> This fix is to require to include `Locale.ROOT` in the returned arrays/set
>> from `getAvailableLocales()` methods in various locale-sensitive classes.
>> The implementation has been including `Locale.ROOT` since its inception, it
>> is si
On Tue, 2 Nov 2021 16:30:56 GMT, Pavel Rappo wrote:
> This PR follows up one of the recent PRs, where I used a non-canonical
> modifier order. Since the problem was noticed [^1], why not to address it at
> mass?
>
> As far as I remember, the first mass-canonicalization of modifiers took place
On Mon, 1 Nov 2021 15:59:22 GMT, Ludvig Janiuk wrote:
> Adds table headers to all tables in Formatter api docs. I inferred the header
> "Unicode" for the columns that contained unicode
> codepoints.
>
> Formatter api docs:
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/uti
On Mon, 1 Nov 2021 16:51:36 GMT, Pavel Rappo wrote:
>> Please review this PR. A comprehensive test job has been scheduled; I'll
>> notify this thread once that job has completed.
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Thu, 28 Oct 2021 01:02:27 GMT, Yoshiki Sato wrote:
> Please review the integration of tzdata2021e (including tzdata2021d) to the
> JDK.
> The fix has passed all relevant JTREG regression tests and JCK tests.
>
> 8275754: (tz) Update Timezone Data to 2021d
> 8275849: TestZoneInfo310.java fai
On Mon, 25 Oct 2021 16:08:29 GMT, Naoto Sato wrote:
> Trivial clean-up.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6110
On Tue, 12 Oct 2021 21:10:12 GMT, Andrey Turbanov wrote:
> Remove 3 unused HashMap's.
> Reported here
> https://mail.openjdk.java.net/pipermail/core-libs-dev/2021-September/081866.html
> I did the similar PR to treetenbp and it was merged
> https://github.com/ThreeTen/threetenbp/pull/155
Marke
On Thu, 7 Oct 2021 21:30:22 GMT, Naoto Sato wrote:
> While working on tzdata2021c update, I noticed there is a dead code in
> `sun.util.calendar.ZoneInfoFile`, which was used to tweak the rules for
> `endOfDay` for certain cases. These are no longer needed as JDK's code is
> already capable of
On Wed, 6 Oct 2021 01:24:49 GMT, Naoto Sato wrote:
> This PR is to upgrade the time zone data in the JDK to IANA's tzdata2021c
> level. Note that the tz data is "as is", as released by IANA. No `merged
> links` are retracted.
> The PR also fixes two issues along with the 2021c upgrade.
Marked
On Fri, 1 Oct 2021 18:57:28 GMT, Naoto Sato wrote:
> This is to incorporate the ISO 4217 amendment #170, which has been released
> today, effective immediately.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5790
On Mon, 27 Sep 2021 22:48:24 GMT, Joe Darcy wrote:
>> Follow-up changes to JDK-8231334. , augmentations to javac's Xlint:serial
>> checking are out for review (#5709) and various client libraries would need
>> some changes to pass under the expanded checks.
>>
>> The changes are to suppress wa
On Tue, 21 Sep 2021 22:18:07 GMT, Naoto Sato wrote:
>> Fixing an AIOOBE on normalizing the month value.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removed the unnecessary space
Marked as reviewed by iris (Reviewer).
--
On Tue, 21 Sep 2021 21:45:40 GMT, Naoto Sato wrote:
> Simple doc fix.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5620
On Tue, 21 Sep 2021 12:47:00 GMT, Naoto Sato wrote:
> Fixing an AIOOBE on normalizing the month value.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5611
On Mon, 13 Sep 2021 11:22:27 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Use "ensure" instead of "insure"
Marked as reviewed by iris (Rev
On Fri, 10 Sep 2021 23:20:11 GMT, Pavel Rappo wrote:
>> 8273616: Fix trivial doc typos in the java.base module
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Revert two fixes
Marked as reviewed by iris (Reviewer).
---
On Fri, 10 Sep 2021 12:21:41 GMT, Naoto Sato wrote:
>> Simple spec clarification. A CSR has also been drafted
>> (https://bugs.openjdk.java.net/browse/JDK-8273296).
>
> Naoto Sato has updated the pull request with a new target base due to a merge
> or a rebase. The incremental webrev excludes t
On Wed, 8 Sep 2021 00:37:41 GMT, Naoto Sato wrote:
>> Simple spec clarification. A CSR has also been drafted
>> (https://bugs.openjdk.java.net/browse/JDK-8273296).
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refined word
On Thu, 2 Sep 2021 19:26:12 GMT, Naoto Sato wrote:
> Simple spec clarification. A CSR has also been drafted
> (https://bugs.openjdk.java.net/browse/JDK-8273296).
Associated CSR also "Reviewed".
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/535
On Mon, 23 Aug 2021 16:42:03 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. When instant seconds and zone
> co-exist in parsed data, instant seconds was not resolved correctly from them.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.ne
On Wed, 18 Aug 2021 20:59:20 GMT, Andrey Turbanov
wrote:
> remove redundant if
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/5171
On Fri, 6 Aug 2021 16:39:34 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. The root cause of this problem is
> that the currency for the country code `XK` is undefined because the country
> code is user-defined in the ISO 3166 standard. However, it is commonly used
> to r
On Wed, 30 Jun 2021 21:38:43 GMT, Naoto Sato wrote:
> A trivial typo fix.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk17/pull/187
On Mon, 28 Jun 2021 20:33:29 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Missed one.
Marke
On Mon, 28 Jun 2021 18:37:34 GMT, Naoto Sato wrote:
>> Please review this small doc change to the system property. Accompanying CSR
>> has also been created.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Refined wording.
On Thu, 24 Jun 2021 12:01:04 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind rega
On Tue, 22 Jun 2021 17:50:05 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind rega
On Tue, 22 Jun 2021 09:58:55 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.time`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request with a new
On Tue, 22 Jun 2021 16:07:12 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review the second half of my update for the `java.time`
>> package to make use of switch expressions?
>>
>> This PR was split into two parts due to the large number of files affected.
>>
>> Kind rega
On Wed, 9 Jun 2021 10:25:35 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request incrementall
On Thu, 3 Jun 2021 11:01:02 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.lang`
>> packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated the pull request incrementall
On Mon, 31 May 2021 14:10:50 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.io`,
>> `java.math`, and `java.text` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated
On Wed, 26 May 2021 02:22:42 GMT, Tagir F. Valeev wrote:
>> Inspired by PR#4088. Most of the changes are done automatically using
>> IntelliJ IDEA refactoring. Some manual adjustments are also performed,
>> including indentations, moving comments, extracting common cast out of
>> switch expres
On Tue, 25 May 2021 21:43:36 GMT, Patrick Concannon
wrote:
>> Hi,
>>
>> Could someone please review my code for updating the code in the `java.io`,
>> `java.math`, and `java.text` packages to make use of the switch expressions?
>>
>> Kind regards,
>> Patrick
>
> Patrick Concannon has updated
On Wed, 28 Apr 2021 16:57:25 GMT, Ian Graves wrote:
>> 8266155: Convert java.base to use Stream.toList()
>
> Ian Graves has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Removing redundant imports
Marked as reviewed by iris (Reviewer).
On Wed, 28 Apr 2021 15:44:47 GMT, Claes Redestad wrote:
> I'm not exactly sure what I intended to say in this partial comment. Removing
> it.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3766
On Tue, 27 Apr 2021 21:34:02 GMT, Ian Graves wrote:
> 8266155: Convert java.base to use Stream.toList()
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3734
On Thu, 1 Apr 2021 03:24:04 GMT, Naoto Sato wrote:
> Please review the fix to the subject issue. Thanks to the contribution by
> Chris Johnson.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3300
On Thu, 25 Mar 2021 22:58:53 GMT, Andy Herrick wrote:
>> implementation of
>> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
>
> Andy Herrick has updated the pull request with a new target base due to a
> merge or a rebase. The incremental webrev excludes the unrelated changes
> bro
On Fri, 19 Mar 2021 18:23:00 GMT, Alex Blewitt
wrote:
> Additional changes found in `java.base` of `final private` -> `private
> final`. Filed with existing bug because it's the same module; can change to a
> different bug number if required.
Marked as reviewed by iris (Reviewer).
--
On Fri, 19 Mar 2021 17:57:31 GMT, Naoto Sato wrote:
> Fixed several broken links to Unicode.org.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3093
On Sat, 13 Mar 2021 20:26:42 GMT, Igor Ignatyev wrote:
> Hi all,
>
> could you please review this trivial cleanup?
> from JBS:
>
>> jtreg `@modules X` directive does two things:
>> - exclude a test from execution if JDK under test doesn't have module X
>> - if JDK under test has module X, m
On Wed, 10 Mar 2021 18:33:37 GMT, Andy Herrick wrote:
> implementation of
> JDK-8256145: JEP 398: Deprecate the Applet API for Removal
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2920
On Mon, 8 Mar 2021 18:48:30 GMT, Patrick Concannon
wrote:
> Hi,
>
> Could someone please review my code for updating the code in the `java.io`,
> `java.math`, and `java.text` packages to make use of the `instanceof` pattern
> variable?
>
> Kind regards,
> Patrick
Marked as reviewed by iris
On Fri, 5 Mar 2021 14:24:34 GMT, Claes Redestad wrote:
> This patch removes the CharacterData.isOtherUppercase and isOtherLowercase
> methods. It also exploits the fact that isOtherUppercase is always false for
> all codepoints in the CharacterDataLatin1 range for a small speed-up.
>
> I have
On Wed, 17 Feb 2021 20:21:57 GMT, Naoto Sato wrote:
>> Please review this simple doc fix. A CSR will be filed accordingly.
>
> Naoto Sato has updated the pull request incrementally with one additional
> commit since the last revision:
>
> Made the additional text an @apiNote
Marked as review
On Mon, 11 Jan 2021 16:54:53 GMT, Naoto Sato wrote:
> Please review this simple doc fix.
Marked as reviewed by iris (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/2028
On Mon, 9 Nov 2020 13:56:33 GMT, Andy Herrick wrote:
> JDK-8189198: Add "forRemoval = true" to Applet APIs
Since all APIs in the java.applet package are deprecated "forRemoval = true",
consider adding a brief deprecation note to java/applet/package-info.java too.
As an example, when all of the
On Thu, 22 Oct 2020 17:16:23 GMT, Jonathan Gibbons wrote:
> The change is (just) to remove legacy usages of a JDK-private custom tag.
Nice clean-up.
-
Marked as reviewed by iris (Reviewer).
PR: https://git.openjdk.java.net/jdk/pull/814
Hi, Yuka.
Looks great!
iris
-Original Message-
From: Yuka Kamiya
Sent: Wednesday, March 26, 2014 11:43 PM
To: Iris Clark; i18n-dev
Subject: Re: Request for a JEP for JDK9 (Unicode support)
Hi Iris,
Thank you for your comment on my JEP.
I've revised the draft to reflect it. And
Hi, Yuka.
Looks good as the expected follow-on to the equivalent work in JDK 8 (JEP 133:
Unicode 6.2 [1]).
My only minor recommendation is that you consider adding a link to unicode.org
[2] in the Summary. As an example see lines 27-28 here [3]. (See [4] for
additional MarkDown syntax.)
Tha
Hi, Naoto.
Fantastic! Sorry I didn’t catch that 'build-dev' was in the set of reviewers.
Thanks for being on top of this.
iris
-Original Message-
From: Naoto Sato
Sent: Friday, July 13, 2012 11:59 AM
To: Iris Clark
Cc: Alan Bateman; Java Core Libs; i18n-dev
Subject: Re:
Hi, Naoto.
Wow. Tons of fantastic work!
Looks like many files contain fairly trivial changes related to resources being
moved to another package, but there are many others which require more careful
review.
Scanning the list of files in the webrev, one comment pops to mind. You've
made ch
73 matches
Mail list logo
