On Thu, 14 Apr 2022 16:05:48 GMT, Magnus Ihse Bursie wrote:
> I ran `codespell` on the `make` directory, and accepted those changes where
> it indeed discovered real typos.
>
> (Due to false positives this can unfortunately not be run automatically)
>
> Most of the fixes are in comments. A fe
On Mon, 21 Mar 2022 16:29:25 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Thu, 17 Mar 2022 00:12:38 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On Sat, 5 Mar 2022 06:49:16 GMT, Julian Waters wrote:
> Should I change the JBS issue title to match the PR title, or is it preferred
> for the PR title to change?
They need to match. You can either do it manually, or change the title to just
the bug number and the bot will change it for you.
On Fri, 3 Dec 2021 01:18:20 GMT, Joe Darcy wrote:
> In JDK 18, JDK-8189591 added the ability to suppress doclint warnings.
> Therefore, it is now possible to enable the full doclint checks for the
> java.desktop module if the instances of warnings are suppressed. This patch
> does this; it wou
On Thu, 28 Oct 2021 01:02:27 GMT, Yoshiki Sato wrote:
> Please review the integration of tzdata2021e (including tzdata2021d) to the
> JDK.
> The fix has passed all relevant JTREG regression tests and JCK tests.
>
> 8275754: (tz) Update Timezone Data to 2021d
> 8275849: TestZoneInfo310.java fai
On Mon, 27 Sep 2021 01:00:18 GMT, Joe Darcy wrote:
> This is an initial PR for expanded lint warnings done under two bugs:
>
> 8202056: Expand serial warning to check for bad overloads of serial-related
> methods and ineffectual fields
> 8160675: Issue lint warning for non-serializable non-tran
On Mon, 17 May 2021 18:23:41 GMT, Weijun Wang wrote:
> Please review this implementation of [JEP
> 411](https://openjdk.java.net/jeps/411).
>
> The code change is divided into 3 commits. Please review them one by one.
>
> 1.
> https://github.com/openjdk/jdk/commit/576161d15423f58281e384174d28
On Mon, 17 May 2021 16:55:35 GMT, Naoto Sato wrote:
> Please review the changes to the subject issue. java.util.Locale class has a
> long-standing issue for those obsolete ISO 639 languages where its
> normalization ends up in the obsolete codes. This change intends to flip the
> normalization
On Wed, 28 Apr 2021 15:44:47 GMT, Claes Redestad wrote:
> I'm not exactly sure what I intended to say in this partial comment. Removing
> it.
Marked as reviewed by erikj (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/3766
On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote:
> Please review the changes to support CLDR version 39. The vast majority of
> the changes are purely data changes from Unicode. The only change affected in
> logic was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with
> CLDR'
On Tue, 16 Mar 2021 12:51:02 GMT, Claes Redestad wrote:
> This patch changes the otherLowercase / otherUppercase bits to be set if
> either the codepoint is of type LOWERCASE_LETTER and UPPERCASE_LETTER, or the
> Unicode Other_Lowercase / Other_Uppercase property is set. This simplifies
> the
On Tue, 26 Jan 2021 10:35:03 GMT, Magnus Ihse Bursie wrote:
> For java.base gensrc we do the following:
>
> # Copy two Java files that need no preprocessing.
> $(SUPPORT_OUTPUTDIR)/gensrc/java.base/java/lang/%.java:
> $(CHARACTERDATA_TEMPLATES)/%.java.template
> $(call LogInfo, Generating $(@F)
On Mon, 4 Jan 2021 18:11:05 GMT, Kiran Sidhartha Ravikumar
wrote:
> Hi Guys,
>
> Please review the integration of tzdata2020e to JDK.
>
> Details regarding the change can be viewed at -
> https://mm.icann.org/pipermail/tz-announce/2020-December/63.html
> Bug: https://bugs.openjdk.java.net
On Tue, 15 Dec 2020 22:56:15 GMT, Magnus Ihse Bursie wrote:
>> A lot (but not all) of the data in make/data is tied to a specific module.
>> For instance, the publicsuffixlist is used by java.base, and fontconfig by
>> java.desktop. (A few directories, like mainmanifest, is *actually* used by
On 2020-12-08 00:30, Magnus Ihse Bursie wrote:
On Tue, 8 Dec 2020 02:40:43 GMT, Mandy Chung wrote:
I have reviewed all lines in the patch file with or near instances of
`jdk.compiler`
Hi Magnus,
I see the motivation of moving these build files for better identification of
ownership. Pl
On Fri, 4 Dec 2020 14:03:08 GMT, Erik Joelsson wrote:
>>> And I can certainly move jdwp.spec to java.base instead.
>>
>> If jdwp.spec has to move to the src tree then src/java.se is probably the
>> most suitable home because Java SE specifies JDWP as an optional i
On Fri, 4 Dec 2020 12:30:02 GMT, Alan Bateman wrote:
>> And I can certainly move jdwp.spec to java.base instead. That's the reason I
>> need input on this: All I know is that is definitely not the responsibility
>> of the Build Group to maintain that document, and I made my best guess at
>> wh
On Tue, 17 Nov 2020 23:19:23 GMT, Naoto Sato wrote:
> Hi,
>
> Please review the changes for upgrading the CLDR data to version 38. The vast
> majority of the changes are simply the changes in CLDR upstream, and others
> are mainly test changes due to the locale data change.
Looks fine from a
On Mon, 19 Oct 2020 18:44:28 GMT, Kiran Sidhartha Ravikumar
wrote:
> Hi Guys,
>
> Please review the integration of tzdata2020c to JDK.
>
> Details regarding the change can be viewed at -
> https://mm.icann.org/pipermail/tz-announce/2020-October/60.html
> Bug: https://bugs.openjdk.java.net
On Mon, 12 Oct 2020 09:32:38 GMT, Kiran Sidhartha Ravikumar
wrote:
> Hi Guys,
>
> Please review the patch for tzdata2020b integration into JDK.
>
> Release details can be found here:
>
> https://mm.icann.org/pipermail/tz-announce/2020-October/59.html
>
> Bug: https://bugs.openjdk.java.ne
On Mon, 21 Sep 2020 18:17:55 GMT, Yumin Qi wrote:
>> With more CDS related code added to VM, it is time to move CDS code to a
>> separate class. CDS is the new class which is
>> specific to CDS.
>> Tests: tier1-4
>
> Yumin Qi has updated the pull request incrementally with one additional
> comm
Build changes look good.
/Erik
On 2019-05-22 18:36, naoto.s...@oracle.com wrote:
Hi Erik,
Thank you for your comments. Updated the webrev accordingly:
https://cr.openjdk.java.net/~naoto/8221431/webrev.04/
Naoto
On 5/22/19 4:13 PM, Erik Joelsson wrote:
Hello Naoto,
In GensrcEmojiData.gmk
Hello Naoto,
In GensrcEmojiData.gmk: The MakeDir doesn't look correct with the double
$$. I would recommend calling the newer MakeTargetDir macro instead. It
doesn't take an argument.
Otherwise build changes look good.
/Erik
On 2019-05-22 15:56, naoto.s...@oracle.com wrote:
Adding build-dev
Looks good to me.
I guess it's hard to prove that the output is now stable, but time will
tell.
/Erik
On 2018-09-18 10:41, Naoto Sato wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8209880
The proposed changeset is located at:
http:/
s that's a separate
issue. Since it's obvious, I included the fix with this changeset (it
was actually described as a comment in the jira issue).
Naoto
On 9/12/18 9:08 AM, Erik Joelsson wrote:
On 2018-09-12 03:19, Magnus Ihse Bursie wrote:
On 2018-09-10 23:34, Naoto Sato wrote:
Hello,
P
On 2018-09-12 03:19, Magnus Ihse Bursie wrote:
On 2018-09-10 23:34, Naoto Sato wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8209167
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8209167/webrev.01/
Some comm
Looks good.
/Erik
On 2018-09-10 14:34, Naoto Sato wrote:
Hello,
Please review the fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8209167
The proposed changeset is located at:
http://cr.openjdk.java.net/~naoto/8209167/webrev.01/
This fix is to remove the hand crafted
Build changes look good.
/Erik
On 2018-04-12 17:34, Naoto Sato wrote:
Hi,
Please review the fix to the subject issue. While fixing 8189784 [1],
I noticed that not only CLDR zones but also tzdb link entries are also
hard coded. So I further modified j.t.f.ZoneName to generate tzdb
entries a
This looks very good. Thanks!
(reviewed build part)
/Erik
On 2018-04-09 18:00, naoto.s...@oracle.com wrote:
Thanks, Erik. Modified GensrcCLDR.gmk as suggested:
http://cr.openjdk.java.net/~naoto/8189784/webrev.03/
Naoto
On 4/9/18 4:15 PM, Erik Joelsson wrote:
Hello Naoto,
Looks good
Hello Naoto,
Looks good, just a style issue.
When breaking a recipe line, please add 4 additional spaces (after the
tab) for continuation indent [1]. In this case I would also advocate
breaking the line sooner to make side by side comparisons easier in the
future.
/Erik
[1] http://openjdk.
Build change looks good.
/Erik
On 2016-10-20 10:33, Masayoshi Okutsu wrote:
Hi,
Please review the changes for JDK-8165804 which is a follow-up of
JDK-8076757. Some notes on the changes.
- Removed INCLUDES := $(TEXT_PKG_LD) from
make/gendata/GendataBreakIterator.gmk in order to avoid compi
Hello Naoto,
Build changes look good to me.
/Erik
On 2015-06-08 22:58, Naoto Sato wrote:
Hello,
Please review the proposed changes for 8008577[1], the implementation
of the JEP-252[2]. The proposed changes are located at:
http://cr.openjdk.java.net/~naoto/8008577/webrev.00/
Here are the v
Looks good to me.
/Erik
On 2015-05-19 00:45, Mandy Chung wrote:
This patch removes native2ascii command-line tool from JDK 9 as
proposed in March [1].
Webrev at:
http://cr.openjdk.java.net/~mchung/jdk9/webrevs/8074431/webrev.00/
Jon - A langtools test is updated to use a new Native2Ascii.jav
Note that the JDK build itself uses native2ascii for the man pages. I
have no idea why or if this is actually necessary. Here is the code:
define install-ja-manpage
$(MKDIR) -p $(@D)
$(CAT) $< \
| $(NATIVE2ASCII) -encoding eucJP \
| $(SED) 's/@@VERSION@@
On 2014-10-31 14:21, Magnus Ihse Bursie wrote:
1) I do not like how gensrc/Gensrc-jdk.localedata.cldr.gmk is included
in CreateJars.gmk -- it should not be there. The reason is to get the
CLDRVERSION which is defined in that file. I'd like to address that,
either by extracting the CLDRVERSIO
Hello Naoto,
Just one thing, in Gensrc-java.base.gmk, shouldn't we still just run the
targets in GENSRC_JAVA_BASE and let Gensrc-jdk.localedata.classic.gmk
deal with GENSRC_JDK_LOCALEDATA_CLASSIC?
/Erik
On 2014-10-23 22:05, Naoto Sato wrote:
I revised the fix according to the suggestions I g
where English locale data is
included. So it cannot be inlined into Gensrc-jdk.localedata.gmk.
Naoto
On 10/20/14, 12:54 AM, Erik Joelsson wrote:
Hello Naoto,
With this split, I would rather see GensrcCLDR.gmk be renamed
Gensrc-jdk.localedata.cldr.gmk and have the "all" targets etc a
Hello Naoto,
With this split, I would rather see GensrcCLDR.gmk be renamed
Gensrc-jdk.localedata.cldr.gmk and have the "all" targets etc added to
it. Then Gensrc-jdk.localedata.gmk should no longer include it. Ideally
GensrcLocaleData.gmk would be inlined into Gensrc-jdk.localedata.gmk.
Note
On 2014-09-16 23:03, Naoto Sato wrote:
I revised the fix based on suggestions from Erik/Magnus. I just ended
up creating Gensrc-jdk.localedata.gmk, instead of renaming
GensrcCLDR.gmk because GensrcLocaleData.gmk (formerly
GensrcLocaleDataMetaInfo.gmk) is also needed to build jdk.localedata:
Hello Naoto,
From what I can see, this means that GensrcCLDR.gmk now only generates
source for the jdk.localedata module. This means that
Gensrc-java.base.gmk should no longer include GensrcCLDR.gmk and
GensrcCLDR.gmk should be renamed to Gensrc-jdk.localedata.gmk.
/Erik
On 2014-09-16 01:30
The reintroduction of the dynamic list looks ok from a build point of view.
/Erik
On 2014-08-29 23:07, Naoto Sato wrote:
I incorporated the suggestions from Mandy and Alan. Also one change
since the last webrev was to revert the hard-coding of the supported
locales list back to the one which d
My understanding is that these changes are needed. From a build
perspective, while making complicated make logic even more complicated,
it's really not that bad imho. So OK from me.
/Erik
On 2014-02-17 17:39, Naoto Sato wrote:
Any other comments? If there is no strong opinion against pushing t
Hello Naoto,
Looks fine from a build perspective.
The logic of that makefile is quite hairy to begin with.
/Erik
On 2014-02-05 03:54, Naoto Sato wrote:
Hello,
Please review this fix:
http://cr.openjdk.java.net/~naoto/8027289/webrev.00/
https://bugs.openjdk.java.net/browse/JDK-8027289
The f
I think the build changes look OK.
/Erik
On 2013-09-06 21:01, Naoto Sato wrote:
Hello,
Please review the fix for the following bug. At the moment, it's not
yet reflected in the bug database, but the symptom is that
sun.util.resources.en package is split between rt.jar and
localedata.jar, wh
(resending to all recepients)
I don't see any changes to the build except for java classes in the
cldrconverter build tool. This shouldn't affect the new build, so it's
ok with the build group.
/Erik
On 2012-12-06 06:06, Masayoshi Okutsu wrote:
Resending in order to include build-...@openjdk
Looks good to me. I'm ok with this.
/Erik
On 2012-08-20 19:14, Naoto Sato wrote:
I have updated the changeset by removing the copyright headers from
all of the CLDR files, and added a LICENSE file at the top of CLDR
source directory (src/share/classes/sun/util/cldr/resources/21_0_1).
No other
/~naoto/6336885/webrev.01/
This includes:
- a couple of fixes to the CLDR Converter
- Added fallback for any bad SPI implementations which return null for
requested instances.
Still asking for review comments.
Naoto
On 8/8/12 2:13 PM, Naoto Sato wrote:
On 8/7/12 2:57 AM, Erik Joelsson wrote:
See
See inline
On 2012-07-13 22:20, Kelly O'Hair wrote:
Something seems strange here:
http://cr.openjdk.java.net/~naoto/6336885/webrev.00/make/java/java/localegen.sh.sdiff.html
It's like someone was avoiding overall quotes, but using them to add spaces
somehow...
I sure would like to get rid o
49 matches
Mail list logo
