On Thu, 28 Oct 2021 01:02:27 GMT, Yoshiki Sato wrote:
> Please review the integration of tzdata2021e (including tzdata2021d) to the
> JDK.
> The fix has passed all relevant JTREG regression tests and JCK tests.
>
> 8275754: (tz) Update Timezone Data to 2021d
> 8275849: TestZoneInfo310.java fai
On Mon, 1 Nov 2021 16:10:26 GMT, Ichiroh Takiguchi
wrote:
>> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13.
>> After JDK18-b13, javac and some other langtool command's usage were garbled
>> on Japanese Windows.
>> These commands use PrintWriter instead of standard out/err with PrintStream.
On Mon, 1 Nov 2021 15:04:16 GMT, Pavel Rappo wrote:
> Please review this PR. A comprehensive test job has been scheduled; I'll
> notify this thread once that job has completed.
This pull request has now been integrated.
Changeset: 2eafa036
Author:Pavel Rappo
URL:
https://git.openjd
On Mon, 1 Nov 2021 16:51:36 GMT, Pavel Rappo wrote:
>> Please review this PR. A comprehensive test job has been scheduled; I'll
>> notify this thread once that job has completed.
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Mon, 1 Nov 2021 22:27:08 GMT, Claes Redestad wrote:
>> src/java.base/share/classes/java/time/format/DateTimeFormatterBuilder.java
>> line 3269:
>>
>>> 3267: return false;
>>> 3268: }
>>> 3269: int val = value.intValue(); // NANO_OF_SECOND must fit in
> Prompted by a request from Volkan Yazıcı I took a look at why the java.time
> formatters are less efficient for some common patterns than custom formatters
> in apache-commons and log4j. This patch reduces the gap, without having
> looked at the third party implementations.
>
> When printing
On Mon, 1 Nov 2021 22:18:52 GMT, Stephen Colebourne
wrote:
>> Prompted by a request from Volkan Yazıcı I took a look at why the java.time
>> formatters are less efficient for some common patterns than custom
>> formatters in apache-commons and log4j. This patch reduces the gap, without
>> hav
On Mon, 1 Nov 2021 13:04:20 GMT, Claes Redestad wrote:
> Prompted by a request from Volkan Yazıcı I took a look at why the java.time
> formatters are less efficient for some common patterns than custom formatters
> in apache-commons and log4j. This patch reduces the gap, without having
> looke
On Mon, 1 Nov 2021 15:59:22 GMT, Ludvig Janiuk wrote:
> Adds table headers to all tables in Formatter api docs. I inferred the header
> "Unicode" for the columns that contained unicode
> codepoints.
>
> Formatter api docs:
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/uti
On Mon, 1 Nov 2021 16:51:36 GMT, Pavel Rappo wrote:
>> Please review this PR. A comprehensive test job has been scheduled; I'll
>> notify this thread once that job has completed.
>
> Pavel Rappo has updated the pull request incrementally with one additional
> commit since the last revision:
>
On Mon, 1 Nov 2021 15:59:22 GMT, Ludvig Janiuk wrote:
> Adds table headers to all tables in Formatter api docs. I inferred the header
> "Unicode" for the columns that contained unicode
> codepoints.
>
> Formatter api docs:
> https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/uti
On Mon, 1 Nov 2021 16:25:26 GMT, Pavel Rappo wrote:
>> src/java.base/share/classes/sun/util/resources/LocaleData.java line 248:
>>
>>> 246: private static final LocaleDataStrategy INSTANCE = new
>>> LocaleDataStrategy();
>>> 247: // TODO: avoid hard-coded Locales
>>> 248:
> Please review this PR. A comprehensive test job has been scheduled; I'll
> notify this thread once that job has completed.
Pavel Rappo has updated the pull request incrementally with one additional
commit since the last revision:
Use the blessed modifiers order
-
Changes:
-
On Mon, 1 Nov 2021 15:23:49 GMT, Claes Redestad wrote:
>> Please review this PR. A comprehensive test job has been scheduled; I'll
>> notify this thread once that job has completed.
>
> src/java.base/share/classes/sun/util/resources/LocaleData.java line 248:
>
>> 246: private static fin
On Mon, 1 Nov 2021 15:52:51 GMT, Daniel Fuchs wrote:
>> Please review this PR. A comprehensive test job has been scheduled; I'll
>> notify this thread once that job has completed.
>
> src/java.base/share/classes/sun/util/resources/LocaleData.java line 336:
>
>> 334: public List getCandi
On Mon, 1 Nov 2021 15:04:16 GMT, Pavel Rappo wrote:
> Please review this PR. A comprehensive test job has been scheduled; I'll
> notify this thread once that job has completed.
Marked as reviewed by naoto (Reviewer).
-
PR: https://git.openjdk.java.net/jdk/pull/6191
> JEP-400 (UTF-8 by Default) was eabled on JDK18-b13.
> After JDK18-b13, javac and some other langtool command's usage were garbled
> on Japanese Windows.
> These commands use PrintWriter instead of standard out/err with PrintStream.
Ichiroh Takiguchi has updated the pull request with a new targe
Adds table headers to all tables in Formatter api docs. I inferred the header
"Unicode" for the columns that contained unicode
codepoints.
Formatter api docs:
https://docs.oracle.com/en/java/javase/17/docs/api/java.base/java/util/Formatter.html
-
Commit messages:
- Fixes JDK-82762
On Mon, 1 Nov 2021 15:04:16 GMT, Pavel Rappo wrote:
> Please review this PR. A comprehensive test job has been scheduled; I'll
> notify this thread once that job has completed.
src/java.base/share/classes/sun/util/resources/LocaleData.java line 336:
> 334: public List getCandidateLocal
On Mon, 1 Nov 2021 13:04:20 GMT, Claes Redestad wrote:
> Prompted by a request from Volkan Yazıcı I took a look at why
> DataTimeFormatters are much less efficient for some common patterns than
> custom formatters in apache-commons and log4j. This patch address some of
> that gap, without havi
Prompted by a request from Volkan Yazıcı I took a look at why
DataTimeFormatters are much less efficient for some common patterns than custom
formatters in apache-commons and log4j. This patch address some of that gap,
without having looked at the third party implementations.
When printing tim
On Mon, 1 Nov 2021 15:04:16 GMT, Pavel Rappo wrote:
> Please review this PR. A comprehensive test job has been scheduled; I'll
> notify this thread once that job has completed.
LGTM, but please use `static final`
src/java.base/share/classes/sun/util/resources/LocaleData.java line 248:
> 246:
Please review this PR. A comprehensive test job has been scheduled; I'll notify
this thread once that job has completed.
-
Commit messages:
- Fix *code* typo
- Be more immutable
- Fix typos
Changes: https://git.openjdk.java.net/jdk/pull/6191/files
Webrev: https://webrevs.openjdk
23 matches
Mail list logo
