On Mon, 1 Nov 2021 15:04:16 GMT, Pavel Rappo <pra...@openjdk.org> wrote:
> Please review this PR. A comprehensive test job has been scheduled; I'll > notify this thread once that job has completed. LGTM, but please use `static final` src/java.base/share/classes/sun/util/resources/LocaleData.java line 248: > 246: private static final LocaleDataStrategy INSTANCE = new > LocaleDataStrategy(); > 247: // TODO: avoid hard-coded Locales > 248: private final static Set<Locale> JAVA_BASE_LOCALES Canonical modifier order is `static final` src/java.base/share/classes/sun/util/resources/LocaleData.java line 327: > 325: = new SupplementaryStrategy(); > 326: // TODO: avoid hard-coded Locales > 327: private final static Set<Locale> JAVA_BASE_LOCALES Canonical modifier order is `static final` ------------- Marked as reviewed by redestad (Reviewer). PR: https://git.openjdk.java.net/jdk/pull/6191
