Re: RFR: 8262108: SimpleDateFormat formatting broken for sq_MK Locale [v4]

2021-04-14 Thread Naoto Sato
On Thu, 15 Apr 2021 01:57:01 GMT, Jaikiran Pai wrote: >> Can I please get a review for this proposed fix for >> https://bugs.openjdk.java.net/browse/JDK-8262108? >> >> As noted in a comment in that issue, the bug relates to the return value of >> `Calendar.getDisplayNames` for the `Calendar.AM

Re: RFR: 8262108: SimpleDateFormat formatting broken for sq_MK Locale [v4]

2021-04-14 Thread Jaikiran Pai
> Can I please get a review for this proposed fix for > https://bugs.openjdk.java.net/browse/JDK-8262108? > > As noted in a comment in that issue, the bug relates to the return value of > `Calendar.getDisplayNames` for the `Calendar.AM_PM` field. The implementation > has started returning inval

Re: RFR: 8262108: SimpleDateFormat formatting broken for sq_MK Locale [v3]

2021-04-14 Thread Jaikiran Pai
On Wed, 14 Apr 2021 18:01:10 GMT, Naoto Sato wrote: >> Jaikiran Pai has updated the pull request incrementally with two additional >> commits since the last revision: >> >> - Update existing NarrowNamesTest to match expectations >> - Naoto's review suggestion > > src/java.base/share/classes/s

Re: RFR: 8258794: Support for CLDR version 39

2021-04-14 Thread Erik Joelsson
On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote: > Please review the changes to support CLDR version 39. The vast majority of > the changes are purely data changes from Unicode. The only change affected in > logic was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with > CLDR'

Re: RFR: 8258794: Support for CLDR version 39

2021-04-14 Thread Naoto Sato
On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote: > Please review the changes to support CLDR version 39. The vast majority of > the changes are purely data changes from Unicode. The only change affected in > logic was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with > CLDR'

Re: RFR: 8258794: Support for CLDR version 39

2021-04-14 Thread Joe Wang
On Wed, 14 Apr 2021 21:13:51 GMT, Naoto Sato wrote: > Please review the changes to support CLDR version 39. The vast majority of > the changes are purely data changes from Unicode. The only change affected in > logic was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with > CLDR'

RFR: 8258794: Support for CLDR version 39

2021-04-14 Thread Naoto Sato
Please review the changes to support CLDR version 39. The vast majority of the changes are purely data changes from Unicode. The only change affected in logic was in `CLDRLocaleProviderAdapter.java`, where it needed to deal with CLDR's Norwegian language code switch (https://unicode-org.atlassi

Re: RFR: 8262108: SimpleDateFormat formatting broken for sq_MK Locale [v3]

2021-04-14 Thread Naoto Sato
On Wed, 14 Apr 2021 17:14:55 GMT, Jaikiran Pai wrote: >> Can I please get a review for this proposed fix for >> https://bugs.openjdk.java.net/browse/JDK-8262108? >> >> As noted in a comment in that issue, the bug relates to the return value of >> `Calendar.getDisplayNames` for the `Calendar.AM

Re: RFR: 8262108: SimpleDateFormat formatting broken for sq_MK Locale [v3]

2021-04-14 Thread Jaikiran Pai
On Wed, 14 Apr 2021 17:14:55 GMT, Jaikiran Pai wrote: >> Can I please get a review for this proposed fix for >> https://bugs.openjdk.java.net/browse/JDK-8262108? >> >> As noted in a comment in that issue, the bug relates to the return value of >> `Calendar.getDisplayNames` for the `Calendar.AM

Re: RFR: 8262108: SimpleDateFormat formatting broken for sq_MK Locale [v3]

2021-04-14 Thread Jaikiran Pai
> Can I please get a review for this proposed fix for > https://bugs.openjdk.java.net/browse/JDK-8262108? > > As noted in a comment in that issue, the bug relates to the return value of > `Calendar.getDisplayNames` for the `Calendar.AM_PM` field. The implementation > has started returning inval

Re: RFR: 8262108: SimpleDateFormat formatting broken for sq_MK Locale [v2]

2021-04-14 Thread Naoto Sato
On Tue, 13 Apr 2021 15:03:28 GMT, Jaikiran Pai wrote: >> Can I please get a review for this proposed fix for >> https://bugs.openjdk.java.net/browse/JDK-8262108? >> >> As noted in a comment in that issue, the bug relates to the return value of >> `Calendar.getDisplayNames` for the `Calendar.AM