Looks OK to me. Thanks for the update.
Naoto
On 4/27/20 11:19 AM, Kiran Ravikumar wrote:
Hi Martin and Andrew,
Thanks for the review and providing a direction towards updating the
translations.
Here is an updated webrev with the changes:
http://cr.openjdk.java.net/~kravikumar/8243541/web
Thanks. This looks good.
How the tzdata updates get done has always been a mystery to me.
If you've written any helper scripts or process docs, checking those
in as well (but which directory?) might be useful.
(I maintain such things at Google, but they are not very useful for
you - too full of G
Hi Martin and Andrew,
Thanks for the review and providing a direction towards updating the
translations.
Here is an updated webrev with the changes:
http://cr.openjdk.java.net/~kravikumar/8243541/webrev/
All associated tests pass. Please let me know if they look alright.
Thanks,
Kiran
+1.
Indeed, the resulting javadoc was fine :-)
Best,
Joe
On 4/27/2020 9:36 AM, naoto.s...@oracle.com wrote:
Hello,
Please review this small doc fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8243664
Here is the diff:
---
--- old/src/java.base/share/classes/java/tex
On 27/04/2020 12:13, Kiran Ravikumar wrote:
> Hello All,
>
>
> Please review the patch for tzdata2020a integration into jdk.
>
> Release details can be found here:
>
> http://mm.icann.org/pipermail/tz-announce/2020-April/58.html
>
>
> Webrev: http://cr.openjdk.java.net/~kravikumar/8243
Hello,
Please review this small doc fix to the following issue:
https://bugs.openjdk.java.net/browse/JDK-8243664
Here is the diff:
---
--- old/src/java.base/share/classes/java/text/CompactNumberFormat.java
2020-04-27 09:09:14.0 -0700
+++ new/src/java.base/share/classes/java/text/Compa
Hi Kiran,
Thanks for working on this update so promptly.
The innocent renaming of America/Godthab to America/Nuuk is causing much
trouble.
Since it's a renaming, both names remain and I expected them to have the
same metadata.
So I expected the entries in TimeZoneNames.java and the translations i
Hello All,
Please review the patch for tzdata2020a integration into jdk.
Release details can be found here:
http://mm.icann.org/pipermail/tz-announce/2020-April/58.html
Webrev: http://cr.openjdk.java.net/~kravikumar/8243541/webrev.00/
Bug: https://bugs.openjdk.java.net/browse/JDK-824354
